On Fri, Apr 26, 2013 at 5:10 PM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> Good, so I'll keep sending the patches, because our users benefit from
>> the review.
>
> Just for the record, a patch sent to the list which nobody bothered
> to read does not really count as reviewed.
No, bu
Felipe Contreras writes:
> Good, so I'll keep sending the patches, because our users benefit from
> the review.
Just for the record, a patch sent to the list which nobody bothered
to read does not really count as reviewed.
You can either
(1) pace yourself when people are otherwise busy; or
On Fri, Apr 26, 2013 at 3:17 PM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
>> The importance of users changes all the time. The 15 year old kid in
>> Sao Paulo might not be important today, but he might be the single
>> most important contributor ten years from now. Hell, he might even
On Fri, Apr 26, 2013 at 3:28 PM, Ramkumar Ramachandra
wrote:
>> Reason is not a tool for appreciating art, reason is a tool for
>> discovering truth, and if when arguing you are not interested in what
>> is actually true, I'm not interested in arguing with you.
>
> There is no great truth to be d
On Fri, Apr 26, 2013 at 3:03 PM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
>> A fine way to start is to not rattle away in trivial inconsequential patches.
>
> I have something from Linus (TM) this time :)
>
> https://lkml.org/lkml/2004/12/20/255
I happen to agree with that, specially
Felipe Contreras wrote:
> If you are so keen in receiving feedback from your fellow developers,
> you should eventually send an email summarizing the issues and the
> proposal for everyone to understand.
Thanks. I'll do that in the morning.
> Reason is not a tool for appreciating art, reason is
On Fri, Apr 26, 2013 at 2:56 PM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
>> We all benefit from these patches being reviewed in the git mailing
>> list, nobody has claimed otherwise. You are making the error of
>> assuming that your review was actionable, that I should have done
>> s
Felipe Contreras wrote:
> The importance of users changes all the time. The 15 year old kid in
> Sao Paulo might not be important today, but he might be the single
> most important contributor ten years from now. Hell, he might even
> replace Junio as the maintainer.
Yes, they do. Did I say that
Felipe Contreras wrote:
> A fine way to start is to not rattle away in trivial inconsequential patches.
I have something from Linus (TM) this time :)
https://lkml.org/lkml/2004/12/20/255
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.k
On Fri, Apr 26, 2013 at 2:30 PM, Ramkumar Ramachandra
wrote:
> [completely off-topic; don't worry, we're just having a friendly chat]
>
> Felipe Contreras wrote:
>> If you are not prepared to defend your review, so are others, why to
>> you blame that on me? If you were right, you would be shown t
Ramkumar Ramachandra wrote:
> Diversity is certainly healthy, and I it would be nice to have you in
> the community. We just have to find a way to keep the conflict down.
After all, what are we asking for? Better commit messages. Why are
you making such a big deal out of it? You want diversity
Felipe Contreras wrote:
> We all benefit from these patches being reviewed in the git mailing
> list, nobody has claimed otherwise. You are making the error of
> assuming that your review was actionable, that I should have done
> something, fix the commit message I suppose, but I don't think that's
Felipe Contreras wrote:
> If you don't understand the reasoning and history behind remote-bzr,
> you might be doing a disservice to everyone by commenting at all.
Felipe, I'm trying to help. If you think my review lacked context,
you can write me a paragraph/ link me to an email and I will read i
On Fri, Apr 26, 2013 at 1:53 PM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
>> What is your objective, do you want to help this project move forward or not?
>
> Forward, please.
>
> I want a solution to this persistent problem of conflict though. And
> I presented one in my previous em
[completely off-topic; don't worry, we're just having a friendly chat]
Felipe Contreras wrote:
> If you are not prepared to defend your review, so are others, why to
> you blame that on me? If you were right, you would be shown to be
> right. Period.
Felipe, there are some things that are worth a
On Fri, Apr 26, 2013 at 4:32 AM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
> Junio C Hamano wrote:
>> I do
>> not agree with Ram at all when he says that developers are more
>> important than users, and I agree with you that the project exists
>> for users, and not for developers.
>
>
Felipe Contreras wrote:
> What is your objective, do you want to help this project move forward or not?
Forward, please.
I want a solution to this persistent problem of conflict though. And
I presented one in my previous email:
Here's my solution to the problem: maintain your project outside
gi
On Fri, Apr 26, 2013 at 7:19 AM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
>> Any sensible reviewer would be context aware, notice that this
>> is a contrib patch, and focus on behavioral changes, notice the
>> mistake I made, and point that *one* of the changes was changing the
>> beh
react accordingly when another person
attacks an opinion, which is not a big deal, and when an objective
fact is attacked, which is a big deal.
>> Other people are perfectly fine with them:
>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/?qt=author&q=fel
Felipe Contreras wrote:
> Any sensible reviewer would be context aware, notice that this
> is a contrib patch, and focus on behavioral changes, notice the
> mistake I made, and point that *one* of the changes was changing the
> behavior, at which point I would agree and reroll either without that
>
Felipe Contreras wrote:
> I am helping my fellow developers by replying to the comments they
> make when I send the patches for review. Unfortunately, the only
> developer other than you that has made any comment at all, Ramkumar
> Ramachandra, did so in a bellicose tone, but I replied to all his
>
t;
> You are the one who is missing the point. My message was about your
> patches to _any_ part of our system, not limited to remote helpers.
I still see "Re: [PATCH 1/9] remote-bzr: trivial cleanups", if we are
talking about something else, let's do so and be clear in the subjec
Felipe Contreras writes:
> You are missing my point, this is *ONE INSTANCE*. Show me another
> instance where a reviewer complained about the lack of a descriptive
> commit messages on *remote-helpers*.
You are the one who is missing the point. My message was about your
patches to _any_ part of
On Thu, Apr 25, 2013 at 5:01 PM, Junio C Hamano wrote:
> Having said that, I am more worried about wasting everybody's time
> (and this includes your time) with the impedance mismatch between
> you and the rest of us.
>
> Our standard for explaining the change (either in the log or in the
> comme
Felipe Contreras writes:
>> Three random points.
>>
>> * For this particular patch [1/9], especially because this would
>>land close to the corresponding remote-hg fixes (e.g. "has_key is
>>deprecated"), I think it is sufficient to say "port fixes from
>>corresponding remote-hg patch
On Thu, Apr 25, 2013 at 4:37 PM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> On Thu, Apr 25, 2013 at 3:30 PM, Thomas Rast wrote:
>>> Felipe Contreras writes:
>>>
But I do not care that much really. The patch is good either way, if
you don't like it, you go ahead and fix it,
Felipe Contreras writes:
> On Thu, Apr 25, 2013 at 3:30 PM, Thomas Rast wrote:
>> Felipe Contreras writes:
>>
>>> But I do not care that much really. The patch is good either way, if
>>> you don't like it, you go ahead and fix it, because I won't. I have
>>> 174 remote-helper related patches in
On Thu, Apr 25, 2013 at 3:36 PM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> But I do not care that much really. The patch is good either way, if
>> you don't like it, you go ahead and fix it, because I won't. I have
>> 174 remote-helper related patches in my queue, and nobody benefits
On Thu, Apr 25, 2013 at 3:30 PM, Thomas Rast wrote:
> Felipe Contreras writes:
>
>> But I do not care that much really. The patch is good either way, if
>> you don't like it, you go ahead and fix it, because I won't. I have
>> 174 remote-helper related patches in my queue, and nobody benefits
>>
Felipe Contreras writes:
> But I do not care that much really. The patch is good either way, if
> you don't like it, you go ahead and fix it, because I won't. I have
> 174 remote-helper related patches in my queue, and nobody benefits
> from rambling about a one liner that is obviously correct, n
Felipe Contreras writes:
> But I do not care that much really. The patch is good either way, if
> you don't like it, you go ahead and fix it, because I won't. I have
> 174 remote-helper related patches in my queue, and nobody benefits
> from rambling about a one liner that is obviously correct, n
On Thu, Apr 25, 2013 at 2:29 PM, Stefano Lattarini
wrote:
> On 04/25/2013 08:19 PM, Ramkumar Ramachandra wrote:
>>> @@ -521,7 +521,7 @@ def c_style_unescape(string):
>>> return string
>>>
>>> def parse_commit(parser):
>>> -global marks, blob_marks, bmarks, parsed_refs
>>> +global ma
On 04/25/2013 08:19 PM, Ramkumar Ramachandra wrote:
> Felipe Contreras wrote:
>> diff --git a/contrib/remote-helpers/git-remote-bzr
>> b/contrib/remote-helpers/git-remote-bzr
>> index aa7bc97..82bf7c7 100755
>> --- a/contrib/remote-helpers/git-remote-bzr
>> +++ b/contrib/remote-helpers/git-remote-
On Thu, Apr 25, 2013 at 1:19 PM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
>> diff --git a/contrib/remote-helpers/git-remote-bzr
>> b/contrib/remote-helpers/git-remote-bzr
>> index aa7bc97..82bf7c7 100755
>> --- a/contrib/remote-helpers/git-remote-bzr
>> +++ b/contrib/remote-helpers/g
Felipe Contreras wrote:
> diff --git a/contrib/remote-helpers/git-remote-bzr
> b/contrib/remote-helpers/git-remote-bzr
> index aa7bc97..82bf7c7 100755
> --- a/contrib/remote-helpers/git-remote-bzr
> +++ b/contrib/remote-helpers/git-remote-bzr
> @@ -94,7 +94,7 @@ class Marks:
> return self
Signed-off-by: Felipe Contreras
---
contrib/remote-helpers/git-remote-bzr | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-bzr
b/contrib/remote-helpers/git-remote-bzr
index aa7bc97..82bf7c7 100755
--- a/contrib/remote-helpers/git-remo
36 matches
Mail list logo
