[GitHub] [beam] thetorpedodog commented on a change in pull request #11359: [BEAM-9731] Include more detail in passert.Equals errors.

thetorpedodog commented on a change in pull request #11359: [BEAM-9731] Include more detail in passert.Equals errors. URL: https://github.com/apache/beam/pull/11359#discussion_r405972252 ## File path: sdks/go/pkg/beam/testing/passert/passert.go ## @@ -32,29 +32,6 @@

[GitHub] [beam] thetorpedodog commented on issue #11359: [BEAM-9731] Include more detail in passert.Equals errors.

thetorpedodog commented on issue #11359: [BEAM-9731] Include more detail in passert.Equals errors. URL: https://github.com/apache/beam/pull/11359#issuecomment-611343232 R: @lostluck Some notes: I chose a somewhat gawdy format for this just to make it very highly visible and

[GitHub] [beam] thetorpedodog opened a new pull request #11359: [BEAM-9731] Include more detail in passert.Equals errors.

thetorpedodog opened a new pull request #11359: [BEAM-9731] Include more detail in passert.Equals errors. URL: https://github.com/apache/beam/pull/11359 This change reworks passert.Equals to collect all of the missing and unexpected values in a single output string to make debugging

[GitHub] [beam] henryken commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata

henryken commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#issuecomment-611327100 I can help to review this as well. This is an automated message from the

[GitHub] [beam] HuangLED commented on a change in pull request #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

HuangLED commented on a change in pull request #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#discussion_r40592 ## File path: sdks/python/apache_beam/metrics/execution.py ## @@

[GitHub] [beam] steveniemitz commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation.

steveniemitz commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#issuecomment-611310160 I think you'll need

[GitHub] [beam] tvalentyn commented on a change in pull request #11092: [BEAM-9085] Fix performance regression in SyntheticSource

tvalentyn commented on a change in pull request #11092: [BEAM-9085] Fix performance regression in SyntheticSource URL: https://github.com/apache/beam/pull/11092#discussion_r405921080 ## File path: sdks/python/apache_beam/testing/synthetic_pipeline.py ## @@ -61,6 +65,35 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

lukecwik commented on a change in pull request #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#discussion_r405917573 ## File path: sdks/python/apache_beam/metrics/execution.py ## @@

[GitHub] [beam] chamikaramj commented on issue #11315: [BEAM-8889] Upgrades gcsio to 2.1.2

chamikaramj commented on issue #11315: [BEAM-8889] Upgrades gcsio to 2.1.2 URL: https://github.com/apache/beam/pull/11315#issuecomment-611288279 Run Java PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] lukecwik merged pull request #11351: [BEAM-9399] Ensure that empty messages are not flushed to handler.

lukecwik merged pull request #11351: [BEAM-9399] Ensure that empty messages are not flushed to handler. URL: https://github.com/apache/beam/pull/11351 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] lukecwik merged pull request #11356: [BEAM-9618] Mark push registration as deprecated.

lukecwik merged pull request #11356: [BEAM-9618] Mark push registration as deprecated. URL: https://github.com/apache/beam/pull/11356 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj merged pull request #11354: [BEAM-9719] Adds nose back to the base image

chamikaramj merged pull request #11354: [BEAM-9719] Adds nose back to the base image URL: https://github.com/apache/beam/pull/11354 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [x] ValueProvider support - [x] Add example usage to javadoc - [ ] Unit test for FhirIO dead letter handling - [ ] Add IT for

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [x] ValueProvider support - [ ] Unit test for FhirIO dead letter handling - [x] Add example usage to javadoc - [ ] Add IT for

[GitHub] [beam] lukecwik commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

lukecwik commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405907504 ## File path:

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405875425 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405875425 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] robertwb opened a new pull request #11358: [BEAM-9729] Runner-side bundle registration cleanup.

robertwb opened a new pull request #11358: [BEAM-9729] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358 Client-side cleanup to come later once dataflow service is up to date. Thank you for your contribution!

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405898356 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraConfig.java

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405895178 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java ## @@

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405895178 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java ## @@

[GitHub] [beam] iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405894039 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java ## @@

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405888316 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java ## @@

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405874887 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java ## @@

[GitHub] [beam] iemejia commented on issue #10546: [BEAM-9008] Add CassandraIO readAll method

iemejia commented on issue #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#issuecomment-611265311 Just for ref I opened the PR for SolrIO #11357 that introduces ReadAll there.

[GitHub] [beam] boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405892978 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -562,45 +562,45

[GitHub] [beam] boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405892978 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -562,45 +562,45

[GitHub] [beam] iemejia opened a new pull request #11357: [BEAM-7770] Add ReadAll transform for SolrIO

iemejia opened a new pull request #11357: [BEAM-7770] Add ReadAll transform for SolrIO URL: https://github.com/apache/beam/pull/11357 This follows the ReadAll pattern style introduced on HBaseIO but for DoFn, but non SDF based IOs. R: @aromanenko-dev

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405892635 ## File path:

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405890215 ## File path:

[GitHub] [beam] regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout

regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout URL: https://github.com/apache/beam/pull/11275#discussion_r40527 ## File path:

[GitHub] [beam] regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout

regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout URL: https://github.com/apache/beam/pull/11275#discussion_r405889052 ## File path:

[GitHub] [beam] regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout

regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout URL: https://github.com/apache/beam/pull/11275#discussion_r40527 ## File path:

[GitHub] [beam] KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff Integration Tests

KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff Integration Tests URL: https://github.com/apache/beam/pull/11338#discussion_r405729704 ## File path: sdks/python/apache_beam/runners/interactive/testing/integration/notebook_executor.py ## @@

[GitHub] [beam] KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff Integration Tests

KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff Integration Tests URL: https://github.com/apache/beam/pull/11338#discussion_r405754337 ## File path: sdks/python/setup.py ## @@ -222,6 +222,17 @@ def get_version(): 'ipython>=5.8.0,<8',

[GitHub] [beam] KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff Integration Tests

KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff Integration Tests URL: https://github.com/apache/beam/pull/11338#discussion_r405731238 ## File path: sdks/python/apache_beam/runners/interactive/testing/integration/screen_diff.py ## @@ -0,0

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405888316 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java ## @@

[GitHub] [beam] chamikaramj commented on issue #11354: [BEAM-9719] Adds nose back to the base image

chamikaramj commented on issue #11354: [BEAM-9719] Adds nose back to the base image URL: https://github.com/apache/beam/pull/11354#issuecomment-611259139 Run Python PreCommit This is an automated message from the Apache Git

[GitHub] [beam] chamikaramj commented on issue #11315: [BEAM-8889] Upgrades gcsio to 2.1.2

chamikaramj commented on issue #11315: [BEAM-8889] Upgrades gcsio to 2.1.2 URL: https://github.com/apache/beam/pull/11315#issuecomment-611256051 Don't think failure is related but test suite seems to be pretty flake. So will try re-run when it's more stable.

[GitHub] [beam] angoenka commented on a change in pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow …

angoenka commented on a change in pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow … URL: https://github.com/apache/beam/pull/11355#discussion_r405879963 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ##

[GitHub] [beam] angoenka commented on a change in pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow …

angoenka commented on a change in pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow … URL: https://github.com/apache/beam/pull/11355#discussion_r405880602 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ##

[GitHub] [beam] angoenka commented on a change in pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow …

angoenka commented on a change in pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow … URL: https://github.com/apache/beam/pull/11355#discussion_r405880080 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ##

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405880091 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [ ] ValueProvider support - [ ] Unit test for FhirIO dead letter handling - [ ] Add example usage to javadoc - [ ] Add IT for

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [ ] ValueProvider support - [ ] Unit test for FhirIO dead letter handling - [ ] Add example usage to javadoc - [ ] Benchmark / load

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405878498 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405874887 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java ## @@

[GitHub] [beam] lukecwik commented on issue #11351: [BEAM-9399] Ensure that empty messages are not flushed to handler.

lukecwik commented on issue #11351: [BEAM-9399] Ensure that empty messages are not flushed to handler. URL: https://github.com/apache/beam/pull/11351#issuecomment-611249407 Run Java PreCommit This is an automated message

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405875425 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] Hannah-Jiang merged pull request #10952: [Beam-9063]update documentation

Hannah-Jiang merged pull request #10952: [Beam-9063]update documentation URL: https://github.com/apache/beam/pull/10952 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405874887 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java ## @@

[GitHub] [beam] lukecwik commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

lukecwik commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405873264 ## File path:

[GitHub] [beam] iemejia commented on issue #10767: Document Beam Schemas

iemejia commented on issue #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#issuecomment-611246436 @reuvenlax sorry for the slow reaction, I only will be able to take a look a deep look after friday, if you can wait I will do a second round otherwise maybe is

[GitHub] [beam] iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405864840 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405869911 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405865873 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405867511 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405870149 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java ## @@

[GitHub] [beam] iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

iemejia commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#discussion_r405866030 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ##

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [ ] ValueProvider support - [ ] Unit test for FhirIO dead letter handling - [ ] Add example usage to javadoc - [ ] Benchmark / load

[GitHub] [beam] chamikaramj commented on issue #11354: Guards for nose package

chamikaramj commented on issue #11354: Guards for nose package URL: https://github.com/apache/beam/pull/11354#issuecomment-611245099 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] ibzib closed pull request #11052: [BEAM-9446] Add missing parallelism and execution mode args.

ibzib closed pull request #11052: [BEAM-9446] Add missing parallelism and execution mode args. URL: https://github.com/apache/beam/pull/11052 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] ibzib commented on issue #11052: [BEAM-9446] Add missing parallelism and execution mode args.

ibzib commented on issue #11052: [BEAM-9446] Add missing parallelism and execution mode args. URL: https://github.com/apache/beam/pull/11052#issuecomment-611244971 This PR is obsolete since #11189 is merged. This is an

[GitHub] [beam] lukecwik commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

lukecwik commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405870539 ## File path:

[GitHub] [beam] amaliujia commented on issue #11282: [DO NOT MERGE] Run Python RC Validation Tests

amaliujia commented on issue #11282: [DO NOT MERGE] Run Python RC Validation Tests URL: https://github.com/apache/beam/pull/11282#issuecomment-611243219 Run Python ReleaseCandidate This is an automated message from the

[GitHub] [beam] ibzib commented on issue #11353: [BEAM-9726] Make region optional for non-service runner.

ibzib commented on issue #11353: [BEAM-9726] Make region optional for non-service runner. URL: https://github.com/apache/beam/pull/11353#issuecomment-611243435 R: @aaltay @youngoli This is an automated message from the

[GitHub] [beam] ibzib commented on issue #11353: [BEAM-9726] Make region optional for non-service runner.

ibzib commented on issue #11353: [BEAM-9726] Make region optional for non-service runner. URL: https://github.com/apache/beam/pull/11353#issuecomment-611243023 Flakes: - Java BEAM-8035 - Python BEAM-9119 This is an

[GitHub] [beam] chamikaramj commented on issue #11354: Guards for nose package

chamikaramj commented on issue #11354: Guards for nose package URL: https://github.com/apache/beam/pull/11354#issuecomment-611238138 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] lukecwik commented on a change in pull request #11038: [BEAM-7746] More typing fixes

lukecwik commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r405860027 ## File path: sdks/python/apache_beam/transforms/core.py ## @@ -1300,12 +1300,13 @@ def to_runner_api_parameter(self,

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405855696 ## File path:

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405831920 ## File path:

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

TheNeuralBit commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405823916 ## File path:

[GitHub] [beam] robertwb merged pull request #11328: [BEAM-9618] Java SDK worker support for pulling bundle descriptors.

robertwb merged pull request #11328: [BEAM-9618] Java SDK worker support for pulling bundle descriptors. URL: https://github.com/apache/beam/pull/11328 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] y1chi commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow …

y1chi commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow … URL: https://github.com/apache/beam/pull/11355#issuecomment-611229442 R: @angoenka This is an automated message from

[GitHub] [beam] pabloem commented on issue #11314: [BEAM-9562] Send Timers over Data Channel as Elements

pabloem commented on issue #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#issuecomment-611229498 I'm sorry. I am havinhg a heavy headache. I'll bow out. @robertwb can you review fn_runner.py and siblings?

[GitHub] [beam] y1chi opened a new pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow …

y1chi opened a new pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow … URL: https://github.com/apache/beam/pull/11355 …runner v2. **Please** add a meaningful description for your change here Thank you for

[GitHub] [beam] udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes

udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r405852662 ## File path: sdks/python/apache_beam/transforms/core.py ## @@ -1300,12 +1300,13 @@ def to_runner_api_parameter(self,

[GitHub] [beam] chamikaramj opened a new pull request #11354: Guards for nose package

chamikaramj opened a new pull request #11354: Guards for nose package URL: https://github.com/apache/beam/pull/11354 DO NOT SUBMIT Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] ibzib opened a new pull request #11353: [BEAM-9726] Make region optional for non-service runner.

ibzib opened a new pull request #11353: [BEAM-9726] Make region optional for non-service runner. URL: https://github.com/apache/beam/pull/11353 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this

[GitHub] [beam] lukecwik commented on issue #11328: [BEAM-9618] Java SDK worker support for pulling bundle descriptors.

lukecwik commented on issue #11328: [BEAM-9618] Java SDK worker support for pulling bundle descriptors. URL: https://github.com/apache/beam/pull/11328#issuecomment-611214335 sgtm This is an automated message from the Apache

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-611213022 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-611213197 Java PostCommit is probably our slowest suite of all, but once it runs we should be good to go

[GitHub] [beam] udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes

udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r405835011 ## File path: sdks/python/apache_beam/coders/coders.py ## @@ -387,8 +387,11 @@ def register_structured_urn(urn, cls):

[GitHub] [beam] udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes

udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r405835011 ## File path: sdks/python/apache_beam/coders/coders.py ## @@ -387,8 +387,11 @@ def register_structured_urn(urn, cls):

[GitHub] [beam] robertwb merged pull request #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.

robertwb merged pull request #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags. URL: https://github.com/apache/beam/pull/11283 This is an automated message from the Apache Git Service. To

[GitHub] [beam] robertwb commented on issue #11328: [BEAM-9618] Java SDK worker support for pulling bundle descriptors.

robertwb commented on issue #11328: [BEAM-9618] Java SDK worker support for pulling bundle descriptors. URL: https://github.com/apache/beam/pull/11328#issuecomment-611209675 Thanks, I'll try to R: @lukecwik you next time. I'll clean up RegisterHandler in a follow-up, but wanted to

[GitHub] [beam] pabloem commented on issue #11182: [BEAM-9650] Add PeriodicImpulse Transform and slowly changing side input documentation

pabloem commented on issue #11182: [BEAM-9650] Add PeriodicImpulse Transform and slowly changing side input documentation URL: https://github.com/apache/beam/pull/11182#issuecomment-611209492 LGTM. It would be good to get a tech writer editor for the documentation. Thanks!

[GitHub] [beam] robertwb commented on a change in pull request #11328: [BEAM-9618] Java SDK worker support for pulling bundle descriptors.

robertwb commented on a change in pull request #11328: [BEAM-9618] Java SDK worker support for pulling bundle descriptors. URL: https://github.com/apache/beam/pull/11328#discussion_r405831616 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java

[GitHub] [beam] rohdesamuel commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.

rohdesamuel commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags. URL: https://github.com/apache/beam/pull/11283#issuecomment-611207545 > @rohdesamuel is this good to go? LGTM, sorry I thought you had the ball.

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405824290 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -1088,6

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405817317 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -562,45 +562,45

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405816460 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -562,45 +562,45

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405826837 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -846,6 +870,30

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405815160 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -562,45 +562,45

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405817899 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -611,7 +611,7

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r405825392 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -846,6 +870,30

[GitHub] [beam] jaketf commented on a change in pull request #11339: [BEAM-9468] [WIP] Fhir io

jaketf commented on a change in pull request #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#discussion_r405824473 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java ## @@ -0,0

[GitHub] [beam] lukecwik commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation.

lukecwik commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#issuecomment-611200240 trigger tests This is an automated message from the Apache Git

[GitHub] [beam] lostluck merged pull request #11352: Update session.go (typofix)

lostluck merged pull request #11352: Update session.go (typofix) URL: https://github.com/apache/beam/pull/11352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout

regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout URL: https://github.com/apache/beam/pull/11275#discussion_r405810674 ## File path:

  1   2   3   >