jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1776642321
##
datafusion/expr-common/src/columnar_value.rs:
##
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single
jayzhan211 commented on PR #12631:
URL: https://github.com/apache/datafusion/pull/12631#issuecomment-2376350199
I have some suggestion
1. It would be nice if there is a reproducible example so we could find out
why and where metadata loss. It could also avoid breaking your case again if w
AnthonyZhOon commented on issue #12555:
URL: https://github.com/apache/datafusion/issues/12555#issuecomment-2376331113
Finished being able to derive Debug on SessionStateBuilder #12632 but I
believe it still needs to implement formatting to be more useful
--
This is an automated message f
notfilippo commented on issue #12622:
URL: https://github.com/apache/datafusion/issues/12622#issuecomment-2376210779
I would like to organise a call so we can discuss the plan of action of this
epic.
cc @alamb , @findepi , @jayzhan211 , @ozankabak and anyone else interested
in this e
AnthonyZhOon opened a new pull request, #12632:
URL: https://github.com/apache/datafusion/pull/12632
## Which issue does this PR close?
Progress on #12555
## Rationale for this change
To make configuration easier to use by providing debug output.
## What changes are i
AnthonyZhOon commented on PR #12632:
URL: https://github.com/apache/datafusion/pull/12632#issuecomment-2376298842
Needs the `api-change` tag. I'm also fine with splitting this PR into
smaller ones
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
mesejo commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1776672713
##
datafusion/expr/src/expr_schema.rs:
##
@@ -150,21 +150,22 @@ impl ExprSchemable for Expr {
.collect::>>()?;
// verify tha
jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1776729857
##
datafusion/expr-common/src/columnar_value.rs:
##
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single
jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1776729857
##
datafusion/expr-common/src/columnar_value.rs:
##
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single
milenkovicm commented on issue #12518:
URL: https://github.com/apache/datafusion/issues/12518#issuecomment-2376226337
It does look good, @Eason0729.
maybe @alamb and @comphead can give you better advice than me when they get
some time
--
This is an automated message from the Apache Gi
jonahgao commented on issue #12598:
URL: https://github.com/apache/datafusion/issues/12598#issuecomment-2376225312
> Is the right approach to close this issue after opening a new one against
`arrow-rs`?
I think we can keep it open and wait for an upstream fix.
--
This is an automat
jayzhan211 commented on issue #12622:
URL: https://github.com/apache/datafusion/issues/12622#issuecomment-2376262420
I suggest to propose the plan directly, since it requires thinking to
response, maybe not be that efficiently to work in a call synchronously. And it
would be more open to ra
jayzhan211 commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1776633248
##
datafusion/expr/src/expr_schema.rs:
##
@@ -150,21 +150,22 @@ impl ExprSchemable for Expr {
.collect::>>()?;
// verify
AnthonyZhOon commented on PR #12632:
URL: https://github.com/apache/datafusion/pull/12632#issuecomment-2376394124
Feel like not adding the derive Debug for `SessionStateBuilder` for now,
this is the current output of a
`SessionStateBuilder::new().with_default_features()`
[debug_session
jayzhan211 commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1776693550
##
datafusion/expr/src/expr_schema.rs:
##
@@ -150,21 +150,22 @@ impl ExprSchemable for Expr {
.collect::>>()?;
// verify
Eason0729 commented on issue #12518:
URL: https://github.com/apache/datafusion/issues/12518#issuecomment-2376409360
Okay, then I will remove thing that doesn't belong to pull request and
submit pull request.
--
This is an automated message from the Apache Git Service.
To respond to the me
jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1776701019
##
datafusion/expr-common/src/columnar_value.rs:
##
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single
jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1776701019
##
datafusion/expr-common/src/columnar_value.rs:
##
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single
jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1776705698
##
datafusion/expr-common/src/columnar_value.rs:
##
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single
jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1776705698
##
datafusion/expr-common/src/columnar_value.rs:
##
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single
mhilton opened a new issue, #12633:
URL: https://github.com/apache/datafusion/issues/12633
### Describe the bug
`NestedLoopJoinExec` (really `NestedLoopJoinStream`) produces one output
batch for each probe side input batch. However it is possible for each row of
build-side input to p
jayzhan211 commented on code in PR #12623:
URL: https://github.com/apache/datafusion/pull/12623#discussion_r1776517883
##
datafusion/physical-plan/src/aggregates/group_values/group_value_row.rs:
##
@@ -121,37 +145,64 @@ impl ArrayRowEq for
PrimitiveGroupValueBuilder {
}
jayzhan211 commented on code in PR #12623:
URL: https://github.com/apache/datafusion/pull/12623#discussion_r1776517883
##
datafusion/physical-plan/src/aggregates/group_values/group_value_row.rs:
##
@@ -121,37 +145,64 @@ impl ArrayRowEq for
PrimitiveGroupValueBuilder {
}
jayzhan211 commented on code in PR #12623:
URL: https://github.com/apache/datafusion/pull/12623#discussion_r1776517883
##
datafusion/physical-plan/src/aggregates/group_values/group_value_row.rs:
##
@@ -121,37 +145,64 @@ impl ArrayRowEq for
PrimitiveGroupValueBuilder {
}
mesejo commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1776523912
##
datafusion/functions/src/encoding/inner.rs:
##
@@ -49,17 +48,8 @@ impl Default for EncodeFunc {
impl EncodeFunc {
pub fn new() -> Self {
-use Dat
Lordworms commented on PR #12614:
URL: https://github.com/apache/datafusion/pull/12614#issuecomment-2376172097
I didn't realize that there is already a function called get_field which has
similar usage to struct_extract 😅
--
This is an automated message from the Apache Git Service.
To res
goldmedal opened a new issue, #12637:
URL: https://github.com/apache/datafusion/issues/12637
### Describe the bug
While working on #12415, I found the `LIKE` and `ILIKE` behavior differs
between `StringView` and other string types. Given the following data and SQL:
```sql
DataFu
palaska opened a new pull request, #1062:
URL: https://github.com/apache/datafusion-ballista/pull/1062
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing chang
palaska commented on PR #1059:
URL:
https://github.com/apache/datafusion-ballista/pull/1059#issuecomment-2377374102
> Would it make sense just to upgrade to DF 41 in this PR?
I will try
> Would it make sense just to upgrade to DF 41 in this PR?
Raised a separate PR that
mesejo commented on code in PR #880:
URL: https://github.com/apache/datafusion-python/pull/880#discussion_r1777392689
##
examples/python-udwf.py:
##
@@ -0,0 +1,270 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See th
mhilton opened a new pull request, #12634:
URL: https://github.com/apache/datafusion/pull/12634
## Which issue does this PR close?
Closes #12633.
## Rationale for this change
Some joins use an excessive amount of memory due to creating very large
record b
AnthonyZhOon commented on PR #12632:
URL: https://github.com/apache/datafusion/pull/12632#issuecomment-2376741572
Now the impl Debug for `SessionStateBuilder` resembles that of
`SessionState` but includes all fields. Also grouped fields by relevance
--
This is an automated message from th
findepi commented on issue #12635:
URL: https://github.com/apache/datafusion/issues/12635#issuecomment-2376910852
FYI: I am doing some experiments how this could look like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
andygrove commented on issue #872:
URL:
https://github.com/apache/datafusion-python/issues/872#issuecomment-2376891574
As a formality, as part of the ASF IP clearance process, I must remind
active committers that they are responsible for ensuring that a Corporate CLA
is recorded if such is
comphead commented on code in PR #12629:
URL: https://github.com/apache/datafusion/pull/12629#discussion_r1777275215
##
datafusion/functions/src/string/common.rs:
##
@@ -35,19 +35,26 @@ use datafusion_expr::ColumnarValue;
/// Append a new view to the views buffer with the giv
progval commented on PR #12593:
URL: https://github.com/apache/datafusion/pull/12593#issuecomment-2376956688
> I wonder if we could change the "automatically load page index if needed"
to "error if page index is needed but it is not loaded" 🤔 That might be a less
surprising behavior
notfilippo commented on issue #12622:
URL: https://github.com/apache/datafusion/issues/12622#issuecomment-2377126283
> We should make it a goal that physical planning also abstracts over
physical representation of individual batches.
> We should also make it a goal that function are expre
findepi opened a new issue, #12635:
URL: https://github.com/apache/datafusion/issues/12635
### Is your feature request related to a problem or challenge?
### Verbosity
Currently implementing a scalar function is a pretty involved process. For
example a simple function calculati
findepi commented on issue #12635:
URL: https://github.com/apache/datafusion/issues/12635#issuecomment-2376798706
cc @alamb, @andygrove, @jayzhan211, @ozankabak, @notfilippo, @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alamb closed pull request #12613: implement kurtosis udaf
URL: https://github.com/apache/datafusion/pull/12613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
alamb commented on PR #12613:
URL: https://github.com/apache/datafusion/pull/12613#issuecomment-2377026297
Closing as this PR is going to be retargeted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
alamb commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1777112205
##
datafusion/expr/src/expr_schema.rs:
##
@@ -150,21 +150,22 @@ impl ExprSchemable for Expr {
.collect::>>()?;
// verify that
viirya commented on PR #972:
URL: https://github.com/apache/datafusion-comet/pull/972#issuecomment-2377760621
cc @huaxingao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
viirya opened a new pull request, #972:
URL: https://github.com/apache/datafusion-comet/pull/972
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes test
viirya opened a new issue, #974:
URL: https://github.com/apache/datafusion-comet/issues/974
### Describe the bug
This is related to #973. After applying the fix, the test we run locally
with Iceberg table with deleted rows fails on incorrect query result.
It is because Iceberg
viirya opened a new issue, #973:
URL: https://github.com/apache/datafusion-comet/issues/973
### Describe the bug
Integrating Comet with Iceberg internally gets the following error if there
are deleted rows in the Iceberg table:
```
org.apache.comet.CometNativeException: Inva
comphead merged PR #975:
URL: https://github.com/apache/datafusion-comet/pull/975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
Michael-J-Ward commented on code in PR #880:
URL: https://github.com/apache/datafusion-python/pull/880#discussion_r1777685386
##
python/datafusion/udf.py:
##
@@ -246,3 +246,229 @@ def udaf(
state_type=state_type,
volatility=volatility,
)
+
+
+c
Michael-J-Ward commented on code in PR #880:
URL: https://github.com/apache/datafusion-python/pull/880#discussion_r1773701467
##
docs/source/user-guide/common-operations/udf-and-udfa.rst:
##
@@ -18,8 +18,21 @@
User Defined Functions
==
-DataFusion provide
Michael-J-Ward commented on code in PR #880:
URL: https://github.com/apache/datafusion-python/pull/880#discussion_r1777657146
##
python/datafusion/udf.py:
##
@@ -246,3 +246,229 @@ def udaf(
state_type=state_type,
volatility=volatility,
)
+
+
+c
comphead commented on PR #12634:
URL: https://github.com/apache/datafusion/pull/12634#issuecomment-2377950999
@mhilton would be that possible to create a unit test reproducing the
problem? This will also be important to prevent regression. The repro can be on
small batch size up to 5
--
mesejo commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r127942
##
datafusion/expr/src/expr_schema.rs:
##
@@ -150,21 +150,22 @@ impl ExprSchemable for Expr {
.collect::>>()?;
// verify tha
alamb commented on issue #12635:
URL: https://github.com/apache/datafusion/issues/12635#issuecomment-2377975313
> Currently DataFusion functions are singletons plugged into the execution
engine. They have no way to store and reuse buffers or compiled regular
expressions, etc.
here i
alamb commented on PR #12623:
URL: https://github.com/apache/datafusion/pull/12623#issuecomment-2377959248
> Marking draft until I have benchmark numbers
The benchmark numbers look good -- now I just need to debug one test and I
will put this up for review
--
This is an automated m
alamb commented on issue #12635:
URL: https://github.com/apache/datafusion/issues/12635#issuecomment-2377975178
I think the idea of making it easier to write functions that include
specialized implementations for different types is a great idea. This would
likely both make our code faster (
justahuman1 commented on issue #742:
URL:
https://github.com/apache/datafusion-comet/issues/742#issuecomment-2377988737
Hi @adi-kmt are you still working on this? I can take if not. I already have
the changes ready, let me know, thanks
https://github.com/justahuman1/datafusion-comet
Michael-J-Ward commented on code in PR #880:
URL: https://github.com/apache/datafusion-python/pull/880#discussion_r160825
##
docs/source/user-guide/common-operations/udf-and-udfa.rst:
##
@@ -57,30 +126,122 @@ Additionally the
:py:func:`~datafusion.udf.AggregateUDF.udaf` fun
findepi commented on issue #12644:
URL: https://github.com/apache/datafusion/issues/12644#issuecomment-2378520646
cc @alamb, @andygrove, @jayzhan211, @ozankabak, @notfilippo, @comphead,
@kylebarron, @yukkit, @sunchao, @Folyd, @wjones127, @Xuanwo, @sadboy, @milevin
--
This is an automated
alamb commented on code in PR #12629:
URL: https://github.com/apache/datafusion/pull/12629#discussion_r100951
##
datafusion/functions/src/string/common.rs:
##
@@ -35,19 +35,26 @@ use datafusion_expr::ColumnarValue;
/// Append a new view to the views buffer with the given
alamb commented on code in PR #12632:
URL: https://github.com/apache/datafusion/pull/12632#discussion_r1777693960
##
datafusion/core/src/catalog_common/information_schema.rs:
##
@@ -70,20 +71,11 @@ impl InformationSchemaProvider {
}
}
-#[derive(Clone)]
+#[derive(Clone, D
alamb commented on issue #12637:
URL: https://github.com/apache/datafusion/issues/12637#issuecomment-2377893100
> I'm not really sure if the behavior of StringView is expected 🤔 but I
think their behavior should be consistent.
> When the input value is NULL, string type will return NU
alamb commented on issue #12604:
URL: https://github.com/apache/datafusion/issues/12604#issuecomment-2377859743
> let Expr carry the type explicitly (that would be "logical type"
I think this is the
> correct, unless get_type is called more than once. optimizer rules ma
alamb commented on code in PR #12614:
URL: https://github.com/apache/datafusion/pull/12614#discussion_r112094
##
datafusion/sql/src/expr/identifier.rs:
##
@@ -142,9 +135,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
}
goldmedal commented on issue #12637:
URL: https://github.com/apache/datafusion/issues/12637#issuecomment-2378241398
> I think if the input is null, the string view should also return null
Thanks! I updated the expected behavior 👍
--
This is an automated message from the Apache Git
Rachelint commented on code in PR #12332:
URL: https://github.com/apache/datafusion/pull/12332#discussion_r1777916707
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -1024,11 +1017,7 @@ impl GroupedHashAggregateStream {
/// Note: currently spilling is not supp
Michael-J-Ward merged PR #882:
URL: https://github.com/apache/datafusion-python/pull/882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
Michael-J-Ward merged PR #881:
URL: https://github.com/apache/datafusion-python/pull/881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb commented on code in PR #12623:
URL: https://github.com/apache/datafusion/pull/12623#discussion_r145457
##
datafusion/physical-plan/src/aggregates/group_values/group_value_row.rs:
##
@@ -121,37 +145,64 @@ impl ArrayRowEq for
PrimitiveGroupValueBuilder {
}
alamb commented on issue #12518:
URL: https://github.com/apache/datafusion/issues/12518#issuecomment-2377960672
PR in sqlparser: https://github.com/sqlparser-rs/sqlparser-rs/pull/1444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
andygrove commented on code in PR #12626:
URL: https://github.com/apache/datafusion/pull/12626#discussion_r1777822954
##
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##
@@ -704,6 +730,7 @@ async fn roundtrip_logical_plan_distinct_on() -> Result<()>
{
let plan =
palaska commented on code in PR #12626:
URL: https://github.com/apache/datafusion/pull/12626#discussion_r1777824338
##
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##
@@ -704,6 +730,7 @@ async fn roundtrip_logical_plan_distinct_on() -> Result<()>
{
let plan = ct
akurmustafa opened a new pull request, #12639:
URL: https://github.com/apache/datafusion/pull/12639
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
Minor changes in the Sort code to impr
jayzhan211 commented on code in PR #12640:
URL: https://github.com/apache/datafusion/pull/12640#discussion_r1778036865
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -1004,9 +1004,13 @@ impl GroupedHashAggregateStream {
/// Updates skip aggregation probe stat
comphead opened a new pull request, #975:
URL: https://github.com/apache/datafusion-comet/pull/975
## Which issue does this PR close?
Closes #.
## Rationale for this change
Adding more documentation interlinks and Comet docs link from the main page
alamb commented on PR #12601:
URL: https://github.com/apache/datafusion/pull/12601#issuecomment-2377888909
Sorry for misleading you @OussamaSaoudi -- it will be great when 1.80 is
released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
comphead commented on issue #12635:
URL: https://github.com/apache/datafusion/issues/12635#issuecomment-2378116102
Thanks @findepi I think this process go through iterations, and easier than
was before but still far from perfect.
The ScalarUDFImpl common trait is already a huge help,
andygrove commented on PR #1059:
URL:
https://github.com/apache/datafusion-ballista/pull/1059#issuecomment-2378345468
I'm fine with pinning to a revision of DataFusion once your PR is merged
over there.
--
This is an automated message from the Apache Git Service.
To respond to the messag
doupache commented on code in PR #12643:
URL: https://github.com/apache/datafusion/pull/12643#discussion_r1777970052
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -1052,12 +1052,16 @@ fn binary_to_string_coercion(
match (lhs_type, rhs_type) {
(Binary
doupache commented on PR #12643:
URL: https://github.com/apache/datafusion/pull/12643#issuecomment-2378348112
Without these change , hit_partitioned will failed at query 20
```
Q20: SELECT COUNT(*) FROM hits WHERE "URL" LIKE '%google%';
Error: Context("type_coercion", Plan("Ther
YjyJeff opened a new pull request, #12642:
URL: https://github.com/apache/datafusion/pull/12642
## Which issue does this PR close?
Closes https://github.com/apache/datafusion/issues/12641.
## Rationale for this change
## What changes are included in this P
akurmustafa commented on issue #12611:
URL: https://github.com/apache/datafusion/issues/12611#issuecomment-2378127718
In datafusion, target_partition argument doesn't necessarily increase
partition count each time. If DataFusion thinks that executing the query in
single partition is better
OussamaSaoudi commented on issue #12607:
URL: https://github.com/apache/datafusion/issues/12607#issuecomment-2378423926
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
andygrove merged PR #12626:
URL: https://github.com/apache/datafusion/pull/12626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
jayzhan211 commented on code in PR #12640:
URL: https://github.com/apache/datafusion/pull/12640#discussion_r1778034315
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -1004,9 +1004,13 @@ impl GroupedHashAggregateStream {
/// Updates skip aggregation probe stat
jayzhan211 commented on code in PR #12640:
URL: https://github.com/apache/datafusion/pull/12640#discussion_r1778034315
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -1004,9 +1004,13 @@ impl GroupedHashAggregateStream {
/// Updates skip aggregation probe stat
jayzhan211 commented on code in PR #12640:
URL: https://github.com/apache/datafusion/pull/12640#discussion_r1778036865
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -1004,9 +1004,13 @@ impl GroupedHashAggregateStream {
/// Updates skip aggregation probe stat
jayzhan211 commented on code in PR #12640:
URL: https://github.com/apache/datafusion/pull/12640#discussion_r1778036865
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -1004,9 +1004,13 @@ impl GroupedHashAggregateStream {
/// Updates skip aggregation probe stat
alamb commented on PR #12620:
URL: https://github.com/apache/datafusion/pull/12620#issuecomment-2377963503
Thanks @comphead and @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
alamb merged PR #12620:
URL: https://github.com/apache/datafusion/pull/12620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
devanbenz commented on issue #6906:
URL: https://github.com/apache/datafusion/issues/6906#issuecomment-2378010992
Finally got around to trying out a little POC locally. I'm getting much
better results by just storing the state as `Vec` it's very much not
polished at this moment in time but
alamb commented on code in PR #12332:
URL: https://github.com/apache/datafusion/pull/12332#discussion_r147273
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -1024,11 +1017,7 @@ impl GroupedHashAggregateStream {
/// Note: currently spilling is not supporte
Rachelint opened a new pull request, #12640:
URL: https://github.com/apache/datafusion/pull/12640
## Which issue does this PR close?
Closes #.
## Rationale for this change
I found an partial assertion check may be needed in skip aggregation probe,
this pr added it.
OussamaSaoudi commented on PR #12601:
URL: https://github.com/apache/datafusion/pull/12601#issuecomment-2378282642
np @alamb :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
Rachelint commented on code in PR #12332:
URL: https://github.com/apache/datafusion/pull/12332#discussion_r1777926331
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -1024,11 +1017,7 @@ impl GroupedHashAggregateStream {
/// Note: currently spilling is not supp
alamb commented on issue #12555:
URL: https://github.com/apache/datafusion/issues/12555#issuecomment-2377868821
> Finished being able to derive Debug on SessionStateBuilder
https://github.com/apache/datafusion/pull/12632 but I believe it still needs to
implement formatting to be more useful
alamb commented on PR #12620:
URL: https://github.com/apache/datafusion/pull/12620#issuecomment-2377883917
Thank you for the review @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb commented on PR #12626:
URL: https://github.com/apache/datafusion/pull/12626#issuecomment-2377910598
I took the liberty of fixing the `clippy` error and pushing the fix to this
branch to get CI to pass (example of [failing
CI](https://github.com/apache/datafusion/actions/runs/11039247
Lordworms commented on code in PR #12614:
URL: https://github.com/apache/datafusion/pull/12614#discussion_r168711
##
datafusion/sql/src/expr/identifier.rs:
##
@@ -142,9 +135,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
}
Michael-J-Ward opened a new pull request, #884:
URL: https://github.com/apache/datafusion-python/pull/884
# Rationale for this change
These tests are now passing, so I've removed the `xfail` from them.
# Are there any user-facing changes?
No.
--
This is an automated message f
Rachelint commented on code in PR #12640:
URL: https://github.com/apache/datafusion/pull/12640#discussion_r1777945500
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -1004,9 +1004,13 @@ impl GroupedHashAggregateStream {
/// Updates skip aggregation probe state
1 - 100 of 122 matches
Mail list logo
