Merged #952 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/952#event-10680086535
You are receiving this because you are subscribed to this thread.
Message ID:
Yeah let's get it in not to have other people waste time trying to "fix" it.
This won't remove all deprecation warnings (the plugin still uses
`gtk_vbox_new()`) though. I can very easily fix that now we depend on GTK3
anyway though, but that can be for later.
--
Reply to this email directly
@b4n approved this pull request.
LGTM (not tested)
Indeed the check is wrong in many aspects -- event 0.0.2 would be < then 1.38.1
Also, it uses `GEANY_VERSION`, which is a compile-time thing, so better update
your update checker! It could benefit from Geany exposing
@b4n approved this pull request.
WFM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3599#pullrequestreview-1682534844
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/
' -i geany_private.rc
sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac
+sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
@eht16 if you move those out of the way:
* */usr/share/icons/Adwaita/48x48/legacy/edit-clear-all.png*
* */usr/share/icons/Adwaita/48x48/legacy/edit-clear.png*
*
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
FWIW I just tried in Bookworm VM as well, and was shocked that @eht16 is not
crazy and it *does* look like this, be it on Wayland or X11… playing a tad with
it, it's due to the Adwaita icons, if I use that on
See #2398
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2906#issuecomment-1765889149
You are receiving this because you are subscribed to this thread.
Message ID:
> Yeah, will happily add it once it is merged 爛
It just got in :wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1765856443
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
I'll try and grab my girlfriend's Bullseye (yeah, not updated yet…) which has
whatever version of GNOME shell that came with it, and see if it looks more
"normal". If it does, I'll take the screenshots later
Merged #3049 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#event-10674470211
You are receiving this because you are subscribed to this thread.
Message ID:
As @techee (IIRC) mentioned somewhere, the *Editor→Display* tab is getting
crowded to the point it makes the prefs window grow. I suggest moving the
*Virtual spaces* section to the *Editor→Features* tab that not only has room,
but also seems more fitting to me – it's not a display thing, it's
@b4n approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#pullrequestreview-1681065041
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
Looks fairly useful and simple enough :+1:
Apart from my inline comments, LGTM and WFM.
> + gtk_container_add(GTK_CONTAINER(menu), item);
+ gtk_menu_reorder_child(GTK_MENU(menu), item, 0);
```suggestion
188038a06a1050308fd7621f11147883d7e5b8fc extended the formatting options, but a
blooper made it effectively ignore the language-specific rules, always using
the default one. This affects formatting for Go, Pascal and Python, as well as
introducing memory leaks for those.
You can view, comment
@b4n commented on this pull request.
> {
- if ((NULL == fgets(buf, BUFSIZ, fp)) || ('\0' == *buf))
- return FALSE;
- }
- while (strncmp(buf, "!_TAG_", 6) == 0); /* skip !_TAG_ lines */
+ TMTagType type;
+ TMTag
@b4n approved this pull request.
Apart the small doc changes, LGTM. Limited testing shows it works nicely,
including mixed languages in a tags file. Older tags files I had laying around
using either Pipe or Tagmanager format still seemed to work as usual. I didn't
have any older ctags tags
@b4n requested changes on this pull request.
First pass only based on *code* review, no actual testing yet.
> + TMParserType lang =
> tm_ctags_get_named_lang(value);
+ if (lang >= 0)
+ tag->lang =
Merged #3316 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#event-10658414985
You are receiving this because you are subscribed to this thread.
Message ID:
I added a few minor changes, including a small behavioral one: the goto popup
is again positioned at the mouse if triggered with it, which makes it slightly
better for that use case.
--
Reply to this email directly or view it on GitHub:
@b4n approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#pullrequestreview-1678848601
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 3 commits.
869606ee1427b3611d01ee37c4811942241bb320 Pass the event to
gtk_menu_popup_at_pointer() when possible
705dc3c8eb39c43e54daf171811b412d6eaa5032 Use gtk_menu_popup_at_pointer() in
filebrowser as well
d10cfb503d30ee9bb7848f171dc857e2e90f0de5 Position goto popup at the
@b4n commented on this pull request.
> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/
' -i geany_private.rc
sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac
+sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build
What about simply adding a `q` command after the first replacement so only that
one is handled?
Le 15 octobre 2023 10:05:04 GMT+02:00, "Enrico Tröger" ***@***.***> a écrit :
>@eht16 commented on this pull request.
>
>
>
>> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^
@b4n approved this pull request.
You gotta do what you gotta do I guess
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3600#pullrequestreview-1678012613
You are receiving this because you are subscribed to this thread.
Message ID:
Closing in favor to #3597.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1762816343
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3578.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#event-10653093939
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3424 as completed via #3597.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3424#event-10653091225
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3597 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3597#event-10653091149
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #1280 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1280#event-10648933358
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #1279 as completed via #1280.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1279#event-10648933493
You are receiving this because you are subscribed to this thread.
Message ID:
> It's actually kind of surprising that it works now because
> `SCI_POINTXFROMPOSITION` didn't work when I removed `SCI_SETFIRSTVISIBLELINE`
> in front of the size request and moved it behind - so
> `SCI_POINTXFROMPOSITION` works only for the displayed editor area but in this
> case it isn't
@b4n approved this pull request.
LGTM.
I don't understand what's actually going on, especially as from my tests it
seems to work alright without this for lines <= 182 for me (yes, that feels
random). Changes on later lines are stuck starting at line 182…
Anyway, this works and shouldn't cause
> Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of
> new Scintilla API.
>
> Is this OK?
It is, especially as I just merged #1281 which also uses newer API :smile:
--
Reply to this email directly or view it on GitHub:
Thanks! I didn't see it behave so badly as your screenshot, but it also looks
weird if the inline option is enabled, so disabling it altogether in the popup
seems the way to go -- and no, we don't need it anyway :)
--
Reply to this email directly or view it on GitHub:
Merged #1281 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1281#event-10648370202
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
Thanks a lot for debugging this up to that point! I somehow didn't notice this
until fairly recently, and was puzzled (and frightened) at what it could be,
yet didn't have time to dig in. And now I see you did, yay!
I don't see a problem re-asking for the
@b4n commented on this pull request.
> @@ -878,6 +878,10 @@ get_widget_for_buf_range (GeanyDocument *doc,
MIN (width + 2, alloc.width),
MIN (height + 1, alloc.height));
+ /* Size request seems to scroll Scintilla view so we
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
I guess I feel like the popup should be under the letter the caret is at (not
sure what are the real differences
@b4n pushed 1 commit.
3498fe12a3be953511b810e568991e4149f2613a Fix popup position on a wrapping
corner case
--
View it on GitHub:
https://github.com/geany/geany/pull/3316/files/4a2999c18e2db59bb40b90ad6453732a2596a316..3498fe12a3be953511b810e568991e4149f2613a
You are receiving this because
@eht16 @techee are we really gonna do something about this for next release, or
is this lingering from release to release? :slightly_smiling_face:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3063#issuecomment-1760315004
You are receiving this
Submitted my version as #3597
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1760302273
You are receiving this because you are subscribed to this thread.
Message ID:
Fixes #3424.
This is my alternate proposal over #3578, as suggested there. If nobody
complains, Ill use that -- but even better, somebody else could test and
merge :wink:
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3597
-- Commit
Merged #3591 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3591#event-10636308048
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
LGTM, but you could squash the second commit into the first :wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3594#pullrequestreview-1675065827
You are receiving this because you are subscribed to this thread.
> We'll still need the "unknown" check to support older ctags binaries
> unfortunately.
Sure, but it'll still make it more coherent. Unless we fear it'd break
compatibility at some level…
> OK to rebase this branch on top of master so it can be more easily tested
> with the php and py tag
> > I wrote most of it, it ought to be perfect
>
> Oh, I'm syncing it in the wrong direction - I should have updated ctags with
> your code :-).
Meh, I also wrote some of that one, so either way works :grinning:
> I discovered one more problem - all parsers use `typeref:typename` but I just
@b4n commented on this pull request.
> - if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then
- MINOR="$((MINOR-1))"
- PATCH="90"
+ if [[ "${MINOR}" = "0" && (-z "${PATCH}" || "${PATCH}" = "0")
]]; then
+
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
Reducing the font size might be the reason for icons to look too big in
comparison, whereas the display was just entirely scaled up somehow…
I have no idea (my Bookworm looks as above, but it's not 100% stock),
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
> Also as I said the set build tools dialog seems to have been expanded
> vertically (as well as the icons).
To me that looks like the dialog is making room for those ginormous icons :)
--
Reply to this
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
Look at the clear icons. My version (yeah, no window borders, but you get the
idea):
--
Reply to this email
Thanks for updating all this! But… I really think there's a problem with the
inline icons in the screenshots, they shouldn't be that big -- and they aren't
on my end with Adwaita (which seems to be what you used, which makes sense to
use IMO).
--
Reply to this email directly or view it on
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
wait… how come the icons are so big? HiDPI issue?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#pullrequestreview-1671065957
You are receiving this because you
> I'm not sure how robust our parser is against invalid input
I wrote most of it, it ought to be perfect :grin:
> or updated ctags file format
In theory the format is perfectly well defined and stable (just adding new
extension fields), so it should be fine™. But in practice uctags added
Having had a look at #3049 I get the point. But IIUC it must only be merged
after #3049 is, otherwise it'll make things rather worse as the current ctags
file parser don't understand that field (it could be made to, but I guess it's
not the point :))
--
Reply to this email directly or view
@b4n commented on this pull request.
> @@ -436,7 +443,6 @@ static TMTag *new_tag_from_tags_file(TMSourceFile *file,
> FILE *fp, TMParserType
result = init_tag_from_file_alt(tag, file, fp);
break;
case TM_FILE_FORMAT_CTAGS:
-
BTW looking at https://scintilla.org/ScintillaDoc.html#ChangeHistory, if we
only showed `!SC_MARKNUM_HISTORY_SAVED` (e.g. display what's *not* saved to
disk) it could be a lot easier to grasp, and probably more useful as well. But
that's for later I think :)
--
Reply to this email directly
@ntrel should I open a PR/update this one with this, do you want to take it
over, do you have anything against it… ?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1756247363
You are receiving this because you are subscribed to this
Actual diff from master that WFM:
```diff
diff --git a/meson.build b/meson.build
index ec3e509af..eacb73cb6 100644
--- a/meson.build
+++ b/meson.build
@@ -166,12 +166,14 @@ python = pymod.find_installation('python3', modules:
doxygen.found() and get_opt
rst2html = find_program('rst2html',
Re-rebased on top of master to fix merge conflicts
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1755442929
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 4 commits.
d906453916469769e68a2b35345813aa66737e7e Fix go to symbol definition popup
location
956409479a4dda51e95357cbb28336c121724238 Drop support for GTK 3.21 and older
bbfc201313f948f0528280a9089bc79af1af98a0 drop ui_menu_popup function
4a2999c18e2db59bb40b90ad6453732a2596a316
* It looks either a bit confusing or to have some bugs (without having
investigated deeply, it did things I didnt understand);
* It marks all lines when reloading a file (instead of resetting to a blank
slate);
* If marker margin is not visible, it can render the editor unreadable with the
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
…and for comparison, the exact same screenshot (to my freehand abilities…) with
the `SCI_POINTYFROMPOSITION`
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
With `char_width=1` (and none of the extra tests), I get this:
Closing now #3547 has been merged. Feel free to open further adjustments again
:wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3542#issuecomment-1755254335
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3542.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3542#event-10603526637
You are receiving this because you are subscribed to this thread.
Message ID:
> > I just rebased on top of master to fix the merge conflict. I did not
> > include my latest suggested change.
>
> And I'm afraid I just introduced another merge conflict by merging #3547...
No worries, I have it resolved locally and it's not a big deal.
--
Reply to this email directly or
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
This is with the current state of this PR right, not with just `char_width=0`,
is it?
The problem with the
@techee I don't think it matters much here (but maybe the "all all"? :grin:),
but it could also be one single commit (basically your first one already
combines various things together)
--
Reply to this email directly or view it on GitHub:
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
Ah… I feel it looks bad if cursor is in block mode (or overwrite) and the popup
is placed on the left (when there
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
> But really, I'd be for the "lazy" solution here, it's not worth complicating
> the code too much I think.
It's not removing indentation completely, it's removing one ident level (AKA
"unindent").
So maybe we indeed need a better wording if it's not clear, but your proposal
is not describing the feature accurately.
--
Reply to this email directly or view it on GitHub:
@b4n commented on this pull request.
> if (! first && have_best)
- /* For translators: it's the filename and line number
of a symbol in the goto-symbol popup menu */
- text = g_markup_printf_escaped(_("%s:%lu: %s"),
fname, tmtag->line,
@techee yeah I'd think it's wiser to wait, but probably get it in soon after.
And yeah, HACKING changes are probably useful nonetheless.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3169#issuecomment-1752172899
You are receiving this because you are
Do we want this in 2.0?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3169#issuecomment-1752172569
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3535 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3535#event-10585470950
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3527 as completed via 35d556ede85efb358d1cac156dd0fc8d44b20201.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3527#event-10585470932
You are receiving this because you are subscribed to this thread.
Message ID:
I just rebased on top of master to fix the merge conflict. I did *not* include
my latest suggested change.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1752161331
You are receiving this because you are subscribed to this thread.
@b4n pushed 4 commits.
c73dc3f0aedbf9b0fbc977a213dbf65b1d8a22f9 Fix go to symbol definition popup
location
229e598dd2b385d39c558b00594eed20db00f684 Drop support for GTK 3.21 and older
439aacc00596611585eeaf5b28378fef2c806bcb drop ui_menu_popup function
d2a64b0ae3af4acc3bad11230a1dec8c20e4bba5
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
As I'm a sucker for weird corner cases, this actually does not work if line
wrapping is enabled and the caret is
Yeah I think we should. There's a conflict, and I'll re-review it once more,
but it probably should make it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1752145766
You are receiving this because you are subscribed to this thread.
I'll test it a bit but I quite like it at the moment. And it basically adds a
new column from what I think I remember was the previous release (if I can
still remember), so it's almost less different, yet adding the extra info
@ntrel wanted, and that I grew to like as well.
I agree that it
> The disadvantage of your version is that the popup could get much bigger in
> some extreme cases but I think it's acceptable.
Yeah, if we want we can also limit the symbol side under 80 if it's a concern
-- although again, if there isn't enough info it can stop being useful.
> (Just a
> The problem seems to an extreme edge case
Not saying it's common, but AFAIR bulk search & replace will do that
(potentially massively change lines from the end to the start)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3551#issuecomment-1751810201
> I added a commit to enable the change history since it was trivial. Seems
> like a nice, user-visible change to take along (gives a bit of a modern
> feeling).
I'm a tad late to the party (as usual), but I don't think it should be enabled
by default. Here's a few reasons:
* I've seen it do
PS: this has string changes, not sure how bad that is for release… but I think
this PR might be worth sorting out anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1751803793
You are receiving this because you are subscribed to
First thoughts:
* I really dislike italics, I think it makes things a lot harder to read, and I
don't see the need (esp. as the symbol part has a different font). We had them
before but only for the non-best match, which is IMO better. If you wanna keep
them, let's only do so for those, not
I've been running the ever so slightly different implementation of this for a
long while and it worked nicely for me. Just tested this PR again, and it
seems to indeed actually behave the same, so I'm merging it.
--
Reply to this email directly or view it on GitHub:
Merged #3490 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3490#event-10582215719
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3454 as completed via #3490.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3454#event-10582215751
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> -if git.found()
+if git.found() and fs.is_dir('.git')
ret = run_command(git, 'rev-parse', '--short', '--revs-only', 'HEAD',
check: true)
cdata.set_quoted('REVISION', ret.stdout().strip())
else
So what about something like this (untested
> I don't really want to support meson from the tarball. It's still too
> experimental. If it seems to work from the tarball some guy or distro is
> going to rely on it.
We should definitely clearly mark this as experimental then.
But ATM it'll work from a tarball given `git` is not installed
Can't we simply not error-out if the `git` command fails, and assume
`REVISION=-1` as well then? given I see `check: true` maybe it'd be easy to
change that…
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1751677602
You are
Anybody up for giving this a test spin? I'm running that daily, but a second
opinion is always welcome :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3535#issuecomment-1749582325
You are receiving this because you are subscribed to this thread.
Merged #3536 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3536#event-10568107141
You are receiving this because you are subscribed to this thread.
Message ID:
I don't care actually, I'd have went with 1.23456789 until the end of times,
but I'm not saying it's a good idea :smile:
If you like 2.0, let's do it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3569#issuecomment-1749543274
You are receiving this
@b4n pushed 1 commit.
35d556ede85efb358d1cac156dd0fc8d44b20201 Fix crash closing directory from the
openfiles sidebar
--
View it on GitHub:
https://github.com/geany/geany/pull/3535/files/acce908d27017883a40e55332a20b3f5aa476f57..35d556ede85efb358d1cac156dd0fc8d44b20201
You are receiving this
@b4n commented on this pull request.
> @@ -1344,7 +1348,16 @@ static void on_openfiles_document_action(GtkMenuItem
> *menuitem, gpointer user_da
gint action = GPOINTER_TO_INT(user_data);
if (gtk_tree_selection_get_selected(selection, , ))
-
`foreach_ptr_array()` was reading one element past the end of the array. This
was not usually noticeable because the resulting garbage pointer was not
actually used, and its highly unlikely there is protected or foreign
memory right after the array, but there is actually no such guarantee, and
When the openfiles sidebar shows documents as a tree, closing a document can
lead to sever re-layout of the view (e.g. collapsing directory nodes together).
This makes walking the tree and closing documents at the same time highly
tricky, as nodes might be shifting as we go.
This lead to
401 - 500 of 3061 matches
Mail list logo
