[gwt-contrib] Remove escaped HTML from devevelopment mode glass panel (issue1514803)
Reviewers: rjrjr,
Description:
Remove escaped HTML from devevelopment mode glass panel
Please review this at http://gwt-code-reviews.appspot.com/1514803/
Affected files:
M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
M dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Index: dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
===
--- dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js (revision
10503)
+++ dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js (working
copy)
@@ -107,8 +107,7 @@
__gwt_displayGlassMessage('GWT Code Server Disconnected',
'Most likely, you closed GWT Development Mode. Or, you might have
lost '
+ 'network connectivity. To fix this, try restarting GWT Development
Mode and '
- + 'a style=color: #FF; font-weight: bold;
href=javascript:location.reload()'
- + 'REFRESH/a this page.');
+ + 'refresh this page.');
}
// Keep track of z-index to allow layering of multiple glass messages
Index: dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
===
--- dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (revision
10503)
+++ dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (working
copy)
@@ -160,8 +160,7 @@
__gwt_displayGlassMessage('GWT Code Server Disconnected',
'Most likely, you closed GWT Development Mode. Or, you might have
lost '
+ 'network connectivity. To fix this, try restarting GWT Development
Mode and '
- + 'a style=color: #FF; font-weight: bold;
href=javascript:location.reload()'
- + 'REFRESH/a this page.');
+ + 'refresh this page.');
}
// Keep track of z-index to allow layering of multiple glass messages
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove escaped HTML from devevelopment mode glass panel (issue1514803)
Committed in r10504 http://gwt-code-reviews.appspot.com/1514803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix typo (issue1497807)
Reviewers: unnurg, Description: Fix typo Fixes issues: 5912 Review by: unn...@google.com Please review this at http://gwt-code-reviews.appspot.com/1497807/ Affected files: M user/src/com/google/gwt/regexp/shared/RegExp.java Index: user/src/com/google/gwt/regexp/shared/RegExp.java === --- user/src/com/google/gwt/regexp/shared/RegExp.java (revision 10471) +++ user/src/com/google/gwt/regexp/shared/RegExp.java (working copy) @@ -32,7 +32,7 @@ * There are a few small incompatibilities between the two implementations. * Java-specific constructs in the regular expression syntax (e.g. [a-z[^bc]], * (?=foo), \A, \Q) work only in the pure Java implementation, not the GWT - * implementation, and are not rejected by either. Also, the Javscript-specific + * implementation, and are not rejected by either. Also, the Javascript-specific * constructs $` and $' in the replacement expression work only in the GWT * implementation, not the pure Java implementation, which rejects them. */ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix typo (issue1497807)
committed in r10494 http://gwt-code-reviews.appspot.com/1497807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix typo (issue1497807)
Test message. Please ignore. http://gwt-code-reviews.appspot.com/1497807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix typo (issue1497807)
2nd test message. http://gwt-code-reviews.appspot.com/1497807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: DirectInstallLinker should not immediately remove the script tag it has inserted into the IFRAME... (issue1454802)
Committed in r10293 http://gwt-code-reviews.appspot.com/1454802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Use glass panel isntead of alert() when displaying dev mode connection failures, (issue1449802)
Committed in r10204 http://gwt-code-reviews.appspot.com/1449802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)
Committed in r9944 http://gwt-code-reviews.appspot.com/1398802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)
Committed in r9918 http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix Javadoc for gesture/touch events (issue1383805)
Committed in r9869 http://gwt-code-reviews.appspot.com/1383805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)
Committed in r9756 http://gwt-code-reviews.appspot.com/1338804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Include the property name in the error message when a single-valued property does not have exact... (issue1348801)
Committed in r9702 http://gwt-code-reviews.appspot.com/1348801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove list of JavaScriptException object properties when compiler.stackTrace = emulated (issue1310802)
Committed in r9672 http://gwt-code-reviews.appspot.com/1310802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Updated StackTraceDeobfuscator javadoc in follow up to r9162. (issue1321801)
Committed in r9604 http://gwt-code-reviews.appspot.com/1321801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)
Committed in r9503 http://gwt-code-reviews.appspot.com/1229801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Re-enable a few style tests now that old linux hosted mode is gone (issue1228801)
Committed in r9499 http://gwt-code-reviews.appspot.com/1228801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
Committed in r9459 http://gwt-code-reviews.appspot.com/1221801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)
Committed in r9758 http://gwt-code-reviews.appspot.com/1323801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Handle cases where element.canPlayType() returns 'no' instead of the empty string on some browsers. (issue1362802)
Committed in r9868 http://gwt-code-reviews.appspot.com/1362802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)
Committed in r10204 http://gwt-code-reviews.appspot.com/1422816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Follow up to r10350. Allow collapse-all-properties in .gwt.xml module files (issue1463806)
ping http://gwt-code-reviews.appspot.com/1463806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update XML doc to make it clearer that 'compiler.emulatedStack' should no longer be used. (issue1462804)
ping http://gwt-code-reviews.appspot.com/1462804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update gwt-module.dtd: (issue1466801)
Committed in r10350 http://gwt-code-reviews.appspot.com/1466801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Follow up to r10350. Allow collapse-all-properties in .gwt.xml module files (issue1463806)
Reviewers: rjrjr, Description: Follow up to r10350. Allow collapse-all-properties in .gwt.xml module files Fixes issues: 5694 Please review this at http://gwt-code-reviews.appspot.com/1463806/ Affected files: M distro-source/core/src/gwt-module.dtd Index: distro-source/core/src/gwt-module.dtd === --- distro-source/core/src/gwt-module.dtd (revision 10346) +++ distro-source/core/src/gwt-module.dtd (working copy) @@ -19,7 +19,7 @@ define-property | extend-property | set-property | set-property-fallback | clear-configuration-property | define-configuration-property | extend-configuration-property | set-configuration-property | - property-provider | define-linker | add-linker)* + property-provider | define-linker | add-linker | collapse-all-properties)* !ATTLIST module rename-to CDATA #IMPLIED -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add a new 'SERVER' level to TreeLogger, which is to be used by the App Engine (issue1465804)
Reviewers: tobyr,
Description:
Add a new 'SERVER' level to TreeLogger, which is to be used by the App
Engine
DevAppServer to log all server messages to the GWT TreeLogger,
regardless
of the current GWT log_level.
Issues: http://code.google.com/p/googleappengine/issues/detail?id=4591
Review by: to...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1465804/
Affected files:
M dev/core/src/com/google/gwt/core/ext/TreeLogger.java
Index: dev/core/src/com/google/gwt/core/ext/TreeLogger.java
===
--- dev/core/src/com/google/gwt/core/ext/TreeLogger.java(revision 10346)
+++ dev/core/src/com/google/gwt/core/ext/TreeLogger.java(working copy)
@@ -59,6 +59,12 @@
public enum Type {
/**
+ * Used by DevAppServer when App Engine SDK server side messages are
logged
+ * to a GWT TreeLogger.
+ */
+SERVER(false),
+
+/**
* Logs an error.
*/
ERROR(true),
@@ -144,6 +150,12 @@
return needsAttention;
}
}
+
+ /**
+ * Used by DevAppServer when App Engine SDK server side messages are
logged
+ * to a GWT TreeLogger.
+ */
+ public static final Type SERVER = Type.SERVER;
/**
* Logs an error.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)
http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)
http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right): http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode461 user/src/com/google/gwt/user/tools/WebAppCreator.java:461: // Public builds generate a DTD reference. On 2011/06/17 13:41:13, pdr wrote: // Public builds... - // Generate a DTD reference. Done. http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode462 user/src/com/google/gwt/user/tools/WebAppCreator.java:462: String gwtModuleDtd = \n!-- Using DTD from SVN 'trunk'. You probably want to change this to a specific, release tagged, DTD -- On 2011/06/17 13:41:13, pdr wrote: Nit: Can you make this less than than 100 chars? Done. http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode469 user/src/com/google/gwt/user/tools/WebAppCreator.java:469: gwtModuleDtd = \n!-- When updating your version of GWT, also update this DTD reference -- I clarified the comment. Strictly speaking, you can use the old DTD. Your IDE just won't know about any new GWT module features. This comment ensures developers have a chance to discover this. http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode470 user/src/com/google/gwt/user/tools/WebAppCreator.java:470: + \n!DOCTYPE module PUBLIC \-//Google Inc.//DTD Google Web Toolkit On 2011/06/17 13:41:13, pdr wrote: Nit: Can we shorten this by adding a newline here? How's this? http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)
http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)
http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right): http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode474 user/src/com/google/gwt/user/tools/WebAppCreator.java:474: + \n!DOCTYPE module PUBLIC \-//Google Inc.//DTD Google Web Toolkit I prefer to keep the version number on the same line as as Google Web Toolkit, i.e. How's this look? !DOCTYPE module PUBLIC -//Google Inc.//DTD Google Web Toolkit 2.3.0//EN http://google-web-toolkit.googlecode.com/svn/trunk/distro-source/core/src/gwt-module.dtd; http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Update XML doc to make it clearer that 'compiler.emulatedStack' should no longer be used. (issue1462804)
Reviewers: bobv, Description: Update XML doc to make it clearer that 'compiler.emulatedStack' should no longer be used. Review by: b...@google.com Please review this at http://gwt-code-reviews.appspot.com/1462804/ Affected files: M user/src/com/google/gwt/core/EmulateJsStack.gwt.xml Index: user/src/com/google/gwt/core/EmulateJsStack.gwt.xml === --- user/src/com/google/gwt/core/EmulateJsStack.gwt.xml (revision 10345) +++ user/src/com/google/gwt/core/EmulateJsStack.gwt.xml (working copy) @@ -17,8 +17,7 @@ module inherits name=com.google.gwt.core.Core / - !-- Legacy property, use 'compiler.stackMode' instead -- - !-- If set to true, emulated stack frames will be emitted into the JS -- + !-- Legacy property. Do NOT use. See 'compiler.stackMode' instead. -- define-property name=compiler.emulatedStack values=true,false / set-property name=compiler.emulatedStack value=false / -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Update gwt-module.dtd: (issue1466801)
Reviewers: rjrjr, Description: Update gwt-module.dtd: - Add support for set-property-fallback, e.g. set-property-fallback name=locale value=en/ - Add support for fallback-value attribute to extend-property, e.g. extend-property name=user.agent values=ie9 fallback-value=ie8 / Fixes issues: 4787, 5325, 5694 Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/1466801/ Affected files: M distro-source/core/src/gwt-module.dtd Index: distro-source/core/src/gwt-module.dtd === --- distro-source/core/src/gwt-module.dtd (revision 10346) +++ distro-source/core/src/gwt-module.dtd (working copy) @@ -16,7 +16,7 @@ !-- The module root element -- !ELEMENT module (inherits | source | public | super-source | entry-point | stylesheet | script | servlet | replace-with | generate-with | - define-property | extend-property | set-property | + define-property | extend-property | set-property | set-property-fallback | clear-configuration-property | define-configuration-property | extend-configuration-property | set-configuration-property | property-provider | define-linker | add-linker)* @@ -104,6 +104,8 @@ !-- ^^^ Commonly-used elements ^^^-- !--VVV Deferred binding elements VVV -- +!-- All possible predicates -- +!ENTITY % predicates when-property-is | when-type-assignable | when-type-is | all | any | none !-- Define a property and allowable values (comma-separated identifiers) -- !ELEMENT define-property EMPTY !ATTLIST define-property @@ -117,8 +119,14 @@ is-multi-valued CDATA #REQUIRED !-- Set the value of a previously-defined property -- -!ELEMENT set-property EMPTY +!ELEMENT set-property (%predicates;)* !ATTLIST set-property + name CDATA #REQUIRED + value CDATA #REQUIRED + +!-- Set the value of a previously-defined property -- +!ELEMENT set-property-fallback EMPTY +!ATTLIST set-property-fallback name CDATA #REQUIRED value CDATA #REQUIRED @@ -133,6 +141,7 @@ !ATTLIST extend-property name CDATA #REQUIRED values CDATA #REQUIRED + fallback-value CDATA #IMPLIED !-- Collapse property values to produce soft permutations -- !ELEMENT collapse-property EMPTY @@ -162,8 +171,6 @@ name CDATA #REQUIRED generator CDATA #IMPLIED -!-- All possible predicates -- -!ENTITY % predicates when-property-is | when-type-assignable | when-type-is | all | any | none !-- Deferred binding assignment to substitute a named class -- !ELEMENT replace-with (%predicates;)* !ATTLIST replace-with -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update gwt-module.dtd: (issue1466801)
http://gwt-code-reviews.appspot.com/1466801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)
Committed in r10347 http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)
http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes a bug in StackTraceDeobfuscator where line numbers from the symbol map were being used in ... (issue1457801)
LGTM
http://gwt-code-reviews.appspot.com/1457801/diff/4001/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
File user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(right):
http://gwt-code-reviews.appspot.com/1457801/diff/4001/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java#newcode145
user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java:145:
if (lineNumber == -1) {
Sorry, one more thought: I think it would be good to extract -1 into a
static final, say LINE_NUMBER_UNKNOWN, similar what's in
StackTraceCreator.java
http://gwt-code-reviews.appspot.com/1457801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Making media events bitless, freeing up a few event bits, since modern, (issue1447816)
Reviewers: jlabanca, Description: Making media events bitless, freeing up a few event bits, since modern, implementing browsers don't leak the way old ones did. The following constants, marked as 'experimental', have been removed: - com.google.gwt.user.client.Event.MEDIAEVENTS - com.google.gwt.user.client.Event.ONCANPLAYTHROUGH - com.google.gwt.user.client.Event.ONENDED - com.google.gwt.user.client.Event.ONPROGRESS Please review this at http://gwt-code-reviews.appspot.com/1447816/ Affected files: M tools/api-checker/config/gwt23_24userApi.conf M user/src/com/google/gwt/media/client/MediaBase.java M user/src/com/google/gwt/user/client/Event.java M user/src/com/google/gwt/user/client/impl/DOMImpl.java M user/src/com/google/gwt/user/client/impl/DOMImplStandard.java M user/test/com/google/gwt/user/client/MediaEventsSinkTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Making media events bitless, freeing up a few event bits, since modern, (issue1447816)
Yep and yep. Thanks. http://gwt-code-reviews.appspot.com/1447816/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/1447816/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode223 user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:223: if (eventTypeName == drag) On 2011/06/03 17:10:39, jlabanca wrote: Does javascript allow switch statements with strings? If so, we might want to use a switch statement instead of else if checks. Done. http://gwt-code-reviews.appspot.com/1447816/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode240 user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:240: elem.onprogress = @com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent; On 2011/06/03 17:10:39, jlabanca wrote: Are we missing canplaythrough? Done. http://gwt-code-reviews.appspot.com/1447816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Making media events bitless, freeing up a few event bits, since modern, (issue1447816)
http://gwt-code-reviews.appspot.com/1447816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Making media events bitless, freeing up a few event bits, since modern, (issue1447816)
Committed as r10274 http://gwt-code-reviews.appspot.com/1447816/diff/2002/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/1447816/diff/2002/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode248 user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:248: // re-entrant safe On 2011/06/03 19:39:41, jlabanca wrote: Can you expand this comment to say: These events are re-entrant safe because they are only available on modern browsers that do not leak memory. I think the intent of my comment wasn't clear, which was directed at my use of removeEventListener Updated it to read: // First call removeEventListener, so as not to add the same event listener more than once http://gwt-code-reviews.appspot.com/1447816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)
http://gwt-code-reviews.appspot.com/1422816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)
http://gwt-code-reviews.appspot.com/1422816/diff/8001/user/src/com/google/gwt/user/client/DocumentModeAsserter.java File user/src/com/google/gwt/user/client/DocumentModeAsserter.java (right): http://gwt-code-reviews.appspot.com/1422816/diff/8001/user/src/com/google/gwt/user/client/DocumentModeAsserter.java#newcode69 user/src/com/google/gwt/user/client/DocumentModeAsserter.java:69: + currentMode + ' is not one of: + Arrays.toString(allowedModes); On 2011/05/20 16:09:13, jlabanca wrote: We should give the user better instructions here. Change the doctype at the top of you applications host html page to one of + Arrays.toString(allowedModes) + . Or, add the following line to your gwt.xml file to continue using quirks mode, but understand that GWT no longer supports Quirks mode: extend-property name=\document.compatMode\ values=\BackCompat\/ Done. Let me know what you think. There's two cases we need to handle: 1. Deprecation of quirks mode 2. Developer has done something custom http://gwt-code-reviews.appspot.com/1422816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Use glass panel isntead of alert() when displaying dev mode connection failures, (issue1449802)
Reviewers: jlabanca,
Description:
Use glass panel isntead of alert() when displaying dev mode connection
failures,
because modal dialog boxes are annoying and consume unnecessary
keystrokes or
mouse clicks before you are able to refresh the page.
Please review this at http://gwt-code-reviews.appspot.com/1449802/
Affected files:
M dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Index: dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
===
--- dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (revision
10190)
+++ dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (working
copy)
@@ -295,7 +295,7 @@
if (errFn) {
errFn(modName);
} else {
-alert(Plugin failed to connect to Development Mode server at +
$hosted);
+__gwt_displayGlassMessage(Plugin failed to connect to Development
Mode server at + $hosted);
loadIframe(http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM;);
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Use glass panel isntead of alert() when displaying dev mode connection failures, (issue1449802)
http://gwt-code-reviews.appspot.com/1449802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)
http://gwt-code-reviews.appspot.com/1422816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)
This change now introduces only a Development Mode warning (to the GWT
treelogger), which an option to suppress it (for those who know what
they are doing, or to raise the severity to a runtime error, which we
can do in a later release
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml
File user/src/com/google/gwt/user/UserAgent.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml#newcode29
user/src/com/google/gwt/user/UserAgent.gwt.xml:29:
On 2011/05/04 14:37:57, jlabanca wrote:
extra newline
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml#newcode56
user/src/com/google/gwt/user/UserAgent.gwt.xml:56:
define-configuration-property name=document.compatMode
On 2011/05/04 14:37:57, jlabanca wrote:
I think we should break this out into a separate DocumentMode.gwt.xml
file and
inherit it in User.gwt.xml. It isn't part of the UserAgent.
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/UserAgent.gwt.xml#newcode67
user/src/com/google/gwt/user/UserAgent.gwt.xml:67:
On 2011/05/04 14:37:57, jlabanca wrote:
extra newline
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/client/DocumentModeAsserter.java
File user/src/com/google/gwt/user/client/DocumentModeAsserter.java
(right):
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/client/DocumentModeAsserter.java#newcode27
user/src/com/google/gwt/user/client/DocumentModeAsserter.java:27: *
rendering mode is of of the values allowed by the
On 2011/05/04 14:37:57, jlabanca wrote:
/r/of of/one of
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java
File user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode49
user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:49:
logger.log(TreeLogger.ERROR, OOPS, e);
On 2011/05/04 14:37:57, jlabanca wrote:
Maybe something better than OOPS
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode57
user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:57:
JClassType remoteService = typeOracle.findType(typeName);
On 2011/05/04 14:37:57, jlabanca wrote:
Isn't removeService the same as userType?
YES!
Fixed.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode76
user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:76:
logger.log(TreeLogger.WARN, Unable to find value for '
On 2011/05/04 14:37:57, jlabanca wrote:
If we are going to throw an exception, this should be an ERROR instead
of a WARN
Done.
http://gwt-code-reviews.appspot.com/1422816/diff/1/user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java#newcode103
user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java:103:
sw.println(\ + iterator.next() + \, );
On 2011/05/04 14:37:57, jlabanca wrote:
This array will always end with a comma. Does Java handle that
correctly?
return new String[]{a,b,};
Yes
http://gwt-code-reviews.appspot.com/1422816/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)
Reviewers: jlabanca, Description: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE declaration), e.g !doctype html 2. Provide a new configuration property to indicate the required browser rendering mode, which can be used to suppress the above Standards Mode requirement, e.g. - Skip rendering mode tests set-configuration-property name=document.compatMode value=*/ - Require Standards Mode (the default) set-configuration-property name=document.compatMode value=CSS1Compat/ - Require Quirks Mode (for apps that require this and know what they are doing) set-configuration-property name=document.compatMode value=BackCompat/ 3. Modify the default HTML template to indicate that quirks mode is not supported Fixes issues: 6086, 6306 Please review this at http://gwt-code-reviews.appspot.com/1422816/ Affected files: M user/src/com/google/gwt/user/UserAgent.gwt.xml A user/src/com/google/gwt/user/client/DocumentModeAsserter.java A user/src/com/google/gwt/user/rebind/DocumentModeGenerator.java M user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/_moduleShortName_.htmlsrc -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)
Reviewers: pdr,
Description:
New projects should always have a DTD specified in their template
.gwt.xml module file
Also, fix broken NoNag version check logic.
Please review this at http://gwt-code-reviews.appspot.com/1407803/
Affected files:
M user/src/com/google/gwt/user/tools/WebAppCreator.java
Index: user/src/com/google/gwt/user/tools/WebAppCreator.java
===
--- user/src/com/google/gwt/user/tools/WebAppCreator.java (revision 9955)
+++ user/src/com/google/gwt/user/tools/WebAppCreator.java (working copy)
@@ -459,9 +459,13 @@
String gwtValidationSourcesPath = installPath + '/'
+ validation-api-1.0.0.GA-sources.jar;
// Public builds generate a DTD reference.
-String gwtModuleDtd = ;
+String gwtModuleDtd = \n!-- Using DTD from SVN 'trunk'. You probably
want to change this to a specific, release tagged, DTD --
++ \n!DOCTYPE module PUBLIC \-//Google Inc.//DTD Google Web
Toolkit
++ About.getGwtVersionNum()
++ //EN\ \http://google-web-toolkit.googlecode.com/svn/trunk/;
++ /distro-source/core/src/gwt-module.dtd\;
GwtVersion gwtVersion = About.getGwtVersionObject();
-if (gwtVersion.isNoNagVersion()) {
+if (!gwtVersion.isNoNagVersion() !gwtVersion.equals(new
GwtVersion(null))) {
gwtModuleDtd = \n!DOCTYPE module PUBLIC \-//Google Inc.//DTD
Google Web Toolkit
+ About.getGwtVersionNum()
+ //EN\ \http://google-web-toolkit.googlecode.com/svn/tags/;
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)
http://gwt-code-reviews.appspot.com/1398802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)
http://gwt-code-reviews.appspot.com/1398802/diff/1/user/src/com/google/gwt/event/dom/client/DragExitEvent.java
File user/src/com/google/gwt/event/dom/client/DragExitEvent.java
(right):
http://gwt-code-reviews.appspot.com/1398802/diff/1/user/src/com/google/gwt/event/dom/client/DragExitEvent.java#newcode41
user/src/com/google/gwt/event/dom/client/DragExitEvent.java:41: * {@link
DomEvent#fireNativeEvent(com.google.gwt.dom.client.NativeEvent,
com.google.gwt.event.shared.HasHandlers)}
On 2011/04/04 14:43:23, pdr wrote:
Line 100 chars.
Done.
http://gwt-code-reviews.appspot.com/1398802/diff/1/user/test/com/google/gwt/user/client/DragAndDropEventsSinkTest.java
File user/test/com/google/gwt/user/client/DragAndDropEventsSinkTest.java
(right):
http://gwt-code-reviews.appspot.com/1398802/diff/1/user/test/com/google/gwt/user/client/DragAndDropEventsSinkTest.java#newcode176
user/test/com/google/gwt/user/client/DragAndDropEventsSinkTest.java:176:
delayTestFinish(100);
On 2011/04/04 14:43:23, pdr wrote:
This is just 100ms, any reason not to bump that to 1000ms / 1s?
Done.
http://gwt-code-reviews.appspot.com/1398802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)
http://gwt-code-reviews.appspot.com/1398802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add the beginnings of new HTML5 drag and drop events (issue1398802)
Reviewers: pdr, Description: Add the beginnings of new HTML5 drag and drop events Please review this at http://gwt-code-reviews.appspot.com/1398802/ Affected files: A user/src/com/google/gwt/event/dom/client/DragEnterClickHandler.java A user/src/com/google/gwt/event/dom/client/DragEnterEvent.java A user/src/com/google/gwt/event/dom/client/DragEnterHandler.java A user/src/com/google/gwt/event/dom/client/DragExitEvent.java A user/src/com/google/gwt/event/dom/client/DragExitHandler.java A user/src/com/google/gwt/event/dom/client/DragOverEvent.java A user/src/com/google/gwt/event/dom/client/DragOverHandler.java A user/src/com/google/gwt/event/dom/client/DropEvent.java A user/src/com/google/gwt/event/dom/client/DropHandler.java A user/src/com/google/gwt/event/dom/client/HasAllDragAndDropHandlers.java A user/src/com/google/gwt/event/dom/client/HasDragEnterHandlers.java A user/src/com/google/gwt/event/dom/client/HasDragExitHandlers.java A user/src/com/google/gwt/event/dom/client/HasDragOverHandlers.java A user/src/com/google/gwt/event/dom/client/HasDropHandlers.java M user/src/com/google/gwt/user/client/ui/FocusPanel.java M user/src/com/google/gwt/user/client/ui/FocusWidget.java M user/src/com/google/gwt/user/client/ui/HTMLTable.java M user/src/com/google/gwt/user/client/ui/Image.java M user/src/com/google/gwt/user/client/ui/Label.java M user/test/com/google/gwt/user/UISuite.java A user/test/com/google/gwt/user/client/DragAndDropEventsSinkTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)
http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)
http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)
http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/EndedHandler.java File user/src/com/google/gwt/event/dom/client/EndedHandler.java (right): http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/EndedHandler.java#newcode26 user/src/com/google/gwt/event/dom/client/EndedHandler.java:26: * Called when EndEdEvent is fired. On 2011/03/21 14:33:54, pdr wrote: EndEdEvent - EndedEvent Done. http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java File user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java (right): http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java#newcode2 user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java:2: * Copyright 2010 Google Inc. On 2011/03/21 14:33:54, pdr wrote: 2010 - 2011 Done. http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java#newcode25 user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java:25: * to it. Therefore, updates can cause breaking API changes. On 2011/03/21 14:33:54, pdr wrote: For consistency, could this be replaced with the experimental warning we use in some of the other html5 apis? Done. http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasCanPlayThroughHandlers.java File user/src/com/google/gwt/event/dom/client/HasCanPlayThroughHandlers.java (right): http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasCanPlayThroughHandlers.java#newcode2 user/src/com/google/gwt/event/dom/client/HasCanPlayThroughHandlers.java:2: * Copyright 2010 Google Inc. On 2011/03/21 14:33:54, pdr wrote: 2010 - 2011 Done. http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasEndedHandlers.java File user/src/com/google/gwt/event/dom/client/HasEndedHandlers.java (right): http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasEndedHandlers.java#newcode2 user/src/com/google/gwt/event/dom/client/HasEndedHandlers.java:2: * Copyright 2010 Google Inc. On 2011/03/21 14:33:54, pdr wrote: 2010 - 2011 Done. http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasProgressHandlers.java File user/src/com/google/gwt/event/dom/client/HasProgressHandlers.java (right): http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/HasProgressHandlers.java#newcode2 user/src/com/google/gwt/event/dom/client/HasProgressHandlers.java:2: * Copyright 2010 Google Inc. On 2011/03/21 14:33:54, pdr wrote: 2010 - 2011 Done. http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/media/client/Audio.java File user/src/com/google/gwt/media/client/Audio.java (right): http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/media/client/Audio.java#newcode93 user/src/com/google/gwt/media/client/Audio.java:93: These are documented on the HasCanPlayThroughHandlers, HasEndedHandlers and HasProgressHandlers interfaces. Would you still like me to duplicate the docs here? http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)
http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix Javadoc for gesture/touch events (issue1383805)
Reviewers: pdr,
Description:
Fix Javadoc for gesture/touch events
Review by: p...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1383805/
Affected files:
M user/src/com/google/gwt/event/dom/client/HasGestureChangeHandlers.java
M user/src/com/google/gwt/event/dom/client/HasGestureEndHandlers.java
M user/src/com/google/gwt/event/dom/client/HasGestureStartHandlers.java
M user/src/com/google/gwt/event/dom/client/HasTouchCancelHandlers.java
M user/src/com/google/gwt/event/dom/client/HasTouchEndHandlers.java
M user/src/com/google/gwt/event/dom/client/HasTouchMoveHandlers.java
M user/src/com/google/gwt/event/dom/client/HasTouchStartHandlers.java
Index:
user/src/com/google/gwt/event/dom/client/HasGestureChangeHandlers.java
===
--- user/src/com/google/gwt/event/dom/client/HasGestureChangeHandlers.java
(revision 9867)
+++ user/src/com/google/gwt/event/dom/client/HasGestureChangeHandlers.java
(working copy)
@@ -26,7 +26,7 @@
/**
* Adds a {@link GestureChangeEvent} handler.
*
- * @param handler the mouse down handler
+ * @param handler the gesture change handler
* @return {@link HandlerRegistration} used to remove this handler
*/
HandlerRegistration addGestureChangeHandler(GestureChangeHandler
handler);
Index: user/src/com/google/gwt/event/dom/client/HasGestureEndHandlers.java
===
--- user/src/com/google/gwt/event/dom/client/HasGestureEndHandlers.java
(revision 9867)
+++ user/src/com/google/gwt/event/dom/client/HasGestureEndHandlers.java
(working copy)
@@ -26,7 +26,7 @@
/**
* Adds a {@link GestureEndEvent} handler.
*
- * @param handler the mouse down handler
+ * @param handler the gesture end handler
* @return {@link HandlerRegistration} used to remove this handler
*/
HandlerRegistration addGestureEndHandler(GestureEndHandler handler);
Index: user/src/com/google/gwt/event/dom/client/HasGestureStartHandlers.java
===
--- user/src/com/google/gwt/event/dom/client/HasGestureStartHandlers.java
(revision 9867)
+++ user/src/com/google/gwt/event/dom/client/HasGestureStartHandlers.java
(working copy)
@@ -26,7 +26,7 @@
/**
* Adds a {@link GestureStartEvent} handler.
*
- * @param handler the mouse down handler
+ * @param handler the gesture start handler
* @return {@link HandlerRegistration} used to remove this handler
*/
HandlerRegistration addGestureStartHandler(GestureStartHandler handler);
Index: user/src/com/google/gwt/event/dom/client/HasTouchCancelHandlers.java
===
--- user/src/com/google/gwt/event/dom/client/HasTouchCancelHandlers.java
(revision 9867)
+++ user/src/com/google/gwt/event/dom/client/HasTouchCancelHandlers.java
(working copy)
@@ -26,7 +26,7 @@
/**
* Adds a {@link TouchCancelEvent} handler.
*
- * @param handler the mouse down handler
+ * @param handler the touch cancel handler
* @return {@link HandlerRegistration} used to remove this handler
*/
HandlerRegistration addTouchCancelHandler(TouchCancelHandler handler);
Index: user/src/com/google/gwt/event/dom/client/HasTouchEndHandlers.java
===
--- user/src/com/google/gwt/event/dom/client/HasTouchEndHandlers.java
(revision 9867)
+++ user/src/com/google/gwt/event/dom/client/HasTouchEndHandlers.java
(working copy)
@@ -26,7 +26,7 @@
/**
* Adds a {@link TouchEndEvent} handler.
*
- * @param handler the mouse down handler
+ * @param handler the touch end handler
* @return {@link HandlerRegistration} used to remove this handler
*/
HandlerRegistration addTouchEndHandler(TouchEndHandler handler);
Index: user/src/com/google/gwt/event/dom/client/HasTouchMoveHandlers.java
===
--- user/src/com/google/gwt/event/dom/client/HasTouchMoveHandlers.java
(revision 9867)
+++ user/src/com/google/gwt/event/dom/client/HasTouchMoveHandlers.java
(working copy)
@@ -26,7 +26,7 @@
/**
* Adds a {@link TouchMoveEvent} handler.
*
- * @param handler the mouse down handler
+ * @param handler the touch move handler
* @return {@link HandlerRegistration} used to remove this handler
*/
HandlerRegistration addTouchMoveHandler(TouchMoveHandler handler);
Index: user/src/com/google/gwt/event/dom/client/HasTouchStartHandlers.java
===
--- user/src/com/google/gwt/event/dom/client/HasTouchStartHandlers.java
(revision 9867)
+++ user/src/com/google/gwt/event/dom/client/HasTouchStartHandlers.java
(working copy)
@@ -26,7 +26,7 @@
/**
* Adds a {@link TouchStartEvent} handler.
*
- * @param handler the mouse down handler
+ *
[gwt-contrib] Add media events for audio/video elements (issue1385804)
Reviewers: pdr, Description: Add media events for audio/video elements Please review this at http://gwt-code-reviews.appspot.com/1385804/ Affected files: M dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java A user/src/com/google/gwt/event/dom/client/EndedEvent.java A user/src/com/google/gwt/event/dom/client/EndedHandler.java A user/src/com/google/gwt/event/dom/client/HasAllMediaHandlers.java A user/src/com/google/gwt/event/dom/client/HasEndedHandlers.java A user/src/com/google/gwt/event/dom/client/HasProgressHandlers.java A user/src/com/google/gwt/event/dom/client/ProgressEvent.java A user/src/com/google/gwt/event/dom/client/ProgressHandler.java M user/src/com/google/gwt/media/client/Audio.java M user/src/com/google/gwt/user/client/Event.java M user/src/com/google/gwt/user/client/impl/DOMImpl.java M user/src/com/google/gwt/user/client/impl/DOMImplStandard.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)
http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Handle cases where element.canPlayType() returns 'no' instead of the empty string on some browsers. (issue1362802)
Reviewers: jgw,
Description:
Handle cases where element.canPlayType() returns 'no' instead of the
empty string on some browsers.
Review by: j...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1362802/
Affected files:
M user/src/com/google/gwt/dom/client/MediaElement.java
Index: user/src/com/google/gwt/dom/client/MediaElement.java
===
--- user/src/com/google/gwt/dom/client/MediaElement.java(revision 9755)
+++ user/src/com/google/gwt/dom/client/MediaElement.java(working copy)
@@ -112,7 +112,11 @@
* {@link #CANNOT_PLAY}
*/
public final native String canPlayType(String type) /*-{
-return this.canPlayType(type);
+var canPlayType = this.canPlayType(type);
+ // Some browsers report no instead of the empty string.
+ // See http://gwt-voices.appspot.com/
+return canPlayType == no ?
+@com.google.gwt.dom.client.MediaElement::CANNOT_PLAY : canPlayType;
}-*/;
/**
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)
http://gwt-code-reviews.appspot.com/1338804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)
http://gwt-code-reviews.appspot.com/1323801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)
http://gwt-code-reviews.appspot.com/1323801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)
http://gwt-code-reviews.appspot.com/1338804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Include the property name in the error message when a single-valued property does not have exact... (issue1348801)
Reviewers: jat,
Description:
Include the property name in the error message when a single-valued
property does not have exactly one value
Please review this at http://gwt-code-reviews.appspot.com/1348801/show
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardConfigurationProperty.java
Index:
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardConfigurationProperty.java
===
---
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardConfigurationProperty.java
(revision 9681)
+++
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardConfigurationProperty.java
(working copy)
@@ -37,8 +37,8 @@
throw new IllegalArgumentException(values is null);
}
if (!p.allowsMultipleValues() values.size() != 1) {
- throw new IllegalArgumentException(
- p is single-valued but values.size != 1);
+ throw new IllegalArgumentException(p.getName()
+ + property is single-valued but values.size() != 1);
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)
Reviewers: robertvawter, Description: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulatedStack' property, with the corresponding 'compiler.stackMode'. Fixes issues: 5692 Please review this at http://gwt-code-reviews.appspot.com/1338804/show Affected files: M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml M user/src/com/google/gwt/benchmarks/Benchmarks.gwt.xml M user/src/com/google/gwt/junit/JUnit.gwt.xml M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java Index: samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml === --- samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml (revision 9666) +++ samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml (working copy) @@ -32,7 +32,7 @@ set-property name=gwt.logging.simpleRemoteHandler value=DISABLED / !-- Uncomment if you are enabling server side deobfuscation of StackTraces - set-property name=compiler.emulatedStack value=true / + set-property name=compiler.stackMode value=emulated / set-configuration-property name=compiler.emulatedStack.recordLineNumbers value=true / set-configuration-property name=compiler.emulatedStack.recordFileNames value=true / -- Index: user/src/com/google/gwt/benchmarks/Benchmarks.gwt.xml === --- user/src/com/google/gwt/benchmarks/Benchmarks.gwt.xml (revision 9666) +++ user/src/com/google/gwt/benchmarks/Benchmarks.gwt.xml (working copy) @@ -26,7 +26,7 @@ !-- We do not want stack traces. -- set-configuration-property name=compiler.emulatedStack.recordFileNames value=false / - set-property name=compiler.emulatedStack value=false / + set-property name=compiler.stackMode value=native / generate-with class=com.google.gwt.benchmarks.rebind.BenchmarkGenerator when-type-assignable class=com.google.gwt.benchmarks.client.Benchmark/ Index: user/src/com/google/gwt/junit/JUnit.gwt.xml === --- user/src/com/google/gwt/junit/JUnit.gwt.xml (revision 9666) +++ user/src/com/google/gwt/junit/JUnit.gwt.xml (working copy) @@ -33,7 +33,7 @@ !-- We want to provide consistent stack traces across all browsers. -- set-configuration-property name=compiler.emulatedStack.recordFileNames value=true / - set-property name=compiler.emulatedStack value=true / + set-property name=compiler.stackMode value=emulated / !-- Override the regular symbolMaps linker to put the data somewhere we can find it -- define-linker name=symbolMaps class=com.google.gwt.junit.linker.JUnitSymbolMapsLinker / Index: user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java === --- user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java (revision 9666) +++ user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java (working copy) @@ -31,7 +31,7 @@ /** * Deobfuscates stack traces on the server side. This class requires that you * have turned on emulated stack traces, via - * codelt;set-property name=compiler.emulatedStack value=true /gt;/code + * codelt;set-property name=compiler.stackMode value=emulated /gt;/code * in your code.gwt.xml/code module file, and moved your symbol map files to * a location accessible by your server sever side code. You can use the GWT * compiler code-deploy/code command line argument to specify the location -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter (issue1334801)
LGTM http://gwt-code-reviews.appspot.com/1334801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: At application startup, assert that the specified user.agent selection property value indeed mat... (issue1278801)
Committed in r9643 http://gwt-code-reviews.appspot.com/1278801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove list of JavaScriptException object properties when compiler.stackTrace = emulated (issue1310802)
http://gwt-code-reviews.appspot.com/1310802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] - Use z-index to layer multiple notifications in hosted.html (issue1323801)
Reviewers: knorton,
Description:
- Use z-index to layer multiple notifications in hosted.html
- ModuleSpace.java produces well formed HTML, replacing /pre with
/div
Please review this at http://gwt-code-reviews.appspot.com/1323801/show
Affected files:
M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
M dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
M dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
Index: dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
===
--- dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js (revision
9607)
+++ dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js (working
copy)
@@ -111,6 +111,9 @@
+ 'REFRESH/a this page.');
}
+// Keep track of z-index to allow layering of multiple glass messages
+var __gwt_glassMessageZIndex = 2147483647;
+
// Note this method is also used by ModuleSpace.java
function __gwt_displayGlassMessage(summary, details) {
var topWin = window.top;
@@ -118,11 +121,13 @@
var outer = topDoc.createElement(div);
// Do not insert whitespace or outer.firstChild will get a text node.
outer.innerHTML =
-'div
style=position:absolute;z-index:2147483646;left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=75);opacity:0.75;background-color:#00;/div'
+
-'div
style=position:absolute;z-index:2147483647;left:50px;top:50px;width:600px;color:#FF;font-family:verdana;'
+
- 'div style=font-size:30px;font-weight:bold;' + summary
+ '/div' +
- 'p style=font-size:15px;' + details + '/p' +
-'/div'
+'div style=position:absolute;z-index:' + __gwt_glassMessageZIndex-- +
+';left:50px;top:50px;width:600px;color:#FFF;font-family:verdana;' +
+'div style=font-size:30px;font-weight:bold;' + summary + '/div' +
+'div style=font-size:15px;' + details + '/div' +
+'/div' +
+'div style=position:absolute;z-index:' + __gwt_glassMessageZIndex-- +
+
';left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=60);opacity:0.6;background-color:#000;/div'
;
topDoc.body.appendChild(outer);
var glass = outer.firstChild;
@@ -164,6 +169,10 @@
//should be prefixed with __gwt_
function fireOnModuleLoadStart(className) {
$sendStats(moduleStartup, onModuleLoadStart);
+var __gwt_glassMessageZIndex = 2147483647;
+
+var __gwt_glassMessageZIndex = 2147483647;
+
}
Index: dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
===
--- dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (revision
9607)
+++ dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (working
copy)
@@ -164,6 +164,9 @@
+ 'REFRESH/a this page.');
}
+// Keep track of z-index to allow layering of multiple glass messages
+var __gwt_glassMessageZIndex = 2147483647;
+
// Note this method is also used by ModuleSpace.java
function __gwt_displayGlassMessage(summary, details) {
var topWin = window.top;
@@ -171,11 +174,13 @@
var outer = topDoc.createElement(div);
// Do not insert whitespace or outer.firstChild will get a text node.
outer.innerHTML =
-'div
style=position:absolute;z-index:2147483646;left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=75);opacity:0.75;background-color:#00;/div'
+
-'div
style=position:absolute;z-index:2147483647;left:50px;top:50px;width:600px;color:#FF;font-family:verdana;'
+
- 'div style=font-size:30px;font-weight:bold;' + summary
+ '/div' +
- 'p style=font-size:15px;' + details + '/p' +
-'/div'
+'div style=position:absolute;z-index:' + __gwt_glassMessageZIndex-- +
+';left:50px;top:50px;width:600px;color:#FFF;font-family:verdana;' +
+'div style=font-size:30px;font-weight:bold;' + summary + '/div' +
+'div style=font-size:15px;' + details + '/div' +
+'/div' +
+'div style=position:absolute;z-index:' + __gwt_glassMessageZIndex-- +
+
';left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=60);opacity:0.6;background-color:#000;/div'
;
topDoc.body.appendChild(outer);
var glass = outer.firstChild;
Index: dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
===
--- dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (revision 9607)
+++ dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (working copy)
@@ -611,7 +611,7 @@
String details = pException while loading module b
+ entryPointTypeName + /b. See Development Mode for
details./p
+ div style='overflow:visisble;white-space:pre;' + stackTrace
-+ /pre;
++ /div;
invokeNativeVoid(__gwt_displayGlassMessage, null,
new Class[]{String.class, String.class},
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)
http://gwt-code-reviews.appspot.com/1323801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Updated StackTraceDeobfuscator javadoc in follow up to r9162. (issue1321801)
Reviewers: unnurg,
Description:
Updated StackTraceDeobfuscator javadoc in follow up to r9162.
Fixes issues: 5923
Please review this at http://gwt-code-reviews.appspot.com/1321801/show
Affected files:
M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
Index: user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
===
--- user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(revision 9493)
+++ user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(working copy)
@@ -30,16 +30,18 @@
/**
* Deobfuscates stack traces on the server side. This class requires that
you
- * have turned on emulated stack traces and moved your symbolMap files to a
- * place accessible by your server. More concretely, you must compile with
the
- * code-extra/code command line option, copy the
codesymbolMaps/code
- * directory to somewhere your server side code has access to it, and then
set
- * the symbolMapsDirectory in this class through the constructor, or the
setter
- * method. For example, this variable could be set to
- * WEB-INF/classes/symbolMaps/, if you copied the symbolMaps directory to
- * there or compiled your application using
- * code-extra war/WEB-INF/classes//code.
- *
+ * have turned on emulated stack traces, via
+ * codelt;set-property name=compiler.emulatedStack value=true
/gt;/code
+ * in your code.gwt.xml/code module file, and moved your symbol map
files to
+ * a location accessible by your server sever side code. You can use the
GWT
+ * compiler code-deploy/code command line argument to specify the
location
+ * of the folder into which the generated codesymbolMaps/code
directory is
+ * written. By default, the final codesymbolMaps/code directory is
+ * codewar/WEB-INF/deploy/iyourmodulename/i/symbolMaps//code. Pass
the
+ * resulting directory location into this class'
+ * {@link StackTraceDeobfuscator#symbolMapsDirectory} constructor or
+ * {@link #setSymbolMapsDirectory(String)} setter method.
+ *
* TODO(unnurg): Combine this code with similar code in JUnitHostImpl
*/
public class StackTraceDeobfuscator {
@@ -58,9 +60,9 @@
/**
* Constructor, which takes a codesymbolMaps/code directory as its
- * argument. Symbol maps can be generated using the code-extra/code
GWT
- * compiler argument.
- *
+ * argument. Symbol maps are generated into the location specified by the
+ * GWT compiler code-deploy/code command line argument.
+ *
* @param symbolMapsDirectory the codesymbolMaps/code directory
with, or
* without trailing directory separator character
*/
@@ -159,8 +161,8 @@
* Retrieves a new {@link InputStream} for the given permutation strong
name.
* This implementation, which subclasses may override, returns a
* {@link InputStream} for the code
- * ilt;permutation-strong-namegt;/i.symbolMap/code file in the
- * symbolMapsDirectory.
+ * ipermutation-strong-name/i.symbolMap/code file in the
+ * codesymbolMaps/code directory.
*
* @param permutationStrongName the GWT permutation strong name
* @return a new {@link InputStream}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove list of JavaScriptException object properties when compiler.stackTrace = emulated (issue1310802)
http://gwt-code-reviews.appspot.com/1310802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove list of JavaScriptException object properties when compiler.stackTrace = emulated (issue1310802)
http://gwt-code-reviews.appspot.com/1310802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make production mode stack traces match JRE spec more closely (issue1295802)
Committed in r9568 http://gwt-code-reviews.appspot.com/1295802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Make production mode stack traces match JRE spec more closely (issue1295802)
Reviewers: scottb,
Description:
Make production mode stack traces match JRE spec more closely
- Fix StackTraceElement#getFileName(), so that it returns null instead
of Unknown Source
- Fix StackTraceElement#getLineNumber(), so that it returns -1 instead
of 0
- Fix StackTraceElement#toString(), so that lineNumber is omitted when
it is unknown, so that
Unknown.foo(Unknown Source:0) becomes Unknown.foo(Unknown Source)
Review by: sco...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1295802/show
Affected files:
M user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
M user/super/com/google/gwt/emul/java/lang/StackTraceElement.java
Index: user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
===
--- user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
(revision 9493)
+++ user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
(working copy)
@@ -67,8 +67,8 @@
StackTraceElement[] stackTrace = new
StackTraceElement[stack.length()];
for (int i = 0, j = stackTrace.length; i j; i++) {
-stackTrace[i] = new StackTraceElement(Unknown, stack.get(i),
-Unknown source, 0);
+stackTrace[i] = new StackTraceElement(Unknown, stack.get(i),
null,
+LINE_NUMBER_UNKNOWN);
}
e.setStackTrace(stackTrace);
}
@@ -77,8 +77,8 @@
JsArrayString stack = StackTraceCreator.createStackTrace();
StackTraceElement[] stackTrace = new
StackTraceElement[stack.length()];
for (int i = 0, j = stackTrace.length; i j; i++) {
-stackTrace[i] = new StackTraceElement(Unknown, stack.get(i),
-Unknown source, 0);
+stackTrace[i] = new StackTraceElement(Unknown, stack.get(i),
null,
+LINE_NUMBER_UNKNOWN);
}
t.setStackTrace(stackTrace);
}
@@ -145,8 +145,8 @@
for (int i = 0, j = stackTrace.length; i j; i++) {
// Locations is also backwards
String location = locations.get(j - i - 1);
-String fileName = Unknown source;
-int lineNumber = 0;
+String fileName = null;
+int lineNumber = LINE_NUMBER_UNKNOWN;
if (location != null) {
int idx = location.indexOf(':');
if (idx != -1) {
@@ -361,6 +361,8 @@
}
}
+ private static final int LINE_NUMBER_UNKNOWN = -1;
+
/**
* Create a stack trace based on a JavaScriptException. This method
should
* only be called in Production Mode.
Index: user/super/com/google/gwt/emul/java/lang/StackTraceElement.java
===
--- user/super/com/google/gwt/emul/java/lang/StackTraceElement.java
(revision 9493)
+++ user/super/com/google/gwt/emul/java/lang/StackTraceElement.java
(working copy)
@@ -60,7 +60,8 @@
}
public String toString() {
-return className + . + methodName + ( + fileName + : + lineNumber
-+ );
+return className + . + methodName + (
++ (fileName != null ? fileName : Unknown Source)
++ (lineNumber 0 ? : + lineNumber : ) + );
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: At application startup, assert that the specified user.agent selection property value indeed mat... (issue1278801)
http://gwt-code-reviews.appspot.com/1278801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] At application startup, assert that the specified user.agent selection property value indeed mat... (issue1278801)
Reviewers: jat, Description: At application startup, assert that the specified user.agent selection property value indeed matches the expected value for the executing browser / user agent, thus avoid long hours debugging strange error messages when a single user agent compile, typically created for testing purposes, ends up being executed in the wrong browser. In other words, this patches saves you from pulling your hair out. Fixes isuess: 5861 Please review this at http://gwt-code-reviews.appspot.com/1278801/show Affected files: M user/src/com/google/gwt/user/UserAgent.gwt.xml A user/src/com/google/gwt/user/client/UserAgentAsserter.java A user/src/com/google/gwt/user/rebind/RuntimeUserAgentGenerator.java A user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: At application startup, assert that the specified user.agent selection property value indeed mat... (issue1278801)
http://gwt-code-reviews.appspot.com/1278801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)
http://gwt-code-reviews.appspot.com/1229801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Re-enable a few style tests now that old linux hosted mode is gone (issue1228801)
http://gwt-code-reviews.appspot.com/1228801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
http://gwt-code-reviews.appspot.com/1221801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re-enable a few style tests now that old linux hosted mode is gone (issue1228801)
Reviewers: zundel,
Description:
Re-enable a few style tests now that old linux hosted mode is gone
Please review this at http://gwt-code-reviews.appspot.com/1228801/show
Affected files:
M user/test/com/google/gwt/dom/client/StyleTest.java
Index: user/test/com/google/gwt/dom/client/StyleTest.java
===
--- user/test/com/google/gwt/dom/client/StyleTest.java (revision 9425)
+++ user/test/com/google/gwt/dom/client/StyleTest.java (working copy)
@@ -85,14 +85,13 @@
style.setCursor(Cursor.HELP);
assertEquals(Cursor.HELP, style.getCursor());
-// These aren't supported on old mozilla, so testing them will break.
-// TODO: re-enable these cases when we finally drop linux hosted mode.
-/*
+// Note, this test will fail on old mozilla due to unsupported style
style.setCursor(Cursor.COL_RESIZE);
assertEquals(Cursor.COL_RESIZE, style.getCursor());
+
+// Note, this test will fail on old mozilla due to unsupported style
style.setCursor(Cursor.ROW_RESIZE);
assertEquals(Cursor.ROW_RESIZE, style.getCursor());
-*/
}
public void testDisplay() {
@@ -106,12 +105,9 @@
style.setDisplay(Display.INLINE);
assertEquals(Display.INLINE, style.getDisplay());
-// Not supported on old mozilla, so testing it will break.
-// TODO: re-enable these cases when we finally drop linux hosted mode.
-/*
+// Note, this test will fail on old mozilla due to unsupported style
style.setDisplay(Display.INLINE_BLOCK);
assertEquals(Display.INLINE_BLOCK, style.getDisplay());
-*/
}
public void testFontStyle() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)
Reviewers: zundel,
Description:
Re-enable XML parse test, which was previously failing in one Safari
configuration in Production Mode in the 1.5 release branch
Please review this at http://gwt-code-reviews.appspot.com/1229801/show
Affected files:
M user/test/com/google/gwt/xml/client/XMLTest.java
Index: user/test/com/google/gwt/xml/client/XMLTest.java
===
--- user/test/com/google/gwt/xml/client/XMLTest.java(revision 9425)
+++ user/test/com/google/gwt/xml/client/XMLTest.java(working copy)
@@ -321,12 +321,10 @@
}
/**
- * This test is failing on one Safari configuration in web mode in the
1.5
- * release branch, but it passes in all other configurations and in the
trunk.
- * The files in the xml package are identical between the trunk and the
1.5
- * branch.
+ * At one point, this test was failing on one Safari configuration in
+ * Production Mode in the 1.5 release branch.
*/
- public void disabledTestParse() {
+ public void testParse() {
Document docA = XMLParser.parse(!--hello-- a spam=\ham\\n
?pi hello ?dfgdfg b/\t/a);
Document docB = XMLParser.createDocument();
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
Addressed feedback and moved StyleTest and XMLTest to separate issues:
Re-enable a few style tests now that old linux hosted mode is gone
http://gwt-code-reviews.appspot.com/1228801
Re-enable XML parse test, which was previously failing in one Safari
configuration in Production Mode in the 1.5 release branch
http://gwt-code-reviews.appspot.com/1229801
http://gwt-code-reviews.appspot.com/1221801/diff/1/35
File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/35#newcode195
user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:195: * In
hosted-mode, the field's declaring class is written to the stream to
On 2010/12/15 23:49:34, zundel wrote:
s/hosted-mode/Development Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/40
File
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode25
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:25:
* SafeHtml utilities whose implementation differs between hosted and
Production
On 2010/12/15 23:49:34, zundel wrote:
s/hosted/Development
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode29
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:29:
* This class has a super-source peer that provides the web-mode
implementation.
On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/41
File user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode71
user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:71: *
details). For performance reasons, this check is not performed in prod
mode
On 2010/12/15 23:49:34, zundel wrote:
s/prod/Production Mode ?
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode76
user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:76: * @throws
IllegalArgumentException if not running in prod mode and {...@code
On 2010/12/15 23:49:34, zundel wrote:
s/prod/Production Mode ?
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/52
File
user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/52#newcode207
user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java:207:
// hosted
On 2010/12/15 23:49:34, zundel wrote:
Development Mode... although this isn't a javadoc comment
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/54
File user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode60
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:60: //
Try something you can't do in web-mode (JRE code)
On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode63
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:63: //
Try something you can't do in web-mode (server code)
On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/59
File user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/59#newcode24
user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java:24: *
Development Mode due to browser inconsistencies; however it should run
in web
On 2010/12/15 23:49:34, zundel wrote:
s/web/Production
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/61
File user/test/com/google/gwt/dom/client/StyleTest.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/61#newcode110
user/test/com/google/gwt/dom/client/StyleTest.java:110: // TODO:
re-enable these cases when we finally drop linux Development Mode.
On 2010/12/15 23:49:34, zundel wrote:
Hey, we can probably re-enable these now!
I'll move this change to a separate patch
http://gwt-code-reviews.appspot.com/1221801/diff/1/76
File user/test/com/google/gwt/xml/client/XMLTest.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/76#newcode328
user/test/com/google/gwt/xml/client/XMLTest.java:328: */
On 2010/12/15 23:49:34, zundel wrote:
umm, maybe time to re-enable this test too?
I'll create a separate patch to re-enable this test
http://gwt-code-reviews.appspot.com/1221801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
Reviewers: zundel, Description: Replace most user/developer visible references to hosted/web mode with Development/Production Mode Please review this at http://gwt-code-reviews.appspot.com/1221801/show Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/HostedModeTemplate.js M dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js M dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html M dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java M dev/core/src/com/google/gwt/dev/shell/HostedModeException.java M dev/core/src/com/google/gwt/dev/shell/ModuleSpacePropertyOracle.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDisableAggressiveOptimization.java M dev/core/super/com/google/gwt/core/client/GWTBridge.java M dev/core/super/com/google/gwt/core/client/GwtScriptOnly.java M dev/core/super/com/google/gwt/lang/LongLibBase.java M dev/core/test/com/google/gwt/dev/javac/JsniCheckerTest.java M user/src/com/google/gwt/benchmarks/client/impl/BenchmarkResults.java M user/src/com/google/gwt/canvas/dom/client/Context2d.java M user/src/com/google/gwt/canvas/dom/client/CssColor.java M user/src/com/google/gwt/core/client/Duration.java M user/src/com/google/gwt/core/client/GWT.java M user/src/com/google/gwt/core/client/JavaScriptException.java M user/src/com/google/gwt/core/client/JavaScriptObject.java M user/src/com/google/gwt/core/client/JsArrayBoolean.java M user/src/com/google/gwt/core/client/JsArrayInteger.java M user/src/com/google/gwt/core/client/JsArrayNumber.java M user/src/com/google/gwt/core/client/impl/Impl.java M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/src/com/google/gwt/core/client/impl/StackTraceCreator.java M user/src/com/google/gwt/core/client/impl/WeakMapping.java M user/src/com/google/gwt/core/client/prefetch/Prefetcher.java M user/src/com/google/gwt/junit/RunStyle.java M user/src/com/google/gwt/junit/RunStyleExternalBrowser.java M user/src/com/google/gwt/junit/RunStyleManual.java M user/src/com/google/gwt/junit/RunStyleRemoteWeb.java M user/src/com/google/gwt/junit/client/GWTTestCase.java M user/src/com/google/gwt/rpc/client/impl/ClientWriterFactory.java M user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java M user/src/com/google/gwt/rpc/server/HostedModeClientOracle.java M user/src/com/google/gwt/rpc/server/RpcServlet.java M user/src/com/google/gwt/rpc/server/SimplePayloadDecoder.java M user/src/com/google/gwt/safehtml/shared/SafeHtmlBuilder.java M user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java M user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java M user/src/com/google/gwt/user/client/Event.java M user/src/com/google/gwt/user/client/impl/DOMImpl.java M user/src/com/google/gwt/user/client/rpc/impl/SerializerBase.java M user/src/com/google/gwt/user/rebind/rpc/SerializationUtils.java M user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java M user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java M user/test/com/google/gwt/benchmarks/client/BenchmarkTest.java M user/test/com/google/gwt/core/client/JavaScriptExceptionTest.java M user/test/com/google/gwt/core/client/JsArrayTest.java M user/test/com/google/gwt/core/client/impl/StackTraceCreatorTest.java M user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java M user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyClass.java M user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java M user/test/com/google/gwt/dev/jjs/test/ClassObjectTest.java M user/test/com/google/gwt/dev/jjs/test/CompilerTest.java M user/test/com/google/gwt/dev/jjs/test/HostedTest.java M user/test/com/google/gwt/dev/jjs/test/JStaticEvalTest.java M user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java M user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java M user/test/com/google/gwt/dom/client/StyleTest.java M user/test/com/google/gwt/emultest/benchmarks/java/util/ArraySortBenchmark.java M user/test/com/google/gwt/emultest/java/lang/CompilerConstantStringTest.java M user/test/com/google/gwt/emultest/java/lang/StringTest.java M user/test/com/google/gwt/emultest/java/math/BigDecimalCompareTest.java M user/test/com/google/gwt/emultest/java/util/IdentityHashMapTest.java M user/test/com/google/gwt/emultest/java/util/LinkedHashMapTest.java M user/test/com/google/gwt/emultest/java/util/TreeMapTest.java M user/test/com/google/gwt/emultest/java/util/TreeSetTest.java M user/test/com/google/gwt/event/shared/HandlerManagerTest.java M user/test/com/google/gwt/json/client/JSONTest.java M user/test/com/google/gwt/regexp/shared/RegExpTest.java M user/test/com/google/gwt/resources/client/TextResourceTest.java M user/test/com/google/gwt/user/client/AsyncProxyTest.java M
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
http://gwt-code-reviews.appspot.com/1221801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Modifications to StackTraceDeobfuscator: (issue1189801)
http://gwt-code-reviews.appspot.com/1189801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Modifications to StackTraceDeobfuscator: (issue1189801)
Committed as r9361 http://gwt-code-reviews.appspot.com/1189801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Modifications to StackTraceDeobfuscator: (issue1189801)
Reviewers: unnurg, Description: Modifications to StackTraceDeobfuscator: - Introduces a new protected method, getSymbolMapInputStream(), to obtain a symbol map InputStream for a given permutation strong name, to be overridden by subclasses. - Makes the deobfuscateStackTrace() convenience method public - Multiple lookups for a given permutations's, non-existent or broken, symbol map file no longer results in repeated attempt to access or parse the file - Javadoc additions Please review this at http://gwt-code-reviews.appspot.com/1189801/show Affected files: M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Modifications to StackTraceDeobfuscator: (issue1189801)
http://gwt-code-reviews.appspot.com/1189801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test whether the new 'compiler.st... (issue1174801)
Committed in r9344 http://gwt-code-reviews.appspot.com/1174801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] The symbolMaps directory provided to StackTraceDeobfuscator should accepts directory name with (issue1180801)
Reviewers: unnurg,
Description:
The symbolMaps directory provided to StackTraceDeobfuscator should
accepts directory name with
and without a trailing directory separator character
Fixes Issues: 5703
Please review this at http://gwt-code-reviews.appspot.com/1180801/show
Affected files:
M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
Index: user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
===
--- user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(revision 9344)
+++ user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(working copy)
@@ -17,6 +17,7 @@
package com.google.gwt.logging.server;
import java.io.BufferedReader;
+import java.io.File;
import java.io.FileReader;
import java.io.IOException;
import java.util.HashMap;
@@ -33,7 +34,8 @@
* server side code has access to it, and then set the symbolMapsDirectory
in
* this class through the constructor, or the setter method.
* For example, this variable could be set to WEB-INF/classes/symbolMaps/
- * if you copied the symbolMaps directory to there.
+ * if you copied the symbolMaps directory to there or compiled your
application
+ * using code-extra war/WEB-INF/classes//code.
*
* TODO(unnurg): Combine this code with similar code in JUnitHostImpl
*/
@@ -46,13 +48,21 @@
private static Pattern JsniRefPattern =
Pattern.compile(@?([^:]+)::([^(]+)(\\((.*)\\))?);
- private String symbolMapsDirectory;
+ private File symbolMapsDirectory;
private MapString, SymbolMap symbolMaps =
new HashMapString, SymbolMap();
-
+
+ /**
+ * Constructor, which takes a codesymbolMaps/code directory as its
+ * argument. Symbol maps can be generated using the code-extra/code
GWT
+ * compiler argument.
+ *
+ * @param symbolMapsDirectory the codesymbolMaps/code directory
with, or
+ * without trailing directory separator character
+ */
public StackTraceDeobfuscator(String symbolMapsDirectory) {
-this.symbolMapsDirectory = symbolMapsDirectory;
+setSymbolMapsDirectory(symbolMapsDirectory);
}
public LogRecord deobfuscateLogRecord(LogRecord lr, String strongName) {
@@ -95,15 +105,9 @@
return ste;
}
- public void setSymbolMapsDirectory(String dir) {
-// Switching the directory should clear the symbolMaps variable (which
-// is read in lazily), but causing the symbolMaps variable to be
re-read
-// is somewhat expensive, so we only want to do this if the directory
is
-// actually different.
-if (!dir.equals(symbolMapsDirectory)) {
- symbolMapsDirectory = dir;
- symbolMaps = new HashMapString, SymbolMap();
-}
+ public void setSymbolMapsDirectory(String symbolMapsDirectory) {
+// permutations are unique, no need to clear the symbolMaps hash map
+this.symbolMapsDirectory = new File(symbolMapsDirectory);
}
private StackTraceElement[] deobfuscateStackTrace(
@@ -136,9 +140,10 @@
}
toReturn = new SymbolMap();
String line;
-String filename = symbolMapsDirectory + strongName + .symbolMap;
try {
+ String filename = symbolMapsDirectory.getCanonicalPath()
+ + File.separatorChar + strongName + .symbolMap;
BufferedReader bin = new BufferedReader(new FileReader(filename));
try {
while ((line = bin.readLine()) != null) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: The symbolMaps directory provided to StackTraceDeobfuscator should accepts directory name with (issue1180801)
Committed in r9349 http://gwt-code-reviews.appspot.com/1180801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove stray javadoc character. (issue1075801)
Committed in r9186 http://gwt-code-reviews.appspot.com/1075801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Cleanup DOM after DoubleClickEventSinkTest tests complete (issue1150801)
Committed in r9292 http://gwt-code-reviews.appspot.com/1150801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make the following method public in StackTraceDeobfuscator, for reuse by user server side code: (issue1040801)
Committed in r9131 http://gwt-code-reviews.appspot.com/1040801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test whether the new 'compiler.st... (issue1174801)
Reviewers: jat, Description: Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test whether the new 'compiler.stackMode' configuration property is set to 'emulated', rather than testing the legacy boolean configuration property 'compiler.emulatedStack'. This will allow developers to specify either syntax reliably and allow us to potentially phase out the legacy syntax at some point: !-- new syntax -- set-property name=compiler.stackMode value=emulated / or !-- legacy syntax -- set-property name=compiler.emulatedStack value=true / Fixes issues: 5692 Please review this at http://gwt-code-reviews.appspot.com/1174801/show Affected files: M user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml M user/src/com/google/gwt/core/EmulateJsStack.gwt.xml Index: user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml === --- user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml (revision 9305) +++ user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml (working copy) @@ -18,7 +18,7 @@ replace-with class=com.google.gwt.core.client.impl.StackTraceCreator.CollectorChrome when-type-is class=com.google.gwt.core.client.impl.StackTraceCreator.Collector / -when-property-is name=compiler.emulatedStack value=false / +when-property-is name=compiler.stackMode value=native / any !-- For now, only Chrome provides Error.stack support, so we hijack the entire WebKit permutation -- @@ -28,13 +28,13 @@ replace-with class=com.google.gwt.core.client.impl.StackTraceCreator.CollectorMoz when-type-is class=com.google.gwt.core.client.impl.StackTraceCreator.Collector / -when-property-is name=compiler.emulatedStack value=false / +when-property-is name=compiler.stackMode value=native / when-property-is name=user.agent value=gecko1_8 / /replace-with replace-with class=com.google.gwt.core.client.impl.StackTraceCreator.CollectorOpera when-type-is class=com.google.gwt.core.client.impl.StackTraceCreator.Collector / -when-property-is name=compiler.emulatedStack value=false / +when-property-is name=compiler.stackMode value=native / any when-property-is name=user.agent value=opera / /any Index: user/src/com/google/gwt/core/EmulateJsStack.gwt.xml === --- user/src/com/google/gwt/core/EmulateJsStack.gwt.xml (revision 9305) +++ user/src/com/google/gwt/core/EmulateJsStack.gwt.xml (working copy) @@ -17,6 +17,7 @@ module inherits name=com.google.gwt.core.Core / + !-- Legacy property, use 'compiler.stackMode' instead -- !-- If set to true, emulated stack frames will be emitted into the JS -- define-property name=compiler.emulatedStack values=true,false / set-property name=compiler.emulatedStack value=false / @@ -29,16 +30,16 @@ define-configuration-property name=compiler.emulatedStack.recordFileNames is-multi-valued=false / - replace-with - class=com.google.gwt.core.client.impl.StackTraceCreator.CollectorEmulated -when-type-is class=com.google.gwt.core.client.impl.StackTraceCreator.Collector / -when-property-is name=compiler.emulatedStack value=true / - /replace-with - !-- if set to 'strip', stack information can be removed or corrupted -- define-property name=compiler.stackMode values=strip,native,emulated / set-property name=compiler.stackMode value=native / set-property name=compiler.stackMode value=emulated when-property-is name=compiler.emulatedStack value=true / /set-property + + replace-with + class=com.google.gwt.core.client.impl.StackTraceCreator.CollectorEmulated +when-type-is class=com.google.gwt.core.client.impl.StackTraceCreator.Collector / +when-property-is name=compiler.stackMode value=emulated / + /replace-with /module -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] StackTraceDeobfuscator now extracts source file and (method declaration) line number information... (issue1175801)
Reviewers: unnurg,
Description:
StackTraceDeobfuscator now extracts source file and (method declaration)
line number information from
the provided symbol map file, when this information is not provided by
optionally enabled stack trace emulation.
Fixes issues: 5682
Please review this at http://gwt-code-reviews.appspot.com/1175801/show
Affected files:
M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
Index: user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
===
--- user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(revision 9305)
+++ user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(working copy)
@@ -73,8 +73,22 @@
if (parts.length == 5) {
String[] ref = parse(
parts[0].substring(0, parts[0].lastIndexOf(')') + 1));
-return new StackTraceElement(
-ref[0], ref[1], ste.getFileName(), ste.getLineNumber());
+
+// parts[3] contains the source file URI or Unknown
+String filename = Unknown.equals(parts[3]) ? null
+: parts[3].substring(parts[3].lastIndexOf('/') + 1);
+
+int lineNumber = ste.getLineNumber();
+/*
+ * When lineNumber is zero, either because compiler.stackMode is
not
+ * emulated or compiler.emulatedStack.recordLineNumbers is false,
use
+ * the method declaration line number from the symbol map.
+ */
+if (lineNumber == 0) {
+ lineNumber = Integer.parseInt(parts[4]);
+}
+
+return new StackTraceElement(ref[0], ref[1], filename, lineNumber);
}
}
// If anything goes wrong, just return the unobfuscated element
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test whether the new 'compiler.st... (issue1174801)
http://gwt-code-reviews.appspot.com/1174801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
