[gwt-contrib] Remove escaped HTML from devevelopment mode glass panel (issue1514803)

2011-08-05 Thread fredsa
Reviewers: rjrjr, Description: Remove escaped HTML from devevelopment mode glass panel Please review this at http://gwt-code-reviews.appspot.com/1514803/ Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js M

[gwt-contrib] Re: Remove escaped HTML from devevelopment mode glass panel (issue1514803)

2011-08-05 Thread fredsa
Committed in r10504 http://gwt-code-reviews.appspot.com/1514803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix typo (issue1497807)

2011-08-04 Thread fredsa
Reviewers: unnurg, Description: Fix typo Fixes issues: 5912 Review by: unn...@google.com Please review this at http://gwt-code-reviews.appspot.com/1497807/ Affected files: M user/src/com/google/gwt/regexp/shared/RegExp.java Index: user/src/com/google/gwt/regexp/shared/RegExp.java

[gwt-contrib] Re: Fix typo (issue1497807)

2011-08-04 Thread fredsa
committed in r10494 http://gwt-code-reviews.appspot.com/1497807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix typo (issue1497807)

2011-08-04 Thread fredsa
Test message. Please ignore. http://gwt-code-reviews.appspot.com/1497807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix typo (issue1497807)

2011-08-04 Thread fredsa
2nd test message. http://gwt-code-reviews.appspot.com/1497807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: DirectInstallLinker should not immediately remove the script tag it has inserted into the IFRAME... (issue1454802)

2011-07-25 Thread fredsa
Committed in r10293 http://gwt-code-reviews.appspot.com/1454802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Use glass panel isntead of alert() when displaying dev mode connection failures, (issue1449802)

2011-07-25 Thread fredsa
Committed in r10204 http://gwt-code-reviews.appspot.com/1449802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)

2011-07-25 Thread fredsa
Committed in r9944 http://gwt-code-reviews.appspot.com/1398802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

2011-07-25 Thread fredsa
Committed in r9918 http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix Javadoc for gesture/touch events (issue1383805)

2011-07-25 Thread fredsa
Committed in r9869 http://gwt-code-reviews.appspot.com/1383805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)

2011-07-25 Thread fredsa
Committed in r9756 http://gwt-code-reviews.appspot.com/1338804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Include the property name in the error message when a single-valued property does not have exact... (issue1348801)

2011-07-25 Thread fredsa
Committed in r9702 http://gwt-code-reviews.appspot.com/1348801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove list of JavaScriptException object properties when compiler.stackTrace = emulated (issue1310802)

2011-07-25 Thread fredsa
Committed in r9672 http://gwt-code-reviews.appspot.com/1310802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated StackTraceDeobfuscator javadoc in follow up to r9162. (issue1321801)

2011-07-25 Thread fredsa
Committed in r9604 http://gwt-code-reviews.appspot.com/1321801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)

2011-07-25 Thread fredsa
Committed in r9503 http://gwt-code-reviews.appspot.com/1229801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-enable a few style tests now that old linux hosted mode is gone (issue1228801)

2011-07-25 Thread fredsa
Committed in r9499 http://gwt-code-reviews.appspot.com/1228801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)

2011-07-25 Thread fredsa
Committed in r9459 http://gwt-code-reviews.appspot.com/1221801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)

2011-07-25 Thread fredsa
Committed in r9758 http://gwt-code-reviews.appspot.com/1323801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Handle cases where element.canPlayType() returns 'no' instead of the empty string on some browsers. (issue1362802)

2011-07-25 Thread fredsa
Committed in r9868 http://gwt-code-reviews.appspot.com/1362802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)

2011-07-25 Thread fredsa
Committed in r10204 http://gwt-code-reviews.appspot.com/1422816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Follow up to r10350. Allow collapse-all-properties in .gwt.xml module files (issue1463806)

2011-06-29 Thread fredsa
ping http://gwt-code-reviews.appspot.com/1463806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update XML doc to make it clearer that 'compiler.emulatedStack' should no longer be used. (issue1462804)

2011-06-29 Thread fredsa
ping http://gwt-code-reviews.appspot.com/1462804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update gwt-module.dtd: (issue1466801)

2011-06-20 Thread fredsa
Committed in r10350 http://gwt-code-reviews.appspot.com/1466801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Follow up to r10350. Allow collapse-all-properties in .gwt.xml module files (issue1463806)

2011-06-20 Thread fredsa
Reviewers: rjrjr, Description: Follow up to r10350. Allow collapse-all-properties in .gwt.xml module files Fixes issues: 5694 Please review this at http://gwt-code-reviews.appspot.com/1463806/ Affected files: M distro-source/core/src/gwt-module.dtd Index:

[gwt-contrib] Add a new 'SERVER' level to TreeLogger, which is to be used by the App Engine (issue1465804)

2011-06-20 Thread fredsa
Reviewers: tobyr, Description: Add a new 'SERVER' level to TreeLogger, which is to be used by the App Engine DevAppServer to log all server messages to the GWT TreeLogger, regardless of the current GWT log_level. Issues: http://code.google.com/p/googleappengine/issues/detail?id=4591 Review by:

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa
http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa
http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right): http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode461

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa
http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa
http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):

[gwt-contrib] Update XML doc to make it clearer that 'compiler.emulatedStack' should no longer be used. (issue1462804)

2011-06-17 Thread fredsa
Reviewers: bobv, Description: Update XML doc to make it clearer that 'compiler.emulatedStack' should no longer be used. Review by: b...@google.com Please review this at http://gwt-code-reviews.appspot.com/1462804/ Affected files: M user/src/com/google/gwt/core/EmulateJsStack.gwt.xml

[gwt-contrib] Update gwt-module.dtd: (issue1466801)

2011-06-17 Thread fredsa
Reviewers: rjrjr, Description: Update gwt-module.dtd: - Add support for set-property-fallback, e.g. set-property-fallback name=locale value=en/ - Add support for fallback-value attribute to extend-property, e.g. extend-property name=user.agent values=ie9 fallback-value=ie8 / Fixes issues: 4787,

[gwt-contrib] Re: Update gwt-module.dtd: (issue1466801)

2011-06-17 Thread fredsa
http://gwt-code-reviews.appspot.com/1466801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa
Committed in r10347 http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-16 Thread fredsa
http://gwt-code-reviews.appspot.com/1407803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes a bug in StackTraceDeobfuscator where line numbers from the symbol map were being used in ... (issue1457801)

2011-06-08 Thread fredsa
LGTM http://gwt-code-reviews.appspot.com/1457801/diff/4001/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java File user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java (right):

[gwt-contrib] Making media events bitless, freeing up a few event bits, since modern, (issue1447816)

2011-06-03 Thread fredsa
Reviewers: jlabanca, Description: Making media events bitless, freeing up a few event bits, since modern, implementing browsers don't leak the way old ones did. The following constants, marked as 'experimental', have been removed: - com.google.gwt.user.client.Event.MEDIAEVENTS -

[gwt-contrib] Re: Making media events bitless, freeing up a few event bits, since modern, (issue1447816)

2011-06-03 Thread fredsa
Yep and yep. Thanks. http://gwt-code-reviews.appspot.com/1447816/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java (right):

[gwt-contrib] Re: Making media events bitless, freeing up a few event bits, since modern, (issue1447816)

2011-06-03 Thread fredsa
http://gwt-code-reviews.appspot.com/1447816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Making media events bitless, freeing up a few event bits, since modern, (issue1447816)

2011-06-03 Thread fredsa
Committed as r10274 http://gwt-code-reviews.appspot.com/1447816/diff/2002/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java (right):

[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)

2011-05-20 Thread fredsa
http://gwt-code-reviews.appspot.com/1422816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)

2011-05-20 Thread fredsa
http://gwt-code-reviews.appspot.com/1422816/diff/8001/user/src/com/google/gwt/user/client/DocumentModeAsserter.java File user/src/com/google/gwt/user/client/DocumentModeAsserter.java (right):

[gwt-contrib] Use glass panel isntead of alert() when displaying dev mode connection failures, (issue1449802)

2011-05-17 Thread fredsa
Reviewers: jlabanca, Description: Use glass panel isntead of alert() when displaying dev mode connection failures, because modal dialog boxes are annoying and consume unnecessary keystrokes or mouse clicks before you are able to refresh the page. Please review this at

[gwt-contrib] Re: Use glass panel isntead of alert() when displaying dev mode connection failures, (issue1449802)

2011-05-17 Thread fredsa
http://gwt-code-reviews.appspot.com/1449802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)

2011-05-17 Thread fredsa
http://gwt-code-reviews.appspot.com/1422816/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)

2011-05-17 Thread fredsa
This change now introduces only a Development Mode warning (to the GWT treelogger), which an option to suppress it (for those who know what they are doing, or to raise the severity to a runtime error, which we can do in a later release

[gwt-contrib] 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE d... (issue1422816)

2011-05-03 Thread fredsa
Reviewers: jlabanca, Description: 1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with an appropriate DOCTYPE declaration), e.g !doctype html 2. Provide a new configuration property to indicate the required browser rendering mode, which can be used to suppress the above

[gwt-contrib] New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-04-07 Thread fredsa
Reviewers: pdr, Description: New projects should always have a DTD specified in their template .gwt.xml module file Also, fix broken NoNag version check logic. Please review this at http://gwt-code-reviews.appspot.com/1407803/ Affected files: M

[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)

2011-04-05 Thread fredsa
http://gwt-code-reviews.appspot.com/1398802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)

2011-04-05 Thread fredsa
http://gwt-code-reviews.appspot.com/1398802/diff/1/user/src/com/google/gwt/event/dom/client/DragExitEvent.java File user/src/com/google/gwt/event/dom/client/DragExitEvent.java (right):

[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)

2011-04-04 Thread fredsa
http://gwt-code-reviews.appspot.com/1398802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add the beginnings of new HTML5 drag and drop events (issue1398802)

2011-03-31 Thread fredsa
Reviewers: pdr, Description: Add the beginnings of new HTML5 drag and drop events Please review this at http://gwt-code-reviews.appspot.com/1398802/ Affected files: A user/src/com/google/gwt/event/dom/client/DragEnterClickHandler.java A

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

2011-03-30 Thread fredsa
http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

2011-03-30 Thread fredsa
http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

2011-03-21 Thread fredsa
http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/event/dom/client/EndedHandler.java File user/src/com/google/gwt/event/dom/client/EndedHandler.java (right):

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

2011-03-21 Thread fredsa
http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix Javadoc for gesture/touch events (issue1383805)

2011-03-19 Thread fredsa
Reviewers: pdr, Description: Fix Javadoc for gesture/touch events Review by: p...@google.com Please review this at http://gwt-code-reviews.appspot.com/1383805/ Affected files: M user/src/com/google/gwt/event/dom/client/HasGestureChangeHandlers.java M

[gwt-contrib] Add media events for audio/video elements (issue1385804)

2011-03-19 Thread fredsa
Reviewers: pdr, Description: Add media events for audio/video elements Please review this at http://gwt-code-reviews.appspot.com/1385804/ Affected files: M dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java A user/src/com/google/gwt/event/dom/client/EndedEvent.java A

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

2011-03-19 Thread fredsa
http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Handle cases where element.canPlayType() returns 'no' instead of the empty string on some browsers. (issue1362802)

2011-02-23 Thread fredsa
Reviewers: jgw, Description: Handle cases where element.canPlayType() returns 'no' instead of the empty string on some browsers. Review by: j...@google.com Please review this at http://gwt-code-reviews.appspot.com/1362802/ Affected files: M

[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)

2011-02-22 Thread fredsa
http://gwt-code-reviews.appspot.com/1338804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)

2011-02-22 Thread fredsa
http://gwt-code-reviews.appspot.com/1323801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)

2011-02-09 Thread fredsa
http://gwt-code-reviews.appspot.com/1323801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)

2011-02-09 Thread fredsa
http://gwt-code-reviews.appspot.com/1338804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Include the property name in the error message when a single-valued property does not have exact... (issue1348801)

2011-02-08 Thread fredsa
Reviewers: jat, Description: Include the property name in the error message when a single-valued property does not have exactly one value Please review this at http://gwt-code-reviews.appspot.com/1348801/show Affected files: M

[gwt-contrib] Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)

2011-02-03 Thread fredsa
Reviewers: robertvawter, Description: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulatedStack' property, with the corresponding 'compiler.stackMode'. Fixes issues: 5692 Please review this at http://gwt-code-reviews.appspot.com/1338804/show

[gwt-contrib] Re: Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter (issue1334801)

2011-01-28 Thread fredsa
LGTM http://gwt-code-reviews.appspot.com/1334801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: At application startup, assert that the specified user.agent selection property value indeed mat... (issue1278801)

2011-01-28 Thread fredsa
Committed in r9643 http://gwt-code-reviews.appspot.com/1278801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove list of JavaScriptException object properties when compiler.stackTrace = emulated (issue1310802)

2011-01-28 Thread fredsa
http://gwt-code-reviews.appspot.com/1310802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] - Use z-index to layer multiple notifications in hosted.html (issue1323801)

2011-01-25 Thread fredsa
Reviewers: knorton, Description: - Use z-index to layer multiple notifications in hosted.html - ModuleSpace.java produces well formed HTML, replacing /pre with /div Please review this at http://gwt-code-reviews.appspot.com/1323801/show Affected files: M

[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)

2011-01-25 Thread fredsa
http://gwt-code-reviews.appspot.com/1323801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updated StackTraceDeobfuscator javadoc in follow up to r9162. (issue1321801)

2011-01-24 Thread fredsa
Reviewers: unnurg, Description: Updated StackTraceDeobfuscator javadoc in follow up to r9162. Fixes issues: 5923 Please review this at http://gwt-code-reviews.appspot.com/1321801/show Affected files: M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java Index:

[gwt-contrib] Re: Remove list of JavaScriptException object properties when compiler.stackTrace = emulated (issue1310802)

2011-01-20 Thread fredsa
http://gwt-code-reviews.appspot.com/1310802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove list of JavaScriptException object properties when compiler.stackTrace = emulated (issue1310802)

2011-01-20 Thread fredsa
http://gwt-code-reviews.appspot.com/1310802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make production mode stack traces match JRE spec more closely (issue1295802)

2011-01-19 Thread fredsa
Committed in r9568 http://gwt-code-reviews.appspot.com/1295802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Make production mode stack traces match JRE spec more closely (issue1295802)

2011-01-18 Thread fredsa
Reviewers: scottb, Description: Make production mode stack traces match JRE spec more closely - Fix StackTraceElement#getFileName(), so that it returns null instead of Unknown Source - Fix StackTraceElement#getLineNumber(), so that it returns -1 instead of 0 - Fix StackTraceElement#toString(),

[gwt-contrib] Re: At application startup, assert that the specified user.agent selection property value indeed mat... (issue1278801)

2011-01-13 Thread fredsa
http://gwt-code-reviews.appspot.com/1278801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] At application startup, assert that the specified user.agent selection property value indeed mat... (issue1278801)

2011-01-11 Thread fredsa
Reviewers: jat, Description: At application startup, assert that the specified user.agent selection property value indeed matches the expected value for the executing browser / user agent, thus avoid long hours debugging strange error messages when a single user agent compile, typically created

[gwt-contrib] Re: At application startup, assert that the specified user.agent selection property value indeed mat... (issue1278801)

2011-01-11 Thread fredsa
http://gwt-code-reviews.appspot.com/1278801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)

2011-01-05 Thread fredsa
http://gwt-code-reviews.appspot.com/1229801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-enable a few style tests now that old linux hosted mode is gone (issue1228801)

2011-01-05 Thread fredsa
http://gwt-code-reviews.appspot.com/1228801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)

2010-12-16 Thread fredsa
http://gwt-code-reviews.appspot.com/1221801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re-enable a few style tests now that old linux hosted mode is gone (issue1228801)

2010-12-16 Thread fredsa
Reviewers: zundel, Description: Re-enable a few style tests now that old linux hosted mode is gone Please review this at http://gwt-code-reviews.appspot.com/1228801/show Affected files: M user/test/com/google/gwt/dom/client/StyleTest.java Index:

[gwt-contrib] Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)

2010-12-16 Thread fredsa
Reviewers: zundel, Description: Re-enable XML parse test, which was previously failing in one Safari configuration in Production Mode in the 1.5 release branch Please review this at http://gwt-code-reviews.appspot.com/1229801/show Affected files: M

[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)

2010-12-16 Thread fredsa
Addressed feedback and moved StyleTest and XMLTest to separate issues: Re-enable a few style tests now that old linux hosted mode is gone http://gwt-code-reviews.appspot.com/1228801 Re-enable XML parse test, which was previously failing in one Safari configuration in Production Mode in the

[gwt-contrib] Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)

2010-12-15 Thread fredsa
Reviewers: zundel, Description: Replace most user/developer visible references to hosted/web mode with Development/Production Mode Please review this at http://gwt-code-reviews.appspot.com/1221801/show Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/HostedModeTemplate.js

[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)

2010-12-15 Thread fredsa
http://gwt-code-reviews.appspot.com/1221801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modifications to StackTraceDeobfuscator: (issue1189801)

2010-12-06 Thread fredsa
http://gwt-code-reviews.appspot.com/1189801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modifications to StackTraceDeobfuscator: (issue1189801)

2010-12-06 Thread fredsa
Committed as r9361 http://gwt-code-reviews.appspot.com/1189801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Modifications to StackTraceDeobfuscator: (issue1189801)

2010-12-03 Thread fredsa
Reviewers: unnurg, Description: Modifications to StackTraceDeobfuscator: - Introduces a new protected method, getSymbolMapInputStream(), to obtain a symbol map InputStream for a given permutation strong name, to be overridden by subclasses. - Makes the deobfuscateStackTrace() convenience method

[gwt-contrib] Re: Modifications to StackTraceDeobfuscator: (issue1189801)

2010-12-03 Thread fredsa
http://gwt-code-reviews.appspot.com/1189801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test whether the new 'compiler.st... (issue1174801)

2010-12-02 Thread fredsa
Committed in r9344 http://gwt-code-reviews.appspot.com/1174801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] The symbolMaps directory provided to StackTraceDeobfuscator should accepts directory name with (issue1180801)

2010-12-02 Thread fredsa
Reviewers: unnurg, Description: The symbolMaps directory provided to StackTraceDeobfuscator should accepts directory name with and without a trailing directory separator character Fixes Issues: 5703 Please review this at http://gwt-code-reviews.appspot.com/1180801/show Affected files: M

[gwt-contrib] Re: The symbolMaps directory provided to StackTraceDeobfuscator should accepts directory name with (issue1180801)

2010-12-02 Thread fredsa
Committed in r9349 http://gwt-code-reviews.appspot.com/1180801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove stray javadoc character. (issue1075801)

2010-12-01 Thread fredsa
Committed in r9186 http://gwt-code-reviews.appspot.com/1075801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Cleanup DOM after DoubleClickEventSinkTest tests complete (issue1150801)

2010-12-01 Thread fredsa
Committed in r9292 http://gwt-code-reviews.appspot.com/1150801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make the following method public in StackTraceDeobfuscator, for reuse by user server side code: (issue1040801)

2010-12-01 Thread fredsa
Committed in r9131 http://gwt-code-reviews.appspot.com/1040801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test whether the new 'compiler.st... (issue1174801)

2010-12-01 Thread fredsa
Reviewers: jat, Description: Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test whether the new 'compiler.stackMode' configuration property is set to 'emulated', rather than testing the legacy boolean configuration property 'compiler.emulatedStack'. This will allow developers to

[gwt-contrib] StackTraceDeobfuscator now extracts source file and (method declaration) line number information... (issue1175801)

2010-12-01 Thread fredsa
Reviewers: unnurg, Description: StackTraceDeobfuscator now extracts source file and (method declaration) line number information from the provided symbol map file, when this information is not provided by optionally enabled stack trace emulation. Fixes issues: 5682 Please review this at

[gwt-contrib] Re: Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test whether the new 'compiler.st... (issue1174801)

2010-12-01 Thread fredsa
http://gwt-code-reviews.appspot.com/1174801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

  1   2   >