Reviewers: rjrjr, jat,
Description:
This is critical for us; could you please include it in 2.1.1?
I'm not sure about the test (re. i18n involved through NumberFormat) but
I'm sure about the fix!
Please review this at http://gwt-code-reviews.appspot.com/1170801/show
Affected files:
user/src/
Reviewers: kathrin,
Description:
Reduces size of the compile report (soyc) for large projects with many
split points by:
- Using a common intern dictionary for methodDependency
reports from the same report.
- Sorting the interned dictionary by number of
references (so the most referenced strings
To justify the complexity of this change, here is the dramatic
difference in the leftoverStatus and splitStatus reports:
before:
-rwxrwxrwx 1 zundel nonconf 149M Nov 24 14:37 leftoverStatus-0.html
-rwxrwxrwx 1 zundel nonconf 33M Nov 24 14:37 splitStatus-0.html
after:
-rw-r- 1 zundel eng 1
Hi,
I'm sorry, I don't know if there is and this is the right place to
place an enhancement wish. So, thank you for reading... ;-)
If a parsed date contains only a 2-digit year, then the century will
be guessed based on the current century +/- 20 years (in short). If
you format a date, no guessin
http://gwt-code-reviews.appspot.com/1144801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I renamed the RPC specific method to SerializationUtils.getRpcTypeName()
After some more digging the term 'binary name' has a meaning in the JLS,
and it matches the implementation of JType.getQualifiedBinaryName(), so
I documented it as such.
http://gwt-code-reviews.appspot.com/1144801/show
-
Great docs!
My only complaint is the CssColor/FillStyle/StrokeStyle methods. I think
it's odd how we wrap CssColor in an array, so I'd like to save people
the trouble and point it out.
http://gwt-code-reviews.appspot.com/1165801/diff/1/7
File user/src/com/google/gwt/canvas/dom/client/Context2d.
http://gwt-code-reviews.appspot.com/1165801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Perfect!
http://gwt-code-reviews.appspot.com/1144801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Dec 1, 2010 at 8:46 AM, HerrB92 wrote:
> I'm sorry, I don't know if there is and this is the right place to
> place an enhancement wish. So, thank you for reading... ;-)
>
> If a parsed date contains only a 2-digit year, then the century will
> be guessed based on the current century +/-
LGTM
http://gwt-code-reviews.appspot.com/1167801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/1167801/diff/1/2#newcode1077
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1077: +
" for class " + classN
Reviewers: scottb,
Description:
Guard against invalid dispIds in JavaDispatchImpl
Also, rather than write an invalid dispId and wait for things to blow
up, throw
a HostedModeException if we hit a JSNI ref that shouldn't be there
Please review this at http://gwt-code-reviews.appspot.com/1172801
Revision: 9324
Author: gwt.mirror...@gmail.com
Date: Wed Dec 1 08:25:41 2010
Log: Cherry pick of r9323 to releases/2.1, javadoc tweak on @UiChild
http://code.google.com/p/google-web-toolkit/source/detail?r=9324
Modified:
/releases/2.1/user/src/com/google/gwt/uibinder/client/UiChild.java
=
http://gwt-code-reviews.appspot.com/1167801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/1167801/diff/1/2#newcode1077
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1077: +
" for class " + className);
LGTM
http://gwt-code-reviews.appspot.com/1172801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java
(right):
http://gwt-code-reviews.appspot.com/1172801/diff/1/2#newcode65
dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java:65: throw
new RuntimeException("Field do
Revision: 9325
Author: gwt.mirror...@gmail.com
Date: Wed Dec 1 08:29:33 2010
Log: Cherry pick r9320 to releases/2.1, Fix some timeout typos, and
increase delay on RequestFactoryTest
http://code.google.com/p/google-web-toolkit/source/detail?r=9325
Modified:
/releases/2.1/user/test/com/goog
Revision: 9326
Author: b...@google.com
Date: Wed Dec 1 04:33:03 2010
Log: Merge to GWT 2.1 branch.
Make DynaTableRf sample not reference dev.Util.
http://code.google.com/p/google-web-toolkit/source/detail?r=9326
Modified:
/releases/2.1/samples/dynatablerf/src/com/google/gwt/sample/dynatabler
LGTM
http://gwt-code-reviews.appspot.com/1129801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9327
Author: gwt.mirror...@gmail.com
Date: Wed Dec 1 08:36:36 2010
Log: Remove dependency on dev.Util class in DynaTableRf sample code.
Issue 5681.
Patch by: bobv
Review by: rchandia, rjrjr
Review at http://gwt-code-reviews.appspot.com/1164802
http://code.google.com/p/google-web-toolk
Reviewers: pdr,
Description:
Fix double escaping of HTML characters in Javadoc
Please review this at http://gwt-code-reviews.appspot.com/1173801/show
Affected files:
M user/src/com/google/gwt/safehtml/client/SafeHtmlTemplates.java
M user/src/com/google/gwt/safehtml/shared/SafeHtml.java
M
http://gwt-code-reviews.appspot.com/1172801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java
(right):
http://gwt-code-reviews.appspot.com/1172801/diff/1/2#newcode65
dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java:65: throw
new RuntimeException("Field does not
LGTM with nits.
I assume you will checking the prebuilt binaries separately?
http://gwt-code-reviews.appspot.com/1116801/diff/9001/10004
File plugins/ie/installer/README.txt (right):
http://gwt-code-reviews.appspot.com/1116801/diff/9001/10004#newcode16
plugins/ie/installer/README.txt:16: 4) Te
Err, yes ... I don't ever want a 2-digit year, also.
I have people, that enter "10" and expect to get "2010". Currently,
you will get "0010" (with a "" pattern).
But I think, I get the point: If there is textfield and a user enters
1.1.10 and default date parsing is used (pattern "dd.MM."
I'll get it in today, thanks very much for the patch.
I suspect this is the cause of
http://code.google.com/p/google-web-toolkit/issues/detail?id=5460
On Wed, Dec 1, 2010 at 3:01 AM, wrote:
> Reviewers: rjrjr, jat,
>
> Description:
> This is critical for us; could you please include it in 2.1.1
On Wed, Dec 1, 2010 at 11:50 AM, HerrB92 wrote:
> Err, yes ... I don't ever want a 2-digit year, also.
>
> I have people, that enter "10" and expect to get "2010". Currently,
> you will get "0010" (with a "" pattern).
>
> But I think, I get the point: If there is textfield and a user enters
>
On Wed, Dec 1, 2010 at 11:52 AM, Ray Ryan wrote:
> I'll get it in today, thanks very much for the patch.
>
> I suspect this is the cause of
> http://code.google.com/p/google-web-toolkit/issues/detail?id=5460
>
Note if you are going to take care of the patch, you need to make sure the
double comp
Sorry for the delay in responding.
I think that while this pattern may be useful for some users, it's probably
not something we would want to encourage everyone to use by making it part
of GWT proper. There are nontrivial runtime costs, you lose static analysis,
and this seems ripe for XSRF if not
Committed in r9186
http://gwt-code-reviews.appspot.com/1075801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Committed in r9292
http://gwt-code-reviews.appspot.com/1150801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9329
Author: mrruss...@google.com
Date: Wed Dec 1 09:25:03 2010
Log: release 1.2.1-rc1
http://code.google.com/p/google-web-toolkit/source/detail?r=9329
Added:
/tags/2.1.1-rc
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Committed in r9131
http://gwt-code-reviews.appspot.com/1040801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1165801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9330
Author: rchan...@google.com
Date: Wed Dec 1 07:08:02 2010
Log: Removed empty Validation sample
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9330
Deleted:
/releases/2.1/eclipse/samples/Validation
/releases/2.1/samples/validation
--
htt
committed as r9328
http://gwt-code-reviews.appspot.com/1129801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat,
Description:
Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test
whether the new 'compiler.stackMode'
configuration property is set to 'emulated', rather than testing the
legacy boolean configuration property
'compiler.emulatedStack'. This will allow developers to
LGTM, but please not my comments...
SOYC is becoming smart!! One thing I'm wondering is whether we have a
good way of making sure we still get the right information everywhere
(the smarter it gets, the harder it gets to follow in some sense, e.g.,
one-character function names, etc.). There's Soy
LGTM
http://gwt-code-reviews.appspot.com/1168801/diff/1/2
File
dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteSingleJsoImplDispatches.java
(right):
http://gwt-code-reviews.appspot.com/1168801/diff/1/2#newcode227
dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteSingleJsoImplDispatches.
LGTM, but wouldn't this require updating JsniCheckerTest?
http://gwt-code-reviews.appspot.com/1142802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM, though you should probably get Bob to look at it since he wrote
this originally.
http://gwt-code-reviews.appspot.com/1174801/diff/1/2
File user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1174801/diff/1/2#newcode22
user/src/com/google/gwt
Reviewers: unnurg,
Description:
StackTraceDeobfuscator now extracts source file and (method declaration)
line number information from
the provided symbol map file, when this information is not provided by
optionally enabled stack trace emulation.
Fixes issues: 5682
Please review this at http:/
Summary of face to face feedback
http://gwt-code-reviews.appspot.com/1167801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/1167801/diff/1/2#newcode1079
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:10
On 2010/12/01 16:41:18, rice wrote:
LGTM
http://gwt-code-reviews.appspot.com/1173801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1172801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java
(right):
http://gwt-code-reviews.appspot.com/1172801/diff/1/2#newcode65
dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java:65: throw
new RuntimeException("Field do
http://gwt-code-reviews.appspot.com/1142802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rice,
Description:
Disable tests using toDataURL() or getImageData() on Safari 3.
Please review this at http://gwt-code-reviews.appspot.com/1176801/show
Affected files:
M user/src/com/google/gwt/dom/client/DOMImplSafari.java
M user/test/com/google/gwt/canvas/client/CanvasTest.ja
The binaries are part of the CL. it seems that rietveld does not show
them, but you can see them in the internal tool.
Also, legal cleared the inclusion of wix binaries under third_party. I
added a README.txt under wix folder as suggested by legal (please
eyeball it to make sure I did not write a
http://gwt-code-reviews.appspot.com/1171801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1142802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1174801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1174801/diff/1/2
File user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1174801/diff/1/2#newcode22
user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml:22:
I'll go ahead and remove them for clarity
http://g
On 2010/12/01 17:28:19, rice wrote:
LGTM
http://gwt-code-reviews.appspot.com/1165801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9332
Author: zun...@google.com
Date: Wed Dec 1 09:41:55 2010
Log: Reduces size of the compile report (soyc) for large projects with many
split points by:
- Using a common intern dictionary for methodDependency
reports from the same report.
- Sorting the interned dictionary by number of
Revision: 9333
Author: p...@google.com
Date: Wed Dec 1 10:08:22 2010
Log: Disable tests using toDataURL() or getImageData() on Safari 3.
Review at http://gwt-code-reviews.appspot.com/1176801
Review by: r...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9333
Modified:
Reviewers: rjrjr, rchandia,
Description:
Support up-casting subclasses of java.util.Date (e.g. java.sql.Date).
Issue 5675.
Patch by: bobv
Review by: rjrjr, rchandia
Please review this at http://gwt-code-reviews.appspot.com/1177801/show
Affected files:
M tools/api-checker/config/gwt21_22userA
LGTM
http://gwt-code-reviews.appspot.com/1177801/diff/1/3
File user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java (right):
http://gwt-code-reviews.appspot.com/1177801/diff/1/3#newcode299
user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java:299:
encodeValue(ctx.getElementType(), el
Revision: 9334
Author: con...@google.com
Date: Wed Dec 1 12:10:45 2010
Log: make computeAllInterfaces resilient to errors in dependendant
compilation units
Review at http://gwt-code-reviews.appspot.com/1168801
Review by: sco...@google.com
http://code.google.com/p/google-web-toolkit/source/de
http://gwt-code-reviews.appspot.com/1172801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java
(right):
http://gwt-code-reviews.appspot.com/1172801/diff/1/2#newcode65
dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java:65: throw
new RuntimeException("Field does not
(patch submitted)
http://gwt-code-reviews.appspot.com/1171801/diff/1/3
File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):
http://gwt-code-reviews.appspot.com/1171801/diff/1/3#newcode115
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:115:
public void freez
On 2010/12/01 16:03:22, scottb wrote:
Perfect!
Is that perfect as in, "Sounds great I'll look at it later!" or "LGTM"?
http://gwt-code-reviews.appspot.com/1144801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Dec 1, 2010 at 1:49 PM, wrote:
> LGTM, but please note my comments...
>
> SOYC is becoming smart!! One thing I'm wondering is whether we have a
> good way of making sure we still get the right information everywhere
> (the smarter it gets, the harder it gets to follow in some sense, e.g.,
Revision: 9335
Author: con...@google.com
Date: Wed Dec 1 13:52:36 2010
Log: Make bad JSNI refs errors
Review at http://gwt-code-reviews.appspot.com/1142802
http://code.google.com/p/google-web-toolkit/source/detail?r=9335
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/JsniChecker.java
http://gwt-code-reviews.appspot.com/1167801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/1167801/diff/1/2#newcode1079
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1079: }
On 2010/12/01 19:39:30, scot
Like, LGTM++
On Wed, Dec 1, 2010 at 7:12 PM, wrote:
> On 2010/12/01 16:03:22, scottb wrote:
>
>> Perfect!
>>
>
> Is that perfect as in, "Sounds great I'll look at it later!" or "LGTM"?
>
>
> http://gwt-code-reviews.appspot.com/1144801/show
>
--
http://groups.google.com/group/Google-Web-Toolkit
http://gwt-code-reviews.appspot.com/1169801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[JSR 303 TCK Result] 4 Pass 6 Fail 32 Error from a total of 259 tests
for a success rate of 1.54%.
http://gwt-code-reviews.appspot.com/1169801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2010/12/01 19:23:57, fredsa wrote:
http://gwt-code-reviews.appspot.com/1175801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
66 matches
Mail list logo
