Hi Bob,
thanks for your answer. With the patch on the current GWT 2 trunk I
get an out of memory error with my example. I tested with 256M and
512M. Any ideas?
Regards,
Mark
java.lang.OutOfMemoryError: Java heap space
at java.util.Arrays.copyOf(Arrays.java:2882)
at
Hi Bob,
sorry for my last post, I made a mistake in my project.
With this patch, the RPC call works properly!
Thanks for your help,
Mark
On 3 Nov., 11:25, Mark Goerdes mgoer...@googlemail.com wrote:
Hi Bob,
thanks for your answer. With the patch on the current GWT 2 trunk I
get an out of
Hi all,
before reporting a bug I would like to know whether this happens
intentionally, and if so, what is the use case?
Common use case: one needs to async. upload a file through hidden
iframe, and she also wants to check what's the result of that
submission. The only way is to check the
On 2009/11/03 01:37:14, bobv wrote:
Review requested.
LGTM.
http://gwt-code-reviews.appspot.com/89815
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
As I was developing this morning, I came across a trade-off that I
wasn't happy with. Namely, as I create handlers and other interface
implementations in a given class, the implementations create new
classes, which adds additional, unnecessary code into the compiled
output.
One way around this
Revision: 6604
Author: b...@google.com
Date: Tue Nov 3 08:52:16 2009
Log: Add a test for circular references via a CustomFieldSerializer.
Update deRPC code to pass this test.
Patch by: bobv
Review by: jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6604
Modified:
This topic usually centers on all the little types needed for various event
handlers. Happily, @UiHandler in UiBinder removes the whole issue. The
UiBinder code generator can do whatever nastiness it needs to in order to
create the most efficient event handler/dispatch code. IOW, it's not only
On 2009/11/03 01:50:35, jlabanca wrote:
As I mentioned before, I'm not all tat familiar with generators,
especially
complex ones like this. Scott can probably give you better feedback
than I.
http://gwt-code-reviews.appspot.com/89814/diff/1/2
File
Reviewers: amitmanjhi,
Description:
This is to support new development where CCs don't retain their
TypeOracle references.
Please review this at http://gwt-code-reviews.appspot.com/89817
Affected files:
dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java
Guess you caught me ignoring those.
Please remember to merge this into releases/2.0 as well, so that
downstream merges don't get complicated.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Tue, Nov 3, 2009 at 8:05 PM, Ray Ryan rj...@google.com wrote:
So circular is okay?
It's fine. ModuleDef deals with this by ignoring repeated imports.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
LGTM, some comments.
http://gwt-code-reviews.appspot.com/91809/diff/1/2
File user/super/com/google/gwt/emul/java/util/ArrayList.java (right):
http://gwt-code-reviews.appspot.com/91809/diff/1/2#newcode79
Line 79: clearImpl();
While you're there, it seems like we should delete this block and
Revision: 6608
Author: br...@google.com
Date: Tue Nov 3 10:32:28 2009
Log: Adds uibinder to javadoc.
Patch by: bruce
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6608
Modified:
/trunk/doc/build.xml
===
---
I think the impact of anonymous classes will be significantly less
once union types are implemented. As it stands right now, every
anonymous class gets typeinfo and getClass because some code elsewhere
is calling it on an variable that can't be tightened more than Object.
On 2009-11-03, at
They show up as severity=info which doesn't break the build. But at
least the @param names seem worth fixing...
Dan
On Tue, Nov 3, 2009 at 3:21 PM, rj...@google.com wrote:
Thanks.
Why is ant checkstyle passing for me?
http://gwt-code-reviews.appspot.com/89816
Revision: 6609
Author: r...@google.com
Date: Tue Nov 3 10:42:54 2009
Log: Avoid calling overridable methods from constructors to avoid
subclassing glitches
(see external issue 4177).
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=6609
Modified:
Revision: 6610
Author: br...@google.com
Date: Tue Nov 3 10:55:22 2009
Log: Adds uibinder to javadoc, replicating the same change in trunk in
r6608.
Patch by: bruce
Reveiw by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6610
Modified:
/releases/2.0/doc/build.xml
Okay, how's this?
(gwt-code-reviews.appspot.com is suddenly puking when I try to upload
patches to it, so here's one the old fashioned way. )
On Tue, Nov 3, 2009 at 4:06 PM, Amit Manjhi amitman...@google.com wrote:
I agree with John. A system property is a global VM-wide option that seems
like
In fact, this is the third one.
On Tue, Nov 3, 2009 at 6:15 PM, j...@google.com wrote:
On 2009/11/03 22:48:40, Ray Ryan wrote:
Joel, here's a quick one.
LGTM (I think it may have already sent this, but Rietveld was 500'ing
before).
http://gwt-code-reviews.appspot.com/91811
Uploading another patch. Did not know how to do it with this message.
http://gwt-code-reviews.appspot.com/91806/diff/1/2
File user/src/com/google/gwt/junit/JUnitMessageQueue.java (right):
http://gwt-code-reviews.appspot.com/91806/diff/1/2#newcode413
Line 413: assert (result != null);
Good
LGTM, but with a few small changes requested. No need for rereview.
http://gwt-code-reviews.appspot.com/89810/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
(right):
http://gwt-code-reviews.appspot.com/89810/diff/1/2#newcode175
Line 175: * the call to
tr...@6596, releases/2...@6599
http://gwt-code-reviews.appspot.com/91807
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On Tue, Nov 3, 2009 at 1:21 PM, Nathan Wells nwwe...@gmail.com wrote:
@Scott
Thanks for the insight into the discussions. Maybe this will be
something possible to add in the future, in some form.
@Bruce
I like what I see with the UIBinder methodology... However, there is
some amount of
Revision: 6623
Author: sco...@google.com
Date: Tue Nov 3 14:04:04 2009
Log: Strangely, this works better across platforms.
http://code.google.com/p/google-web-toolkit/source/detail?r=6623
Modified:
/trunk/user/build.xml
===
--- /trunk/user/build.xml
As mentioned in the detailed comments, because more classes will pass
the isAnonymous() filter, the matching algorithm will break.
Perhaps isAnonymous() can be renamed to isLocal() (since that is exactly
what is being computed).
isAnonymous() can then be isLocal()
Reviewers: bobv,
Message:
Clue and review requested.
Description:
Makes User inherit UiBinder, to keep people from having to think about
turning it on.
But before I submit this, an important question: why did (and does) the
test app work if it inherits UiBinder directly, without inheriting
Revision: 6612
Author: rj...@google.com
Date: Tue Nov 3 12:16:32 2009
Log: Checkstyle fixes for UiBinder tests
Patch by jat
review by rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6612
Modified:
/trunk/user/test/com/google/gwt/uibinder/All.java
Revision: 6628
Author: j...@google.com
Date: Tue Nov 3 14:59:17 2009
Log: Remove FF2 prebuilt directories (for now, may add back later), tweak
install.rdf template.
http://code.google.com/p/google-web-toolkit/source/detail?r=6628
Deleted:
Reviewers: jgw,
Description:
Forgetting a namespace prefix on a child elem of DockLayoutPanel causes
an NPE, for example:
g:DockLayoutPanel unit=PCT
westg:HTMLPanelfoo/g:HTMLPanel/west
east/east
/g:DockLayoutPanel
Unfortunately, even after the patch the error message is confusing. It
Thanks, John. ant checkstyle didn't complain so I didn't notice. I'll
commit the patch in a moment.
On Tue, Nov 3, 2009 at 8:53 AM, John Tamplin j...@google.com wrote:
Here is a patch which fixes it.
--
John A. Tamplin
Software Engineer (GWT), Google
Revision: 6606
Author: b...@google.com
Date: Tue Nov 3 10:06:29 2009
Log: Stabilize the output from ClientBundle and MhtmlResourceContext.
Patch by: bobv
Review by: jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6606
Modified:
Revision: 6627
Author: j...@google.com
Date: Tue Nov 3 14:54:41 2009
Log: Update XPCOM plugin names, prepare for production deployment.
http://code.google.com/p/google-web-toolkit/source/detail?r=6627
Added:
Revision: 6611
Author: rj...@google.com
Date: Tue Nov 3 11:48:42 2009
Log: Fix accidentally extended timeout in JUnitShell
http://code.google.com/p/google-web-toolkit/source/detail?r=6611
Modified:
/trunk/user/src/com/google/gwt/junit/JUnitShell.java
===
LGTM, of course.
http://gwt-code-reviews.appspot.com/89816
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6620
Author: j...@google.com
Date: Tue Nov 3 13:06:00 2009
Log: Merge trunk at r6618 into this branch.
Support more structured GWT versions.
svn merge --ignore-ancestry -c6618 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Reviewers: Ray Ryan,
Please review this at http://gwt-code-reviews.appspot.com/89816
Affected files:
user/src/com/google/gwt/uibinder/client/UiBinderUtil.java
user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
user/src/com/google/gwt/uibinder/rebind/XMLElement.java
Index:
On 2009/11/03 20:55:16, Ray Ryan wrote:
LGTM
This is great, thanks for all the iterations.
http://gwt-code-reviews.appspot.com/72802/diff/5001/4008
File dev/core/src/com/google/gwt/dev/GwtVersion.java (right):
http://gwt-code-reviews.appspot.com/72802/diff/5001/4008#newcode23
Line 23:
Revision: 6630
Author: rj...@google.com
Date: Tue Nov 3 18:02:50 2009
Log: Merges tr...@6612 into releases/2.0
Checkstyle fixes in UiBinder tests
svn merge --ignore-ancestry -c r6612
https://google-web-toolkit.googlecode.com/svn/trunk .
Revision: 6624
Author: j...@google.com
Date: Tue Nov 3 14:14:13 2009
Log: Eliminates the need to call layout() explicitly on *LayoutPanel, which
should greatly simplify their use. RequiresLayout becomes
AnimatedLayout, which is now just a convenient moniker for the ability
of a panel to layout
LGTM
This is great, thanks for all the iterations.
http://gwt-code-reviews.appspot.com/72802/diff/5001/4008
File dev/core/src/com/google/gwt/dev/GwtVersion.java (right):
http://gwt-code-reviews.appspot.com/72802/diff/5001/4008#newcode23
Line 23: public final class GwtVersion implements
Reviewers: amitmanjhi,
Message:
I imagine I'm not the only one who tweaks
JUnitShell.TEST_METHOD_TIMEOUT_MILLIS when in the middle of long debug
sessions. Wouldn't it be nice to be able to do so without touching the
code?
General questions: is a system property the right way to do this; is the
Reviewers: freeland_google.com,
Description:
Description:
Since we run tests in parallel, its really difficult to tell which test
target failed when the tests fail.
Fix:
This patch adds a test.name to all gwt.junit calls. The name is printed
at the bottom of the console
Revision: 6607
Author: b...@google.com
Date: Tue Nov 3 10:24:07 2009
Log: Merge tr...@6606 to stabilize ClientBundle and MhtmlResourceContext
generator output.
$ svn merge --ignore-ancestry -c 6606
http://google-web-toolkit.googlecode.com/svn/trunk/ .
I agree with John. A system property is a global VM-wide option that seems
like an overkill for this purpose. A command line option with sane defaults
is probably the way to go.
On Tue, Nov 3, 2009 at 3:50 PM, j...@google.com wrote:
On 2009/11/03 23:49:14, Ray Ryan wrote:
I imagine I'm not
Revision: 6626
Author: j...@google.com
Date: Tue Nov 3 14:18:11 2009
Log: Merge trunk r6625 was into this branch
Avoid Arrays.copyOf since that was added in JDK1.6.
svn merge --ignore-ancestry -c6625 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
BTW: the main thing I wanted to ask was if this will impact your CCL
code in any way. John T was nervous about me removing the call to
isClassnameGenerated() when making the anonymous class determination.
http://gwt-code-reviews.appspot.com/89817/diff/1/3
File
Fantastic. Just a couple of doc issues.
http://gwt-code-reviews.appspot.com/89818/diff/1/3
File samples/mail/src/com/google/gwt/sample/mail/client/MailList.java
(right):
http://gwt-code-reviews.appspot.com/89818/diff/1/3#newcode81
Line 81: dock.forceLayout();
Should add comment explaining why
[New subject line for the new subject. ]
Sorry, no samples to point you at right now. And no, @UiHandler will
only work in the class that owns the binder, the view.
I've seen different teams approach communication between view and
presenter in different ways. Some will give the view interface
Many thanks. Committed with review tweaks @r6624.
http://gwt-code-reviews.appspot.com/89818/diff/1/3
File samples/mail/src/com/google/gwt/sample/mail/client/MailList.java
(right):
http://gwt-code-reviews.appspot.com/89818/diff/1/3#newcode81
Line 81: dock.forceLayout();
On 2009/11/03 21:57:19,
So circular is okay?
User - UiBinder - Resources - HTTP - User
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM.
UiBinder - Resources - HTTP - User (for access to timers, which
could be replaced with the new Scheduler API)
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Let me be clear: I'm not currently using the UIBinder for my development.
Let me know if this is a catastrophic mistake, but we started this project
before UIBinder was available, so we went with MVP. It could be (and
hopefully is) the case that my concerns with disappear when I start using
On 2009/11/03 22:48:40, Ray Ryan wrote:
Joel, here's a quick one.
LGTM.
http://gwt-code-reviews.appspot.com/91811
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jgw,
Message:
Joel, here's a quick one.
Please review this at http://gwt-code-reviews.appspot.com/91811
Affected files:
M
user/src/com/google/gwt/uibinder/parsers/HorizontalAlignmentConstantParser.java
M user/src/com/google/gwt/uibinder/parsers/StrictAttributeParser.java
http://gwt-code-reviews.appspot.com/89817/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right):
http://gwt-code-reviews.appspot.com/89817/diff/1/3#newcode80
Line 80: boolean anonymous = false;
a small nit: perhaps move this to a separate method? as in
this.anonymous =
Revision: 6629
Author: j...@google.com
Date: Tue Nov 3 16:25:38 2009
Log: Checkin prebuilt Mac libraries.
http://code.google.com/p/google-web-toolkit/source/detail?r=6629
Added:
/changes/jat/single-xpi/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff3/libgwt_devmode_ff3.dylib
On 2009/11/03 22:48:40, Ray Ryan wrote:
Joel, here's a quick one.
LGTM.
http://gwt-code-reviews.appspot.com/91811
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
I can review it. -Lex
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6616
Author: sco...@google.com
Date: Tue Nov 3 12:52:13 2009
Log: Clarify JsniCollector.SourceCache comment.
Review by: jat (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6616
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/JsniCollector.java
Revision: 6625
Author: j...@google.com
Date: Tue Nov 3 14:15:06 2009
Log: Avoid use of Arrays.copyOf since that was added in JDK1.6.
Patch by: jat
Review by: rice (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6625
Modified:
Revision: 6613
Author: r...@google.com
Date: Tue Nov 3 12:32:10 2009
Log: Fix checkstyle warnings.
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6613
Modified:
/trunk/user/src/com/google/gwt/uibinder/client/UiBinderUtil.java
Reviewers: jgw,
Message:
Review, please.
Description:
HasHTML extends HasText, so there is no need for these widgets to
declare both interfaces. And the fact that they do makes UiBinder treat
their content as text rather than HTML. The UiBinder fix would be hard,
maybe even completely
Revision: 6617
Author: sco...@google.com
Date: Tue Nov 3 12:52:20 2009
Log: Fix Showcase classpath.
Review by: fabbott (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6617
Modified:
/trunk/eclipse/samples/Showcase/.classpath
===
---
http://code.google.com/p/google-web-toolkit/source/detail?r=6631
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6631
Author: rj...@google.com
Date: Tue Nov 3 20:12:52 2009
Log: Checkstyle fix in LayoutCommand
tbr jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6631
Modified:
/trunk/user/src/com/google/gwt/user/client/ui/LayoutCommand.java
@Scott
Thanks for the insight into the discussions. Maybe this will be
something possible to add in the future, in some form.
@Bruce
I like what I see with the UIBinder methodology... However, there is
some amount of incompatibility with the MVP approach, unless I'm
mistaken. This is because all
Revision: 6615
Author: r...@google.com
Date: Tue Nov 3 12:45:24 2009
Log: Merged tr...@6613 into this branch
Fix checkstyle warnings
svn merge --ignore-ancestry -c 6613
http://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=6615
+fabbott
Used the wrong screen name.
Thanks,
John LaBanca
jlaba...@google.com
On Tue, Nov 3, 2009 at 4:21 PM, jlaba...@google.com wrote:
Reviewers: freeland_google.com,
Description:
Description:
Since we run tests in parallel, its really difficult to tell which test
target
I just submitted a change to checkstyle our user tests, so in the future the
build can nicely break. :)
I was going to enable this for dev also, but there's too many breaks in
there for me to go fix them right now.
On Tue, Nov 3, 2009 at 3:14 PM, Ray Ryan rj...@google.com wrote:
Thanks, John.
Reviewers: Ray Ryan,
Please review this at http://gwt-code-reviews.appspot.com/89818
Affected files:
M samples/mail/src/com/google/gwt/sample/mail/client/Mail.java
M samples/mail/src/com/google/gwt/sample/mail/client/MailList.java
M
Revision: 6632
Author: rj...@google.com
Date: Tue Nov 3 20:41:24 2009
Log: Make the alignment parsers field ref friendly
Review by jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6632
Modified:
Revision: 6621
Author: r...@google.com
Date: Tue Nov 3 13:18:00 2009
Log: Merge tr...@6441 into this branch
Add a 'sessionId' field to GWT lightweight metrics events
svn merge --ignore-ancestry -c 6441
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 6618
Author: j...@google.com
Date: Tue Nov 3 13:02:30 2009
Log: Add support for more structured GWT versions.
Patch by: jat
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6618
Added:
/trunk/dev/core/src/com/google/gwt/dev/GwtVersion.java
Revision: 6619
Author: sco...@google.com
Date: Tue Nov 3 13:04:24 2009
Log: Add support for checkstyle of tests; checkstyle user/tests; fix
existing errors.
Review by: rice (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6619
Modified:
/trunk/common.ant.xml
Revision: 6633
Author: rj...@google.com
Date: Tue Nov 3 20:54:59 2009
Log: Makes User depend upon UiBinder, to keep people from having to
think about turning it on.
Review by: bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=6633
Modified:
Revision: 6622
Author: r...@google.com
Date: Tue Nov 3 13:26:55 2009
Log: Merged tr...@6580 into this branch
Implement a -standardsMode flag for junit tests
svn merge --ignore-ancestry -c 6580
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 6634
Author: rj...@google.com
Date: Tue Nov 3 21:19:08 2009
Log: Merges tr...@6632, 6633 into this branch
Make the alignment parsers field ref friendly, Makes User depend upon
UiBinder
svn merge --ignore-ancestry -r 6631:6633
Bob LGTM'd offline.
committed tr...@6633, releases/2...@6634
http://gwt-code-reviews.appspot.com/89820
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Committed tr...@6632, releases/2...@6634
http://gwt-code-reviews.appspot.com/91811
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: Ray Ryan, bruce,
Description:
This patch adds support for launching the user's default browser using
several methods. This facility is then used for HelpInfo links in the
logger detail messages (falling back to the old method of using the
Swing HTML panel if none work), including the
Reviewers: Lex,
Message:
Review requsted
Description:
Adds support for overloaded method names to SingleJsoImpl
Please review this at http://gwt-code-reviews.appspot.com/92801
Affected files:
M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
M
Reviewers: jat,
Message:
Review requested.
@John, you have better state than I do on what flags can be usefully
used with DevMode today.
Description:
DevMode has a bunch of irrelevant and confusing options since it doesn't
support compiling the app into JS. This patch shuffles the ArgHandlers
82 matches
Mail list logo
