Bob noted a missing check for Set, which led me to realize that we had
no Set equivalent of RecordListRequest/ProxyListRequest. The lastest
patch adds it and fixes the nits.
http://gwt-code-reviews.appspot.com/893801/diff/23001/24007
File
If the MultiSelectionModel is used as a selection model for a CellList
items can only be selected but they can not be deselected. I found
this in svn 8815. The way to reproduce the bug is to replace the
following code in CwCellList from the showcase example:
// Add a selection model so we can
On Sep 21, 11:44 am, stuckagain david.no...@gmail.com wrote:
GWT contributors,
Will there be a production quality RPC mechanism available in GWT 2.1
as part of the RequestFactory stuff ? Or do we still have to suffer
the stackoverflow inducing RPC implementation ?
I'm currently fighting
stuckagain wrote:
GWT contributors,
Will there be a production quality RPC mechanism available in GWT 2.1
as part of the RequestFactory stuff ? Or do we still have to suffer
the stackoverflow inducing RPC implementation ?
I'm currently fighting to get RPC to work with a tree structure that
We have a TODO in the code to fix this. When we add ctrl/shift+click
support, we can fix the issue.
Thanks,
John LaBanca
jlaba...@google.com
On Tue, Sep 21, 2010 at 3:56 AM, monkeyboy dilbert.elbo...@gmail.comwrote:
If the MultiSelectionModel is used as a selection model for a CellList
Reviewers: rice,
Description:
Adds additional keyboard support in Cell Widgets. CellList and CellTable
now support page down/up, home, and end. CellBrowser and CellTree
support left/right to navigate into/out of child nodes. All widgets
support SPACE to select the current item in the
Thanks John for the quick response. How can I monitor this issue, I
mean how can I tell when it is solved cause I need this feature real
soon. I assume it will surely be solved before 2.1 final release.
On Sep 21, 3:39 pm, John LaBanca jlaba...@google.com wrote:
We have a TODO in the code to fix
For the untranslatable validators, it seems more straightforward to have
a super-source version of the annotation that's tagged as
@NotGwtCompatible.
Instead of having the sample app import the HibernateValidator package,
would it make sense to have the gwt.Validation package include the
On Tue, Sep 21, 2010 at 7:04 AM, b...@google.com wrote:
For the untranslatable validators, it seems more straightforward to have
a super-source version of the annotation that's tagged as
@NotGwtCompatible.
Hmm, that might work.
However it could be complicated because I am actually deciding
Let me know how that works as I am doing the same for ROO-1430
El 21 de septiembre de 2010 01:05, Amit Manjhi amitman...@google.comescribió:
LGTM, with a TODO (amitmanjhi) to change SimpleFoo id to String and
checking if everything works.
On Mon, Sep 20, 2010 at 9:15 PM, Amit Manjhi
http://gwt-code-reviews.appspot.com/893801/diff/30001/31001
File
user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonProxyCollectionRequest.java
(right):
http://gwt-code-reviews.appspot.com/893801/diff/30001/31001#newcode69
Reviewers: jat,
Description:
This is a first-pass at adding SafeHtml support to a subset of the
widgets. In cases where the class implements HasHTML, HasSafeHtml has
been implemented as well. In constructors that accept a string that can
be parsed as Html, a SafeHtml constructor has been added.
http://gwt-code-reviews.appspot.com/880802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/880802/diff/12001/13003
File
samples/logexample/src/com/google/gwt/sample/logexample/client/LogExample.java
(right):
http://gwt-code-reviews.appspot.com/880802/diff/12001/13003#newcode55
LGTM
http://gwt-code-reviews.appspot.com/880802/diff/22001/23010
File
user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java
(right):
http://gwt-code-reviews.appspot.com/880802/diff/22001/23010#newcode34
user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java:34:
*
LGTM with some nits
http://gwt-code-reviews.appspot.com/901801/diff/1/3
File user/src/com/google/gwt/user/client/ui/DirectionalTextHelper.java
(right):
http://gwt-code-reviews.appspot.com/901801/diff/1/3#newcode29
user/src/com/google/gwt/user/client/ui/DirectionalTextHelper.java:29:
public
Reviewers: rjrjr,
Description:
Add base64 encoding to JsonRequestProcessor and change the delimiter to
the '!' character.
Please review this at http://gwt-code-reviews.appspot.com/908801/show
Affected files:
M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java
M
http://gwt-code-reviews.appspot.com/880802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/908801/diff/1/5
File
user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java
(right):
http://gwt-code-reviews.appspot.com/908801/diff/1/5#newcode192
user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java:192:
String schemaAndId[] =
LGTM
http://gwt-code-reviews.appspot.com/880802/diff/19/4027
File
user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java
(right):
http://gwt-code-reviews.appspot.com/880802/diff/19/4027#newcode42
user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java:42:
* Returns
http://gwt-code-reviews.appspot.com/902801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/906801/diff/1/12
File
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellValidation.java
(right):
http://gwt-code-reviews.appspot.com/906801/diff/1/12#newcode104
LGTM
http://gwt-code-reviews.appspot.com/908801/diff/1/5
File
user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java
(right):
http://gwt-code-reviews.appspot.com/908801/diff/1/5#newcode192
user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java:192:
String
Hi,
I'm using CellTable to render a table with a total footer. However,
the footer is not redrawn when I change the rows in the table, so the
total always says $0.00. Looking at the code, it looks like
headersStale is only set true if I add/remove a column.
IIRC, previously there was a
Revision: 8827
Author: b...@google.com
Date: Tue Sep 21 03:59:38 2010
Log: Move RequestFactory.URL field into DefaultRequestTransport.
Patch by: bobv
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/903801
http://code.google.com/p/google-web-toolkit/source/detail?r=8827
Modified:
Revision: 8828
Author: con...@google.com
Date: Tue Sep 21 04:21:01 2010
Log: Fix GWTShell. Compare classpaths by content instead of reference in
ResourceOracleImpl.refresh(). Note that this is still much faster than the
old behavior of exploring each classpath individually.
Review at
Revision: 8829
Author: sp...@google.com
Date: Tue Sep 21 05:23:10 2010
Log: Gets the code splitter to be effective even in draft compile mode.
Review at http://gwt-code-reviews.appspot.com/875801
Review by: sco...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8829
http://gwt-code-reviews.appspot.com/863801/diff/3002/15002
File eclipse/samples/Validation/.classpath (right):
http://gwt-code-reviews.appspot.com/863801/diff/3002/15002#newcode5
eclipse/samples/Validation/.classpath:5: classpathentry kind=src
path=gwt-gen/
On 2010/09/21 14:04:18, bobv wrote:
http://gwt-code-reviews.appspot.com/863801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8834
Author: gwt.mirror...@gmail.com
Date: Tue Sep 21 13:12:02 2010
Log: Get strong permutation from headers rather than serialized log record
Review at http://gwt-code-reviews.appspot.com/880802
Review by: fre...@google.com
Revision: 8835
Author: rj...@google.com
Date: Tue Sep 21 13:40:35 2010
Log: assertEquals(1, list.size()) works a lot more often than you would
think
http://code.google.com/p/google-web-toolkit/source/detail?r=8835
Modified:
Reviewers: rjrjr, cromwellian,
Description:
Rename RequestObject-Request and pull the 'with' method into it
Please review this at http://gwt-code-reviews.appspot.com/909801/show
Affected files:
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java
http://gwt-code-reviews.appspot.com/906801/diff/1/12
File
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellValidation.java
(right):
http://gwt-code-reviews.appspot.com/906801/diff/1/12#newcode104
Revision: 8836
Author: amitman...@google.com
Date: Tue Sep 21 17:22:41 2010
Log: Repeats the existing tests with String id and confirm that the tests
pass.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
http://code.google.com/p/google-web-toolkit/source/detail?r=8836
Added:
34 matches
Mail list logo
