Actually, the Editor framework underwent a complete rewrite between 2.2 and
2.3. There are only few visible changes though: introduction of EditorDriver
base interface (with setConstraintViolations, so error reporting is now
available on SimpleBeanEditorDriver too), EditorVisitor and
http://gwt-code-reviews.appspot.com/1451801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wednesday, May 25, 2011 3:29:35 PM UTC+2, Jeff Larsen wrote:
Wow, this is awesome.
+1
I haven't started digging into the code yet, but I would like to point out
a minor nit. In Firefox giving the scrollbars opacity looks OK, but in
chrome, it doesn't look right (see attached
Revision: 10223
Author: jbrosenb...@google.com
Date: Wed May 25 04:59:33 2011
Log: Fix dangling clinit issue; check if clinit method calls have been
replaced or removed, during javascript generation phase.
Review at http://gwt-code-reviews.appspot.com/1448807
On Wednesday, May 25, 2011 10:21:18 AM UTC-5, Thomas Broyer wrote:
On Wednesday, May 25, 2011 3:29:35 PM UTC+2, Jeff Larsen wrote:
Wow, this is awesome.
+1
I haven't started digging into the code yet, but I would like to point out
a minor nit. In Firefox giving the scrollbars
On Wednesday, May 25, 2011 5:46:34 PM UTC+2, Jeff Larsen wrote:
On Wednesday, May 25, 2011 10:21:18 AM UTC-5, Thomas Broyer wrote:
On Wednesday, May 25, 2011 3:29:35 PM UTC+2, Jeff Larsen wrote:
Wow, this is awesome.
+1
I haven't started digging into the code yet, but I would
http://gwt-code-reviews.appspot.com/1451801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, May 25, 2011 at 9:13 AM, Thomas Broyer t.bro...@gmail.com wrote:
On Wednesday, May 25, 2011 5:46:34 PM UTC+2, Jeff Larsen wrote:
On Wednesday, May 25, 2011 10:21:18 AM UTC-5, Thomas Broyer wrote:
On Wednesday, May 25, 2011 3:29:35 PM UTC+2, Jeff Larsen wrote:
Wow, this is
LGTM
http://gwt-code-reviews.appspot.com/1451801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10224
Author: dconne...@google.com
Date: Wed May 25 07:29:58 2011
Log: Implemented expression range shifting for IE block size
transformation. Moved expression range shifting for both transformations
inside the transformation classes. Modified constructors/instance
Reviewers: rjrjr,
Description:
Fix escaping issue with SafeHtml in Safari3
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1443806/
Affected files:
M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
Index:
LGTM
On Wed, May 25, 2011 at 11:53 AM, sbruba...@google.com wrote:
Reviewers: rjrjr,
Description:
Fix escaping issue with SafeHtml in Safari3
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1443806/
Affected files:
M
Revision: 10225
Author: sbruba...@google.com
Date: Wed May 25 09:31:31 2011
Log: Fix escaping issue with SafeHtml in Safari3
Review at http://gwt-code-reviews.appspot.com/1443806
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10225
Modified:
On Wednesday, May 25, 2011 6:41:22 PM UTC+2, Ray Ryan wrote:
On Wed, May 25, 2011 at 9:13 AM, Thomas Broyer t.br...@gmail.com wrote:
On Wednesday, May 25, 2011 5:46:34 PM UTC+2, Jeff Larsen wrote:
Is there any bug tracker you don't know by heart? :)
I didn't actually know that bug
Revision: 10226
Author: j...@google.com
Date: Wed May 25 09:56:39 2011
Log: Fix several @Select issues, adding tests for them:
- @Select only worked if @PluralCount was also on the same message
- @Select for long generated a switch statement which doesn't support
long values
- @Select
(This is a copy from the General discussion group, as no one replied
to me there :'( )
Hi all,
I was wondering if there is anything on the timetable for GWT to
include some enhancements to the CSS support (I mean other than the
CSS3 stuff that were mentioned in the fireside chat @ Google I/O
Thanks. I like it. It makes clearer some of the relationships.
On Wed, May 25, 2011 at 11:43 AM, danieldietrich cafeb...@googlemail.comwrote:
Hi,
I've drawn an informal map about Activities Places
- perhaps it is helpful for someone...
Greetings from Kiel/Germany
- Daniel
(No warranty
Hi,
Poking around a bit more I found that gwtc seems to assume internally
that whenever type name contains '$' it's in binary form and if it
doesn't contain dollar sign then it can be considered to be in source
form. It's worth noting (and it's admitted in gwtc's internals) that
this condition
Reviewers: rjrjr, juliog,
Description:
Change the wrapElement API to receive the id and a parent element. I
also ported some of the bookeeping we were doing in our internal Panel
to RenderablePanel, please let me know what you think.
Please review this at
Wanted to ask you guys for specific feedback on the fact that I am
changing the phase right before calling the wrapCallback. As I stated
on the comment, I'm doing that because the UiBinder-generated code
calls getElement(), and it must know it doesn't need to trigger the
slow process. I see 2
Reviewers: fabbott,
Description:
Resubmitting r9970 again (again) - updating Animation to use the native
requestAnimationFrame, which generally results in optimal performance
versus using timer based animations. I did away with the soft
permutation in this version. Basing the impl on user agent
I'm sending this issue for review. tbroyer's original issue is:
http://gwt-code-reviews.appspot.com/1355805/
@fabbott -
You can hold off on the review until we get feedback, at least from
tbroyer.
http://gwt-code-reviews.appspot.com/1446812/
--
Reviewers: zundel, jbrosenberg,
Message:
Tiny code review.
Description:
Bugfixes in ControlFlowAnalyzer
- Instantiating Interface[] failed to rescue Object[]
- Field initializers being visited twice
Please review this at http://gwt-code-reviews.appspot.com/1443807/
Affected files:
M
Reviewers: jbrosenberg, zundel,
http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java
File dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java (right):
LGTM (with nits).
Also, the amount of code spent in seemingly trivial adapters for
resources and styles is something I could not fail to notice. Although
this probably not the place to fix it.
http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(left):
Hi again,
Can you point out any of places where you saw this assumption? The
last time I was mucking around with binary type names I was told not
to assume that $ could not appear in source names, so it might be
unintentional.
-Eric.
On Wed, May 25, 2011 at 5:51 PM, Grzegorz Kossakowski
http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(right):
On Wed, May 25, 2011 at 5:51 PM, Grzegorz Kossakowski
grzegorz.kossakow...@gmail.com wrote:
Hi,
Poking around a bit more I found that gwtc seems to assume internally
that whenever type name contains '$' it's in binary form and if it
doesn't contain dollar sign then it can be considered to
http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(left):
Revision: 10227
Author: sco...@google.com
Date: Wed May 25 15:35:34 2011
Log: Bugfixes in ControlFlowAnalyzer
- Instantiating Interface[] failed to rescue Object[]
- Field initializers being visited twice
http://gwt-code-reviews.appspot.com/1443807/
Review by: jbrosenb...@google.com
http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(right):
http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(left):
http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(left):
LGTM
with a couple questions
http://gwt-code-reviews.appspot.com/1452802/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java (right):
36 matches
Mail list logo
