[gwt-contrib] Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

Reviewers: scottb, robertvawter, cromwellian, Description: Removed use of a global table (typeIdArray) for testing castability between types. This information is now stored per class prototype as a castableMap. Please review this at http://gwt-code-reviews.appspot.com/750801/show Affected

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

I have a working version now that removes the use of the typeId, that's passing our tests. I will clean it up and submit it as a separate patch tomorrow(unless you think it's worth adding to this one?) Jason http://gwt-code-reviews.appspot.com/750801/show --

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

http://gwt-code-reviews.appspot.com/750801/diff/1/17 File user/super/com/google/gwt/emul/java/lang/Object.java (right): http://gwt-code-reviews.appspot.com/750801/diff/1/17#newcode46 user/super/com/google/gwt/emul/java/lang/Object.java:46: * lookup castability between types I think this makes

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

http://gwt-code-reviews.appspot.com/750801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

http://gwt-code-reviews.appspot.com/750801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java (right): http://gwt-code-reviews.appspot.com/750801/diff/1/2#newcode86 dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java:86: Object getCastableTypeMap(); Added minor

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

I'm addressing Bob's remaining comments now, new patch forthcoming Jason http://gwt-code-reviews.appspot.com/750801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

http://gwt-code-reviews.appspot.com/750801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

http://gwt-code-reviews.appspot.com/750801/diff/18001/19002 File dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java (right): http://gwt-code-reviews.appspot.com/750801/diff/18001/19002#newcode36 dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java:36:

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

http://gwt-code-reviews.appspot.com/750801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

http://gwt-code-reviews.appspot.com/750801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

Ok, I've addressed Bob's minor nits there (thanks Bob for catching)... I shall proceed to submit this puppy. Thanks for the great review guys Jason http://gwt-code-reviews.appspot.com/750801/diff/10002/45012 File user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java (right):

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

http://gwt-code-reviews.appspot.com/750801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Removed Object.typeId from generated class prototypes, and from the compilation and linkage phas... (issue751803)

Reviewers: scottb, robertvawter, Description: Removed Object.typeId from generated class prototypes, and from the compilation and linkage phases. Type cast checking depends only on the castableTypeMaps and queryIds now. Fixed a bug in deRPC for preserving meta data in transmitted Arrays for

[gwt-contrib] Re: Removed Object.typeId from generated class prototypes, and from the compilation and linkage phas... (issue751803)

http://gwt-code-reviews.appspot.com/751803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed Object.typeId from generated class prototypes, and from the compilation and linkage phas... (issue751803)

http://gwt-code-reviews.appspot.com/751803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix assertion error in CastNormalizer. (issue820801)

Reviewers: scottb, Description: Fix assertion error in CastNormalizer. Please review this at http://gwt-code-reviews.appspot.com/820801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java Index: dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java

[gwt-contrib] Enum name obfuscation option. Addresses issue 2387369 (issue827802)

Reviewers: scottb, cromwellian, robertvawter, Description: Enum name obfuscation option. Addresses issue 2387369 Public: Enum name obfuscation. Added configuration property (compiler.enum.obfuscate.names) to optionally obfuscatate enum names from production output. Please review this at

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

http://gwt-code-reviews.appspot.com/827802/diff/4001/5007 File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java (right): http://gwt-code-reviews.appspot.com/827802/diff/4001/5007#newcode76 user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:76: //

[gwt-contrib] Re: Enum name obfuscation. (issue827802)

http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum name obfuscation. (issue827802)

http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum name obfuscation. (issue827802)

http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Remove dependency on CastableTypeMap from deRPC (issue943803)

Reviewers: zundel, Description: Remove dependency on CastableTypeMap from deRPC Please review this at http://gwt-code-reviews.appspot.com/943803/show Affected files: M user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java M user/src/com/google/gwt/rpc/linker/ClientOracleLinker.java

[gwt-contrib] Enum Ordinalization Optimization (issue1015801)

Reviewers: scottb, cromwellian, Description: Enum Ordinalization Optimization Please review this at http://gwt-code-reviews.appspot.com/1015801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java

[gwt-contrib] Cleanup for EnumsTest and EnumsWithNameObfuscationTest suites, make sure they always run with co... (issue1018801)

Reviewers: cromwellian, Description: Cleanup for EnumsTest and EnumsWithNameObfuscationTest suites, make sure they always run with correct configuration property Please review this at http://gwt-code-reviews.appspot.com/1018801/show Affected files: A

[gwt-contrib] Fix for resolving overloaded enum valueOf method (issue1024801)

Reviewers: scottb, Description: Fix for resolving overloaded enum valueOf method Please review this at http://gwt-code-reviews.appspot.com/1024801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/ast/JClassLiteral.java M user/test/com/google/gwt/dev/jjs/test/EnumsTest.java

[gwt-contrib] Re: Fix for resolving overloaded enum valueOf method (issue1024801)

http://gwt-code-reviews.appspot.com/1024801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum Ordinalization Optimization (issue1015801)

http://gwt-code-reviews.appspot.com/1015801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum Ordinalization Optimization (issue1015801)

http://gwt-code-reviews.appspot.com/1015801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum Ordinalization Optimization (issue1015801)

Added spaces after commas in parameter lists. Named my TODO's. Moved EnumOrdinalizer under the isAggressivelyOptimize block, per zundel's suggestion (and left a TODO to eventually graduate it out of there). http://gwt-code-reviews.appspot.com/1015801/diff/6001/7001 File

[gwt-contrib] Re: Enum Ordinalization Optimization (issue1015801)

http://gwt-code-reviews.appspot.com/1015801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum Ordinalization Optimization (issue1015801)

Updated to handle casting between multi-dimensional arrays where one of them is of an enum type. http://gwt-code-reviews.appspot.com/1015801/diff/13001/14004 File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java (right):

[gwt-contrib] Rolling back Enum Ordinalization Optimization, some issues have been identified. (issue1064801)

Reviewers: zundel, Description: Rolling back Enum Ordinalization Optimization, some issues have been identified. Please review this at http://gwt-code-reviews.appspot.com/1064801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M

[gwt-contrib] Enum Ordinalization Optimization (revisited) (issue1104801)

Reviewers: cromwellian, Description: Enum Ordinalization Optimization (revisited) Please review this at http://gwt-code-reviews.appspot.com/1104801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M

[gwt-contrib] Rolling back Enum Ordinalization Optimization (latent issues have been identified) (issue1128801)

Reviewers: zundel, Description: Rolling back Enum Ordinalization Optimization (latent issues have been identified) Please review this at http://gwt-code-reviews.appspot.com/1128801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M

[gwt-contrib] Enum Ordinalization Optimization (revised) (issue1133801)

Reviewers: cromwellian, Description: Enum Ordinalization Optimization (revised) Please review this at http://gwt-code-reviews.appspot.com/1133801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M

[gwt-contrib] Re: Enum Ordinalization Optimization (revised) (issue1133801)

http://gwt-code-reviews.appspot.com/1133801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)

Do we want to hide this change initially behind a flag (e.g. -DXuseByteCodeToBuildTypeOracle)? http://gwt-code-reviews.appspot.com/1217801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256

[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)

LGTM http://gwt-code-reviews.appspot.com/1217801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:256: I see now that you were

[gwt-contrib] Re: Refactors TypeOracleMediator to get rid of the 'context' as an instance variable. (issue1220801)

LGTM http://gwt-code-reviews.appspot.com/1220801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Experimental framework for generator result caching in dev mode. (issue1227801)

Reviewers: tobyr, zundel, robertvawter, Description: Experimental framework for generator result caching in dev mode. Please review this at http://gwt-code-reviews.appspot.com/1227801/show Affected files: A dev/core/src/com/google/gwt/core/ext/GeneratorContextExt.java A

[gwt-contrib] Re: Experimental framework for generator result caching in dev mode. (issue1227801)

http://gwt-code-reviews.appspot.com/1227801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Base Framework for Generator Result Caching (issue1232801)

Reviewers: tobyr, zundel, Description: Base Framework for Generator Result Caching Please review this at http://gwt-code-reviews.appspot.com/1232801/show Affected files: A dev/core/src/com/google/gwt/core/ext/GeneratorContextExt.java A

[gwt-contrib] Generator Result Caching implementation for RPC (issue1235801)

Reviewers: tobyr, zundel, Description: Generator Result Caching implementation for RPC Please review this at http://gwt-code-reviews.appspot.com/1235801/show Affected files: M user/src/com/google/gwt/rpc/rebind/RpcProxyCreator.java M

[gwt-contrib] Generator Result Caching implementation for ClientBundle (issue1236801)

Reviewers: tobyr, zundel, robertvawter, Description: Generator Result Caching implementation for ClientBundle Please review this at http://gwt-code-reviews.appspot.com/1236801/show Affected files: M user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java M

[gwt-contrib] Re: Base Framework for Generator Result Caching (issue1232801)

Looking into some unit tests, but these may wait to a follow-on release, once we remove the experimental nature of the api, and no longer require the -XenableGeneratorResultCaching flag. http://gwt-code-reviews.appspot.com/1232801/diff/1/4 File dev/core/src/com/google/gwt/dev/DevModeBase.java

[gwt-contrib] Re: Generator Result Caching implementation for RPC (issue1235801)

http://gwt-code-reviews.appspot.com/1235801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for RPC (issue1235801)

http://gwt-code-reviews.appspot.com/1235801/diff/1/4 File user/src/com/google/gwt/user/rebind/rpc/ServiceInterfaceProxyGenerator.java (right): http://gwt-code-reviews.appspot.com/1235801/diff/1/4#newcode61 user/src/com/google/gwt/user/rebind/rpc/ServiceInterfaceProxyGenerator.java:61: return

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

On 2010/12/21 16:02:35, bobv wrote: Bob, thanks for the comments... The mix of explicit vs. implicit dependency tracking is confusing. You have an explicit requirements.addConfigurationProperty(), but the @Source-file tracking is implicit via ResourceContext.getResourcesForMethod().

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/diff/1/3 File user/src/com/google/gwt/resources/ext/ResourceContext.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/1/3#newcode147 user/src/com/google/gwt/resources/ext/ResourceContext.java:147: * a given method. This data will be

[gwt-contrib] Rolling back Generator Result Caching for RPC (issues have been identified) (issue1241801)

Reviewers: zundel, Description: Rolling back Generator Result Caching for RPC (issues have been identified) Please review this at http://gwt-code-reviews.appspot.com/1241801/show Affected files: M user/src/com/google/gwt/rpc/rebind/RpcProxyCreator.java M

[gwt-contrib] Re: Ensure that enum types reachable through AutoBean method parameterizations are included in the E... (issue1240801)

LGTM with nits/suggestions http://gwt-code-reviews.appspot.com/1240801/diff/1/3 File user/src/com/google/gwt/autobean/rebind/model/AutoBeanMethod.java (right): http://gwt-code-reviews.appspot.com/1240801/diff/1/3#newcode201 user/src/com/google/gwt/autobean/rebind/model/AutoBeanMethod.java:201:

[gwt-contrib] Generator Result Caching for RPC, with some refinements to the underlying framework (issue1243801)

Reviewers: zundel, tobyr, Description: Generator Result Caching for RPC, with some refinements to the underlying framework Please review this at http://gwt-code-reviews.appspot.com/1243801/show Affected files: A dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java M

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004 File dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004#newcode30 dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java:30: public

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009 File dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009#newcode574 dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java:574: * structure of a

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

LGTM (with 1 minor nit about a comment) http://gwt-code-reviews.appspot.com/1254801/diff/1/3 File dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorFromByteCodeTest.java (right): http://gwt-code-reviews.appspot.com/1254801/diff/1/3#newcode31

[gwt-contrib] Re: [GWT Designer] Don't cache rebind results while design time (issue1275801)

I'm not sure I understand the larger picture, but I think there are some issues with this approach. Perhaps we can connect up to discuss furtherHere are some of the main points to consider: 1. StandardRebindOracle should not know anything specific about a specific generator, so SRO is not

[gwt-contrib] Re: [GWT Designer] Don't cache rebind results while design time (issue1275801)

On 2011/01/11 22:13:48, Konstantin.Scheglov wrote: In reality, as I can see from patch, there are no UiBinder specific check, just design-time check. But probably would be good to add UiBinder specific check to avoid unnecessary rebinding other classes. Yes, but the design-time check

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/diff/39001/40003 File dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/39001/40003#newcode2 dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java:2: *

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001 File dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001#newcode28 dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java:28: void

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

addByteCode(byte[] byteCode); On 2011/01/25 00:48:19, jbrosenberg wrote: On 2011/01/24 19:14:07, tobyr wrote: Why is this method in the public interface? Can we just remove it and leave the implementation in typemodel.JRealClassType? Well, I thought about doing that, but then we'd lose the benefits

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

LGTM http://gwt-code-reviews.appspot.com/1304802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

: public final class ExternalTextResourceGenerator extends On 2011/01/25 00:48:19, jbrosenberg wrote: On 2011/01/24 19:33:31, bobv wrote: FYI: Unnur is also working on a change to ETRG that may affect its use of properties. I'll consult with Unnur, thanks. Unnur's changes were committed

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add GeneratorContextExt.isProdMode. Allows generators to specialize output for dev or prod mode.... (issue1338801)

http://gwt-code-reviews.appspot.com/1338801/diff/1/3 File dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java (right): http://gwt-code-reviews.appspot.com/1338801/diff/1/3#newcode89 dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java:89: } HmmmI'm not sure

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove useless templatization from JS AST. (issue1310805)

LGTM -- with some questions I looked over the high-level (and scanned each file). It looks like in some places you also changed the types of params (e.g. JsExpression - JsVisitable). Was that intended? All the removing of template params and removing of @SuppressWarnings(unchecked) seem ok

[gwt-contrib] Re: Only intern strings on non-IE browsers when they occur 2 or more times. (issue1336802)

http://gwt-code-reviews.appspot.com/1336802/diff/1/4 File dev/core/src/com/google/gwt/dev/js/JsStringInterner.java (right): http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode48 dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:48: /** Should this comment be changed, to indicate

[gwt-contrib] Enhancements for SpeedTracerLogging within gwt (issue1336803)

Reviewers: zundel, conroy, Description: Enhancements for SpeedTracerLogging within gwt Added support for logging/estimating garbage collection, process cpu time, per thread cpu time, and for overhead time for logging itself. Please review this at

[gwt-contrib] Re: Enhancements for SpeedTracerLogging within gwt (issue1336803)

http://gwt-code-reviews.appspot.com/1336803/diff/1/3 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/1336803/diff/1/3#newcode477 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:477: private

[gwt-contrib] Re: Enhancements for SpeedTracerLogging within gwt (issue1336803)

http://gwt-code-reviews.appspot.com/1336803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enhancements for SpeedTracerLogging within gwt (issue1336803)

http://gwt-code-reviews.appspot.com/1336803/diff/1/3 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/1336803/diff/1/3#newcode592 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:592:

[gwt-contrib] Re: Enhancements for SpeedTracerLogging within gwt (issue1336803)

http://gwt-code-reviews.appspot.com/1336803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make FieldSerializers use reflection directly instead of round-tripping through JSNI. Speeds up ... (issue1310807)

For some reason, the 'View' link for TypeSerializerCreator is broken on this review (but I could look at the diff view). http://gwt-code-reviews.appspot.com/1310807/diff/1/2 File user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java (right):

[gwt-contrib] Re: Reduce logging work in STOB. Wrap logging calls with isLoggable and only create .rpc.log during ... (issue1310806)

http://gwt-code-reviews.appspot.com/1310806/diff/1/3 File user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java (right): http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode841 user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:841: //

[gwt-contrib] Re: Make FieldSerializers use reflection directly instead of round-tripping through JSNI. Speeds up ... (issue1310807)

LGTM (but what's NB:?) http://gwt-code-reviews.appspot.com/1310807/diff/2003/4002 File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java (right): http://gwt-code-reviews.appspot.com/1310807/diff/2003/4002#newcode55

[gwt-contrib] Re: Modifies CompiledClass to be serializable (issue1329802)

http://gwt-code-reviews.appspot.com/1329802/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right): http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode76 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:76: */ I don't see where unit gets re-initialized

[gwt-contrib] Re: Reduce logging work in STOB. Wrap logging calls with isLoggable and only create .rpc.log during ... (issue1310806)

LGTM (with one minor question remaining) http://gwt-code-reviews.appspot.com/1310806/diff/1/3 File user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java (right): http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode1537

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removes @Override annotation from implemented interface methods. (issue1343802)

LGTM http://gwt-code-reviews.appspot.com/1343802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010 File user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode66 user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:66: *

[gwt-contrib] Re: Provides a CachedCompilationUnit class to serialize a CompilationUnit. (issue1357801)

LGTM + minor nits http://gwt-code-reviews.appspot.com/1357801/diff/2001/2004 File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right): http://gwt-code-reviews.appspot.com/1357801/diff/2001/2004#newcode41 dev/core/src/com/google/gwt/dev/javac/Dependencies.java:41: class Dependencies

[gwt-contrib] Re: Allow resource oracle to be expandable, speeds up client bundle in dev mode (issue1356801)

After discussing further with Scott, there's probably a better way to solve this one. Closing this review and retooling. It turns out this does result in a significant savings in practice, for projects with lots of ClientBundles with resources outside of the module space. So this approach

[gwt-contrib] Updated speed tracer logging for JDTCompiler, CompilationStateBuilder (issue1356802)

Reviewers: zundel, Description: Updated speed tracer logging for JDTCompiler, CompilationStateBuilder Please review this at http://gwt-code-reviews.appspot.com/1356802/show Affected files: M dev/core/src/com/google/gwt/dev/javac/CompilationState.java M

[gwt-contrib] Re: Proactively gathers more method names for MethodArgNamesLookup. Before this (issue1359801)

LGTM + nits http://gwt-code-reviews.appspot.com/1359801/diff/6002/7 File dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java (right): http://gwt-code-reviews.appspot.com/1359801/diff/6002/7#newcode39 dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java:39: * visible in

[gwt-contrib] Re: A Class that creates a string hash out of the public API of a (issue1359802)

http://gwt-code-reviews.appspot.com/1359802/diff/4/5 File dev/core/src/com/google/gwt/dev/javac/BytecodeSignatureMaker.java (right): http://gwt-code-reviews.appspot.com/1359802/diff/4/5#newcode76 dev/core/src/com/google/gwt/dev/javac/BytecodeSignatureMaker.java:76: // ignore I think generators

  1   2   3   >