Re: [PATCH] REGTEST/MINOR: skip seamless-reload test with abns socket on freebsd

Hi Pieter, On Sat, Dec 08, 2018 at 09:01:32PM +0100, PiBa-NL wrote: > Hi List, Willy, > > Added below to the reg-tests/seamless-reload/b0.vtc, I'm sure there are > other targets to be excluded, but I'm not sure which. Or should i have > listed 'all' targets except the 5 linux22 - linux2628 sp

[PATCH] REGTEST/MINOR: skip seamless-reload test with abns socket on freebsd

s, PiBa-NL (Pieter) From 3ef9f57b274b350b69d747f8f92fedfb8d283092 Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Sat, 8 Dec 2018 20:51:16 +0100 Subject: [PATCH] REGTEST/MINOR: skip seamless-reload test with abns socket on freebsd abns sockets are not available on freebsd as such mark the test to skip this OS and expose-fd was

Re: [PATCH] REGTEST/MINOR: remove double body specification for server txresp

Hi Pieter, On Sat, Dec 08, 2018 at 07:51:59PM +0100, PiBa-NL wrote: > Hi List, > > I'm getting a regtest failure for the h1.vtc test, seemingly because > varnishtest doesn't like the definition. > > Error (full log attached): > s1    0.0 http[23] |be-hdr-crc: 3634102538 > s1    0.0

[PATCH] REGTEST/MINOR: remove double body specification for server txresp

9e0af05c85e975b Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Sat, 8 Dec 2018 19:48:37 +0100 Subject: [PATCH] REGTEST/MINOR: remove double body specification for server txresp fix http-rules/h0.vtc / http-rules/h0.vtc as both 'bodylen' and 'body' are specified, these se

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

On 11/29/18 10:04 PM, Frederic Lecaille wrote: On 11/29/18 5:36 AM, Willy Tarreau wrote: Hi guys, On Wed, Nov 28, 2018 at 11:17:22AM +0100, Frederic Lecaille wrote: Perhaps we should "chmod +x" this script. Good point, done here. However I'm now seeing this when starting it : #

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

On Thu, Nov 29, 2018 at 10:04:29PM +0100, Frederic Lecaille wrote: > Here is a patch for haproxy (named 0001-REGTEST*) to fix these issues. Works like a charm, thank you Fred! Now applied. Willy

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

On 11/29/18 5:36 AM, Willy Tarreau wrote: Hi guys, On Wed, Nov 28, 2018 at 11:17:22AM +0100, Frederic Lecaille wrote: Perhaps we should "chmod +x" this script. Good point, done here. However I'm now seeing this when starting it : ## Starting varnishtest #

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

Hi Frederic, Op 29-11-2018 om 19:18 schreef Frederic Lecaille: On 11/29/18 8:47 AM, Willy Tarreau wrote: On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote: However I'm well aware that it's easier to work on improvements once the script is merged, so what I've done now is to merge

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

On 11/29/18 8:47 AM, Willy Tarreau wrote: On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote: However I'm well aware that it's easier to work on improvements once the script is merged, so what I've done now is to merge it and create a temporary "reg-tests2" target in the makefile to u

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote: > However I'm well aware that it's easier to work on improvements once the > script is merged, so what I've done now is to merge it and create a > temporary "reg-tests2" target in the makefile to use it without losing > the existing one

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

Hi guys, On Wed, Nov 28, 2018 at 11:17:22AM +0100, Frederic Lecaille wrote: > Perhaps we should "chmod +x" this script. Good point, done here. However I'm now seeing this when starting it : ## Starting varnishtest ## Testing with haproxy version:

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

On 11/27/18 11:17 PM, PiBa-NL wrote: Hi Frederic, Willy, Op 27-11-2018 om 15:00 schreef Frederic Lecaille: On 11/27/18 10:44 AM, Frederic Lecaille wrote: On 11/27/18 9:52 AM, Willy Tarreau wrote: Hi guys, On Tue, Nov 27, 2018 at 09:45:25AM +0100, Frederic Lecaille wrote: I put the script in

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

Hi Pieter, On Tue, Nov 27, 2018 at 11:17:42PM +0100, PiBa-NL wrote: > I've changed the the script to include the LEVEL parameter almost the way > the Makefile used it, changed behavior though so without the parameter it it > runs all tests. (...) > New path attached, which includes a LEVEL check.

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

odification of the Makefile to call the ./scripts/run-regtests.sh Please can someone check it again before merging.?. Thanks guys :). Regards, PiBa-NL (Pieter) From 989bf7ccbfd849deed450291121cdcc68796ba64 Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Tue, 27 Nov 2018 22:26:38 +0100 Subject: [PATCH] RE

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

tioned above. Seems to work ;) Willy, Here is a better patch which takes into an account the modification above and yours (the script is added in "tests" directory). You can merge it as-is. Regards, Fred >From 4432c10a0a822619c152aa187f18b2f6478ac565 Mon Sep 17 00:00:00 2001 From: PiBa-

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

10a0a822619c152aa187f18b2f6478ac565 Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Sun, 25 Nov 2018 16:46:44 +0100 Subject: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script Some tests require a minimal haproxy version or compilation options to be able to run successfully. This script allows

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

Hi guys, On Tue, Nov 27, 2018 at 09:45:25AM +0100, Frederic Lecaille wrote: > > I put the script in the /reg-tests/ folder. Maybe it should have been > > besides the Makefile in the / root ? > > Yes I think it should be placed at the same level as the Makefile. Well, we already have a "scripts"

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

On 11/25/18 4:59 PM, PiBa-NL wrote: Hi Frederic, Willy, Hi Pieter, Added the varnishtest script we have been discussing as a .patch this time. I put the script in the /reg-tests/ folder. Maybe it should have been besides the Makefile in the / root ? Yes I think it should be placed at the

[PATCH] REGTEST/MINOR: script: add run-regtests.sh script

7 00:00:00 2001 From: PiBa-NL Date: Sun, 25 Nov 2018 16:46:44 +0100 Subject: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script Some tests require a minimal haproxy version or compilation options to be able to run successfully. This script allows to add 'requirements' to tests t

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

On Fri, Oct 12, 2018 at 02:29:51PM +0200, PiBa-NL wrote: > Op 12-10-2018 om 10:53 schreef William Lallemand: > > The attached patch should fix the issue. > > The patch works for me, thanks. Great, patch now merged. Thanks! Willy

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi William, Op 12-10-2018 om 10:53 schreef William Lallemand: The attached patch should fix the issue. The patch works for me, thanks. Regards, PiBa-NL (Pieter)

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

On Thu, Oct 11, 2018 at 11:06:38PM +0200, William Lallemand wrote: > On Thu, Oct 11, 2018 at 09:31:48PM +0200, PiBa-NL wrote: > > Hi Willy, William, > > > > Hi Peter, > > Regarding this part: > > > -Connection and request counters to low when ran as regtest from > > varnishtest (bug?) > > It

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

On Thu, Oct 11, 2018 at 09:31:48PM +0200, PiBa-NL wrote: > Hi Willy, William, > Hi Peter, Regarding this part: > -Connection and request counters to low when ran as regtest from > varnishtest (bug?) > It turns out that starting haproxy from varnishtest, and using -W > master-worker mode, act

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Willy, William, Op 2-10-2018 om 3:56 schreef Willy Tarreau: it's important to cut this into pieces to figure what it's showing. A little update on this issue split in 2 pieces. -Connection and request counters to low when ran as regtest from varnishtest (bug?) It turns out that starting

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Pieter, On Thu, Oct 04, 2018 at 09:43:36PM +0200, PiBa-NL wrote: > Hi Willy, > > Op 2-10-2018 om 3:56 schreef Willy Tarreau: > > it's important to cut this into pieces > > to figure what it's showing. > > Okay, the good thing i suppose we already have a reproduction sort-off.. > > What would

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Willy, Op 2-10-2018 om 3:56 schreef Willy Tarreau: it's important to cut this into pieces to figure what it's showing. Okay, the good thing i suppose we already have a reproduction sort-off.. What would be the best way to try and get to the bottom of this? Add debug output to haproxy code

Re: [PATCH] REGTEST/MINOR: compatibility: use unix@ instead of abns@

Hi Pieter, On Thu, Oct 04, 2018 at 12:02:11AM +0200, PiBa-NL wrote: > Hi Frederic, Willy, > > Attached a patch that will change /reg-tests/connection/b0.vtc to use > unix@ sockets so it is compatible with FreeBSD and possibly other OS's. (...) applied, thank you! Willy

[PATCH] REGTEST/MINOR: compatibility: use unix@ instead of abns@

ieter) From 8c5ff12b4603e3525445d6f708f6239974003df4 Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Wed, 3 Oct 2018 23:54:49 +0200 Subject: [PATCH] REGTEST/MINOR: compatibility: use unix@ instead of abns@ sockets Changes the /reg-tests/connection/b0.vtc test to use unix@ instead of abns@ so

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Pieter, On Mon, Oct 01, 2018 at 11:06:33PM +0200, PiBa-NL wrote: > I have used the exact config above, and well it 'works fine' ?? Results > below.. both types of nc requests send to 1 running haproxy result in a > proper '21'.. OK. > But even in this case the results would be 'predicable', w

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Frederic, Op 1-10-2018 om 15:15 schreef Frederic Lecaille: On 09/15/2018 02:03 AM, PiBa-NL wrote: Hi List, Willy, Hi Pieter, Sorry for this late reply. I am also sorry to tell you that -D option should not be used anymore because it as been recently broken. It adds an extra 2s delay on

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Willy, Op 1-10-2018 om 4:00 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 10:16:55PM +0200, PiBa-NL wrote: Hi Willy, Op 30-9-2018 om 20:38 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 08:22:23PM +0200, Willy Tarreau wrote: On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote: Indeed

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

On 09/15/2018 02:03 AM, PiBa-NL wrote: Hi List, Willy, Hi Pieter, Sorry for this late reply. I am also sorry to tell you that -D option should not be used anymore because it as been recently broken. It adds an extra 2s delay on my PC. Without this option, on my PC the test fails but after

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

On Sun, Sep 30, 2018 at 10:16:55PM +0200, PiBa-NL wrote: > Hi Willy, > Op 30-9-2018 om 20:38 schreef Willy Tarreau: > > On Sun, Sep 30, 2018 at 08:22:23PM +0200, Willy Tarreau wrote: > > > On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote: > > > > Indeed it works with 1.8, so in that regard i

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Willy, Op 30-9-2018 om 20:38 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 08:22:23PM +0200, Willy Tarreau wrote: On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote: Indeed it works with 1.8, so in that regard i 'think' the test itself is correct.. Also when disabling threads, or runni

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

On Sun, Sep 30, 2018 at 08:22:23PM +0200, Willy Tarreau wrote: > On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote: > > Indeed it works with 1.8, so in that regard i 'think' the test itself is > > correct.. Also when disabling threads, or running only 1 client, it still > > works.. Then both

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote: > Indeed it works with 1.8, so in that regard i 'think' the test itself is > correct.. Also when disabling threads, or running only 1 client, it still > works.. Then both CumConns CumReq show 11 for the first stats result. Hmmm for me it fai

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

On Sun, Sep 30, 2018 at 07:15:59PM +0200, PiBa-NL wrote: > > on a simple config, the CummConns always matches the CumReq, and when > > running this test I'm seeing random values there in the output, but I > > also see that they are retrieved before all connections are closed > But CurrConns is 0, s

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Willy, Op 30-9-2018 om 7:46 schreef Willy Tarreau: Hi Pieter, On Sun, Sep 30, 2018 at 12:05:14AM +0200, PiBa-NL wrote: Hi Willy, I thought lets give those reg-test another try :) as its easy to run and dev3 just came out. All tests pass on my FreeBSD system, except this one, new reg-test a

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Willy, Op 30-9-2018 om 7:56 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 07:46:24AM +0200, Willy Tarreau wrote: Well, at least it works fine on 1.8 and not on 1.9-dev3 so I think you spotted a regression that we have to analyse. However, I'd like to merge the fix before merging the regtest

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

On Sun, Sep 30, 2018 at 07:46:24AM +0200, Willy Tarreau wrote: > Well, at least it works fine on 1.8 and not on 1.9-dev3 so I think you > spotted a regression that we have to analyse. However, I'd like to merge > the fix before merging the regtest otherwise it will kill the reg-test > feature until

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Pieter, On Sun, Sep 30, 2018 at 12:05:14AM +0200, PiBa-NL wrote: > Hi Willy, > > I thought lets give those reg-test another try :) as its easy to run and > dev3 just came out. > All tests pass on my FreeBSD system, except this one, new reg-test attached. > > Pretty much the same test as previ

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

ilure, or it only logs the failures. There isn't much in between. As for all the rest of the email, thanks for your elaborate response :). Regards, PiBa-NL (Pieter) From 28377ffe246ed1db0e0d898fa6263eccdc68c490 Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Sat, 15 Sep 2018 01:51:54 +02

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Willy, Op 20-9-2018 om 13:56 schreef Willy Tarreau: For me the test produces like 345 lines of output as attached. which seems not to bad (if the test succeeds). It's already far too much for a user. Well those 345 lines are if it succeeds while in 'verbose' mode, in 'normal' mode it only

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Pieter, On Thu, Sep 20, 2018 at 12:48:35AM +0200, PiBa-NL wrote: > Test takes like 5 seconds to run here, and while that is a bit long if you > get a hundred more similar tests and want to continue tweaking developments > while running tests in between. It wouldn't hurt to run such a (series) o

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Willy, Op 19-9-2018 om 7:36 schreef Willy Tarreau: Hi Pieter, I took some time this morning to give it a test. For now it fails here, after dumping 2200 lines of not really usable output that I didn't investigate. From what I'm seeing it seems to moderately stress the local machine so it has

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

Hi Pieter, On Sat, Sep 15, 2018 at 02:03:45AM +0200, PiBa-NL wrote: > Hi List, Willy, > > I've created a regtest that checks that when concurrent connections are > being handled that the connection counters are kept properly. > > I think it could be committed as attached. It takes a few seconds

[PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

1 From: PiBa-NL Date: Sat, 15 Sep 2018 01:51:54 +0200 Subject: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters after running 3000 requests in a loop --- reg-tests/loadtest/b0-loadtest.vtc | 94 ++ 1 file changed, 94 insertions(+) create mode 1

Re: [PATCH] REGTEST/MINOR: lua: Add reg testing files for 70d318c.

On Tue, Sep 04, 2018 at 04:08:56PM +0200, Frederic Lecaille wrote: > On 09/04/2018 04:01 PM, Frederic Lecaille wrote: > > Another reg testing file for a LUA bug fixed by 70d318c commit. > > > > Fred. > > > > The same reg testing file but with indentation fixes. Applied, thank you Fred. Willy

Re: [PATCH] REGTEST/MINOR: lua: Add reg testing files for 70d318c.

=C3=A9caille?= Date: Tue, 4 Sep 2018 15:58:14 +0200 Subject: [PATCH] REGTEST/MINOR: lua: Add reg testing files for 70d318c. --- reg-tests/lua/b3.lua | 1 + reg-tests/lua/b3.vtc | 52 2 files changed, 53 insertions(+) create mode 100644 reg-te

[PATCH] REGTEST/MINOR: lua: Add reg testing files for 70d318c.

Another reg testing file for a LUA bug fixed by 70d318c commit. Fred. >From ff46b36aa4d3ee0213ec0572f9ab3a7261233579 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Tue, 4 Sep 2018 15:58:14 +0200 Subject: [PATCH] REGTEST/MINOR: lua: Add reg testing files

Re: [PATCH] REGTEST/MINOR

On Thu, Aug 23, 2018 at 09:01:45AM +0200, Frederic Lecaille wrote: > Hi ML, > > Here are two patches for haproxy reg testing. (...) Applied, thanks Fred! Willy

[PATCH] REGTEST/MINOR

Hi ML, Here are two patches for haproxy reg testing. Note that we have recently added an new feature to varnishtest so that to send commands to the CLI without running a shell, socat etc (https://varnish-cache.org/docs/trunk/reference/vtc.html#haproxy). This breaks reg-tests/spoe/h0.vtc r

Re: [PATCH] REGTEST/MINOR: Unexpected curl URL globling.

On Fri, Jul 13, 2018 at 10:51:07AM +0200, Frederic Lecaille wrote: > Another patch to fix a remaining issue with this boring VTC file reported by > Ilya. Applied, thanks Fred! willy

[PATCH] REGTEST/MINOR: Unexpected curl URL globling.

reported by Ilya. Fred. >From 1f3c909b3a649059a41d7fa97b4bb4b7be056c53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Fri, 13 Jul 2018 10:44:12 +0200 Subject: [PATCH] REGTEST/MINOR: Unexpected curl URL globling. With certain curl versions URLs which cont

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

On 07/13/2018 10:17 AM, Илья Шипицин wrote: пт, 13 июл. 2018 г. в 13:08, Frederic Lecaille >: On 07/13/2018 09:53 AM, Илья Шипицин wrote: > sorry, I did not test it on centos 7 > > https://gitlab.com/chipitsine/haproxy/-/jobs/81501288 >

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

пт, 13 июл. 2018 г. в 13:08, Frederic Lecaille : > On 07/13/2018 09:53 AM, Илья Шипицин wrote: > > sorry, I did not test it on centos 7 > > > > https://gitlab.com/chipitsine/haproxy/-/jobs/81501288 > > > > > > (I could not find out what's that, error message is strange, I'll try to > > investigate

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

On 07/13/2018 09:53 AM, Илья Шипицин wrote: sorry, I did not test it on centos 7 https://gitlab.com/chipitsine/haproxy/-/jobs/81501288 (I could not find out what's that, error message is strange, I'll try to investigate on separate vm) чт, 12 июл. 2018 г. в 14:08, Frederic Lecaille

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

sorry, I did not test it on centos 7 https://gitlab.com/chipitsine/haproxy/-/jobs/81501288 (I could not find out what's that, error message is strange, I'll try to investigate on separate vm) чт, 12 июл. 2018 г. в 14:08, Frederic Lecaille : > This is a patch to fix the issue reported by Ilya S

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

On Thu, Jul 12, 2018 at 11:05:30AM +0200, Frederic Lecaille wrote: > This is a patch to fix the issue reported by Ilya Shipitsin in this thread. Applied, thank you Fred. Willy

[PATCH] REGTEST/MINOR: Wrong URI syntax.

This is a patch to fix the issue reported by Ilya Shipitsin in this thread. Fred. >From 47ca7696d0ccca5989929940db323e9e9255ae4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Thu, 12 Jul 2018 10:48:06 +0200 Subject: [PATCH] REGTEST/MINOR: Wrong URI syn