[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500926#comment-16500926
]
Konstantin Shvachko commented on HDFS-13399:
+1 for the 010 patch and for the plan to address
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498800#comment-16498800
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498660#comment-16498660
]
Plamen Jeliazkov commented on HDFS-13399:
-
Spoke with [~shv] offline about how to proceed
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498592#comment-16498592
]
Konstantin Shvachko commented on HDFS-13399:
I think we got wrong build links. Here is the
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497399#comment-16497399
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497254#comment-16497254
]
Plamen Jeliazkov commented on HDFS-13399:
-
Please ignore .008 patch as it had a bug in it. There
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494427#comment-16494427
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494033#comment-16494033
]
Plamen Jeliazkov commented on HDFS-13399:
-
Thanks for taking a look [~shv]!
# Removed unused
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491863#comment-16491863
]
Konstantin Shvachko commented on HDFS-13399:
Looked at your patch Plamen. Still think it would
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479957#comment-16479957
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470871#comment-16470871
]
Plamen Jeliazkov commented on HDFS-13399:
-
While I understand the shift there were some major
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464279#comment-16464279
]
Plamen Jeliazkov commented on HDFS-13399:
-
Thank you everyone for your input offline. I think I
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464160#comment-16464160
]
Plamen Jeliazkov commented on HDFS-13399:
-
Yes I propose to remove it from {{DFSClient}}. I think
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462864#comment-16462864
]
Konstantin Shvachko commented on HDFS-13399:
Plamen, I left
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461569#comment-16461569
]
Plamen Jeliazkov commented on HDFS-13399:
-
Hey Konstantin,
Alright I think things are cleared up
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459371#comment-16459371
]
Konstantin Shvachko commented on HDFS-13399:
For the reference attached my changes. Just as a
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459341#comment-16459341
]
Konstantin Shvachko commented on HDFS-13399:
Spent a lot of time on this and finally realized
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454623#comment-16454623
]
Plamen Jeliazkov commented on HDFS-13399:
-
I think I may have uncovered something from looking
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453528#comment-16453528
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453277#comment-16453277
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452862#comment-16452862
]
Plamen Jeliazkov commented on HDFS-13399:
-
Hey [~shv],
Yes there was some misunderstanding. I
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451440#comment-16451440
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451323#comment-16451323
]
Konstantin Shvachko commented on HDFS-13399:
There is some misunderstanding. Why do you still
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450482#comment-16450482
]
Plamen Jeliazkov commented on HDFS-13399:
-
I looked into the unit test failure.
When the timeout
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449255#comment-16449255
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449015#comment-16449015
]
Plamen Jeliazkov commented on HDFS-13399:
-
I was able to remove most of the changes around
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448970#comment-16448970
]
Plamen Jeliazkov commented on HDFS-13399:
-
Yeah I tried to remove the AlignmentContext from
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448937#comment-16448937
]
Konstantin Shvachko commented on HDFS-13399:
Your proposal to change
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448619#comment-16448619
]
Plamen Jeliazkov commented on HDFS-13399:
-
Thanks for the review, [~shv].
Regarding (1), those
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446514#comment-16446514
]
Konstantin Shvachko commented on HDFS-13399:
# It seems to me that {{createNonHAProxy()}} does
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439672#comment-16439672
]
Plamen Jeliazkov commented on HDFS-13399:
-
Failed unit cases appear to be unrelated. Let me know
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436621#comment-16436621
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436263#comment-16436263
]
Plamen Jeliazkov commented on HDFS-13399:
-
Ok attached new patch. I did the following:
(1)
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434729#comment-16434729
]
Erik Krogen commented on HDFS-13399:
{quote}
Just to make sure we are on the same page. Hadoop
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434705#comment-16434705
]
Konstantin Shvachko commented on HDFS-13399:
??We are allowed to break compatibility at minor
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434588#comment-16434588
]
Erik Krogen commented on HDFS-13399:
(1) I just saw the link error and assumed it was related since
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433151#comment-16433151
]
Plamen Jeliazkov commented on HDFS-13399:
-
(1) I am not sure if that Javadoc link error is related
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433061#comment-16433061
]
Plamen Jeliazkov commented on HDFS-13399:
-
Attaching a new patch: whitespace and checkstyle fixes
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433055#comment-16433055
]
Erik Krogen commented on HDFS-13399:
Few comments on the v001 patch:
* Looks like the Javadoc for
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431346#comment-16431346
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431295#comment-16431295
]
Plamen Jeliazkov commented on HDFS-13399:
-
I also have an out-of-scope question for you;
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430941#comment-16430941
]
Plamen Jeliazkov commented on HDFS-13399:
-
Thanks [~xkrogen] – I've taken your changes into a new
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428622#comment-16428622
]
Erik Krogen commented on HDFS-13399:
I think on (2) if the change is not relevant to this JIRA let's
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428591#comment-16428591
]
Plamen Jeliazkov commented on HDFS-13399:
-
Hey [~xkrogen], thanks for the prompt review. :)
*(1)
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427838#comment-16427838
]
genericqa commented on HDFS-13399:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427725#comment-16427725
]
Erik Krogen commented on HDFS-13399:
Hey [~zero45], I took a first look at the patch. I think the
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427453#comment-16427453
]
Plamen Jeliazkov commented on HDFS-13399:
-
Attaching a preliminary patch.
Notable changes:
(1) In
[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426303#comment-16426303
]
Erik Krogen commented on HDFS-13399:
There is some discussion of how to achieve this in the comments
48 matches
Mail list logo
