[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146480717 ## File path:

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146482199 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146482385 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@ message

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146483553 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146483788 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146483992 ## File path:

[GitHub] asfgit commented on issue #649: Pool AddCompletions

asfgit commented on issue #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#issuecomment-338913081 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/bookkeeper-precommit-pullrequest-docker/141/

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146036457 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146485874 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146486343 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146491818 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146520915 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ##

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146520352 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146521260 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ##

[GitHub] eolivelli closed pull request #649: Pool AddCompletions

eolivelli closed pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] jiazhai closed pull request #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

jiazhai closed pull request #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] jiazhai commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

jiazhai commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710#issuecomment-343430652 what a coincidence for us to do it at same time, will close this, since it is merged.

[GitHub] eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150197544 ## File path:

[GitHub] eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

eolivelli commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150197544 ## File path:

[GitHub] ivankelly commented on issue #711: ISSUE #691: Move generated files into their own module

ivankelly commented on issue #711: ISSUE #691: Move generated files into their own module URL: https://github.com/apache/bookkeeper/pull/711#issuecomment-343429555 @eolivelli Addressed comments in latest push This is an

[GitHub] asfgit commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

asfgit commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#issuecomment-343425644 FAILURE --none-- This

[GitHub] ivankelly commented on a change in pull request #706: Bookies should not queue read request indefinitely

ivankelly commented on a change in pull request #706: Bookies should not queue read request indefinitely URL: https://github.com/apache/bookkeeper/pull/706#discussion_r150194893 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestMaxSizeWorkersQueue.java

[GitHub] jiazhai commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

jiazhai commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710#issuecomment-343425606 I will have a try This is an automated

[GitHub] eolivelli commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

eolivelli commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710#issuecomment-343425654 I am merging this into 4.5 This is an

[GitHub] eolivelli commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky

eolivelli commented on issue #710: ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky URL: https://github.com/apache/bookkeeper/pull/710#issuecomment-343425824 are you trying too @jiazhai ? This is

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150196941 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150196445 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150201065 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150201018 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150203340 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150200741 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151225622 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151225239 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151218740 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151218118 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #728: Issue-553 Documentation for new API (WIP)

sijie commented on a change in pull request #728: Issue-553 Documentation for new API (WIP) URL: https://github.com/apache/bookkeeper/pull/728#discussion_r151227038 ## File path: site/docs/4.6.0/api/ledger-api.md ## @@ -264,6 +264,88 @@ Result: 2 # etc ``` +## New API

[GitHub] eolivelli commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

eolivelli commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151228183 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntries.java

[GitHub] eolivelli commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

eolivelli commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151228170 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntries.java

[GitHub] sijie commented on issue #713: New apis should be experimental until they've been used a bit

sijie commented on issue #713: New apis should be experimental until they've been used a bit URL: https://github.com/apache/bookkeeper/issues/713#issuecomment-344701128 All the api should be marked as `@InterfaceAudience.Public` and `@InterfaceStability.Unstable`

[GitHub] sijie commented on issue #728: Issue-553 Documentation for new API (WIP)

sijie commented on issue #728: Issue-553 Documentation for new API (WIP) URL: https://github.com/apache/bookkeeper/pull/728#issuecomment-344699622 The API documentation should be the final change after we sort out all the api related issues.

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150512890 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150515092 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150515363 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150514554 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150515576 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150512696 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150515311 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150513356 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150515004 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150514704 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150514855 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150514882 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints

ivankelly commented on a change in pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#discussion_r150514242 ## File path: site/docs/latest/admin/http.md ## @@ -0,0 +1,317 @@ +--- +title: BookKeeper http

[GitHub] asfgit commented on issue #721: Issue 674: Documentation for HTTP endpoints

asfgit commented on issue #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721#issuecomment-343903058 FAILURE --none-- This is an automated message from the Apache Git

[GitHub] zhaijack opened a new pull request #721: Issue 674: Documentation for HTTP endpoints

zhaijack opened a new pull request #721: Issue 674: Documentation for HTTP endpoints URL: https://github.com/apache/bookkeeper/pull/721 Descriptions of the changes in this PR: Add a document for http endpoints. This is

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150477787 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150479020 ## File path:

[GitHub] ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

ivankelly commented on a change in pull request #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#discussion_r150478188 ## File path:

[GitHub] ivankelly commented on a change in pull request #720: Fixed simultaneus reads on same ledger/entry with v2 protocol

ivankelly commented on a change in pull request #720: Fixed simultaneus reads on same ledger/entry with v2 protocol URL: https://github.com/apache/bookkeeper/pull/720#discussion_r150481321 ## File path:

[GitHub] ivankelly commented on a change in pull request #720: Fixed simultaneus reads on same ledger/entry with v2 protocol

ivankelly commented on a change in pull request #720: Fixed simultaneus reads on same ledger/entry with v2 protocol URL: https://github.com/apache/bookkeeper/pull/720#discussion_r150482316 ## File path:

[GitHub] sijie commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read

sijie commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read URL: https://github.com/apache/bookkeeper/pull/729#discussion_r151261724 ## File path:

[GitHub] sijie commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read

sijie commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read URL: https://github.com/apache/bookkeeper/pull/729#discussion_r151260556 ## File path:

[GitHub] sijie commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read

sijie commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read URL: https://github.com/apache/bookkeeper/pull/729#discussion_r151261333 ## File path:

[GitHub] sijie opened a new pull request #730: Issue 726: Unit Tests failure with BKMetadataVersionException

sijie opened a new pull request #730: Issue 726: Unit Tests failure with BKMetadataVersionException URL: https://github.com/apache/bookkeeper/pull/730 Descriptions of the changes in this PR: Problem: The problem is introduced after making storing ctime optional. the

[GitHub] sijie commented on issue #613: Bookie: LRU FileInfo Eviction Policy

sijie commented on issue #613: Bookie: LRU FileInfo Eviction Policy URL: https://github.com/apache/bookkeeper/issues/613#issuecomment-344420235 This issue is already addressed by #513 This is an automated message from the

[GitHub] sijie closed issue #613: Bookie: LRU FileInfo Eviction Policy

sijie closed issue #613: Bookie: LRU FileInfo Eviction Policy URL: https://github.com/apache/bookkeeper/issues/613 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] jiazhai commented on issue #726: Unit Tests failure with BKMetadataVersionException

jiazhai commented on issue #726: Unit Tests failure with BKMetadataVersionException URL: https://github.com/apache/bookkeeper/issues/726#issuecomment-344528515 Thanks for @sijie's help, this may related changes in #718 This

[GitHub] jiazhai opened a new issue #726: Unit Tests failure with BKMetadataVersionException

jiazhai opened a new issue #726: Unit Tests failure with BKMetadataVersionException URL: https://github.com/apache/bookkeeper/issues/726 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? Run mvn test - What did you expect to see? Expect all

[GitHub] sijie commented on issue #552: Update BookKeeper Tutorial to the the API

sijie commented on issue #552: Update BookKeeper Tutorial to the the API URL: https://github.com/apache/bookkeeper/issues/552#issuecomment-344788327 @eolivelli @ivankelly is any of you working on this? This is an automated

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151304990 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntries.java

[GitHub] jiazhai opened a new issue #731: Refine LedgerEntry interface

jiazhai opened a new issue #731: Refine LedgerEntry interface URL: https://github.com/apache/bookkeeper/issues/731 In review of #727, @sijie suggested to refine the LedgerEntry interface: The LedgerEntry interface is completely a mess. getEntry() and getEntryBuffer() have

[GitHub] zhaijack commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read

zhaijack commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read URL: https://github.com/apache/bookkeeper/pull/729#discussion_r151311828 ## File path:

[GitHub] asfgit commented on issue #730: Issue 726: Unit Tests failure with BKMetadataVersionException

asfgit commented on issue #730: Issue 726: Unit Tests failure with BKMetadataVersionException URL: https://github.com/apache/bookkeeper/pull/730#issuecomment-344787789 FAILURE --none-- This is an automated message

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151305502 ## File path:

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151305208 ## File path:

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151305313 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntries.java

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151305313 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntries.java

[GitHub] zhaijack commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read

zhaijack commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read URL: https://github.com/apache/bookkeeper/pull/729#discussion_r151311751 ## File path:

[GitHub] zhaijack commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read

zhaijack commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read URL: https://github.com/apache/bookkeeper/pull/729#discussion_r151311549 ## File path:

[GitHub] jiazhai opened a new issue #732: Release 4.5.1: update docker image file after 4.5.1 is released

jiazhai opened a new issue #732: Release 4.5.1: update docker image file after 4.5.1 is released URL: https://github.com/apache/bookkeeper/issues/732 update docker image file after 4.5.1 is released This is an automated

[GitHub] eolivelli commented on issue #774: Open should run recovery by default

eolivelli commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347183565 I think that the core of BK is fencing/recovery + LAC, they are pretty unique and amazing features. When you are using BK you know what you

[GitHub] ivankelly commented on issue #782: Don't print out redundant JMX notice

ivankelly commented on issue #782: Don't print out redundant JMX notice URL: https://github.com/apache/bookkeeper/pull/782#issuecomment-347470415 *removed On Tue 28 Nov 2017, 09:50 Ivan Kelly wrote: > Oh, I didn't know that. Ok that case, this while if else

[GitHub] reddycharan commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#issuecomment-347277148 reviewing it now. Thanks This is an automated message from

[GitHub] sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions

sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153277803 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have been

[GitHub] sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions

sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153277291 ## File path: site/community/release_guide.md ## @@ -234,21 +244,14 @@ Use Maven release plugin to

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153285124 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153285124 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347329315 @eolivelli "When you are using BK you know what you are doing" & "they will read carefully the docs" are both counter to being easy to use.

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153284382 ## File path: site/community/release_guide.md ## @@ -234,21 +244,14 @@ Use Maven release

[GitHub] acoburn opened a new pull request #779: Issue 230: Enable Checkstyle on the tls package

acoburn opened a new pull request #779: Issue 230: Enable Checkstyle on the tls package URL: https://github.com/apache/bookkeeper/pull/779 This is part of #230 and adds Checkstyle verification to the TLS package in `bookkeeper-server`.

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153284757 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have

[GitHub] sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153283583 ## File path:

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347140907 @jvrao > non-recovery: default > If the caller doesn't know what they are doing, the ledger may never get sealed. > What is

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153552837 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153552867 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153552849 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153578019 ## File path:

[GitHub] sijie commented on issue #775: Tests wait for client to see started bookie

sijie commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347620519 @ivankelly `CompletableFuture methodAsync()` is better if you are going to provide a sync version of same method `void method()`.

[GitHub] ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153498756 ## File path:

[GitHub] ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153501013 ## File path:

<    1   2   3   4   5   6   7   8   9   10   >