eolivelli merged PR #3439:
URL: https://github.com/apache/bookkeeper/pull/3439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@bookke
StevenLuMT commented on issue #3447:
URL: https://github.com/apache/bookkeeper/issues/3447#issuecomment-1220881695
>
yes, look good to me,thanks @zymap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1220852299
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
hangc0276 closed pull request #3450: Fix wrong stats name
URL: https://github.com/apache/bookkeeper/pull/3450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
StevenLuMT commented on code in PR #3368:
URL: https://github.com/apache/bookkeeper/pull/3368#discussion_r949975958
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LedgerMetadataIndexAsync.java:
##
@@ -0,0 +1,117 @@
+/**
+ *
+ * Licensed to the Apache
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1220383976
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
eolivelli commented on code in PR #3368:
URL: https://github.com/apache/bookkeeper/pull/3368#discussion_r949895963
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LedgerMetadataIndexAsync.java:
##
@@ -0,0 +1,117 @@
+/**
+ *
+ * Licensed to the Apache
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1220348074
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
zymap commented on code in PR #3450:
URL: https://github.com/apache/bookkeeper/pull/3450#discussion_r949742882
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/stats/JournalStats.java:
##
@@ -216,7 +217,7 @@ public JournalStats(StatsLogger statsLogger, final long
hangc0276 opened a new pull request, #3450:
URL: https://github.com/apache/bookkeeper/pull/3450
### Modification
Fix the wrong `cbThreadPoolQueueSize` doc name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tisonkun closed pull request #3449: Bump grpcio dep version of Python client
for supporting ARM
URL: https://github.com/apache/bookkeeper/pull/3449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
tisonkun commented on PR #3449:
URL: https://github.com/apache/bookkeeper/pull/3449#issuecomment-1220133096
Closed for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
tisonkun commented on code in PR #3449:
URL: https://github.com/apache/bookkeeper/pull/3449#discussion_r949717085
##
stream/clients/python/setup.py:
##
@@ -31,7 +31,7 @@
'six>=1.10.0',
'pytz',
'futures>=3.2.0;python_version<"3.2"',
-'grpcio<1.28,>=1.8.2',
+
zymap commented on PR #3448:
URL: https://github.com/apache/bookkeeper/pull/3448#issuecomment-1220118528
cherry-picked to 4.14 and 4.15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
eolivelli commented on code in PR #3449:
URL: https://github.com/apache/bookkeeper/pull/3449#discussion_r949422949
##
stream/clients/python/setup.py:
##
@@ -31,7 +31,7 @@
'six>=1.10.0',
'pytz',
'futures>=3.2.0;python_version<"3.2"',
-'grpcio<1.28,>=1.8.2',
+
tisonkun opened a new pull request, #3449:
URL: https://github.com/apache/bookkeeper/pull/3449
Reference:
* https://github.com/apache/bookkeeper/pull/2432
* https://github.com/apache/pulsar/issues/7477
* https://github.com/grpc/grpc/pull/25418
*
https://github.com/apache/puls
zymap commented on PR #3448:
URL: https://github.com/apache/bookkeeper/pull/3448#issuecomment-1219413551
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
eolivelli commented on PR #3448:
URL: https://github.com/apache/bookkeeper/pull/3448#issuecomment-1219385238
@zymap please cherry-pick to 4.15 and 4.14 branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
eolivelli merged PR #3448:
URL: https://github.com/apache/bookkeeper/pull/3448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@bookke
zymap commented on PR #3448:
URL: https://github.com/apache/bookkeeper/pull/3448#issuecomment-1219349641
Now the TLS test has no failures
https://pipelines.actions.githubusercontent.com/serviceHosts/18fb66ef-1cbe-4dfc-9200-fca890f3f8b2/_apis/pipelines/1/runs/42799/signedlogcontent/2?urlE
zymap opened a new pull request, #3448:
URL: https://github.com/apache/bookkeeper/pull/3448
---
*Motivation*
When runing the tls test, the remote address is a LocalAddress,
but we cast it to the `InetSocketAddress`. That cause the test
`testConnectToLocalTLSClusterTLSClien
zymap commented on issue #3447:
URL: https://github.com/apache/bookkeeper/issues/3447#issuecomment-1218827844
https://github.com/apache/bookkeeper/pull/3439
this PR is for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1217945930
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1217554227
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT opened a new issue, #3447:
URL: https://github.com/apache/bookkeeper/issues/3447
TestTLS.testConnectToLocalTLSClusterTLSClient can't run all successfully in
branch master and 4.15.1-rc0,
it seems that this problem has appeared long ago, rather than being
introduced separately
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1217501028
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1217459504
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1217421099
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1217409959
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1217358847
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1216796484
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1216575392
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
eolivelli merged PR #3444:
URL: https://github.com/apache/bookkeeper/pull/3444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@bookke
eolivelli merged PR #3443:
URL: https://github.com/apache/bookkeeper/pull/3443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@bookke
eolivelli commented on PR #3443:
URL: https://github.com/apache/bookkeeper/pull/3443#issuecomment-1216461826
@nicoloboschi @michaeljmarshall @zymap @merlimat
TLS tests are failing, this is unrelated to this change.
I am committing the patch
--
This is an automated message from t
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1216355600
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1216305868
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1216187201
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1216040104
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
disserakt commented on issue #3445:
URL: https://github.com/apache/bookkeeper/issues/3445#issuecomment-1215270686
@hangc0276 - How can I check if the ledger log file is broken or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1214822071
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
wangjialing218 commented on code in PR #3158:
URL: https://github.com/apache/bookkeeper/pull/3158#discussion_r945371704
##
bookkeeper-common/src/test/java/org/apache/bookkeeper/common/net/ServiceURITest.java:
##
@@ -206,6 +206,30 @@ public void testServiceInfoPlus() {
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1214249759
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
gaozhangmin closed pull request #3446: Support reading entry fail-fast on
unavailable bookie
URL: https://github.com/apache/bookkeeper/pull/3446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1212649794
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
lhotari commented on PR #3444:
URL: https://github.com/apache/bookkeeper/pull/3444#issuecomment-1212256336
> We already have the index lookup stats `read-locations-index-time`, does
it has any case this metric can't cover?
>
>
https://github.com/apache/bookkeeper/blob/de5d45fb823dc55
hangc0276 commented on issue #3445:
URL: https://github.com/apache/bookkeeper/issues/3445#issuecomment-1212212437
It looks like the ledgerId is < 0, which will lead to the above exception. I
wonder whether your ledger log file is broken.
https://github.com/apache/bookkeeper/blob/de5d45fb
gaozhangmin closed pull request #3446: Support skipping unavailable bookie when
reading entry
URL: https://github.com/apache/bookkeeper/pull/3446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
StevenLuMT commented on PR #3103:
URL: https://github.com/apache/bookkeeper/pull/3103#issuecomment-1211856787
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
gaozhangmin closed pull request #3446: Support skipping unavailable bookie when
reading entry
URL: https://github.com/apache/bookkeeper/pull/3446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gaozhangmin opened a new pull request, #3446:
URL: https://github.com/apache/bookkeeper/pull/3446
### Motivation
During autoRecovery, there were so many `Bookie handle is not available`
errors, it was because replicateWorker would tried to read entry from bookie
even if it's alrea
rdhabalia commented on PR #3214:
URL: https://github.com/apache/bookkeeper/pull/3214#issuecomment-1211526187
I think the main issue is #2973 implementation. You should not add a
blocking call to throttle unless you have sync API.
The right fix for #2973 is to check the permit and if the p
lhotari commented on code in PR #3444:
URL: https://github.com/apache/bookkeeper/pull/3444#discussion_r942878756
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java:
##
@@ -73,18 +74,28 @@ public long getLocation(long ledgerId, lon
lhotari commented on code in PR #3444:
URL: https://github.com/apache/bookkeeper/pull/3444#discussion_r942876868
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java:
##
@@ -73,18 +74,28 @@ public long getLocation(long ledgerId, lon
lhotari commented on code in PR #3444:
URL: https://github.com/apache/bookkeeper/pull/3444#discussion_r942874378
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java:
##
@@ -73,18 +74,28 @@ public long getLocation(long ledgerId, lon
StevenLuMT commented on code in PR #3444:
URL: https://github.com/apache/bookkeeper/pull/3444#discussion_r942618402
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java:
##
@@ -73,18 +74,28 @@ public long getLocation(long ledgerId,
StevenLuMT commented on PR #3443:
URL: https://github.com/apache/bookkeeper/pull/3443#issuecomment-1210890542
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
michaeljmarshall commented on code in PR #3444:
URL: https://github.com/apache/bookkeeper/pull/3444#discussion_r942579938
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java:
##
@@ -73,18 +74,28 @@ public long getLocation(long ledg
disserakt opened a new issue, #3445:
URL: https://github.com/apache/bookkeeper/issues/3445
Hi all!
Sometimes we see this ERROR message in the Bookkeeper logs:
`"log.level":"ERROR","message":"Failed to compact entry log 11 due
to unexpected error"`
We use Pulsar versi
lhotari commented on issue #3442:
URL: https://github.com/apache/bookkeeper/issues/3442#issuecomment-1210297380
I have added a new metric for entry location index lookups with PR #3444 .
That is slightly related. It doesn't go down into the RocksDB level, but it
will help detect when RocksD
lhotari opened a new pull request, #3444:
URL: https://github.com/apache/bookkeeper/pull/3444
### Motivation
- this metric will help to detect when the bottleneck is in the entry
location index lookup operations
and RocksDB tuning is needed
### Changes
Add new opera
michaeljmarshall commented on issue #3442:
URL: https://github.com/apache/bookkeeper/issues/3442#issuecomment-1210136035
The available metrics are here:
https://github.com/facebook/rocksdb/blob/d7ebb58cb531031853a183a5771bc4be8c10b45b/include/rocksdb/statistics.h.
I am not very familiar wit
michaeljmarshall commented on issue #3442:
URL: https://github.com/apache/bookkeeper/issues/3442#issuecomment-1210134353
We could expose the metrics by adding these methods to the
`KeyValueStorageRocksDB` class.
```java
public long cacheMisses() throws IOException {
michaeljmarshall opened a new issue, #3442:
URL: https://github.com/apache/bookkeeper/issues/3442
**FEATURE REQUEST**
1. Please describe the feature you are requesting.
Expose rocks db metrics (statistics) in the `/metrics` endpoint.
2. Indicate the importance of this iss
horizonzy commented on PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#issuecomment-1207717335
> > Now we add the shutdown bookies to excludes nodes to replace it.
>
> Just confirm, are you mentioned here?
https://github.com/horizonzy/bookkeeper/blob/6ef1e2aa8ac0780bd819
equanz commented on PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#issuecomment-1207710503
> Now we add the shutdown bookies to excludes nodes to replace it.
Just confirm, are you mentioned here?
https://github.com/horizonzy/bookkeeper/blob/6ef1e2aa8ac0780bd8199b360e
equanz commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939846111
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1083,220 @@ public boolean
areAckedBookiesAd
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939801881
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java:
##
@@ -440,6 +440,31 @@ default boolean
areAckedBookiesAdheringToPlac
horizonzy commented on PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#issuecomment-1207672356
> And what about the default rack? [#2931
(review)](https://github.com/apache/bookkeeper/pull/2931#pullrequestreview-1062016018)
>
> If it is being addressed, please let me kno
davemasterdave opened a new issue, #3441:
URL: https://github.com/apache/bookkeeper/issues/3441
**FEATURE REQUEST**
1. Please describe the feature you are requesting.
I would like to use the etcd driver to run Bookie servers in a production
Kubernetes environment, using the clu
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939807153
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1083,220 @@ public boolean
areAckedBookie
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939803617
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java:
##
@@ -440,6 +440,31 @@ default boolean
areAckedBookiesAdheringToPlac
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939801881
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java:
##
@@ -440,6 +440,31 @@ default boolean
areAckedBookiesAdheringToPlac
equanz commented on PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#issuecomment-1207628808
And what about the default rack?
https://github.com/apache/bookkeeper/pull/2931#pullrequestreview-1062016018
If it is being addressed, please let me know where it is.
--
equanz commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939797743
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/net/NetworkTopology.java:
##
@@ -29,6 +29,7 @@ public interface NetworkTopology {
String DEFAULT_RACK = "
equanz commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939777030
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1083,220 @@ public boolean
areAckedBookiesAd
equanz commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939784939
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1083,220 @@ public boolean
areAckedBookiesAd
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939758977
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java:
##
@@ -481,7 +506,7 @@ public T getResult() {
return resu
zymap commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939756121
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java:
##
@@ -481,7 +506,7 @@ public T getResult() {
return result;
zymap commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939756121
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java:
##
@@ -481,7 +506,7 @@ public T getResult() {
return result;
horizonzy commented on PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#issuecomment-1207521488
@eolivelli ping, address the comment, could you review it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939693677
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1083,236 @@ public boolean
areAckedBookie
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939693630
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1083,236 @@ public boolean
areAckedBookie
yws-tracy commented on issue #2269:
URL: https://github.com/apache/bookkeeper/issues/2269#issuecomment-1207418852
>
@sunshujie1990 we met the same problem, was your problems finally solved？
we use DbLedgerStorage
https://user-images.githubusercontent.com/34879511/183294702-152a341a-9
eolivelli merged PR #3435:
URL: https://github.com/apache/bookkeeper/pull/3435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@bookke
eolivelli commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r939673475
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1083,236 @@ public boolean
areAckedBookie
yws-tracy commented on issue #2269:
URL: https://github.com/apache/bookkeeper/issues/2269#issuecomment-1207415108
> hi @aloyszhang i also saw this problem a few days ago. We are using pulsar
2.6.0， could you please tell me how to solve this issue?
I met the same problem, was your pro
horizonzy commented on PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#issuecomment-1207330892
@equanz Thanks for your graceful way to find replaceAderePlamencePolicy
bookie, I have enhanced it and use it for AutoRecovery feature, could you help
to view it.
--
This is an au
horizonzy commented on PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1207188552
> In my understanding, currently, defaultRack of Rackaware is
`/default-rack`. So we should consider about it if use it.
Yes, you are right. If the test case, we changed the d
equanz commented on PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1206328578
In my understanding, currently, defaultRack of Rackaware is `/default-rack`.
So we should consider about it if use it.
https://github.com/equanz/bookkeeper/blob/62970b3122fa1f8266763
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r938691945
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1084,237 @@ public boolean
areAckedBookie
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r938691945
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1084,237 @@ public boolean
areAckedBookie
horizonzy commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r938691945
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -1079,4 +1084,237 @@ public boolean
areAckedBookie
horizonzy commented on PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1206281401
> However, it is not expected of me. I'll modify to add to excludeNodes
regardless of enforceMinNumRacksPerWriteQuorum value.
Yes, If we already knows which bookie shutdown, I
horizonzy commented on PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1206280009
>> I notice that the implements didn’t handle the bookie which already
shutdown. The shutdown bookie will be as the defaultRack, can we replace it?
> If the default rack name i
equanz commented on PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1206254111
>> I notice that the implements didn’t handle the bookie which already
shutdown. The shutdown bookie will be as the defaultRack, can we replace it?
>
> Currently, maybe, we can't
horizonzy commented on PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1206057762
Improve it both #3359 and this pr. I think the improvement is common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
equanz commented on PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1206044293
@horizonzy
> I notice that the implements didn’t handle the bookie which already
shutdown. The shutdown bookie will be as the defaultRack, can we replace it?
Currently, we
equanz commented on code in PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#discussion_r938418581
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java:
##
@@ -236,6 +236,28 @@ public BookieNode selectFromNetworkLocat
equanz commented on code in PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#discussion_r938418581
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java:
##
@@ -236,6 +236,28 @@ public BookieNode selectFromNetworkLocat
1 - 100 of 21211 matches
Mail list logo
