[jira] [Comment Edited] (CALCITE-5887) Trim function can’t work well with SqlDelegatingConformance

[ https://issues.apache.org/jira/browse/CALCITE-5887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750592#comment-17750592 ] Julian Hyde edited comment on CALCITE-5887 at 8/14/23 11:56 PM: The

[jira] [Commented] (CALCITE-5888) Assertion error in aggregate

[ https://issues.apache.org/jira/browse/CALCITE-5888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754340#comment-17754340 ] Julian Hyde commented on CALCITE-5888: -- This is the {{assert}} in question: {code} assert

[jira] [Updated] (CALCITE-5914) Cache compiled regular expressions in SQL function runtime

[ https://issues.apache.org/jira/browse/CALCITE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5914: - Description: Cache compiled regular expressions (and other amortized work) in SQL function

[jira] [Commented] (CALCITE-5906) Add the visit(Sample e) implementation in RelToSqlConverter

[ https://issues.apache.org/jira/browse/CALCITE-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754338#comment-17754338 ] Julian Hyde commented on CALCITE-5906: -- The PR looks good. Can you rebase it onto main (which now

[jira] [Commented] (CALCITE-5917) Comments in TimeString class are incorrect

[ https://issues.apache.org/jira/browse/CALCITE-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754334#comment-17754334 ] Julian Hyde commented on CALCITE-5917: -- I agree with [~libenchao] that a PR is sufficient for

[jira] [Comment Edited] (CALCITE-5743) Query gives incorrect result when COUNT appears in the correlated subquery select list

[ https://issues.apache.org/jira/browse/CALCITE-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754333#comment-17754333 ] Julian Hyde edited comment on CALCITE-5743 at 8/14/23 10:56 PM:

[jira] [Commented] (CALCITE-5743) Query gives incorrect result when COUNT appears in the correlated subquery select list

[ https://issues.apache.org/jira/browse/CALCITE-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754333#comment-17754333 ] Julian Hyde commented on CALCITE-5743: -- [~shenlang], Here is a query on the built-in EMP table.

[jira] [Commented] (CALCITE-5914) Cache compiled regular expressions in SQL function runtime

[ https://issues.apache.org/jira/browse/CALCITE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754330#comment-17754330 ] Julian Hyde commented on CALCITE-5914: -- Suppose {{FunctionState}} has a method {{void

[jira] [Commented] (CALCITE-985) Validate MERGE

[ https://issues.apache.org/jira/browse/CALCITE-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754252#comment-17754252 ] Julian Hyde commented on CALCITE-985: - [~jiajunbernoulli], I saw you requested that I re-review the

[jira] [Commented] (CALCITE-5921) SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure

[ https://issues.apache.org/jira/browse/CALCITE-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754228#comment-17754228 ] Julian Hyde commented on CALCITE-5921: -- Is this case related to CALCITE-2535 and CALCITE-525? >

[jira] [Commented] (CALCITE-5922) POSITION signature incorrect for SparkSQL

[ https://issues.apache.org/jira/browse/CALCITE-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754226#comment-17754226 ] Julian Hyde commented on CALCITE-5922: -- Does this bug concern parsing SQL, validating SQL, or

[jira] [Commented] (CALCITE-5923) Some test cases in `SqlOperatorTest` violates the test fixture's design principle

[ https://issues.apache.org/jira/browse/CALCITE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754224#comment-17754224 ] Julian Hyde commented on CALCITE-5923: -- Thanks for this. This is a useful change. The commit

[jira] [Commented] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754219#comment-17754219 ] Julian Hyde commented on CALCITE-5909: -- Sorry, but please don't ask me personally to review stuff.

[jira] [Commented] (CALCITE-5928) Add SortHomogenizeRule for homogenization sort fields for futher optimize

[ https://issues.apache.org/jira/browse/CALCITE-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754214#comment-17754214 ] Julian Hyde commented on CALCITE-5928: -- Thanks for logging this case. Complex cases may be

[jira] [Commented] (CALCITE-5894) Add SortRemoveRedundantRule to remove redundant sort fields if they are functionally dependent on other sort fields

[ https://issues.apache.org/jira/browse/CALCITE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754212#comment-17754212 ] Julian Hyde commented on CALCITE-5894: -- I've also added some comments to CALCITE-5913. Let's start

[jira] [Commented] (CALCITE-5913) Support to get functional dependency metadata in RelMetadataQuery

[ https://issues.apache.org/jira/browse/CALCITE-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754211#comment-17754211 ] Julian Hyde commented on CALCITE-5913: -- [~thomas.rebele], I don't know the right interface. We

[jira] [Commented] (CALCITE-5907) Unexpected boolean expression simplification for And expression

[ https://issues.apache.org/jira/browse/CALCITE-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753804#comment-17753804 ] Julian Hyde commented on CALCITE-5907: -- [~libenchao], I agree. If this can be reproduced in

[jira] [Commented] (CALCITE-5894) Add SortRemoveRedundantRule to remove redundant sort fields if they are functionally dependent on other sort fields

[ https://issues.apache.org/jira/browse/CALCITE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753803#comment-17753803 ] Julian Hyde commented on CALCITE-5894: -- I just read the “Fundamental Techniques” paper. I see that

[jira] [Commented] (CALCITE-5927) LoptOptimizeJoinRule has wrong condition when finding out if Self-Join keys are unique

[ https://issues.apache.org/jira/browse/CALCITE-5927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753802#comment-17753802 ] Julian Hyde commented on CALCITE-5927: -- [~qiang.wang] I’m sure you’re right, that this is a bug.

[jira] [Resolved] (CALCITE-5895) TABLESAMPLE(0) should return empty result

[ https://issues.apache.org/jira/browse/CALCITE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-5895. -- Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-5916) In RelBuilder, add sample() method (equivalent to SQL TABLESAMPLE clause)

[ https://issues.apache.org/jira/browse/CALCITE-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-5916. -- Fix Version/s: 1.36.0 Resolution: Fixed Fixed in

[jira] [Assigned] (CALCITE-5916) In RelBuilder, add sample() method (equivalent to SQL TABLESAMPLE clause)

[ https://issues.apache.org/jira/browse/CALCITE-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reassigned CALCITE-5916: Assignee: Julian Hyde > In RelBuilder, add sample() method (equivalent to SQL

[jira] [Commented] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753571#comment-17753571 ] Julian Hyde commented on CALCITE-5909: -- Could you fix CALCITE-5920 in a different commit but the

[jira] [Commented] (CALCITE-5920) Reset PERCENTILE_CONT/PERCENTILE_DISC to ReservedKeyWords

[ https://issues.apache.org/jira/browse/CALCITE-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753555#comment-17753555 ] Julian Hyde commented on CALCITE-5920: -- I agree.  > Reset PERCENTILE_CONT/PERCENTILE_DISC to

[jira] [Resolved] (CALCITE-5184) In parser, allow "LIMIT start, ALL"

[ https://issues.apache.org/jira/browse/CALCITE-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-5184. -- Fix Version/s: 1.36.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-5908) Refactor: Remove unnecessary null checks in CalciteSchema

[ https://issues.apache.org/jira/browse/CALCITE-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-5908. -- Fix Version/s: 1.36.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753423#comment-17753423 ] Julian Hyde commented on CALCITE-5909: -- Thanks for your detective work, [~taoran]. It sounds very

[jira] [Comment Edited] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753019#comment-17753019 ] Julian Hyde edited comment on CALCITE-5909 at 8/11/23 11:04 PM: Hi

[jira] [Commented] (CALCITE-5918) Add MAP function (enabled in Spark library)

[ https://issues.apache.org/jira/browse/CALCITE-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753422#comment-17753422 ] Julian Hyde commented on CALCITE-5918: -- For what it's worth, I don't think that standard SQL has a

[jira] [Commented] (CALCITE-5919) Compile-time implementation of EXTRACT ignores sub-millisecond values

[ https://issues.apache.org/jira/browse/CALCITE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753382#comment-17753382 ] Julian Hyde commented on CALCITE-5919: -- Good one. It seems to me that we should use exact

[jira] [Commented] (CALCITE-5895) TABLESAMPLE(0) should return empty result

[ https://issues.apache.org/jira/browse/CALCITE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752906#comment-17752906 ] Julian Hyde commented on CALCITE-5895: -- I have reviewed again. As I said in the PR, can you change

[jira] [Updated] (CALCITE-5912) Add an implementation of TABLESAMPLE in Enumerable convention

[ https://issues.apache.org/jira/browse/CALCITE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5912: - Summary: Add an implementation of TABLESAMPLE in Enumerable convention (was: Add an

[jira] [Updated] (CALCITE-5895) TABLESAMPLE(0) should return empty result

[ https://issues.apache.org/jira/browse/CALCITE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5895: - Summary: TABLESAMPLE(0) should return empty result (was: The result of table sample rate 0

[jira] [Created] (CALCITE-5916) In RelBuilder, add sample() method (equivalent to SQL TABLESAMPLE clause)

Julian Hyde created CALCITE-5916: Summary: In RelBuilder, add sample() method (equivalent to SQL TABLESAMPLE clause) Key: CALCITE-5916 URL: https://issues.apache.org/jira/browse/CALCITE-5916 Project:

[jira] [Comment Edited] (CALCITE-5910) Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

[ https://issues.apache.org/jira/browse/CALCITE-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752889#comment-17752889 ] Julian Hyde edited comment on CALCITE-5910 at 8/10/23 5:39 PM: --- We need

[jira] [Commented] (CALCITE-5910) Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

[ https://issues.apache.org/jira/browse/CALCITE-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752889#comment-17752889 ] Julian Hyde commented on CALCITE-5910: -- We need to make a decision whether or not to use re2, and

[jira] [Commented] (CALCITE-5858) Add REGEXP_CONTAINS, REGEXP_EXTRACT, REGEXP_EXTRACT_ALL, REGEXP_INSTR, REGEXP_REPLACE and REGEXP_SUBSTR functions (enabled in BigQuery library)

[ https://issues.apache.org/jira/browse/CALCITE-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752888#comment-17752888 ] Julian Hyde commented on CALCITE-5858: -- Depending on how the discussion of re2 vs java regexp

[jira] [Updated] (CALCITE-5914) Cache compiled regular expressions in SQL function runtime

[ https://issues.apache.org/jira/browse/CALCITE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5914: - Description: Cache compiled regular expressions (and other amortized work) in SQL function

[jira] [Updated] (CALCITE-5914) Cache compiled regular expressions in SQL function runtime

[ https://issues.apache.org/jira/browse/CALCITE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5914: - Description: Cache compiled regular expressions (and other amortized work) in SQL function

[jira] [Updated] (CALCITE-5914) Cache compiled regular expressions in SQL function runtime

[ https://issues.apache.org/jira/browse/CALCITE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5914: - Description: Cache compiled regular expressions (and other amortized work) in SQL function

[jira] [Comment Edited] (CALCITE-5858) Add REGEXP_CONTAINS, REGEXP_EXTRACT, REGEXP_EXTRACT_ALL, REGEXP_INSTR, REGEXP_REPLACE and REGEXP_SUBSTR functions (enabled in BigQuery library)

[ https://issues.apache.org/jira/browse/CALCITE-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752438#comment-17752438 ] Julian Hyde edited comment on CALCITE-5858 at 8/9/23 11:53 PM: --- Calcite

[jira] [Updated] (CALCITE-5914) Cache compiled regular expressions in SQL function runtime

[ https://issues.apache.org/jira/browse/CALCITE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5914: - Description: Cache compiled regular expressions (and other amortized work) in SQL function

[jira] [Created] (CALCITE-5914) Cache compiled regular expressions in SQL function runtime

Julian Hyde created CALCITE-5914: Summary: Cache compiled regular expressions in SQL function runtime Key: CALCITE-5914 URL: https://issues.apache.org/jira/browse/CALCITE-5914 Project: Calcite

[jira] [Commented] (CALCITE-5910) Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

[ https://issues.apache.org/jira/browse/CALCITE-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752541#comment-17752541 ] Julian Hyde commented on CALCITE-5910: -- +1 to call out exactly which flavor of regular expressions

[jira] [Updated] (CALCITE-5908) Refactor: Remove unnecessary null checks in CalciteSchema

[ https://issues.apache.org/jira/browse/CALCITE-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5908: - Summary: Refactor: Remove unnecessary null checks in CalciteSchema (was: Remove unnecessary

[jira] [Commented] (CALCITE-5908) Remove unnecessary NULL checks in CalciteSchema

[ https://issues.apache.org/jira/browse/CALCITE-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752516#comment-17752516 ] Julian Hyde commented on CALCITE-5908: -- It's a reasonable refactoring. I was concerned that

[jira] [Reopened] (CALCITE-5908) Remove unnecessary NULL checks in CalciteSchema

[ https://issues.apache.org/jira/browse/CALCITE-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reopened CALCITE-5908: -- > Remove unnecessary NULL checks in CalciteSchema >

[jira] [Commented] (CALCITE-5894) Add SortRemoveRedundantRule to remove redundant sort fields if they are functionally dependent by other sort fields

[ https://issues.apache.org/jira/browse/CALCITE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752309#comment-17752309 ] Julian Hyde commented on CALCITE-5894: -- [~jingda], That sounds like a good plan. This has been a

[jira] [Commented] (CALCITE-5894) Add SortRemoveRedundantRule to remove redundant sort fields if they are functionally dependent by other sort fields

[ https://issues.apache.org/jira/browse/CALCITE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752305#comment-17752305 ] Julian Hyde commented on CALCITE-5894: -- [~libenchao], Yes, it seems likely to me also, that this

[jira] [Comment Edited] (CALCITE-5894) Add SortRemoveRedundantRule to remove redundant sort fields if they are functionally dependent by other sort fields

[ https://issues.apache.org/jira/browse/CALCITE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752299#comment-17752299 ] Julian Hyde edited comment on CALCITE-5894 at 8/9/23 7:33 AM: -- I like the

[jira] [Commented] (CALCITE-5894) Add SortRemoveRedundantRule to remove redundant sort fields if they are functionally dependent by other sort fields

[ https://issues.apache.org/jira/browse/CALCITE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752299#comment-17752299 ] Julian Hyde commented on CALCITE-5894: -- I like the idea of using functional dependencies to

[jira] [Commented] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752223#comment-17752223 ] Julian Hyde commented on CALCITE-5909: -- I've reopened it, because a flaky test is a problem. It's

[jira] [Updated] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5909: - Summary: Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but

[jira] [Updated] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5909: - Priority: Minor (was: Major) > Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords

[jira] [Updated] (CALCITE-5909) Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE but passes when run from the command line

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5909: - Fix Version/s: (was: 1.36.0) > Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords

[jira] [Reopened] (CALCITE-5909) SqlParserTest has a failed unit test, but the Calcite pipeline passed all of them

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reopened CALCITE-5909: -- > SqlParserTest has a failed unit test, but the Calcite pipeline passed all of > them >

[jira] [Commented] (CALCITE-5895) The result of table sample rate 0 is incorrect result and should return the empty result

[ https://issues.apache.org/jira/browse/CALCITE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752205#comment-17752205 ] Julian Hyde commented on CALCITE-5895: -- I agree this is a bug, and we should fix it. The parser

[jira] [Commented] (CALCITE-5894) Add SortRemoveRedundantRule to remove redundant sort fields if sort fields contains unique key

[ https://issues.apache.org/jira/browse/CALCITE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752182#comment-17752182 ] Julian Hyde commented on CALCITE-5894: -- Here is a sketch for the new metadata: {code:java} public

[jira] [Commented] (CALCITE-5894) Add SortRemoveRedundantRule to remove redundant sort fields if sort fields contains unique key

[ https://issues.apache.org/jira/browse/CALCITE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752179#comment-17752179 ] Julian Hyde commented on CALCITE-5894: -- We can generalize a little. If we have "ORDER BY w, x, y,

[jira] [Commented] (CALCITE-5894) Add SortRemoveRedundantRule to remove redundant sort fields if sort fields contains unique key

[ https://issues.apache.org/jira/browse/CALCITE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752177#comment-17752177 ] Julian Hyde commented on CALCITE-5894: -- [~libenchao], There is a significant benefit to removing

[jira] [Comment Edited] (CALCITE-5889) Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

[ https://issues.apache.org/jira/browse/CALCITE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752168#comment-17752168 ] Julian Hyde edited comment on CALCITE-5889 at 8/8/23 8:13 PM: -- You're

[jira] [Commented] (CALCITE-5889) Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

[ https://issues.apache.org/jira/browse/CALCITE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752168#comment-17752168 ] Julian Hyde commented on CALCITE-5889: -- You're right. For regular EXCEPT the condition is "c0 > 0

[jira] [Commented] (CALCITE-5909) SqlParserTest has a failed unit test, but the Calcite pipeline passed all of them

[ https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752113#comment-17752113 ] Julian Hyde commented on CALCITE-5909: -- I’ve seen this happen, too. I think the IDE may be getting

[jira] [Commented] (CALCITE-5908) Remove misleading NULL checks in CalciteSchema

[ https://issues.apache.org/jira/browse/CALCITE-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752102#comment-17752102 ] Julian Hyde commented on CALCITE-5908: -- Do you understand why those checks were added? Read the

[jira] [Commented] (CALCITE-5907) Unexpected boolean expression simplification for And expression

[ https://issues.apache.org/jira/browse/CALCITE-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752095#comment-17752095 ] Julian Hyde commented on CALCITE-5907: -- I agree with[~kgyrtkirk]. The RexCall to EQUALS is not

[jira] [Commented] (CALCITE-5184) In parser, allow "LIMIT start, ALL"

[ https://issues.apache.org/jira/browse/CALCITE-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751737#comment-17751737 ] Julian Hyde commented on CALCITE-5184: -- The commit message is a bit unclear whether this is a bug

[jira] [Commented] (CALCITE-5901) Compiler should not accept DECIMAL types with precision < scale

[ https://issues.apache.org/jira/browse/CALCITE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751411#comment-17751411 ] Julian Hyde commented on CALCITE-5901: -- This bug is a misreading of the standard. The standard

[jira] [Commented] (CALCITE-5889) Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

[ https://issues.apache.org/jira/browse/CALCITE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750885#comment-17750885 ] Julian Hyde commented on CALCITE-5889: -- Thanks, [~shenlang]. That makes sense. It generalizes

[jira] [Commented] (CALCITE-5889) Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

[ https://issues.apache.org/jira/browse/CALCITE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750373#comment-17750373 ] Julian Hyde commented on CALCITE-5889: -- Can you give a SQL query (involving say Emp and Dept) that

[jira] [Commented] (CALCITE-5884) Nullability of of ARRAY_TO_STRING result does not depend on third argument nullability

[ https://issues.apache.org/jira/browse/CALCITE-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750031#comment-17750031 ] Julian Hyde commented on CALCITE-5884: -- I agree, but can you give an example where the third

[jira] [Commented] (CALCITE-5701) Add NAMED_STRUCT function (enabled in Spark library)

[ https://issues.apache.org/jira/browse/CALCITE-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749976#comment-17749976 ] Julian Hyde commented on CALCITE-5701: -- Not the validator. The validator is read-only, and works

[jira] [Commented] (CALCITE-5681) Support authorization via GRANT and REVOKE DDL commands

[ https://issues.apache.org/jira/browse/CALCITE-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749952#comment-17749952 ] Julian Hyde commented on CALCITE-5681: -- I took a very quick look. This looks very well structured

[jira] [Commented] (CALCITE-5883) Calcite ignores window frames when there is no ORDER BY clause

[ https://issues.apache.org/jira/browse/CALCITE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749590#comment-17749590 ] Julian Hyde commented on CALCITE-5883: -- Please check the spec. With ROWS, isn’t CURRENT ROW

[jira] [Updated] (CALCITE-985) Validate MERGE

[ https://issues.apache.org/jira/browse/CALCITE-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-985: Fix Version/s: 1.36.0 > Validate MERGE > -- > > Key: CALCITE-985 >

[jira] [Commented] (CALCITE-5883) Calcite ignores window frames when there is no ORDER BY clause

[ https://issues.apache.org/jira/browse/CALCITE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749358#comment-17749358 ] Julian Hyde commented on CALCITE-5883: -- I agree that this is a duplicate of 4565. However I'm not

[jira] [Commented] (CALCITE-5874) Add withReturnTypeInference copy method for SqlBasicFunction

[ https://issues.apache.org/jira/browse/CALCITE-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748709#comment-17748709 ] Julian Hyde commented on CALCITE-5874: -- I think you should squash this commit into CALCITE-5831.

[jira] [Commented] (CALCITE-5831) Add SOUNDEX function(enabled in Spark library)

[ https://issues.apache.org/jira/browse/CALCITE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748708#comment-17748708 ] Julian Hyde commented on CALCITE-5831: -- When you create related Jira cases, can you "issue links"?

[jira] [Commented] (CALCITE-5874) Add a withReturnTypeInference copy method for SqlBasicFunction

[ https://issues.apache.org/jira/browse/CALCITE-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748222#comment-17748222 ] Julian Hyde commented on CALCITE-5874: -- I reviewed the PR. I don’t think a test is necessary. Are

[jira] [Commented] (CALCITE-5864) getValueAs reports the wrong number of milliseconds for WEEK and the wrong number of months for QUARTER

[ https://issues.apache.org/jira/browse/CALCITE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747667#comment-17747667 ] Julian Hyde commented on CALCITE-5864: -- Your PR looks good, and helped me understand the problem.

[jira] [Commented] (CALCITE-5861) Optimization should constant-fold expressions in window bounds

[ https://issues.apache.org/jira/browse/CALCITE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747629#comment-17747629 ] Julian Hyde commented on CALCITE-5861: -- The SQL spec doesn't 'require' that bounds are constant.

[jira] [Commented] (CALCITE-5870) Core parser support DECIMAL String literal to SqlNumericLiteral sql grammar

[ https://issues.apache.org/jira/browse/CALCITE-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747616#comment-17747616 ] Julian Hyde commented on CALCITE-5870: -- I reviewed the PR. I believe that this will work

[jira] [Commented] (CALCITE-5861) Optimization rules do not constant-fold expressions in window bounds

[ https://issues.apache.org/jira/browse/CALCITE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747141#comment-17747141 ] Julian Hyde commented on CALCITE-5861: -- It's helpful to change "do not" to "should" in the

[jira] [Commented] (CALCITE-5867) Support BLOB data type

[ https://issues.apache.org/jira/browse/CALCITE-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747134#comment-17747134 ] Julian Hyde commented on CALCITE-5867: -- Is it true that I can call {{getBlob}} on columns of type

[jira] [Commented] (CALCITE-5725) Support Doris Dialect

[ https://issues.apache.org/jira/browse/CALCITE-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747045#comment-17747045 ] Julian Hyde commented on CALCITE-5725: -- I agree with what [~libenchao] and[~jiajunbernoulli] have

[jira] [Commented] (CALCITE-5863) Calcite rejects valid query with multiple ORDER BY columns and constant RANGE bounds in window functions

[ https://issues.apache.org/jira/browse/CALCITE-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746764#comment-17746764 ] Julian Hyde commented on CALCITE-5863: -- I agree that this should be valid. The problem is not with

[jira] [Commented] (CALCITE-5864) getValueAs reports the wrong number of milliseconds for QUARTER and WEEK

[ https://issues.apache.org/jira/browse/CALCITE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746744#comment-17746744 ] Julian Hyde commented on CALCITE-5864: -- Is the number of milliseconds in a quarter (or month)

[jira] [Commented] (CALCITE-5866) Not all dialects support sorting in sub-queries

[ https://issues.apache.org/jira/browse/CALCITE-5866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746743#comment-17746743 ] Julian Hyde commented on CALCITE-5866: -- Standard SQL doesn't allow {{ORDER BY}} in subqueries.

[jira] [Commented] (CALCITE-5867) Add BLOB data type in SqlTypeName

[ https://issues.apache.org/jira/browse/CALCITE-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746737#comment-17746737 ] Julian Hyde commented on CALCITE-5867: -- Suppose the summary was 'Support BLOB data type'. What

[jira] [Commented] (CALCITE-985) Validate MERGE

[ https://issues.apache.org/jira/browse/CALCITE-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746720#comment-17746720 ] Julian Hyde commented on CALCITE-985: - I reviewed, and +1 to merge when you've made my requested

[jira] [Commented] (CALCITE-5869) LEAST_RESTRICTIVE does not use inner type of MEASURE for comparisons

[ https://issues.apache.org/jira/browse/CALCITE-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746719#comment-17746719 ] Julian Hyde commented on CALCITE-5869: -- Can you come up with a simple SQL test case? It's

[jira] [Commented] (CALCITE-5688) Support TRUNCATE TABLE DDL statement in server module

[ https://issues.apache.org/jira/browse/CALCITE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746718#comment-17746718 ] Julian Hyde commented on CALCITE-5688: -- Thanks for the prompt response, [~jiajunbernoulli]. The

[jira] [Commented] (CALCITE-5870) Babel Parser support DECIMAL '99.999' to SqlNumericLiteral sql grammar

[ https://issues.apache.org/jira/browse/CALCITE-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746717#comment-17746717 ] Julian Hyde commented on CALCITE-5870: -- Should this be in the Babel parser or the core parser? A

[jira] [Commented] (CALCITE-5688) Support TRUNCATE TABLE DDL statement in server module

[ https://issues.apache.org/jira/browse/CALCITE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746141#comment-17746141 ] Julian Hyde commented on CALCITE-5688: -- The parser now complains about a choice conflict on the

[jira] [Commented] (CALCITE-5865) ClassCastException with FLOOR and CEIL on conformances that are not builtin

[ https://issues.apache.org/jira/browse/CALCITE-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745140#comment-17745140 ] Julian Hyde commented on CALCITE-5865: -- I agree that RelDataTyoeSystem is better than conformance;

[jira] [Commented] (CALCITE-5851) Add LEVENSHTEIN function (enabled in Hive and Spark library)

[ https://issues.apache.org/jira/browse/CALCITE-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744263#comment-17744263 ] Julian Hyde commented on CALCITE-5851: -- My bad. The spark link works correctly in Jira. It failed

[jira] [Commented] (CALCITE-5836) Implement Rel2Sql for MERGE

[ https://issues.apache.org/jira/browse/CALCITE-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743621#comment-17743621 ] Julian Hyde commented on CALCITE-5836: -- I appreciate this PR. But we’re building on sand; until

[jira] [Commented] (CALCITE-4338) Support MERGE INTO Clause

[ https://issues.apache.org/jira/browse/CALCITE-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743620#comment-17743620 ] Julian Hyde commented on CALCITE-4338: -- Can we close this as a duplicate of CALCITE-985? Logging

[jira] [Commented] (CALCITE-5852) Enhance MERGE INTO statement

[ https://issues.apache.org/jira/browse/CALCITE-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743618#comment-17743618 ] Julian Hyde commented on CALCITE-5852: -- I don’t think this clarifies. I believe that the

[jira] [Commented] (CALCITE-5851) Add LEVENSHTEIN function (enabled in Hive and Spark library)

[ https://issues.apache.org/jira/browse/CALCITE-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743542#comment-17743542 ] Julian Hyde commented on CALCITE-5851: -- Since neither of those links take me (directly) to the

[jira] [Commented] (CALCITE-5844) Make RelMdColumnOrigins to be extendable for getting columnOrigins from viewTable

[ https://issues.apache.org/jira/browse/CALCITE-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742651#comment-17742651 ] Julian Hyde commented on CALCITE-5844: -- You don't need to subclass {{{}RelMdColumnOrigins{}}}.

<    3   4   5   6   7   8   9   10   11   12   >