Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230636555
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -118,6 +122,15 @@ public CarbonReaderBuilder
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230388489
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -118,6 +122,16 @@ public CarbonReaderBuilder
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230389069
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -158,14 +172,31 @@ public CarbonReaderBuilder
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230384734
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java ---
@@ -78,6 +81,15 @@ public void initialize(InputSplit
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230386178
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java
---
@@ -145,9 +154,30 @@ public CarbonTable
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230383031
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
---
@@ -524,6 +524,28 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230387678
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java
---
@@ -0,0 +1,211
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230383113
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
---
@@ -524,6 +524,28 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230384381
--- Diff: docs/sdk-guide.md ---
@@ -442,6 +442,16 @@ public CarbonWriterBuilder withJsonInput(Schema
carbonSchema);
public CarbonWriter
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2888
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2877
@ravipesala CI is passed...please merge
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2883
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230257378
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/SnappyCompressor.java
---
@@ -90,7 +90,7 @@ public String getName
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230260860
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -224,135 +239,134
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230258183
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPageValueConverter.java
---
@@ -37,5 +40,6 @@
double
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230261176
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/PrimitivePageStatsCollector.java
---
@@ -243,6 +244,11
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230117118
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaFloatingCodec.java
---
@@ -244,59 +243,56
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2883#discussion_r229628306
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java
---
@@ -350,47 +358,77 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2877#discussion_r229627245
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/encoder/Encoding.java ---
@@ -57,10 +62,55 @@ public static Encoding valueOf(int
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2877#discussion_r229627207
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/encoder/Encoding.java ---
@@ -57,10 +62,55 @@ public static Encoding valueOf(int
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2877#discussion_r229627163
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -696,9 +697,6 @@ private void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2877#discussion_r229620608
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/encoder/Encoding.java ---
@@ -57,10 +62,55 @@ public static Encoding valueOf(int
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2868
retest this please
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2868#discussion_r229578811
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -300,40 +300,27 @@ public static void deleteFoldersAndFiles
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2868#discussion_r229578798
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -300,40 +300,27 @@ public static void deleteFoldersAndFiles
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2876
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2868#discussion_r229363551
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
---
@@ -141,7 +141,12 @@ public boolean
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2868#discussion_r229363490
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/CarbonFile.java
---
@@ -62,6 +62,11 @@
boolean
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2868
> If the table is on S3, will it behave correctly since it does not have
"folder" concept?
I have not changed any existing behavior, so it should work fine
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2876
LGTM...can be merged once build passes
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2876#discussion_r229208742
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -557,16 +561,20 @@ class CarbonDecoderRDD
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2876#discussion_r229208346
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -137,14 +139,15 @@ case class
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2852
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2868#discussion_r229173642
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/SubqueryWithFilterAndSortTestCase.scala
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2877
[WIP] Added validation for supported format version and Encoding type to
throw proper exception to the user while reading a file
**This PR contains:**
1. Validation for columnar
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2852
Please add a Note for `addCarbonTable` method of `CarbonMetadata` class to
say that the method should be used only in driver as clean up in executor is
not handled if this table is added
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2852#discussion_r228850717
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -84,7 +84,7
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2852#discussion_r228845893
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -510,6 +509,7 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2852#discussion_r228845130
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -281,9 +281,7 @@ case class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2852#discussion_r228849744
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/Sorter.java
---
@@ -31,9 +32,10
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2852#discussion_r228850573
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/CarbonRowDataWriterProcessorStepImpl.java
---
@@ -161,7 +159,7
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2868
retest this please
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2868
[WIP] Improve drop table performance by reducing the namenode RPC calls
during physical deletion of files
**Problem**
Current drop table command takes more than 1 minute to delete
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2772
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2848
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2848#discussion_r227731562
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2806
LGTM..can be merged once build is passed
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2808
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2772#discussion_r227304248
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -100,17 +100,17 @@ private
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2772#discussion_r227303328
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java
---
@@ -534,6 +534,11 @@ private int
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2808
@dhatchayani...Please add the description so that I can merge this PR
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2806
This PR holds good till the time the default behavior of load is to
consider all dimension columns as sort columns if sort_column property is not
specified in the schema. If this default
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2806#discussion_r227251258
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/RefreshCarbonTableCommand.scala
---
@@ -118,6
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227239817
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ComplexColumnPage.java
---
@@ -73,8 +73,9 @@ public ComplexColumnPage
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227246688
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -292,7 +300,7 @@ private void addComplexColumn
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227241237
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -125,46 +126,48 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227246446
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -124,8 +116,21 @@ private synchronized
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227235905
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java
---
@@ -168,13 +169,16 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227238938
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java
---
@@ -168,13 +169,16 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2822#discussion_r22787
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2822#discussion_r226973433
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2822#discussion_r226980856
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2820#discussion_r226974300
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
---
@@ -316,4 +320,164 @@ private
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2820#discussion_r226974056
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
---
@@ -98,7 +98,11 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2820#discussion_r226973940
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtrThanEquaToFilterExecuterImpl.java
---
@@ -331,6
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2820#discussion_r226973701
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RestructureEvaluatorImpl.java
---
@@ -104,6 +108,12 @@ protected
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2820#discussion_r226905099
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
---
@@ -143,6 +144,40 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2820#discussion_r226905048
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
---
@@ -143,6 +144,40 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2820#discussion_r226905066
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
---
@@ -143,6 +144,40 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r226223364
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java
---
@@ -91,6 +108,8 @@ public double getDouble(int
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r226188701
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeFixedLengthDimensionDataChunkStore.java
---
@@ -30,9
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r226223232
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java
---
@@ -42,10 +43,26 @@ private LazyColumnPage
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r226188657
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeFixedLengthDimensionDataChunkStore.java
---
@@ -30,9
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r226299668
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaIntegralCodec.java
---
@@ -272,5 +293,164
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r226317816
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java
---
@@ -173,6 +221,23 @@ public int
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r226321251
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DirectPageWiseVectorFillResultCollector.java
---
@@ -0,0 +1,181
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r226329882
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DirectPageWiseVectorFillResultCollector.java
---
@@ -0,0 +1,181
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r225948814
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java
---
@@ -49,6 +51,29
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2818
We should also think of making this parameter configurable using SET
command...
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r225836328
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -178,6 +196,143
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r225853518
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -95,10 +99,24 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r225798939
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -178,6 +196,143
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r225866022
--- Diff:
integration/spark-datasource/src/main/scala/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java
---
@@ -290,12
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r225868472
--- Diff:
integration/spark-datasource/src/main/scala/org/apache/carbondata/spark/vectorreader/ColumnarVectorWrapperDirect.java
---
@@ -0,0
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2818#discussion_r225785597
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -228,9 +230,12 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2818#discussion_r225787305
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -337,19 +340,35
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2818#discussion_r225785705
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -748,4 +754,8 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2818#discussion_r225784934
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -1530,6 +1530,12 @@ public int
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2818#discussion_r225788984
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -374,10 +410,27
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2729#discussion_r225088657
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/dimension/legacy/IndexStorageEncoder.java
---
@@ -66,26 +109,76
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2730
@ravipesala ...Please add code comments wherever applicable...especially
for new classes and to explain major flow or logic...it will make the code more
readable and easy to understand
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2730#discussion_r224746003
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDelta.java
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2730#discussion_r224738600
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2730#discussion_r224776123
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java
---
@@ -95,6 +100,51 @@ public int
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2803
retest this please
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2803
[WIP] Fixed hadoop configuration broadcast issue which was causing the
queries to slow down after some time
Be sure to do all of the following checklist to help us incorporate
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2793
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2793#discussion_r222318367
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -217,6 +212,17 @@ public static MemoryBlock
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2795
[HOTFIX] Changes to align printing of information in explain command based
on enable.query.statistics flag
Now user need to set the flag enable.query.statistics = true to print
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2780
retest this please
---
101 - 200 of 771 matches
Mail list logo
