[jira] [Commented] (GEOMETRY-25) Class "Geometry"

2019-02-10 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764373#comment-16764373 ] Gilles commented on GEOMETRY-25: * {{ZERO_PI}} is redundant (0 is "0" in source code). :

[jira] [Commented] (GEOMETRY-40) Replace commons-rng with commons-geometry on developers guide

2019-02-10 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764359#comment-16764359 ] Gilles commented on GEOMETRY-40: I had fixed the templates files (commit 45b1fe0be5ce96

[jira] [Commented] (GEOMETRY-44) Enable Coveralls Reporting

2019-02-09 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764253#comment-16764253 ] Gilles commented on GEOMETRY-44: Good point.  File a request there. ;) > Enable Coveral

[jira] [Commented] (GEOMETRY-41) Vector Precision Equals

2019-02-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763626#comment-16763626 ] Gilles commented on GEOMETRY-41: bq. "tolerance" was present in the original commons-mat

[jira] [Commented] (GEOMETRY-41) Vector Precision Equals

2019-02-07 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762658#comment-16762658 ] Gilles commented on GEOMETRY-41: bq. using the C++-ish terse method names like eq, and l

[jira] [Commented] (GEOMETRY-41) Vector Precision Equals

2019-02-07 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762579#comment-16762579 ] Gilles commented on GEOMETRY-41: I still don't get why {{areEqual}} rather than {{isEqua

[jira] [Commented] (GEOMETRY-41) Vector Precision Equals

2019-02-06 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761810#comment-16761810 ] Gilles commented on GEOMETRY-41: I find it strange to have an {{areEqual}} method in {{D

[jira] [Updated] (RNG-70) xoshiro generators

2019-02-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated RNG-70: -- Affects Version/s: (was: 1.3) Fix Version/s: 1.3 > xoshiro generators > -- > >

[jira] [Commented] (NUMBERS-90) DoublePrecisionContext

2019-02-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758698#comment-16758698 ] Gilles commented on NUMBERS-90: --- Fine; I should not prevent progress without proposing an a

[jira] [Commented] (NUMBERS-90) DoublePrecisionContext

2019-02-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758507#comment-16758507 ] Gilles commented on NUMBERS-90: --- Sorry I don't have time to do that right now. Is it a prob

[jira] [Commented] (NUMBERS-90) DoublePrecisionContext

2019-01-31 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757813#comment-16757813 ] Gilles commented on NUMBERS-90: --- I'll try to figure out a working example of what I attempt

[jira] [Commented] (NUMBERS-90) DoublePrecisionContext

2019-01-26 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753011#comment-16753011 ] Gilles commented on NUMBERS-90: --- {quote}These classes are meant to replace the usage of tol

[jira] [Commented] (RNG-68) AhrensDieterMarsagliaTsangGammaSampler constructor can be optimised for the theta parameter

2019-01-25 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752341#comment-16752341 ] Gilles commented on RNG-68: --- bq. split the two algorithms into two classes +1 Private inner classe

[jira] [Commented] (NUMBERS-90) DoublePrecisionContext

2019-01-25 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752336#comment-16752336 ] Gilles commented on NUMBERS-90: --- I just don't see clearly how the functionality should be d

[jira] [Resolved] (GEOMETRY-38) Check unit test - line intersecting cube

2019-01-25 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved GEOMETRY-38. Resolution: Fixed Fix Version/s: 1.0 Commit a835cad504b8683e6951b02bd1098cc63ef95105 ("master" bran

[jira] [Resolved] (GEOMETRY-39) Remove Unneeded PlaneAngleRadians Normalize Checks

2019-01-25 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved GEOMETRY-39. Resolution: Fixed Fix Version/s: 1.0 Commit f57f82bea38dcf8646edb3c7f5f70818281a4c77 ("master" bran

[jira] [Resolved] (NUMBERS-93) PlaneAngle normalize() Upper Bound is Exclusive

2019-01-24 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-93. --- Resolution: Fixed Fix Version/s: 1.0 Commit 463183281c06a2398a70a00651fbb5feab5b0413 ("master" branch)

[jira] [Commented] (NUMBERS-90) DoublePrecisionContext

2019-01-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750153#comment-16750153 ] Gilles commented on NUMBERS-90: --- Currently, I fail to see how, for general use, the "contex

[jira] [Resolved] (MATH-1458) Simpson Integrator computes incorrect value at minimum iterations=1 and wastes an iteration

2019-01-18 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved MATH-1458. -- Resolution: Fixed > Simpson Integrator computes incorrect value at minimum iterations=1 and > wastes an iterati

[jira] [Resolved] (MATH-1460) IntegerSequence.Incrementor should fail earlier

2019-01-18 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved MATH-1460. -- Resolution: Fixed > IntegerSequence.Incrementor should fail earlier > --

[jira] [Commented] (NUMBERS-91) Conform BigFraction class to Fraction class

2019-01-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743106#comment-16743106 ] Gilles commented on NUMBERS-91: --- bq. "getReducedFraction" is the only static function I fou

[jira] [Commented] (NUMBERS-92) Rename AbstractFormat to AbstractFractionFormat

2019-01-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743020#comment-16743020 ] Gilles commented on NUMBERS-92: --- Are the "formatting" classes used (within the component)?

[jira] [Resolved] (NUMBERS-89) Standardize Method Names with commons-geometry

2019-01-07 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-89. --- Resolution: Done Fix Version/s: 1.0 Commit 2db8cdfdc65326a4a7e86c004c7c147a645944b0 in "master". > St

[jira] [Resolved] (MATH-1432) IndexOutOfBoundsException when calling PolygonsSet.getSize()

2018-12-31 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved MATH-1432. -- Resolution: Duplicate The OP marked this issue as duplicating a resolved one. > IndexOutOfBoundsException when

[jira] [Commented] (NUMBERS-75) Make "BigFraction" a ValJO

2018-12-27 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729817#comment-16729817 ] Gilles commented on NUMBERS-75: --- There should perhaps be a brief explanation about the reso

[jira] [Resolved] (NUMBERS-85) Move "Slerp" from "Commons Geometry"

2018-12-24 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-85. --- Resolution: Fixed > Move "Slerp" from "Commons Geometry" > > >

[jira] [Commented] (NUMBERS-88) Don't use the default locale in message formatting

2018-12-24 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728402#comment-16728402 ] Gilles commented on NUMBERS-88: --- Yes. But I wish that, somehow, we set "the default format

[jira] [Resolved] (NUMBERS-87) Avoid unnecessary allocations in production code

2018-12-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-87. --- Resolution: Fixed Fix Version/s: 1.0 Commit d6d7b047cd45530986c34a3e66a1251940d6f7e9 ("master") Thanks

[jira] [Commented] (NUMBERS-88) Don't use the default locale in message formatting

2018-12-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728076#comment-16728076 ] Gilles commented on NUMBERS-88: --- I agree that we must avoid inconsistent formatting (part o

[jira] [Resolved] (NUMBERS-86) Slerp Unit Tests

2018-12-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-86. --- Resolution: Fixed Fix Version/s: 1.0 commit c64fa8ae373cb8c71e3754788529d298a4d051a5 > Slerp Unit Tes

[jira] [Commented] (GEOMETRY-11) Replace tolerance with GeometryContext

2018-12-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727579#comment-16727579 ] Gilles commented on GEOMETRY-11: Would the [FP64|https://gitbox.apache.org/repos/asf?p=

[jira] [Commented] (GEOMETRY-31) Standardize Method Names with commons-numbers

2018-12-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727336#comment-16727336 ] Gilles commented on GEOMETRY-31: I meant: Could you merge PR #17 on your side, and make

[jira] [Commented] (NUMBERS-86) Slerp Unit Tests

2018-12-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727329#comment-16727329 ] Gilles commented on NUMBERS-86: --- bq. I can change it to the above if needed, though. Thank

[jira] [Commented] (GEOMETRY-31) Standardize Method Names with commons-numbers

2018-12-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727331#comment-16727331 ] Gilles commented on GEOMETRY-31: bq. depends on PR [https://github.com/apache/commons-g

[jira] [Commented] (NUMBERS-86) Slerp Unit Tests

2018-12-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727325#comment-16727325 ] Gilles commented on NUMBERS-86: --- {quote}It seems cleaner to me to have the call to positive

[jira] [Commented] (GEOMETRY-11) Replace tolerance with GeometryContext

2018-12-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727321#comment-16727321 ] Gilles commented on GEOMETRY-11: How would the {{Precision}} instance be used? > Replac

[jira] [Commented] (NUMBERS-86) Slerp Unit Tests

2018-12-21 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727171#comment-16727171 ] Gilles commented on NUMBERS-86: --- bq. except in the single situation Does it warrant the ad

[jira] [Commented] (GEOMETRY-11) Replace tolerance with GeometryContext

2018-12-21 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726780#comment-16726780 ] Gilles commented on GEOMETRY-11: bq. name could be something like DoublePrecision I did

[jira] [Commented] (NUMBERS-86) Slerp Unit Tests

2018-12-21 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726774#comment-16726774 ] Gilles commented on NUMBERS-86: --- Could you elaborate about the changes (moving the call {{p

[jira] [Commented] (GEOMETRY-31) Standardize Method Names with commons-numbers

2018-12-21 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726659#comment-16726659 ] Gilles commented on GEOMETRY-31: bq. chance I'm overthinking this No; I like it when th

[jira] [Updated] (GEOMETRY-36) Package "o.a.c.geometry.euclidean.threed.rotation"

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated GEOMETRY-36: --- Labels: design documentation (was: ) Description: There is no equivalent in package {{o.a.c.geomet

[jira] [Created] (GEOMETRY-36) z

2018-12-17 Thread Gilles (JIRA)
Gilles created GEOMETRY-36: -- Summary: z Key: GEOMETRY-36 URL: https://issues.apache.org/jira/browse/GEOMETRY-36 Project: Apache Commons Geometry Issue Type: Task Components: Euclidean 3D

[jira] [Created] (GEOMETRY-35) Use "PlaneAngle" from "Commons Numbers"

2018-12-17 Thread Gilles (JIRA)
Gilles created GEOMETRY-35: -- Summary: Use "PlaneAngle" from "Commons Numbers" Key: GEOMETRY-35 URL: https://issues.apache.org/jira/browse/GEOMETRY-35 Project: Apache Commons Geometry Issue Type: Wis

[jira] [Updated] (GEOMETRY-25) Class "Geometry"

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated GEOMETRY-25: --- Fix Version/s: 1.0 > Class "Geometry" > > > Key: GEOMETRY-25 >

[jira] [Resolved] (NUMBERS-83) Replace usage of methods deprecated in Java 9

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-83. --- Resolution: Fixed commit d0cff0d8f2a249e6c87df323fe635386749f62f4 > Replace usage of methods deprecated in J

[jira] [Resolved] (NUMBERS-76) Make "Quaternion" a ValJO

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-76. --- Resolution: Done > Make "Quaternion" a ValJO > - > > Key: NUMBERS-76

[jira] [Updated] (NUMBERS-76) Make "Quaternion" a ValJO

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated NUMBERS-76: -- Description: https://blog.joda.org/2014/03/valjos-value-java-objects.html > Make "Quaternion" a ValJO > ---

[jira] [Resolved] (NUMBERS-42) Factory methods

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-42. --- Resolution: Done > Factory methods > --- > > Key: NUMBERS-42 > UR

[jira] [Resolved] (NUMBERS-56) Wrong dimension check?

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-56. --- Resolution: Fixed > Wrong dimension check? > -- > > Key: NUMBERS-56 >

[jira] [Commented] (NUMBERS-25) Check list for first release

2018-12-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722551#comment-16722551 ] Gilles commented on NUMBERS-25: --- bq. Please review the PR I sent. Much better, but you lef

[jira] [Commented] (GEOMETRY-14) AffineTransform?D Classes

2018-12-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722445#comment-16722445 ] Gilles commented on GEOMETRY-14: bq. I'm thinking of doing it after \[...\] OK. We can

[jira] [Commented] (GEOMETRY-26) Vector safeNormalize()

2018-12-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722441#comment-16722441 ] Gilles commented on GEOMETRY-26: {quote}second version captures the idea of the algorith

[jira] [Commented] (GEOMETRY-30) VectorBuilder?D Classes

2018-12-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722436#comment-16722436 ] Gilles commented on GEOMETRY-30: I'm not convinced by the single centroid example method

[jira] [Commented] (GEOMETRY-26) Vector safeNormalize()

2018-12-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722339#comment-16722339 ] Gilles commented on GEOMETRY-26: bq. I think having a null check will produce cleaner co

[jira] [Commented] (GEOMETRY-14) AffineTransform?D Classes

2018-12-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722338#comment-16722338 ] Gilles commented on GEOMETRY-14: Commit 437c7c4976dde2757fb70aaae08fc86c30e017e7 uses {{

[jira] [Commented] (NUMBERS-85) Move "Slerp" from "Commons Geometry"

2018-12-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722336#comment-16722336 ] Gilles commented on NUMBERS-85: --- Class created in commit fd2fb49e14832ee28f361d558305a8886b

[jira] [Commented] (GEOMETRY-26) Vector safeNormalize()

2018-12-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722330#comment-16722330 ] Gilles commented on GEOMETRY-26: bq. safeNormalize method to the Vector classes that wil

[jira] [Commented] (GEOMETRY-14) AffineTransform?D Classes

2018-12-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722315#comment-16722315 ] Gilles commented on GEOMETRY-14: bq. Are you planning on doing it or should I? I'll mov

[jira] [Commented] (GEOMETRY-14) AffineTransform?D Classes

2018-12-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722266#comment-16722266 ] Gilles commented on GEOMETRY-14: I've removed the redundant accessor methods: If {{Quate

[jira] [Updated] (NUMBERS-85) Move "Slerp" from "Commons Geometry"

2018-12-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated NUMBERS-85: -- Description: Feature branch "feature_GEOMETRY-14" contains a [{{Slerp}}|https://gitbox.apache.org/repos/asf?p=c

[jira] [Created] (NUMBERS-85) Move "Slerp" from "Commons Geometry"

2018-12-15 Thread Gilles (JIRA)
Gilles created NUMBERS-85: - Summary: Move "Slerp" from "Commons Geometry" Key: NUMBERS-85 URL: https://issues.apache.org/jira/browse/NUMBERS-85 Project: Commons Numbers Issue Type: Task Com

[jira] [Updated] (GEOMETRY-25) Class "Geometry"

2018-12-14 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated GEOMETRY-25: --- Component/s: core > Class "Geometry" > > > Key: GEOMETRY-25 >

[jira] [Created] (GEOMETRY-25) Class "Geometry"

2018-12-14 Thread Gilles (JIRA)
Gilles created GEOMETRY-25: -- Summary: Class "Geometry" Key: GEOMETRY-25 URL: https://issues.apache.org/jira/browse/GEOMETRY-25 Project: Apache Commons Geometry Issue Type: Task Reporter:

[jira] [Commented] (GEOMETRY-14) AffineTransform?D Classes

2018-12-14 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721985#comment-16721985 ] Gilles commented on GEOMETRY-14: {quote}plenty to review {quote} Indeed. Thanks for all

[jira] [Resolved] (NUMBERS-80) Quaternion Updates for commons-geometry

2018-12-14 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-80. --- Resolution: Not A Bug I'm closing this report since the description does not match the direction we've taken

[jira] [Resolved] (NUMBERS-84) Quaternion Normalization Should Check for NaN and Infinite

2018-12-14 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-84. --- Resolution: Fixed Fix Version/s: 1.0 commit d7fe20e5d71fe6b473d9491f4a09beafe52633f0 > Quaternion Nor

[jira] [Commented] (NUMBERS-84) Quaternion Normalization Should Check for NaN and Infinite

2018-12-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720916#comment-16720916 ] Gilles commented on NUMBERS-84: --- bq. commit changes Done. > Quaternion Normalization Shou

[jira] [Commented] (NUMBERS-76) Make "Quaternion" a ValJO

2018-12-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720915#comment-16720915 ] Gilles commented on NUMBERS-76: --- I've refactored the class in commit c0bf9f7d93c9f5fd09bd12

[jira] [Commented] (NUMBERS-84) Quaternion Normalization Should Check for NaN and Infinite

2018-12-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720881#comment-16720881 ] Gilles commented on NUMBERS-84: --- bq. This is the last change I need before using Quaternion

[jira] [Resolved] (NUMBERS-21) Target Java 8

2018-12-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-21. --- Resolution: Done commit 317076df3dc11d9ea9ad0baaea1a26073adf052b > Target Java 8 > - > >

[jira] [Commented] (NUMBERS-84) Quaternion Normalization Should Check for NaN and Infinite

2018-12-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720874#comment-16720874 ] Gilles commented on NUMBERS-84: --- {quote}any reasons to keep using JDK 6? {quote} No: NUMBER

[jira] [Commented] (NUMBERS-84) Quaternion Normalization Should Check for NaN and Infinite

2018-12-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720821#comment-16720821 ] Gilles commented on NUMBERS-84: --- I'm working on "Quaternion" (based on the "dev" ML ValJO d

[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"

2018-12-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720817#comment-16720817 ] Gilles commented on NUMBERS-77: --- bq. my work on Fraction overflows Commenting on the wrong

[jira] [Updated] (MATH-1472) KolmogorSmirnovTest: Unit test fails

2018-12-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated MATH-1472: - Summary: KolmogorSmirnovTest: Unit test fails (was: Unit test fails in "Commons Math") > KolmogorSmirnovTest: Un

[jira] [Commented] (RNG-66) Unit test fails in "Commons Math"

2018-12-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719297#comment-16719297 ] Gilles commented on RNG-66: --- bq. Bug is perhaps in the usage Confirming: In line {code} data[i] +=

[jira] [Comment Edited] (MATH-1472) Unit test fails in "Commons Math"

2018-12-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719297#comment-16719297 ] Gilles edited comment on MATH-1472 at 12/12/18 6:45 PM: {quote}Bug

[jira] [Moved] (MATH-1472) Unit test fails in "Commons Math"

2018-12-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles moved RNG-66 to MATH-1472: - Affects Version/s: (was: 1.2) Component/s: (was: core) Workflow: cl

[jira] [Updated] (MATH-1472) Unit test fails in "Commons Math"

2018-12-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated MATH-1472: - Description: Upgrading the dependency of "Commons Math" to the just released v1.2 of "Commons RNG", a unit test n

[jira] [Commented] (NUMBERS-80) Quaternion Updates for commons-geometry

2018-12-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719284#comment-16719284 ] Gilles commented on NUMBERS-80: --- bq. match commons-numbers here? Probably; but if somethin

[jira] [Commented] (RNG-66) Unit test fails in "Commons Math"

2018-12-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719270#comment-16719270 ] Gilles commented on RNG-66: --- Bug is perhaps in the usage: {code} private static void jitter(double

[jira] [Created] (RNG-66) Unit test fails in "Commons Math"

2018-12-12 Thread Gilles (JIRA)
Gilles created RNG-66: - Summary: Unit test fails in "Commons Math" Key: RNG-66 URL: https://issues.apache.org/jira/browse/RNG-66 Project: Commons RNG Issue Type: Bug Components: core Affect

[jira] [Commented] (NUMBERS-80) Quaternion Updates for commons-geometry

2018-12-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719185#comment-16719185 ] Gilles commented on NUMBERS-80: --- bq. Is the Default class needed? I think so; class {{Quat

[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"

2018-12-12 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719159#comment-16719159 ] Gilles commented on NUMBERS-77: --- I was thinking about utilities that work tuples (e.g. {{Si

[jira] [Commented] (NUMBERS-83) Replace usage of methods deprecated in Java 9

2018-12-11 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718106#comment-16718106 ] Gilles commented on NUMBERS-83: --- Classes {{Complex}} and {{PlaneAngle}} fixed in commit 11

[jira] [Commented] (NUMBERS-80) Quaternion Updates for commons-geometry

2018-12-11 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717480#comment-16717480 ] Gilles commented on NUMBERS-80: --- Hi Matt and Steve. Please have a look at commit d216fe767

[jira] [Created] (NUMBERS-83) Replace usage of methods deprecated in Java 9

2018-12-11 Thread Gilles (JIRA)
Gilles created NUMBERS-83: - Summary: Replace usage of methods deprecated in Java 9 Key: NUMBERS-83 URL: https://issues.apache.org/jira/browse/NUMBERS-83 Project: Commons Numbers Issue Type: Task

[jira] [Commented] (NUMBERS-25) Check list for first release

2018-12-11 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716630#comment-16716630 ] Gilles commented on NUMBERS-25: --- Your branch must be updated to the current state of the "m

[jira] [Commented] (NUMBERS-80) Quaternion Updates for commons-geometry

2018-12-10 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715989#comment-16715989 ] Gilles commented on NUMBERS-80: --- Instance fields renamed to {{(w, x, y, z)}} in commit 1d8

[jira] [Commented] (GEOMETRY-14) AffineTransform?D Classes

2018-12-10 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714824#comment-16714824 ] Gilles commented on GEOMETRY-14: bq. get NUMBERS-80 sorted out I'll take care of the fi

[jira] [Commented] (NUMBERS-80) Quaternion Updates for commons-geometry

2018-12-09 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713928#comment-16713928 ] Gilles commented on NUMBERS-80: --- bq. Make constructor protected. We overlooked that it wil

[jira] [Resolved] (NUMBERS-51) Represent the "field" concept

2018-12-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-51. --- Resolution: Implemented Review of module {{commons-numbers-field}} would still be welcome. > Represent the "

[jira] [Commented] (NUMBERS-51) Represent the "field" concept

2018-12-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713819#comment-16713819 ] Gilles commented on NUMBERS-51: --- Branch was merged in commit fff24948c7f89fd9f00e721c0c5e06

[jira] [Commented] (NUMBERS-56) Wrong dimension check?

2018-12-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713815#comment-16713815 ] Gilles commented on NUMBERS-56: --- Steve, I've merged your PR.  Thanks a lot for this work!

[jira] [Resolved] (NUMBERS-81) Jacoco reports 0% coverage

2018-12-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-81. --- Resolution: Fixed Fix Version/s: (was: 1.0) Problem was due to a crash of the surefire plugin. See

[jira] [Commented] (NUMBERS-25) Check list for first release

2018-12-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713809#comment-16713809 ] Gilles commented on NUMBERS-25: --- Gimo, I'm afraid I've lost track of your PR. Sorry. Coul

[jira] [Created] (NUMBERS-82) Update PMD configuration

2018-12-08 Thread Gilles (JIRA)
Gilles created NUMBERS-82: - Summary: Update PMD configuration Key: NUMBERS-82 URL: https://issues.apache.org/jira/browse/NUMBERS-82 Project: Commons Numbers Issue Type: Sub-task Reporter:

[jira] [Created] (NUMBERS-81) Jacoco reports 0% coverage

2018-12-08 Thread Gilles (JIRA)
Gilles created NUMBERS-81: - Summary: Jacoco reports 0% coverage Key: NUMBERS-81 URL: https://issues.apache.org/jira/browse/NUMBERS-81 Project: Commons Numbers Issue Type: Task Components: c

[jira] [Updated] (NUMBERS-21) Target Java 8

2018-12-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated NUMBERS-21: -- Summary: Target Java 8 (was: Target Java 7) > Target Java 8 > - > > Key: NUMBERS-2

[jira] [Commented] (NUMBERS-54) Stream-based utilities

2018-12-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713802#comment-16713802 ] Gilles commented on NUMBERS-54: --- The current modules layout * {{commons-numbers-complex}} w

[jira] [Commented] (NUMBERS-21) Target Java 7

2018-12-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713799#comment-16713799 ] Gilles commented on NUMBERS-21: --- Time passes... I now think that it's not worth targeting

<    1   2   3   4   5   6   7   8   9   10   >