[
https://issues.apache.org/jira/browse/MATH-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120217#comment-17120217
]
Gilles Sadowski commented on MATH-1536:
---
bq. related to the change of nextDouble()
Sure.
IMO, it
garydgregory commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432839481
##
File path: src/main/java/org/apache/commons/beanutils2/ConvertUtilsBean.java
##
@@ -172,8 +172,8 @@
public class ConvertUtilsBean {
-
XenoAmess commented on pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#issuecomment-636324147
> OK I am very impressed by both IntelliJ and the other plugin because these
are all great suggestions.
> OK I am very impressed by both IntelliJ and the
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432842061
##
File path: src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
##
@@ -144,19 +144,19 @@ public Object get(final String name) {
JIN XU created IO-669:
-
Summary: fix code smells; fix typos
Key: IO-669
URL: https://issues.apache.org/jira/browse/IO-669
Project: Commons IO
Issue Type: Improvement
Reporter: JIN XU
JIN XU created BEANUTILS-537:
Summary: fix typos; fix error in javadoc; performance fix; fix
code smells
Key: BEANUTILS-537
URL: https://issues.apache.org/jira/browse/BEANUTILS-537
Project: Commons
XenoAmess commented on pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#issuecomment-636323681
> This is a nice PR. Can I ask were these IntelliJ suggestions?
for most of them, yes.
and others are from another inspection plugin.
melloware commented on pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#issuecomment-636323935
OK I am very impressed by both IntelliJ and the other plugin because these
are all great suggestions.
dota17 commented on pull request #159:
URL:
https://github.com/apache/commons-collections/pull/159#issuecomment-636294209
comparators/AbstractComparatorTest.java
comparators/BooleanComparatorTest.java
comparators/ComparatorChainTest.java
comparators/FixedOrderComparatorTest.java
coveralls edited a comment on pull request #115:
URL: https://github.com/apache/commons-io/pull/115#issuecomment-633306871
[](https://coveralls.io/builds/31131698)
Coverage remained the same at 89.783% when pulling
melloware commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432840234
##
File path: src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
##
@@ -144,19 +144,19 @@ public Object get(final String name) {
XenoAmess edited a comment on pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#issuecomment-636324147
> OK I am very impressed by both IntelliJ and the other plugin because these
are all great suggestions.
Ah I fogot to mention
You can pick that plugin
[
https://issues.apache.org/jira/browse/BEANUTILS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JIN XU updated BEANUTILS-537:
-
Issue Type: Improvement (was: Bug)
> fix typos; fix error in javadoc; performance fix; fix code
[
https://issues.apache.org/jira/browse/MATH-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120127#comment-17120127
]
Alex Herbert commented on MATH-1536:
Possibly related to the change of nextDouble() to create 2^53
XenoAmess opened a new pull request #24:
URL: https://github.com/apache/commons-jexl/pull/24
also `static public` to `public static`
This is an automated message from the Apache Git Service.
To respond to the message,
coveralls edited a comment on pull request #159:
URL:
https://github.com/apache/commons-collections/pull/159#issuecomment-625612511
[](https://coveralls.io/builds/31130760)
Coverage decreased (-0.004%) to 90.119%
garydgregory commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432840384
##
File path: src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
##
@@ -144,19 +144,19 @@ public Object get(final String name) {
XenoAmess opened a new pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25
notice that because of there exist some typos in some public functions, this
pr may break BC.
This is an automated message
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432843902
##
File path: src/main/java/org/apache/commons/beanutils2/MethodUtils.java
##
@@ -1150,7 +1150,7 @@ private static float
garydgregory commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432843564
##
File path:
src/main/java/org/apache/commons/beanutils2/locale/converters/StringLocaleConverter.java
##
@@ -268,7 +268,7 @@ else if (value
garydgregory commented on a change in pull request #117:
URL: https://github.com/apache/commons-io/pull/117#discussion_r432845089
##
File path:
src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestSimple.java
##
@@ -66,6 +67,10 @@ public void
XenoAmess opened a new pull request #532:
URL: https://github.com/apache/commons-lang/pull/532
Hi.
commit
https://github.com/apache/commons-lang/commit/c141bc961cb5cb84c47a21c3a5b0f15ab0035728
broke the Checkstyle, thus making travis-ci cannot pass.
thus I made a commit to fix it.
JIN XU created JEXL-332:
---
Summary: fix 404 ruls in readme.
Key: JEXL-332
URL: https://issues.apache.org/jira/browse/JEXL-332
Project: Commons JEXL
Issue Type: Improvement
Reporter: JIN XU
coveralls edited a comment on pull request #117:
URL: https://github.com/apache/commons-io/pull/117#issuecomment-636140238
[](https://coveralls.io/builds/31135023)
Coverage decreased (-0.03%) to 89.751% when pulling
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844388
##
File path:
src/main/java/org/apache/commons/beanutils2/locale/converters/StringLocaleConverter.java
##
@@ -268,7 +268,7 @@ else if (value
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844458
##
File path: src/main/java/org/apache/commons/beanutils2/JDBCDynaClass.java
##
@@ -106,7 +106,7 @@ public DynaProperty getDynaProperty(final
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844475
##
File path: src/main/java/org/apache/commons/beanutils2/ConvertUtilsBean.java
##
@@ -172,8 +172,8 @@
public class ConvertUtilsBean {
-
garydgregory commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844498
##
File path: src/main/java/org/apache/commons/beanutils2/MethodUtils.java
##
@@ -1150,7 +1150,7 @@ private static float
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844493
##
File path: src/main/java/org/apache/commons/beanutils2/BasicDynaClass.java
##
@@ -165,7 +165,7 @@ public DynaProperty getDynaProperty(final
XenoAmess opened a new pull request #26:
URL: https://github.com/apache/commons-beanutils/pull/26
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
XenoAmess commented on pull request #26:
URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-636354515
I know void can never be a class of a parameter of a function, but should we
consider about adding logics for void and Void?
after all void.class.isPrimitive() is
[
https://issues.apache.org/jira/browse/JEXL-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro resolved JEXL-332.
Fix Version/s: 3.2
Resolution: Fixed
Thanks! Committed pull request 24.
> fix 404 ruls in
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844925
##
File path:
src/main/java/org/apache/commons/beanutils2/locale/converters/IntegerLocaleConverter.java
##
@@ -215,8 +215,8 @@ public
[
https://issues.apache.org/jira/browse/IO-669?focusedWorklogId=439104=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439104
]
ASF GitHub Bot logged work on IO-669:
-
Author: ASF GitHub Bot
Created
XenoAmess commented on a change in pull request #115:
URL: https://github.com/apache/commons-io/pull/115#discussion_r432869943
##
File path:
src/test/java/org/apache/commons/io/filefilter/FileFilterTestCase.java
##
@@ -1406,7 +1406,7 @@ public void
XenoAmess commented on a change in pull request #115:
URL: https://github.com/apache/commons-io/pull/115#discussion_r432870107
##
File path: src/main/java/org/apache/commons/io/file/Counters.java
##
@@ -92,8 +92,8 @@ public int hashCode() {
@Override
public
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844631
##
File path:
src/main/java/org/apache/commons/beanutils2/converters/CharacterConverter.java
##
@@ -84,7 +84,7 @@ protected String
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844590
##
File path: src/main/java/org/apache/commons/beanutils2/PropertyUtilsBean.java
##
@@ -504,7 +504,7 @@ public Object getIndexedProperty(final
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844680
##
File path:
src/main/java/org/apache/commons/beanutils2/converters/NumberConverter.java
##
@@ -243,17 +243,17 @@ protected String
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432845691
##
File path: src/main/java/org/apache/commons/beanutils2/MethodUtils.java
##
@@ -1150,7 +1150,7 @@ private static float
garydgregory merged pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/BEANUTILS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated BEANUTILS-537:
--
Summary: Fix typos; fix error in Javadoc; performance fix; fix code smells
#25
[
https://issues.apache.org/jira/browse/BEANUTILS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved BEANUTILS-537.
---
Fix Version/s: 2.0.0
Resolution: Fixed
Please review and close.
> fix
XenoAmess commented on pull request #26:
URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-636354813
also, right now I used a homemade array list of classes as performance test
data.
if we have more 'real' data about how we use these functions usually (what
class
mernst commented on a change in pull request #117:
URL: https://github.com/apache/commons-io/pull/117#discussion_r432871156
##
File path:
src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestSimple.java
##
@@ -66,6 +67,10 @@ public void
coveralls edited a comment on pull request #115:
URL: https://github.com/apache/commons-io/pull/115#issuecomment-633306871
[](https://coveralls.io/builds/31134674)
Coverage remained the same at 89.783% when pulling
[
https://issues.apache.org/jira/browse/IO-669?focusedWorklogId=439110=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439110
]
ASF GitHub Bot logged work on IO-669:
-
Author: ASF GitHub Bot
Created
henrib merged pull request #24:
URL: https://github.com/apache/commons-jexl/pull/24
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/IO-669?focusedWorklogId=439073=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439073
]
ASF GitHub Bot logged work on IO-669:
-
Author: ASF GitHub Bot
Created
XenoAmess edited a comment on pull request #26:
URL: https://github.com/apache/commons-beanutils/pull/26#issuecomment-636354515
one more question: I know void can never be a class of a parameter of a
function, but should we consider about adding logics for void and Void?
after all
[
https://issues.apache.org/jira/browse/IO-669?focusedWorklogId=439107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439107
]
ASF GitHub Bot logged work on IO-669:
-
Author: ASF GitHub Bot
Created
XenoAmess closed pull request #426:
URL: https://github.com/apache/commons-lang/pull/426
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory commented on a change in pull request #115:
URL: https://github.com/apache/commons-io/pull/115#discussion_r432843971
##
File path: src/main/java/org/apache/commons/io/file/Counters.java
##
@@ -245,7 +245,7 @@ public BigInteger getBigInteger() {
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432843902
##
File path: src/main/java/org/apache/commons/beanutils2/MethodUtils.java
##
@@ -1150,7 +1150,7 @@ private static float
[
https://issues.apache.org/jira/browse/IO-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated IO-119:
--
Fix Version/s: (was: 3.x)
> Convenience "Builder" for creating complex FileFilter conditions
>
[
https://issues.apache.org/jira/browse/IO-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated IO-154:
--
Fix Version/s: (was: 3.x)
> Throw IllegalArgumentException when parameters are null (and explicitly
>
[
https://issues.apache.org/jira/browse/IO-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated IO-89:
-
Fix Version/s: (was: 3.x)
> Inconsistency in SizeFileFilter and AgeFileFilter implementations
>
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844827
##
File path:
src/main/java/org/apache/commons/beanutils2/locale/converters/DoubleLocaleConverter.java
##
@@ -212,7 +212,7 @@ public
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844794
##
File path:
src/main/java/org/apache/commons/beanutils2/converters/NumberConverter.java
##
@@ -87,8 +87,8 @@
*/
public abstract class
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844716
##
File path: src/main/java/org/apache/commons/beanutils2/WrapDynaClass.java
##
@@ -184,7 +184,7 @@ public DynaProperty getDynaProperty(final
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844774
##
File path:
src/main/java/org/apache/commons/beanutils2/converters/DateTimeConverter.java
##
@@ -341,7 +341,7 @@ protected String
XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844821
##
File path:
src/main/java/org/apache/commons/beanutils2/locale/converters/ByteLocaleConverter.java
##
@@ -217,6 +217,6 @@ protected Object
JIN XU created BEANUTILS-538:
Summary: refine performance of MethodUtils.getPrimitiveWrapper and
getPrimitiveType
Key: BEANUTILS-538
URL: https://issues.apache.org/jira/browse/BEANUTILS-538
Project:
coveralls commented on pull request #80:
URL: https://github.com/apache/commons-imaging/pull/80#issuecomment-636399900
[](https://coveralls.io/builds/31138327)
Coverage remained the same at 76.304% when pulling
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439184=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439184
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
XenoAmess edited a comment on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636423277
> I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in
XenoAmess edited a comment on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636423277
> I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439183=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439183
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
XenoAmess edited a comment on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636423277
> I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439182=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439182
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
XenoAmess opened a new pull request #533:
URL: https://github.com/apache/commons-lang/pull/533
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
coveralls edited a comment on pull request #80:
URL: https://github.com/apache/commons-imaging/pull/80#issuecomment-636399900
[](https://coveralls.io/builds/31138352)
Coverage remained the same at 76.304% when pulling
[
https://issues.apache.org/jira/browse/EMAIL-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JIN XU updated EMAIL-192:
-
Priority: Minor (was: Major)
> fix errors in javadoc, and add maven-javadoc-plugin to pom.
>
[
https://issues.apache.org/jira/browse/EMAIL-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JIN XU updated EMAIL-192:
-
Issue Type: Improvement (was: Bug)
> fix errors in javadoc, and add maven-javadoc-plugin to pom.
>
[
https://issues.apache.org/jira/browse/EMAIL-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JIN XU updated EMAIL-192:
-
Description: [https://github.com/apache/commons-email/pull/16] (was:
gwlucastrig opened a new pull request #80:
URL: https://github.com/apache/commons-imaging/pull/80
A few years ago, somebody changed the ApacheImagingSpeedAndMemoryTest.java
to close the output between test operations. So when the application tried to
report the results of the second
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439179=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439179
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439180=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439180
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
XenoAmess edited a comment on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636423277
> I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in
XenoAmess edited a comment on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636423277
> I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in
JIN XU created LANG-1547:
Summary: fix code smells; fix typos; performance refine(trying to)
Key: LANG-1547
URL: https://issues.apache.org/jira/browse/LANG-1547
Project: Commons Lang
Issue Type:
jochenw commented on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636399159
I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in one go?
kinow commented on a change in pull request #80:
URL: https://github.com/apache/commons-imaging/pull/80#discussion_r432897263
##
File path:
src/test/java/org/apache/commons/imaging/examples/ApacheImagingSpeedAndMemoryTest.java
##
@@ -280,7 +261,6 @@ private void
XenoAmess commented on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636423277
> I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in one go?
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439178=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439178
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
XenoAmess commented on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636385221
Hi.
I implemented a lastIndexOf in the last commit.
Maybe we should open another pr for it but...anyway.
if it is acceptable, then I will make the indexOf.
if
XenoAmess edited a comment on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636385221
Hi.
I implemented a lastIndexOf in the last commit.
Maybe we should open another pr for it but...anyway.
if it is acceptable, then I will make the indexOf
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439155=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439155
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
kinow commented on pull request #80:
URL: https://github.com/apache/commons-imaging/pull/80#issuecomment-636401052
Looks good to me @gwlucastrig ! I'm on leave next week, and as it's winter
over here, I might have time to prepare alpha2 release in the next days. Let me
know if you have
XenoAmess edited a comment on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636423277
> I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439181=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439181
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
91 matches
Mail list logo
