[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356122#comment-16356122
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363922111
 
 
   (6.0 actually because the UWP change was a breaking one - but looking for 
any feedback on CB-13834)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356067#comment-16356067
 ] 

ASF subversion and git services commented on CB-13829:
--

Commit 656ef073f417d59e32a123aa1fc84d3149378b52 in cordova-windows's branch 
refs/heads/master from Jan Piotrowski
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=656ef07 ]

CB-13829 Fix tests that were broken since CB-13237 (#246)

* CB-13829 Introduce variable `silent` to control output of commands

* fix first failing test for new default `appx`

* document/structure current state of tests (although some are still failing)

* extrat file and subdir+file expect code into function

* add build target override `8.1` (8.1-win + 8.1-phone)

* add test for new override

* remove duplicated getBuildTargets (and update its internal usage)

* more tests fixed

* silent tests with less output again

* default value for buildConfig that old nodes also understand

* fix

* default value that old nodes also understand

* remove duplicated test and re-number tests

* debug 6a problem with vs17 that is not reproducible locally

* move 6a down so more tests run

* Improve readability of logging

* fix


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356063#comment-16356063
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363906445
 
 
   > It looks like the following test cases were added: 2b, 2c, 2d, 2e, 3b, 3c, 
3d, 4b, 5b, 6b
   
   > It appears that the test coverage would be expanded to cover Windows 8.1, 
Windows Phone 8.1, Windows 10 and all possible CPU targets more completely.
   
   Before the default was Win8.1, now it is Win10. That meant that the Win8.1 
stuff that was automatically done before now has to be done explicitly. Also 
some of the architecture splits that were possible with default Win8.1 are not 
possible with Win10, so this had to be transformed as well.
   
   But you are right, it is possible that one of these combinations was not 
tested before. I have to be honest, I don't know well enough what actually was 
tested and so could also not split this into its own PR 藍 
   
   > I am still hoping we can have a release within the next few days to solve 
the Windows 8.1 crash problem.
   
   I can not do a release with failing tests which represent an actual problem, 
which CB-13834 seems to do. Either the test is broken or the actual 
implementation for VS2017 is broken - both won't allow me to cut a release.
   
   The only way to do a 5.1 with the patch you need would be to go back to 
before the UWP (and probably also test) changes, then cherry pick the one you 
need and do a release only for with that. But that is definitely not a viable 
option though because of the work involved, sorry. So we nee to get CB-13834 
fixed, then I can continue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356065#comment-16356065
 ] 

ASF subversion and git services commented on CB-13829:
--

Commit 656ef073f417d59e32a123aa1fc84d3149378b52 in cordova-windows's branch 
refs/heads/master from Jan Piotrowski
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=656ef07 ]

CB-13829 Fix tests that were broken since CB-13237 (#246)

* CB-13829 Introduce variable `silent` to control output of commands

* fix first failing test for new default `appx`

* document/structure current state of tests (although some are still failing)

* extrat file and subdir+file expect code into function

* add build target override `8.1` (8.1-win + 8.1-phone)

* add test for new override

* remove duplicated getBuildTargets (and update its internal usage)

* more tests fixed

* silent tests with less output again

* default value for buildConfig that old nodes also understand

* fix

* default value that old nodes also understand

* remove duplicated test and re-number tests

* debug 6a problem with vs17 that is not reproducible locally

* move 6a down so more tests run

* Improve readability of logging

* fix


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356064#comment-16356064
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio closed pull request #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356059#comment-16356059
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363906445
 
 
   > It looks like the following test cases were added: 2b, 2c, 2d, 2e, 3b, 3c, 
3d, 4b, 5b, 6b
   
   > It appears that the test coverage would be expanded to cover Windows 8.1, 
Windows Phone 8.1, Windows 10 and all possible CPU targets more completely.
   
   Before the default was Win8.1, now it is Win10. That meant that the Win8.1 
stuff that was automatically done before now has to be done explicitly. Also 
some of the architecture splits that were possible with default Win8.1 are not 
possible with Win10, so this had to be transformed as well.
   
   > I am still hoping we can have a release within the next few days to solve 
the Windows 8.1 crash problem.
   
   I can not do a release with failing tests which represent an actual problem, 
which CB-13834 seems to do. Either the test is broken or the actual 
implementation for VS2017 is broken - both won't allow me to cut a release.
   
   The only way to do a 5.1 with the patch you need would be to go back to 
before the UWP (and probably also test) changes, then cherry pick the one you 
need and do a release only for with that. But that is definitely not a viable 
option though because of the work involved, sorry. So we nee to get CB-13834 
fixed, then I can continue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356044#comment-16356044
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363903549
 
 
   > In my opinion these changes actually are only to fix the previously 
existing tests
   
   It is clear to me that a major goal is to pass most of the existing test 
cases. It is not clear to me whether or not the following items are other goals 
of this change:
   - fix actual script behavior
   - fix test cases that were incorrect
   
   > I didn't really extend the test coverage, did I?
   
   It looks like the following test cases were added: 2b, 2c, 2d, 2e, 3b, 3c, 
3d, 4b, 5b, 6b
   
   It appears that the test coverage would be expanded to cover Windows 8.1, 
Windows Phone 8.1, Windows 10 and all possible CPU targets more completely.
   
   > I did some smaller changes, and think I will "ignore" the other things for 
now.
   
   Fine for me, they are all minor anyway.
   
   > Do you think the "new"/rewritten tests are doing their job equivalent to 
what was there before?
   
   Yes, with more complete coverage of Windows 8.1/Windows Phone 8.1/Windows 10 
build and all CPU targets.
   
   > If you agree, I think I will just merge this in to see some progress here.
   
   Yes, please.
   
   In general I think this is a major step in the right direction. I would be 
happy to take a look at CB-13834, cannot promise anything though. I am still 
hoping we can have a release within the next few days to solve the Windows 8.1 
crash problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356014#comment-16356014
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363898512
 
 
   Thanks for the review @brodybits, very helpful.
   
   I did some smaller changes, and think I will "ignore" the other things for 
now.
   
   Do you think the "new"/rewritten tests are doing their job equivalent to 
what was there before? If you agree, I think I will just merge this in to see 
some progress here.
   
   If you have any ideas about 
https://issues.apache.org/jira/browse/CB-13834... I am pretty much out of ideas 
as I can't reproduce locally and don't know what is going on on AppVeyor :/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356015#comment-16356015
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363898512
 
 
   Thanks for the review @brodybits, very helpful.
   
   I did some smaller updates, and think I will "ignore" the other things for 
now.
   
   Do you think the "new"/rewritten tests are doing their job equivalent to 
what was there before? If you agree, I think I will just merge this in to see 
some progress here.
   
   If you have any ideas about 
https://issues.apache.org/jira/browse/CB-13834... I am pretty much out of ideas 
as I can't reproduce locally and don't know what is going on on AppVeyor :/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356008#comment-16356008
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363897813
 
 
   > I would favor making these changes in two parts (maybe split into 2 
different issues): one to fix the actual Windows build (with just enough test 
coverage to prove it working) and another to fix and extend the test coverage.
   
   In my opinion these changes actually are only to fix the previously existing 
tests, I just went through those that didn't work and replace them with the new 
equivalents for the new "UWP = standard" situation. I didn't really extend the 
test coverage, did I? If so, it was more an accident ;)
   
   > I do not really like the idea of moving the failing test function if we 
expect to to move it right back. I would favor just marking it as pending (use 
xit or pending function) and then fixing it in 
issues.apache.org/jira/browse/CB-13834.
   
   Yeah, in principle I agree - but I wanted to make sure the tests keep 
failing as that test is actually broken. So moving it down just enabled them 
all to run but it is still clearly visible that `master` is in a broken state.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356005#comment-16356005
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363897159
 
 
   Thanks @janpio for the nice work so far. I gave my review comments what I 
think are all minor (non-blocking), leaving it up to your best judgment. I am 
also looking forward to the fix for 
. I am really hoping to see a 
release to fix the crash on Windows 8.1 
(https://issues.apache.org/jira/browse/CB-13175 - fixed in PR #239).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356004#comment-16356004
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on a change in pull request #246: CB-13829 Fix tests that were 
broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166742215
 
 

 ##
 File path: template/cordova/lib/build.js
 ##
 @@ -411,92 +437,6 @@ function clearIntermediatesAndGetPackage (bundleTerms, 
config, hasAnyCpu) {
 return pckage.getPackageFileInfo(finalFile);
 }
 
-// Can update buildConfig in the following ways:
-//  * Sets targetProject property, the project to launch when complete
-function getBuildTargets (buildConfig) {
 
 Review comment:
   I think I chose this one to remove because the other one was closer to what 
will be kept in use. 
   With the export I technically agree, but this is quite a mess anyway and 
should probably be cleaned up in a future PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356002#comment-16356002
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on a change in pull request #246: CB-13829 Fix tests that were 
broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166741556
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
 expect(fs.existsSync(projectFolder)).toBe(true);
 });
 
-it('spec.2 should build project', function () {
-shell.exec(buildScriptPath, {silent: true});
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+// default
+
+it('spec.2 should build default (win10) project', function () {
+shell.exec(buildScriptPath + '', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.3 should build project for particular CPU', function () {
-shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: true}); /* 
eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
+// --appx
+
+it('spec.2a should build uap/win10 project', function () {
+shell.exec(buildScriptPath + ' --appx=uap', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.4 should build project for CPUs separated by whitespaces', 
function () {
-shell.exec(buildScriptPath + ' --archs=\"x64 x86 arm anycpu\"', 
{silent: true}); /* eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*AnyCPU.*\.appx.*/i); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*anycpu.*\.appx.*/i); }).length).toBe(1);
+it('spec.2b should build 8.1 win project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-win', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+});
+
+it('spec.2c should build 8.1 phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-phone', {silent: silent});
+_expectExist(/.*Phone.*\.appxupload/);
 });
 
-it('spec.5 should build project containing plugin with InProcessServer 
extension', function (done) {
+it('spec.2c should build 8.1 win + phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+_expectExist(/.*Phone.*\.appxupload/);
+});
+
+// --archs
+
+it('spec.3a should build project for particular CPU', function () {
+shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: silent}); /* 
eslint no-useless-escape : 0 */
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_x64_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_x64_debug.appx');
+});
+
+it('spec.3b should build project (8.1) for particular CPU', function () {
+shell.exec(buildScriptPath + ' --appx=8.1 --archs=\"x64\"', {silent: 
silent}); /* eslint no-useless-escape : 0 */
+_expectExist(/.*Phone.*x64.*\.appxupload/);
+_expectExist(/.*Windows.*x64.*\.appxupload/);
+});
+
+it('spec.3c should build project (8.1-win) for particular CPU', function 
() {
+shell.exec(buildScriptPath + ' --appx=8.1-win --archs=\"x64\"', 
{silent: silent}); /* eslint no-useless-escape : 0 */
+_expectExist(/.*Windows.*x64.*\.appxupload/);
+});
+
+

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356001#comment-16356001
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on a change in pull request #246: CB-13829 Fix tests that were 
broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166741352
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
 expect(fs.existsSync(projectFolder)).toBe(true);
 });
 
-it('spec.2 should build project', function () {
-shell.exec(buildScriptPath, {silent: true});
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+// default
+
+it('spec.2 should build default (win10) project', function () {
+shell.exec(buildScriptPath + '', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.3 should build project for particular CPU', function () {
-shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: true}); /* 
eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
+// --appx
+
+it('spec.2a should build uap/win10 project', function () {
+shell.exec(buildScriptPath + ' --appx=uap', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.4 should build project for CPUs separated by whitespaces', 
function () {
-shell.exec(buildScriptPath + ' --archs=\"x64 x86 arm anycpu\"', 
{silent: true}); /* eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*AnyCPU.*\.appx.*/i); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*anycpu.*\.appx.*/i); }).length).toBe(1);
+it('spec.2b should build 8.1 win project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-win', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+});
+
+it('spec.2c should build 8.1 phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-phone', {silent: silent});
+_expectExist(/.*Phone.*\.appxupload/);
 });
 
-it('spec.5 should build project containing plugin with InProcessServer 
extension', function (done) {
+it('spec.2c should build 8.1 win + phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+_expectExist(/.*Phone.*\.appxupload/);
+});
+
+// --archs
+
+it('spec.3a should build project for particular CPU', function () {
+shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: silent}); /* 
eslint no-useless-escape : 0 */
 
 Review comment:
   Re eslint: No idea, was there already.
   Re extract into function: Out of scope of this issue, but good idea for 
follow up PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: 

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355986#comment-16355986
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166733483
 
 

 ##
 File path: template/cordova/lib/build.js
 ##
 @@ -411,92 +437,6 @@ function clearIntermediatesAndGetPackage (bundleTerms, 
config, hasAnyCpu) {
 return pckage.getPackageFileInfo(finalFile);
 }
 
-// Can update buildConfig in the following ways:
-//  * Sets targetProject property, the project to launch when complete
-function getBuildTargets (buildConfig) {
 
 Review comment:
   +1 for cleaning up duplicated code
   
   I would favor keeping the existing function here, with any changes needed to 
get it working right, and remove unneeded (duplicated) code elsewhere.
   
   I would also favor keeping exports in one place, probably at the end of this 
module.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355989#comment-16355989
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166687318
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -34,15 +34,32 @@ describe('Cordova create and build', function () {
 var buildDirectory = path.join(__dirname, '../..');
 var appPackagesFolder = path.join(buildDirectory, projectFolder, 
'AppPackages');
 var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'build') + '"';
+var silent = false;
+
+function verifySubDirContainsFile (subDirName, fileName, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
-function verifySubDirContainsFile (subDirName, fileName) {
 var subDir = path.join(appPackagesFolder, subDirName);
 var packages = shell.ls(subDir);
-expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(1);
+expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(count);
+}
+
+function _expectExist (fileNamePattern, count) {
+count = typeof count !== 'undefined' ? count : 1;
+
+var packages = shell.ls(appPackagesFolder);
+expect(packages.filter(function (file) { return 
file.match(fileNamePattern); }).length).toBe(count);
+}
+
+function _expectSubdirAndFileExist (subDirName, fileName, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
 Review comment:
   ditto (ugly overwrite)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355990#comment-16355990
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166725050
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
 expect(fs.existsSync(projectFolder)).toBe(true);
 });
 
-it('spec.2 should build project', function () {
-shell.exec(buildScriptPath, {silent: true});
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+// default
+
+it('spec.2 should build default (win10) project', function () {
+shell.exec(buildScriptPath + '', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.3 should build project for particular CPU', function () {
-shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: true}); /* 
eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
+// --appx
+
+it('spec.2a should build uap/win10 project', function () {
+shell.exec(buildScriptPath + ' --appx=uap', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.4 should build project for CPUs separated by whitespaces', 
function () {
-shell.exec(buildScriptPath + ' --archs=\"x64 x86 arm anycpu\"', 
{silent: true}); /* eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*AnyCPU.*\.appx.*/i); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*anycpu.*\.appx.*/i); }).length).toBe(1);
+it('spec.2b should build 8.1 win project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-win', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+});
+
+it('spec.2c should build 8.1 phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-phone', {silent: silent});
+_expectExist(/.*Phone.*\.appxupload/);
 });
 
-it('spec.5 should build project containing plugin with InProcessServer 
extension', function (done) {
+it('spec.2c should build 8.1 win + phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+_expectExist(/.*Phone.*\.appxupload/);
+});
+
+// --archs
+
+it('spec.3a should build project for particular CPU', function () {
+shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: silent}); /* 
eslint no-useless-escape : 0 */
 
 Review comment:
   Why is `/* eslint no-useless-escape : 0 */` needed? Any other way to get 
around the problem?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects 

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355991#comment-16355991
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166723962
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
 expect(fs.existsSync(projectFolder)).toBe(true);
 });
 
-it('spec.2 should build project', function () {
-shell.exec(buildScriptPath, {silent: true});
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+// default
+
+it('spec.2 should build default (win10) project', function () {
 
 Review comment:
   Thanks, leaving it up to your best judgment:)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355988#comment-16355988
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166687770
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -34,15 +34,32 @@ describe('Cordova create and build', function () {
 var buildDirectory = path.join(__dirname, '../..');
 var appPackagesFolder = path.join(buildDirectory, projectFolder, 
'AppPackages');
 var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'build') + '"';
+var silent = false;
+
+function verifySubDirContainsFile (subDirName, fileName, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
-function verifySubDirContainsFile (subDirName, fileName) {
 var subDir = path.join(appPackagesFolder, subDirName);
 var packages = shell.ls(subDir);
-expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(1);
+expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(count);
+}
+
+function _expectExist (fileNamePattern, count) {
 
 Review comment:
   I would rename to something like _`verifyFileExists` (or maybe 
`checkFileExists`)_ (more consistent with existing functions, I think less ugly)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355987#comment-16355987
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166727337
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
 expect(fs.existsSync(projectFolder)).toBe(true);
 });
 
-it('spec.2 should build project', function () {
-shell.exec(buildScriptPath, {silent: true});
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+// default
+
+it('spec.2 should build default (win10) project', function () {
+shell.exec(buildScriptPath + '', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.3 should build project for particular CPU', function () {
-shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: true}); /* 
eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
+// --appx
+
+it('spec.2a should build uap/win10 project', function () {
+shell.exec(buildScriptPath + ' --appx=uap', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.4 should build project for CPUs separated by whitespaces', 
function () {
-shell.exec(buildScriptPath + ' --archs=\"x64 x86 arm anycpu\"', 
{silent: true}); /* eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*AnyCPU.*\.appx.*/i); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*anycpu.*\.appx.*/i); }).length).toBe(1);
+it('spec.2b should build 8.1 win project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-win', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+});
+
+it('spec.2c should build 8.1 phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-phone', {silent: silent});
+_expectExist(/.*Phone.*\.appxupload/);
 });
 
-it('spec.5 should build project containing plugin with InProcessServer 
extension', function (done) {
+it('spec.2c should build 8.1 win + phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+_expectExist(/.*Phone.*\.appxupload/);
+});
+
+// --archs
+
+it('spec.3a should build project for particular CPU', function () {
+shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: silent}); /* 
eslint no-useless-escape : 0 */
 
 Review comment:
   It would also be nice to extract the `shell.exec` call into a function, 
called like this for example:
   ```js
   tryBuild('--archs=\"x64\"');
   ```
   or to build with no options:
   ```js
   tryBuild();
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> 

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355992#comment-16355992
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166690071
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
 expect(fs.existsSync(projectFolder)).toBe(true);
 });
 
-it('spec.2 should build project', function () {
-shell.exec(buildScriptPath, {silent: true});
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+// default
+
+it('spec.2 should build default (win10) project', function () {
+shell.exec(buildScriptPath + '', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.3 should build project for particular CPU', function () {
-shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: true}); /* 
eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
+// --appx
+
+it('spec.2a should build uap/win10 project', function () {
+shell.exec(buildScriptPath + ' --appx=uap', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.4 should build project for CPUs separated by whitespaces', 
function () {
-shell.exec(buildScriptPath + ' --archs=\"x64 x86 arm anycpu\"', 
{silent: true}); /* eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*AnyCPU.*\.appx.*/i); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*anycpu.*\.appx.*/i); }).length).toBe(1);
+it('spec.2b should build 8.1 win project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-win', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+});
+
+it('spec.2c should build 8.1 phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-phone', {silent: silent});
+_expectExist(/.*Phone.*\.appxupload/);
 });
 
-it('spec.5 should build project containing plugin with InProcessServer 
extension', function (done) {
+it('spec.2c should build 8.1 win + phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+_expectExist(/.*Phone.*\.appxupload/);
+});
+
+// --archs
+
+it('spec.3a should build project for particular CPU', function () {
+shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: silent}); /* 
eslint no-useless-escape : 0 */
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_x64_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_x64_debug.appx');
+});
+
+it('spec.3b should build project (8.1) for particular CPU', function () {
+shell.exec(buildScriptPath + ' --appx=8.1 --archs=\"x64\"', {silent: 
silent}); /* eslint no-useless-escape : 0 */
+_expectExist(/.*Phone.*x64.*\.appxupload/);
+_expectExist(/.*Windows.*x64.*\.appxupload/);
+});
+
+it('spec.3c should build project (8.1-win) for particular CPU', function 
() {
+shell.exec(buildScriptPath + ' --appx=8.1-win --archs=\"x64\"', 
{silent: silent}); /* eslint no-useless-escape : 0 */
+_expectExist(/.*Windows.*x64.*\.appxupload/);
+});
+
+

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355985#comment-16355985
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166689447
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -34,15 +34,32 @@ describe('Cordova create and build', function () {
 var buildDirectory = path.join(__dirname, '../..');
 var appPackagesFolder = path.join(buildDirectory, projectFolder, 
'AppPackages');
 var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'build') + '"';
+var silent = false;
+
+function verifySubDirContainsFile (subDirName, fileName, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
-function verifySubDirContainsFile (subDirName, fileName) {
 var subDir = path.join(appPackagesFolder, subDirName);
 var packages = shell.ls(subDir);
-expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(1);
+expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(count);
+}
+
+function _expectExist (fileNamePattern, count) {
+count = typeof count !== 'undefined' ? count : 1;
+
+var packages = shell.ls(appPackagesFolder);
+expect(packages.filter(function (file) { return 
file.match(fileNamePattern); }).length).toBe(count);
+}
+
+function _expectSubdirAndFileExist (subDirName, fileName, count) {
 
 Review comment:
   I would rename to something like `verifySubdirExistsAndContansFile` (or 
maybe `checkSubdirExistsAndContainsFile` (I think more consistenst and less 
ugly)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355942#comment-16355942
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on a change in pull request #246: CB-13829 Fix tests that were 
broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166729548
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -34,15 +34,32 @@ describe('Cordova create and build', function () {
 var buildDirectory = path.join(__dirname, '../..');
 var appPackagesFolder = path.join(buildDirectory, projectFolder, 
'AppPackages');
 var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'build') + '"';
+var silent = false;
+
+function verifySubDirContainsFile (subDirName, fileName, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
 Review comment:
   that line is actually just an ugly "hack" to get default params for older 
node versions, otherwise one could just `count = 1` in the param list of the 
functions. yay JavaScript.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355743#comment-16355743
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166687229
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -34,15 +34,32 @@ describe('Cordova create and build', function () {
 var buildDirectory = path.join(__dirname, '../..');
 var appPackagesFolder = path.join(buildDirectory, projectFolder, 
'AppPackages');
 var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'build') + '"';
+var silent = false;
+
+function verifySubDirContainsFile (subDirName, fileName, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
-function verifySubDirContainsFile (subDirName, fileName) {
 var subDir = path.join(appPackagesFolder, subDirName);
 var packages = shell.ls(subDir);
-expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(1);
+expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(count);
+}
+
+function _expectExist (fileNamePattern, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
 Review comment:
   ditto (ugly overwrite)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355731#comment-16355731
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166687229
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -34,15 +34,32 @@ describe('Cordova create and build', function () {
 var buildDirectory = path.join(__dirname, '../..');
 var appPackagesFolder = path.join(buildDirectory, projectFolder, 
'AppPackages');
 var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'build') + '"';
+var silent = false;
+
+function verifySubDirContainsFile (subDirName, fileName, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
-function verifySubDirContainsFile (subDirName, fileName) {
 var subDir = path.join(appPackagesFolder, subDirName);
 var packages = shell.ls(subDir);
-expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(1);
+expect(packages.filter(function (file) { return file.match(fileName); 
}).length).toBe(count);
+}
+
+function _expectExist (fileNamePattern, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
 Review comment:
   ditto


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355730#comment-16355730
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166687194
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -34,15 +34,32 @@ describe('Cordova create and build', function () {
 var buildDirectory = path.join(__dirname, '../..');
 var appPackagesFolder = path.join(buildDirectory, projectFolder, 
'AppPackages');
 var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'build') + '"';
+var silent = false;
+
+function verifySubDirContainsFile (subDirName, fileName, count) {
+count = typeof count !== 'undefined' ? count : 1;
 
 Review comment:
   ugly overwrite (I think)
   
   I would propose something like this:
   
   ```js
   var expectedCount = typeof count !== 'undefined' ? count : 1;
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355727#comment-16355727
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on a change in pull request #246: CB-13829 Fix tests that were 
broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166686826
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
 expect(fs.existsSync(projectFolder)).toBe(true);
 });
 
-it('spec.2 should build project', function () {
-shell.exec(buildScriptPath, {silent: true});
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+// default
+
+it('spec.2 should build default (win10) project', function () {
 
 Review comment:
   doesn't make a difference really, but I think all the others start with `a` 
as well, so might as well do this here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355725#comment-16355725
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166685988
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
 expect(fs.existsSync(projectFolder)).toBe(true);
 });
 
-it('spec.2 should build project', function () {
-shell.exec(buildScriptPath, {silent: true});
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+// default
+
+it('spec.2 should build default (win10) project', function () {
+shell.exec(buildScriptPath + '', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.3 should build project for particular CPU', function () {
-shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: true}); /* 
eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
+// --appx
+
+it('spec.2a should build uap/win10 project', function () {
+shell.exec(buildScriptPath + ' --appx=uap', {silent: silent});
+
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.4 should build project for CPUs separated by whitespaces', 
function () {
-shell.exec(buildScriptPath + ' --archs=\"x64 x86 arm anycpu\"', 
{silent: true}); /* eslint no-useless-escape : 0 */
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*AnyCPU.*\.appx.*/i); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*x86.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*arm.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*anycpu.*\.appx.*/i); }).length).toBe(1);
+it('spec.2b should build 8.1 win project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-win', {silent: silent});
+_expectExist(/.*Windows.*\.appxupload/);
+});
+
+it('spec.2c should build 8.1 phone project', function () {
+shell.exec(buildScriptPath + ' --appx=8.1-phone', {silent: silent});
+_expectExist(/.*Phone.*\.appxupload/);
 });
 
-it('spec.5 should build project containing plugin with InProcessServer 
extension', function (done) {
+it('spec.2c should build 8.1 win + phone project', function () {
 
 Review comment:
   spec.2c repeated


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test 

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355724#comment-16355724
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on a change in pull request #246: CB-13829 Fix tests that 
were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166685892
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
 expect(fs.existsSync(projectFolder)).toBe(true);
 });
 
-it('spec.2 should build project', function () {
-shell.exec(buildScriptPath, {silent: true});
-var packages = shell.ls(appPackagesFolder);
-expect(packages.filter(function (file) { return 
file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-expect(packages.filter(function (file) { return 
file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+// default
+
+it('spec.2 should build default (win10) project', function () {
 
 Review comment:
   I wonder if this should already be spec.2a?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355632#comment-16355632
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363815393
 
 
   Done (although there are no relevant changes that would require this in that 
last commit).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355631#comment-16355631
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363815393
 
 
   Done (although there are no relevant changes that would require this in that 
last commit).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355630#comment-16355630
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363815279
 
 
   Done (although there are no relevant changes that would require this in that 
last commit).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355628#comment-16355628
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363810122
 
 
   > All but one are passing, but this will be covered in
   > https://issues.apache.org/jira/browse/CB-13834 - this PR is about the
   > changes to the tests to match the actual implementation.
   
   Thanks I will review later today. It would be ideal if you can rebase on
   the latest changes on master.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355613#comment-16355613
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363810122
 
 
   All but one are passing, but this will be covered in
   https://issues.apache.org/jira/browse/CB-13834 - this PR is about the
   changes to the tests to match the actual implementation.
   
   
   Thanks I will review later today. It would be ideal if you can rebase on
   the latest changes on master.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355541#comment-16355541
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363791177
 
 
   Look below - there is a "Details" link next to the checks that go to the 
actual test runs. All but one are passing, but this will be covered in 
https://issues.apache.org/jira/browse/CB-13834 - this PR is about the changes 
to the tests to match the actual implementation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355529#comment-16355529
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363787290
 
 
   Thanks @janpio. Can you give me an idea of what portion of tests are now 
passing vs failing?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355488#comment-16355488
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363780207
 
 
   
https://github.com/apache/cordova-windows/commit/dd91933d7030f6f0bb207a676968c4fdad9e3691
 has nothing to do with this (and is not mentioned anywhere here in this PR, is 
it?). 
   
   [This was just a commit of the release process that is documented here: 
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#update-and-pin-dependencies
 It had to be reverted as the release process was canceled as I discovered the 
failing tests and breaking changes (which requires a 6.0 release instead of a 
5.1 I was working on).]
   
   The culprit for the failing tests is in 
https://issues.apache.org/jira/browse/CB-13237 / 
https://github.com/apache/cordova-windows/commit/c1dfc77ddf866b4872330eb2b8874ede05daddcd
 but wasn't noticed as earlier `jasmine-node` was replaced by `jasmine` which 
doesn't have the same command line params, which caused the tests to fail 
silently and not to be run at all via 
https://github.com/apache/cordova-windows/commit/1c6d245fbb10ab71c77eed6a73989827042422f5.
 
   
   So this PR here effectively updates the tests to work with the new situation 
created with CB-13237.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355484#comment-16355484
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363780207
 
 
   
https://github.com/apache/cordova-windows/commit/dd91933d7030f6f0bb207a676968c4fdad9e3691
 has nothing to do with this, it was just a commit of the release process that 
is documented here: 
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#update-and-pin-dependencies
 It had to be reverted as the release process was canceled as I discovered the 
failing tests and breaking changes (which requires a 6.0 release instead of a 
5.1 I was working on).
   
   The culprit for the failing tests is in 
https://issues.apache.org/jira/browse/CB-13237 / 
https://github.com/apache/cordova-windows/commit/c1dfc77ddf866b4872330eb2b8874ede05daddcd
 but wasn't noticed as earlier `jasmine-node` was replaced by `jasmine` which 
doesn't have the same command line params, which caused the tests to fail 
silently and not to be run at all via 
https://github.com/apache/cordova-windows/commit/1c6d245fbb10ab71c77eed6a73989827042422f5
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355487#comment-16355487
 ] 

ASF GitHub Bot commented on CB-13829:
-

janpio commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363780207
 
 
   
https://github.com/apache/cordova-windows/commit/dd91933d7030f6f0bb207a676968c4fdad9e3691
 has nothing to do with this (and is not mentioned anywhere here in this PR, is 
it?). 
   
   [This was just a commit of the release process that is documented here: 
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#update-and-pin-dependencies
 It had to be reverted as the release process was canceled as I discovered the 
failing tests and breaking changes (which requires a 6.0 release instead of a 
5.1 I was working on).]
   
   The culprit for the failing tests is in 
https://issues.apache.org/jira/browse/CB-13237 / 
https://github.com/apache/cordova-windows/commit/c1dfc77ddf866b4872330eb2b8874ede05daddcd
 but wasn't noticed as earlier `jasmine-node` was replaced by `jasmine` which 
doesn't have the same command line params, which caused the tests to fail 
silently and not to be run at all via 
https://github.com/apache/cordova-windows/commit/1c6d245fbb10ab71c77eed6a73989827042422f5
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355453#comment-16355453
 ] 

ASF GitHub Bot commented on CB-13829:
-

brodybits commented on issue #246: CB-13829 Fix tests that were broken since 
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363773190
 
 
   @janpio can you give any explanation of how reverting dd91933 ("CB-13799 
Updated checked-in node_modules") in 18eb64389700667608c0186da1e5112afc67e23e 
could trigger the test failures?
   
   Also can you also give me an idea what dd91933 was supposed to do in the 
first place?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237

[Jan Piotrowski (Sujan) (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340283#comment-16340283
 ] 

Jan Piotrowski (Sujan) commented on CB-13829:
-

PR is ready to be reviewed.

> Fix tests that were broken since CB-13237
> -
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 6.0.0
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jan Piotrowski (Sujan)
>Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built 
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in 
> the process (which wasn't noticed because the running of tests was broken 
> even before by the switch from jasmine-node to jasmine and so CI didn'T 
> report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org