[jira] [Updated] (FLINK-8318) Conflict jackson library with ElasticSearch connector

2018-01-05 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-8318: Fix Version/s: 1.4.1 1.5.0 > Conflict jackson library with ElasticSearch

[jira] [Commented] (FLINK-8363) Build Hadoop 2.9.0 convenience binaries

2018-01-05 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313309#comment-16313309 ] Aljoscha Krettek commented on FLINK-8363: - Probably everything except the filesystem connector and

[jira] [Commented] (FLINK-8346) add S3 signature v4 workaround to docs

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313308#comment-16313308 ] ASF GitHub Bot commented on FLINK-8346: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5231: [FLINK-8346][docs] add v4 signature workaround for manual...

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5231 Very nice, thanks! Merging this... ---

[jira] [Commented] (FLINK-8364) ListState should return empty iterator rather than null when it has no value

2018-01-05 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313298#comment-16313298 ] Aljoscha Krettek commented on FLINK-8364: - +1 to what [~fhueske] said! > ListState should return

[GitHub] flink pull request #5205: [FLINK-8037] Fix integer multiplication or shift i...

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5205#discussion_r159899525 --- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractID.java --- @@ -186,7 +186,7 @@ private static long byteArrayToLong(byte[] ba, int

[jira] [Commented] (FLINK-8037) Missing cast in integer arithmetic in TransactionalIdsGenerator#generateIdsToAbort

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313297#comment-16313297 ] ASF GitHub Bot commented on FLINK-8037: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-6214) WindowAssigners do not allow negative offsets

2018-01-05 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313293#comment-16313293 ] Aljoscha Krettek commented on FLINK-6214: - Nope, no reason except no-one has gotten around to it

[jira] [Commented] (FLINK-8361) Remove create_release_files.sh

2018-01-05 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313291#comment-16313291 ] Aljoscha Krettek commented on FLINK-8361: - Ah yes, definitely remove. I left it in when I added

[GitHub] flink issue #5204: [hotfix] Fix typo in ReplicatingInputFormat/DualInputOper...

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5204 The code looks good, thanks! Merging this... For the next contributions, it would be great if you could give the Pull Request a proper description, as the text of the pull request

[jira] [Commented] (FLINK-8260) Document API of Kafka 0.11 Producer

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313257#comment-16313257 ] ASF GitHub Bot commented on FLINK-8260: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5191: Release 1.4

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5191 This looks like an accidentally opened pull request. Can you please close it? ---

[GitHub] flink issue #5179: [FLINK-8260/8287] [kafka] Bunch of improvements to Kafka ...

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5179 These look like good changes. +1 to merge ---

[jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313206#comment-16313206 ] ASF GitHub Bot commented on FLINK-8203: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313212#comment-16313212 ] ASF GitHub Bot commented on FLINK-8203: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313211#comment-16313211 ] ASF GitHub Bot commented on FLINK-8203: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313210#comment-16313210 ] ASF GitHub Bot commented on FLINK-8203: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313213#comment-16313213 ] ASF GitHub Bot commented on FLINK-8203: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313208#comment-16313208 ] ASF GitHub Bot commented on FLINK-8203: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313209#comment-16313209 ] ASF GitHub Bot commented on FLINK-8203: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313207#comment-16313207 ] ASF GitHub Bot commented on FLINK-8203: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159887168 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -450,37 +450,54 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159878618 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/StreamTableEnvironmentValidationTest.scala --- @@ -138,4 +145,25 @@

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159885776 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -450,37 +450,54 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159876208 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -446,52 +443,60 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159889511 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -450,37 +450,54 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159878296 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala --- @@ -532,35 +527,27 @@ class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159880719 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -492,11 +509,16 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159877092 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -855,42 +852,26 @@ abstract class

[jira] [Commented] (FLINK-8340) Do not pass Configuration and configuration directory to CustomCommandLine methods

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313168#comment-16313168 ] ASF GitHub Bot commented on FLINK-8340: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #4594: [FLINK-7517][network] let NettyBufferPool extend P...

2018-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4594 ---

[jira] [Commented] (FLINK-7517) let NettyBufferPool extend PooledByteBufAllocator

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313192#comment-16313192 ] ASF GitHub Bot commented on FLINK-7517: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313191#comment-16313191 ] ASF GitHub Bot commented on FLINK-7499: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7427) integrate PartitionRequestProtocol into NettyProtocol

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313190#comment-16313190 ] ASF GitHub Bot commented on FLINK-7427: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4528: [FLINK-7427][network] integrate PartitionRequestPr...

2018-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4528 ---

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2018-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4581 ---

[GitHub] flink pull request #5226: [FLINK-8340] [flip6] Remove passing of Configurati...

2018-01-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5226#discussion_r159874411 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -183,93 +204,43 @@ public FlinkYarnSessionCli(String shortPrefix,

[GitHub] flink pull request #5226: [FLINK-8340] [flip6] Remove passing of Configurati...

2018-01-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5226#discussion_r159883795 --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendPackageProgramTest.java --- @@ -60,220 +59,178 @@ public static void init() {

[GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ...

2018-01-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5225#discussion_r159885568 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/AbstractCustomCommandLine.java --- @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313170#comment-16313170 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-8339) Let CustomCommandLine return a ClusterDescriptor

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313183#comment-16313183 ] ASF GitHub Bot commented on FLINK-8339: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink issue #5178: [hotfix] Fix typo in TestableKinesisDataFetcher

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5178 Merging this... ---

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159884153 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/MultiStreamStateHandle.java --- @@ -1,104 +0,0 @@ -/* --- End diff --

[jira] [Commented] (FLINK-8340) Do not pass Configuration and configuration directory to CustomCommandLine methods

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313167#comment-16313167 ] ASF GitHub Bot commented on FLINK-8340: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5226: [FLINK-8340] [flip6] Remove passing of Configurati...

2018-01-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5226#discussion_r159883585 --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendPackageProgramTest.java --- @@ -60,220 +59,178 @@ public static void init() {

[jira] [Commented] (FLINK-8340) Do not pass Configuration and configuration directory to CustomCommandLine methods

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313166#comment-16313166 ] ASF GitHub Bot commented on FLINK-8340: --- Github user GJL commented on a diff in the pull request:

[jira] [Updated] (FLINK-8376) Remove potentially unnecessary synchronization in SpillableSubpartition

2018-01-05 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8376: -- Description: After https://issues.apache.org/jira/browse/FLINK-8375 {{SpillableSubpartition}}

[jira] [Updated] (FLINK-8375) Remove unnecessary synchronization in ResultPartition

2018-01-05 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8375: -- Description: {{PipelinedSubpartition}} doesn't need this extra synchronization in

[jira] [Created] (FLINK-8376) Remove potentially unnecessary synchronization in SpillableSubpartition

2018-01-05 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-8376: - Summary: Remove potentially unnecessary synchronization in SpillableSubpartition Key: FLINK-8376 URL: https://issues.apache.org/jira/browse/FLINK-8376 Project:

[jira] [Updated] (FLINK-8375) Remove unnecessary synchronization in ResultPartition

2018-01-05 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8375: -- Description: {{PipelinedSubpartition}} doesn't need this extra synchronization in

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313164#comment-16313164 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159883287 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[jira] [Created] (FLINK-8375) Remove unnecessary synchronization in ResultPartition

2018-01-05 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-8375: - Summary: Remove unnecessary synchronization in ResultPartition Key: FLINK-8375 URL: https://issues.apache.org/jira/browse/FLINK-8375 Project: Flink Issue

[GitHub] flink pull request #5246: Various minor improvements to FileSystem and relat...

2018-01-05 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/5246 Various minor improvements to FileSystem and related classes ## What is the purpose of the change Many small improvements, like - harmonization of of `FileSystem.mkdirs()`

[jira] [Commented] (FLINK-8359) Update copyright date in NOTICE

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313158#comment-16313158 ] ASF GitHub Bot commented on FLINK-8359: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5238: [FLINK-8359][docs] Update copyright date in NOTICE

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5238 Good fix, merging this... ---

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159866220 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/BarrierBufferTest.java --- @@ -1483,11 +1482,6 @@ long

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313144#comment-16313144 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313147#comment-16313147 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313142#comment-16313142 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159865703 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -669,31 +676,14 @@ else if (current ==

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313154#comment-16313154 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313141#comment-16313141 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159865414 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/JobManagerTaskRestore.java --- @@ -20,15 +20,18 @@ import

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313145#comment-16313145 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313153#comment-16313153 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313148#comment-16313148 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159880527 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java --- @@ -147,7 +147,7 @@ public void close() throws

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313157#comment-16313157 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313143#comment-16313143 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159861671 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBAsyncSnapshotTest.java --- @@ -132,21

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313140#comment-16313140 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159877503 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamTaskStateManager.java --- @@ -0,0 +1,48 @@ +/* + *

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159860788 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -1041,7

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313155#comment-16313155 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159865180 --- Diff: flink-core/src/main/java/org/apache/flink/util/CloseableIterator.java --- @@ -18,11 +18,38 @@ package org.apache.flink.util;

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159877880 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointListener.java --- @@ -18,11 +18,14 @@ package

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159865241 --- Diff: flink-core/src/main/java/org/apache/flink/util/CloseableIterable.java --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159866648 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -669,31 +676,14 @@ else if (current ==

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159863616 --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java --- @@ -375,11 +376,13 @@ public void

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159840075 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -831,11

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313146#comment-16313146 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159880011 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStreamFactory.java --- @@ -43,9 +44,9 @@ CheckpointStateOutputStream

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159881015 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/MultiStreamStateHandle.java --- @@ -1,104 +0,0 @@ -/* --- End diff --

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313150#comment-16313150 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313156#comment-16313156 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313149#comment-16313149 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313151#comment-16313151 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313152#comment-16313152 ] ASF GitHub Bot commented on FLINK-8360: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159836477 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -145,8 +145,8 @@ private volatile

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159840618 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -831,11

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r159834127 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -145,8 +145,8 @@ private volatile

[GitHub] flink issue #5242: [hotfix] Fix typos

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5242 Wow, this is pretty good! Thanks a lot! Addressing Fabian's comment and merging this. Want that merged very soon to avoid future merge conflicts... ---

[jira] [Commented] (FLINK-8362) Shade Elasticsearch dependencies away

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313125#comment-16313125 ] ASF GitHub Bot commented on FLINK-8362: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5243: [FLINK-8362][elasticsearch] shade all dependencies

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5243 I vaguely recall that there was a reason why we did not shade the Elasticsearch connectors initially. Maybe a license issue. @zentol and @tzulitai can you chime in here? If we want to

[jira] [Commented] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313116#comment-16313116 ] ASF GitHub Bot commented on FLINK-8322: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5237: [hotfix][doc] fix typo in filesystems.md

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5237 Thanks, looks good, merging this... ---

[GitHub] flink issue #5236: [FLINK-8322] support getting number of existing timers in...

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5236 I am with Aljoscha here - the cost of making this information available in the general case seems pretty high. What is the use case that needs that feature - can that be implemented in a

[jira] [Commented] (FLINK-6206) As an Engineer, I want task state transition log to be warn/error for FAILURE scenarios

2018-01-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313109#comment-16313109 ] ASF GitHub Bot commented on FLINK-6206: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5235: [FLINK-6206] [runtime] Changed log level to WARN for task...

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5235 Can you elaborate why you want to change this? This seems like a perfect regular information, not a case for a warning. Warnings indicate that something is potentially not okay. ---

<    1   2   3   >