[GitHub] [flink] flinkbot edited a comment on issue #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions URL: https://github.com/apache/flink/pull/9250#issuecomment-515772917 ## CI report: * 4e15048a256b338df18ad8f9d89e0a576ae06a27 : FAILURE [Build](https://travis-ci.com/flink-ci

[GitHub] [flink] zentol opened a new pull request #9317: [FLINK-13530][qs][tests] Increase port range size

2019-08-01 Thread GitBox
zentol opened a new pull request #9317: [FLINK-13530][qs][tests] Increase port range size URL: https://github.com/apache/flink/pull/9317 Increase the size of the port range used in `AbstractServerTest#testPortRangeSuccess` by 4000%, which should make it quite likely that we find an open p

[GitHub] [flink] ifndef-SleePy commented on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect…

2019-08-01 Thread GitBox
ifndef-SleePy commented on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect… URL: https://github.com/apache/flink/pull/9221#issuecomment-517219932 @pnowojski , done This is an automated messa

[GitHub] [flink] flinkbot commented on issue #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-01 Thread GitBox
flinkbot commented on issue #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#issuecomment-517219779 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[GitHub] [flink] flinkbot commented on issue #9315: [FLINK-13374][scala][build] Set -Xss2m when compiling scala

2019-08-01 Thread GitBox
flinkbot commented on issue #9315: [FLINK-13374][scala][build] Set -Xss2m when compiling scala URL: https://github.com/apache/flink/pull/9315#issuecomment-517219249 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pul

[jira] [Updated] (FLINK-13529) Verify and correct agg function's semantic for Blink planner

2019-08-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13529: --- Labels: pull-request-available (was: ) > Verify and correct agg function's semantic for Bli

[GitHub] [flink] zjuwangg commented on issue #9310: [FLINK-13190]add test to verify partition pruning for HiveTableSource

2019-08-01 Thread GitBox
zjuwangg commented on issue #9310: [FLINK-13190]add test to verify partition pruning for HiveTableSource URL: https://github.com/apache/flink/pull/9310#issuecomment-517219228 Hi @lirui-apache @xuefuz ~ I studied the way of the planner `org.apache.flink.table.planner.plan.rules.logical.P

[GitHub] [flink] beyond1920 opened a new pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-01 Thread GitBox
beyond1920 opened a new pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316 ## What is the purpose of the change Verify and correct agg function's semantic for Blink planner

[jira] [Updated] (FLINK-13374) flink-table-planner-blink compile failed for scala-2.12 on travis

2019-08-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13374: --- Labels: pull-request-available (was: ) > flink-table-planner-blink compile failed for scala

[GitHub] [flink] zentol opened a new pull request #9315: [FLINK-13374][scala][build] Set -Xss2m when compiling scala

2019-08-01 Thread GitBox
zentol opened a new pull request #9315: [FLINK-13374][scala][build] Set -Xss2m when compiling scala URL: https://github.com/apache/flink/pull/9315 This PR bumps the ThreadStackSize to 2MB when compiling scala. This appears to be the common approach for handling StackOverflowErrors by the s

[GitHub] [flink] pnowojski commented on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect…

2019-08-01 Thread GitBox
pnowojski commented on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect… URL: https://github.com/apache/flink/pull/9221#issuecomment-517218187 @ifndef-SleePy ok, I will merge this PR as those failures are almost definitely unrelated and across couple of th

[GitHub] [flink] flinkbot edited a comment on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner.

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner. URL: https://github.com/apache/flink/pull/9314#issuecomment-517209689 ## CI report: * 7c2920eb071c70714b53d12355019ae97c0b080b : PENDING [Build](https://travis-ci.com/fli

[GitHub] [flink] flinkbot edited a comment on issue #9253: [Flink-12164][tests] Harden JobMasterTest.testJobFailureWhenTaskExecutorHeartbeatTimeout

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9253: [Flink-12164][tests] Harden JobMasterTest.testJobFailureWhenTaskExecutorHeartbeatTimeout URL: https://github.com/apache/flink/pull/9253#issuecomment-515843418 ## CI report: * ee881273027480bd8901c2a06cc4f082f1c0604c : FAILURE [Build](https:/

[GitHub] [flink] dianfu commented on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner.

2019-08-01 Thread GitBox
dianfu commented on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner. URL: https://github.com/apache/flink/pull/9314#issuecomment-517216168 Thanks a lot for the update. +1 from my side. This

[GitHub] [flink] WeiZhong94 commented on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner.

2019-08-01 Thread GitBox
WeiZhong94 commented on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner. URL: https://github.com/apache/flink/pull/9314#issuecomment-517215671 @dianfu Thanks for your review! I have fixed these spelling errors in the latest commit. --

[GitHub] [flink] tillrohrmann commented on issue #9288: [FLINK-13421] [runtime] Do not allocate slots in a MultiTaskSlot when it’s releasing children

2019-08-01 Thread GitBox
tillrohrmann commented on issue #9288: [FLINK-13421] [runtime] Do not allocate slots in a MultiTaskSlot when it’s releasing children URL: https://github.com/apache/flink/pull/9288#issuecomment-517214497 Thanks a lot @zhuzhurk. I'll check out the test case and try to reproduce the problem l

[jira] [Commented] (FLINK-13510) Show fail attemp for subtask in timelime

2019-08-01 Thread lining (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897932#comment-16897932 ] lining commented on FLINK-13510: [~till.rohrmann] could you assign it to me? > Show fai

[GitHub] [flink] dianfu commented on a change in pull request #9314: [FLINK-12704][python] Enable the configuration of using blink planner.

2019-08-01 Thread GitBox
dianfu commented on a change in pull request #9314: [FLINK-12704][python] Enable the configuration of using blink planner. URL: https://github.com/apache/flink/pull/9314#discussion_r309613599 ## File path: flink-python/pyflink/table/environment_settings.py ## @@ -0,0 +1,19

[GitHub] [flink] dianfu commented on a change in pull request #9314: [FLINK-12704][python] Enable the configuration of using blink planner.

2019-08-01 Thread GitBox
dianfu commented on a change in pull request #9314: [FLINK-12704][python] Enable the configuration of using blink planner. URL: https://github.com/apache/flink/pull/9314#discussion_r309612718 ## File path: flink-python/pyflink/table/environment_settings.py ## @@ -0,0 +1,19

[jira] [Updated] (FLINK-13529) Verify and correct agg function's semantic for Blink planner

2019-08-01 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-13529: Issue Type: Sub-task (was: Task) Parent: FLINK-13522 > Verify and correct agg function's semantic

[GitHub] [flink] flinkbot edited a comment on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner.

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner. URL: https://github.com/apache/flink/pull/9314#issuecomment-517209689 ## CI report: * 7c2920eb071c70714b53d12355019ae97c0b080b : PENDING [Build](https://travis-ci.com/fli

[jira] [Assigned] (FLINK-13529) Verify and correct agg function's semantic for Blink planner

2019-08-01 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13529: --- Assignee: Jing Zhang > Verify and correct agg function's semantic for Blink planner > -

[jira] [Created] (FLINK-13530) AbstractServerTest failed on Travis

2019-08-01 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-13530: Summary: AbstractServerTest failed on Travis Key: FLINK-13530 URL: https://issues.apache.org/jira/browse/FLINK-13530 Project: Flink Issue Type: Bug

[GitHub] [flink] twalthr commented on a change in pull request #9312: [FLINK-13436][end-to-end-tests] Add TPC-H queries as E2E tests

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9312: [FLINK-13436][end-to-end-tests] Add TPC-H queries as E2E tests URL: https://github.com/apache/flink/pull/9312#discussion_r309608185 ## File path: flink-end-to-end-tests/run-nightly-tests.sh ## @@ -152,6 +152,8 @@ run_tes

[GitHub] [flink] twalthr commented on a change in pull request #9312: [FLINK-13436][end-to-end-tests] Add TPC-H queries as E2E tests

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9312: [FLINK-13436][end-to-end-tests] Add TPC-H queries as E2E tests URL: https://github.com/apache/flink/pull/9312#discussion_r309605512 ## File path: flink-end-to-end-tests/flink-tpch-test/src/main/java/org/apache/flink/table/tpch/Tp

[GitHub] [flink] flinkbot edited a comment on issue #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese URL: https://github.com/apache/flink/pull/7751#issuecomment-517135258 ## CI report: * 82afc481b4eb377bbcec2b9bac53d013a1ba1666 : SUCCESS [Build](https://travis-ci.c

[GitHub] [flink] flinkbot commented on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner.

2019-08-01 Thread GitBox
flinkbot commented on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner. URL: https://github.com/apache/flink/pull/9314#issuecomment-517209689 ## CI report: * 7c2920eb071c70714b53d12355019ae97c0b080b : PENDING [Build](https://travis-ci.com/flink-ci/f

[GitHub] [flink] flinkbot edited a comment on issue #9304: [FLINK-13434][e2e] Add stop-with-savepoint end-to-end tests.

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9304: [FLINK-13434][e2e] Add stop-with-savepoint end-to-end tests. URL: https://github.com/apache/flink/pull/9304#issuecomment-516863417 ## CI report: * feb7953f619a2b134318d114a113fa4d7a2d6572 : SUCCESS [Build](https://travis-ci.com/flink-ci/flin

[GitHub] [flink] flinkbot edited a comment on issue #9236: [FLINK-13283][FLINK-13490][jdbc] Fix JDBC connectors with DataTypes.DATE/TIME/TIMESTAMP support and null checking

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9236: [FLINK-13283][FLINK-13490][jdbc] Fix JDBC connectors with DataTypes.DATE/TIME/TIMESTAMP support and null checking URL: https://github.com/apache/flink/pull/9236#issuecomment-515390325 ## CI report: * 1135cc72f00606c7a230714838c938068887ce23 :

[GitHub] [flink] flinkbot edited a comment on issue #9264: [FLINK-13192][hive] Add tests for different Hive table formats

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9264: [FLINK-13192][hive] Add tests for different Hive table formats URL: https://github.com/apache/flink/pull/9264#issuecomment-515988891 ## CI report: * 152412f354ed83326a23edbf5f47b138fdd8e9e2 : FAILURE [Build](https://travis-ci.com/flink-ci/fl

[GitHub] [flink] zentol commented on a change in pull request #9192: [FLINK-12749] [docs] [examples] Initial Version of Flink Cluster Playground

2019-08-01 Thread GitBox
zentol commented on a change in pull request #9192: [FLINK-12749] [docs] [examples] Initial Version of Flink Cluster Playground URL: https://github.com/apache/flink/pull/9192#discussion_r309609794 ## File path: docs/getting-started/docker-playgrounds/flink_cluster_playground.md ###

[jira] [Closed] (FLINK-13434) Add E2E test for stop-with-savepoint

2019-08-01 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-13434. -- Resolution: Fixed Merged on master with d57ff710e361b74ba9703f670f92d039b7b9c08f and on releas

[GitHub] [flink] kl0u commented on issue #9304: [FLINK-13434][e2e] Add stop-with-savepoint end-to-end tests.

2019-08-01 Thread GitBox
kl0u commented on issue #9304: [FLINK-13434][e2e] Add stop-with-savepoint end-to-end tests. URL: https://github.com/apache/flink/pull/9304#issuecomment-517207805 Merged. This is an automated message from the Apache Git Servic

[GitHub] [flink] azagrebin commented on issue #9272: [FLINK-13435] Remove ShuffleDescriptor.ReleaseType and make release semantics fixed per partition type

2019-08-01 Thread GitBox
azagrebin commented on issue #9272: [FLINK-13435] Remove ShuffleDescriptor.ReleaseType and make release semantics fixed per partition type URL: https://github.com/apache/flink/pull/9272#issuecomment-517207789 Thanks for the review @zhijiangW ! I mentioned the explanation in FLINK-13

[GitHub] [flink] kl0u closed pull request #9304: [FLINK-13434][e2e] Add stop-with-savepoint end-to-end tests.

2019-08-01 Thread GitBox
kl0u closed pull request #9304: [FLINK-13434][e2e] Add stop-with-savepoint end-to-end tests. URL: https://github.com/apache/flink/pull/9304 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] zentol commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions

2019-08-01 Thread GitBox
zentol commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions URL: https://github.com/apache/flink/pull/9250#discussion_r309607220 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.jav

[GitHub] [flink] flinkbot commented on issue #9313: [FLINK-13504][table] Fixed shading issues in table modules.

2019-08-01 Thread GitBox
flinkbot commented on issue #9313: [FLINK-13504][table] Fixed shading issues in table modules. URL: https://github.com/apache/flink/pull/9313#issuecomment-517206630 ## CI report: * 8f5327afea7e343ed0effb541050ebfdc6f443e4 : PENDING [Build](https://travis-ci.com/flink-ci/flink/buil

[GitHub] [flink] flinkbot edited a comment on issue #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions URL: https://github.com/apache/flink/pull/9250#issuecomment-515772917 ## CI report: * 4e15048a256b338df18ad8f9d89e0a576ae06a27 : FAILURE [Build](https://travis-ci.com/flink-ci

[GitHub] [flink] flinkbot commented on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner.

2019-08-01 Thread GitBox
flinkbot commented on issue #9314: [FLINK-12704][python] Enable the configuration of using blink planner. URL: https://github.com/apache/flink/pull/9314#issuecomment-517205472 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-12704) Enable the configuration of using blink planner

2019-08-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12704: --- Labels: pull-request-available (was: ) > Enable the configuration of using blink planner >

[jira] [Commented] (FLINK-13083) Various improvements PubSub Connector

2019-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897913#comment-16897913 ] Jiangjie Qin commented on FLINK-13083: -- [~Xeli] Ping again. Please let me know if y

[GitHub] [flink] WeiZhong94 opened a new pull request #9314: [FLINK-12704][python] Enable the configuration of using blink planner.

2019-08-01 Thread GitBox
WeiZhong94 opened a new pull request #9314: [FLINK-12704][python] Enable the configuration of using blink planner. URL: https://github.com/apache/flink/pull/9314 ## What is the purpose of the change *This pull request adds the `EnvironmentSettings` class for flink python API to enab

[GitHub] [flink] flinkbot edited a comment on issue #9269: [FLINK-9900][tests] Fix unstable ZooKeeperHighAvailabilityITCase

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9269: [FLINK-9900][tests] Fix unstable ZooKeeperHighAvailabilityITCase URL: https://github.com/apache/flink/pull/9269#issuecomment-516265744 ## CI report: * cb68c75d9078f8631c89ee30b7f6b1309b189be3 : FAILURE [Build](https://travis-ci.com/flink-ci/

[GitHub] [flink] azagrebin commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions

2019-08-01 Thread GitBox
azagrebin commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions URL: https://github.com/apache/flink/pull/9250#discussion_r309602906 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutor

[GitHub] [flink] zhuzhurk edited a comment on issue #9288: [FLINK-13421] [runtime] Do not allocate slots in a MultiTaskSlot when it’s releasing children

2019-08-01 Thread GitBox
zhuzhurk edited a comment on issue #9288: [FLINK-13421] [runtime] Do not allocate slots in a MultiTaskSlot when it’s releasing children URL: https://github.com/apache/flink/pull/9288#issuecomment-517152938 > Thanks for opening this PR @zhuzhurk. I have to admit that I cannot completely fol

[GitHub] [flink] zhuzhurk edited a comment on issue #9288: [FLINK-13421] [runtime] Do not allocate slots in a MultiTaskSlot when it’s releasing children

2019-08-01 Thread GitBox
zhuzhurk edited a comment on issue #9288: [FLINK-13421] [runtime] Do not allocate slots in a MultiTaskSlot when it’s releasing children URL: https://github.com/apache/flink/pull/9288#issuecomment-517152938 > Thanks for opening this PR @zhuzhurk. I have to admit that I cannot completely fol

[jira] [Assigned] (FLINK-13523) Verify and correct arithmetic function's semantic for Blink planner

2019-08-01 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13523: --- Assignee: Zhenghua Gao > Verify and correct arithmetic function's semantic for Blink planner >

[GitHub] [flink] flinkbot commented on issue #9313: [FLINK-13504][table] Fixed shading issues in table modules.

2019-08-01 Thread GitBox
flinkbot commented on issue #9313: [FLINK-13504][table] Fixed shading issues in table modules. URL: https://github.com/apache/flink/pull/9313#issuecomment-517202601 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your p

[GitHub] [flink] twalthr commented on a change in pull request #9312: [FLINK-13436][end-to-end-tests] Add TPC-H queries as E2E tests

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9312: [FLINK-13436][end-to-end-tests] Add TPC-H queries as E2E tests URL: https://github.com/apache/flink/pull/9312#discussion_r309601603 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/Ex

[GitHub] [flink] dawidwys closed pull request #9297: [FLINK-13504][table] Fixed shading issues in table modules.

2019-08-01 Thread GitBox
dawidwys closed pull request #9297: [FLINK-13504][table] Fixed shading issues in table modules. URL: https://github.com/apache/flink/pull/9297 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [flink] dawidwys commented on issue #9297: [FLINK-13504][table] Fixed shading issues in table modules.

2019-08-01 Thread GitBox
dawidwys commented on issue #9297: [FLINK-13504][table] Fixed shading issues in table modules. URL: https://github.com/apache/flink/pull/9297#issuecomment-517202233 Unfortunately this approach does not work. The problem is that when we relocate `flink-sql-parser` it uses the relocat

[GitHub] [flink] dawidwys opened a new pull request #9313: [FLINK-13504][table] Fixed shading issues in table modules.

2019-08-01 Thread GitBox
dawidwys opened a new pull request #9313: [FLINK-13504][table] Fixed shading issues in table modules. URL: https://github.com/apache/flink/pull/9313 ## What is the purpose of the change This PR properly includes the flink-sql-parser into flink-planner* modules shaded jars. It a

[jira] [Commented] (FLINK-11608) Translate the "Local Setup Tutorial" page into Chinese

2019-08-01 Thread WangHengWei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897903#comment-16897903 ] WangHengWei commented on FLINK-11608: - Hi [~jark], [~shengjk1], I left some comments

[GitHub] [flink] flinkbot edited a comment on issue #9269: [FLINK-9900][tests] Fix unstable ZooKeeperHighAvailabilityITCase

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9269: [FLINK-9900][tests] Fix unstable ZooKeeperHighAvailabilityITCase URL: https://github.com/apache/flink/pull/9269#issuecomment-516265744 ## CI report: * cb68c75d9078f8631c89ee30b7f6b1309b189be3 : FAILURE [Build](https://travis-ci.com/flink-ci/

[GitHub] [flink] zentol commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions

2019-08-01 Thread GitBox
zentol commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions URL: https://github.com/apache/flink/pull/9250#discussion_r309600284 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309545022 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309554284 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309594125 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[jira] [Commented] (FLINK-13504) NoSuchFieldError when executing DDL via tEnv.sqlUpdate in application project

2019-08-01 Thread Nicholas Jiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897899#comment-16897899 ] Nicholas Jiang commented on FLINK-13504: [~dawidwys]I removed sql package of cal

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309560829 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309537284 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309564946 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309561355 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] twalthr commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37 URL: https://github.com/apache/flink/pull/9239#discussion_r309599021 ## File path: docs/dev/table/catalog.md ## @@ -161,8 +161,8 @@ Currently `HiveCatalog` supports

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309591683 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309556473 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309557480 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309554158 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309558289 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309590465 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309590101 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309590685 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] twalthr commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37 URL: https://github.com/apache/flink/pull/9239#discussion_r309597763 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/uti

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309538399 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309595542 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309592331 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309596603 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309537175 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[GitHub] [flink] wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-01 Thread GitBox
wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309596546 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/ta

[jira] [Commented] (FLINK-13497) Checkpoints can complete after CheckpointFailureManager fails job

2019-08-01 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897896#comment-16897896 ] vinoyang commented on FLINK-13497: -- [~SleePy] Your comment is reasonable, I am discussi

[GitHub] [flink] JingsongLi commented on issue #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job

2019-08-01 Thread GitBox
JingsongLi commented on issue #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job URL: https://github.com/apache/flink/pull/9277#issuecomment-517198392 LGTM This is an automated message from the Apa

[GitHub] [flink] zentol commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions

2019-08-01 Thread GitBox
zentol commented on a change in pull request #9250: [FLINK-13371][coordination] Prevent leaks of blocking partitions URL: https://github.com/apache/flink/pull/9250#discussion_r309597163 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest

[GitHub] [flink] JingsongLi commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job

2019-08-01 Thread GitBox
JingsongLi commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job URL: https://github.com/apache/flink/pull/9277#discussion_r309596967 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/t

[jira] [Commented] (FLINK-13497) Checkpoints can complete after CheckpointFailureManager fails job

2019-08-01 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897891#comment-16897891 ] Biao Liu commented on FLINK-13497: -- There is another problem. The {{failGlobal}} might

[GitHub] [flink] XuPingyong commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job

2019-08-01 Thread GitBox
XuPingyong commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job URL: https://github.com/apache/flink/pull/9277#discussion_r309595939 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/t

[GitHub] [flink] YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese

2019-08-01 Thread GitBox
YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese URL: https://github.com/apache/flink/pull/7751#discussion_r309581645 ## File path: docs/tutorials/local_setup.zh.md ## @@ -0,0 +1,288 @@ +--

[GitHub] [flink] flinkbot edited a comment on issue #9287: [FLINK-13498][kafka] abort transactions in parallel

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9287: [FLINK-13498][kafka] abort transactions in parallel URL: https://github.com/apache/flink/pull/9287#issuecomment-516728827 ## CI report: * 1bbf7fcca6eaf926e1e8126e3564a86df16f2d37 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/

[GitHub] [flink] YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese

2019-08-01 Thread GitBox
YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese URL: https://github.com/apache/flink/pull/7751#discussion_r309580130 ## File path: docs/tutorials/local_setup.zh.md ## @@ -0,0 +1,288 @@ +--

[GitHub] [flink] XuPingyong commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job

2019-08-01 Thread GitBox
XuPingyong commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job URL: https://github.com/apache/flink/pull/9277#discussion_r309594327 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/t

[GitHub] [flink] YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese

2019-08-01 Thread GitBox
YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese URL: https://github.com/apache/flink/pull/7751#discussion_r309579053 ## File path: docs/tutorials/local_setup.zh.md ## @@ -0,0 +1,288 @@ +--

[GitHub] [flink] JingsongLi commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job

2019-08-01 Thread GitBox
JingsongLi commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job URL: https://github.com/apache/flink/pull/9277#discussion_r309593539 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/t

[GitHub] [flink] JingsongLi commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job

2019-08-01 Thread GitBox
JingsongLi commented on a change in pull request #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job URL: https://github.com/apache/flink/pull/9277#discussion_r309593206 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/t

[GitHub] [flink] YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese

2019-08-01 Thread GitBox
YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese URL: https://github.com/apache/flink/pull/7751#discussion_r309570136 ## File path: docs/tutorials/local_setup.zh.md ## @@ -0,0 +1,288 @@ +--

[GitHub] [flink] YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese

2019-08-01 Thread GitBox
YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese URL: https://github.com/apache/flink/pull/7751#discussion_r309569346 ## File path: docs/tutorials/local_setup.zh.md ## @@ -0,0 +1,288 @@ +--

[jira] [Commented] (FLINK-13527) Instable KafkaProducerExactlyOnceITCase due to CheckpointFailureManager

2019-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897885#comment-16897885 ] Jiangjie Qin commented on FLINK-13527: -- [~yanghua] I did not notice that [~yunta] w

[jira] [Commented] (FLINK-13279) not able to query table registered in catalogs in SQL CLI

2019-08-01 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897884#comment-16897884 ] Timo Walther commented on FLINK-13279: -- Hi [~xuefuz], I totally agree that the usab

[GitHub] [flink] YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese

2019-08-01 Thread GitBox
YngwieWang commented on a change in pull request #7751: [FLINK-11608] [docs] Translate the "Local Setup Tutorial" page into Chinese URL: https://github.com/apache/flink/pull/7751#discussion_r309562144 ## File path: docs/tutorials/local_setup.zh.md ## @@ -0,0 +1,288 @@ +--

[GitHub] [flink] flinkbot commented on issue #8886: [FLINK-12987][metrics] fix DescriptiveStatisticsHistogram#getCount() not returning the number of elements seen

2019-08-01 Thread GitBox
flinkbot commented on issue #8886: [FLINK-12987][metrics] fix DescriptiveStatisticsHistogram#getCount() not returning the number of elements seen URL: https://github.com/apache/flink/pull/8886#issuecomment-517193351 ## CI report: * 33a116dc1d23b9f423385240859bf9b0b72822b1 : PENDING

[GitHub] [flink] NicoK commented on issue #9287: [FLINK-13498][kafka] abort transactions in parallel

2019-08-01 Thread GitBox
NicoK commented on issue #9287: [FLINK-13498][kafka] abort transactions in parallel URL: https://github.com/apache/flink/pull/9287#issuecomment-517193410 Thanks @pnowojski for the review. Following a discussion with @becketqin, I reverted the parts that used our own `ForkJoinPool` and chan

[GitHub] [flink] flinkbot edited a comment on issue #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job

2019-08-01 Thread GitBox
flinkbot edited a comment on issue #9277: [FLINK-13494][table-planner-blink] Only use env parallelism for sql job URL: https://github.com/apache/flink/pull/9277#issuecomment-516388088 ## CI report: * 7bebdd65247ac172a23f9b0a91873b01b554cd71 : FAILURE [Build](https://travis-ci.com/fl

<    1   2   3   4   5   6   7   >