wuchong commented on code in PR #22734:
URL: https://github.com/apache/flink/pull/22734#discussion_r1248518654
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/fusion/spec/HashJoinFusionCodegenSpec.scala:
##
@@ -0,0 +1,542 @@
+/*
+ *
wuchong commented on code in PR #22734:
URL: https://github.com/apache/flink/pull/22734#discussion_r1248518300
##
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/multipleinput/input/InputSelectionHandlerTest.java:
##
@@ -41,7 +42,11 @@
wuchong commented on code in PR #22734:
URL: https://github.com/apache/flink/pull/22734#discussion_r1248506769
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/GeneratedExpression.scala:
##
@@ -39,7 +39,7 @@ import
liuyongvs commented on code in PR #22745:
URL: https://github.com/apache/flink/pull/22745#discussion_r1248456341
##
docs/data/sql_functions.yml:
##
@@ -658,6 +658,9 @@ collection:
- sql: MAP_FROM_ARRAYS(array_of_keys, array_of_values)
table: mapFromArrays(array_of_keys,
liuyongvs commented on PR #22745:
URL: https://github.com/apache/flink/pull/22745#issuecomment-1615454677
Hi @snuyanzin do you have time to review it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/FLINK-32418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739266#comment-17739266
]
Benchao Li commented on FLINK-32418:
Agree with [~yuxia] , connectors and formats should use the
hanyuzheng7 commented on PR #22923:
URL: https://github.com/apache/flink/pull/22923#issuecomment-1615417080
@snuyanzin do you know the result format of this select statement in
sql-client?
`SELECT cast(array[row(1, 'one'), row(2, 'two')] as array>);`
--
This is an automated message
flinkbot commented on PR #22924:
URL: https://github.com/apache/flink/pull/22924#issuecomment-1615407096
## CI report:
* b0fc06c58850968ad345c0b2693a4387a648cc9d UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-32404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-32404:
---
Labels: pull-request-available (was: )
> Introduce catalog modification listener and
FangYongs opened a new pull request, #22924:
URL: https://github.com/apache/flink/pull/22924
## What is the purpose of the change
This PR aims to add catalog modification listener interface and create the
listeners for catalog manager from configuration
## Brief change log
xintongsong commented on code in PR #22851:
URL: https://github.com/apache/flink/pull/22851#discussion_r1248387674
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/file/HashPartitionFileWriter.java:
##
@@ -0,0 +1,234 @@
+/*
+ * Licensed
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1248421262
##
flink-end-to-end-tests/run-nightly-tests.sh:
##
@@ -185,7 +185,7 @@ function run_group_2 {
run_test "Batch SQL end-to-end test using hybrid selective
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1248421262
##
flink-end-to-end-tests/run-nightly-tests.sh:
##
@@ -185,7 +185,7 @@ function run_group_2 {
run_test "Batch SQL end-to-end test using hybrid selective
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1248422378
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##
@@ -268,12 +266,7 @@ private CompletableFuture handleException(
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1248421262
##
flink-end-to-end-tests/run-nightly-tests.sh:
##
@@ -185,7 +185,7 @@ function run_group_2 {
run_test "Batch SQL end-to-end test using hybrid selective
flinkbot commented on PR #22923:
URL: https://github.com/apache/flink/pull/22923#issuecomment-1615306688
## CI report:
* 141305019b2b1a9eadc73be6c4e3bf7662460a0e UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin reassigned FLINK-32296:
---
Assignee: Sergey Nuyanzin
> Flink SQL handle array of row incorrectly
>
[
https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739253#comment-17739253
]
Sergey Nuyanzin commented on FLINK-32296:
-
[~qingwei91] could you please double check that this
snuyanzin opened a new pull request, #22923:
URL: https://github.com/apache/flink/pull/22923
The PR addresses allows casting in correct way collections like `ARRAY` and
`MAP` with `ROW` element types
e.g.
```sql
SELECT cast(array[row(1, 'one'), row(2, 'two')] as array>);
SELECT
[
https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-32296:
---
Labels: pull-request-available (was: )
> Flink SQL handle array of row incorrectly
>
[
https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739252#comment-17739252
]
Sergey Nuyanzin edited comment on FLINK-32296 at 7/1/23 12:14 AM:
--
The
[
https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739252#comment-17739252
]
Sergey Nuyanzin edited comment on FLINK-32296 at 7/1/23 12:14 AM:
--
The
[
https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739252#comment-17739252
]
Sergey Nuyanzin commented on FLINK-32296:
-
The root cause is {{RowToRowCastRule}}. Since it was
[
https://issues.apache.org/jira/browse/FLINK-32505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739251#comment-17739251
]
Yuxin Tan commented on FLINK-32505:
---
[~mapohl] Thanks for the fix.
> Compilation error in
liuyongvs commented on code in PR #22917:
URL: https://github.com/apache/flink/pull/22917#discussion_r1248327617
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java:
##
@@ -58,8 +58,12 @@ public final
hanyuzheng7 commented on code in PR #22917:
URL: https://github.com/apache/flink/pull/22917#discussion_r1248318340
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java:
##
@@ -58,8 +58,12 @@ public final
hanyuzheng7 commented on code in PR #22917:
URL: https://github.com/apache/flink/pull/22917#discussion_r1248317688
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##
@@ -303,7 +302,7 @@ ANY,
hanyuzheng7 commented on code in PR #22917:
URL: https://github.com/apache/flink/pull/22917#discussion_r1248317688
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##
@@ -303,7 +302,7 @@ ANY,
hanyuzheng7 commented on PR #22922:
URL: https://github.com/apache/flink/pull/22922#issuecomment-1615226953
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
XComp commented on PR #22661:
URL: https://github.com/apache/flink/pull/22661#issuecomment-1615206613
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
XComp commented on PR #22661:
URL: https://github.com/apache/flink/pull/22661#issuecomment-1615206433
Test instability is related to FLINK-32370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
flinkbot commented on PR #22922:
URL: https://github.com/apache/flink/pull/22922#issuecomment-1615182489
## CI report:
* 86adecb4b4efea7984e8d04a5194c2d6b2defb47 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-32256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-32256:
---
Labels: pull-request-available (was: )
> Add ARRAY_MIN support in SQL & Table API
>
hanyuzheng7 opened a new pull request, #22922:
URL: https://github.com/apache/flink/pull/22922
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring
[
https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739229#comment-17739229
]
Hanyu Zheng commented on FLINK-32257:
-
Hi [~jackylau], I am also working on collection functions.
I
hanyuzheng7 commented on PR #22785:
URL: https://github.com/apache/flink/pull/22785#issuecomment-1615158354
@dawidwys I have already rebased it and solved conflicts and run CI test.
It's ready to merge now. Thank you!
--
This is an automated message from the Apache Git Service.
To
Ryan van Huuksloot created FLINK-32508:
--
Summary: Flink-Metrics Prometheus - Native Histograms / Native
Counters
Key: FLINK-32508
URL: https://issues.apache.org/jira/browse/FLINK-32508
Project:
[
https://issues.apache.org/jira/browse/FLINK-32507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mason Chen updated FLINK-32507:
---
Issue Type: Improvement (was: Technical Debt)
> Document KafkaSink SinkWriterMetricGroup metrics
>
[
https://issues.apache.org/jira/browse/FLINK-31662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Cranmer resolved FLINK-31662.
---
Resolution: Done
> Migrate flink-connectors-aws to new structure
>
[
https://issues.apache.org/jira/browse/FLINK-31662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739210#comment-17739210
]
Danny Cranmer commented on FLINK-31662:
---
Merged commit
[
https://issues.apache.org/jira/browse/FLINK-30946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Cranmer resolved FLINK-30946.
---
Assignee: Hong Liang Teoh
Resolution: Fixed
> Migrate AWS connector formats to
[
https://issues.apache.org/jira/browse/FLINK-31662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Cranmer updated FLINK-31662:
--
Component/s: Connectors / DynamoDB
Connectors / Firehose
[
https://issues.apache.org/jira/browse/FLINK-30946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Cranmer updated FLINK-30946:
--
Fix Version/s: aws-connector-4.2.0
> Migrate AWS connector formats to flink-connector-aws
>
[
https://issues.apache.org/jira/browse/FLINK-30946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739211#comment-17739211
]
Danny Cranmer commented on FLINK-30946:
---
All subtasks complete. Resolving, thanks [~liangtl]
>
[
https://issues.apache.org/jira/browse/FLINK-31662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Cranmer updated FLINK-31662:
--
Component/s: Connectors / AWS
> Migrate flink-connectors-aws to new structure
>
[
https://issues.apache.org/jira/browse/FLINK-31662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Cranmer updated FLINK-31662:
--
Fix Version/s: aws-connector-4.2.0
> Migrate flink-connectors-aws to new structure
>
dannycranmer merged PR #62:
URL: https://github.com/apache/flink-connector-aws/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-32262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hanyu Zheng updated FLINK-32262:
Description:
Implement the {{map_entries}} method to transform a map into an array of
key-value
Mason Chen created FLINK-32507:
--
Summary: Document KafkaSink SinkWriterMetricGroup metrics
Key: FLINK-32507
URL: https://issues.apache.org/jira/browse/FLINK-32507
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-32496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739192#comment-17739192
]
Rui Fan commented on FLINK-32496:
-
Thanks [~haishui] and [~mason6345] , I will finish it asap.:)
>
1996fanrui commented on PR #22921:
URL: https://github.com/apache/flink/pull/22921#issuecomment-1614986008
Hi @pnowojski @RocMarshal , I have finished the first version of watermark
aggregation benchmark. Would you mind help take a look in your free time?
thanks~
[
https://issues.apache.org/jira/browse/FLINK-32422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl reassigned FLINK-32422:
-
Assignee: Matthias Pohl
> EmbeddedLeaderService doesn't handle the leader events
[
https://issues.apache.org/jira/browse/FLINK-31837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl reassigned FLINK-31837:
-
Assignee: Matthias Pohl
> Move LeaderElectionDriver instantiated into
>
[
https://issues.apache.org/jira/browse/FLINK-32503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl reassigned FLINK-32503:
-
Assignee: Matthias Pohl
> FLIP-285 technical debt
> ---
>
>
[
https://issues.apache.org/jira/browse/FLINK-32496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739189#comment-17739189
]
Mason Chen commented on FLINK-32496:
Hi [~haishui] [~fanrui]! I was looking at the user thread too
flinkbot commented on PR #22921:
URL: https://github.com/apache/flink/pull/22921#issuecomment-1614960838
## CI report:
* 73edc3a766af1d716a28c63b6729042ac94eb12d UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-32506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-32506:
---
Labels: pull-request-available (was: )
> Add the watermark aggregation benchmark for
1996fanrui opened a new pull request, #22921:
URL: https://github.com/apache/flink/pull/22921
## What is the purpose of the change
[FLINK-32420](https://issues.apache.org/jira/browse/FLINK-32420) is
improving the watermark aggregation performance.
We want to add a benchmark
hanyuzheng7 commented on PR #22785:
URL: https://github.com/apache/flink/pull/22785#issuecomment-1614890408
@flinkbot run Azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Rui Fan created FLINK-32506:
---
Summary: Add the watermark aggregation benchmark for source
coordinator
Key: FLINK-32506
URL: https://issues.apache.org/jira/browse/FLINK-32506
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-32505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl resolved FLINK-32505.
---
Fix Version/s: 1.18.0
Resolution: Fixed
master:
XComp merged PR #22920:
URL: https://github.com/apache/flink/pull/22920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
XComp commented on PR #22920:
URL: https://github.com/apache/flink/pull/22920#issuecomment-1614874864
thanks for the quick approval. A local run succeeded. I'm not gonna wait for
CI and merge the fix rightaway to make `master` succeed again, hopefully.
--
This is an automated message
XComp commented on PR #22844:
URL: https://github.com/apache/flink/pull/22844#issuecomment-1614873661
and another one after I rebased FLINK-31783 again -.-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
reswqa commented on PR #22920:
URL: https://github.com/apache/flink/pull/22920#issuecomment-1614862202
Thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
flinkbot commented on PR #22920:
URL: https://github.com/apache/flink/pull/22920#issuecomment-1614856839
## CI report:
* 6c1d7488d10adf01b8d609b38eadf8c0855a09a5 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
jayadeep-jayaraman commented on PR #15:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/15#issuecomment-1614855328
@MartijnVisser - I closed the earlier PR and raised a new one, my local
workspace had got corrupted so I cleaned it up and added back the changes.
Please take
XComp commented on PR #22661:
URL: https://github.com/apache/flink/pull/22661#issuecomment-1614853966
I had to do another round because of FLINK-32505 :roll_eyes: I now
force-pushed the branch based on 1ef997369799b1b72d263c945ddeafcf671b3326 which
had a green CI run in master
--
This
XComp commented on PR #22920:
URL: https://github.com/apache/flink/pull/22920#issuecomment-1614844835
@reswqa can you approve this issue to fix master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chucheng92 commented on code in PR #21442:
URL: https://github.com/apache/flink/pull/21442#discussion_r1248018536
##
pom.xml:
##
@@ -684,9 +684,9 @@ under the License.
- commons-collections
[
https://issues.apache.org/jira/browse/FLINK-32505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-32505:
---
Labels: pull-request-available (was: )
> Compilation error in
XComp opened a new pull request, #22920:
URL: https://github.com/apache/flink/pull/22920
Looks like the issue was caused by the introduction of FLINK-31644 and the
concurrent upgrade of flink-shaded.
## What is the purpose of the change
Fixes the compilation error
##
[
https://issues.apache.org/jira/browse/FLINK-32208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739142#comment-17739142
]
Danny Cranmer commented on FLINK-32208:
---
merged commit
[
https://issues.apache.org/jira/browse/FLINK-32208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Cranmer resolved FLINK-32208.
---
Resolution: Fixed
> Remove dependency on flink-shaded from flink-connector-aws
>
dannycranmer merged PR #85:
URL: https://github.com/apache/flink-connector-aws/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Matthias Pohl created FLINK-32505:
-
Summary: Compilation error in ProducerMergedPartitionFileWriter
Key: FLINK-32505
URL: https://issues.apache.org/jira/browse/FLINK-32505
Project: Flink
jayadeep-jayaraman closed pull request #13: [FLINK-32031] Flink GCP Connector
having issues with Conscrypt library
URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dannycranmer commented on code in PR #85:
URL:
https://github.com/apache/flink-connector-aws/pull/85#discussion_r1248007942
##
flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/DynamoDbDynamicSinkFactory.java:
##
@@ -72,6 +70,10 @@ public String
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1248008592
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
>
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1248008592
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
>
dannycranmer commented on code in PR #21458:
URL: https://github.com/apache/flink/pull/21458#discussion_r1248002523
##
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java:
##
@@ -126,7 +126,16 @@ public long
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
MartijnVisser commented on PR #13:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/13#issuecomment-1614819302
@jayadeep-jayaraman I'm a bit surprised that
d7ed02b76be15afdff0f9c8fc0805bc30ce6c559 is now appearing in this PR as a
commit, that shouldn't have been the case
flinkbot commented on PR #22919:
URL: https://github.com/apache/flink/pull/22919#issuecomment-1614819532
## CI report:
* 2a64d561b88bdf51aec952e557d08310e05189fa UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
XComp commented on PR #22844:
URL: https://github.com/apache/flink/pull/22844#issuecomment-1614818534
Force-pushed a rebase to the most-recent version of
[FLINK-31783](https://issues.apache.org/jira/browse/FLINK-31783) to include
`master` which appears to be more stable now
--
This is
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
dannycranmer commented on code in PR #22906:
URL: https://github.com/apache/flink/pull/22906#discussion_r1247985816
##
docs/layouts/shortcodes/generated/expert_rest_section.html:
##
@@ -20,6 +20,12 @@
Long
The time in ms that the client waits for the
XComp commented on PR #22661:
URL: https://github.com/apache/flink/pull/22661#issuecomment-1614816466
Force-pushed rebase since master seems to be more stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
[
https://issues.apache.org/jira/browse/FLINK-31837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-31837:
---
Labels: pull-request-available (was: )
> Move LeaderElectionDriver instantiated into
>
XComp opened a new pull request, #22919:
URL: https://github.com/apache/flink/pull/22919
## What is the purpose of the change
The driver doesn't need to be instantiated when the
`DefaultLeaderElectionService` is instantiated. Instead, we can instantiated
when the first contender is
chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
[
https://issues.apache.org/jira/browse/FLINK-31816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl updated FLINK-31816:
--
Parent: FLINK-32503
Issue Type: Sub-task (was: Technical Debt)
> Refactor
MartijnVisser commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247980121
##
flink-connector-kafka/pom.xml:
##
@@ -72,6 +72,13 @@ under the License.
${kafka.version}
+
Review Comment:
[
https://issues.apache.org/jira/browse/FLINK-30789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl updated FLINK-30789:
--
Parent: FLINK-32503
Issue Type: Sub-task (was: Technical Debt)
> Merge
hanyuzheng7 commented on code in PR #22917:
URL: https://github.com/apache/flink/pull/22917#discussion_r1247961308
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java:
##
@@ -58,8 +58,12 @@ public final
[
https://issues.apache.org/jira/browse/FLINK-32157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl updated FLINK-32157:
--
Parent: (was: FLINK-26522)
Issue Type: Technical Debt (was: Sub-task)
> Replaces
1 - 100 of 313 matches
Mail list logo
