Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5560#discussion_r170296322
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5560#discussion_r170281192
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -289,7 +290,7 @@ public void invoke() throws Exception
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5545
I have test failures, e.g., `
StreamGraphGeneratorTest.testMaxParallelismWithConnectedKeyedStream` ð¢
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169682725
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/retriever/TestingGatewayRetriever.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169696196
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/async/AbstractAsynchronousOperationHandlersTest.java
---
@@ -0,0 +1,350
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169687251
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -109,9 +97,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169676080
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -123,214 +109,112 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169694927
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/async/AbstractAsynchronousOperationHandlersTest.java
---
@@ -0,0 +1,350
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169687850
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/async/AsynchronousOperationResult.java
---
@@ -0,0 +1,74
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169675799
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -123,214 +109,112 @@ public
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5545
The test relies on being able to set setParallelism on a non-parallel
source:
`DataStream input1 = env.fromElements(1, 2, 3,
4).setMaxParallelism(128);`
---
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5529
[FLINK-7712][flip6] Port JarDeleteHandler to new REST endpoint
## What is the purpose of the change
*Enable deletion of jars from Web UI in flip6 mode.*
cc: @tillrohrmann
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5577#discussion_r170537772
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/leaderretrieval/SettableLeaderRetrievalServiceTest.java
---
@@ -0,0 +1,66
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5577#discussion_r170537784
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/SettableLeaderRetrievalService.java
---
@@ -16,36 +16,34 @@
* limitations
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5566
[FLINK-8754][flip6] Make TaskManagerInfo implement Serializable
## What is the purpose of the change
*`TaskManagerInfo` can be returned from RPC calls, e.g.,
`ResourceManagerGateway
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5557
I think you mean work-around
https://www.merriam-webster.com/dictionary/work-around
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5216#discussion_r159243077
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -272,6 +275,7 @@ public void testJavaAPI() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r159247245
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java ---
@@ -27,11 +27,16 @@
import java.util.concurrent.TimeoutException
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r159249258
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -659,128 +655,107 @@ protected int savepoint(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159227421
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -660,7 +570,25 @@ public int run
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5219
This PR is based on #5216
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r159248959
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -659,128 +655,107 @@ protected int savepoint(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159227619
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -717,7 +645,26 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159226314
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -660,7 +570,25 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159225871
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/YarnApplicationStatusMonitor.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159227955
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -660,7 +570,25 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159224695
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -743,6 +690,142 @@ private void logAndSysout(String message
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159228367
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -717,7 +645,26 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r159230885
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -743,6 +690,142 @@ private void logAndSysout(String message
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5216#discussion_r159242946
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java ---
@@ -78,6 +83,9 @@ public void testPerJobMode
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5216#discussion_r159243765
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -143,31 +138,48 @@
private
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r159400326
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
---
@@ -149,23 +153,26 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r159255690
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
---
@@ -128,13 +131,14 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r159402067
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
---
@@ -178,65 +185,30 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r159252679
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
---
@@ -77,23 +74,25 @@
public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r159401004
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -659,128 +655,107 @@ protected int savepoint(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r159403066
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
---
@@ -178,65 +185,30 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159446300
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -99,6 +69,44 @@ public void testStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159447901
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
@@ -1,170 +0,0 @@
-/*
- * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159449988
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendCancelTest.java
---
@@ -42,70 +39,54 @@
/**
* Tests for the CANCEL
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159465985
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -442,23 +458,15 @@ public int
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159461777
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -442,23 +458,15 @@ public int
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159462006
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -262,16 +277,17 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159464428
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -475,4 +483,38 @@ public int
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159465653
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -442,23 +458,15 @@ public int
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5223
[FLINK-8317][flip6] Implement Triggering of Savepoints
## What is the purpose of the change
*Implement triggering of savepoints through HTTP and through command line
in FLIP-6 mode. This PR
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5193#discussion_r159153854
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/ContentDump.java
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5193#discussion_r159154132
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/AbstractStreamOperatorTestHarness.java
---
@@ -492,6 +503,10 @@ public void close
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159451928
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -391,35 +353,22 @@ public static void printHelpForSavepoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159641680
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendAddressConfigurationTest.java
---
@@ -47,36 +49,29 @@ public static void init
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159644962
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendPackageProgramTest.java
---
@@ -60,7 +62,10 @@ public static void init
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159640707
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -448,68 +397,31 @@ public static RunOptions parseRunCommand
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159643583
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendCancelTest.java
---
@@ -133,19 +139,23 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159650780
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/CliFrontendYarnAddressConfigurationTest.java
---
@@ -191,27 +213,47 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159647064
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/MockedCliFrontend.java
---
@@ -20,40 +20,22 @@
import
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5584#discussion_r170679952
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -186,7 +187,7 @@ public YarnClient getYarnClient
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5584
[FLINK-8787][flip6] WIP
WIP
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5577
[FLINK-8776][flip6] Use correct port for job submission from Web UI
## What is the purpose of the change
*Use correct port for job submission from Web UI when Flink is deployed in
YARN session
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/5545
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5584
test failures due to
```
// logback + log4j, with/out krb5, different JVM opts
// IMPORTANT: Be aware that we are using side effects here to modify the
created YarnClusterDescriptor
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5410
Taking a look once more.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6297
@dawidwys Please merge.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204384134
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -983,7 +983,7 @@ private void startCheckpointScheduler(final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204373664
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -323,7 +323,7 @@ public void disconnectResourceManager
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204368060
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -1011,7 +1011,7 @@ public void failAllocation(final
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6386
https://github.com/apache/flink/pull/6369 should also be merged after this
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204394265
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -384,6 +393,8 @@ private MultiTaskSlot
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204400729
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
---
@@ -504,6 +512,107 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204399866
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
---
@@ -504,6 +512,107 @@ public void
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6368
[FLINK-9890] Remove obsolete class ResourceManagerConfiguration
## What is the purpose of the change
*The configuration values are effectively not used. This commit removes the
class
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6369
[FLINK-9892][tests] Disable local recovery in Jepsen tests.
## What is the purpose of the change
*Until FLINK-9635 is fixed, local recovery should be disabled in the Jepsen
tests
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6418
[FLINK-9939][runtime] Mesos: Not setting TMP dirs causes NPE
## What is the purpose of the change
*This fixes a possible NPE when deploying on Mesos.*
## Brief change log
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6419
[FLINK-9949][tests] Kill Flink processes in DB/teardown
## What is the purpose of the change
*Not killing Flink processes at the end of a test, can cause interference
with subsequent test runs
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6406
[FLINK-9159][runtime] Sanity check default timeout values
## What is the purpose of the change
*Set the default timeouts for resource release to sane values. Consolidate
config keys
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6240#discussion_r201312394
--- Diff: flink-jepsen/src/jepsen/flink/db.clj ---
@@ -175,7 +175,7 @@
(c/su
(c/exec (c/lit (str "HADOOP_CLASSPATH=`&qu
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6279#discussion_r201329956
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -536,7 +540,25 @@ private JobManagerRunner
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6296#discussion_r201570938
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -1189,7 +1189,7 @@ private static Path
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6240
It seems that we have to stick with `0.1.8` for now. According to legal,
there are no concerns so far: https://issues.apache.org/jira/browse/LEGAL-392
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6240#discussion_r200667325
--- Diff: jepsen-flink/.gitignore ---
@@ -0,0 +1,17 @@
+*.class
+*.iml
+*.jar
+*.retry
+.DS_Store
+.hg/
+.hgignore
+.idea
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202300463
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/EntrypointClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,84
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202299810
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/EntrypointClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,84
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202305883
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterConfiguration.java
---
@@ -18,27 +18,43 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202300255
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/ClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,82
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202300519
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/ClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,82
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202332323
--- Diff:
flink-container/src/test/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,89
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202332741
--- Diff: flink-container/pom.xml ---
@@ -0,0 +1,67 @@
+
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202336290
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
+
+## Installation
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202348473
--- Diff: flink-container/docker/build.sh ---
@@ -0,0 +1,128 @@
+#!/bin/sh
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202351378
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
+
+## Installation
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6240
I extended the regular `README.md`.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6319#discussion_r202271606
--- Diff: flink-container/docker/build.sh ---
@@ -0,0 +1,118 @@
+#!/bin/sh
--- End diff --
Just want to note that in other scripts, `bash
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6320
I tested the tooling around docker-compose and it works for me when using
the local distribution.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6297
I will take a look later.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202020619
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202017985
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r201980407
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r201981340
--- Diff: docs/ops/deployment/yarn_setup.md ---
@@ -101,12 +101,12 @@ Usage:
Optional
-D Dynamic properties
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6297
cc: @dawidwys @StephanEwen
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202057663
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6240
`0.1.9.` was problematic. Currently testing `0.1.10`.
---
501 - 600 of 690 matches
Mail list logo
