Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6076#discussion_r190858003
--- Diff: docs/dev/event_time.md ---
@@ -219,4 +219,17 @@ with late elements in event time windows.
Please refer to the [Debugging Windows & E
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6073
Converging dependencies by enforcing their versions in root's pom
`dependencyManagement` section is the way that we have chosen previously, so it
would be more consistent.
https
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r190884312
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -247,7 +249,15 @@ public void shutdown(Time timeout
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6071
Dead lock visible in failed travis is unrelated to this change
(https://issues.apache.org/jira/browse/FLINK-9439)
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5983#discussion_r190567872
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/TimeoutAwareAsyncFunction.java
---
@@ -0,0 +1,41
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6073
Ok, I see it now. This pull request's title is just a tad misleading (it
doesn't fix all of the convergence for this module, just some selection of them)
---
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6072
[hotfix][doc] Mention AggregationEnabled setting in kinesis docs
This change only clarifies the documentation for `FlinkKinesisProducer`
(clarification suggested by a user via mailing list).
You
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6073
Does this fix or just improves dependency convergence? I'm asking because
dependencies of `flink-table` (like `flink-runtime`) still have convergence
errors.
---
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6071
[FLINK-3952][runtine] Upgrade to Netty 4.1
This PR adjusts our code to work with Netty 4.1. It also includes possible
bug fix to file uploading cleanup in FileUploadHandler and HttpRequestHandler
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5983#discussion_r190553816
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/TimeoutAwareAsyncFunction.java
---
@@ -0,0 +1,41
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r190554721
--- Diff: pom.xml ---
@@ -308,7 +308,7 @@ under the License.
errors.
[1] https
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6076
[hotfix][docs] Specify operators behaviour on processing watermarks
This PR is a simple documentation improvement
You can merge this pull request into a Git repository by running:
$ git pull
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6031
Thanks for the review and manual checks! I either addressed your comments
in fixup commit and left comment responses otherwise.
> Do we file a follow up ticket to remove netty-router f
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6031#discussion_r190273990
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RouterHandler.java
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194718801
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/runtime/NettyEpollITCase.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194713008
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RoutedRequest.java
---
@@ -97,11 +98,17 @@ public ReferenceCounted
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194711763
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/ChunkedByteBuf.java
---
@@ -88,6
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195341250
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java ---
@@ -278,15 +278,15 @@
* Unlimited be default
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195342365
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
---
@@ -313,14 +313,22 @@ public int
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195346228
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
---
@@ -1032,19 +1113,50 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195345480
--- Diff:
flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java
---
@@ -122,4 +125,28 @@ public static boolean
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195344817
--- Diff:
flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java
---
@@ -132,7 +132,12 @@ else
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195340311
--- Diff: docs/ops/filesystems.md ---
@@ -102,8 +102,8 @@ fs..limit.input: (number, 0/-1 mean no limit)
fs..limit.output: (number, 0/-1 mean no limit
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r196008935
--- Diff:
flink-core/src/test/java/org/apache/flink/core/fs/LimitedConnectionsFileSystemTest.java
---
@@ -122,6 +122,42 @@ public void
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6076
I have added a sentence covering this, but it would be nice to merge it and
not prolonging and ever extending this PR.
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6081#discussion_r195011678
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
---
@@ -1239,6 +1286,50 @@ protected void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6081#discussion_r195007487
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
---
@@ -806,6 +819,40 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6081#discussion_r195007239
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
---
@@ -806,6 +819,40 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6081#discussion_r195013346
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
---
@@ -169,6 +175,13 @@
private
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6081#discussion_r195012204
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
---
@@ -1239,6 +1286,50 @@ protected void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6076#discussion_r195004441
--- Diff: docs/dev/event_time.md ---
@@ -213,10 +213,36 @@ arrive after the system's event time clock (as
signaled by the watermarks) has a
timestamp
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6071
Thanks!
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6081#discussion_r195123173
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
---
@@ -806,6 +811,44 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195137063
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
---
@@ -88,6 +90,12 @@
/** The nanoseconds
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195136244
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/ConnectionLimitingFactory.java
---
@@ -62,7 +62,9 @@ public FileSystem create(URI fsUri
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195138105
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
---
@@ -731,6 +791,9 @@ public boolean checkNewBytesAndMark
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195134150
--- Diff: docs/ops/filesystems.md ---
@@ -102,6 +102,8 @@ fs..limit.input: (number, 0/-1 mean no limit)
fs..limit.output: (number, 0/-1 mean no limit
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195138248
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
---
@@ -741,6 +804,10 @@ public void write(int b) throws
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195134228
--- Diff: docs/ops/filesystems.md ---
@@ -102,6 +102,8 @@ fs..limit.input: (number, 0/-1 mean no limit)
fs..limit.output: (number, 0/-1 mean no limit
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195134923
--- Diff: docs/ops/filesystems.md ---
@@ -89,9 +89,9 @@ For example, if the default file system configured as
`fs.default-scheme: hdfs
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195142699
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
---
@@ -166,12 +174,47 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194763826
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/ReadOnlySlicedNetworkBuffer.java
---
@@ -75,12 +75,12 @@ private
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194770093
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/ChunkedByteBuf.java
---
@@ -88,6
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194769995
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/ChunkedByteBuf.java
---
@@ -88,6
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195657899
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
---
@@ -940,7 +932,9 @@ public int read() throws
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195681277
--- Diff:
flink-core/src/test/java/org/apache/flink/core/fs/LimitedConnectionsFileSystemTest.java
---
@@ -122,6 +122,42 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195685352
--- Diff:
flink-core/src/test/java/org/apache/flink/core/fs/LimitedConnectionsFileSystemTest.java
---
@@ -122,6 +122,42 @@ public void
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6081
ð Yes, I have already approved it on github:
> pnowojski approved these changes 23 hours ago
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6166#discussion_r195774420
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -292,30 +292,49 @@ private void readRawResponse
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6166#discussion_r195774052
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -292,30 +292,49 @@ private void readRawResponse
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6071
@zentol as @NicoK suggested I have missed netty 4.1 upgrade without credit
base flow control. It turns out that this upgrade is unstable without this fix:
https://github.com/apache/flink/pull/5571
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6076#discussion_r194390932
--- Diff: docs/dev/event_time.md ---
@@ -213,10 +213,33 @@ arrive after the system's event time clock (as
signaled by the watermarks) has a
timestamp
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6076#discussion_r194393116
--- Diff: docs/dev/event_time.md ---
@@ -213,10 +213,33 @@ arrive after the system's event time clock (as
signaled by the watermarks) has a
timestamp
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6081
@yanghua why is it difficult? Can not you create more or less similar test
to @GJL's `testSetsUserCodeClassLoader` from here:
https://github.com/apache/flink/pull/4980/files. With couple side
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r192028605
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AsyncDataStream.scala
---
@@ -71,6 +71,9 @@ object AsyncDataStream
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r192026724
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
---
@@ -648,6 +662,52 @@ public
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6091
Test failure is most likely unrelated and I have crated separate ticket for
it: https://issues.apache.org/jira/browse/FLINK-9481
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6071
@zentol I have also fixed added a test to cover
https://github.com/apache/flink-shaded/issues/30 in the second commit
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191684561
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/runtime/NettyEpollITCase.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191685731
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBuffer.java
---
@@ -215,16 +242,33 @@ protected void _setMedium
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191700895
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/ReadOnlySlicedNetworkBuffer.java
---
@@ -75,12 +75,12 @@ private
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191700141
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBuffer.java
---
@@ -424,6 +480,19 @@ public int setBytes(int
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191685431
--- Diff: pom.xml ---
@@ -300,15 +300,7 @@ under the License.
org.apache.flink
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191683459
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/runtime/NettyEpollITCase.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6076
Thanks for the feedback @eliaslevy. Pushed one extra commit about idling
sources.
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r192319359
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperator.java
---
@@ -209,8 +208,7 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r192316460
--- Diff:
flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/AsyncDataStreamITCase.scala
---
@@ -0,0 +1,157
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r192316418
--- Diff:
flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/AsyncDataStreamITCase.scala
---
@@ -0,0 +1,157
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r192316223
--- Diff:
flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/AsyncDataStreamITCase.scala
---
@@ -0,0 +1,157
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5983
This PR superseded by https://github.com/apache/flink/pull/6091
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6116
Yes I know, but I didn't see those problematic dependencies in
> mvn -Dhadoop.version=2.7.0 dependency:tree -pl
flink-shaded-hadoop/flink-shaded-hadoop2
thus I why assumed prob
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6116
Or can not you converge dependencies in your hadoop? It seems like it's
causing convergence errors with itself.
Disabling convergence checking would be a step back and asking ourself
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6116
I think the problem here is not that some of your versions are conflicting
with flink, but that your dependencies are on their own conflicting. When I
check:
> mvn -Dhadoop.version=2.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191768245
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AsyncDataStream.scala
---
@@ -71,6 +71,9 @@ object AsyncDataStream
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191757079
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
---
@@ -212,6 +212,20 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191768672
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/async/AsyncFunction.scala
---
@@ -46,4 +48,16 @@ trait AsyncFunction
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191767070
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
---
@@ -648,6 +662,52 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r191760364
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
---
@@ -212,6 +212,20 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r197729438
--- Diff:
flink-core/src/test/java/org/apache/flink/core/fs/LimitedConnectionsFileSystemTest.java
---
@@ -122,6 +122,42 @@ public void
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6215
[FLINK-9217][kafka-tests] Disable testTimestamps for Kafka 0.10
This test was deadlocking someimtes and for some reasons it appears not
failing in Kafka 0.11.
Disabling it for now, since
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6218#discussion_r199781443
--- Diff:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverterTest.java
---
@@ -0,0 +1,71
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6218#discussion_r199780422
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java
---
@@ -201,71 +202,69 @@ private Object
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6218#discussion_r199782571
--- Diff: flink-formats/flink-avro/pom.xml ---
@@ -51,6 +51,17 @@ under the License
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6218#discussion_r199780249
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java
---
@@ -17,154 +17,338
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6218#discussion_r199778602
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java
---
@@ -148,25 +148,26 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5923#discussion_r185819830
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -228,20 +228,19 @@ public void setupPartition
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5923#discussion_r185817506
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -228,20 +228,19 @@ public void setupPartition
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5952
[FLINK-9287][kafka] Properly clean up resources in non EXACTLY_ONCE
FlinkKafkaProducer011
Previously FlinkKafkaProducer was not being closed for AT_LEAST_ONCE and
NONE Semantics when closing
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145917513
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145915808
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145903567
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145917932
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145902939
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/AcknowledgeStreamMockEnvironment.java
---
@@ -0,0 +1,65
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4851#discussion_r145903139
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/RestoreStreamTaskTest.java
---
@@ -0,0 +1,325
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4851
It appears that current behaviour is as you wished @StefanRRichter:
- Operator participated in checkpoint, data written -> `isRestored == true`
- Operator participated in checkpo
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145692507
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -269,4 +315,49 @@ private void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145697819
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,6 +211,53 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145697848
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,6 +211,53 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145697924
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -37,18 +43,29 @@
import
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r144244479
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
@@ -304,12 +304,21 @@ public
401 - 500 of 902 matches
Mail list logo
