Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5730#discussion_r177798624
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
---
@@ -80,42 +95,38 @@ public void testJobRetrieval
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5771#discussion_r177746665
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java
---
@@ -167,6 +172,9 @@ private static void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5694
ah i remembered why.
I had to copy the test because this test is in `flink-runtime`. Here we
don't have access to the `MiniClusterResource`.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5694
that is true, yes. I'll update the PR, hang on.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5760
I would suggest to bump it to 3.2.5 as that's that latest version for which
the shading works properly.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5780
[FLINK-8704][tests] Port ClassLoaderITCase to flip6
Partially based on #5766.
## What is the purpose of the change
This PR ports the `ClassLoaderITCase` to flip6
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5778
while you are at it, can you also add the savepoint tests to
`run-nightly-tests.sh`?
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5755#discussion_r177497889
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -165,7 +166,7 @@
private final BlobServer blobServer
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5755#discussion_r177436964
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobManagerJobMetricGroupFactory.java
---
@@ -0,0 +1,46
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5772
[FLINK-8963][tests] Port BigUserProgramJobSubmitITCase to
MiniClusterResource
## What is the purpose of the change
This PR ports the `BigUserProgramJobSubmitITCase` to flip6. The test
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5771#discussion_r177343764
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java
---
@@ -167,6 +172,9 @@ private static void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5755#discussion_r177340014
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobManagerJobMetricGroupFactory.java
---
@@ -0,0 +1,46
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5771#discussion_r177339622
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java
---
@@ -167,6 +172,9 @@ private static void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5769
will merge this later today.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5767#discussion_r177163114
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java
---
@@ -67,7 +61,7 @@
private final
Github user zentol commented on the pull request:
https://github.com/apache/flink/commit/5803950ef0c8c57534b11de459b92d01da4d3fc0#commitcomment-28272592
In flink-end-to-end-tests/test-scripts/test_batch_allround.sh:
In flink-end-to-end-tests/test-scripts/test_batch_allround.sh
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5755#discussion_r177087225
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobManagerJobMetricGroupFactory.java
---
@@ -0,0 +1,46
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5755#discussion_r177090323
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobManagerJobMetricGroupFactory.java
---
@@ -0,0 +1,46
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5763
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5764#discussion_r177080293
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
---
@@ -536,6 +546,103 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5764#discussion_r177082615
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/savepoints/SavepointDisposalRequest.java
---
@@ -0,0 +1,47
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5764#discussion_r177083854
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -344,6 +363,42 @@ public void testJobRecovery() throws
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5764#discussion_r177080326
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
---
@@ -534,6 +534,18 @@ public void start() throws Exception
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5766
[FLINK-8966][tests] Port AvroExternalJarProgramITCase to flip6
## What is the purpose of the change
This PR ports the `AvroExternalJarProgramITCase` to flip6.
## Brief change log
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5763
[hotfix][tests] Hide output from config.sh
## What is the purpose of the change
The `TaskManagerHeapSizeCalculationJavaBashTest` calls the
`calcTMHeapSizeMB.sh/calcTMNetBufMem.sh` scripts
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5736
merging,
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5715
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176767320
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -1831,4 +1831,5 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176769129
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -143,30 +160,23 @@ public void shutdown
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176767248
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/iterative/aggregators/AggregatorsITCase.java
---
@@ -91,6 +93,7 @@ public void after() throws
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176767271
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/distributedcache/DistributedCacheTest.java
---
@@ -40,6 +42,7 @@
/**
* Test
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176768205
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void testGetFailsDuringStreaming
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176766216
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread createShutdownHook
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176764920
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread createShutdownHook
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5736#discussion_r176733032
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ResumeCheckpointManuallyITCase.java
---
@@ -263,56 +268,113 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5728#discussion_r176731691
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/TimestampITCase.java
---
@@ -185,22 +177,23 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5730#discussion_r176690193
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
---
@@ -21,54 +21,69 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5730#discussion_r176688158
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
---
@@ -80,42 +95,38 @@ public void testJobRetrieval
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5745
we may improve the test times by writing a custom reporter specifically for
this test that writes to the log if the condition is met.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5733#discussion_r176677567
--- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
@@ -0,0 +1,155 @@
+#!/usr/bin/env bash
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5733#discussion_r176677831
--- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
@@ -0,0 +1,155 @@
+#!/usr/bin/env bash
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5733#discussion_r176678628
--- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
@@ -0,0 +1,155 @@
+#!/usr/bin/env bash
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5745#discussion_r176677259
--- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
@@ -17,11 +17,25 @@
# limitations under the License
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5745#discussion_r176677065
--- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
@@ -17,11 +17,25 @@
# limitations under the License
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5727
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5722
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5719
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5720
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5715#discussion_r176663967
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java
---
@@ -528,54 +454,44 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176658024
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -306,18 +311,20 @@ public JobSubmissionResult
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662757
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void testGetFailsDuringStreaming
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662599
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void testGetFailsDuringStreaming
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176663553
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -57,89 +65,59 @@
+ "MI
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176658632
--- Diff: flink-end-to-end-tests/pom.xml ---
@@ -78,6 +78,27 @@ under the License
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176660974
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -527,59 +403,83 @@ else if (response == RETURN_ERROR
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176658516
--- Diff: flink-end-to-end-tests/pom.xml ---
@@ -78,6 +78,27 @@ under the License
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176659407
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -159,7 +162,7 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176659832
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -488,13 +493,36 @@ public void addJar(Path jar
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176658879
--- Diff:
flink-libraries/flink-streaming-python/src/main/java/org/apache/flink/streaming/python/api/environment/PythonStreamExecutionEnvironment.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176661729
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread createShutdownHook
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662637
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void testGetFailsDuringStreaming
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662188
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread createShutdownHook
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662946
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -19,30 +19,38 @@
package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176661496
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread createShutdownHook
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176657746
--- Diff:
flink-libraries/flink-python/src/test/java/org/apache/flink/python/api/PythonPlanBinderTest.java
---
@@ -30,6 +33,7 @@
/**
* Tests
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5743
[FLINK-9051][build] Invert flip6 profile
## What is the purpose of the change
Invert the `flip6` profile so that flip6 tests are run by default.
You can merge this pull request into a Git
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5738
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5714
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5738
[FLINK-8925][tests] Enable flip6 on travis
Minimal version of #5714.
## What is the purpose of the change
This PR enables Flip6 for half of our travis profiles.
You can merge
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5736
[FLINK-9042][tests] Port ResumeCheckpointManuallyITCase to flip6
## What is the purpose of the change
Ports the `ResumeCheckpointManuallyITCase` to use `MiniClusterResource
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4809
@razvan100 I've merged the PR, could you close it?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5479
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5717
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5708
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5718
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5729
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5717#discussion_r176032646
--- Diff: flink-end-to-end-tests/parent-child-classloading-test/pom.xml ---
@@ -0,0 +1,107 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5733#discussion_r176028721
--- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
@@ -0,0 +1,102 @@
+#!/usr/bin/env bash
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5734#discussion_r176028213
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -265,7 +265,11 @@ class TaskManager(
case t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5734#discussion_r176028191
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -292,6 +292,13 @@ public void start() throws Exception
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5733#discussion_r176020327
--- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
@@ -0,0 +1,102 @@
+#!/usr/bin/env bash
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5733#discussion_r176019938
--- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
@@ -0,0 +1,102 @@
+#!/usr/bin/env bash
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5730
[FLINK-8961][tests] Port JobRetrievalITCase to flip6
## What is the purpose of the change
This PR ports the `JobRetrievalITCase` to flip6. The existing test was
renamed
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5701
@tillrohrmann done. I wouldn't squash the savepoint port commit with the
accumulator changes though.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5701
let me quickly address the `getCOnfigurationSafe` comment and then let's
merge them together.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5672#discussion_r175752444
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -225,7 +226,9 @@ protected void run(String[] args) throws Exception
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5701#discussion_r175751892
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java
---
@@ -194,49 +187,35 @@ protected final void
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5728
[FLINK-8965][tests] Port TimestampITCase to flip6
## What is the purpose of the change
Ports the `TimestampITCase` to use `MiniClusterResource`.
## Verifying this change
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5701
@tillrohrmann I've addressed your comments regarding the accumulator commit.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5701#discussion_r175735031
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java
---
@@ -194,49 +187,35 @@ protected final void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5701#discussion_r175733781
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/AccumulatorReport.java
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5701#discussion_r175733627
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/AccumulatorReport.java
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5699
@tillrohrmann I've addressed your comments.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5699#discussion_r175732315
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerTest.java
---
@@ -347,6 +348,162 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5699#discussion_r175730535
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
---
@@ -106,8 +107,8 @@ Executor getExecutor
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5672#discussion_r175724663
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -225,7 +226,9 @@ protected void run(String[] args) throws Exception
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5727
[FLINK-8964][tests] Port JobSubmissionFailsITCase to flip6
## What is the purpose of the change
Ports the `JobSubmissionFailsITCase` to use `MiniClusterResource`.
## Brief change
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5580
Not supporting directories would be a regression regardless of whether the
Python API needs it or not.
We either have to add a new method with different behavior, or zip
directories
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5719#discussion_r175702017
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java
---
@@ -18,292 +18,188 @@
package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5719#discussion_r175566292
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java
---
@@ -18,292 +18,188 @@
package
901 - 1000 of 5225 matches
Mail list logo
