Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5448
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197754848
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java ---
@@ -148,6 +148,27 @@ public static MemorySize parse(String text) throws
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197736638
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
---
@@ -67,8 +68,8 @@ public String toString() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197707880
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java ---
@@ -148,6 +148,27 @@ public static MemorySize parse(String text) throw
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197707246
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
---
@@ -67,8 +68,8 @@ public String toString() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197711900
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -385,10 +386,10 @@ private ClusterSpecification
createClusterS
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197711813
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -161,7 +162,7 @@ public YarnResourceManager(
numPen
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197711430
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
---
@@ -66,7 +67,7 @@
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197711881
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -385,10 +386,10 @@ private ClusterSpecification
createClusterS
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197708483
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -482,14 +484,15 @@ private static NetworkEnviro
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197707216
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
---
@@ -67,8 +68,8 @@ public String toString() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197708797
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/NetworkBufferCalculationTest.java
---
@@ -86,7 +87,7 @@ private static TaskMana
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197707411
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java ---
@@ -95,8 +95,8 @@ public long getKibiBytes() {
/**
*
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r193277880
--- Diff: docs/_includes/generated/task_manager_configuration.html ---
@@ -84,13 +84,13 @@
taskmanager.memory.seg
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r193221496
--- Diff: docs/_includes/generated/task_manager_configuration.html ---
@@ -84,13 +84,13 @@
taskmanager.memory.segm
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191191358
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
---
@@ -72,10 +72,19 @@
" leader-election
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191197602
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -647,7 +649,16 @@ public static long calculateH
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191190916
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -176,19 +188,19 @@
/**
* Size of memory b
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191190775
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -176,19 +188,19 @@
/**
* Size of memory b
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191199370
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
---
@@ -223,9 +224,17 @@ public static Ta
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191147297
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
---
@@ -72,10 +72,19 @@
" leader-election
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191147488
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -32,10 +32,22 @@
// General TaskManager Options
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191186380
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -176,19 +188,19 @@
/**
* Size of memory b
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191198882
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -647,7 +649,16 @@ public static long calculateH
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5448
[FLINK-6469] Configure Memory Sizes with units
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-6469
Alternatively you can r
25 matches
Mail list logo
