[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297083#comment-14297083
]
stack commented on HBASE-12859:
---
+1
Looks good.
> Major compaction completion tracker
> -
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296371#comment-14296371
]
Lars Hofhansl commented on HBASE-12859:
---
Looks like this is related to the > 100 ch
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296368#comment-14296368
]
Lars Hofhansl commented on HBASE-12859:
---
Oh, it's checkstyle, not findbugs. Looking
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296350#comment-14296350
]
Hadoop QA commented on HBASE-12859:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296211#comment-14296211
]
Lars Hofhansl commented on HBASE-12859:
---
Thanks [~stack].
bq. nit: getLastMajorCom
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294802#comment-14294802
]
stack commented on HBASE-12859:
---
nit: getLastMajorCompactionTsForTable should have a commen
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294794#comment-14294794
]
Hadoop QA commented on HBASE-12859:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294787#comment-14294787
]
Enis Soztutar commented on HBASE-12859:
---
Removing 1.0 line for now since the RC is
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294606#comment-14294606
]
Lars Hofhansl commented on HBASE-12859:
---
Hmm... HFileBlock heapsize changed. Might
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294568#comment-14294568
]
Hadoop QA commented on HBASE-12859:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294419#comment-14294419
]
Lars Hofhansl commented on HBASE-12859:
---
Thanks guys. This should be a good tactica
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294305#comment-14294305
]
Gary Helmling commented on HBASE-12859:
---
Thanks for the work on this [~lhofhansl] a
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294303#comment-14294303
]
Gary Helmling commented on HBASE-12859:
---
+1 on v5 patch. As we discussed, I think
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294278#comment-14294278
]
Andrew Purtell commented on HBASE-12859:
HBASE-12932 is in, no problem adding met
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294050#comment-14294050
]
Andrew Purtell commented on HBASE-12859:
We don't actually have a 1.0 release yet
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294045#comment-14294045
]
Lars Hofhansl commented on HBASE-12859:
---
Good question what "stable" means. We coul
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294041#comment-14294041
]
Andrew Purtell commented on HBASE-12859:
I moved the interface annotations discus
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294022#comment-14294022
]
Andrew Purtell commented on HBASE-12859:
bq. We do not differentiate or explicitl
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294013#comment-14294013
]
Enis Soztutar commented on HBASE-12859:
---
We do not differentiate or explicitly docu
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293969#comment-14293969
]
Andrew Purtell commented on HBASE-12859:
It's more of a policy question. The HCon
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293937#comment-14293937
]
Lars Hofhansl commented on HBASE-12859:
---
You're worried about binary compatibility?
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293806#comment-14293806
]
Andrew Purtell commented on HBASE-12859:
v5 lgtm
In 0.98, Admin is HBaseAdmin, a
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293799#comment-14293799
]
Andrew Purtell commented on HBASE-12859:
{quote}
bq. I apologize for the rant...
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293000#comment-14293000
]
stack commented on HBASE-12859:
---
bq. I apologize for the rant...
If noone complains, it'l
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292976#comment-14292976
]
Lars Hofhansl commented on HBASE-12859:
---
[~apurtell] explained a bit more of the hi
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291532#comment-14291532
]
Lars Hofhansl commented on HBASE-12859:
---
Now that I said that it occurs to me that
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291450#comment-14291450
]
Lars Hofhansl commented on HBASE-12859:
---
No pain no gain :)
Cleanup or at least mak
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291178#comment-14291178
]
stack commented on HBASE-12859:
---
What happens when master is down? Can it be ignored? It
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290926#comment-14290926
]
Lars Hofhansl commented on HBASE-12859:
---
I agree. It's fine to make master call aft
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290922#comment-14290922
]
Andrew Purtell commented on HBASE-12859:
We used to track region state in the met
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290916#comment-14290916
]
James Taylor commented on HBASE-12859:
--
Is there such a thing as per region metadata
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290904#comment-14290904
]
Lars Hofhansl commented on HBASE-12859:
---
Note that if you call this from a region o
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290795#comment-14290795
]
James Taylor commented on HBASE-12859:
--
Any API is fine by me, [~lhofhansl]. I think
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283232#comment-14283232
]
Andrew Purtell commented on HBASE-12859:
bq. So what about keeping just the HBase
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283132#comment-14283132
]
Lars Hofhansl commented on HBASE-12859:
---
bq. I'm not happy with either alternative.
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282814#comment-14282814
]
Andrew Purtell commented on HBASE-12859:
I'll defer to Gary as to which option is
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281892#comment-14281892
]
Gary Helmling commented on HBASE-12859:
---
Thanks for the work on this, Lars. I will
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281228#comment-14281228
]
Lars Hofhansl commented on HBASE-12859:
---
The other option is to do what HBaseAdmin.
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279893#comment-14279893
]
Lars Hofhansl commented on HBASE-12859:
---
And [~giacomotaylor], is this all we need
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279174#comment-14279174
]
Lars Hofhansl commented on HBASE-12859:
---
Just discussing with [~apurtell]... We can
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278329#comment-14278329
]
Lars Hofhansl commented on HBASE-12859:
---
So the wrinkle is that compaction are per
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278195#comment-14278195
]
Gary Helmling commented on HBASE-12859:
---
Thanks for filing this, Lars.
Yes, this w
[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277957#comment-14277957
]
Lars Hofhansl commented on HBASE-12859:
---
We can use that for:
* Implement predicate
43 matches
Mail list logo
