MikeThomsen commented on pull request #4343:
URL: https://github.com/apache/nifi/pull/4343#issuecomment-648514384
Sorry about that. I didn't see your comment. I usually look for WIP or some
other indicator on this sort of thing.
markobean commented on pull request #4225:
URL: https://github.com/apache/nifi/pull/4225#issuecomment-648511269
The isA(flowFile.class) was in the original code and not added as part of
this PR. It's a mockito thing which I'm not quite following either. The point
of the verify() call in
joewitt commented on pull request #4225:
URL: https://github.com/apache/nifi/pull/4225#issuecomment-648445181
I dont quite follow the change to the test class. MOving from an Object[]
comparison to any string seems ok but the added isA(flowFile.class) I dont
follow.
The change in
M Tien created NIFI-7577:
Summary: Upgrade angular dependency
Key: NIFI-7577
URL: https://issues.apache.org/jira/browse/NIFI-7577
Project: Apache NiFi
Issue Type: Improvement
Components:
mtien-apache opened a new pull request #190:
URL: https://github.com/apache/nifi-minifi/pull/190
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
joewitt commented on pull request #4346:
URL: https://github.com/apache/nifi/pull/4346#issuecomment-648437572
I'd punt 0.9 and 0.10 for sure. I still run into 0.11 in the wild so prob
good to hang onto that a bit longer.
markobean commented on pull request #4225:
URL: https://github.com/apache/nifi/pull/4225#issuecomment-648433765
The API is not violated. As an example, the previously required array usage
of "new Object { foo, bar }" is still valid and no code changes are required.
However, it the new
MikeThomsen commented on pull request #4346:
URL: https://github.com/apache/nifi/pull/4346#issuecomment-648408135
We have 0.9, 0.10 and 0.11 in nifi-assembly. Are any of them worth keeping
in the convenience binary at this point vs moving them to profiles?
alopresto commented on pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#issuecomment-648405432
The compilation errors in the CI/CD checks are odd; the previous (non-merge
commit aee2fce) has all four checks passing.
alopresto commented on pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#issuecomment-648404789
@joewitt Any further comments on this PR?
This is an automated message from the Apache Git Service.
To respond
MikeThomsen commented on pull request #4225:
URL: https://github.com/apache/nifi/pull/4225#issuecomment-648355261
@joewitt @markap14 @alopresto do you concur with my take? If so, I'll close.
If not, I'm +1 to merge.
This is
joewitt commented on pull request #4346:
URL: https://github.com/apache/nifi/pull/4346#issuecomment-648355056
Kafka is a different animal. We should just dump an older nar from the
assembly but we should add a new Kafka 2.5 specific nar.
I'll review this as it gets closer to ready
MikeThomsen commented on pull request #4346:
URL: https://github.com/apache/nifi/pull/4346#issuecomment-648351851
Read over your Jira ticket, and updating the Kafka 2.X processors might make
more sense. We're running out of space in our convenience binary so it might be
a hard fit to have
MikeThomsen commented on pull request #4279:
URL: https://github.com/apache/nifi/pull/4279#issuecomment-648350854
I just verified on the latest master, and everything looks good. Going to
close the ticket. Feel free to reopen if you can post a screenshot and more
details showing what
MikeThomsen closed pull request #4279:
URL: https://github.com/apache/nifi/pull/4279
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
MikeThomsen commented on a change in pull request #4336:
URL: https://github.com/apache/nifi/pull/4336#discussion_r33577
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
##
@@
[
https://issues.apache.org/jira/browse/NIFI-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143190#comment-17143190
]
ASF subversion and git services commented on NIFI-7576:
---
Commit
markap14 closed pull request #4356:
URL: https://github.com/apache/nifi/pull/4356
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markap14 commented on pull request #4356:
URL: https://github.com/apache/nifi/pull/4356#issuecomment-648337836
Thanks for fixing this @Wastack ! All looks good to me. +1 merged to master.
This is an automated message from
[
https://issues.apache.org/jira/browse/NIFI-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143180#comment-17143180
]
ASF subversion and git services commented on NIFI-7523:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Bende updated NIFI-7523:
--
Fix Version/s: 1.12.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
>
[
https://issues.apache.org/jira/browse/NIFI-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143183#comment-17143183
]
ASF subversion and git services commented on NIFI-7523:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143184#comment-17143184
]
ASF subversion and git services commented on NIFI-7523:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143181#comment-17143181
]
ASF subversion and git services commented on NIFI-7523:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143185#comment-17143185
]
ASF subversion and git services commented on NIFI-7523:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143182#comment-17143182
]
ASF subversion and git services commented on NIFI-7523:
---
Commit
bbende merged pull request #4348:
URL: https://github.com/apache/nifi/pull/4348
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mtien-apache commented on a change in pull request #4344:
URL: https://github.com/apache/nifi/pull/4344#discussion_r17661
##
File path:
turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444397215
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/credstore/HadoopCredentialStore.java
##
@@ -0,0 +1,85 @@
+/*
+ *
turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444396485
##
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
##
@@
turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444393794
##
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/security/Kerberos.java
##
@@ -49,22
turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444392671
##
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
##
@@
turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444392671
##
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
##
@@
turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444391262
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/credstore/HadoopCredentialStore.java
##
@@ -0,0 +1,85 @@
+/*
+ *
turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444390888
##
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
##
@@
turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444389267
##
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
##
@@
arpadboda commented on a change in pull request #818:
URL: https://github.com/apache/nifi-minifi-cpp/pull/818#discussion_r444357215
##
File path: extensions/http-curl/tests/TestServer.h
##
@@ -24,65 +24,87 @@
#include "CivetServer.h"
#include "civetweb.h"
#include
[
https://issues.apache.org/jira/browse/MINIFICPP-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1268:
--
Description:
In our Windows builds, we currently use warning level /W1 (severe
Ferenc Gerlits created MINIFICPP-1268:
-
Summary: Turn on warnings in Windows builds, and fix them
Key: MINIFICPP-1268
URL: https://issues.apache.org/jira/browse/MINIFICPP-1268
Project: Apache NiFi
tpalfy commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444299023
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##
@@
tpalfy commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444296917
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##
@@
[
https://issues.apache.org/jira/browse/NIFI-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Makarov Vasiliy Nicolaevich reassigned NIFI-6603:
-
Assignee: Makarov Vasiliy Nicolaevich
> Variables: There is no
[
https://issues.apache.org/jira/browse/NIFI-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142942#comment-17142942
]
Otto Fowler commented on NIFI-7572:
---
would you want to return a new record rather than work on the
turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444237471
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/credstore/HadoopCredentialStore.java
##
@@ -0,0 +1,85 @@
+/*
+ *
bbende commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444230495
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/credstore/HadoopCredentialStore.java
##
@@ -0,0 +1,85 @@
+/*
+ *
arpadboda commented on a change in pull request #820:
URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r444227780
##
File path: extensions/http-curl/tests/C2DescribeCoreComponentStateTest.cpp
##
@@ -58,16 +57,11 @@ class VerifyC2DescribeCoreComponentState :
arpadboda commented on a change in pull request #820:
URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r444227780
##
File path: extensions/http-curl/tests/C2DescribeCoreComponentStateTest.cpp
##
@@ -58,16 +57,11 @@ class VerifyC2DescribeCoreComponentState :
[
https://issues.apache.org/jira/browse/NIFI-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142924#comment-17142924
]
Makarov Vasiliy Nicolaevich commented on NIFI-6603:
---
You can cancel it by "ESC" button.
tpalfy commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444222618
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/credstore/HadoopCredentialStore.java
##
@@ -0,0 +1,85 @@
+/*
+ *
markap14 commented on a change in pull request #4356:
URL: https://github.com/apache/nifi/pull/4356#discussion_r444222483
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
##
@@
markap14 commented on a change in pull request #4356:
URL: https://github.com/apache/nifi/pull/4356#discussion_r444220971
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
##
@@
hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444195397
##
File path: libminifi/test/script-tests/ExecutePythonProcessorTests.cpp
##
@@ -0,0 +1,220 @@
+/**
+ *
+ * Licensed to the Apache Software
Adam Hunyadi created MINIFICPP-1267:
---
Summary: Fix or decommission ConvertUpdate processor
Key: MINIFICPP-1267
URL: https://issues.apache.org/jira/browse/MINIFICPP-1267
Project: Apache NiFi MiNiFi
hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444195348
##
File path: extensions/script/python/ExecutePythonProcessor.h
##
@@ -18,12 +18,16 @@
* limitations under the License.
*/
-#ifndef
hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444194796
##
File path: extensions/script/python/ExecutePythonProcessor.cpp
##
@@ -35,155 +35,185 @@ namespace python {
namespace processors {
hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444194985
##
File path: extensions/script/python/ExecutePythonProcessor.cpp
##
@@ -35,155 +35,184 @@ namespace python {
namespace processors {
hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444192954
##
File path: libminifi/include/utils/TestUtils.h
##
@@ -0,0 +1,67 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444192521
##
File path: extensions/script/python/ExecutePythonProcessor.cpp
##
@@ -35,155 +35,184 @@ namespace python {
namespace processors {
arpadboda commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444189007
##
File path: extensions/script/python/ExecutePythonProcessor.h
##
@@ -18,12 +18,16 @@
* limitations under the License.
*/
-#ifndef
adam-markovics commented on a change in pull request #820:
URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r444186928
##
File path: extensions/http-curl/tests/C2DescribeCoreComponentStateTest.cpp
##
@@ -58,16 +57,11 @@ class
hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444186455
##
File path: extensions/script/python/ExecutePythonProcessor.h
##
@@ -18,12 +18,16 @@
* limitations under the License.
*/
-#ifndef
hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444186455
##
File path: extensions/script/python/ExecutePythonProcessor.h
##
@@ -18,12 +18,16 @@
* limitations under the License.
*/
-#ifndef
tpalfy commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444174839
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##
@@
tpalfy commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444174839
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##
@@
EvgenyTyurin commented on pull request #3987:
URL: https://github.com/apache/nifi/pull/3987#issuecomment-648103085
And what about BlobMessage support?
This is an automated message from the Apache Git Service.
To respond to
Wastack opened a new pull request #4356:
URL: https://github.com/apache/nifi/pull/4356
ListenHTTP processor now binds port and creates a HTTP connection only
if one of the following conditions apply:
- Primary node execution is 'false'
- Primary node execution is 'true' and
Tamás Bunth created NIFI-7576:
-
Summary: ListenHTTP processor does not honor "Primary node" only
Key: NIFI-7576
URL: https://issues.apache.org/jira/browse/NIFI-7576
Project: Apache NiFi
Issue
simonbence commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r443675238
##
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/security/Kerberos.java
##
@@ -49,22
turcsanyip commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444111607
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##
tpalfy commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444100867
##
File path:
tpalfy commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444100533
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##
@@
dvas0004 opened a new pull request #4355:
URL: https://github.com/apache/nifi/pull/4355
QueryElasticsearchHttp as it stands doesn't parse returned nested JSON
objects from the "_source" JSON object returned from Elasticsearch, resulting
in empty attributes in the flow file. The current
simonbence commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444009133
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##
fgerlits commented on a change in pull request #820:
URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r444037795
##
File path: extensions/http-curl/tests/C2DescribeCoreComponentStateTest.cpp
##
@@ -58,16 +57,11 @@ class VerifyC2DescribeCoreComponentState :
74 matches
Mail list logo
