[jira] [Commented] (NIFI-4410) PutElasticsearchHttp needs better error handling and logging

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219658#comment-16219658 ] ASF GitHub Bot commented on NIFI-4410: -- Github user MikeThomsen commented on the issue:

[GitHub] nifi issue #2175: NIFI-4410: Improved error handling/logging in PutElasticse...

2017-10-25 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2175 I actually had a bad batch go through, and it sent them out properly. What log settings need to be set in the configuration files to make sure I see your changes? ---

[GitHub] nifi issue #2175: NIFI-4410: Improved error handling/logging in PutElasticse...

2017-10-25 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2175 Before the fix, you would probably see a log statement for each failed doc. Also for some "not found" errors, such as maybe deleting a doc that doesn't exist? you would see an empty reason. The fix

[jira] [Commented] (NIFI-4410) PutElasticsearchHttp needs better error handling and logging

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219671#comment-16219671 ] ASF GitHub Bot commented on NIFI-4410: -- Github user mattyb149 commented on the issue:

[jira] [Commented] (NIFI-4410) PutElasticsearchHttp needs better error handling and logging

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219672#comment-16219672 ] ASF GitHub Bot commented on NIFI-4410: -- Github user mattyb149 commented on the issue:

[GitHub] nifi issue #2175: NIFI-4410: Improved error handling/logging in PutElasticse...

2017-10-25 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2175 If you need to raise the logging level, you can add that processor to logback.xml with a setting of INFO, otherwise you can change all processors to INFO with the following sed statement (works on

[GitHub] nifi-registry pull request #28: NIFIREG-44 Refactor integration test framewo...

2017-10-25 Thread kevdoran
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-registry/pull/28 NIFIREG-44 Refactor integration test framework and add secure tests You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (NIFI-4506) Add date functions to Record Path

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219622#comment-16219622 ] ASF GitHub Bot commented on NIFI-4506: -- Github user mattyb149 commented on a diff in the pull request:

[GitHub] nifi pull request #2221: NIFI-4506 Adding toDate and format functions to rec...

2017-10-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2221#discussion_r146999573 --- Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/paths/RecordPathCompiler.java --- @@ -346,4 +356,19 @@ private static

[GitHub] nifi-registry pull request #27: NIFIREG-43 Provide configurable extension di...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/27 ---

[jira] [Commented] (NIFIREG-43) Provide configurable extension directories

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219502#comment-16219502 ] ASF GitHub Bot commented on NIFIREG-43: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (NIFIREG-43) Provide configurable extension directories

2017-10-25 Thread Bryan Bende (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-43. Resolution: Fixed > Provide configurable extension directories >

[jira] [Created] (NIFI-4527) unable to get dynamicallyModifiesClasspath for PropertyDescriptor to work

2017-10-25 Thread Bob Whitehurst (JIRA)
Bob Whitehurst created NIFI-4527: Summary: unable to get dynamicallyModifiesClasspath for PropertyDescriptor to work Key: NIFI-4527 URL: https://issues.apache.org/jira/browse/NIFI-4527 Project:

[GitHub] nifi-minifi-cpp issue #154: MINIFICPP-265 Disabled fsanitize=address for now...

2017-10-25 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/154 looks good. ---

[jira] [Commented] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219748#comment-16219748 ] ASF GitHub Bot commented on MINIFICPP-265: -- Github user minifirocks commented on the issue:

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146848920 --- Diff: libminifi/src/processors/ExtractText.cpp --- @@ -0,0 +1,105 @@ +/** + * @file ExtractText.cpp + * ExtractText class

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146857720 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146857498 --- Diff: libminifi/src/processors/ExtractText.cpp --- @@ -0,0 +1,105 @@ +/** + * @file ExtractText.cpp + * ExtractText class

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218635#comment-16218635 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user phrocker commented on a diff in the pull

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218637#comment-16218637 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user phrocker commented on a diff in the pull

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146849052 --- Diff: libminifi/src/processors/ExtractText.cpp --- @@ -0,0 +1,105 @@ +/** + * @file ExtractText.cpp + * ExtractText class

[jira] [Assigned] (NIFI-4522) Add "SQL Statement" property to PutSQL

2017-10-25 Thread Matt Burgess (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-4522: -- Assignee: Matt Burgess > Add "SQL Statement" property to PutSQL >

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread calebj
GitHub user calebj opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/152 MINIFICPP-52 basic ExtractText processor Regex support blocked by dynamic properties, #37 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to

[jira] [Commented] (MINIFICPP-39) Create FocusArchive processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218551#comment-16218551 ] ASF GitHub Bot commented on MINIFICPP-39: - Github user phrocker commented on the issue:

[GitHub] nifi-minifi-cpp issue #148: MINIFI-244 Un/FocusArchive processors

2017-10-25 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/148 diff --git a/libminifi/src/processors/FocusArchiveEntry.cpp b/libminifi/src/processors/FocusArchiveEntry.cpp index c262217..42962a6 100644 ---

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218636#comment-16218636 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user phrocker commented on a diff in the pull

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218634#comment-16218634 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user phrocker commented on a diff in the pull

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218638#comment-16218638 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user phrocker commented on a diff in the pull

[jira] [Created] (NIFI-4524) ListHDFS should allow for glob patterns

2017-10-25 Thread Benjamin Garrett (JIRA)
Benjamin Garrett created NIFI-4524: -- Summary: ListHDFS should allow for glob patterns Key: NIFI-4524 URL: https://issues.apache.org/jira/browse/NIFI-4524 Project: Apache NiFi Issue Type:

[jira] [Commented] (MINIFICPP-39) Create FocusArchive processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218664#comment-16218664 ] ASF GitHub Bot commented on MINIFICPP-39: - Github user calebj commented on the issue:

[GitHub] nifi pull request #2225: NIFI-4522: Add SQL Statement property to PutSQL

2017-10-25 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2225 NIFI-4522: Add SQL Statement property to PutSQL Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi-minifi-cpp issue #148: MINIFI-244 Un/FocusArchive processors

2017-10-25 Thread calebj
Github user calebj commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/148 @phrocker Cool. I can squash into one commit and force push, if needed. ---

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218482#comment-16218482 ] ASF GitHub Bot commented on MINIFICPP-52: - GitHub user calebj opened a pull request:

[GitHub] nifi-minifi-cpp issue #148: MINIFI-244 Un/FocusArchive processors

2017-10-25 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/148 @calebj These failures are isolated to OSX. I noticed that travis isn't building your PRs to show you the build failure. I'll take a look to see why you aren't getting travis runs. My

[jira] [Commented] (MINIFICPP-263) Move libarchive functionality to an extension

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218521#comment-16218521 ] ASF GitHub Bot commented on MINIFICPP-263: -- GitHub user phrocker opened a pull request:

[jira] [Commented] (MINIFICPP-39) Create FocusArchive processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218607#comment-16218607 ] ASF GitHub Bot commented on MINIFICPP-39: - Github user calebj commented on the issue:

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146846580 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[jira] [Commented] (MINIFICPP-39) Create FocusArchive processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218657#comment-16218657 ] ASF GitHub Bot commented on MINIFICPP-39: - Github user phrocker commented on the issue:

[jira] [Commented] (NIFI-4510) ValidateRecord does not work properly with AvroRecordSetWriter

2017-10-25 Thread David Doran (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218401#comment-16218401 ] David Doran commented on NIFI-4510: --- Actually, it could be argued that the result I labelled "as

[GitHub] nifi-minifi-cpp issue #148: MINIFI-244 Un/FocusArchive processors

2017-10-25 Thread calebj
Github user calebj commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/148 I'm changing the types for size, mtime and mtime_nsec in `ArchiveEntryMetadata`'s declaration instead of casting. Why'd you take out the boost header include? ---

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread calebj
Github user calebj commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146861542 --- Diff: libminifi/src/processors/ExtractText.cpp --- @@ -0,0 +1,105 @@ +/** + * @file ExtractText.cpp + * ExtractText class

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218652#comment-16218652 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user calebj commented on a diff in the pull

[GitHub] nifi-minifi-cpp issue #148: MINIFI-244 Un/FocusArchive processors

2017-10-25 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/148 @calebj Ignore the boost removal, that was unrelated. This processor will be moved to an EXCLUDE_BOOST so that those who wish to exclude boost will not see this and other libarchive

[jira] [Commented] (MINIFICPP-39) Create FocusArchive processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218527#comment-16218527 ] ASF GitHub Bot commented on MINIFICPP-39: - Github user phrocker commented on the issue:

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218653#comment-16218653 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user calebj commented on a diff in the pull

[jira] [Commented] (MINIFICPP-39) Create FocusArchive processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218655#comment-16218655 ] ASF GitHub Bot commented on MINIFICPP-39: - Github user phrocker commented on the issue:

[GitHub] nifi-minifi-cpp issue #148: MINIFI-244 Un/FocusArchive processors

2017-10-25 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/148 @calebj thanks for the fix. Something in the way this PR is submitted is causing travis not to run as as result I"ll go through re-verification on all platforms and merge once I have an

[jira] [Created] (NIFIREG-44) Add integration tests for secure NiFi Registry

2017-10-25 Thread Kevin Doran (JIRA)
Kevin Doran created NIFIREG-44: -- Summary: Add integration tests for secure NiFi Registry Key: NIFIREG-44 URL: https://issues.apache.org/jira/browse/NIFIREG-44 Project: NiFi Registry Issue Type:

[GitHub] nifi pull request #2150: NIFI-3402: Added etag support to InvokeHTTP

2017-10-25 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2150#discussion_r146825133 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -439,6

[jira] [Commented] (NIFI-3402) Add ETag Support to InvokeHTTP

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218414#comment-16218414 ] ASF GitHub Bot commented on NIFI-3402: -- Github user MikeThomsen commented on a diff in the pull

[jira] [Commented] (NIFI-3402) Add ETag Support to InvokeHTTP

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218416#comment-16218416 ] ASF GitHub Bot commented on NIFI-3402: -- Github user MikeThomsen commented on a diff in the pull

[GitHub] nifi pull request #2150: NIFI-3402: Added etag support to InvokeHTTP

2017-10-25 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2150#discussion_r146825326 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -669,6

[GitHub] nifi pull request #2150: NIFI-3402: Added etag support to InvokeHTTP

2017-10-25 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2150#discussion_r146825541 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -370,6

[jira] [Commented] (NIFI-3402) Add ETag Support to InvokeHTTP

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218415#comment-16218415 ] ASF GitHub Bot commented on NIFI-3402: -- Github user MikeThomsen commented on a diff in the pull

[GitHub] nifi-minifi-cpp pull request #153: MINIFICPP-263: Move merge content to an e...

2017-10-25 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/153 MINIFICPP-263: Move merge content to an extension. Also remove circul… …ar dependencies MINIFICPP-263: Remove boost deps by updating yaml-cpp MINIFICPP-263: Resolve

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread calebj
Github user calebj commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146861365 --- Diff: libminifi/src/processors/ExtractText.cpp --- @@ -0,0 +1,105 @@ +/** + * @file ExtractText.cpp + * ExtractText class

[jira] [Updated] (NIFI-4522) Add "SQL Statement" property to PutSQL

2017-10-25 Thread Matt Burgess (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-4522: --- Status: Patch Available (was: In Progress) > Add "SQL Statement" property to PutSQL >

[jira] [Commented] (NIFI-4522) Add "SQL Statement" property to PutSQL

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218666#comment-16218666 ] ASF GitHub Bot commented on NIFI-4522: -- GitHub user mattyb149 opened a pull request:

[jira] [Commented] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218832#comment-16218832 ] ASF GitHub Bot commented on MINIFICPP-265: -- Github user achristianson commented on the issue:

[GitHub] nifi pull request #2220: NIFI-2979 PriorityAttributePrioritizer violates Com...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2220 ---

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146897196 --- Diff: libminifi/test/unit/ExtractTextTest.cpp --- @@ -0,0 +1,101 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] nifi-minifi-cpp issue #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/152 @calebj Thanks for updating all this, adding the test, and opening the PR. Overall looks good, mostly stylistic/idiom issues due to the style I was using at the time. ---

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218913#comment-16218913 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on the issue:

[GitHub] nifi issue #2220: NIFI-2979 PriorityAttributePrioritizer violates Comparator...

2017-10-25 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2220 Agreed, great catch! +1 merged to master. Thanks for the contribution! ---

[jira] [Commented] (NIFI-3453) Provenance Events dont have the "relationship" from where the event came

2017-10-25 Thread Joseph Witt (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218957#comment-16218957 ] Joseph Witt commented on NIFI-3453: --- Ok thanks Scott. The thing is the connection identifier is only

[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-25 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 @apiri @phrocker fix the test cast, change size and offset signature to uint6_t, it looks like travis passed. please review ---

[jira] [Commented] (MINIFICPP-264) Implement CompressContent Processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218972#comment-16218972 ] ASF GitHub Bot commented on MINIFICPP-264: -- Github user minifirocks commented on the issue:

[GitHub] nifi-minifi-cpp issue #154: MINIFICPP-265 Disabled fsanitize=address for now...

2017-10-25 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/154 Fixed. Ready for review/merge now. ---

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218880#comment-16218880 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146891895 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146897792 --- Diff: libminifi/test/unit/ExtractTextTest.cpp --- @@ -0,0 +1,101 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146897535 --- Diff: libminifi/test/unit/ExtractTextTest.cpp --- @@ -0,0 +1,101 @@ +/** + * + * Licensed to the Apache Software Foundation

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218910#comment-16218910 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Created] (NIFI-4526) The REST API and NiFi UI should allow the target URL for a remote process group to be edited

2017-10-25 Thread Joseph Witt (JIRA)
Joseph Witt created NIFI-4526: - Summary: The REST API and NiFi UI should allow the target URL for a remote process group to be edited Key: NIFI-4526 URL: https://issues.apache.org/jira/browse/NIFI-4526

[jira] [Commented] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218829#comment-16218829 ] ASF GitHub Bot commented on MINIFICPP-265: -- GitHub user achristianson opened a pull request:

[GitHub] nifi-minifi-cpp pull request #154: MINIFICPP-265 Disabled fsanitize=address ...

2017-10-25 Thread achristianson
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/154 MINIFICPP-265 Disabled fsanitize=address for now, due to overly-verbo… …se log messages. This may be re-enabled in a more controlled fashion later on. Thank you for

[jira] [Commented] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218849#comment-16218849 ] ASF GitHub Bot commented on MINIFICPP-265: -- Github user achristianson commented on the issue:

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146891117 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146898758 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[jira] [Commented] (NIFI-2979) PriorityAttributePrioritizer violates Comparator contract

2017-10-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218899#comment-16218899 ] ASF subversion and git services commented on NIFI-2979: --- Commit

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218995#comment-16218995 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146912119 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[jira] [Created] (NIFI-4525) Provide option to "Create Diagnostics Report" or "Run Diagnostics" for a processor

2017-10-25 Thread Mark Payne (JIRA)
Mark Payne created NIFI-4525: Summary: Provide option to "Create Diagnostics Report" or "Run Diagnostics" for a processor Key: NIFI-4525 URL: https://issues.apache.org/jira/browse/NIFI-4525 Project:

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146876835 --- Diff: libminifi/src/processors/ExtractText.cpp --- @@ -0,0 +1,105 @@ +/** + * @file ExtractText.cpp + * ExtractText class

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218751#comment-16218751 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (NIFI-4410) PutElasticsearchHttp needs better error handling and logging

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218777#comment-16218777 ] ASF GitHub Bot commented on NIFI-4410: -- Github user mattyb149 commented on the issue:

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218884#comment-16218884 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218885#comment-16218885 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218902#comment-16218902 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (NIFI-2979) PriorityAttributePrioritizer violates Comparator contract

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218901#comment-16218901 ] ASF GitHub Bot commented on NIFI-2979: -- Github user asfgit closed the pull request at:

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218909#comment-16218909 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218764#comment-16218764 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146877256 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[jira] [Commented] (NIFI-3402) Add ETag Support to InvokeHTTP

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218823#comment-16218823 ] ASF GitHub Bot commented on NIFI-3402: -- Github user m-hogue commented on the issue:

[GitHub] nifi issue #2150: NIFI-3402: Added etag support to InvokeHTTP

2017-10-25 Thread m-hogue
Github user m-hogue commented on the issue: https://github.com/apache/nifi/pull/2150 Thanks for the review, @MikeThomsen! I agree & I'll make all of these changes. ---

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218877#comment-16218877 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146891271 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread calebj
Github user calebj commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146907747 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class declaration

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218963#comment-16218963 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user calebj commented on a diff in the pull

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218873#comment-16218873 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

  1   2   >