[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375296#comment-15375296 ] Till Rohrmann commented on FLINK-4152: -- [~mxm]The restarted registration attempts are the observable

[jira] [Comment Edited] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375296#comment-15375296 ] Till Rohrmann edited comment on FLINK-4152 at 7/13/16 4:24 PM: --- The

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375360#comment-15375360 ] ASF GitHub Bot commented on FLINK-4197: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2234: [hotfix][kinesis-connector] Remove duplicate info ...

2016-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4206) Metric names should allow special characters

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375377#comment-15375377 ] ASF GitHub Bot commented on FLINK-4206: --- Github user rmetzger commented on the issue:

[jira] [Resolved] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-4197. --- Resolution: Fixed Assignee: Scott Kidder Fix Version/s: (was: 1.0.4)

[jira] [Commented] (FLINK-3466) Job might get stuck in restoreState() from HDFS due to interrupt

2016-07-13 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375397#comment-15375397 ] Stephan Ewen commented on FLINK-3466: - Here is a Unit test that minimally reproduces getting stuck in

[GitHub] flink issue #2234: [hotfix][kinesis-connector] Remove duplicate info in Kine...

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2234 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2239: [FLINK-4208] Support Running Flink processes in foregroun...

2016-07-13 Thread iemejia
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2239 Hi, Yes, this is exactly the situation, in a previous pull request I was optimizing the flink docker image, however I found that the image used supervisord to catch and keep alive those daemons, so

[jira] [Created] (FLINK-4212) Lock on pid file when starting daemons

2016-07-13 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4212: - Summary: Lock on pid file when starting daemons Key: FLINK-4212 URL: https://issues.apache.org/jira/browse/FLINK-4212 Project: Flink Issue Type: Improvement

[GitHub] flink issue #2237: [FLINK-4206][metrics] Remove alphanumeric name restrictio...

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2237 I stumbled across this and I found the limitation quite annoying, so if there are no good reasons for the check, I agree to remove it. Since @StephanEwen wrote this, it might be good if he could

[GitHub] flink issue #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis connecte...

2016-07-13 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2228 Rebased again on the new endpoint config merged in https://github.com/apache/flink/pull/2227. This PR should be ready for a final review now. --- If your project is set up for it, you can

[GitHub] flink pull request #2243: [FLINK-4196] [runtime] Remove recovery timestamp f...

2016-07-13 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/2243 [FLINK-4196] [runtime] Remove recovery timestamp from checkpoint restores The 'recoveryTimestamp' was an unsafe wall clock timestamp attached by the master upon recovery. Because this timestamp

[jira] [Commented] (FLINK-4196) Remove "recoveryTimestamp"

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375630#comment-15375630 ] ASF GitHub Bot commented on FLINK-4196: --- GitHub user StephanEwen opened a pull request:

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375530#comment-15375530 ] ASF GitHub Bot commented on FLINK-2125: --- Github user delding commented on the issue:

[GitHub] flink issue #2233: [FLINK-2125][streaming] Delimiter change from char to str...

2016-07-13 Thread delding
Github user delding commented on the issue: https://github.com/apache/flink/pull/2233 Hi @zentol , thanks for your comments. I have updated this PR. Please let me know if there are further improvements that need to be done. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request #2242: ExceptionHandler keep count of exceptions

2016-07-13 Thread sumitchawla
GitHub user sumitchawla opened a pull request: https://github.com/apache/flink/pull/2242 ExceptionHandler keep count of exceptions This is just a bug identified while going through exception handler. There is no JIRA ticket for this. You can merge this pull request into a Git

[jira] [Commented] (FLINK-4170) Remove `CONFIG_` prefix from KinesisConfigConstants variables

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375464#comment-15375464 ] ASF GitHub Bot commented on FLINK-4170: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-4206) Metric names should allow special characters

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375505#comment-15375505 ] ASF GitHub Bot commented on FLINK-4206: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2237: [FLINK-4206][metrics] Remove alphanumeric name restrictio...

2016-07-13 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2237 Actually, I just wrote a more efficient version of a check that was there before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376126#comment-15376126 ] ASF GitHub Bot commented on FLINK-3477: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1517 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Closed] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-07-13 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-3477. - Resolution: Implemented Implemented in 52e191a5067322e82192314c16e70ae9e937ae2c > Add hash-based combine

[jira] [Closed] (FLINK-2246) Add chained combine driver strategy for ReduceFunction

2016-07-13 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-2246. - Resolution: Implemented Implemented in 0db804b936efd8631f1a08db37753dad7f1f71ea > Add chained combine

[jira] [Created] (FLINK-4213) Provide CombineHint in Gelly algorithms

2016-07-13 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4213: - Summary: Provide CombineHint in Gelly algorithms Key: FLINK-4213 URL: https://issues.apache.org/jira/browse/FLINK-4213 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-13 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374568#comment-15374568 ] Aljoscha Krettek commented on FLINK-4190: - What you could also do is create a new package and put

[jira] [Created] (FLINK-4205) Implement stratified sampling for DataSet

2016-07-13 Thread Do Le Quoc (JIRA)
Do Le Quoc created FLINK-4205: - Summary: Implement stratified sampling for DataSet Key: FLINK-4205 URL: https://issues.apache.org/jira/browse/FLINK-4205 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-1501) Integrate metrics library and report basic metrics to JobManager web interface

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374538#comment-15374538 ] ASF GitHub Bot commented on FLINK-1501: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #421: [FLINK-1501] Add metrics library for monitoring TaskManage...

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/421 @sumitchawla: These charts have been removed from the TaskManager view due to licensing issues. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #2234: [hotfix][kinesis-connector] Remove duplicate info ...

2016-07-13 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/2234 [hotfix][kinesis-connector] Remove duplicate info in KinesisDeserializationSchema The duplicate was added in https://github.com/apache/flink/pull/2225. `byte[] recordKey` and `String

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-13 Thread Josh Forman-Gornall (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374589#comment-15374589 ] Josh Forman-Gornall commented on FLINK-4190: Ok I'll do that. Can you see any issues with the

[jira] [Comment Edited] (FLINK-4194) KinesisDeserializationSchema.isEndOfStream() is never called

2016-07-13 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374453#comment-15374453 ] Tzu-Li (Gordon) Tai edited comment on FLINK-4194 at 7/13/16 6:34 AM: -

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2219#discussion_r70584088 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {

[GitHub] flink issue #2225: [FLINK-4191] Expose shard information in kinesis deserial...

2016-07-13 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2225 Just realized that the `byte[] recordKey` and `String partitionKey` are actually the same only in different form, so now we have duplicate info in the deser schema. I think we can keep the `String`

[jira] [Commented] (FLINK-4191) Expose shard information in KinesisDeserializationSchema

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374528#comment-15374528 ] ASF GitHub Bot commented on FLINK-4191: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #421: [FLINK-1501] Add metrics library for monitoring TaskManage...

2016-07-13 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/421 Yes, per default metrics are published via the JMX. But you can also configure a Ganglia, Graphite or StatsD reporter. On Tue, Jul 12, 2016 at 12:02 AM, Sumit Chawla

[jira] [Commented] (FLINK-1501) Integrate metrics library and report basic metrics to JobManager web interface

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374533#comment-15374533 ] ASF GitHub Bot commented on FLINK-1501: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-4194) KinesisDeserializationSchema.isEndOfStream() is never called

2016-07-13 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374453#comment-15374453 ] Tzu-Li (Gordon) Tai commented on FLINK-4194: [~rmetzger] Hi Robert, I can take care of this if

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2219#discussion_r70577752 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {

[jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374541#comment-15374541 ] ASF GitHub Bot commented on FLINK-4143: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-4196) Remove "recoveryTimestamp"

2016-07-13 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374566#comment-15374566 ] Aljoscha Krettek commented on FLINK-4196: - +1, I think this was introduced for the DB backend. >

[GitHub] flink pull request #2235: [hotfix] removed duplicated code

2016-07-13 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/2235 [hotfix] removed duplicated code You can merge this pull request into a Git repository by running: $ git pull https://github.com/StefanRRichter/flink

[jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374594#comment-15374594 ] ASF GitHub Bot commented on FLINK-4143: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4170) Remove `CONFIG_` prefix from KinesisConfigConstants variables

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374595#comment-15374595 ] ASF GitHub Bot commented on FLINK-4170: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis connecte...

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2228 I think there was an issue with Github and travis: https://www.traviscistatus.com/incidents/t4xn7bmq7fww --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375658#comment-15375658 ] ASF GitHub Bot commented on FLINK-3477: --- Github user greghogan commented on the issue:

[GitHub] flink issue #2244: [FLINK-3874] Add a Kafka TableSink with JSON serializatio...

2016-07-13 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2244 I tried to inherit TableSink trait in Java code but it seems that it is impossible to inherit traits with vars in Java, therefor I had to change class structures there somewhat. --- If your

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375822#comment-15375822 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on the issue:

[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

2016-07-13 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1517 CI tests are passing. I've been testing Gelly algorithms with this without error. I will merge this ... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request #2244: Kafka json

2016-07-13 Thread mushketyk
GitHub user mushketyk opened a pull request: https://github.com/apache/flink/pull/2244 Kafka json Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into

[jira] [Updated] (FLINK-4214) JobExceptionsHandler will return all exceptions

2016-07-13 Thread Sumit Chawla (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumit Chawla updated FLINK-4214: Priority: Minor (was: Major) > JobExceptionsHandler will return all exceptions >

[GitHub] flink issue #1813: [FLINK-3034] Redis Sink Connector

2016-07-13 Thread subhankarb
Github user subhankarb commented on the issue: https://github.com/apache/flink/pull/1813 Hi @kl0u, IMO that is the expected behavior. The sink would not know that if the Redis is down or not unless it tries to send the next data to the Redis. When ever a new message reaches the sink

[jira] [Commented] (FLINK-4214) JobExceptionsHandler will return all exceptions

2016-07-13 Thread Sumit Chawla (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376269#comment-15376269 ] Sumit Chawla commented on FLINK-4214: - Change added in https://github.com/apache/flink/pull/2242 >

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376320#comment-15376320 ] ASF GitHub Bot commented on FLINK-3034: --- Github user subhankarb commented on the issue:

[jira] [Created] (FLINK-4214) JobExceptionsHandler will return all exceptions

2016-07-13 Thread Sumit Chawla (JIRA)
Sumit Chawla created FLINK-4214: --- Summary: JobExceptionsHandler will return all exceptions Key: FLINK-4214 URL: https://issues.apache.org/jira/browse/FLINK-4214 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-4127) Clean up configuration and check breaking API changes

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374609#comment-15374609 ] ASF GitHub Bot commented on FLINK-4127: --- Github user asfgit closed the pull request at:

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 This will simplify this PR: https://issues.apache.org/jira/browse/FLINK-4206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374618#comment-15374618 ] ASF GitHub Bot commented on FLINK-4186: --- GitHub user rmetzger opened a pull request:

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70589875 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java --- @@

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70591165 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java --- @@

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70591328 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java ---

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374677#comment-15374677 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70591698 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java ---

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374684#comment-15374684 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70591835 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374683#comment-15374683 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374700#comment-15374700 ] ASF GitHub Bot commented on FLINK-4143: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2219#discussion_r70592983 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {

[GitHub] flink pull request #2210: [FLINK-4167] [metrics] Close IOMetricGroup in Task...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2210#discussion_r70597751 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/groups/ProxyMetricGroup.java --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374763#comment-15374763 ] ASF GitHub Bot commented on FLINK-4184: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-4167) TaskMetricGroup does not close IOMetricGroup

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374764#comment-15374764 ] ASF GitHub Bot commented on FLINK-4167: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4167) TaskMetricGroup does not close IOMetricGroup

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374776#comment-15374776 ] ASF GitHub Bot commented on FLINK-4167: --- Github user zentol commented on the issue:

[GitHub] flink issue #2210: [FLINK-4167] [metrics] Close IOMetricGroup in TaskMetricG...

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2210 Only had a small comment, otherwise +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Updated] (FLINK-4207) WindowOperator becomes very slow with allowed lateness

2016-07-13 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-4207: Priority: Blocker (was: Major) > WindowOperator becomes very slow with allowed lateness >

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374642#comment-15374642 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on the issue:

[GitHub] flink pull request #2237: [FLINK-4206][metrics] Remove alphanumeric name res...

2016-07-13 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2237 [FLINK-4206][metrics] Remove alphanumeric name restriction You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 4206_me_so_special

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2236 You can rebase on top of #2237. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-4206) Metric names should allow special characters

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374641#comment-15374641 ] ASF GitHub Bot commented on FLINK-4206: --- GitHub user zentol opened a pull request:

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374654#comment-15374654 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-13 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/2219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (FLINK-3729) Several SQL tests fail on Windows OS

2016-07-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-3729: --- Assignee: Chesnay Schepler > Several SQL tests fail on Windows OS >

[jira] [Commented] (FLINK-4167) TaskMetricGroup does not close IOMetricGroup

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374597#comment-15374597 ] ASF GitHub Bot commented on FLINK-4167: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #2235: [hotfix] removed duplicated code

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2235 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (FLINK-4127) Clean up configuration and check breaking API changes

2016-07-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-4127. --- Resolution: Fixed Merged in http://git-wip-us.apache.org/repos/asf/flink/commit/6b7bb761 >

[jira] [Created] (FLINK-4206) Metric names should alle special characters

2016-07-13 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-4206: --- Summary: Metric names should alle special characters Key: FLINK-4206 URL: https://issues.apache.org/jira/browse/FLINK-4206 Project: Flink Issue Type:

[jira] [Created] (FLINK-4207) WindowOperator becomes very slow with allowed lateness

2016-07-13 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-4207: --- Summary: WindowOperator becomes very slow with allowed lateness Key: FLINK-4207 URL: https://issues.apache.org/jira/browse/FLINK-4207 Project: Flink

[jira] [Commented] (FLINK-4159) Quickstart poms exclude unused dependencies

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374721#comment-15374721 ] ASF GitHub Bot commented on FLINK-4159: --- Github user zentol closed the pull request at:

[GitHub] flink issue #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2219 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Closed] (FLINK-4159) Quickstart poms exclude unused dependencies

2016-07-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-4159. --- Resolution: Fixed Fixed in 90658c8383efef1e3330cf8bd2ca327d1b55baf4 > Quickstart poms

[jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374733#comment-15374733 ] ASF GitHub Bot commented on FLINK-4143: --- Github user zentol closed the pull request at:

[jira] [Closed] (FLINK-4143) Configurable delimiter for metric identifier

2016-07-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-4143. --- Resolution: Fixed Implemented in 790a654c5e08e0e54f3e02499be4dd8c4006227a > Configurable

[jira] [Commented] (FLINK-3704) JobManagerHAProcessFailureBatchRecoveryITCase.testJobManagerProcessFailure unstable

2016-07-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374601#comment-15374601 ] Robert Metzger commented on FLINK-3704: --- Once again:

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2236 [FLINK-4186] Use Flink metrics to report Kafka metrics We were using Flink's accumulators in the past to report the Kafka metrics. With this change, we'll use the new metrics of Flink.

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70590934 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java --- @@

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374673#comment-15374673 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4167) TaskMetricGroup does not close IOMetricGroup

2016-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374689#comment-15374689 ] ASF GitHub Bot commented on FLINK-4167: --- Github user tillrohrmann commented on the issue:

[GitHub] flink pull request #2230: [FLINK-4200] [Kafka Connector] Kafka consumers log...

2016-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2210: [FLINK-4167] [metrics] Close IOMetricGroup in TaskMetricG...

2016-07-13 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2210 I've addressed your comments @zentol and introduced a `ProxyMetricGroup` which simply forwards all calls as you've suggested. --- If your project is set up for it, you can reply to this email

  1   2   >