subject:"\[jira\] \[Commented\] $HBASE\-5443$ Add PB\-based calls to HRegionInterface"

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-23 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260260#comment-13260260
 ] 

Hudson commented on HBASE-5443:
---

Integrated in HBase-TRUNK-security #182 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/182/])
HBASE-5443 Convert admin protocol of HRegionInterface to PB (Revision 
1329358)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java
* 
/hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/SortedCopyOnWriteSet.java
* /hbase/trunk/src/main/protobuf/Admin.proto
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java


> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-23 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259890#comment-13259890
 ] 

Hudson commented on HBASE-5443:
---

Integrated in HBase-TRUNK #2799 (See 
[https://builds.apache.org/job/HBase-TRUNK/2799/])
HBASE-5443 Convert admin protocol of HRegionInterface to PB (Revision 
1329358)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java
* 
/hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/SortedCopyOnWriteSet.java
* /hbase/trunk/src/main/protobuf/Admin.proto
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java


> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-13 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254000#comment-13254000
 ] 

Hudson commented on HBASE-5443:
---

Integrated in HBase-TRUNK-security #171 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/171/])
HBASE-5443 Convert the client protocol of HRegionInterface to PB (Revision 
1325937)

 Result = FAILURE
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionAdminProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionClientProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Leases.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java
* /hbase/trunk/src/main/protobuf/Admin.proto
* /hbase/trunk/src/main/protobuf/Client.proto
* /hbase/trunk/src/main/protobuf/RegionAdmin.proto
* /hbase/trunk/src/main/protobuf/RegionClient.proto
* /hbase/trunk/src/main/protobuf/hbase.proto
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java


> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-13 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253767#comment-13253767
 ] 

Hudson commented on HBASE-5443:
---

Integrated in HBase-TRUNK #2755 (See 
[https://builds.apache.org/job/HBase-TRUNK/2755/])
HBASE-5443 Convert the client protocol of HRegionInterface to PB (Revision 
1325937)

 Result = FAILURE
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionAdminProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionClientProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Leases.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java
* /hbase/trunk/src/main/protobuf/Admin.proto
* /hbase/trunk/src/main/protobuf/Client.proto
* /hbase/trunk/src/main/protobuf/RegionAdmin.proto
* /hbase/trunk/src/main/protobuf/RegionClient.proto
* /hbase/trunk/src/main/protobuf/hbase.proto
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java


> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-04 Thread binlijin (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246138#comment-13246138
 ] 

binlijin commented on HBASE-5443:
-

@Jimmy Xiang  and @stack , 
Thank you very much!

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-02 Thread stack (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244522#comment-13244522
 ] 

stack commented on HBASE-5443:
--

There is also this write up of Todd's on why pb in first place over in hdfs: 
https://issues.apache.org/jira/browse/HDFS-2058?focusedCommentId=13047289&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13047289

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-01 Thread Jimmy Xiang (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243954#comment-13243954
 ] 

Jimmy Xiang commented on HBASE-5443:


The main reason is that the HBase writable RPC already supports pb.  Hadoop 
uses pb too.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-01 Thread binlijin (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243950#comment-13243950
 ] 

binlijin commented on HBASE-5443:
-

Hi guys,i have some question, why choose pb? why not avro or thrift?

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-01 Thread binlijin (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243949#comment-13243949
 ] 

binlijin commented on HBASE-5443:
-

Hi guys,i have some question, why choose pb? why not avro or thrift?

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-01 Thread binlijin (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243948#comment-13243948
 ] 

binlijin commented on HBASE-5443:
-

Hi guys,i have some question, why choose pb? why not avro or thrift?

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-30 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243036#comment-13243036
 ] 

Hudson commented on HBASE-5443:
---

Integrated in HBase-TRUNK-security #155 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/155/])
HBASE-5443 Create PB protocols for HRegionInterface (Revision 1307625)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionAdminProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionClientProtos.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/package.html
* /hbase/trunk/src/main/protobuf
* /hbase/trunk/src/main/protobuf/README.txt
* /hbase/trunk/src/main/protobuf/RegionAdmin.proto
* /hbase/trunk/src/main/protobuf/RegionClient.proto
* /hbase/trunk/src/main/protobuf/hbase.proto


> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-30 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242824#comment-13242824
 ] 

Hudson commented on HBASE-5443:
---

Integrated in HBase-TRUNK #2701 (See 
[https://builds.apache.org/job/HBase-TRUNK/2701/])
HBASE-5443 Create PB protocols for HRegionInterface (Revision 1307625)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionAdminProtos.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionClientProtos.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/package.html
* /hbase/trunk/src/main/protobuf
* /hbase/trunk/src/main/protobuf/README.txt
* /hbase/trunk/src/main/protobuf/RegionAdmin.proto
* /hbase/trunk/src/main/protobuf/RegionClient.proto
* /hbase/trunk/src/main/protobuf/hbase.proto


> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-22 Thread Jimmy Xiang (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235780#comment-13235780
 ] 

Jimmy Xiang commented on HBASE-5443:


I have done some code changes, and some tests failed.  It is very hard to look 
into them.  So I'd like to break it into small pieces and tag them one by one.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221238#comment-13221238
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--

bq.  On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq.  > pom.xml, line 750
bq.  > 
bq.  >
bq.  > Do this instead:
bq.  > 
bq.  >   if which cygpath >/dev/null 2>/dev/null; then
bq.  > # Windows
bq.  >   else
bq.  > # Not Windows
bq.  >   fi

Why do we need /dev/null twice?

bq.  On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq.  > pom.xml, line 761
bq.  > 
bq.  >
bq.  > Actually you can just remove the whole $IS_WIN business and 
everything.  Simply fix PROTO_DIR and JAVA_DIR when on Windows before calling 
protoc.

How about this?  The reason for I_PROTO_DIR is to keep "ls $PROTO_DIR/*.proto" 
working.

if which cygpath 2> /dev/null; then
  I_PROTO_DIR=$PROTO_DIR
else
  I_PROTO_DIR=`cygpath --windows $PROTO_DIR`
  JAVA_DIR=`cygpath --windows $JAVA_DIR`
fi
mkdir -p $JAVA_DIR 2> /dev/null
for PROTO_FILE in `ls $PROTO_DIR/*.proto 2> /dev/null`
do
  protoc -I$I_PROTO_DIR --java_out=$JAVA_DIR $PROTO_FILE
done

- Jimmy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5552
---

On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  ---
bq.  
bq.  (Updated 2012-03-02 18:54:29)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The 
corresponding java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.  https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.pom.xml bb518b1 
bq.src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.src/main/proto/RegionClient.proto PRE-CREATION 
bq.src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221231#comment-13221231
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--

bq.  On 2012-03-02 20:07:30, Gregory Chanan wrote:
bq.  > src/main/proto/hbase.proto, line 23
bq.  > 
bq.  >
bq.  > You don't have "option optimize_for = SPEED;" here.

will add.

bq.  On 2012-03-02 20:07:30, Gregory Chanan wrote:
bq.  > src/main/proto/RegionAdmin.proto, line 22
bq.  > 
bq.  >
bq.  > If we are getting rid of "Proto" in the message names, might as well 
get rid of it here too.

This one, I am not sure?

- Jimmy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5583
---

On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  ---
bq.  
bq.  (Updated 2012-03-02 18:54:29)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The 
corresponding java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.  https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.pom.xml bb518b1 
bq.src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.src/main/proto/RegionClient.proto PRE-CREATION 
bq.src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221228#comment-13221228
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5583
---

src/main/proto/RegionAdmin.proto

If we are getting rid of "Proto" in the message names, might as well get 
rid of it here too.

src/main/proto/RegionClient.proto

Here too.

src/main/proto/hbase.proto

Here too.

src/main/proto/hbase.proto

You don't have "option optimize_for = SPEED;" here.

- Gregory

On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  ---
bq.  
bq.  (Updated 2012-03-02 18:54:29)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The 
corresponding java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.  https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.pom.xml bb518b1 
bq.src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.src/main/proto/RegionClient.proto PRE-CREATION 
bq.src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221221#comment-13221221
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--

bq.  On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq.  > src/main/proto/RegionClient.proto, line 112
bq.  > 
bq.  >
bq.  > trailing whitespaces

Will remove it.

bq.  On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq.  > pom.xml, line 764
bq.  > 
bq.  >
bq.  > You didn't take into account my comments on fixing this shell 
scripting from the previous iteration.

Sorry. I forgot it.  Good idea.  I will address it in the next diff.

bq.  On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq.  > src/main/proto/hbase.proto, line 64
bq.  > 
bq.  >
bq.  > I still don't understand how these can be optional.

Ok, I can make family and qualifier required.

bq.  On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq.  > src/main/proto/RegionClient.proto, line 147
bq.  > 
bq.  >
bq.  > I don't know if we should let the client specify the TTL.  Right now 
in HBase the TTL is hardcoded in the Configuration object of the RegionServer.
bq.  > 
bq.  > Actually I'm fine with allowing clients specify their own TTL as 
long as we bound the TTL with the servers' Configuration.

I see.  I will remove it.  We can add it back if server supports it later on.

How about lockRow?  Does the server support client specified TTL?

bq.  On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq.  > src/main/proto/RegionClient.proto, line 63
bq.  > 
bq.  >
bq.  > So a Get request can only fetch multiple Get from a single Region?  
That's not good.  We need true multi-get, where you can fetch things from 
multiple regions on the same RegionServer at once.

I can move the region to Get.  That means each Get need to specify a region, so 
it can be duplicated.  Another option is to add another message like GetGroup 
which has a region and a set of Gets.

One more option is to make region optional in the request, and add an optional 
region to Get.  The region in GetRequest will be used if there is no region 
specified in Get.

What do you think?

- Jimmy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5573
---

On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  ---
bq.  
bq.  (Updated 2012-03-02 18:54:29)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The 
corresponding java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.  https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.pom.xml bb518b1 
bq.src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.src/main/proto/RegionClient.proto PRE-CREATION 
bq.src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221218#comment-13221218
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--

bq.  On 2012-03-02 19:31:46, Jimmy Xiang wrote:
bq.  > This is another option for scan.  This way, we will have only one scan 
method, no need to open/next/close.
bq.  > 
bq.  > Which one do you prefer?  In the ScanRequest, either scannerId or scan 
must be specified, not both.
bq.  > 
bq.  > message Scan {
bq.  >   required RegionSpecifier region = 1;
bq.  >   repeated Column column = 2;
bq.  >   repeated Attribute attribute = 3;
bq.  >   optional bytes startRow = 4;
bq.  >   optional bytes stopRow = 5;
bq.  >   optional string filterName = 6;
bq.  >   optional TimeRange timeRange = 7;
bq.  >   optional uint32 maxVersions = 8 [default = 1];
bq.  >   optional bool cacheBlocks = 9 [default = true];
bq.  >   optional uint32 rowsToCache = 10;
bq.  >   optional uint32 batchSize = 11;
bq.  > }
bq.  > 
bq.  > message ScanRequest {
bq.  >   optional uint64 scannerId = 1;
bq.  >   optional Scan scan = 2;
bq.  >   optional uint32 numberOfRows = 3;
bq.  >   optional bool closeScanner = 4;
bq.  >   optional uint32 ttl = 5;
bq.  > }
bq.  > 
bq.  > message ScanResponse {
bq.  >   repeated Result result = 1;
bq.  >   optional uint64 scannerId = 2;
bq.  >   optional bool moreResults = 3;
bq.  >   optional uint32 ttl = 4;
bq.  > }
bq.  >
bq.  
bq.  Michael Stack wrote:
bq.  So we would do away with openScanner,  next, and close, just do scan?  
Inside in the ScanRequest, we'd carry over the Scan specification each time?  
We'd be able to honor the current openScanner, next, close client-facing API 
but could add a new scan method to the public api that allowed passing the 
above specifications?  Sounds good.

The only issue is that both optional.  They need to know to specify one. From 
documentation?

- Jimmy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5575
---

On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  ---
bq.  
bq.  (Updated 2012-03-02 18:54:29)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The 
corresponding java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.  https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.pom.xml bb518b1 
bq.src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.src/main/proto/RegionClient.proto PRE-CREATION 
bq.src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221198#comment-13221198
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--

bq.  On 2012-03-02 19:31:46, Jimmy Xiang wrote:
bq.  > This is another option for scan.  This way, we will have only one scan 
method, no need to open/next/close.
bq.  > 
bq.  > Which one do you prefer?  In the ScanRequest, either scannerId or scan 
must be specified, not both.
bq.  > 
bq.  > message Scan {
bq.  >   required RegionSpecifier region = 1;
bq.  >   repeated Column column = 2;
bq.  >   repeated Attribute attribute = 3;
bq.  >   optional bytes startRow = 4;
bq.  >   optional bytes stopRow = 5;
bq.  >   optional string filterName = 6;
bq.  >   optional TimeRange timeRange = 7;
bq.  >   optional uint32 maxVersions = 8 [default = 1];
bq.  >   optional bool cacheBlocks = 9 [default = true];
bq.  >   optional uint32 rowsToCache = 10;
bq.  >   optional uint32 batchSize = 11;
bq.  > }
bq.  > 
bq.  > message ScanRequest {
bq.  >   optional uint64 scannerId = 1;
bq.  >   optional Scan scan = 2;
bq.  >   optional uint32 numberOfRows = 3;
bq.  >   optional bool closeScanner = 4;
bq.  >   optional uint32 ttl = 5;
bq.  > }
bq.  > 
bq.  > message ScanResponse {
bq.  >   repeated Result result = 1;
bq.  >   optional uint64 scannerId = 2;
bq.  >   optional bool moreResults = 3;
bq.  >   optional uint32 ttl = 4;
bq.  > }
bq.  >

So we would do away with openScanner,  next, and close, just do scan?  Inside 
in the ScanRequest, we'd carry over the Scan specification each time?  We'd be 
able to honor the current openScanner, next, close client-facing API but could 
add a new scan method to the public api that allowed passing the above 
specifications?  Sounds good.

- Michael

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5575
---

On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  ---
bq.  
bq.  (Updated 2012-03-02 18:54:29)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The 
corresponding java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.  https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.pom.xml bb518b1 
bq.src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.src/main/proto/RegionClient.proto PRE-CREATION 
bq.src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221191#comment-13221191
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5575
---

This is another option for scan.  This way, we will have only one scan method, 
no need to open/next/close.

Which one do you prefer?  In the ScanRequest, either scannerId or scan must be 
specified, not both.

message Scan {
  required RegionSpecifier region = 1;
  repeated Column column = 2;
  repeated Attribute attribute = 3;
  optional bytes startRow = 4;
  optional bytes stopRow = 5;
  optional string filterName = 6;
  optional TimeRange timeRange = 7;
  optional uint32 maxVersions = 8 [default = 1];
  optional bool cacheBlocks = 9 [default = true];
  optional uint32 rowsToCache = 10;
  optional uint32 batchSize = 11;
}

message ScanRequest {
  optional uint64 scannerId = 1;
  optional Scan scan = 2;
  optional uint32 numberOfRows = 3;
  optional bool closeScanner = 4;
  optional uint32 ttl = 5;
}

message ScanResponse {
  repeated Result result = 1;
  optional uint64 scannerId = 2;
  optional bool moreResults = 3;
  optional uint32 ttl = 4;
}

- Jimmy

On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  ---
bq.  
bq.  (Updated 2012-03-02 18:54:29)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The 
corresponding java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.  https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.pom.xml bb518b1 
bq.src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.src/main/proto/RegionClient.proto PRE-CREATION 
bq.src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221181#comment-13221181
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5573
---

This is a lot better already.  One thing this doesn't address that I should've 
mentioned in my previous review is that the requests and responses still have a 
lot of duplicate data.  For example if I "Get" a row that contains 3 KeyValue, 
in the response, on the wire, I'll get 3 times the key and 3 times the family.

pom.xml

You didn't take into account my comments on fixing this shell scripting 
from the previous iteration.

src/main/proto/RegionClient.proto

So a Get request can only fetch multiple Get from a single Region?  That's 
not good.  We need true multi-get, where you can fetch things from multiple 
regions on the same RegionServer at once.

src/main/proto/RegionClient.proto

trailing whitespaces

src/main/proto/RegionClient.proto

I don't know if we should let the client specify the TTL.  Right now in 
HBase the TTL is hardcoded in the Configuration object of the RegionServer.

Actually I'm fine with allowing clients specify their own TTL as long as we 
bound the TTL with the servers' Configuration.

src/main/proto/hbase.proto

I still don't understand how these can be optional.

- Benoit

On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  ---
bq.  
bq.  (Updated 2012-03-02 18:54:29)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The 
corresponding java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.  https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.pom.xml bb518b1 
bq.src/main/proto/RegionAdmin.proto PRE-CREATION 
bq.src/main/proto/RegionClient.proto PRE-CREATION 
bq.src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread Jimmy Xiang (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221155#comment-13221155
 ] 

Jimmy Xiang commented on HBASE-5443:


I updated the review with new diff, which incorporated the feedbacks from all 
reviewers.  Thanks a lot for review.
 

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221151#comment-13221151
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/
---

(Updated 2012-03-02 18:54:29.710858)


Review request for hbase.


Summary
---

This is the first draft of the ProtoBuff HRegionProtocol.  The corresponding 
java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443

Please review.  I'd like to move ahead after we get to some agreement.


This addresses bug HBASE-5443.
https://issues.apache.org/jira/browse/HBASE-5443


Diffs
-

  pom.xml bb518b1 
  src/main/proto/RegionAdmin.proto PRE-CREATION 
  src/main/proto/RegionClient.proto PRE-CREATION 
  src/main/proto/hbase.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/4054/diff


Testing
---


Thanks,

Jimmy



> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221119#comment-13221119
]

jirapos...@reviews.apache.org commented on HBASE-5443:
--

bq. On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq. > This seems to be close to a one-to-one mapping with the current
interface today. I don't know if this is the intent or whether you're willing
to completely redesign the look of the API too. Maybe it's to ease the
transition?
bq. >
bq. > I'd like to see a request type to do one-shot scans. Something where
you don't even get a scanner ID. You pass parameters like to open a scanner,
you say up to how many rows or bytes you want to retrieve, and you get just
that in one shot.
bq. > When opening a actual scanner, we also need to be able to get the first
batch of scan results at the same time we open the scanner. This is a
must-have IMO. And we need to be able to request to close the scanner while
fetching a batch of results.
bq. >
bq. > It would be nice to have a "keep-alive" request for existing scanners.
Something to tell the server "I'm not fetching anything from this scanner right
now, but please keep it open by reseting its TTL, don't close it just because I
haven't used it for a while".
bq. >
bq. > Please, please, please, consider shortening the name of all these
protobufs and dropping the Proto suffix. The current names are unnecessarily
long or aren't intuitive (e.g. "columnFamily" for something that describes the
multiple things you're trying to get out of a row) or are too redundant (e.g.
"KeyType keyType").
bq. >
bq. > Regarding the lack of "multi" RPC, I think this is a good thing.
"multi" is a big mess that was only marginally better than its horrible
"multiPut" predecessor. This proposal already supports multi-everything, it
just doesn't support batching different kind of operations in the same RPC,
which isn't a big deal IMO.
bq.
bq. Michael Stack wrote:
bq. We should implement what Benoît is asking for, probably not all as
part of this issue. That said, if possible can we try and accomodate what he's
asking for down here at the rpc level? I suppose once all is pb, it should be
easy enough adding new stuff but it would be good to keep in mind what he's
asking while redoing this layer. In a later issue we can add the overloads
that exploit the additions or add the new methods B wants (What B is asking for
are long-time outstanding fixups needed in hbase). For example, can the pb
response on open of a scanner be more than just the scanner id; could it
include an optional result item? Or I suppose, once up on pb, we can do this
easily enough later?
bq.
bq.

The idea is not to break the existing client application code. So the new
interface should be able to do the same thing and more.
By the way, I have changed the interfaces a lot after several reviews so I
closed this review. I will post a new review later.

As to scanner, we cannot retrieve everything in one shot. So in the RPC layer,
there must be multiple trips. As to the function you mentioned, it can be
built in the client side, right?
I will add an option to return results in opening a scanner, and an option to
close the scanner in fetching from the scanner.

Ok, I will try to shorten the names.

As to multi, I am not sure. This proposal doesn't support mix different kind of
operations in different order in the same RPC. I may need to add a similar one
if we don't want to break the existing function.

bq. On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq. > src/main/proto/HRegionProtocol.proto, line 22
bq. >
bq. >
bq. > I find the Proto suffix unnecessary and long. If you truly want a
suffix, PB would be shorter, but no suffix would be better IMO.

Ok, I will remove the Proto suffix.

bq. On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq. > src/main/proto/HRegionProtocol.proto, line 25
bq. >
bq. >
bq. > Use "option optimize_for = SPEED", it makes a big difference.

Cool. I will add it.

bq. On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq. > src/main/proto/HRegionProtocol.proto, line 28
bq. >
bq. >
bq. > I'd call this just "Columns".

I changed it to ColumnProto.

bq. On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq. > src/main/proto/HRegionProtocol.proto, line 30
bq. >
bq. >
bq. > I would recommend to pluralize all "repeated" fields. This will
make for nicer code where you'll be able to write something along the lines of:
bq. >
bq. > for (byte[] qualifier : pb.qualifiers())

For the re

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221085#comment-13221085
 ] 

jirapos...@reviews.apache.org commented on HBASE-5443:
--

bq.  On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq.  > This seems to be close to a one-to-one mapping with the current 
interface today.  I don't know if this is the intent or whether you're willing 
to completely redesign the look of the API too.  Maybe it's to ease the 
transition?
bq.  > 
bq.  > I'd like to see a request type to do one-shot scans.  Something where 
you don't even get a scanner ID.  You pass parameters like to open a scanner, 
you say up to how many rows or bytes you want to retrieve, and you get just 
that in one shot.
bq.  > When opening a actual scanner, we also need to be able to get the first 
batch of scan results at the same time we open the scanner.  This is a 
must-have IMO.  And we need to be able to request to close the scanner while 
fetching a batch of results.
bq.  > 
bq.  > It would be nice to have a "keep-alive" request for existing scanners.  
Something to tell the server "I'm not fetching anything from this scanner right 
now, but please keep it open by reseting its TTL, don't close it just because I 
haven't used it for a while".
bq.  > 
bq.  > Please, please, please, consider shortening the name of all these 
protobufs and dropping the Proto suffix.  The current names are unnecessarily 
long or aren't intuitive (e.g. "columnFamily" for something that describes the 
multiple things you're trying to get out of a row) or are too redundant (e.g. 
"KeyType keyType").
bq.  > 
bq.  > Regarding the lack of "multi" RPC, I think this is a good thing.  
"multi" is a big mess that was only marginally better than its horrible 
"multiPut" predecessor.  This proposal already supports multi-everything, it 
just doesn't support batching different kind of operations in the same RPC, 
which isn't a big deal IMO.

We should implement what Benoît is asking for, probably not all as part of this 
issue.  That said, if possible can we try and accomodate what he's asking for 
down here at the rpc level?  I suppose once all is pb, it should be easy enough 
adding new stuff but it would be good to keep in mind what he's asking while 
redoing this layer.  In a later issue we can add the overloads that exploit the 
additions or add the new methods B wants (What B is asking for are long-time 
outstanding fixups needed in hbase).  For example, can the pb response on open 
of a scanner be more than just the scanner id; could it include an optional 
result item?  Or I suppose, once up on pb, we can do this easily enough later?

- Michael

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5552
---

On 2012-02-27 18:54:31, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  ---
bq.  
bq.  (Updated 2012-02-27 18:54:31)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The 
corresponding java vs pb method mapping is attached to the jira: 
https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.  https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.pom.xml 066c027 
bq.src/main/proto/HRegionProtocol.proto PRE-CREATION 
bq.src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.

> Add PB-based calls to HRegionInterface
> --
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Todd Lipcon
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220823#comment-13220823
]

jirapos...@reviews.apache.org commented on HBASE-5443:
--

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5552
---

This seems to be close to a one-to-one mapping with the current interface
today. I don't know if this is the intent or whether you're willing to
completely redesign the look of the API too. Maybe it's to ease the transition?

I'd like to see a request type to do one-shot scans. Something where you don't
even get a scanner ID. You pass parameters like to open a scanner, you say up
to how many rows or bytes you want to retrieve, and you get just that in one
shot.
When opening a actual scanner, we also need to be able to get the first batch
of scan results at the same time we open the scanner. This is a must-have IMO.
And we need to be able to request to close the scanner while fetching a batch
of results.

It would be nice to have a "keep-alive" request for existing scanners.
Something to tell the server "I'm not fetching anything from this scanner right
now, but please keep it open by reseting its TTL, don't close it just because I
haven't used it for a while".

Please, please, please, consider shortening the name of all these protobufs and
dropping the Proto suffix. The current names are unnecessarily long or aren't
intuitive (e.g. "columnFamily" for something that describes the multiple things
you're trying to get out of a row) or are too redundant (e.g. "KeyType
keyType").

Regarding the lack of "multi" RPC, I think this is a good thing. "multi" is a
big mess that was only marginally better than its horrible "multiPut"
predecessor. This proposal already supports multi-everything, it just doesn't
support batching different kind of operations in the same RPC, which isn't a
big deal IMO.

pom.xml

Do this instead:

if which cygpath >/dev/null 2>/dev/null; then
# Windows
else
# Not Windows
fi

pom.xml

Simply do:

if $IS_WIN; then

pom.xml

Actually you can just remove the whole $IS_WIN business and everything.
Simply fix PROTO_DIR and JAVA_DIR when on Windows before calling protoc.