[jira] [Created] (NIFI-8113) Persisting status history

2021-01-05 Thread Simon Bence (Jira)
Simon Bence created NIFI-8113: - Summary: Persisting status history Key: NIFI-8113 URL: https://issues.apache.org/jira/browse/NIFI-8113 Project: Apache NiFi Issue Type: New Feature

[jira] [Updated] (NIFI-7761) Allow HandleHttpRequest to add specified form data to FlowFile attributes

2021-01-05 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-7761: - Component/s: Extensions > Allow HandleHttpRequest to add specified form data to FlowFile

[jira] [Resolved] (NIFI-7761) Allow HandleHttpRequest to add specified form data to FlowFile attributes

2021-01-05 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-7761. -- Fix Version/s: 1.13.0 Resolution: Fixed > Allow HandleHttpRequest to add specified form

[jira] [Updated] (NIFI-8113) Persisting status history

2021-01-05 Thread Simon Bence (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Bence updated NIFI-8113: -- Description: An alternative solution would be useful to replace/extend current in-memory solution for

[GitHub] [nifi] s9514171 commented on pull request #4720: NIFI-1440 Allow Remote Process Group Target URI to change after creation

2021-01-05 Thread GitBox
s9514171 commented on pull request #4720: URL: https://github.com/apache/nifi/pull/4720#issuecomment-754493844 HI @markap14 I faced some issues after I change the URI of the RPG in version 1.12.x when I changed the target to another instance, the old peers don't be removed, it

[GitHub] [nifi] pvillard31 commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…

2021-01-05 Thread GitBox
pvillard31 commented on pull request #4513: URL: https://github.com/apache/nifi/pull/4513#issuecomment-754494329 Merged to main based on previous comments. Thanks @ottobackwards @joewitt @markap14 @grego33 This is an

[jira] [Commented] (NIFI-7761) Allow HandleHttpRequest to add specified form data to FlowFile attributes

2021-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258755#comment-17258755 ] ASF subversion and git services commented on NIFI-7761: --- Commit

[GitHub] [nifi] asfgit closed pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…

2021-01-05 Thread GitBox
asfgit closed pull request #4513: URL: https://github.com/apache/nifi/pull/4513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (MINIFICPP-1446) SQL extension doesn't compile on Debian

2021-01-05 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1446: - Summary: SQL extension doesn't compile on Debian Key: MINIFICPP-1446 URL: https://issues.apache.org/jira/browse/MINIFICPP-1446 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi] asfgit closed pull request #4733: NIFI-8067: Fix 1-way SSL in GRPC processors

2021-01-05 Thread GitBox
asfgit closed pull request #4733: URL: https://github.com/apache/nifi/pull/4733 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (NIFI-8067) Fix 1-way SSL in GRPC processors

2021-01-05 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8067: - Fix Version/s: 1.13.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #957: URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551922177 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -447,35 +447,43 @@ class HeartbeatHandler : public ServerAwareHandler { }

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #957: URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551922305 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -499,8 +507,8 @@ class C2UpdateHandler : public ServerAwareHandler { }

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #969: MINIFICPP-1439 - Startup without agent class, handle class update

2021-01-05 Thread GitBox
arpadboda commented on a change in pull request #969: URL: https://github.com/apache/nifi-minifi-cpp/pull/969#discussion_r551926784 ## File path: extensions/http-curl/tests/C2RequestClassTest.cpp ## @@ -0,0 +1,139 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-05 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r551920589 ## File path: extensions/librdkafka/ConsumeKafka.h ## @@ -0,0 +1,197 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #931: MINIFICPP-1390 Create DeleteS3Object processor

2021-01-05 Thread GitBox
arpadboda closed pull request #931: URL: https://github.com/apache/nifi-minifi-cpp/pull/931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

2021-01-05 Thread GitBox
arpadboda commented on a change in pull request #957: URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551958321 ## File path: libminifi/include/core/controller/ForwardingControllerServiceProvider.h ## @@ -0,0 +1,136 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

2021-01-05 Thread GitBox
arpadboda commented on a change in pull request #957: URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551898202 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -499,8 +507,8 @@ class C2UpdateHandler : public ServerAwareHandler { }

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #969: MINIFICPP-1439 - Startup without agent class, handle class update

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #969: URL: https://github.com/apache/nifi-minifi-cpp/pull/969#discussion_r551933077 ## File path: extensions/http-curl/tests/C2RequestClassTest.cpp ## @@ -0,0 +1,139 @@ +/** + * + * Licensed to the Apache Software Foundation

[jira] [Created] (MINIFICPP-1447) Remove unused C2Payload::isResponse

2021-01-05 Thread Adam Debreceni (Jira)
Adam Debreceni created MINIFICPP-1447: - Summary: Remove unused C2Payload::isResponse Key: MINIFICPP-1447 URL: https://issues.apache.org/jira/browse/MINIFICPP-1447 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

2021-01-05 Thread GitBox
szaszm commented on a change in pull request #957: URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551953686 ## File path: libminifi/include/core/controller/ForwardingControllerServiceProvider.h ## @@ -0,0 +1,136 @@ +/** + * + * Licensed to the Apache

[jira] [Commented] (NIFI-7965) JoltTransformJSON Memory leak

2021-01-05 Thread Jeffery Lyrine Bowman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258947#comment-17258947 ] Jeffery Lyrine Bowman commented on NIFI-7965: - Was this issue in earlier versions of Nifi as

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551891610 ## File path: libminifi/src/provenance/Provenance.cpp ## @@ -178,8 +181,8 @@ bool

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551902820 ## File path: main/AgentDocs.cpp ## @@ -47,7 +47,7 @@ std::string AgentDocs::extractClassName(const std::string ) const { auto lastOfIdx

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551902469 ## File path: libminifi/test/unit/ZlibStreamTests.cpp ## @@ -97,7 +106,8 @@ TEST_CASE("gzip compression and decompression pipeline",

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

2021-01-05 Thread GitBox
arpadboda commented on a change in pull request #957: URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551915849 ## File path: libminifi/include/core/controller/ForwardingControllerServiceProvider.h ## @@ -0,0 +1,136 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #969: MINIFICPP-1439 - Startup without agent class, handle class update

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #969: URL: https://github.com/apache/nifi-minifi-cpp/pull/969#discussion_r551935670 ## File path: extensions/http-curl/tests/C2RequestClassTest.cpp ## @@ -0,0 +1,139 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551891837 ## File path: libminifi/src/provenance/Provenance.cpp ## @@ -189,8 +192,8 @@ bool

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551893946 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -95,21 +95,23 @@ bool StringUtils::StringToFloat(std::string input, float ,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #957: URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551908167 ## File path: libminifi/include/core/controller/ForwardingControllerServiceProvider.h ## @@ -0,0 +1,136 @@ +/** + * + * Licensed to the

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551912172 ## File path: nanofi/tests/CTestsBase.h ## @@ -138,7 +138,8 @@ class TestControllerWithTemporaryWorkingDirectory { }

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551912512 ## File path: nanofi/include/sitetosite/CPeer.h ## @@ -79,15 +79,15 @@ static void setHostName(struct SiteToSiteCPeer * peer, const char *

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #957: URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551917293 ## File path: libminifi/include/core/controller/ForwardingControllerServiceProvider.h ## @@ -0,0 +1,136 @@ +/** + * + * Licensed to the

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #957: URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551917293 ## File path: libminifi/include/core/controller/ForwardingControllerServiceProvider.h ## @@ -0,0 +1,136 @@ +/** + * + * Licensed to the

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #969: MINIFICPP-1439 - Startup without agent class, handle class update

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #969: URL: https://github.com/apache/nifi-minifi-cpp/pull/969#discussion_r551945346 ## File path: extensions/http-curl/tests/C2RequestClassTest.cpp ## @@ -0,0 +1,139 @@ +/** + * + * Licensed to the Apache Software Foundation

[jira] [Resolved] (MINIFICPP-1432) NetworkPrioritizerServiceTests are sensitive to timing

2021-01-05 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1432. --- Resolution: Fixed > NetworkPrioritizerServiceTests are sensitive to timing >

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request #969: MINIFICPP-1439 - Startup without agent class, handle class update

2021-01-05 Thread GitBox
adamdebreceni opened a new pull request #969: URL: https://github.com/apache/nifi-minifi-cpp/pull/969 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #969: MINIFICPP-1439 - Startup without agent class, handle class update

2021-01-05 Thread GitBox
arpadboda commented on a change in pull request #969: URL: https://github.com/apache/nifi-minifi-cpp/pull/969#discussion_r551936160 ## File path: extensions/http-curl/tests/C2RequestClassTest.cpp ## @@ -0,0 +1,139 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #961: MINIFICPP-1440 PublishKafka processor's "security protocol" should ha…

2021-01-05 Thread GitBox
szaszm closed pull request #961: URL: https://github.com/apache/nifi-minifi-cpp/pull/961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (MINIFICPP-1445) Clean up docker integration test framework

2021-01-05 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1445: Description: *Background:* Docker integration tests are currently living in a two,

[jira] [Commented] (NIFI-8067) Fix 1-way SSL in GRPC processors

2021-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258810#comment-17258810 ] ASF subversion and git services commented on NIFI-8067: --- Commit

[GitHub] [nifi] pvillard31 commented on pull request #4733: NIFI-8067: Fix 1-way SSL in GRPC processors

2021-01-05 Thread GitBox
pvillard31 commented on pull request #4733: URL: https://github.com/apache/nifi/pull/4733#issuecomment-754551608 Merged to main following previous comments. Thanks @turcsanyip @exceptionfactory This is an automated message

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551895592 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -95,21 +95,23 @@ bool StringUtils::StringToFloat(std::string input, float ,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551912512 ## File path: nanofi/include/sitetosite/CPeer.h ## @@ -79,15 +79,15 @@ static void setHostName(struct SiteToSiteCPeer * peer, const char *

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551912512 ## File path: nanofi/include/sitetosite/CPeer.h ## @@ -79,15 +79,15 @@ static void setHostName(struct SiteToSiteCPeer * peer, const char *

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551902820 ## File path: main/AgentDocs.cpp ## @@ -47,7 +47,7 @@ std::string AgentDocs::extractClassName(const std::string ) const { auto lastOfIdx

[GitHub] [nifi] turcsanyip commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-05 Thread GitBox
turcsanyip commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-754619090 @exceptionfactory I ran some test flows and there is a regression in ConvertRecord. ConvertRecord setup: - Json reader/writer (XML and CSV also affected) - explicit

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-05 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r551922933 ## File path: libminifi/include/utils/ProcessorConfigUtils.h ## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-05 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r538358865 ## File path: libminifi/test/TestBase.h ## @@ -200,7 +199,7 @@ class LogTestController { } my_properties_->set("logger.root",

[GitHub] [nifi] adenes commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-05 Thread GitBox
adenes commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-754646839 @exceptionfactory , thanks for the PR. I ran the unit tests in CET timezone, and one of the newly added tests fails: ``` [ERROR]

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-05 Thread GitBox
fgerlits commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r552072783 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
adamdebreceni commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551985634 ## File path: nanofi/include/sitetosite/CPeer.h ## @@ -88,7 +88,7 @@ static void setPort(struct SiteToSiteCPeer * peer, uint16_t port) {

[jira] [Commented] (NIFI-7965) JoltTransformJSON Memory leak

2021-01-05 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258981#comment-17258981 ] Joe Witt commented on NIFI-7965: Showing memory usage like that alone doesn't give a clear indication of a

[jira] [Commented] (NIFI-6242) PutFileTransfer generating incorrect provenance events

2021-01-05 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259041#comment-17259041 ] Joe Witt commented on NIFI-6242: will pull into 1.13. as requested. just reviewed and looks fine >

[jira] [Updated] (NIFI-6242) PutFileTransfer generating incorrect provenance events

2021-01-05 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6242: --- Fix Version/s: 1.13.0 > PutFileTransfer generating incorrect provenance events >

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-05 Thread GitBox
lordgamez opened a new pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request #971: MINIFICPP-1447 - Remove unused C2Payload::isResponse

2021-01-05 Thread GitBox
adamdebreceni opened a new pull request #971: URL: https://github.com/apache/nifi-minifi-cpp/pull/971 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-05 Thread GitBox
lordgamez commented on a change in pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r552045547 ## File path: extensions/aws/processors/FetchS3Object.h ## @@ -0,0 +1,110 @@ +/** + * @file FetchS3Object.h + * FetchS3Object class declaration +

[jira] [Updated] (NIFI-7387) Update ComponentLog to use varargs in addition to array

2021-01-05 Thread Mark Bean (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bean updated NIFI-7387: Summary: Update ComponentLog to use varargs in addition to array (was: Update ComponentLog to use varargs

[GitHub] [nifi] turcsanyip commented on a change in pull request #4578: NIFI-7889 - ConsumeMQTT - use offer instead of add

2021-01-05 Thread GitBox
turcsanyip commented on a change in pull request #4578: URL: https://github.com/apache/nifi/pull/4578#discussion_r552055174 ## File path: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java ## @@ -82,6 +85,9 @@

[GitHub] [nifi] moranr commented on pull request #4563: NIFI-7738 Reverse Provenance Query

2021-01-05 Thread GitBox
moranr commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-754772546 @markap14 @NissimShiman I don’t think the tabular like appearance is necessary. Much like Start Date/Time, etc. these are just other fields upon which the user can search. I

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551967884 ## File path: libminifi/src/provenance/Provenance.cpp ## @@ -178,8 +181,8 @@ bool

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551970890 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -95,21 +95,23 @@ bool StringUtils::StringToFloat(std::string input, float , FailurePolicy

[jira] [Commented] (NIFI-2002) Name property for funnels

2021-01-05 Thread John Wise (Jira)
[ https://issues.apache.org/jira/browse/NIFI-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258990#comment-17258990 ] John Wise commented on NIFI-2002: - I'll add colors as well, since we use them for routing and grounding

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #968: MINIFICPP-1445 - Refactor docker integration test frame

2021-01-05 Thread GitBox
arpadboda commented on a change in pull request #968: URL: https://github.com/apache/nifi-minifi-cpp/pull/968#discussion_r552009363 ## File path: docker/test/integration/test_s2s.py ## @@ -14,8 +14,6 @@ # limitations under the License. from minifi import * -from

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-05 Thread GitBox
lordgamez commented on a change in pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r552049971 ## File path: extensions/aws/s3/S3WrapperBase.cpp ## @@ -32,6 +33,17 @@ namespace minifi { namespace aws { namespace s3 { +void

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-05 Thread GitBox
arpadboda commented on a change in pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r552056509 ## File path: extensions/aws/processors/FetchS3Object.cpp ## @@ -0,0 +1,122 @@ +/** + * @file FetchS3Object.cpp + * FetchS3Object class

[GitHub] [nifi] turcsanyip commented on a change in pull request #4578: NIFI-7889 - ConsumeMQTT - use offer instead of add

2021-01-05 Thread GitBox
turcsanyip commented on a change in pull request #4578: URL: https://github.com/apache/nifi/pull/4578#discussion_r552055174 ## File path: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java ## @@ -82,6 +85,9 @@

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551970138 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -95,21 +95,23 @@ bool StringUtils::StringToFloat(std::string input, float , FailurePolicy

[jira] [Updated] (NIFI-7974) Upgrading calcite, hbase, geo2ip deps

2021-01-05 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-7974: - Fix Version/s: (was: 1.13.0) > Upgrading calcite, hbase, geo2ip deps >

[GitHub] [nifi] mattyb149 commented on a change in pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components

2021-01-05 Thread GitBox
mattyb149 commented on a change in pull request #4682: URL: https://github.com/apache/nifi/pull/4682#discussion_r552051653 ## File path: nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcProperties.java ## @@ -78,4 +77,15 @@

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-05 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-754765641 > @exceptionfactory , thanks for the PR. > > I ran the unit tests in CET timezone, and one of the newly added tests fails: > > ``` > [ERROR]

[jira] [Updated] (NIFI-8113) Persisting status history

2021-01-05 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8113: - Fix Version/s: (was: 1.13.0) > Persisting status history > - > >

[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #968: MINIFICPP-1445 - Refactor docker integration test frame

2021-01-05 Thread GitBox
arpadboda commented on pull request #968: URL: https://github.com/apache/nifi-minifi-cpp/pull/968#issuecomment-754705934 Seems to conflict with a recently merged PR, could you address that? This is an automated message from

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #968: MINIFICPP-1445 - Refactor docker integration test frame

2021-01-05 Thread GitBox
hunyadi-dev commented on a change in pull request #968: URL: https://github.com/apache/nifi-minifi-cpp/pull/968#discussion_r552019420 ## File path: docker/test/integration/test_s2s.py ## @@ -14,8 +14,6 @@ # limitations under the License. from minifi import * -from

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-05 Thread GitBox
lordgamez commented on a change in pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r552044816 ## File path: extensions/aws/processors/FetchS3Object.cpp ## @@ -0,0 +1,122 @@ +/** + * @file FetchS3Object.cpp + * FetchS3Object class

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r552052405 ## File path: nanofi/include/sitetosite/CPeer.h ## @@ -88,7 +88,7 @@ static void setPort(struct SiteToSiteCPeer * peer, uint16_t port) {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551971620 ## File path: nanofi/include/sitetosite/CPeer.h ## @@ -79,15 +79,15 @@ static void setHostName(struct SiteToSiteCPeer * peer, const char *

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2021-01-05 Thread GitBox
fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551971025 ## File path: libminifi/test/unit/ZlibStreamTests.cpp ## @@ -97,7 +106,8 @@ TEST_CASE("gzip compression and decompression pipeline", "[basic]") {

[jira] [Updated] (NIFI-8109) Make MongoDB controller support mongodb+srv URIs and split off username and password from URI

2021-01-05 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8109: - Fix Version/s: (was: 1.13.0) > Make MongoDB controller support mongodb+srv URIs and split off

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-05 Thread GitBox
arpadboda commented on a change in pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r551993522 ## File path: extensions/aws/processors/FetchS3Object.cpp ## @@ -0,0 +1,122 @@ +/** + * @file FetchS3Object.cpp + * FetchS3Object class

[jira] [Created] (NIFI-8114) Timer-driven ListFile processor sometimes doesn't start

2021-01-05 Thread Annalisa Asta (Jira)
Annalisa Asta created NIFI-8114: --- Summary: Timer-driven ListFile processor sometimes doesn't start Key: NIFI-8114 URL: https://issues.apache.org/jira/browse/NIFI-8114 Project: Apache NiFi

[jira] [Updated] (NIFI-7964) PutAzureBlobStorage OutOfMemory Exception

2021-01-05 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee updated NIFI-7964: -- Priority: Blocker (was: Major) > PutAzureBlobStorage OutOfMemory Exception >

[jira] [Updated] (NIFI-8034) PropertyValue.isExpressionLanguagePresent always returns true for non-null values

2021-01-05 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8034: -- Fix Version/s: 1.13.0 > PropertyValue.isExpressionLanguagePresent always returns true for

[GitHub] [nifi] sjyang18 closed pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-05 Thread GitBox
sjyang18 closed pull request #4630: URL: https://github.com/apache/nifi/pull/4630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] sjyang18 commented on pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-05 Thread GitBox
sjyang18 commented on pull request #4630: URL: https://github.com/apache/nifi/pull/4630#issuecomment-754932330 @mtien-apache I have added the fallback property explanation to admin doc. Will this work? This is an

[GitHub] [nifi] sjyang18 commented on pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-05 Thread GitBox
sjyang18 commented on pull request #4630: URL: https://github.com/apache/nifi/pull/4630#issuecomment-754930724 > @sjyang18 Thank you for submitting this. I've reviewed it and the functionality LGTM. I verified I can log in with OIDC enabled and verified the tests will use the listed

[GitHub] [nifi] NissimShiman commented on pull request #4563: NIFI-7738 Reverse Provenance Query

2021-01-05 Thread GitBox
NissimShiman commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-754951005 @moranr Thank You for your feedback (and for taking the time to put together a sample prototype of what the UI should look like :) ). This will certainly work, is very

[GitHub] [nifi] sjyang18 removed a comment on pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-05 Thread GitBox
sjyang18 removed a comment on pull request #4630: URL: https://github.com/apache/nifi/pull/4630#issuecomment-754930724 > @sjyang18 Thank you for submitting this. I've reviewed it and the functionality LGTM. I verified I can log in with OIDC enabled and verified the tests will use the

[GitHub] [nifi] exceptionfactory opened a new pull request #4743: NIFI-6576 Added Basic Authentication support to ConfluentSchemaRegistry

2021-01-05 Thread GitBox
exceptionfactory opened a new pull request #4743: URL: https://github.com/apache/nifi/pull/4743 Description of PR NIFI-6576 Adds HTTP Basic Authentication support to `ConfluentSchemaRegistry` Controller Service. This PR is based on work from @mark-weghorst in PR #4508 and

[GitHub] [nifi] turcsanyip commented on a change in pull request #4586: NIFI-7894 - ConsumeMQTT - allow EL on Client ID property with shared …

2021-01-05 Thread GitBox
turcsanyip commented on a change in pull request #4586: URL: https://github.com/apache/nifi/pull/4586#discussion_r552232866 ## File path: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java ## @@ -194,9 +194,15

[GitHub] [nifi] jfrazee commented on pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-05 Thread GitBox
jfrazee commented on pull request #4630: URL: https://github.com/apache/nifi/pull/4630#issuecomment-754971676 @mtien-apache @sjyang18 I've been looking at this and was wondering which identity providers this has been tested against?

[GitHub] [nifi] readl1 commented on a change in pull request #2231: NIFI-4521 MS SQL CDC Processor

2021-01-05 Thread GitBox
readl1 commented on a change in pull request #2231: URL: https://github.com/apache/nifi/pull/2231#discussion_r552273118 ## File path: nifi-nar-bundles/nifi-cdc/nifi-cdc-mssql-bundle/nifi-cdc-mssql-processors/src/main/java/org/apache/nifi/cdc/mssql/MSSQLCDCUtils.java ## @@

[GitHub] [nifi] readl1 removed a comment on pull request #2231: NIFI-4521 MS SQL CDC Processor

2021-01-05 Thread GitBox
readl1 removed a comment on pull request #2231: URL: https://github.com/apache/nifi/pull/2231#issuecomment-753328778 I believe Decimal is 10^38 not 2^38 On Thu, Dec 31, 2020 at 4:50 PM Peter Wicks wrote: > *@patricker* commented on this pull request. >