[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r671773887 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -758,16 +814,25 @@ class FetchManager(private val time: Time, case

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r671754759 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -758,16 +814,25 @@ class FetchManager(private val time: Time, case

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r671754618 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -186,36 +250,65 @@ public String toString() { *

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r671754420 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -186,36 +250,65 @@ public String toString() { *

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r661788073 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -296,11 +276,23 @@ public AbstractResponse

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660061129 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -231,20 +239,31 @@ class FetchSession(val id: Int, def metadata: JFetchMetadata

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660228674 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +512,26 @@ class IncrementalFetchContext(private val time: Time, if

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660228129 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -296,11 +276,24 @@ public AbstractResponse

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660199209 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -277,14 +277,18 @@ public AbstractResponse

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660127887 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -193,18 +197,22 @@ class CachedPartition(val topic: String, * Each fetch session

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660122565 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -353,39 +375,50 @@ class SessionlessFetchContext(val fetchData:

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660122565 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -353,39 +375,50 @@ class SessionlessFetchContext(val fetchData:

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660068452 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +504,19 @@ class IncrementalFetchContext(private val time: Time, if

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660062652 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -353,39 +375,50 @@ class SessionlessFetchContext(val fetchData:

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660061358 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -193,18 +197,22 @@ class CachedPartition(val topic: String, * Each fetch session

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660061129 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -231,20 +239,31 @@ class FetchSession(val id: Int, def metadata: JFetchMetadata

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655642933 ## File path: core/src/test/scala/unit/kafka/server/FetchRequestTest.scala ## @@ -116,61 +122,85 @@ class FetchRequestTest extends BaseRequestTest {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655810138 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -746,7 +753,34 @@ class AuthorizerIntegrationTest extends

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655649858 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -216,12 +217,21 @@ class ReplicaFetcherThread(name: String, try {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655649425 ## File path: core/src/main/scala/kafka/server/metadata/RaftMetadataCache.scala ## @@ -226,6 +226,18 @@ class RaftMetadataCache(val brokerId: Int) extends

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655649094 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -71,6 +79,14 @@ public FetchResponseData data() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655648541 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java ## @@ -362,7 +363,8 @@ BROKER_ID_NOT_REGISTERED(102, "The given

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655647688 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +504,19 @@ class IncrementalFetchContext(private val time: Time, if

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655643270 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -154,17 +154,17 @@ class AuthorizerIntegrationTest extends

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655642933 ## File path: core/src/test/scala/unit/kafka/server/FetchRequestTest.scala ## @@ -116,61 +122,85 @@ class FetchRequestTest extends BaseRequestTest {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r654673513 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -161,7 +163,7 @@ class CachedPartition(val topic: String, mustRespond } -

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r653921888 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r652250666 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -71,6 +76,12 @@ public FetchResponseData data() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r652228425 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -294,8 +296,9 @@ class ReplicaFetcherThread(name: String, val

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651985270 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -70,6 +71,7 @@ object FetchSession { * localLogStartOffset is the log start

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651971564 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651970044 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -239,12 +245,22 @@ class FetchSession(val id: Int, // Update the cached

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651969184 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -216,12 +217,21 @@ class ReplicaFetcherThread(name: String, try {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651336157 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -119,18 +120,50 @@ public static FetchResponse

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651335666 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -71,6 +76,12 @@ public FetchResponseData data() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651335255 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -283,14 +290,18 @@ public void onSuccess(ClientResponse

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651335121 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -283,14 +290,18 @@ public void onSuccess(ClientResponse

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651334106 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651333015 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -213,9 +335,22 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651332908 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -186,23 +268,63 @@ public String toString() { *

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651332118 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -186,23 +268,63 @@ public String toString() { *

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651331636 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -412,6 +412,12 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651331247 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -216,12 +217,21 @@ class ReplicaFetcherThread(name: String, try {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651329577 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -945,10 +945,12 @@ private boolean hasValidClusterId(String

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r650612574 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -254,8 +255,14 @@ public synchronized int sendFetches()

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r648811500 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -254,8 +255,14 @@ public synchronized int sendFetches()

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r628405414 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627840199 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627776011 ## File path: core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala ## @@ -276,7 +284,12 @@ class ReplicaAlterLogDirsThread(name: String, }

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627767360 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -425,16 +438,27 @@ class IncrementalFetchContext(private val time: Time,

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627724561 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -314,22 +321,24 @@ class SessionErrorContext(val error: Errors, override def

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627723205 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -237,14 +239,16 @@ class FetchSession(val id: Int, type TL =

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627523900 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -125,10 +167,22 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627523117 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627522339 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -212,10 +273,19 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627519381 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -281,10 +296,16 @@ public String toString() { public

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627518693 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -319,12 +355,25 @@ public int maxBytes() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627516643 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,14 +89,26 @@ public Errors error() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627514050 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -425,16 +438,27 @@ class IncrementalFetchContext(private val time: Time,

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627027404 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -314,22 +321,24 @@ class SessionErrorContext(val error: Errors, override def

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627027261 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -319,12 +355,25 @@ public int maxBytes() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627026623 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -820,20 +838,30 @@ class KafkaApis(val requestChannel: RequestChannel, def

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r626749507 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r625164696 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -412,12 +412,6 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r603507748 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -143,34 +275,71 @@ public String toString() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r603506960 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -110,7 +116,68 @@ public String toString() { }

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r595284658 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r593922148 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r593772326 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r593771946 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r593293236 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r593283525 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592761061 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592761061 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592546512 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592536126 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592524660 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592520900 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -216,6 +217,14 @@ public synchronized boolean updateRequested() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r574909648 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -237,14 +317,80 @@ class FetchSession(val id: Int, type TL =

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r574846728 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +76,25 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r574846728 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +76,25 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r573046669 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -216,10 +217,10 @@ class ReplicaFetcherThread(name: String, try {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r573033865 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -353,50 +508,68 @@ class SessionlessFetchContext(val fetchData:

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572475014 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -353,50 +508,68 @@ class SessionlessFetchContext(val fetchData:

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572472724 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -237,14 +317,80 @@ class FetchSession(val id: Int, type TL =

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572470829 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -353,50 +508,68 @@ class SessionlessFetchContext(val fetchData:

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572413017 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -71,6 +75,7 @@ object FetchSession { * localLogStartOffset is the log start

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572413017 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -71,6 +75,7 @@ object FetchSession { * localLogStartOffset is the log start

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572381787 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -143,34 +275,71 @@ public String toString() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572377972 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -133,6 +200,71 @@ public String toString() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572373623 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -425,16 +598,26 @@ class IncrementalFetchContext(private val time: Time,

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572370494 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -216,10 +217,10 @@ class ReplicaFetcherThread(name: String, try {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572367849 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -237,14 +317,80 @@ class FetchSession(val id: Int, type TL =

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572363402 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -270,24 +314,40 @@ public T records() { */ public

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572363402 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -270,24 +314,40 @@ public T records() { */ public

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572357857 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -237,14 +317,80 @@ class FetchSession(val id: Int, type TL =

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572356813 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -110,7 +116,68 @@ public String toString() { }

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572355958 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -265,9 +353,32 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572354491 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +76,25 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572351945 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -270,24 +314,40 @@ public T records() { */ public

  1   2   >