D23579: WIP: port ftp slave to new error reporting system

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ftp.cpp:2153 > +const auto storResult = ftpOpenCommand("stor", dest, '?', > ERR_CANNOT_WRITE, offset); > +qDebug() << "!!! storresult" << storResult;

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

dfaure added inline comments. INLINE COMMENTS > ECMGenerateExportHeader.cmake:269 > +# cannot be used to reactivate the declaration, and ``Foo::doWhat`` will not > +# have been built into the library binary. > +# Really? Isn't doWhat excluded only if EXCLUDE_DEPRECATED_BEFORE_AND_AT is set to

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

kossebau abandoned this revision. kossebau added a comment. Not sure of usefulness (see D20984#543937 ), so discarding myself. Happy to see someone else take over though if they feel this improves things. REPOSITORY R296 KDeclarative REVISION

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

kossebau added a dependency: D20984: Add ECMAddQmlModule. REPOSITORY R296 KDeclarative BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabricator.kde.org/D21356 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

kossebau added a dependent revision: D21356: Port to ECMAddQmlModule, add plugins.qmltypes files. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,

D21344: Port to ECMAddQmlModule

kossebau abandoned this revision. kossebau added a comment. Not sure of usefulness (see D20984#543937 ), so discarding myself. Happy to see someone else take over though if they feel this improves things. REPOSITORY R242 Plasma Framework

D21344: Port to ECMAddQmlModule

kossebau added a dependency: D20984: Add ECMAddQmlModule. REPOSITORY R242 Plasma Framework (Library) BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabricator.kde.org/D21344 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

kossebau added a dependent revision: D21344: Port to ECMAddQmlModule. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

kossebau abandoned this revision. kossebau added a comment. @apol Thanks again for your review work. I am still a bit unsure about the usefulness and completeness of this macro, even more as I would not call myself a QML expert who has seen all corners. And given the lack of feedback

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. So, given the lack of further change proposals or objections, I would proceed to push this in the next days (Thurday evening or Friday morning), to have 3 weeks of pre-5.64 real world testing by CI and people running from git master. See also

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67523. kossebau added a comment. - add missing group defaulting for warning settings, got lost in rebase before REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67324=67523 BRANCH

D24372: Compile without deprecated foreach

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in job.cpp:181 > You need a local const var to hold the result of the subjobs() method call. > > (repeats) IIUC, subjobs() returns a const QList &, do we still need a local const var?

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcoreconfigskeleton.cpp:140 > Do we need to make this > > if (d->mIsDefaultImpl){ > return d->mIsDefaultImpl(); > } > return false; > > and initialize mIsDefaultImpl to nullptr > > so that it doesn't crash if

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

ervin updated this revision to Diff 67522. ervin added a comment. 5.63 -> 5.64 REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24494?vs=67507=67522 REVISION DETAIL https://phabricator.kde.org/D24494 AFFECTED FILES autotests/kconfigskeletontest.cpp

D24493: Add draw-highlight action icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH add-highlight-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24493 To: trickyricky26, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

kossebau added inline comments. INLINE COMMENTS > kcoreconfigskeleton.h:216 > + * > + * @since 5.63 > + */ -> 5.64 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart Cc: kossebau, davidedmundson,

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

davidedmundson added a comment. Looks good to me INLINE COMMENTS > kcoreconfigskeleton.cpp:140 > +{ > +return d->mIsDefaultImpl(); > +} Do we need to make this if (d->mIsDefaultImpl){ return d->mIsDefaultImpl(); } return false; and initialize mIsDefaultImpl to nullptr so

D24490: Make kconfig_compiler generate ctors with the optional parent arg

ervin updated this revision to Diff 67516. ervin added a comment. Address Friedrich's comments, I went for hiding the feature behind a flag after all, it was just less complexity added to the compiler in the end REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ognarb added inline comments. INLINE COMMENTS > kcategorydrawer.cpp:88 > +textRect.setTop(textRect.top() + 4); > +textRect.setLeft(textRect.left() + 8); > textRect.setHeight(fontMetrics.height()); Instead of using magic number, I would create a constant named padding.

D24490: Make kconfig_compiler generate ctors with the optional parent arg

ervin added a comment. In D24490#543810 , @kossebau wrote: > In D24490#543807 , @ervin wrote: > > > In D24490#543724 , @kossebau wrote: > > > > > How

D24372: Compile without deprecated foreach

ahmadsamir updated this revision to Diff 67510. ahmadsamir marked 7 inline comments as done. ahmadsamir added a comment. - User more descriptive var names other than list2 - qAsConst isn't needed if the method is const and the container is a member var REPOSITORY R241 KIO CHANGES SINCE

D24490: Make kconfig_compiler generate ctors with the optional parent arg

kossebau added a comment. In D24490#543807 , @ervin wrote: > In D24490#543724 , @kossebau wrote: > > > How does this effect the BIC of the generated classes? Consumers might have exposed the

D24490: Make kconfig_compiler generate ctors with the optional parent arg

ervin added a comment. In D24490#543724 , @kossebau wrote: > How does this effect the BIC of the generated classes? Consumers might have exposed the generated classes in public API. Any chance this could become a opt-in change for KF5 times?

D24415: Add standard icons to support to all entries in QDialogButtonBox

This revision was automatically updated to reflect the committed changes. Closed by commit R252:50593c561899: Add standard icons to support to all entries in QDialogButtonBox (authored by GB_2). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

ervin updated this revision to Diff 67507. ervin added a comment. Second try, without breaking ABI... it's the best workaround I found in the current situation, I admit I died a bit inside. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D24502: Replace recursion in FilteredDirIterator with loop iteration

bruns created this revision. bruns added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case many consecutive files are skipped in a directory, the recursive next()

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. LGTM except for the abrupt end on the right side where the scrollbar's area begins, but this is a pre-existing problem with all things that butt up against a scrollbar in a scrollview, and I think we should add a vertical separator line to fix it universally.

D24493: Add draw-highlight action icons

ngraham added subscribers: ndavis, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! @ndavis? REPOSITORY R266 Breeze Icons BRANCH add-highlight-icons (branched from master) REVISION DETAIL

D24493: Add draw-highlight action icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH add-highlight-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24493 To: trickyricky26, #vdg, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

kossebau added a comment. How does this effect the BIC of the generated classes? Consumers might have exposed the generated classes in public API. Any chance this could become a opt-in change for KF5 times? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To:

D24490: Make kconfig_compiler generate ctors with the optional parent arg

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Right, makes sense. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: apol, kde-frameworks-devel,

D24496: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KConfigCore/Gui to hide deprecated API up to

D24497: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KConfigWidgets to hide deprecated API up to

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

davidedmundson added a comment. In principle + INLINE COMMENTS > kcoreconfigskeleton.h:218 > + */ > +virtual bool isDefault() const = 0; > + Is this an ABI break? :/ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma,

D24495: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KCompletion to hide deprecated API up to a

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

ervin created this revision. ervin added reviewers: Plasma, Frameworks, dfaure, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY It allows to verify if all the items of the skeleton are in their

D24430: [KCModuleLoader] Show error when QML fails to load

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kcmutils.git/commit/?id=8cea2dacd80565f6d22bf1e5151e5c7be1620eab REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D24430 To: broulik, #plasma, ngraham, mart Cc: kde-frameworks-devel,

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

GB_2 added inline comments. INLINE COMMENTS > ppeter wrote in executablefileopendialog.cpp:58 > if (mode == OnlyExecute) > connect(executeButton, ...) > else if (mode == OpenAsExecute) > ... > > looks better :) That would be against the common KDE coding style:

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.13 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/17/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 08 Oct 2019 12:41:23 + Build duration: 5 min 7 sec and counting CONSOLE OUTPUT

D24493: Add draw-highlight action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24493 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24493: Add draw-highlight action icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24493 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2,

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/24/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 08 Oct 2019 12:41:23 + Build duration: 3 min 6 sec and counting CONSOLE OUTPUT [...truncated

D24493: Add draw-highlight action icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-highlight-icons (branched from master) REVISION DETAIL

D24492: [FilteredDirIterator] Reduce stack pressure

hurikhan77 added a comment. I think we can also assume that using possibly unlimited recursion is also not good practice. Let me change that into a proper loop. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: cullmann, shubham,

D24492: [FilteredDirIterator] Reduce stack pressure

cullmann added a comment. Yes, I think you want the concept of a loop with continue. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: cullmann, shubham, kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ppeter added inline comments. INLINE COMMENTS > executablefileopendialog.cpp:58 > + > +if (mode == OnlyExecute) { > +connect(executeButton, ::clicked, > [=]{done(ExecuteFile);}); if (mode == OnlyExecute) connect(executeButton, ...) else if (mode == OpenAsExecute) ...

D24490: Make kconfig_compiler generate ctors with the optional parent arg

ervin added inline comments. INLINE COMMENTS > apol wrote in test_notifiers.cpp.ref:7 > Maybe it would be better to use the parent argument in KConfigSkeleton? > explicit KConfigSkeleton(const QString = QString(), QObject > *parent = nullptr); It's what I attempted first, the problem was that

D24429: [ConfigModule] Expose mainUi component status and error string

This revision was automatically updated to reflect the committed changes. Closed by commit R296:2c2942cee9ec: [ConfigModule] Expose mainUi component status and error string (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D24492: [FilteredDirIterator] Reduce stack pressure

shubham added a comment. It is not a good practice to "goto" in C++ REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: shubham, kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D24490: Make kconfig_compiler generate ctors with the optional parent arg

apol added a comment. +1 in spirit. INLINE COMMENTS > test_notifiers.cpp.ref:7 > +TestNotifiers::TestNotifiers( int Number, QObject *parent ) >: KConfigSkeleton( QStringLiteral( "test7rc" ) ) >, mParamNumber(Number) Maybe it would be better to use the parent argument in

D24492: [FilteredDirIterator] Reduce stack pressure

hurikhan77 created this revision. hurikhan77 added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. hurikhan77 requested review of this revision. REVISION SUMMARY Let's not call ourselves recursively in next() when the currently

D24430: [KCModuleLoader] Show error when QML fails to load

mart accepted this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D24430 To: broulik, #plasma, ngraham, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 To: broulik, #plasma, mart Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

ervin created this revision. ervin added reviewers: Plasma, Frameworks, dfaure, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490

D24489: KAutosaveFile not respecting maximum filename length

mardelle created this revision. mardelle added a reviewer: Frameworks. mardelle added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mardelle requested review of this revision. REVISION SUMMARY There are 2 different issues in current code regarding maximum filename

D24487: fix password error condition handling of smb mount

sitter created this revision. sitter added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this was previously wrong in two ways: 1. errors from the

D24387: improve error reporting for when kpasswdserver is unreachable

This revision was automatically updated to reflect the committed changes. Closed by commit R320:5a8705548fae: improve error reporting for when kpasswdserver is unreachable (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D24443: Add a plugin system

dvratil added a comment. - I would add `name` property to the `CalendarEntry` - I would add `color` property to the `CalendarEntry`, so that calendar that is e.g. green in KOrganizer would show up green in the Plasma applet, too. The Akonadi plugin for this will need to expose a list

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added a reviewer: Amarok. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, #kpublictransport, #amarok Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24387: improve error reporting for when kpasswdserver is unreachable

sitter added inline comments. INLINE COMMENTS > dfaure wrote in kio_smb_mount.cpp:72 > (pre-existing: shouldn't this call `error` rather than `finished`?) Ah yes, I was thinking the same thing but didn't manage to find a reasonable way to use this feature so it's hard to test. I'll write my

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added reviewers: Konversation, KEXI, KDE Edu, KDE PIM, KPublicTransport. davidre added a comment. Looking at lxr other users include (not exhaustive, I may have missed some) Konversation F7546131: Screenshot_20191008_105439.png Kexi (don't

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre edited the test plan for this revision. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre updated this revision to Diff 67480. davidre edited the summary of this revision. davidre added a comment. Set categoryspacing to 0 REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24453?vs=67408=67480 BRANCH newcategorystyle (branched from

D24443: Add a plugin system

vkrause added a reviewer: KDE PIM. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: vkrause, dvratil, davidedmundson, dhaumann

D24443: Add a plugin system

vkrause added a comment. In D24443#543140 , @vkrause wrote: > - Is KDeclarative is the right place for this? It's a module on the way out in KF6, it is hard to build for Android due to its dependency chain (which isn't even needed for this),