D12044: baloodb: Improve interface

ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. Very nice, I like it. This is a very handy tool now. REPOSITORY R293 Baloo BRANCH sanitize-improve-ui (branched from master) REVISION DETAIL https://phabricator.kde.org

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. Of note, this patch also makes it trivially easy to change the "Configure" icon in the future, because it makes everything that uses that icon actually point to the `configure` icon rather than a hodgepodge of different icons. REPOSITORY R266 Breeze Icons REVISION

D12051: [UDisks] Correct handling of removable file systems

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, I can confirm that this fixes the automount issue for me. +1 for making the code clearer, too. REPOSITORY R245 Solid BRANCH revert_empty_filepath_check REVISION DETAIL htt

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Without this patch, changing the view mode is unnecesarily difficult: you need to click on the settings button in

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc: sharvey, #frameworks, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. 1. System Settings uses sliders right there in its icon. :) They're already used to mean "Configure me!" in other contexts (KRunner, Plasma widgets, GTK apps) 2. Sliders aren't the same as on/off toggle buttons. We use sliders in, for example, volume controls. I do

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. If we also want to change the icon, it can't be done as a part of this patch because I've got no icon design or vector art skills whatsoever. It can't go into this patch as long as I'm the author. Like I said, I'm open to changing the icon itself, but that's a separa

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham updated this revision to Diff 31813. ngraham added a comment. Also move the Preview button over to the right, so it doesn't compete with the view mode buttons REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31779&id=31813 BRANCH show-view-mo

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham added a comment. In D12077#243556 , @broulik wrote: > Can we arrange them so that they're more consistent with Dolphin? i.e. put the Preview button at right-most Sure! F5802899: Like this.png

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham added a comment. To elaborate, the open/save dialog has four view modes: - Simple View: what most other platforms would calll "Icons view". Can be configured to have the icons to the left side of the labels (Windows style), or above them (macOS, GNOME, Cinnamon, XFCE, Elementrary

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: mmustac, broulik, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: mmustac, broulik, michaelh, ngraham, bruns

D12045: Clean up existing documentation

ngraham added a comment. Sorry, not aware of a better workflow for now, but yeah, this does not seem ideal. Perhaps real-time chat would be better, during a time when everyone's available. INLINE COMMENTS > michaelh wrote in README.md:36 > "Baloo is developed and tested exclusively for 64-b

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added a reviewer: Frameworks. ngraham edited subscribers, added: Dolphin; removed: Frameworks. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks Cc: #dolphin, cfeck, fabiank, broulik, michaelh, n

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc: abetts, sharvey, #frameworks, michaelh, ngraham, bruns

D11733: Allow opening items from the open/save dialogs

ngraham abandoned this revision. ngraham added a comment. After thinking about this for a few weeks, I can't imagine and haven't seen a use case for using the Open File dialog to open the file in a different app that wouldn't be better served in another way. REPOSITORY R241 KIO REVISION D

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. Is that "three sliders" icon one we already have, or did you just mock it up? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc: bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. If we're proposing new icons, what I'd like to see is a "base" configure iconography that you can add other things to. For example, if we use a base "two sliders" icon for "configure", then... - "Configure shortcuts" would have one of the sliders replaced with a

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. Eike reports that I have bribed him into acquiescing to this patch! 😆 Keep in mind we will be able to very easily change the icons in the future if need be, once this is landed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham updated this revision to Diff 31848. ngraham added a comment. Also add a Sort menu to the toolbar REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31813&id=31848 BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master)

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham retitled this revision from "Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs" to "Show view mode buttons and a sort menu in the open/save dialog's toolbar". ngraham edited the summary of this revision. ngraham edited the test plan

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham added a comment. I'm not thrilled about the dropdown menu button losing its an arrow when you make it activate-able with a regular click, but that's a Breeze issue (that I plan to fix soon...). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham,

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added a comment. Any more opinions on this? As you can see from the Summary section, it fixes (or obviates) a //ton// of bugs, many of them very old. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #f

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham added a comment. In D12077#244140 , @rkflx wrote: > I brought this up before, but let me repeat: It is of utmost importance to test with the default settings, i.e. default font size and default dialog size (remove `~/.config/kate*` for t

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham added a comment. In D12077#244309 , @rkflx wrote: > In D12077#244307 , @ngraham wrote: > > > Actually, the file is `~/.config/kdeglobals`, and the pertinent information is in the under the

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham updated this revision to Diff 31884. ngraham added a comment. Remove sorting menu button; will do that in a separate commit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31848&id=31884 BRANCH show-view-mode-toggles-on-open-save-dialog-toolb

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham retitled this revision from "Show view mode buttons and a sort menu in the open/save dialog's toolbar" to "Show view mode buttons in the open/save dialog's toolbar". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISI

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. How's this? F5804311: Default appearance.png Better now? That's with a new fresh user account, so I think we can be sure it's using the default settings. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.o

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added a comment. In D11993#244077 , @broulik wrote: > The only downside this has is that you can no longer resize the column wider manually but then you might as well resize the window and actually //see// more :) Precisely! :)

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added a comment. @sharvey, can you re-base this onto current master? It doesn't want to land. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, broulik,

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. In D12077#244340 , @rkflx wrote: > Okay, did look at the code ;) But please get at least one extra approval from someone else… Yep, was planning on it. In D12077#244339

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Time to fix a 14-year old wishlist bug! This patch uses the more user-friendly string "File format" to replace

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg Cc: michaelh, ngraham, bruns

D12133: Correctly encode URL of thumbnails

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Confirmed the fix! It was indeed an amazing bug report. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12133 To: davidedmundson, ngraham Cc: ngraha

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham created this revision. ngraham added reviewers: Frameworks, VDG, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY This patch improves the grid spacing in icons-on-top mode by making it looser for small icons (which gi

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added a comment. Yes, I'm afraid it's a magic number: the minimum width of each cell. I'm open to better approaches. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added a comment. FWIW I wrestled with the issue prior to submitting the patch, but couldn't come up with anything better. The issue here that we really do need a minimum width of //at least// 110px or else there's simply never enough room for titles with small icons, but there's a la

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: alexeymin, michaelh, ngraham, bruns

D11452: sanitizer: Improve device listing

ngraham added a comment. I'm afraid you guys' code writing abilities have far surpassed my code review abilities at this point! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks Cc: ngraham, bruns, smithjd, ashaposhnikov, michaelh

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx Cc: rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham planned changes to this revision. ngraham added a comment. Let's see if I can make this patch more intelligent, because the root of the issue is that the same text field is used for different things in different modes. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added inline comments. INLINE COMMENTS > kdiroperatordetailview.cpp:53 > > +<<< HEAD > void KDirOperatorDetailView::setModel(QAbstractItemModel *model) Uh-oh :) > kdiroperatordetailview.cpp:71 > +=== > +>>> Remove unneeded resize code; ensure other columns fill to content

D12160: Rebase onto fresh master

ngraham added a comment. Oops, did you mean to create a new revision? Let's just focus on the existing one. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 To: sharvey Cc: ngraham, #frameworks, michaelh, bruns

D12160: Rebase onto fresh master

ngraham added a comment. Join me in #plasma and we'll work this out. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 To: sharvey Cc: ngraham, #frameworks, michaelh, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham accepted this revision. ngraham added a comment. Works, thanks! REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham updated this revision to Diff 32015. ngraham added a comment. Change the text only when saving (it really is a filter bar in open mode) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=31936&id=32015 BRANCH file-format-label (branched from mas

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham added a comment. It's not too hard to make the label and the "What's this?" text differ for open vs save mode, which I've done here. There's still the issue that the text doesn't quite fit in save mode, where there's a filter but it's somewhat useless. I wonder: what good is the

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham retitled this revision from "Use the more user-friendly string "File format" in the open/save dialogs" to "Use the more user-friendly string "File format" in the save dialogs". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added inline comments. INLINE COMMENTS > cfeck wrote in kdiroperator.cpp:2590 > If you need a minimum width to accomodate a minimum number of characters, you > could use a value proportional to font size, e.g. "8 * metrics.height()" will > give you room for about 15 characters (they are

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham updated this revision to Diff 32017. ngraham added a comment. Take the font size into consideration with the minimum width REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12149?vs=31973&id=32017 BRANCH tighter-grid-in-icons-view (branched from master)

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: cfeck, alexeymin, michaelh, ngraham, bruns

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham updated this revision to Diff 32018. ngraham marked 2 inline comments as done. ngraham added a comment. Improve the formatting, and move the label into its own function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=32015&id=32018 BRANCH fil

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham marked 2 inline comments as done. ngraham added inline comments. INLINE COMMENTS > cfeck wrote in kfilewidget.cpp:1338 > Do you say "Save a file as a format" or "Save a file in a format"? I've always said "save as." "Save that picture as a JPEG real fast, would ya?" REPOSITORY R241 K

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham marked an inline comment as done. ngraham added a comment. In D12130#245409 , @bruns wrote: > In D12130#245373 , @ngraham wrote: > > > Change the text only when saving (it really is a filter

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham updated this revision to Diff 32030. ngraham added a comment. Use the more familiar and less technical string "File type" REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=32018&id=32030 BRANCH file-format-label (branched from master) REVISION

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham retitled this revision from "Use the more user-friendly string "File format" in the save dialogs" to "Use the more user-friendly string "File type" in the save dialogs". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO RE

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx Cc: ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a reviewer: VDG. REPOSITORY R241 KIO BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham planned changes to this revision. ngraham added a comment. In D12077#245758 , @rkflx wrote: > I know I already accepted this, but: > > > moves the preview button over to the right so it doesn't compete with the new view mode and sorti

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. One reason why I used Detailed Vew instead of Detailed Tree View was honestly because I think it has a better icon. Detailed Tree View's "squares connected with lines" iconography //tolerably// communicates "tree-style view" but not "vertical list of items" and "colu

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham planned changes to this revision. ngraham added a comment. In D12130#245721 , @cfeck wrote: > In D12130#245680 , @davidc wrote: > > > "File Type" is a big improvement over "File format." > >

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze, abetts Cc: hein, bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham updated this revision to Diff 32093. ngraham added a comment. First fix the casing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=32030&id=32093 BRANCH arcpatch-D12130 REVISION DETAIL https://phabricator.kde.org/D12130 AFFECTED FILES s

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. I'll submit some more patches tomorrow. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyf

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham added a comment. In D12130#245826 , @rkflx wrote: > > If necessary I can make the string return to "Filter" for these save-with-filter dialogs, but I'm still left wondering what the feature is actually for or if Kate is affected by a bug

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham updated this revision to Diff 32094. ngraham added a comment. Slightly reduce the minimum width REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12149?vs=32017&id=32094 BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 AFFEC

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin, michaelh, ngraham, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham updated this revision to Diff 32112. ngraham added a comment. This revision is now accepted and ready to land. Rebase on current master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31884&id=32112 BRANCH arcpatch-D12077 REVISION DETAIL h

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham updated this revision to Diff 32113. ngraham added a comment. Use Detailed Tree View and adjust separators and spacing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=32112&id=32113 BRANCH arcpatch-D12077 REVISION DETAIL https://phabricato

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. Yes, when the filename or metadata are the primary tools for differentiating files, having the items presented in a list format is much much better, as in your example of browsing for source files. But keep in mind that source files and other textual documents are on

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D12077 REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D12077 REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham updated this revision to Diff 32114. ngraham added a comment. Rebase on current master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12149?vs=32094&id=32114 BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 AFFECTED FILES

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin, michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham created this revision. ngraham added reviewers: Frameworks, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY According to a comment in the code, Open With was never supposed to show up for folders in the first place,

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns

D12207: Use text "Other Application..." in "Open With" submenu

ngraham created this revision. ngraham added reviewers: Frameworks, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Use the text "Other Application..." in the {nav Open With submenu, because it makes a bit clearer what's goi

D12207: Use text "Other Application..." in "Open With" submenu

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12207 To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham added a comment. In D12206#246282 , @michaelh wrote: > I find "Open with..." for folders useful. What apps do you typically open folders in? What's the use case? In D12206#246282 , @m

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham added a comment. So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app? Sounds reasonable enough to me. Does anyone else feel otherwise? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham added a comment. In D12206#246301 , @Zren wrote: > > So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app? > > Hmmm? Ah I missed D11569

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: Zren, michaelh, ngraham, bruns

D12206: [RFC] Don't show "Open With" for folders, as was apparently originally intended

ngraham retitled this revision from "Don't show "Open With" for folders, as was apparently originally intended" to "[RFC] Don't show "Open With" for folders, as was apparently originally intended". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #framewo

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: Zren, michaelh, ngraham, bruns

D12206: [RFC] Don't show "Open With" for folders, as was apparently originally intended

ngraham updated this revision to Diff 32153. ngraham added a comment. Instead of removing the "Open With" entries entirely, only remove the inline "Open in " entry REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32143&id=32153 BRANCH no-open-with-fo

D12206: [RFC] Don't show top "Open With" app for folders; only for files

ngraham retitled this revision from "[RFC] Don't show "Open With" for folders, as was apparently originally intended" to "[RFC] Don't show top "Open With" app for folders; only for files". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R

D12206: [RFC] Don't show top "Open With" app for folders; only for files

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: Zren, michaelh, ngraham, bruns

D12215: Add a "Reload" menu item to KDirOperator's context menu

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Add a Reload menu item to KDirOperator's context menu, so clients that don't display a toolbar but might need to r

D12215: Add a "Reload" menu item to KDirOperator's context menu

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12215 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

D12206: [RFC] Don't show top "Open With" app for folders; only for files

ngraham updated this revision to Diff 32161. ngraham added a comment. Restore original logic, minus the unnecessary extra separator REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32153&id=32161 BRANCH no-open-with-for-folders (branched from master)

<    2   3   4   5   6   7   8   9   10   11   >