[RFC v4 4/5] VSOCK: Introduce vhost_vsock.ko

2015-12-22 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> VM sockets vhost transport implementation. This driver runs on the host. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v4: * Add MAINTAINERS file entry * virtqueue used len is now size

[RFC v4 0/5] Add virtio transport for AF_VSOCK

2015-12-22 Thread Stefan Hajnoczi
) is 2 and the guest must be assigned a CID (3 in the example above). Status -- This patch series implements the latest draft specification. Please review. Asias He (4): VSOCK: Introduce virtio_vsock_common.ko VSOCK: Introduce virtio_transport.ko VSOCK: Introduce vhost_vsock.ko VSOCK

[RFC v4 3/5] VSOCK: Introduce virtio_transport.ko

2015-12-22 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> VM sockets virtio transport implementation. This driver runs in the guest. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v4: * Add MAINTAINERS file entry * Drop short/long rx packet

[RFC v4 1/5] VSOCK: transport-specific vsock_transport functions

2015-12-22 Thread Stefan Hajnoczi
function pointers. The virtio transport will use this. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- include/net/af_vsock.h | 3 +++ net/vmw_vsock/af_vsock.c | 9 + 2 files changed, 12 insertions(+) diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h index e

[RFC v4 5/5] VSOCK: Add Makefile and Kconfig

2015-12-22 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v4: * Make checkpatch.pl happy with longer option description * Clarify dependency on virtio rather than

[RFC v4 2/5] VSOCK: Introduce virtio_vsock_common.ko

2015-12-22 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> This module contains the common code and header files for the following virtio_transporto and vhost_vsock kernel modules. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v4: * Add MAIN

Re: [PATCH v3 3/4] VSOCK: Introduce vhost-vsock.ko

2015-12-15 Thread Stefan Hajnoczi
On Fri, Dec 11, 2015 at 01:45:29PM +, Alex Bennée wrote: > > + if (head == vq->num) { > > + if (unlikely(vhost_enable_notify(>dev, vq))) { > > + vhost_disable_notify(>dev, vq); > > + continue; > > Why are we doing

Re: [PATCH v3 4/4] VSOCK: Add Makefile and Kconfig

2015-12-15 Thread Stefan Hajnoczi
On Fri, Dec 11, 2015 at 05:19:08PM +, Alex Bennée wrote: > > +config VHOST_VSOCK > > + tristate "vhost virtio-vsock driver" > > + depends on VSOCKETS && EVENTFD > > + select VIRTIO_VSOCKETS_COMMON > > + select VHOST > > + select VHOST_RING > > + default n > > + ---help--- > > +

Re: [PATCH v3 1/4] VSOCK: Introduce virtio-vsock-common.ko

2015-12-10 Thread Stefan Hajnoczi
On Thu, Dec 10, 2015 at 10:17:07AM +, Alex Bennée wrote: > Stefan Hajnoczi <stefa...@redhat.com> writes: > > > From: Asias He <as...@redhat.com> > > > > This module contains the common code and header files for the following > > virtio-vsock and

Re: [PATCH v3 2/4] VSOCK: Introduce virtio-vsock.ko

2015-12-10 Thread Stefan Hajnoczi
On Thu, Dec 10, 2015 at 09:23:25PM +, Alex Bennée wrote: > Stefan Hajnoczi <stefa...@redhat.com> writes: > > > From: Asias He <as...@redhat.com> > > > > VM sockets virtio transport implementation. This module runs in guest > > kernel. > > chec

[PATCH v3 1/4] VSOCK: Introduce virtio-vsock-common.ko

2015-12-09 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> This module contains the common code and header files for the following virtio-vsock and virtio-vhost kernel modules. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v3: * Remove unnecessa

[PATCH v3 0/4] Add virtio transport for AF_VSOCK

2015-12-09 Thread Stefan Hajnoczi
Note: the virtio-vsock device specification is currently under review but not yet finalized. Please review this code but don't merge until I send an update when the spec is finalized. Thanks! v3: * Remove unnecessary 3-way handshake, just do REQUEST/RESPONSE instead of REQUEST/RESPONSE/ACK

[PATCH v3 4/4] VSOCK: Add Makefile and Kconfig

2015-12-09 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v3: * Don't put vhost vsock driver into staging * Add missing Kconfig dependencies (Arnd Bergm

[PATCH v3 3/4] VSOCK: Introduce vhost-vsock.ko

2015-12-09 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> VM sockets vhost transport implementation. This module runs in host kernel. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v3: * Remove unneeded variable used to store return value (Fengg

[PATCH v3 2/4] VSOCK: Introduce virtio-vsock.ko

2015-12-09 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> VM sockets virtio transport implementation. This module runs in guest kernel. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v2: * Fix total_tx_buf accounting * Add virtio_transport globa

[PATCH 3/6] Revert "VSOCK: Introduce vhost-vsock.ko"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 98bb892821c1ad3781b8c7daec2fc8a8de3390c9. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- drivers/vhost/vsock.c | 631 -- drivers/vhost/v

[PATCH 2/6] Revert "VSOCK: Add Makefile and Kconfig"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 8a2a2029893b4c35d1aba2932111a1a164b9c948. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- drivers/vhost/Kconfig | 4 drivers/vhost/Kconfig.vsock | 7 --- drivers

[PATCH 5/6] Revert "VSOCK: Introduce virtio-vsock-common.ko"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 80a19e338d458abb5a700df3fd00795c51361f06. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- include/linux/virtio_vsock.h| 209 - include/uapi/linux/virtio_ids.h

[PATCH 6/6] Revert "VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 357ab2234d57f6c74386f64ded42dff8e3c0500b. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- include/net/af_vsock.h | 2 -- net/vmw_vsock/af_vsock.

[PATCH 4/6] Revert "VSOCK: Introduce virtio-vsock.ko"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 32e61b06b6946ba137723c5b1de2a1fdb2e0e0a5. Keep virtio-vsock out-of-tree until the device specification is finalized. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- net/vmw_vsock/virtio_transport.c | 466 --- 1 file change

[PATCH 1/6] Revert "VSOCK: fix returnvar.cocci warnings"

2015-12-08 Thread Stefan Hajnoczi
This reverts commit 0d76d6e8b2507983a2cae4c09880798079007421. Keep virtio-vsock out-of-tree until the virtio-vsock device specification is finalized. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- drivers/vhost/vsock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH 0/6] VSOCK: revert virtio-vsock until device spec is finalized

2015-12-08 Thread Stefan Hajnoczi
and at that point the interfaces will be stable. Stefan Hajnoczi (6): Revert "VSOCK: fix returnvar.cocci warnings" Revert "VSOCK: Add Makefile and Kconfig" Revert "VSOCK: Introduce vhost-vsock.ko" Revert "VSOCK: Introduce virtio-vsock.ko" Revert

Re: [PATCH v2 0/5] Add virtio transport for AF_VSOCK

2015-12-08 Thread Stefan Hajnoczi
On Fri, Dec 04, 2015 at 09:45:04AM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2015 at 02:43:58PM +0800, Stefan Hajnoczi wrote: > > 1. The 3-way handshake isn't necessary over a reliable transport > > (virtqueue). > >Spoofing packets is also impossible so the secu

Re: [PATCH 0/6] VSOCK: revert virtio-vsock until device spec is finalized

2015-12-08 Thread Stefan Hajnoczi
On Tue, Dec 08, 2015 at 11:26:55AM -0500, David Miller wrote: > From: Stefan Hajnoczi <stefa...@redhat.com> > Date: Tue, 8 Dec 2015 19:57:30 +0800 > > > Please revert for now. > > Please don't revert it piece by piece like this. > > Instead, send me one big re

[PATCH v2] Revert "Merge branch 'vsock-virtio'"

2015-12-08 Thread Stefan Hajnoczi
this code when the hardware interface (and possibly the userspace interface) could still change. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v2: * Revert merge commit and coccinelle fixup in a single patch drivers/vhost/Kconfig |4 - drivers/vhost/Kconfig

Re: [PATCH] VSOCK: fix returnvar.cocci warnings

2015-12-06 Thread Stefan Hajnoczi
gt; static u32 vhost_transport_get_local_cid(void) > { > - u32 cid = VHOST_VSOCK_DEFAULT_HOST_CID; > - return cid; > + return VHOST_VSOCK_DEFAULT_HOST_CID; > } > > static struct vhost_vsock *vhost_vsock_get(u32 guest_cid) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

[PATCH] VSOCK: mark virtio_transport.ko experimental

2015-12-03 Thread Stefan Hajnoczi
Be explicit that the virtio_transport.ko code implements a draft virtio specification that is still subject to change. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- If you'd rather wait until the device specification has been finalized, feel free to revert the virtio-vsock code f

[PATCH v2 0/5] Add virtio transport for AF_VSOCK

2015-12-01 Thread Stefan Hajnoczi
v2: * Rebased onto Linux v4.4-rc2 * vhost: Refuse to assign reserved CIDs * vhost: Refuse guest CID if already in use * vhost: Only accept correctly addressed packets (no spoofing!) * vhost: Support flexible rx/tx descriptor layout * vhost: Add missing total_tx_buf decrement *

[PATCH v2 3/5] VSOCK: Introduce virtio-vsock.ko

2015-12-01 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> VM sockets virtio transport implementation. This module runs in guest kernel. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v2: * Fix total_tx_buf accounting * Add virtio_transport globa

[PATCH v2 4/5] VSOCK: Introduce vhost-vsock.ko

2015-12-01 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> VM sockets vhost transport implementation. This module runs in host kernel. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v2: * Add missing total_tx_buf decrement * Support flexible rx/tx

[PATCH v2 2/5] VSOCK: Introduce virtio-vsock-common.ko

2015-12-01 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> This module contains the common code and header files for the following virtio-vsock and virtio-vhost kernel modules. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- v2: * Fix peer_buf

[PATCH v2 5/5] VSOCK: Add Makefile and Kconfig

2015-12-01 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- drivers/vhost/Kconfig | 4 drivers/vhost/Kconfig.vsock | 7 +++ drivers/vhost/Makefile

[PATCH v2 1/5] VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic

2015-12-01 Thread Stefan Hajnoczi
From: Asias He <as...@redhat.com> Signed-off-by: Asias He <as...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsock.c | 70 2 files changed, 72 inserti

Re: best way to create a snapshot of a running vm ?

2015-12-01 Thread Stefan Hajnoczi
On Mon, Nov 30, 2015 at 04:34:14PM +0100, Lentes, Bernd wrote: > Stefan wrote: > > > > > Hi Bernd, > > qemu-img cannot be used on the disk image when the VM is running. > > Please use virsh, it communicates with the running QEMU process and > > ensures that the snapshot is crash-consistent. > >

Re: [PATCH v8 0/5] implement vNVDIMM

2015-11-30 Thread Stefan Hajnoczi
eader > nvdimm acpi: build ACPI NFIT table > nvdimm acpi: build ACPI nvdimm devices > nvdimm: add maintain info > > MAINTAINERS | 7 + > default-configs/i386-softmmu.mak | 2 + > default-configs/x86_64-softmmu.mak | 2 + > hw/acpi/Makefile.objs | 1 + > hw/acpi/aml-build.c| 15 +- > hw/acpi/ich9.c | 19 ++ > hw/acpi/memory_hotplug.c | 5 + > hw/acpi/nvdimm.c | 467 > + > hw/acpi/piix4.c| 4 + > hw/arm/virt-acpi-build.c | 13 +- > hw/i386/acpi-build.c | 26 ++- > hw/mem/Makefile.objs | 1 + > hw/mem/nvdimm.c| 46 > include/hw/acpi/aml-build.h| 3 +- > include/hw/acpi/ich9.h | 3 + > include/hw/i386/pc.h | 12 +- > include/hw/mem/nvdimm.h| 41 > 17 files changed, 645 insertions(+), 22 deletions(-) > create mode 100644 hw/acpi/nvdimm.c > create mode 100644 hw/mem/nvdimm.c > create mode 100644 include/hw/mem/nvdimm.h Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: best way to create a snapshot of a running vm ?

2015-11-30 Thread Stefan Hajnoczi
On Mon, Nov 30, 2015 at 12:36:56AM +0100, Lentes, Bernd wrote: > what is the best way to create a snapshot of a running vm ? qemu-img or virsh > ? > I#d like to create a snapshot which is copied afterwards by other means, e.g. > by a network based backup software. Hi Bernd, qemu-img cannot be

Re: [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM

2015-11-23 Thread Stefan Hajnoczi
On Thu, Nov 19, 2015 at 10:39:05AM +0800, Xiao Guangrong wrote: > On 11/19/2015 04:44 AM, Michael S. Tsirkin wrote: > >On Wed, Nov 18, 2015 at 05:18:17PM -0200, Eduardo Habkost wrote: > >>On Wed, Nov 18, 2015 at 09:59:34AM +0800, Xiao Guangrong wrote: > >sorry, I'm busy with 2.5 now, and this is

Re: [PATCH v7 00/35] implement vNVDIMM

2015-11-02 Thread Stefan Hajnoczi
I have reviewed ACPI interface: Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [PATCH v6 00/33] implement vNVDIMM

2015-10-30 Thread Stefan Hajnoczi
t; include/qemu/osdep.h |1 + > numa.c |4 +- > qapi-schema.json |8 +- > qmp.c |4 +- > stubs/Makefile.objs|2 +- > ...c_dimm_device_list.c => qmp_dimm_device_list.c} |4 +- > target-ppc/kvm.c | 21 +- > trace-events |8 +- > util/oslib-posix.c | 16 + > util/oslib-win32.c |5 + > 43 files changed, 2224 insertions(+), 838 deletions(-) > create mode 100644 docs/specs/acpi_nvdimm.txt > create mode 100644 hw/acpi/nvdimm.c > rename hw/mem/{pc-dimm.c => dimm.c} (65%) > create mode 100644 hw/mem/nvdimm.c > rewrite hw/mem/pc-dimm.c (91%) > create mode 100644 include/hw/mem/dimm.h > create mode 100644 include/hw/mem/nvdimm.h > rewrite include/hw/mem/pc-dimm.h (97%) > rename stubs/{qmp_pc_dimm_device_list.c => qmp_dimm_device_list.c} (56%) I've reviewed the interface that ACPI inside the guest uses to communicate with QEMU. I haven't reviewed the actual ACPI generation or pc-dimm device model parts. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [PATCH v6 27/33] nvdimm acpi: support function 0

2015-10-30 Thread Stefan Hajnoczi
On Fri, Oct 30, 2015 at 01:56:21PM +0800, Xiao Guangrong wrote: > static uint64_t > nvdimm_dsm_read(void *opaque, hwaddr addr, unsigned size) > { > -return 0; > +AcpiNVDIMMState *state = opaque; > +MemoryRegion *dsm_ram_mr = >ram_mr; > +NvdimmDsmIn *in; > +GArray *out; > +

Re: [Qemu-devel] [PATCH v5 28/33] nvdimm acpi: support Get Namespace Label Size function

2015-10-29 Thread Stefan Hajnoczi
On Thu, Oct 29, 2015 at 10:16:14AM +0800, Xiao Guangrong wrote: > > > On 10/29/2015 12:41 AM, Stefan Hajnoczi wrote: > >On Wed, Oct 28, 2015 at 10:26:26PM +, Xiao Guangrong wrote: > >>+struct nvdimm_func_in_get_label_data { > >>+uint32_t offset; /* the o

Re: [PATCH v5 27/33] nvdimm acpi: support function 0

2015-10-28 Thread Stefan Hajnoczi
> hw/acpi/nvdimm.c| 156 > +++- > include/hw/acpi/aml-build.h | 1 + > 3 files changed, 157 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [PATCH v5 30/33] nvdimm acpi: support Set Namespace Label Data function

2015-10-28 Thread Stefan Hajnoczi
On Wed, Oct 28, 2015 at 10:26:28PM +, Xiao Guangrong wrote: > +static void nvdimm_dsm_func_set_label_data(NVDIMMDevice *nvdimm, > + nvdimm_dsm_in *in, GArray *out) > +{ > +NVDIMMClass *nvc = NVDIMM_GET_CLASS(nvdimm); > +

Re: [PATCH v5 29/33] nvdimm acpi: support Get Namespace Label Data function

2015-10-28 Thread Stefan Hajnoczi
On Wed, Oct 28, 2015 at 10:26:27PM +, Xiao Guangrong wrote: > +static void nvdimm_dsm_func_get_label_data(NVDIMMDevice *nvdimm, > + nvdimm_dsm_in *in, GArray *out) > +{ > +NVDIMMClass *nvc = NVDIMM_GET_CLASS(nvdimm); > +

Re: [PATCH v5 28/33] nvdimm acpi: support Get Namespace Label Size function

2015-10-28 Thread Stefan Hajnoczi
On Wed, Oct 28, 2015 at 10:26:26PM +, Xiao Guangrong wrote: > +struct nvdimm_func_in_get_label_data { > +uint32_t offset; /* the offset in the namespace label data area. */ > +uint32_t length; /* the size of data is to be read via the function. */ > +} QEMU_PACKED; > +typedef struct

Re: virtio assisted migration

2015-10-28 Thread Stefan Hajnoczi
On Sat, Oct 24, 2015 at 05:21:01PM +0800, Dave Young wrote: > * block device > For block storage migration, the problem is similar as memory. The original > migration does not consider storage usage ratio it just copy all the sectors. This is equivalent to issuing discard requests. File systems

Re: [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

2015-10-21 Thread Stefan Hajnoczi
On Wed, Oct 21, 2015 at 12:26:35AM +0800, Xiao Guangrong wrote: > > > On 10/20/2015 11:51 PM, Stefan Hajnoczi wrote: > >On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote: > >>+exit: > >>+/* Write our output result to dsm memory. */ > >>

Re: [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

2015-10-20 Thread Stefan Hajnoczi
On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote: > +exit: > +/* Write our output result to dsm memory. */ > +((dsm_out *)dsm_ram_addr)->len = out->len; Missing byteswap? I thought you were going to remove this field because it wasn't needed by the guest. -- To unsubscribe

Re: just an observation about USB

2015-10-16 Thread Stefan Hajnoczi
On Wed, Oct 14, 2015 at 04:30:22PM -0400, Eric S. Johansson wrote: > On 10/14/2015 04:04 PM, Paolo Bonzini wrote: > >On 14/10/2015 21:39, Eric S. Johansson wrote: > >>Latency is a bit longer than I like. USB and network connections break > >>every time I come out of suspend part at least I don't

Re: [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

2015-10-15 Thread Stefan Hajnoczi
On Wed, Oct 14, 2015 at 10:50:40PM +0800, Xiao Guangrong wrote: > On 10/14/2015 05:40 PM, Stefan Hajnoczi wrote: > >On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: > >>+out = (dsm_out *)in; > >>+ > >>+revision = in->arg1; > &

Re: [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

2015-10-15 Thread Stefan Hajnoczi
On Wed, Oct 14, 2015 at 10:52:15PM +0800, Xiao Guangrong wrote: > On 10/14/2015 05:41 PM, Stefan Hajnoczi wrote: > >On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: > >>+out->len = sizeof(out->status); > > > >out->len is uint16_t, it n

Re: Inconsistent guest OS disk size compared to volume.img size

2015-10-14 Thread Stefan Hajnoczi
On Tue, Sep 29, 2015 at 12:02:17AM -0700, Jay Fishman wrote: > I have looked all over the internet but I can not even find a > reference to this issue. > > > I have installed the following on Linux Mint 17.1 > QEMU emulator version 2.0.0 (Debian 2.0.0+dfsg-2ubuntu1.19), Fabrice Bellard > > On

Re: [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

2015-10-14 Thread Stefan Hajnoczi
On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: > static void dsm_write(void *opaque, hwaddr addr, >uint64_t val, unsigned size) > { > +NVDIMMState *state = opaque; > +MemoryRegion *dsm_ram_mr; > +dsm_in *in; > +dsm_out *out; > +

Re: AIO requests may be disordered by Qemu-kvm iothread with disk cache=writethrough, Bug or Feature?

2015-10-14 Thread Stefan Hajnoczi
On Thu, Oct 08, 2015 at 07:59:56PM +0800, charlie.song wrote: > We recently try to use Linux AIO from guest OS and find that the IOthread > mechanism of Qemu-KVM will reorder I/O requests from guest OS > even when the AIO write requests are issued from a single thread in order. > This does

Re: [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

2015-10-14 Thread Stefan Hajnoczi
On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: > +out->len = sizeof(out->status); out->len is uint16_t, it needs cpu_to_le16(). There may be other instances in this patch series. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to

Re: QEMU Technical Talk: NVDIMM and persistent memory in QEMU

2015-10-12 Thread Stefan Hajnoczi
On Mon, Oct 5, 2015 at 8:52 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote: Just a reminder that QEMU's first technical talk is today (Monday, 12 October 2015) at 14:00 UTC. We will be using Hangouts On Air for video/audio. The URL is: https://plus.google.com/events/cfssoojfogaafulssb1qe

Re: QEMU Technical Talk: NVDIMM and persistent memory in QEMU

2015-10-12 Thread Stefan Hajnoczi
Thanks to everyone who joined and to Marc Mari for giving the presentation. The next QEMU technical talk will be announced to the mailing list in a few days. Video: https://www.youtube.com/watch?v=Vit3-PjbN9M#t=13m02s Slides (PDF): http://vmsplice.net/~stefan/nvdimm_slides_public.pdf Stefan --

Re: [Qemu-devel] [PATCH v2 00/18] implement vNVDIMM

2015-10-09 Thread Stefan Hajnoczi
On Wed, Oct 07, 2015 at 10:43:40PM +0800, Xiao Guangrong wrote: > > > On 10/07/2015 10:02 PM, Stefan Hajnoczi wrote: > >On Wed, Aug 26, 2015 at 06:49:35PM +0800, Xiao Guangrong wrote: > >>On 08/26/2015 12:26 AM, Stefan Hajnoczi wrote: > >>>On Fri, Aug 14, 2015

Re: [Qemu-devel] [PATCH v2 00/18] implement vNVDIMM

2015-10-07 Thread Stefan Hajnoczi
On Wed, Aug 26, 2015 at 06:49:35PM +0800, Xiao Guangrong wrote: > On 08/26/2015 12:26 AM, Stefan Hajnoczi wrote: > >On Fri, Aug 14, 2015 at 10:51:53PM +0800, Xiao Guangrong wrote: > >Have you thought about live migration? > > > >Are the contents of the NVDIMM migrate

Re: [Qemu-devel] [RFC PATCH v4] os-android: Add support to android platform

2015-10-06 Thread Stefan Hajnoczi
On Sat, Oct 03, 2015 at 12:44:14PM +0800, Houcheng Lin wrote: > diff --git a/configure b/configure > index d7c24cd..cda88c1 100755 > --- a/configure > +++ b/configure > @@ -567,7 +567,6 @@ fi > > # host *BSD for user mode > HOST_VARIANT_DIR="" > - > case $targetos in > CYGWIN*) >

Who wants to mentor for Outreachy Dec-Mar?

2015-09-09 Thread Stefan Hajnoczi
We are now looking for mentors for the next round of Outreachy running from December 7, 2015 to March 7, 2016. I have set up a wiki page here: http://qemu-project.org/Outreachy_2015_DecemberMarch Our communities have participated in previous years to mentor people from underrepresented groups

Re: Who wants to mentor for Outreachy Dec-Mar?

2015-09-09 Thread Stefan Hajnoczi
On Wed, Sep 9, 2015 at 12:59 PM, Michal Privoznik <mpriv...@redhat.com> wrote: > On 09.09.2015 12:28, Stefan Hajnoczi wrote: >> We are now looking for mentors for the next round of Outreachy running >> from December 7, 2015 to March 7, 2016. I have set up a wiki page &g

Re: KVM: Security Policy

2015-09-02 Thread Stefan Hajnoczi
On Thu, Aug 27, 2015 at 02:01:52PM +0200, Stefan Geißler wrote: > Hello kvm mailing list, > > I assume, this is a rather uncommon mailing list post since it is not > directly related to the usage or development of KVM. Instead, the following > is the case: > > I am a student of computer science

Re: [Qemu-devel] [PATCH v2 14/18] nvdimm: support NFIT_CMD_IMPLEMENTED function

2015-09-01 Thread Stefan Hajnoczi
On Mon, Aug 31, 2015 at 02:51:50PM +0800, Xiao Guangrong wrote: > > > On 08/28/2015 08:01 PM, Stefan Hajnoczi wrote: > >On Wed, Aug 26, 2015 at 06:46:35PM +0800, Xiao Guangrong wrote: > >>On 08/26/2015 12:23 AM, Stefan Hajnoczi wrote: > >>>On Fri, Aug 14, 2015

Re: [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-01 Thread Stefan Hajnoczi
On Mon, Aug 31, 2015 at 02:23:43PM +0800, Xiao Guangrong wrote: > > Hi Stefan, > > On 08/28/2015 07:58 PM, Stefan Hajnoczi wrote: > > > > >>>>+goto do_unmap; > >>>>+} > >>>>+ > >>>>+nvdimm

Re: [Qemu-devel] [PATCH v2 13/18] nvdimm: build namespace config data

2015-08-28 Thread Stefan Hajnoczi
On Wed, Aug 26, 2015 at 06:42:01PM +0800, Xiao Guangrong wrote: On 08/26/2015 12:16 AM, Stefan Hajnoczi wrote: On Fri, Aug 14, 2015 at 10:52:06PM +0800, Xiao Guangrong wrote: +#ifdef NVDIMM_DEBUG +#define nvdebug(fmt, ...) fprintf(stderr, nvdimm: fmt, ## __VA_ARGS__) +#else +#define

Re: [PATCH v2 14/18] nvdimm: support NFIT_CMD_IMPLEMENTED function

2015-08-28 Thread Stefan Hajnoczi
On Wed, Aug 26, 2015 at 06:46:35PM +0800, Xiao Guangrong wrote: On 08/26/2015 12:23 AM, Stefan Hajnoczi wrote: On Fri, Aug 14, 2015 at 10:52:07PM +0800, Xiao Guangrong wrote: static void dsm_write(void *opaque, hwaddr addr, uint64_t val, unsigned size

Re: [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-08-28 Thread Stefan Hajnoczi
On Wed, Aug 26, 2015 at 06:40:26PM +0800, Xiao Guangrong wrote: On 08/26/2015 12:03 AM, Stefan Hajnoczi wrote: On Fri, Aug 14, 2015 at 10:52:01PM +0800, Xiao Guangrong wrote: +if (fd 0) { +error_setg(errp, can not open %s, nvdimm-file); s/can not/cannot/ +return

Re: [PATCH v2 14/18] nvdimm: support NFIT_CMD_IMPLEMENTED function

2015-08-25 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 10:52:07PM +0800, Xiao Guangrong wrote: @@ -306,6 +354,18 @@ struct dsm_buffer { static ram_addr_t dsm_addr; static size_t dsm_size; +struct cmd_out_implemented { QEMU coding style uses typedef struct {} CamelCase. Please follow this convention in all

Re: [Qemu-devel] [PATCH v2 00/18] implement vNVDIMM

2015-08-25 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 10:51:53PM +0800, Xiao Guangrong wrote: Changlog: - Use litten endian for DSM method, thanks for Stefan's suggestion - introduce a new parameter, @configdata, if it's false, Qemu will build a static and readonly namespace in memory and use it serveing for DSM

Re: [PATCH v2 10/18] nvdimm: init the address region used by DSM method

2015-08-25 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 10:52:03PM +0800, Xiao Guangrong wrote: @@ -257,14 +258,91 @@ static void build_nfit_table(GSList *device_list, char *buf) } } +struct dsm_buffer { +/* RAM page. */ +uint32_t handle; +uint8_t arg0[16]; +uint32_t arg1; +uint32_t arg2;

Re: [Qemu-devel] [PATCH v2 13/18] nvdimm: build namespace config data

2015-08-25 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 10:52:06PM +0800, Xiao Guangrong wrote: +#ifdef NVDIMM_DEBUG +#define nvdebug(fmt, ...) fprintf(stderr, nvdimm: fmt, ## __VA_ARGS__) +#else +#define nvdebug(...) +#endif The following allows the compiler to check format strings and syntax check the argument

Re: [PATCH v2 15/18] nvdimm: support NFIT_CMD_GET_CONFIG_SIZE function

2015-08-25 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 10:52:08PM +0800, Xiao Guangrong wrote: Function 4 is used to get Namespace lable size s/lable/label/ -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device abstract

2015-08-25 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 10:51:59PM +0800, Xiao Guangrong wrote: +static void set_file(Object *obj, const char *str, Error **errp) +{ +PCNVDIMMDevice *nvdimm = PC_NVDIMM(obj); + +if (nvdimm-file) { +g_free(nvdimm-file); +} g_free(NULL) is a nop so it's safe to replace

Re: [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM

2015-08-25 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote: diff --git a/hw/mem/nvdimm/pc-nvdimm.c b/hw/mem/nvdimm/pc-nvdimm.c index a53d235..7a270a8 100644 --- a/hw/mem/nvdimm/pc-nvdimm.c +++ b/hw/mem/nvdimm/pc-nvdimm.c @@ -24,6 +24,19 @@ #include hw/mem/pc-nvdimm.h +#define

Re: [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-08-25 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 10:52:01PM +0800, Xiao Guangrong wrote: The parameter @file is used as backed memory for NVDIMM which is divided into two parts if @dataconfig is true: s/dataconfig/configdata/ @@ -76,13 +109,87 @@ static void pc_nvdimm_init(Object *obj)

Re: [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM

2015-08-25 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote: NVDIMM reserves all the free range above 4G to do: - Persistent Memory (PMEM) mapping - implement NVDIMM ACPI device _DSM method Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/i386/pc.c | 12

Re: Fwd: KVM : Virtio ring size

2015-08-10 Thread Stefan Hajnoczi
On Fri, Aug 07, 2015 at 10:48:50AM +0530, sai kiran wrote: I am experimenting on Virtio-net frontend driver. And I observe that the virtio ring size is communicated to guest as 256. I tried changing backend-qemu code manually, to propagate 512 ring size. But other than changing code and

Re: Live migration using shared storage in different networks

2015-07-09 Thread Stefan Hajnoczi
On Mon, Jul 06, 2015 at 09:44:07AM +0100, Miguel Barbosa Gonçalves wrote: I am building a KVM cluster that needs VM live migration. My shared storage as well as the KVM hosts will be running CentOS. Because 10 Gbps Ethernet switches are very expensive at the moment I will connect the KVM

Re: [PATCH 14/16] nvdimm: support NFIT_CMD_GET_CONFIG_SIZE function

2015-07-02 Thread Stefan Hajnoczi
On Wed, Jul 01, 2015 at 10:50:30PM +0800, Xiao Guangrong wrote: +static uint32_t dsm_cmd_config_size(struct dsm_buffer *in, struct dsm_out *out) +{ +GSList *list = get_nvdimm_built_list(); +PCNVDIMMDevice *nvdimm = get_nvdimm_device_by_handle(list, in-handle); +uint32_t status =

Re: [Qemu-devel] [PATCH 00/16] implement vNVDIMM

2015-07-02 Thread Stefan Hajnoczi
On Thu, Jul 02, 2015 at 02:34:05PM +0800, Xiao Guangrong wrote: On 07/02/2015 02:17 PM, Michael S. Tsirkin wrote: On Wed, Jul 01, 2015 at 10:50:16PM +0800, Xiao Guangrong wrote: hw/acpi/aml-build.c | 32 +- hw/i386/acpi-build.c|9 +- hw/i386/acpi-dsdt.dsl |

Re: [Qemu-devel] [PATCH 00/16] implement vNVDIMM

2015-07-02 Thread Stefan Hajnoczi
On Wed, Jul 01, 2015 at 10:50:16PM +0800, Xiao Guangrong wrote: == Background == NVDIMM (A Non-Volatile Dual In-line Memory Module) is going to be supported on Intel's platform. They are discovered via ACPI and configured by _DSM method of NVDIMM device in ACPI. There has some

Re: Announcing qboot, a minimal x86 firmware for QEMU

2015-06-05 Thread Stefan Hajnoczi
On Tue, May 26, 2015 at 9:47 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, May 22, 2015 at 10:53:54AM +0800, Yong Wang wrote: On Thu, May 21, 2015 at 03:51:43PM +0200, Paolo Bonzini wrote: On the QEMU side, there is no support yet for persistent memory and the NFIT tables from ACPI

[RFC 6/6] VSOCK: Add Makefile and Kconfig

2015-05-27 Thread Stefan Hajnoczi
From: Asias He as...@redhat.com Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He as...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- drivers/vhost/Kconfig | 4 drivers/vhost/Kconfig.vsock | 7 +++ drivers/vhost/Makefile | 4 net

[RFC 5/6] VSOCK: Introduce vhost-vsock.ko

2015-05-27 Thread Stefan Hajnoczi
From: Asias He as...@redhat.com VM sockets vhost transport implementation. This module runs in host kernel. Signed-off-by: Asias He as...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- drivers/vhost/vsock.c | 596 ++ drivers

[RFC 2/6] Add dgram_skb to vsock_sock

2015-05-27 Thread Stefan Hajnoczi
From: Asias He as...@redhat.com This list will be used to match received packets when multiple packets are used because datagram size is larger than the receive buffer size. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/net/af_vsock.h | 1 + net/vmw_vsock/af_vsock.c | 1 + 2

[RFC 0/6] Add virtio transport for AF_VSOCK

2015-05-27 Thread Stefan Hajnoczi
This patch series adds a virtio transport for AF_VSOCK (net/vmw_vsock/). AF_VSOCK is designed for communication between virtual machines and hypervisors. It is currently only implemented for VMware's VMCI transport. This series implements the proposed virtio-vsock device specification from here:

[RFC 4/6] VSOCK: Introduce virtio-vsock.ko

2015-05-27 Thread Stefan Hajnoczi
From: Asias He as...@redhat.com VM sockets virtio transport implementation. This module runs in guest kernel. Signed-off-by: Asias He as...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- net/vmw_vsock/virtio_transport.c | 450 +++ 1 file

[RFC 1/6] VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic

2015-05-27 Thread Stefan Hajnoczi
From: Asias He as...@redhat.com Signed-off-by: Asias He as...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsock.c | 70 2 files changed, 72 insertions(+) diff --git

[RFC 3/6] VSOCK: Introduce virtio-vsock-common.ko

2015-05-27 Thread Stefan Hajnoczi
From: Asias He as...@redhat.com This module contains the common code and header files for the following virtio-vsock and virtio-vhost kernel modules. Signed-off-by: Asias He as...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/linux/virtio_vsock.h| 207

Re: Announcing qboot, a minimal x86 firmware for QEMU

2015-05-26 Thread Stefan Hajnoczi
On Fri, May 22, 2015 at 10:53:54AM +0800, Yong Wang wrote: On Thu, May 21, 2015 at 03:51:43PM +0200, Paolo Bonzini wrote: On the QEMU side, there is no support yet for persistent memory and the NFIT tables from ACPI 6.0. Once that (and ACPI support) is added, qboot will automatically start

Re: [GSoC] project proposal

2015-04-23 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 9:51 AM, Catalin Vasile catalinvasil...@gmail.com wrote: On Wed, Apr 22, 2015 at 11:20 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Apr 21, 2015 at 04:07:56PM +0200, Paolo Bonzini wrote: On 21/04/2015 16:07, Catalin Vasile wrote: I don't get the part

Re: [GSoC] project proposal

2015-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2015 at 04:07:56PM +0200, Paolo Bonzini wrote: On 21/04/2015 16:07, Catalin Vasile wrote: I don't get the part with getting cryptodev upstream. I don't know what getting cryptodev upstream actually implies. From what I know cryptodev is done (is a functional project) that

Re: [GSoC] project proposal

2015-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2015 at 05:24:55PM +0300, Catalin Vasile wrote: Can you give me more details on GnuTLS? I'm going through some documentation and code and I see that it doesn't actually have separate encryption and authentication primitives. gnutls is a natural choice because QEMU already uses

x2apic issues with Solaris and Xen guests

2015-04-20 Thread Stefan Hajnoczi
I wonder whether the following two x2apic issues are related: Solaris 10 U11 network doesn't work https://bugzilla.redhat.com/show_bug.cgi?id=1040500 kvm - fails to setup timer interrupt via io-apic (Thanks to Michael Tokarev for posting this link)

Re: [GSoC] project proposal

2015-03-31 Thread Stefan Hajnoczi
On Wed, Mar 18, 2015 at 8:59 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 18/03/2015 18:05, Catalin Vasile wrote: cryptodev is not merged into upstream from what I know. Yes, but QEMU runs on non-Linux platforms too. Of course doing vhost+driver or gnutls+driver would be already more than

Re: iscsi multipath failure with libvirtError: Failed to open file '/dev/mapper/Mar': No such file or directory

2015-03-27 Thread Stefan Hajnoczi
On Mon, Mar 23, 2015 at 10:14:31PM +0530, mad Engineer wrote: hello All, I know the issue is related to libvirt,but i dont know where to ask. The libvirt mailing list is the place to ask libvirt questions. I have CCed it. i have centos 6.6 running KVM as compute node in

Re: KVM live migration i/o error

2015-03-23 Thread Stefan Hajnoczi
On Fri, Mar 20, 2015 at 12:34:59PM +0100, Francesc Guasch wrote: On Fri, Mar 20, 2015 at 10:03:20AM +, Stefan Hajnoczi wrote: Hi Stefan, thank you very much for answering me. On Wed, Mar 18, 2015 at 04:53:28PM +0100, Francesc Guasch wrote: I have three Ubuntu Server 14.04 trusty

Re: Windows 7 guest installer does not detect drive if physical partition used instead of disk file.

2015-03-23 Thread Stefan Hajnoczi
On Sat, Mar 21, 2015 at 01:50:46AM +0800, Emmanuel Noobadmin wrote: Running 3.18.9-200.fc21.x86_64 qemu 2:2.1.3-3.fc21 libvirt 1.2.9.2-1.fc21 System is a Thinkpad X250 with Intel i7-5600u Broadwell GT2 I'm trying to replace the Win7 installation on my laptop with Fedora 21 and

Re: KVM live migration i/o error

2015-03-20 Thread Stefan Hajnoczi
On Wed, Mar 18, 2015 at 04:53:28PM +0100, Francesc Guasch wrote: I have three Ubuntu Server 14.04 trusty with KVM. Two of them are HP servers and one is Dell. Both brands run fine the KVM virtual servers, and I can do live migration between the HPs. But I get I/O errors in the vda when I

  1   2   3   4   5   6   7   8   9   >