Re: [PATCH v8 06/14] lockdep: Detect and handle hist_lock ring buffer overwrite

2017-08-10 Thread Peter Zijlstra
On Thu, Aug 10, 2017 at 10:32:16AM +0900, Byungchul Park wrote: > On Wed, Aug 09, 2017 at 04:16:05PM +0200, Peter Zijlstra wrote: > > Hehe, _another_ scheme... > > > > Yes I think this works.. but I had just sort of understood the last one. > > > > How about I do this on top? That I think is a co

[PATCH v2] nvme: Fix nvme reset command timeout handling

2017-08-10 Thread Johannes Thumshirn
From: Keith Busch We need to return an error if a timeout occurs on any NVMe command during initialization. Without this, the nvme reset work will be stuck. A timeout will have a negative error code, meaning we need to stop initializing the controller. All postitive returns mean the controller is

Re: [PATCH v8 11/14] lockdep: Apply crossrelease to PG_locked locks

2017-08-10 Thread Peter Zijlstra
On Thu, Aug 10, 2017 at 10:35:02AM +0900, Byungchul Park wrote: > On Mon, Aug 07, 2017 at 04:12:58PM +0900, Byungchul Park wrote: > > Although lock_page() and its family can cause deadlock, the lock > > correctness validator could not be applied to them until now, becasue > > things like unlock_pag

Re: [RFC PATCH] PCI: rockchip: fix system hang up if activate CONFIG_DEBUG_SHIRQ

2017-08-10 Thread jeffy
Hi shawn, On 08/10/2017 05:14 PM, Shawn Lin wrote: Hi Jeffy On 2017/8/10 16:39, jeffy wrote: Hi shawn, On 08/10/2017 04:21 PM, Shawn Lin wrote: With CONFIG_DEBUG_SHIRQ enabled, the irq tear down routine would still access the irq handler registed as a shard irq. Per the comment within the fu

Re: [PATCH] arcmsr: add const to bin_attribute structures

2017-08-10 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v2] nvme: Fix nvme reset command timeout handling

2017-08-10 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [RFC PATCH] PCI: rockchip: fix system hang up if activate CONFIG_DEBUG_SHIRQ

2017-08-10 Thread Heiko Stuebner
Hi Shawn, Am Donnerstag, 10. August 2017, 16:21:13 CEST schrieb Shawn Lin: > With CONFIG_DEBUG_SHIRQ enabled, the irq tear down routine > would still access the irq handler registed as a shard irq. > Per the comment within the function of __free_irq, it says > "It's a shared IRQ -- the driver ough

Re: [RFC PATCH 2/6] bsg: assign sense_len instead of fixed SCSI_SENSE_BUFFERSIZE

2017-08-10 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [RFC PATCH 1/6] bsg: fix kernel panic resulting from missing allocation of a reply-buffer

2017-08-10 Thread Christoph Hellwig
We can't use an on-stack buffer for the sense data, as drivers will dma to it. So we should reuse the SCSI init_rq_fn() for the BSG queues and/or implement the same scheme.

Re: [RFC PATCH 3/6] bsg: scsi-transport: add compile-tests to prevent reply-buffer overflows

2017-08-10 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH] userfaultfd: replace ENOSPC with ESRCH in case mm has gone during copy/zeropage

2017-08-10 Thread Michal Hocko
On Tue 08-08-17 09:08:17, Mike Rapoport wrote: > (adding Michal) Thanks > On Mon, Aug 07, 2017 at 04:12:25PM +0300, Mike Rapoport wrote: > > When the process exit races with outstanding mcopy_atomic, it would be > > better to return ESRCH error. When such race occurs the process and it's mm > > a

Re: [RFC PATCH 4/6] bsg: refactor ioctl to use regular BSG-command infrastructure for SG_IO

2017-08-10 Thread Christoph Hellwig
On Thu, Aug 10, 2017 at 10:24:56AM +0200, Johannes Thumshirn wrote: > On Wed, Aug 09, 2017 at 04:11:18PM +0200, Benjamin Block wrote: > > + return 0 == (bc->hdr.flags & BSG_FLAG_Q_AT_TAIL); > > return !(bc->hdr.flags & BSG_FLAG_Q_AT_TAIL); and make the function return > bool? I have to admit, th

Re: [RFC PATCH 5/6] bsg: reduce unnecessary arguments for bsg_map_hdr()

2017-08-10 Thread Christoph Hellwig
On Wed, Aug 09, 2017 at 04:11:19PM +0200, Benjamin Block wrote: > Since struct bsg_command is now used in every calling case, we don't > need separation of arguments anymore that are contained in the same > bsg_command. > > Signed-off-by: Benjamin Block > --- > block/bsg.c | 13 ++--- >

Re: [RFC PATCH 6/6] bsg: reduce unnecessary arguments for blk_complete_sgv4_hdr_rq()

2017-08-10 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

2017-08-10 Thread Sandy Huang
Hi Sean Paul, Thanks for your review. 在 2017/8/10 3:58, Sean Paul 写道: On Wed, Aug 09, 2017 at 06:00:59PM +0800, Sandy Huang wrote: This adds support for Rockchip soc lvds found on rk3288 Based on the patches from Mark yao and Heiko Stuebner Signed-off-by: Sandy Huang Signed-off-by: Mark y

Re: [PATCH v8 00/14] lockdep: Implement crossrelease feature

2017-08-10 Thread Byungchul Park
On Wed, Aug 09, 2017 at 05:50:59PM +0200, Peter Zijlstra wrote: > > > Heh, look what it does... Wait.. execuse me but.. is it a real problem? > > > 4== > 4WARNING: possible circular locking dependency detected > 4.13.0-rc2-00317-gadc6764a3ad

[PATCH] Subject:drivers:staging:media:atomisp:

2017-08-10 Thread Harold Gomez
Fix Warning from checkpatch.pl Block comments use * on subsequent lines Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp

Re: [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2)

2017-08-10 Thread Jean Delvare
On mer., 2017-08-09 at 09:18 -0700, Matt Roper wrote: > On Mon, Jul 31, 2017 at 10:36:05AM +0200, Jean Delvare wrote: > > > > Hi Matt, Mauro, > > > > On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote: > > > > > > On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote: > > > > > > > > A coupl

Re: [RFC PATCH] PCI: rockchip: fix system hang up if activate CONFIG_DEBUG_SHIRQ

2017-08-10 Thread jeffy
Hi Heiko, On 08/10/2017 05:27 PM, Heiko Stuebner wrote: Hi Shawn, Am Donnerstag, 10. August 2017, 16:21:13 CEST schrieb Shawn Lin: >With CONFIG_DEBUG_SHIRQ enabled, the irq tear down routine >would still access the irq handler registed as a shard irq. >Per the comment within the function of __

Re: [PATCH v3 01/20] mtd: nand: qcom: program NAND_DEV_CMD_VLD register

2017-08-10 Thread Boris Brezillon
Le Sat, 5 Aug 2017 21:49:39 +0530, Abhishek Sahu a écrit : > The NAND page read fails without complete boot chain since > NAND_DEV_CMD_VLD value is not proper. The default power on reset > value for this register is > > 0xe - ERASE_START_VALID | WRITE_START_VALID | READ_STOP_VALID > > The

Re: [PATCH] xen-blkfront: use a right index when checking requests

2017-08-10 Thread Roger Pau Monne
On Wed, Aug 09, 2017 at 03:31:40PM -0700, Munehisa Kamata wrote: > Since commit d05d7f40791c ("Merge branch 'for-4.8/core' of > git://git.kernel.dk/linux-block") and 3fc9d690936f ("Merge branch > 'for-4.8/drivers' of git://git.kernel.dk/linux-block"), blkfront_resume() > has been using an index for

Re: RCU stall when using function_graph

2017-08-10 Thread Daniel Lezcano
On 09/08/2017 19:22, Paul E. McKenney wrote: > On Wed, Aug 09, 2017 at 05:51:33PM +0200, Daniel Lezcano wrote: >> On 09/08/2017 16:40, Paul E. McKenney wrote: >>> On Wed, Aug 09, 2017 at 03:28:05PM +0200, Daniel Lezcano wrote: On 09/08/2017 14:58, Paul E. McKenney wrote: > On Wed, Aug 09,

Re: wake_wide mechanism clarification

2017-08-10 Thread Brendan Jackman
On Wed, Aug 09 2017 at 21:22, Atish Patra wrote: > On 08/03/2017 10:05 AM, Brendan Jackman wrote: >> >> On Thu, Aug 03 2017 at 13:15, Josef Bacik wrote: >>> On Thu, Aug 03, 2017 at 11:53:19AM +0100, Brendan Jackman wrote: Hi, On Fri, Jun 30 2017 at 17:55, Josef Bacik wrote: >>>

[PATCH 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

2017-08-10 Thread Sandy Huang
This adds support for Rockchip soc lvds found on rk3288 Based on the patches from Mark yao and Heiko Stuebner Signed-off-by: Sandy Huang Signed-off-by: Mark yao Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/Kconfig | 9 + drivers/gpu/drm/rockchip/Makefile| 1 +

[PATCH] HID: multitouch: Support ALPS PTP stick with pid 0x120A

2017-08-10 Thread Shrirang Bagul
This patch adds ALPS PTP sticks with pid/device id 0x120A to the list of devices supported by hid-multitouch. Signed-off-by: Shrirang Bagul --- drivers/hid/hid-ids.h| 1 + drivers/hid/hid-multitouch.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/hid/hid-ids.h b/driver

[PATCH v2 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

2017-08-10 Thread Sandy Huang
This adds support for Rockchip soc lvds found on rk3288 Based on the patches from Mark yao and Heiko Stuebner Signed-off-by: Sandy Huang Signed-off-by: Mark yao Signed-off-by: Heiko Stuebner --- Changes according to Sean Paul's reviews. drivers/gpu/drm/rockchip/Kconfig | 9 + driver

[PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port()

2017-08-10 Thread Dan Carpenter
This function has a copy and paste bug so it accidentally calls the add function instead of the delete function. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c

Re: [PATCH 0/3] ACPI: Initialize GPEs before the initial namespace scan

2017-08-10 Thread Mika Westerberg
On Thu, Aug 10, 2017 at 12:29:12AM +0200, Rafael J. Wysocki wrote: > Hi, > > This is exceptional for at least two reasons. > > First, we need it now to work around boot problems on multiple platforms > already seen in the field (which are shipping products). > > Second, the ACPICA changes in thi

Re: [PATCH 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

2017-08-10 Thread Sandy Huang
sorry, it's a wrong email, send the v1 patch ,please ignore. 在 2017/8/10 17:49, Sandy Huang 写道: This adds support for Rockchip soc lvds found on rk3288 Based on the patches from Mark yao and Heiko Stuebner Signed-off-by: Sandy Huang Signed-off-by: Mark yao Signed-off-by: Heiko Stuebner ---

Re: [PATCH v2 1/5] usb: xhci: Disable slot even virt-dev is null

2017-08-10 Thread Mathias Nyman
On 10.08.2017 03:35, Lu Baolu wrote: Hi, On 08/09/2017 03:58 PM, Mathias Nyman wrote: On 27.07.2017 05:21, Lu Baolu wrote: xhci_disable_slot() is a helper for disabling a slot when a device goes away or recovers from error situations. Currently, it checks the corespoding virt-dev pointer and r

Re: [PATCH v3 3/5] ASoC: codecs: msm8916-wcd-analog: add MBHC support

2017-08-10 Thread Srinivas Kandagatla
Hi Damien, Thanks for testing. On 09/08/17 22:10, Damien Riegel wrote: Hi Srinivas, On Wed, Aug 09, 2017 at 06:49:25PM +0200, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla MBHC (MultiButton Headset Control) support is available in pm8921 in two blocks, one to detect mechani

[PATCH] KVM/x86: Increase max vcpu number to 352

2017-08-10 Thread Lan Tianyu
Intel Xeon phi chip will support 352 logical threads. For HPC usage case, it will create a huge VM with vcpu number as same as host cpus. This patch is to increase max vcpu number to 352. Signed-off-by: Lan Tianyu --- arch/x86/include/asm/kvm_host.h | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v4 1/4] can: dev: Add support for limiting configured bitrate

2017-08-10 Thread Sergei Shtylyov
Hello! On 8/10/2017 3:59 AM, Franklin S Cooper Jr wrote: Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to di

clk-samsung tree inlcusion in linux-next

2017-08-10 Thread Sylwester Nawrocki
Hi Stephen, I'd like to ask for inclusion of this (clk-samsung) tree in linux-next: git://git.kernel.org/pub/scm/linux/kernel/git/snawrocki/clk.git for-next It will contain Samsung SoC clock controller related patches. Thanks, Sylwester

Re: [PATCH v2 1/9] arm64: dts: hi3660: enable idle states

2017-08-10 Thread Daniel Lezcano
Hi Guodong, Leo, there are several typos in the patch description. I *humbly* propose an alternate description to make it a bit more English friendly. """ There are two clusters on the Hi3660, the first one is Cortex-A53 based and the other one is Cortex-A73 based. These two clusters have diffe

Re: [PATCH] Do not disable driver and bus shutdown hook when class shutdown hook is set.

2017-08-10 Thread Michal Suchánek
On Wed, 9 Aug 2017 15:52:02 -0600 Jason Gunthorpe wrote: > On Wed, Aug 09, 2017 at 11:34:20PM +0200, Michal Suchanek wrote: > > Disabling the driver hook by setting class hook is totally sound > > design not prone to error as evidenced by the single implementation > > of the class hook. > > It

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-10 Thread Daniel Colascione
Thanks for taking a look at the patch! On Thu, Aug 10 2017, Michal Hocko wrote: > [CC linux-api - the patch was posted here > http://lkml.kernel.org/r/20170810001557.147285-1-dan...@google.com] > > On Thu 10-08-17 13:38:31, Minchan Kim wrote: >> On Wed, Aug 09, 2017 at 05:15:57PM -0700, Daniel Col

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
The original patch did not go through the normal review process... On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: > I'm all for fixing memory leaks, but freeing a block while it is still > being used is a recipe for hard-to-debug kernel exceptions. > This bug completely breaks the

Re: [PATCH v3 01/20] mtd: nand: qcom: program NAND_DEV_CMD_VLD register

2017-08-10 Thread Abhishek Sahu
On 2017-08-10 15:12, Boris Brezillon wrote: Le Sat, 5 Aug 2017 21:49:39 +0530, Abhishek Sahu a écrit : The NAND page read fails without complete boot chain since NAND_DEV_CMD_VLD value is not proper. The default power on reset value for this register is 0xe - ERASE_START_VALID | WRITE_ST

[PATCH 07/17] pinctrl: digicolor: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (pctlops and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/pinctrl-digicolor.c |4 ++-- 1 file changed, 2 insertions(+), 2 d

[PATCH 16/17] pinctrl: ti-iodelay: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (confops and pctlops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/ti/pinctrl-ti-iodelay.c |4 ++-- 1 file changed, 2 insertions(+)

[PATCH 03/17] pinctrl: armada-37xx: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
This pinconf_ops structure is only stored in the const pinconf_ops field of a pinctrl_desc structure. Make the pinconf_ops structure const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c |2 +- 1 file changed, 1 inserti

[PATCH 02/17] pinctrl: artpec6: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
This pinctrl_ops structure is only stored in the const pctlops field of a pinctrl_desc structure. Make the pinctrl_ops structure const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/pinctrl-artpec6.c |2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 00/17] constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure that are const. Make the structures const as well. Done with the help of Coccinelle. --- drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c |4 ++-- drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c |6 +++--- drivers/pinctrl/bcm

[PATCH 05/17] pinctrl: sirf: atlas7: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
This pinmux_ops structure is only stored in the const pmxops field of a pinctrl_desc structure. Make the pinmux_ops structure const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/sirf/pinctrl-atlas7.c |2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH 1/3] wait: add wait_event_killable_timeout()

2017-08-10 Thread Peter Zijlstra
On Wed, Aug 09, 2017 at 04:46:33PM -0700, Luis R. Rodriguez wrote: > This wait is similar to wait_event_interruptable_timeout() but only accepts > SIGKILL interrupt signal. Other signals are ignored. > > Signed-off-by: Luis R. Rodriguez Assuming someone else is going to merge all these: Acked-b

[PATCH 04/17] pinctrl: st: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (confops, pctlops, and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/pinctrl-st.c |6 +++--- 1 file changed, 3 insertions(+)

Re: [PATCH v8 06/14] lockdep: Detect and handle hist_lock ring buffer overwrite

2017-08-10 Thread Byungchul Park
On Wed, Aug 09, 2017 at 04:16:05PM +0200, Peter Zijlstra wrote: > > Hehe, _another_ scheme... > > Yes I think this works.. but I had just sort of understood the last one. > > How about I do this on top? That I think is a combination of what I > proposed last and your single invalidate thing. Com

[PATCH 15/17] pinctrl: tz1090: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (confops, pctlops, and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- This seems to target the metag architecture for which I don't know how to c

[PATCH 12/17] pinctrl: rza1: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
This pinmux_ops structure is only stored in the const pmxops field of a pinctrl_desc structure. Make the pinmux_ops structure const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/pinctrl-rza1.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 13/17] pinctrl: tb10x: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (pctlops and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/pinctrl-tb10x.c |4 ++-- 1 file changed, 2 insertions(+), 2 delet

[PATCH 10/17] pinctrl: adi2: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (pctlops and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/pinctrl-adi2.c |4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH 14/17] pinctrl: tz1090-pdc: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (confops, pctlops, and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- This seems to target the metag architecture for which I don't know how to c

[PATCH 01/17] pinctrl: bcm281xx: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
This pinconf_ops structure is only stored in the const confops field of a pinctrl_desc structure. Make the pinconf_ops structure const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/bcm/pinctrl-bcm281xx.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 11/17] pinctrl: ingenic: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (confops, pctlops, and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/pinctrl-ingenic.c |6 +++--- 1 file changed, 3 insertio

[PATCH 08/17] pinctrl: aspeed: g4: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (pctlops, and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c |4 ++-- 1 file changed, 2 insertions

[PATCH 09/17] pinctrl: aspeed: g5: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (confops, pctlops, and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c |6 +++--- 1 file changed, 3

[PATCH 06/17] pinctrl: sirf: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (pctlops and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/sirf/pinctrl-sirf.c |4 ++-- 1 file changed, 2 insertions(+), 2 d

[PATCH 17/17] pinctrl: vt8500: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Julia Lawall
These structures are only stored in fields of a pinctrl_desc structure (confops, pctlops, and pmxops) that are const. Make the structures const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pinctrl/vt8500/pinctrl-wmt.c |6 +++--- 1 file changed, 3 inser

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

2017-08-10 Thread Philipp Zabel
Hi Katsuhiro, On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote: > Add a reset line for analog signal amplifier core (ADAMV) on > UniPhier LD11/LD20 SoCs. > > > Signed-off-by: Katsuhiro Suzuki > --- >  drivers/reset/reset-uniphier.c | 15 +++ >  1 file changed, 15 insertions(+

Re: [PATCH] sched/fair: Make PELT signal more accurate

2017-08-10 Thread Peter Zijlstra
On Thu, Aug 10, 2017 at 09:17:34AM +0200, Vincent Guittot wrote: > Ah! this is quite confusing and not obvious that the trace is not for > 1 signal but in fact 2 signals are interleaved and only 1 is displayed > and that we have to filter them > > So ok i can see that the trace with cfs_rq=1 is no

Re: [PATCH 2/2] lib: add test for bitmap_parselist()

2017-08-10 Thread Yury Norov
On Thu, Aug 10, 2017 at 09:30:31AM +0200, Rasmus Villemoes wrote: > > From be0e663b804daff0d0512e72cf94b5143270bd29 Mon Sep 17 00:00:00 2001 > > From: Yury Norov > > Date: Thu, 10 Aug 2017 01:25:46 +0300 > > Subject: [PATCH] bitmap: introduce BITMAP_FROM_U64() and use it in test for > > bitmap_pa

Re: [PATCH] rwsem: fix missed wakeup due to reordering of load

2017-08-10 Thread Peter Zijlstra
On Thu, Aug 10, 2017 at 10:32:56AM +0200, Andrea Parri wrote: > On Thu, Jul 27, 2017 at 11:48:53AM -0400, Waiman Long wrote: > > On 07/26/2017 04:17 PM, Prateek Sood wrote: > > > If a spinner is present, there is a chance that the load of > > > rwsem_has_spinner() in rwsem_wake() can be reordered w

Re: [PATCH] rwsem: fix missed wakeup due to reordering of load

2017-08-10 Thread Peter Zijlstra
On Thu, Jul 27, 2017 at 01:47:52AM +0530, Prateek Sood wrote: > diff --git a/kernel/locking/rwsem-xadd.c b/kernel/locking/rwsem-xadd.c > index 34e727f..21c111a 100644 > --- a/kernel/locking/rwsem-xadd.c > +++ b/kernel/locking/rwsem-xadd.c > @@ -585,6 +585,40 @@ struct rw_semaphore *rwsem_wake(struc

Re: [PATCH 2/2] f2fs: introduce gc_urgent mode for background GC

2017-08-10 Thread Chao Yu
On 2017/8/8 9:42, Jaegeuk Kim wrote: > This patch adds a sysfs entry to control urgent mode for background GC. > If this is set, background GC thread conducts GC with gc_urgent_sleep_time > all the time. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu

Re: [PATCH 1/1] f2fs: merge equivalent flags F2FS_GET_BLOCK_[READ|DIO]

2017-08-10 Thread Chao Yu
On 2017/8/9 17:27, sunqiuyang wrote: > From: Qiuyang Sun > > Currently, the two flags F2FS_GET_BLOCK_[READ|DIO] are totally equivalent > and can be used interchangably in all scenarios they are involved in. > Neither of the flags is referenced in f2fs_map_blocks(), making them both > the defaul

Re: [PATCH v3 1/2] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2

2017-08-10 Thread Masahiro Yamada
Hayashi-san 2017-07-05 20:53 GMT+09:00 Kunihiko Hayashi : > Add nodes of thermal monitor and thermal zone for UniPhier PXs2 SoC. > The thermal monitor is included in sysctrl. > Furthermore, add cpuN labels for reference in cooling-device property. > > Signed-off-by: Kunihiko Hayashi > --- Plea

Re: clk-samsung tree inlcusion in linux-next

2017-08-10 Thread Krzysztof Kozlowski
On Thu, Aug 10, 2017 at 12:07 PM, Sylwester Nawrocki wrote: > Hi Stephen, > > I'd like to ask for inclusion of this (clk-samsung) tree in linux-next: > > git://git.kernel.org/pub/scm/linux/kernel/git/snawrocki/clk.git for-next > > It will contain Samsung SoC clock controller related patches. Cool

[PATCH v2 0/3] livepatch: Introduce force sysfs attribute

2017-08-10 Thread Miroslav Benes
Currently, livepatch gradually migrate the system from an unpatched to a patched state (or vice versa). Each task drops its TIF_PATCH_PENDING itself when crossing the kernel/user space boundary or it is cleared using the stack checking approach. If there is a task which sleeps on a patched function

[PATCH v2 1/3] livepatch: Add force sysfs attribute

2017-08-10 Thread Miroslav Benes
Add read-write force attribute to livepatch sysfs infrastructure. We can use it later to force couple of events during a live patching process. Be it a sending of a fake signal or forcing of the tasks' successful conversion. It does not make sense to use the force facility when there is no transac

[PATCH v2 3/3] livepatch: force transition process to finish

2017-08-10 Thread Miroslav Benes
If a task sleeps in a set of patched functions uninterruptibly, it could block the whole transition process indefinitely. Thus it may be useful to clear its TIF_PATCH_PENDING to allow the process to finish. Admin can do that now by writing to force sysfs attribute in livepatch sysfs directory. TI

Re: [PATCH v3 2/2] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20

2017-08-10 Thread Masahiro Yamada
Hi Hayashi-san, 2017-07-05 20:53 GMT+09:00 Kunihiko Hayashi : > Add nodes of thermal monitor and thermal zone for UniPhier LD20 SoC. > The thermal monitor is included in sysctrl. > > Furthermore, since the reference board doesn't have a calibrated value of > thermal monitor, this patch gives the

[PATCH v2 2/3] livepatch: send a fake signal to all blocking tasks

2017-08-10 Thread Miroslav Benes
Live patching consistency model is of LEAVE_PATCHED_SET and SWITCH_THREAD. This means that all tasks in the system have to be marked one by one as safe to call a new patched function. Safe means when a task is not (sleeping) in a set of patched functions. That is, no patched function is on the task

Re: [PATCH v2] arm64: defconfig: enable CONFIG_UNIPHIER_WATCHDOG

2017-08-10 Thread Masahiro Yamada
Forwarding to ARM-SOC Hi Arnd, Olof, This patch was sent to arm64 maintainers a few weeks ago (but not picked up). I think the best home for this patch is the ARM-SOC tree. Could you pick it up, please? This patch: https://patchwork.kernel.org/patch/9847049/ Thanks, Masahiro 2017-07-18

Re: [PATCH v8 00/14] lockdep: Implement crossrelease feature

2017-08-10 Thread Peter Zijlstra
On Thu, Aug 10, 2017 at 06:37:07PM +0900, Byungchul Park wrote: > On Wed, Aug 09, 2017 at 05:50:59PM +0200, Peter Zijlstra wrote: > > > > > > Heh, look what it does... > > Wait.. execuse me but.. is it a real problem? I've not tried again with my patch removed -- I'm chasing another issue atm.

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Phil Elwell
On 10/08/2017 11:21, Dan Carpenter wrote: > The original patch did not go through the normal review process... > > On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: >> I'm all for fixing memory leaks, but freeing a block while it is still >> being used is a recipe for hard-to-debug kern

Re: [PATCH v8 00/14] lockdep: Implement crossrelease feature

2017-08-10 Thread Byungchul Park
On Thu, Aug 10, 2017 at 09:55:56AM +0900, Byungchul Park wrote: > On Wed, Aug 09, 2017 at 05:50:59PM +0200, Peter Zijlstra wrote: > > > > > > Heh, look what it does... > > It does not happen in my machine.. > > I tihink it happens because of "Simplify xhlock ring buffer invalidation" > patch of

Re: [PATCH v4 00/06] clocksource: sh_cmt: DT binding rework V4

2017-08-10 Thread Daniel Lezcano
On 10/08/2017 11:01, Geert Uytterhoeven wrote: > On Tue, Jul 11, 2017 at 1:56 PM, Simon Horman wrote: >> On Thu, Nov 24, 2016 at 11:58:43AM +0100, Simon Horman wrote: >>> On Mon, Mar 14, 2016 at 11:23:42PM +0900, Magnus Damm wrote: clocksource: sh_cmt: DT binding rework V4 [PATCH v4

Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-10 Thread David.Wu
Hi Andrew, Florian 在 2017/8/10 8:20, Andrew Lunn 写道: Hi Florian, David. I'm happy with the property name. But i think the text needs more description. We deal with Ethernet switches with integrated PHYs. Yet for us, this property is unneeded. Seeing this property means some bit of software nee

Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup

2017-08-10 Thread Michal Hocko
On Thu 10-08-17 03:23:23, Daniel Colascione wrote: > Thanks for taking a look at the patch! > > On Thu, Aug 10 2017, Michal Hocko wrote: > > [CC linux-api - the patch was posted here > > http://lkml.kernel.org/r/20170810001557.147285-1-dan...@google.com] > > > > On Thu 10-08-17 13:38:31, Minchan K

Re: [PATCH 00/35] constify net usb_device_id

2017-08-10 Thread Marc Kleine-Budde
On 08/08/2017 05:55 PM, Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > [PATCH 10/35] :Fix checkpatch.pl error. > ERROR: space prohibited

Re: [PATCH 04/17] pinctrl: st: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Patrice CHOTARD
Hi Julia On 08/10/2017 12:06 PM, Julia Lawall wrote: > These structures are only stored in fields of a pinctrl_desc > structure (confops, pctlops, and pmxops) that are const. Make the > structures const as well. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- >

Re: [RFC PATCH] PCI: rockchip: fix system hang up if activate CONFIG_DEBUG_SHIRQ

2017-08-10 Thread Shawn Lin
Hi Heiko On 2017/8/10 17:27, Heiko Stuebner wrote: Hi Shawn, Am Donnerstag, 10. August 2017, 16:21:13 CEST schrieb Shawn Lin: With CONFIG_DEBUG_SHIRQ enabled, the irq tear down routine would still access the irq handler registed as a shard irq. Per the comment within the function of __free_irq

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: > > This label name is out of date. There is a later error path where > > vc_vchi_audio_init() fails and we leak on that path. > > Also agreed. I'll rework it. > Actually I wasn't right. That error path should probably stay how it is

Re: [PATCH 2/2] clk: uniphier: add video input subsystem clock

2017-08-10 Thread Masahiro Yamada
2017-08-10 16:23 GMT+09:00 Katsuhiro Suzuki : > Add a clock for video input subsystem (EXIV) on > UniPhier LD11/LD20 SoCs. > > Signed-off-by: Katsuhiro Suzuki Acked-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 1/2] clk: uniphier: add audio system clock

2017-08-10 Thread Masahiro Yamada
2017-08-10 16:23 GMT+09:00 Katsuhiro Suzuki : > Add clock for audio subsystem (AIO) and SoC internal audio codec > (EVEA) on UniPhier LD11/LD20 SoCs. > > Signed-off-by: Katsuhiro Suzuki > --- Acked-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 1/3] reset: uniphier: add audio systems reset control

2017-08-10 Thread Masahiro Yamada
2017-08-10 16:27 GMT+09:00 Katsuhiro Suzuki : > Add reset lines for audio subsystem (AIO) and > SoC internal audio codec (EVEA) on UniPhier LD11/LD20 SoCs. > > Signed-off-by: Katsuhiro Suzuki Acked-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH 2/3] reset: uniphier: add video input subsystem reset control

2017-08-10 Thread Masahiro Yamada
2017-08-10 16:27 GMT+09:00 Katsuhiro Suzuki : > Add a reset line for video input subsystem (EXIV) on > UniPhier LD11/LD20 SoCs. > > Signed-off-by: Katsuhiro Suzuki Acked-by: Masahiro Yamada -- Best Regards Masahiro Yamada

Re: [PATCH] Subject:drivers:staging:media:atomisp:

2017-08-10 Thread Sakari Ailus
Hi Harold, Please use a better subject line. On Thu, Aug 10, 2017 at 03:08:26PM +0530, Harold Gomez wrote: > Fix Warning from checkpatch.pl > Block comments use * on subsequent lines > > Signed-off-by: Harold Gomez > --- > drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++-- > 1 file changed

Re: [PATCH] nvme: fix directive command numd calculation

2017-08-10 Thread Christoph Hellwig
On Thu, Aug 10, 2017 at 10:36:50AM +0200, Christoph Hellwig wrote: > Do you want to take it directly for the block tree? I've actually got a set of nvme 4.13 patches now that I did a sweep over the list, so I'd be happy to take it. There is one other I want to merge pending an ok from Keith. Wit

[PATCH] selftests: memfd: Align STACK_SIZE for ARM AArch64 system

2017-08-10 Thread Orson Zhai
The stack size should be 16 bytes aligned in arm64 system. The similar patch has been merged already. > > selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned > >There is a mandate of 16-byte aligned stack on AArch64 [1], so the >STACK_SIZE here should also be 16-byte alig

Re: [PATCH v8 00/14] lockdep: Implement crossrelease feature

2017-08-10 Thread Ingo Molnar
* Byungchul Park wrote: > Change from v7 > - rebase on latest tip/sched/core (Jul 26 2017) > - apply peterz's suggestions > - simplify code of crossrelease_{hist/soft/hard}_{start/end} > - exclude a patch avoiding redundant links > - exclude a patch already applied

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

2017-08-10 Thread Masahiro Yamada
2017-08-10 19:37 GMT+09:00 Philipp Zabel : > Hi Katsuhiro, > > On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote: >> Add a reset line for analog signal amplifier core (ADAMV) on >> UniPhier LD11/LD20 SoCs. >> >> > Signed-off-by: Katsuhiro Suzuki >> --- >> drivers/reset/reset-uniphier.c |

Re: [PATCH 0/3] livepatch: introduce atomic replace

2017-08-10 Thread Miroslav Benes
> Ok - associating the "atomic replace" with the patch itself makes sense to me. > It would also basically work, I think with the patch I proposed except for the > case where the the "atomic replace" was on top of several non-"atomic replace" > patches. The reason is that the "atomic replace" I po

Re: [PATCH v3 01/49] block: drbd: comment on direct access bvec table

2017-08-10 Thread Christoph Hellwig
I really don't think that these comments are all that useful. A big comment near the bi_io_vec field defintion explaining the rules for access would be a lot better.

RE: [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the namespace

2017-08-10 Thread Zheng, Lv
Hi, > From: Lukas Wunner [mailto:lu...@wunner.de] > Subject: Re: [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the > namespace > > On Thu, Aug 10, 2017 at 12:34:23AM +0200, Rafael J. Wysocki wrote: > > --- linux-pm.orig/drivers/acpi/scan.c > > +++ linux-pm/drivers/acpi/scan.c > > @@ -2139

Re: [PATCH v3 04/49] mm: page_io.c: comment on direct access to bvec table

2017-08-10 Thread Christoph Hellwig
Can we just add a bio_first_page macro that always return the first page in the bio?

Re: [PATCH v3 05/49] fs/buffer: comment on direct access to bvec table

2017-08-10 Thread Christoph Hellwig
> + /* > + * It is safe to truncate the last bvec in the following way > + * even though multipage bvec is supported, but we need to > + * fix the parameters passed to zero_user(). > + */ > + struct bio_vec *bvec = &bio->bi_io_vec[bio->bi_vcnt - 1]; A 'we need to fix XX

Re: + mm-shmem-add-hugetlbfs-support-to-memfd_create.patch added to -mm tree

2017-08-10 Thread Michal Hocko
[The updated changelog is here so let me comment here] On Tue 08-08-17 16:19:45, Andrew Morton wrote: > From: Mike Kravetz > Subject: mm/shmem: add hugetlbfs support to memfd_create() > > This patch came out of discussions in this e-mail thread: > https://lkml.org/lkml/2017/7/6/564 Use http://l

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

2017-08-10 Thread Masahiro Yamada
Hi. 2017-08-10 20:11 GMT+09:00 Masahiro Yamada : > 2017-08-10 19:37 GMT+09:00 Philipp Zabel : >> Hi Katsuhiro, >> >> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote: >>> Add a reset line for analog signal amplifier core (ADAMV) on >>> UniPhier LD11/LD20 SoCs. >>> >>> > Signed-off-by: Ka

<    1   2   3   4   5   6   7   8   9   10   >