On Tue, 5 Dec 2023 at 08:59, Miroslav Lichvar wrote:
> On Mon, Dec 04, 2023 at 11:25:00PM +0100, Andrew Zaborowski wrote:
> > On Sun, 3 Dec 2023 at 00:39, Richard Cochran
> wrote:
> > > @@ -306,13 +307,15 @@ static void do_set_action(struct pmc *pmc, int
> action, int index, char *str)
> > >
"wrong" value, it probably comes from the ptp4l service
itself.
Erez
>
> BR,
> Paz
> ___
> Linuxptp-devel mailing list
> Linuxptp-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
The PTP service is a master or client, not both.
So the amount of traffic you timestamp does not reduce by using a SYNC/
DELY versa events filter.
Erez
>
> --
> Miroslav Lichvar
>
>
>
> ___
> Linuxptp-devel mailing list
> Linuxp
.
TIME_STATUS_NP was added in september 2012 and published in version 1.1.
You can fix calculations of values in the TLV, but not sizes, types, order
or *NAMES*.
Wireshark should follow IEEE 1588 and linuxptp enterprise management TLVs,
not the other way around.
Erez
On Wed, 29 Nov 2023 at 07:52, Choong
ts as they don't have timestamp each other's
> delay requets and timestamping of sync messages is more reliable.
>
PTP traffic by its nature is very low.
I do not see any benefit for a filter that supports only client or only
master PTP traffic.
Perhaps the kernel should add a HWTSTAMP_FILTER
Hi,
Debian builds allow using patches during building of Debian packages.
Erez
On Tue, 28 Nov 2023 at 00:48, Richard Cochran
wrote:
> On Mon, Nov 27, 2023 at 10:47:48AM +0300, IlorDash wrote:
> > Thanks, Richard, for such a detailed answer!
> > I'll try to find another s
On Sun, 26 Nov 2023 at 22:07, Richard Cochran
wrote:
> On Thu, Nov 23, 2023 at 01:39:45PM +0100, Erez wrote:
> > On Thu, 23 Nov 2023 at 04:26, Chwee-Lin Choong <
> chwee.lin.cho...@intel.com>
> > wrote:
> >
> > > Add the computation for scaledLastGmFreqCha
in the header where the TLV is defined.
Erez
>
> Signed-off-by: Tan Tee Min
> Signed-off-by: Chwee-Lin Choong
> ---
> clock.c | 59 +
> clock.h | 7 +++
> pmc.c | 4 ++--
> port.c | 5 +++--
> tl
move these obsolete URLs?
Erez
On Tue, 21 Nov 2023 at 09:35, Maciek Machnikowski
wrote:
> No leap seconds will happen till 28 June 2024. Update leapfile validity
> accordingly.
> Add a new source of leapsecond file from the IERS.
>
> Signed-off-by: Maciek Machnikowski
> ---
&
pports PTP or not.
Anyhow this mailing list is for linuxptp and not for Broadcom's NIC.
You should try in forums for Broadcom NICs.
Or Linux kernel modules forums.
Erez
Hardware Transmit Timestamp Modes: none
>
> Hardware Receive Filter Modes: none
>
>
>
> The kernel ver
On Mon, 13 Nov 2023 at 18:49, IlorDash wrote:
> From: Ilya Orazov
>
> Added adv_rx_filter config that allows to send SIOCSHWTSTAMP ioctl with
> HWTSTAMP_FILTER_PTP_XXX_SYNC or HWTSTAMP_FILTER_PTP_XXX_DELAY_REQ
> rx filters based on whether the Device is Slave or Master respectively.
> This Featu
I think Richard means using the SUBSCRIBE_EVENTS_NP.
Adding new events, and make sure the ptp4l sends all the statistics you
need together.
Erez
On Sat, 11 Nov 2023 at 19:02, Luigi 'Comio' Mantellini <
luigi.mantell...@gmail.com> wrote:
> Thanks for your time.
>
> Wh
On Fri, 10 Nov 2023 at 14:05, Maciek Machnikowski
wrote:
> Additionally, forcing PTP minor version to be nonzero causes
> interoperability issues with some legacy grandmasters.
>
> Signed-off-by: Maciek Machnikowski
> ---
> config.c| 1 +
> configs/default.cfg | 1 +
> ptp4l.8
omain->phc_interval) * 3);
>
I think it is better to use
MAX(10, domain->phc_interval)
Instead of
(10 > domain->phc_interval ? 10 : domain->phc_interval)
You may add
#define MAX(a, b) ((a) > (b) ? (a) : (b))
Erez
> Would it simplify things just to change the 180,60 constants
>
On Fri, 20 Oct 2023 at 18:35, Luca Fancellu wrote:
>
>
> > On 20 Oct 2023, at 16:57, Erez wrote:
> >
> > Hi,
> >
> > Your statement is correct, but not the implementation.
> > You need to export CC from the makefile, to get
> > CC = $(CROSS_COMPIL
www.gnu.org/software/make/manual/html_node/Setting.html
Erez
On Thu, 19 Oct 2023 at 17:10, Luca Fancellu wrote:
> The Makefile is defining CC and incdefs.sh is using
> ${CROSS_COMPILE}cpp inside it, allowing both to use different
> compilers depending on what the user pass during make
et_arg, -DBL_MAX, DBL_MAX);
> + switch (r) {
> + case PARSED_OK:
> + break;
> + case MALFORMED:
> + pr_err("phase: '%s' is not a valid double", cmdv[0]);
> + return -2;
> + case OUT_OF_RANGE:
> +
official kernel. :-)
https://elixir.bootlin.com/linux/v6.5/source/include/uapi/linux/ptp_clock.h#L204
Erez
>
> Signed-off-by: Rahul Rameshbabu
> ---
> missing.h | 9 +
> phc_ctl.c | 4
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git
o PHC phase control
> keyword",
> - offset_arg);
> + if (!clockadj_set_phase(clkid, nsecs))
> + pr_notice("offset of %lf seconds provided to PHC phase
> control keyword",
> + offset_arg);
>
And here
Erez
>
> /* phas
h the SET and the RESPONSE, the index value is the same.
Although the standard forbids setting a static or nonconfigurable value.
It also forbids mixing, so what about using only nonconfigurable and
non-static values?
I think we can skip this rule for statistics.
And as the index and the statistic
On Wed, 26 Jul 2023 at 04:39, Richard Cochran
wrote:
> On Tue, Jul 04, 2023 at 12:30:38PM +0200, Stephan Wurm wrote:
>
> > diff --git a/fsm.h b/fsm.h
> > index 857af05..919e934 100644
> > --- a/fsm.h
> > +++ b/fsm.h
> > @@ -31,6 +31,7 @@ enum port_state {
> > PS_PASSIVE,
> > PS_UNCALI
On Sun, 23 Jul 2023 at 21:28, Saravanan Arunachalam via Linuxptp-devel <
linuxptp-devel@lists.sourceforge.net> wrote:
> The pmc call to ptp4l to get phc_index returns invalid value since in
> free_running mode, ptp4l sets phc_index to -1. Adding a socket call in
> phc2sys to get the phc_index.
>
ndling to filter them.
You might need a link detection protocol like LLDP.
Erez
> I used this patch to solve a problem. It clears the client list, if port
> goes to faulty state.
>
That sounds like a daemon restart.
>
> Index: linuxptp-2.0/port.c
> ===
On Mon, 10 Jul 2023 at 04:08, Vladimir Dubrovsky
wrote:
> Hello Erez,
>
> Thank you for your time.
>
> I think the problem is not in Ethernet driver, because all applications
> over IPv6 work fine, at least I am not aware of a problem. PTP over IPv4
> works fine as well.
.
Erez
On Fri, 7 Jul 2023 at 20:46, Vladimir Dubrovsky via Linuxptp-devel <
linuxptp-devel@lists.sourceforge.net> wrote:
> Hello,
>
> I have a problem with ptp4l working with IPv6 messages.
>
> We use Linux version 4.19.0+ and ptp4l version 3.1.
>
> Everythi
lkid, int cmdc, char *cmdv[])
> +{
> + struct ptp_pin_desc pin_desc;
> + unsigned int index;
> + int n_pins;
> +
> + if (clkid >= 0) {
> + pr_warning("The provided clock is not a PHC device.");
> + return 0;
>
On Fri, 23 Jun 2023 at 19:03, Jacob Keller wrote:
>
>
> On 6/23/2023 2:08 AM, Erez wrote:
> > On Fri, 23 Jun 2023 at 09:07, Jacob Keller
> wrote:
> >
> >> Add a new function to phc_ctl to display the devices pin configuration
> >> data. First, obtai
On Fri, 23 Jun 2023 at 18:55, Jacob Keller wrote:
>
>
> On 6/23/2023 1:44 AM, Erez wrote:
> > On Fri, 23 Jun 2023 at 09:07, Jacob Keller
> wrote:
> >
> >> The phc library currently selects whether to use PTP_PIN_SETFUNC2 over
> >> PTP_PIN_SETFUNC
On Fri, 23 Jun 2023 at 09:07, Jacob Keller wrote:
> Add a new function to phc_ctl to display the devices pin configuration
> data. First, obtain the device capabilities to determine the number of
> pins. Then, for each pin, print the name, function, and channel
> information.
>
> Signed-off-by: J
better to checkthe ptp_pin_desc structure
https://elixir.bootlin.com/linux/v6.4-rc7/source/include/uapi/linux/ptp_clock.h#L174
Once we have new properties there.
Then we can use PTP_PIN_SETFUNC2.
Erez
>
> Signed-off-by: Jacob Keller
> ---
> missing.h | 7 ++-
> phc.c | 7
On Wed, 21 Jun 2023 at 01:13, Rahul Rameshbabu
wrote:
> Hi Erez,
>
> On Wed, 21 Jun, 2023 00:33:28 +0200 Erez wrote:
> > Hi,
> >
> > You already submitted the patch seria.
> > Has it changed?
>
> Yes, I took feedback from the RFC (request for commen
Hi,
You already submitted the patch seria.
Has it changed?
If so, please mark it with version 2. "git format-patch -v 2".
If not, why do you send it again?
I think Richard wanted to close version 4 first.
Erez
On Tue, 20 Jun 2023 at 19:39, Rahul Rameshbabu via Linuxptp-devel
On Fri, 16 Jun 2023 at 13:13, Walfred Tedeschi
wrote:
> On 15.06.23 17:37, Erez wrote:
>
>
>
> On Thu, 15 Jun 2023 at 06:26, Richard Cochran
> wrote:
>
>> On Wed, Jun 14, 2023 at 03:51:08PM +0200, Walfred Tedeschi via
>> Linuxptp-devel wrote:
>>
>>
TSN :-)
I also add the wrapper languages, so developers can use scripting in
addition to C++.
Erez
>
>
> HTH,
> Richard
>
>
> ___
> Linuxptp-devel mailing list
> Linuxptp-devel@lists.sourc
On Wed, 14 Jun 2023 at 06:25, Richard Cochran
wrote:
> On Tue, Jun 13, 2023 at 01:01:11PM +0200, Erez wrote:
>
> > Just so I am clear on the matter.
> > I simply suggest taking the same test you run with linuxptp-testsuite.
> > And run it in a github action. So we can a
On Tue, 13 Jun 2023 at 12:57, Erez wrote:
>
>
> On Tue, 13 Jun 2023 at 09:48, Richard Cochran
> wrote:
>
>> On Tue, Jun 13, 2023 at 08:02:29AM +0200, Erez wrote:
>> > Hi,
>> >
>> > Using Miroslav's linuxptp-testsuite we can run a simulated H
On Tue, 13 Jun 2023 at 09:48, Richard Cochran
wrote:
> On Tue, Jun 13, 2023 at 08:02:29AM +0200, Erez wrote:
> > Hi,
> >
> > Using Miroslav's linuxptp-testsuite we can run a simulated HIL in github
> > itself.
>
> "Simulated HIL" is an oxymoron.
o not suggest passing testing with real hardware and manuals for
the changes we do.
Using github action allows developers to do some basic smoke tests to
ensure they did not break too much.
Erez
On Tue, 13 Jun 2023 at 06:20, Richard Cochran
wrote:
> On Fri, Jun 09, 2023 at 07:14:31PM -0700,
ns everywhere.
I do not suggest to ignore standards,
Only bear in mind that we can not rely on others to implement the standard
to the letter.
And that standards in many cases involve politics of many vendors,
which lead to ambiguity by design and compromises.
Erez
> In a few places you mentio
Hi,
We tie patches by using the version, so version 2 is named: "[PATCH v2]"
We use "git format-patch -v2"
And add "--cover-letter" in case of several commits.
Next time :-)
Erez
On Tue, 6 Jun 2023 at 21:28, Dylan Robinson wrote:
> If the transportSpe
for this macro.
>
+1
And follow Linux kernel.
Erez
> Signed-off-by: Rahul Rameshbabu
> ---
> phc_ctl.c | 8
> port.c | 14 +++---
> port_private.h | 2 +-
> tc.c | 6 +++---
> 4 files changed, 15 insertions(+), 15 deletions(-)
if your patch follows the IEEE standard, then perhaps Richard will
apply.
Yours
Erez
On Wed, 31 May 2023 at 19:39, Dylan Robinson
wrote:
> Hello linuxptp-devel group!
>
> I would like to discuss the implementation of the two-step peer delay
> computation. The 1588 and 802.1AS sp
iling list.
Erez
On Fri, 26 May 2023 at 16:53, egg car wrote:
> Dear Richard,
>
> Ah yes I have figured out that the problem is not ts2phc, it should be
> fixed in igb_extts() at igb_main.c
>
> if (hw->mac
> <https://elixir.bootlin.com/linux/v5.19.17/C/ide
Thanks for the reply.
Please add the explanation to the commit and to the structure.
Personally, I do not have an opinion, yet I did not participate in the IEEE
1558 committee.
Erez
On Tue, 16 May 2023 at 23:43, Kishen Maloor wrote:
> On 5/16/23 3:56 AM, Erez wrote:
> > On Tue, 16
On Tue, 16 May 2023 at 00:29, Kishen Maloor wrote:
> In a setup with multiple gPTP domains, the Common Mean Link Delay Service
> (CMLDS) (IEEE 1588/16.6.3) performs link delay measurements in a single
> domain and must (somehow) convey those to other domains. IEEE 1588 does not
> specify this int
On Tue, 9 May 2023 at 20:38, Richard Cochran
wrote:
> On Tue, May 09, 2023 at 02:02:05PM +0200, Andrew Zaborowski wrote:
> > Per https://www.kernel.org/doc/Documentation/networking/timestamping.txt
> > section 3:
> > "User space is responsible to ensure that multiple processes don't
> interfere
>
Did blame.
commit afeabf3c90edf6699d7e0d058593835ec258be46
Author: Hangbin Liu
Date: Wed May 25 14:46:16 2022 +0800
ptp4l: add VLAN over bond support
Perhaps Hangbin Liu can assist?
Erez
On Tue, 2 May 2023 at 00:08, Erez wrote:
>
>
> On Mon, 1 May 2023 at 18:30, Martin Pec
upport SIOCGHWTSTAMP
> without the possibility to use the bonded PHC.
>
On a second review.
I think you have a point.
This get ioctl (SIOCGHWTSTAMP) was added for VLAN over bond support.
On normal run, the get ioctl is only used with HWTS
eq, &cfg, device);
> } else {
> pr_err("ioctl SIOCGHWTSTAMP failed: %m");
> return err;
> }
> }
>
> @Martin would that also fix your issue?
>
I support.
Erez
>
> Thanks,
> Richard
&g
nt TLV (you can query and set
by using the pmc tool).
> 3. Are power profile messages mandatorily required to carry IEEE 802.1Q
> VLAN tags?
>
I do not remember seeing dependence of that kind.
But you can read IEEE C37 238 of 2011 or 2017.
Or simply try yourself.
As I did not tr
On Wed, 26 Apr 2023 at 11:55, Maciek Machnikowski
wrote:
> On 4/21/2023 6:46 PM, Erez wrote:
> >
> >
> > On Fri, 21 Apr 2023 at 17:27, Maciek Machnikowski
> > mailto:mac...@machnikowski.net>> wrote:
> >
> > On 4/21/2023 1:25 PM, Erez wrote:
>
features.
We only use compilation flags for dependencies of outer headers like
kernels.
We control features by configuration only on run time.
The Linuxptp is first an IEEE 1588 PTP project.
It does not mean we do not like enhancements or using ITU or IEC.
But at bottom line, your code must
On Tue, 25 Apr 2023 at 10:16, Wurm, Stephan
wrote:
> Am Montag, dem 24.04.2023 um 12:39 +0200 schrieb Erez:
>
>
>
>
>
> On Mon, 24 Apr 2023 at 11:08, Stephan Wurm
> wrote:
>
> Standard IEC 21439-3:2016 Appendix A extends the PTPv2 standard by the
> definition of
On Tue, 25 Apr 2023 at 09:16, Wurm, Stephan
wrote:
> Am Montag, dem 24.04.2023 um 12:46 +0200 schrieb Erez:
>
>
>
> On Mon, 24 Apr 2023 at 11:07, Stephan Wurm
> wrote:
>
> Set profile identification according to IEC 62439-3:2016 Appendix B,
> when dataset comparison i
On Mon, 24 Apr 2023 at 11:07, Stephan Wurm wrote:
> Allow ORDINARY_CLOCK (OC) as doubly attached clock according to IEC
> 62439-3:2016 standard.
>
> Signed-off-by: Stephan Wurm
> ---
> ptp4l.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/ptp4l.c b/ptp4l.
nds for digital analog converter.
https://en.wikipedia.org/wiki/Digital-to-analog_converter
Perhaps you or IEC have a better acronym? Like DbAC? or CA2 and CA1?
Erez
> Signed-off-by: Stephan Wurm
> ---
> bmc.h| 1 +
> config.c | 1 +
> port.c | 25 ++
On Mon, 24 Apr 2023 at 11:08, Stephan Wurm wrote:
> Standard IEC 21439-3:2016 Appendix A extends the PTPv2 standard by the
> definition of doubly attached clocks (DAC) via redundant ports (either
> connected by HSR or PRP). Therefore, the state machine is extended by
> state PASSIVE_SLAVE and tra
eable;
> }
>
I think I have it:
+ /* Run the callback on signaling messages if configured */
+ if (res == 0 && node->signaling_cb_ena && (msg_type(*msg)
== SIGNALING)) {
+ res=2;
+ }
-
On Sat, 8 Apr 2023 at 17:29, Erez wrote:
>
>
> On Fri, 7 Apr 2023 at 17:15, Maciek Machnikowski
> wrote:
>
>> Add option to run callback that when the PMC agent receives signaling
>> messages.
>>
>
> I support you!
>
>
>>
>> Signed
fset_traceable(struct pmc_agent *agent);
>
> +/**
> + * Enables or disables callback on signaling messages
> + * @param agent Pointer to a PMC instance obtained via @ref
> pmc_agent_create().
> + * @param enable - if set to true, callback will be called on signaling
> msgs
> + */
>
nt and signaling messages.
In https://github.com/erezgeva/libptpmgmt/, I added an option to filter
signalling messages by their ID.
Erez
>
> Signed-off-by: Maciek Machnikowski
> ---
> phc2sys.c | 4 ++--
> pmc_agent.c | 17 -
> pmc_agent.h | 7 +--
> ts2
octl.c
It is usually returned for:
```c++
if (!capable(CAP_NET_ADMIN))
return -EPERM;
```
Or with network namespace
```c++
if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
return -EPERM;
```
I do not think we want to check this error in sk.c.
Unless the error was generated by something more reasonable.
Erez
>
> Thanks for your help, Erez.
>
> Martin
>
>
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
tand it may require too many changes in the code.
Erez
>
> 0x is an out of range value for option
> power_profile.2011.grandmasterTimeInaccuracy at line 44
> failed to parse configuration file configs/default.cfg
> These values are unsigned and stored as f
Sorry I forgot another hint.
Please use the 'git format-patch' with the patch seria iteration flag '-v
'.
So we can differentiate the mails as newer :-)
This will change the subject to something like "Subject: [PATCH *v2* 0/6]
"
Erez
On Wed, 29 Mar 2023 at 17
backs :-)
Well done
Erez
On Wed, 29 Mar 2023 at 15:24, Luigi Mantellini
wrote:
> In order to obtain a precise TX SYNC frequency we need to use a periodic
> timer facility instead to reconfigure the timer on every expiration.
>
> The solution consists to configure the it_inte
On Wed, 29 Mar 2023 at 14:37, Luigi 'Comio' Mantellini <
luigi.mantell...@gmail.com> wrote:
> Hi Erez,
>
> sorry, I usually use pull requests.
>
Me too :-)
But using patch seria is cool too.
>
>
> Il giorno mer 29 mar 2023 alle ore 14:29 Erez ha
> scrit
#x27;git format-patch' with the
'--cover-letter' options.
And please add a short explanation on the issue you solve to each patch
(relevant to each patch).
And if the solution is not trivial, a short explanation on the solution as
well.
Thanks
Erez
> e2e_tc.c | 28
q, &cfg, device);
>
> What would be the best way to fix this properly?
>
If linuxptp has a bug, we should fix it.
If the bug is in the 'eqos' driver, then the fix should be there. :-)
Richard, do you think we should wait with commit afeabf3 "ptp4l: add VLAN
over bond sup
iable as a network
> interface. This is how the bridge thing is implemented in Linux.
>
There are also other options for creating bridges, i.e. like using the dsa
driver.
But the overall result is the same.
With the dsa, you can only access the "host interface" not the external
On Mon, 13 Mar 2023 at 12:12, Kamil Zaripov wrote:
>
>
> On 12 Mar 2023, at 14:18, Erez wrote:
>
> Sounds cool, but requires multiple clocks on the network interface.
> Hardware or logic using a single hardware clock.
> I do know that some do work on this.
> Both in k
sets the field, but never checks the value.
Anyhow we do not support PTP version 1 hardware,
so perhaps it is better to break faster :-)
Erez
things. It is similar to 2a2532d66121 ("Bump to IEEE 1588-2019 version")
> however, where ptp4l switches the version field to the IEEE1588-2019
Hi Richard,
You forgot to add 'tz2alt' to .gitignore.
Erez
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
On Wed, 22 Feb 2023 at 16:07, Richard Cochran
wrote:
> Dear Devs,
>
> I'll be releasing 4.0 in the next day or two. I won't be taking any
>
Great :-)
Will your power profile patch be included?
It looks like it passed the review.
Erez
> new stuff until after the
be representable (for example, 1 AD) is not
yet determined.
Systems purchased after the approval of this volume of POSIX.1-2017 should
be evaluated to determine whether their lifetime will extend past 2038."
Seems that instead of 'BUG 2000', we will have 'Bug 2038' :-)
; + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> along
> + * with this program; if not, write to the Free Software Foundation,
> Inc.,
> + *
r32 jumpSeconds;
> + struct {
> + uint16_t seconds_msb; /* 16 bits + */
> + uint32_t seconds_lsb; /* 32 bits = 48 bits*/
> + } PACKED timeOfNextJump;
> + uint8_t pad;
> +} PACKED;
> +
> struct management_tlv {
> E
On Thu, 29 Dec 2022 at 08:02, Devasish Dey
wrote:
> Hi Erez,
>
>
>> > + goto failed;
>> > + }
>>
>> I think it is better to merge this ioctl and the socket creation with
>> sk_get_ts_info().
>> No reason for duplication.
>
On Thu, 29 Dec 2022 at 07:52, SyncMonk Technologies
wrote:
> Get the interface speed related information using ethtool and
> convert interface speed to bit rate in attoseconds per bit.
>
> v4: adding interface bit period in iface_if_info. This bit period
> is updated during init time and when
On Thu, 22 Dec 2022 at 18:41, Sebastian Andrzej Siewior <
bige...@linutronix.de> wrote:
> Replace the hand written BPF code with something that has been created
>
We love tcpdump and use its output as reference.
But we prefer using opcodes, we can understand and NOT numbers generated by
tcpdump,
transmitting PTP timestamp interface, excluding line
encoding.
The value is encoded as an unsigned integer in units of attoseconds (10–18 s)
to accommodate interface bit periods less than 1 ns."
Thanks,
Devasish.
On Fri, 9 Dec 2022 at 18:08, Geva, Erez
mailto:erez.geva@siemens.com>> wr
is my opinion, but you can defer.
Thanks,
Devasish.
Erez
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
On Tue, 2022-12-13 at 17:27 +0100, Erez Geva wrote:
On Tue, 2022-12-13 at 10:56 +0530, Devasish Dey wrote:
> + /* Megabits per secon converted to attoseconds per bit. */
> + return 1ULL/ iface->if_info.speed;
Performing division in running is not a very good id
On Tue, 2022-12-13 at 17:39 +0100, Erez Geva wrote:
On Tue, 2022-12-13 at 10:39 +0530, Devasish Dey wrote:
> + goto failed;
> + }
I think it is better to merge this ioctl and the socket creation with
sk_get_ts_info().
No reason for duplication.
You can use a static funct
r));
> + if (!extra) {
> + return -1;
> + }
> + mir = (struct msg_interface_rate_tlv *) extra->tlv;
> + mir->type = TLV_ORGANIZATION_EXTENSION;
> + mir->length = sizeof(*mir) - sizeof(mir->type) - sizeof(mir-
> >length);
> + memcpy(mir-&g
anizationally Unique Identifiers */
> +#define ITU_T_COMMITTEE 0x00, 0x19, 0xA7
> +extern uint8_t itu_t_id[3];
> +
> +struct msg_interface_rate_tlv {
> + Enumeration16 type;
> + UInteger16 length;
> + Octet id[3];
> + Octet subtype[3];
>
e_index().
> * @return An open socket on success, -1 otherwise.
> @@ -78,6 +89,14 @@ int sk_general_init(int fd);
> */
> int sk_get_ts_info(const char *name, struct sk_ts_info *sk_info);
>
> +/**
> + * Obtain supporte interface information
> + * @param name The
On Mon, 2022-12-05 at 12:52 -0500, vincent.cheng...@renesas.com wrote:
> On Mon, Dec 05, 2022 at 02:44:07AM EST, Geva, Erez wrote:
> > On Fri, 2022-12-02 at 15:33 -0500,
> > vincent.cheng...@renesas.com wrote:
> > > From: Vincent Cheng
> > >
> > > In ha
On Wed, 2022-12-07 at 06:59 -0800, Richard Cochran wrote:
> On Thu, Nov 17, 2022 at 02:15:23PM -0800, Jacob Keller wrote:
> > On 11/17/2022 1:34 PM, Geva, Erez wrote:
>
> > > The problem is the fallback works only on build.
> > > But if the build system is newe
+
> LIST_FOREACH(piter, &c->ports, list) {
> enum port_state ps;
> enum fsm_event event;
P.S.
All patches should be on top of master, no need to comment on obvious.
The rest of the explantation is perfect :-)
Erez
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
On Thu, 2022-11-17 at 18:27 +, Keller, Jacob E wrote:
>
>
> > -Original Message-
> > From: Geva, Erez
> > Sent: Thursday, November 17, 2022 9:13 AM
> > To: Keller, Jacob E ; linuxptp-
> > de...@lists.sourceforge.net
> > Subject: Re:
eq(const struct PortIdentity *a, const struct PortIdentity *b)
And debug and find the real reason you have the bug.
And than send a real bug fix :-)
Erez
> ---
> bmc.c | 17 ++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/bmc.c b/bmc.c
On Thu, 2022-11-17 at 08:02 +, Magnus Armholt via Linuxptp-devel
wrote:
> Nothing to complain about the patch, thanks for looking after the
> code base!
>
> > LinuxPTP source still prefers to keep with the GNU C89 convention
> > of
> > variables being at the top of the function. Newer versions
/phc_ctl.c
> @@ -311,7 +311,7 @@ static int do_caps(clockid_t clkid, int cmdc,
> char *cmdv[])
> caps.n_pins,
> caps.pps ? "has" : "doesn't have",
> caps.cross_timestamping ? "has" : "doesn't have&qu
ment the
receive side.
You can filter the received packets using a kernel BPF filter, to
filter only the wanted VLAN id and PTP packets.
Erez
>
> Mika Paulamäki (1):
> Add configurable VLAN tags for Ethernet
>
> config.c | 3 +++
> raw.c | 47 +++
2' variants in
> principle that developer doesn't have to remember "is this variant ok
> to get
> all the new features going forward?"
There are more 12 bytes in the reserve.
I guess once we pass them, we would need a non-backward flag, but till
then, I think we can keep
get you can
add in any case.
Erez
-Original Message-
From: izunna.otiji...@renesas.com
Sent: Wednesday, 2 November 2022 22:33
To: linuxptp-devel@lists.sourceforge.net
Subject: [Linuxptp-devel] [PATCH 0/5] *** Add support for configurable data set
members in ptp4l ***
From: Izunna
Already have it in
https://github.com/erezgeva/libptpmgmt/blob/master/src/ptp.h
Erez 😊
-Original Message-
From: Miroslav Lichvar
Sent: Thursday, 27 October 2022 17:00
To: Jacob Keller
Cc: linuxptp-devel@lists.sourceforge.net
Subject: Re: [Linuxptp-devel] [PATCH] phc_ctl: add pin_cfg
ys2phc into ptp4l and
let the system clock or any non PTP clock behave as a virtual port.
But I think you should start by explicitly explaining in simple, what you
think is missing in the current ts2phc and sys2phc to fulfill your needs,
but without moving to a robust ptp4l with "virtual
though in most cases we want to make the decision, who is the
master/grandmaster of our PTP domain,
As PTP does work with "priorities", it means that in practice, any PTP
entity with a higher value may become the master. So a feature like that in
phc2sys does make sense :-)
Erez
>
> Si
Hi,
I think we should put a comment there.
It does looks buzzard to see ' ts->tv_nsec = ntx.time.tv_usec'.
Though this is how 'ADJ_NANO' works 😊
Erez
-Original Message-
From: Miroslav Lichvar
Sent: Monday, 26 September 2022 10:57
To: j.raczyn
1 - 100 of 267 matches
Mail list logo
