[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Steffen Offermann (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469853#comment-15469853 ] Steffen Offermann commented on LOG4J2-1259: --- Gary, this is the original feature

Re: Local build Ok with Java 7 and 8

2016-09-07 Thread Mikael Ståldal
Now builds fine on Linux, Java 8. On Wed, Sep 7, 2016 at 5:56 AM, Matt Sicker wrote: > Built fine on Mac OS, Java 8. > > On 6 September 2016 at 22:08, Gary Gregory wrote: > >> I am using: >> >> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; >> 2015-11-10T08:41:47-08:00) >> Maven

[jira] [Commented] (LOG4J2-1528) Serialize configuration into a log4j2.xml file

2016-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470100#comment-15470100 ] Mikael Ståldal commented on LOG4J2-1528: [~garydgregory], can you test this on Wi

Re: Log4j 2.7

2016-09-07 Thread Mikael Ståldal
Those three issues are resolved now, so I am fine with doing a release. On Mon, Sep 5, 2016 at 12:19 PM, Mikael Ståldal wrote: > I think we should get the following done before a 2.7 release: > - https://issues.apache.org/jira/browse/LOG4J2-1518 > - https://issues.apache.org/jira/browse/LOG4J2-1

[jira] [Updated] (LOG4J2-1567) DynamicThresholdFilter

2016-09-07 Thread jdumetier (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jdumetier updated LOG4J2-1567: -- Attachment: DynamicThreasholdFilter.patch.txt > DynamicThresholdFilter > --- > >

[jira] [Created] (LOG4J2-1567) DynamicThresholdFilter

2016-09-07 Thread jdumetier (JIRA)
jdumetier created LOG4J2-1567: - Summary: DynamicThresholdFilter Key: LOG4J2-1567 URL: https://issues.apache.org/jira/browse/LOG4J2-1567 Project: Log4j 2 Issue Type: Bug Components: Fil

[jira] [Resolved] (LOG4J2-1567) DynamicThresholdFilter

2016-09-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1567. - Resolution: Duplicate Fix Version/s: 2.7 It looks like this is a duplicate of LOG4J2-1511.

[jira] [Created] (LOG4J2-1568) Add support for LinkedTransferQueue to AsyncAppender

2016-09-07 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-1568: --- Summary: Add support for LinkedTransferQueue to AsyncAppender Key: LOG4J2-1568 URL: https://issues.apache.org/jira/browse/LOG4J2-1568 Project: Log4j 2 Issue Ty

[jira] [Updated] (LOG4J2-1568) Add support for java.util.concurrent.LinkedTransferQueue to AsyncAppender

2016-09-07 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-1568: Summary: Add support for java.util.concurrent.LinkedTransferQueue to AsyncAppender (was: Add suppo

Re: logging-log4j2 git commit: Add changelog entries for LOG4J2-1430 and LOG4J2-1439

2016-09-07 Thread Matt Sicker
Added a new issue and changelog entry. On 6 September 2016 at 22:54, Matt Sicker wrote: > Good point. I'll add one tomorrow morning. > > On 6 September 2016 at 17:37, Remko Popma wrote: > >> It would be good to have a change log entry for the new TransferQueue >> support in AsyncAppender. >> >>

[jira] [Resolved] (LOG4J2-1568) Add support for java.util.concurrent.LinkedTransferQueue to AsyncAppender

2016-09-07 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker resolved LOG4J2-1568. - Resolution: Fixed Added this feature in the LOG4J2-1430 branch that was merged. Changelog updated

Re: logging-log4j2 git commit: Add changelog entries for LOG4J2-1430 and LOG4J2-1439

2016-09-07 Thread Remko Popma
Good stuff! On Wed, Sep 7, 2016 at 10:48 PM, Matt Sicker wrote: > Added a new issue and changelog entry. > > On 6 September 2016 at 22:54, Matt Sicker wrote: > >> Good point. I'll add one tomorrow morning. >> >> On 6 September 2016 at 17:37, Remko Popma wrote: >> >>> It would be good to have a

[jira] [Commented] (LOG4J2-1430) Add optional support for Conversant DisruptorBlockingQueue in AsyncAppender

2016-09-07 Thread John Cairns (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470852#comment-15470852 ] John Cairns commented on LOG4J2-1430: - I'll look into adding a classifier for a futur

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470895#comment-15470895 ] Gary Gregory commented on LOG4J2-1259: -- You can inherit from {{AbstractLifeCycle}} a

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470911#comment-15470911 ] Gary Gregory commented on LOG4J2-1259: -- I added an abstract class {{AbstractTriggeri

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470917#comment-15470917 ] Gary Gregory commented on LOG4J2-1259: -- I have not seen any prep work on our end for

[jira] [Comment Edited] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470911#comment-15470911 ] Gary Gregory edited comment on LOG4J2-1259 at 9/7/16 3:26 PM: -

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470924#comment-15470924 ] Remko Popma commented on LOG4J2-1259: - Does the {{TriggeringPolicy}} interface still

Re: Link to JAX Innovation Awards voting page from Log4j site?

2016-09-07 Thread Remko Popma
Several pages for the 2.6.2 and the 1.2.17 site now have a banner and link to the JAX Innovation Award vote page. Time to hit the social media! On Wed, Sep 7, 2016 at 8:00 AM, Remko Popma wrote: > FYI I'm thinking of doing this by directly modifying the HTML files under > https://svn.apache.org/

Re: logging-log4j2 git commit: [LOG4J2-1259] Log4j threads are leaking on tomcat shutdown. TriggeringPolicy now implement LiceCycle which has a stop(long, TimeUnit) method. This TriggeringPolicy.stop(

2016-09-07 Thread Remko Popma
I'm okay with most of this except for the part where we modify the TriggeringPolicy interface. I'm sure there is a way to accomplish the goal without breaking binary compatibility. With the AbstractTriggeringPolicy introduced in a later commit, probably all that remains is to use "instanceof LifeCy

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Remko Popma
We should do this before starting the 2.7 release. If we are serious about being the replacement for Log4j 1.2 we should not break user code for no good reason. On Wed, Sep 7, 2016 at 7:25 AM, Remko Popma wrote: > I think that would be good. > > Based on the number of Jira tickets being filed we

[jira] [Commented] (LOG4J2-1535) KafkaAppender NullPointerException when putting the related jars in tomcat lib

2016-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471003#comment-15471003 ] Mikael Ståldal commented on LOG4J2-1535: What is the status of this issue? Has an

[jira] [Updated] (LOG4J2-1523) Log4j 1 appenders

2016-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal updated LOG4J2-1523: --- Fix Version/s: (was: 2.7) > Log4j 1 appenders > - > > Key

[jira] [Updated] (LOG4J2-1524) Support overall structure of Log4j 1 log4j.properties

2016-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal updated LOG4J2-1524: --- Fix Version/s: (was: 2.7) > Support overall structure of Log4j 1 log4j.properties > -

[jira] [Updated] (LOG4J2-1525) Convert Log4j 1 log4j.properties into equvivalent Log4j 2 config file

2016-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal updated LOG4J2-1525: --- Fix Version/s: (was: 2.7) > Convert Log4j 1 log4j.properties into equvivalent Log4j 2 con

[jira] [Closed] (LOG4J2-1181) Scala wrapper for Log4j 2 API

2016-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal closed LOG4J2-1181. -- > Scala wrapper for Log4j 2 API > - > > Key: LOG4J2-118

[jira] [Updated] (LOG4J2-1523) Log4j 1 appenders

2016-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal updated LOG4J2-1523: --- Description: Support all appenders in Log4j 1 to the extent possible and reasonable. All app

[jira] [Updated] (LOG4J2-1523) Log4j 1 appenders

2016-09-07 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal updated LOG4J2-1523: --- Description: Support all appenders in Log4j 1 to the extent possible and reasonable. All app

Re: Log4j 2.7

2016-09-07 Thread Remko Popma
At the risk of sounding like a broken record, we should revert the changes that broke binary compatibility before doing a release. The ones I am aware of are the change to the TriggerPolicy interface and the removed factory methods, there may be others. On Wed, Sep 7, 2016 at 6:16 PM, Mikael Ståld

Jenkins build became unstable: Log4j 2.x #2272

2016-09-07 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471284#comment-15471284 ] Gary Gregory commented on LOG4J2-1259: -- Hi, The method {{RollingFileManager.release

[jira] [Comment Edited] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471284#comment-15471284 ] Gary Gregory edited comment on LOG4J2-1259 at 9/7/16 5:40 PM: -

[jira] [Commented] (LOG4J2-1528) Serialize configuration into a log4j2.xml file

2016-09-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471328#comment-15471328 ] Gary Gregory commented on LOG4J2-1528: -- I get CR LF for line endings. I also get nas

Build failed in Jenkins: Log4j 2.x #2273

2016-09-07 Thread Apache Jenkins Server
See Changes: [ggregory] Track stopped state during shutdown (WIP). [ggregory] org.apache.logging.log4j.core.appender.OutputStreamManager.closeOutputStream() [ggregory] Properly track resources during shutdown. --

Re: logging-log4j2 git commit: [LOG4J2-1259] Log4j threads are leaking on tomcat shutdown. TriggeringPolicy now implement LiceCycle which has a stop(long, TimeUnit) method. This TriggeringPolicy.stop(

2016-09-07 Thread Gary Gregory
To facilitate things, I created an AbstractTriggeringPolicy that extends AbstractLifeCycle; that should help future-proof changes to some extent. Are you thinking about something like public interface "TriggeringPolicy2 extends TriggeringPolicy, LifeCycle"? Gary On Wed, Sep 7, 2016 at 11:38 AM,

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
On Wed, Sep 7, 2016 at 11:41 AM, Remko Popma wrote: > We should do this before starting the 2.7 release. > If we are serious about being the replacement for Log4j 1.2 we should not > break user code for no good reason. > What does this have to do with 1.2? Gary > > On Wed, Sep 7, 2016 at 7:25

Fwd: [1/2] logging-log4j2 git commit: Remove obsolete comment

2016-09-07 Thread Gary Gregory
How do you know what is supported then? Gary -- Forwarded message -- From: Date: Wed, Sep 7, 2016 at 12:15 PM Subject: [1/2] logging-log4j2 git commit: Remove obsolete comment To: comm...@logging.apache.org Repository: logging-log4j2 Updated Branches: refs/heads/master 15eb84

Build failed in Jenkins: Log4j 2.x #2274

2016-09-07 Thread Apache Jenkins Server
See Changes: [ggregory] Add missing closed check during shutdown. -- [...truncated 5064 lines...] [INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ log4j-api-scala_2.11 --- [INFO] Building jar:

Fwd: Build failed in Jenkins: Log4j 2.x #2274

2016-09-07 Thread Matt Sicker
Compile error! Twice in a row even. -- Forwarded message -- From: Apache Jenkins Server Date: 7 September 2016 at 14:21 Subject: Build failed in Jenkins: Log4j 2.x #2274 To: log4j-dev@logging.apache.org See Changes: [ggr

Fwd: Build failed in Jenkins: Log4j 2.x #2273

2016-09-07 Thread Gary Gregory
I need to adjust the DB mocking test to fix this... but I can't do it ATM, in a couple of hours... Gary -- Forwarded message -- From: Apache Jenkins Server Date: Wed, Sep 7, 2016 at 1:59 PM Subject: Build failed in Jenkins: Log4j 2.x #2273 To: log4j-dev@logging.apache.org See

Re: Build failed in Jenkins: Log4j 2.x #2274

2016-09-07 Thread Gary Gregory
Yes, I forgot to adjust the tricky DB mocking tests :-( I can only fix that late this PM (PST) or tonight. Gary On Wed, Sep 7, 2016 at 3:21 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > Changes: > > [ggregory] Add

Re: Build failed in Jenkins: Log4j 2.x #2274

2016-09-07 Thread Matt Sicker
I would be totally ok with replacing those tests with Mockito instead. EasyMock is anything but easy. ;) On 7 September 2016 at 14:31, Gary Gregory wrote: > Yes, I forgot to adjust the tricky DB mocking tests :-( I can only fix > that late this PM (PST) or tonight. > > Gary > > On Wed, Sep 7, 20

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Ralph Goers
We really need to document what we want to strive to maintain compatibility with in core. Basic components like Appenders and their managers, Filters, Layouts, & Lookups or pretty much any Plugin type would be at the top of my list. Ralph > On Sep 7, 2016, at 11:05 AM, Gary Gregory wrote: >

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
On Wed, Sep 7, 2016 at 1:02 PM, Ralph Goers wrote: > We really need to document what we want to strive to maintain > compatibility with in core. Basic components like Appenders and their > managers, Filters, Layouts, & Lookups or pretty much any Plugin type would > be at the top of my list. > B

Re: Build failed in Jenkins: Log4j 2.x #2274

2016-09-07 Thread Gary Gregory
On Wed, Sep 7, 2016 at 1:03 PM, Matt Sicker wrote: > I would be totally ok with replacing those tests with Mockito instead. > EasyMock is anything but easy. ;) > I'm no fan either but I cannot take the time to do this work. Gary > > On 7 September 2016 at 14:31, Gary Gregory wrote: > >> Yes,

Re: Build failed in Jenkins: Log4j 2.x #2274

2016-09-07 Thread Gary Gregory
OK, I fixed the DB tests, I apologize for causing the build to fail. Gary On Wed, Sep 7, 2016 at 4:25 PM, Gary Gregory wrote: > On Wed, Sep 7, 2016 at 1:03 PM, Matt Sicker wrote: > >> I would be totally ok with replacing those tests with Mockito instead. >> EasyMock is anything but easy. ;) >>

Re: Log4j 2.7

2016-09-07 Thread Gary Gregory
If you care about Core BC, you could start with running Clirr... Gary On Wed, Sep 7, 2016 at 9:26 AM, Remko Popma wrote: > At the risk of sounding like a broken record, we should revert the changes > that broke binary compatibility before doing a release. The ones I am aware > of are the change

Build failed in Jenkins: Log4j 2.x #2275

2016-09-07 Thread Apache Jenkins Server
See Changes: [ggregory] Adjust tests for previous commit about cleaning up resources and -- [...truncated 4856 lines...] [INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ log4j-api-scala_2.11 ---

Re: logging-log4j2 git commit: [LOG4J2-1259] Log4j threads are leaking on tomcat shutdown. TriggeringPolicy now implement LiceCycle which has a stop(long, TimeUnit) method. This TriggeringPolicy.stop(

2016-09-07 Thread Remko Popma
Introducing an abstract class implementating both TriggeringPolicy and LifeCycle will help future users, that's good. I don't think you need another interface. To be backwards compatible we need to keep using the existing TriggeringPolicy interface. Then, in places where you want to call a Li

Jenkins build is unstable: Log4j 2.x #2276

2016-09-07 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Fwd: Jenkins build is unstable: Log4j 2.x #2276

2016-09-07 Thread Gary Gregory
Hm... mystery: java.io.EOFException at org.apache.logging.log4j.core.appender.rolling.RollingAppenderSizeTest.testAppender(RollingAppenderSizeTest.java:153) Does not happen for me locally... Gary -- Forwarded message -- From: Apache Jenkins Server Date: Wed, Sep 7, 2

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Remko Popma
We should make an effort not to break compatibility unless it's unavoidable. There is usually a way to accomplish things without breaking BC. This is doubly true for plugins but should be our policy in general. We should not make breaking changes for aesthetic reasons. For example, NullOutputS

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
I do not think NullOutputStream.NULL_OUTPUT_STREAM is a good example because the Core util package is or should out of bounds for BC. I thought we had "agreed" on that. Gary On Wed, Sep 7, 2016 at 5:29 PM, Remko Popma wrote: > We should make an effort not to break compatibility unless it's > un

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Matt Sicker
I agree that util packages are out of scope for BC. That's especially true in log4j-api where everything else has BC concerns. On 7 September 2016 at 21:14, Gary Gregory wrote: > I do not think NullOutputStream.NULL_OUTPUT_STREAM is a good example > because the Core util package is or should out

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
For Core util's NullOutputStream, I deprecated NULL_OUTPUT_STREAM in favor of getInstance(). It seems OK to delete NULL_OUTPUT_STREAM altogether IMO. Thoughts from others? Gary On Wed, Sep 7, 2016 at 8:52 PM, Matt Sicker wrote: > I agree that util packages are out of scope for BC. That's espec

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Remko Popma
Okay. Shall we introduce an @Internal annotation? Sent from my iPhone > On 2016/09/08, at 12:52, Matt Sicker wrote: > > I agree that util packages are out of scope for BC. That's especially true in > log4j-api where everything else has BC concerns. > >> On 7 September 2016 at 21:14, Gary Gre

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
On Wed, Sep 7, 2016 at 9:17 PM, Remko Popma wrote: > Okay. > Shall we introduce an @Internal annotation? > Please no, everything in Core is internal. I think we need to start with English sentences before we get caught up on details of how to communicate that to users. Gary > > Sent from my i

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Matt Sicker
This is actually why I suggested making an spi package long ago in core for public classes that would remain BC. Sadly, it's a little late for that now. On 7 September 2016 at 23:22, Gary Gregory wrote: > On Wed, Sep 7, 2016 at 9:17 PM, Remko Popma wrote: > >> Okay. >> Shall we introduce an @In

Re: Build failed in Jenkins: Log4j 2.x #2274

2016-09-07 Thread Matt Sicker
Next time I'm in a unit testing mood, I'll take a look at migrating them to use Mockito then. On 7 September 2016 at 18:36, Gary Gregory wrote: > OK, I fixed the DB tests, I apologize for causing the build to fail. > > Gary > > On Wed, Sep 7, 2016 at 4:25 PM, Gary Gregory > wrote: > >> On Wed,

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
On Wed, Sep 7, 2016 at 9:26 PM, Matt Sicker wrote: > This is actually why I suggested making an spi package long ago in core > for public classes that would remain BC. Sadly, it's a little late for that > now. > It's never too late ;-) We could do that and call it 2.8 or surely for 3.0. BC for

Re: Build failed in Jenkins: Log4j 2.x #2274

2016-09-07 Thread Gary Gregory
That would be pretty low on my priority list ;-) Gary On Wed, Sep 7, 2016 at 9:27 PM, Matt Sicker wrote: > Next time I'm in a unit testing mood, I'll take a look at migrating them > to use Mockito then. > > On 7 September 2016 at 18:36, Gary Gregory wrote: > >> OK, I fixed the DB tests, I apol

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
FWIW, here is what Clirr finds for removed code: [ERROR] 7002: org.apache.logging.log4j.core.appender.ConsoleAppender$Builder: Method 'public org.apache.logging.log4j.core.appender.ConsoleAppender$Builder setFilter(org.apache.logging.log4j.core.Filter)' has been removed [ERROR] 7002: org.apache.lo

Jenkins build is still unstable: Log4j 2.x #2277

2016-09-07 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Created] (LOG4J2-1569) Update Jackson from 2.8.1 to 2.8.2

2016-09-07 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1569: Summary: Update Jackson from 2.8.1 to 2.8.2 Key: LOG4J2-1569 URL: https://issues.apache.org/jira/browse/LOG4J2-1569 Project: Log4j 2 Issue Type: Improvement

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Ralph Goers
Everything is internal, but as I said previously, there are things where we do want to try to maintain compatibility - plugins being one of them. Also as I said, we really need to document where anyone making customizations is at risk and where they aren’t. Ralph > On Sep 7, 2016, at 9:22 PM,

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
What about code in the Core util package? Gary On Wed, Sep 7, 2016 at 10:06 PM, Ralph Goers wrote: > Everything is internal, but as I said previously, there are things where > we do want to try to maintain compatibility - plugins being one of them. > Also as I said, we really need to document w

[jira] [Closed] (LOG4J2-1569) Update Jackson from 2.8.1 to 2.8.2

2016-09-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1569. Resolution: Fixed In Git master. Local build passes 'mvn clean test'. > Update Jackson from 2.8.1

Jenkins build is back to stable : Log4j 2.x #2278

2016-09-07 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
So what would this look like? Just stick all the interfaces in there? And add more interfaces for things that are "public" and "supported"? Gary On Wed, Sep 7, 2016 at 9:26 PM, Matt Sicker wrote: > This is actually why I suggested making an spi package long ago in core > for public classes that

Re: Deprecated factory methods replaced by builders.

2016-09-07 Thread Gary Gregory
We can take a one step at a time approach too. There is only one interface in javax.security.auth.spi... Gary On Wed, Sep 7, 2016 at 11:23 PM, Gary Gregory wrote: > So what would this look like? Just stick all the interfaces in there? And > add more interfaces for things that are "public" and "

[jira] [Created] (LOG4J2-1570) Logging with a lambda expression with a method call that also logs causes logs within method call to reference line num and method name as parent method

2016-09-07 Thread Joel Berta (JIRA)
Joel Berta created LOG4J2-1570: -- Summary: Logging with a lambda expression with a method call that also logs causes logs within method call to reference line num and method name as parent method Key: LOG4J2-1570 URL

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Steffen Offermann (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473003#comment-15473003 ] Steffen Offermann commented on LOG4J2-1259: --- Thanks again, Gary! {{RollingFile

[jira] [Comment Edited] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

2016-09-07 Thread Steffen Offermann (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473003#comment-15473003 ] Steffen Offermann edited comment on LOG4J2-1259 at 9/8/16 6:51 AM: