On Fri, 6 Mar 2020 23:12:57 GMT, Kevin Rushforth wrote:
>> A simple readability cleanup for the files that were changed in #113.
>>
>> Note that the boolean property has an `instanceof` check that doesn't exist
>> in the other properties.
>
> I note that this also changes the wrapper property
On Wed, 5 Feb 2020 13:48:45 GMT, Kevin Rushforth wrote:
>> We have a few performance tests in apps/performance, but I don't know how up
>> to date they are. They might give you a
>> starting point on how to measure FPS, but really the harder part is going to
>> be coming up with a workload --
I added a note about removing Dprism.order=sw.
On Wed, Mar 25, 2020 at 7:27 PM Tres Finocchiaro
wrote:
> With the help from a paid fx support channel, we're making headway with
> this. The main help was disabling the recommended software option. At
> time of writing this, I recommend this
Is this a bug caused by JavaFX or Gluon?
On Fri, Mar 20, 2020 at 9:24 PM Debayan Sutradhar <
debayansutradh...@gmail.com> wrote:
> Swipe Events like swipeup and swipedown don't get registered and their
> related set methods don't get called. OnTouch works rarely.
>
> JavaFX Version : 14
> Gluon
### Cause
`Animation#jumpTo(Duration)` does not handle `Duration.INDEFINITE` properly.
This causes
`InfiniteClipEnvelope#jumpTo(long)` to receive an erroneous value and start the
animation not from the end, depending
on the modulo calculation.
### Fix
For infinite cycles, use the
On Wed, 15 Apr 2020 20:59:40 GMT, Kevin Rushforth wrote:
>> Here are the results on Phil's machine, which is a Mac Book Pro with a
>> graphics accelerator (Nvidia, I think).
>>
>> Without the patch:
>> 2000 quads average 8.805 fps
>>
>> With the patch:
>> 2000 quads average 4.719 fps
>>
>>
" from
> "11" to "14". Not sure if anything more is needed. I've never tried it.
>
> -- Kevin
>
>
> On 4/13/2020 1:49 PM, Nir Lisker wrote:
> > Hi,
> >
> > I would like to test the preview features in Java 14 on JavaFX. What
> > changes should I make in the build files to get it working?
> >
> > - Nir
>
>
rgs that gradle generates to pass to javac (using
> @.../java-compiler-args.txt)
>
> -- Kevin
>
> On 4/13/2020 4:10 PM, Nir Lisker wrote:
>
> Thanks, yes, testing on JavaFX itself.
> I made these changes. I'm getting "error: invalid source release: 14" when
> trying to
Hi,
I would like to test the preview features in Java 14 on JavaFX. What
changes should I make in the build files to get it working?
- Nir
I managed to get it working by adding "--enable-preview" in several
places, I'm not sure if they are all needed. There will be a test branch in
my fork with the working build.grade.
On Tue, Apr 14, 2020 at 4:35 AM Nir Lisker wrote:
> It contains:
> -source
> 14
> -targ
Hi,
For those who didn't build Webkit, running tests is done with `-x
:web:test`. I think it makes sense to just add a test task that does
exactly that, for convenience.
What do you think?
- Nir
On Fri, 13 Mar 2020 15:02:48 GMT, Kevin Rushforth wrote:
> So this begs the question: Do we still want to do this? Is the cleanup worth
> the extra memory used?
I'm not sure. This raises the opposite question: are there any places where we
can benefit from introducing anonymous
classes
On Fri, 3 Jan 2020 09:26:43 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Attenuation and range changed internally to floats from doubles
>
> I have added few co
On Thu, 27 Feb 2020 21:29:27 GMT, Martin Polakovic
wrote:
>> If there are many columns, the current TableView will stall scrolling.
>> Resolving this performance issue requires column
>> virtualization. Virtualization mode is enabled when the row height is fixed
>> by the following method.
>>
On Fri, 27 Mar 2020 17:10:09 GMT, Johan Vos wrote:
>> Now that we have switched to using gradle 6.3 we can switch to using JDK 14
>> as the boot JDK for JavaFX 15 builds.
>>
>> This will not change the minimum JDK version needed to build or run JavaFX,
>> which remains at 11. We will continue
BTW, Tomas Mikula wrote about this on
http://tomasmikula.github.io/blog/2015/02/10/the-trouble-with-weak-listeners.html
.
There is a comment at the end that is worth a read too.
On Thu, Mar 26, 2020 at 1:53 PM Jeanette Winzenburg
wrote:
>
> Zitat von Kevin Rushforth :
>
> Thanks for your
Vote: YES
On Thu, Mar 26, 2020 at 1:46 PM Kevin Rushforth
wrote:
> Vote: YES
>
> On 3/26/2020 4:44 AM, Kevin Rushforth wrote:
> > I hereby nominate Arun Joseph [1] to OpenJFX Committer.
>
>
Mostly refactoring in preparation of the upcoming fixes. The changes might look
like a lot, but it's mostly rearranging
of methods. Summery of changes:
### Animation
* Added `isNearZero` and `areNearEqual` methods that deal with `EPSILON` checks.
* Added `isStopped`, `isRunning` and `isPaused`
>
> Will there also be any performance drop in case you just use the default
> parameters for the lighting?
That's what we're testing.
The default, which corresponds to the current lighting, should not need
> any additional computations
> and thus no performance drop.
But there is no way to
On Wed, 22 Apr 2020 00:08:05 GMT, Kevin Rushforth wrote:
>> ### Cause
>>
>> `Animation#jumpTo(Duration)` does not handle `Duration.INDEFINITE` properly.
>> This causes
>> `InfiniteClipEnvelope#jumpTo(long)` to receive an erroneous value and start
>> the animation not from the end, depending
On Mon, 27 Apr 2020 13:19:49 GMT, Kevin Rushforth wrote:
>> The title of this PR should match exactly the title of the JBS bug. So:
>>
>> 8243115: Spurious invalidations due to bug in IntegerBinding and other
>> classes
>
> @arapte can you also review this?
I will review this too anyway.
Hi all,
My PR [1] for adding attenuation for PointLight is pending tests from
setups with recent NVidia or AMD GPUs. If anyone has such a setup, it would
greatly help to get tests results from it.
Thanks,
Nir
[1] https://github.com/openjdk/jfx/pull/43
e modified version of the benchmark, unless you have
> a working version.
>
> -- Kevin
>
>
> On 4/23/2020 2:41 PM, Nir Lisker wrote:
> > I think so. The test is relatively simple, so it should be worth it.
> Thanks.
> >
> > On Fri, Apr 24, 2020 at 12:04 AM David Gri
I think so. The test is relatively simple, so it should be worth it. Thanks.
On Fri, Apr 24, 2020 at 12:04 AM David Grieve
wrote:
> I have an NVIDIA Quadro P400. Will that help?
>
> -Original Message-
> From: openjfx-dev On Behalf Of Nir
> Lisker
> Sent: Thursday, A
On Tue, 5 May 2020 05:47:30 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Wed, 6 May 2020 14:18:06 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Tue, 5 May 2020 11:19:55 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Tue, 12 May 2020 17:58:09 GMT, John Hendrikx wrote:
> I'm fine with doing a fix, but I need to know which one. Avoiding NPE's and
> silently doing nothing is IMHO not very
> desirable as this will give the user of the API no feedback that something
> went wrong.
> So I would prefer to fix
On Mon, 11 May 2020 04:30:28 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Tue, 28 Apr 2020 00:00:28 GMT, Kevin Rushforth wrote:
>> I will review this too anyway.
>
>> I will review this too anyway.
>
> Thank you. That will be helpful.
As I started my review I noticed that `unbind` does not null-check its argument
`dependencies` like `bind` does and it
can lead
On Mon, 11 May 2020 22:27:27 GMT, Nir Lisker wrote:
>>> I will review this too anyway.
>>
>> Thank you. That will be helpful.
>
> As I started my review I noticed that `unbind` does not null-check its
> argument `dependencies` like `bind` does and it
> can le
if this is confirmed I can update the page.
On Tue, Apr 14, 2020 at 1:18 PM Florian Kirmaier
wrote:
> Hi everyone,
>
> it seems to me, that the newest JDK for Mac (MacOSX10.15.sdk) doesn't work
> to build JavaFX.
> It works for me with 10.14 but not with 10.15.
> Can anyone confirm this?
> It
I would say that for doubles, the minimum step size is the one given by ulp
= Math.ulp(double). Then the double case should behave like the
integer case where the ulp is 1 I think.
So, for the angle case of [0, 360), if we are at 360 - ulp, incrementing by
N * ulp will get us to (N-1) * ulp.
On
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request with a new target base due to a merge
or a rebase. The pull request now
contains 11 commits:
- Merge branch 'master' into 8217472_Add_attenuation_for_PointLight
- Attenuation and range chan
On Sat, 25 Apr 2020 17:07:21 GMT, Kevin Rushforth wrote:
> We should make sure that we aren't seeing any significant performance drop
> when rendering spheres (at a couple
> different tessellation levels) or boxes.
I missed this. Do you mean that the test should create a mesh of a sphere
On Thu, 7 May 2020 08:50:23 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Tue, 17 Mar 2020 11:43:16 GMT, Frederic Thevenet
wrote:
>> Issue JDK-8088198, where an exception would be thrown when trying to capture
>> a snapshot whose final dimensions would be
>> larger than the running platform's maximum supported texture size, was
>> addressed in openjfx14. The
I thought that Johan Vos's team did some work on Raspberry, maybe he can
comment on this.
On Mon, Mar 9, 2020 at 9:50 AM Debayan Sutradhar <
debayansutradh...@gmail.com> wrote:
> I have a large embedded project for raspberry pis (https://stream-pi.com)
> and recently its discord server crosses
On Tue, 17 Mar 2020 02:50:28 GMT, Nir Lisker wrote:
>> Updated test case:
>> [attenTest2.zip](https://github.com/openjdk/jfx/files/4332937/attenTest2.zip)
>
> On Win 10 with an AMD RX 470 4GB I get the following:
>
> Without the patch:
> 200 quads average 113 fps
&g
On Tue, 17 Mar 2020 11:01:55 GMT, Ambarish Rapte wrote:
>> Frederic Thevenet has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed code style and typo following review.
>
> The PR looks good to me, Please revert the changes in import.
> A simple readability cleanup for the files that were changed in #113.
>
> Note that the boolean property has an `instanceof` check that doesn't exist
> in the other properties.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revisio
Hi,
As I'm continuing my work on the animations front, I came across an
ambiguous behavior of JumpTo. The specifications don't say anything about
it, but in FiniteClipEnvelop, if the rate is negative, it jumps to the
specified time *counted from the end*. This seems intentional because it's
Updated
On Tue, Mar 24, 2020 at 3:26 AM Thiago Milczarek Sayao <
thiago.sa...@clamed.com.br> wrote:
> Hi,
>
> Can someone update
> https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX for Ubuntu
> 20.04?
>
>
> 1) libavformat-ffmpeg57 -> libavformat58
>
> 2) Need to add libxxf86vm-dev
> A simple readability cleanup for the files that were changed in #113.
>
> Note that the boolean property has an `instanceof` check that doesn't exist
> in the other properties.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last rev
Hi,
I posted the release notes for OpenJFX 14 on Reddit. The top comment [1]
complained about the presentation. Maybe on openjfx.io the Release Notes
link could show a more "friendly" summary with a link to the detailed
table. I suggest:
1. Including only changes that matter to the users of the
Changeset: e3026b9c
Author:Nir Lisker
Date: 2020-03-09 16:38:20 +
URL: https://git.openjdk.java.net/jfx/commit/e3026b9c
8240688: Remove the JavaBeanXxxPropertyBuilders constructors
Reviewed-by: kcr, arapte
!
modules/javafx.base/src/main/java/javafx/beans/property/adapter
On Fri, 6 Mar 2020 10:46:44 GMT, Frederic Thevenet
wrote:
>> Issue JDK-8088198, where an exception would be thrown when trying to capture
>> a snapshot whose final dimensions would be larger than the running
>> platform's maximum supported texture size, was addressed in openjfx14.
>> The fix,
On Sat, 14 Mar 2020 15:31:18 GMT, Kevin Rushforth wrote:
>> I'll attach the above modified testcase that I ran. I ran it on a relatively
>> new Windows 10 laptop and a rather ancient
>> MacBook Pro. I had to drastically reduce the number of quads on the Mac, but
>> the results are similar: no
On Tue, 1 Sep 2020 17:00:10 GMT, Kevin Rushforth wrote:
> gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests MyTest
What format is `MyTest`? Is it some relative path?
-
PR: https://git.openjdk.java.net/jfx/pull/43
Correction to the order of transforms specified in the docs of `Node`.
-
Commit messages:
- Remove whitespace
- Remove whitespace
- Initial commit
Changes: https://git.openjdk.java.net/jfx/pull/293/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=293=00
Issue:
On Tue, 1 Sep 2020 23:09:39 GMT, Kevin Rushforth wrote:
>>> gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests MyTest
>>
>> What format is `MyTest`? Is it some relative path?
>
> It can either be a fully qualified class name (with `.` as separator) or the
> unqualified name of
On Fri, 7 Aug 2020 22:37:15 GMT, Kevin Rushforth wrote:
>> Given that we don't have any automated tests for lighting (we have a couple
>> that verify that we can take a snapshot and
>> get the same result, but that isn't testing the lighting itself), probably
>> the most we can expect is a
> Correction to the order of transforms specified in the docs of `Node`.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/293/fi
On Fri, 11 Sep 2020 21:43:46 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added tags
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 34
> Moving implementation details about lazy evaluation and equality checking to
> `@implSpec`.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.java.n
On Sat, 12 Sep 2020 14:35:49 GMT, Kevin Rushforth wrote:
>> Marked as reviewed by kcr (Lead).
>
> I see that [SKARA-548](https://bugs.openjdk.java.net/browse/SKARA-548) is
> still an issue, and that the PR was marked
> ready without the CSR being approved.
Yeah I saw. The CSR has been
> Correction to the order of transforms specified in the docs of `Node`.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Added tags
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/293/files
- new: ht
> Correction to the order of transforms specified in the docs of `Node`.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Replaced link
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/293/files
- new: ht
> Moving implementation details about lazy evaluation and equality checking to
> `@implSpec`.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments and added
-
Changes:
- all:
On Tue, 15 Sep 2020 06:41:29 GMT, Bhawesh Choudhary
wrote:
>> This is pending response to comments above.
>
> 10ms
>
>
On Tue, 15 Sep 2020 15:57:00 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments and added
>
> Marked as reviewed by arapte (Rev
On Tue, 15 Sep 2020 16:29:58 GMT, Kevin Rushforth wrote:
>> It's not really ready to be integrated, right? It's not finding the CSR I
>> think.
>
> Correct. It is not yet ready.
> [SKARA-548](https://bugs.openjdk.java.net/browse/SKARA-548) is not yet
> resolved, so shows
> as ready even
On Sun, 30 Aug 2020 16:09:14 GMT, Nir Lisker wrote:
> Moving implementation details about lazy evaluation and equality checking to
> `@implSpec`.
This pull request has now been integrated.
Changeset: b2e2000c
Author: Nir Lisker
URL: https://git.openjdk.java.net/jfx/commit/b2
On Mon, 14 Sep 2020 09:57:26 GMT, yosbits
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8253086
>
> ObservableListWrapper.java
> * public boolean removeAll(Collection c)
> * public boolean retainAll(Collection c)
>
> These two methods use BitSet, but it doesn't make sense.
> By rewriting
On Mon, 31 Aug 2020 23:28:51 GMT, Nir Lisker wrote:
> Correction to the order of transforms specified in the docs of `Node`.
This pull request has now been integrated.
Changeset: d6dee348
Author: Nir Lisker
URL: https://git.openjdk.java.net/jfx/commit/d6dee348
Stats: 45 li
On Sat, 12 Sep 2020 14:41:01 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replaced link
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 336
> Correction to the order of transforms specified in the docs of `Node`.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Replaced a link
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/293/files
- new: ht
>
> PS: If someone can send me the URL for OpenJFX's JIRA or equivalent, I will
> submit a bug report.
>
bugreport.java.com
On Mon, Sep 14, 2020 at 11:03 PM wrote:
> While I am still looking for where I can file this problem I thought I'd
> bring it to the list. A program I use in my course
ars to be for Java SE bug
> reporting and I thought that JavaFX as OpenJFX is not part of the Java SE
> distribution. If so then this may not be where I report my issue.
>
>
>
> Ken
>
>
>
>
>
> *From:* Nir Lisker
> *Sent:* September 14, 2020 4:19 PM
>
On Sat, 12 Sep 2020 17:16:38 GMT, Kevin Rushforth wrote:
> This PR updates the `CONTRIBUTING.md` guide to address the following:
>
> 1. Clarify the process for adding new features / API changes, specifically
> that they must be discussed on the mailing
> list as the first step. 2. Add a link
On Wed, 2 Sep 2020 17:16:00 GMT, Kevin Rushforth wrote:
>> I wrote the following test:
>>
>> import static org.junit.Assert.assertTrue;
>> import static org.junit.Assert.fail;
>>
>> import java.util.concurrent.CountDownLatch;
>> import java.util.concurrent.TimeUnit;
>>
>> import
On Tue, 1 Sep 2020 11:42:30 GMT, Kevin Rushforth wrote:
>> I've written a simple draft for the automated test:
>>
>> PointLight light = new PointLight(Color.BLUE);
>> light.setTranslateZ(-50);
>> var box = new Box(100, 100, 1);
>> var root = new Group(light,
On Fri, 4 Sep 2020 14:34:40 GMT, Nir Lisker wrote:
>> If you run it with `--info` you will see something like this:
>>
>> test.javafx.scene.shape.PointLightAttenuationTest STANDARD_ERROR
>> Exception in Application constructor
>> Exception in thread "T
On Thu, 8 Oct 2020 22:08:16 GMT, Kevin Rushforth wrote:
>> In that case, it seems like a generally useful optimization (not just at
>> initialization) to send down `maxRange` as 0
>> whenever `ca`, `la`, and `qa` are all at their default values.
>
> Actually, my above comment is wrong. A
On Thu, 8 Oct 2020 22:21:06 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change range after clamping
>
> modules/javafx.graphics/src/main/native-prism-d3d
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new: ht
On Thu, 8 Oct 2020 22:20:17 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change range after clamping
>
> modules/javafx.graphics/src/main/native-prism-d3d
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fixed test
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new: https://git.openjdk.java.
Hi,
Spinner's editable property seems to have conflicting initial values.
isEditable() returns true on an uninitialized property, but initializing it
sets its default to false:
private BooleanProperty editable;
public final void setEditable(boolean value) {
I noticed now that the class docs specify that the default is false.
Should isEditable() be changed to return false on a null property?
On Fri, Oct 16, 2020 at 2:59 PM Nir Lisker wrote:
> Hi,
>
> Spinner's editable property seems to have conflicting initial values.
> isEditable()
> would be good to fix this, since it is a bug waiting to happen if that
> initialization were to ever change.
>
> -- Kevin
>
>
> On 10/16/2020 5:06 AM, Nir Lisker wrote:
> > I noticed now that the class docs specify that the default is false.
> > Should isEditable()
Added 2 `@defaultValue` and fixed the incorrect default for `editable`. Also
corrected a typo that doesn't show anyway
in the docs.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.java.net/jfx/pull/323/files
Webrev:
On Fri, 9 Oct 2020 18:11:14 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed test
>
> tests/performance/3DLighting/attenuation/Lightin
On Sun, 17 Nov 2019 04:15:34 GMT, Nir Lisker wrote:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
This pull request has now been integrated.
Changeset: aab26d93
Author: Nir Lisker
URL: https://git.openjdk.java.net/jfx/commit/aab26d93
Stats: 1223 lines in 33 fi
On Fri, 9 Oct 2020 12:34:08 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> tests/system/src/test/java/test/javafx/scene/lighting3D/
On Mon, 5 Oct 2020 19:22:41 GMT, Kevin Rushforth wrote:
>>> The listView test is passing for the bitSet and for the back-to-front
>>> approach. Can we imagine a context where the
>>> broken selectedItems impl would add wreckage to the latter?
>>
>> To answer my own question: yes. A failing
On Tue, 18 Aug 2020 23:47:07 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/PseudoClass.java line 83:
>>
>>> 82:
>>> 83: /**
>>> 84: * There is only one PseudoClass instance for a given pseudoClass.
>>
>> 1. Is having a public constructor for this
On Wed, 19 Aug 2020 00:12:01 GMT, Kevin Rushforth wrote:
> I think that two of the classes have implicit constructors that are there by
> accident. Once we get agreement, I'll file
> a follow-on bug for those, and those changes should be reverted.
I finished reviewing the rest of the classes
On Wed, 19 Aug 2020 00:12:01 GMT, Kevin Rushforth wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Marked few class constructor as deprecated as per review
>
> I think that two of the classes have implicit
On Tue, 18 Aug 2020 23:31:42 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TableFocusModel.java
>> line 51:
>>
>>> 50:
>>> 51: /**
>>> 52: * Causes the item at the given index to receive the focus.
>>
>> Please add a missing `)` for the
On Tue, 18 Aug 2020 23:41:23 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Preloader.java line
>> 121:
>>
>>> 120: public Preloader() {
>>> 121: }
>>> 122:
>>
>> Not sure that "default" means anything here. I don't see any configuration.
>
>
Hi Tobias,
I thought that ReactFX superseded EasyBind and InhiBeans. What is the
current relation between these?
In any case, while removing the final modifier could work (I didn't look
into it much), I suggest to take a broader approach. These libraries have
many features that I think are
On Mon, 17 Aug 2020 11:16:55 GMT, Bhawesh Choudhary
wrote:
> Added missing explicit no-arg constructors to classes in package
> javafx.scene, javafx.css and javafx.stage.
I've completed a partial review. I think that just mechanically adding a
constructor with the same doc everywhere is
not
On Fri, 28 Aug 2020 14:55:55 GMT, Bhawesh Choudhary
wrote:
> Deprecate the public constructor of javafx.css.Selector as it should not be
> public due to only being extended by
> classes in same package. Deprecate the public constructor of
> javafx.css.converter.ShapeConverter as its a
wrote:
>
> agree with better highlighting of the important changes/issues
> disagree with leaving out the not so important - that's in the eye of
> the reader, anyway - changes/issues: after all, the target readership
> are technicians, not suits :)
>
> -- Jeanette
>
> Zita
On Sat, 29 Aug 2020 14:35:58 GMT, Kevin Rushforth wrote:
>> Looks good. Please update the CSR to reflect the change in the docs Selector.
>
> This should not have been marked as ready by the Skara bot. Looks like there
> is a bug in the processing of the `/csr`
> since the CSR is not yet
On Fri, 28 Aug 2020 17:26:41 GMT, Bhawesh Choudhary
wrote:
>> Deprecate the public constructor of javafx.css.Selector as it should not be
>> public due to only being extended by
>> classes in same package. Deprecate the public constructor of
>> javafx.css.converter.ShapeConverter as its a
ell.
> I
> > don't think those should go in the github repo, but they can definitely
> go
> > on openjfx.io.
> >
> > Those "friendly" release notes will always be subjective, but I don't see
> > big problems with that. In case of doubt,
Hi Peter,
This is a development mailing list, not a help list. I suggest you ask
questions on a help site.
The reason you see this difference is that you're using an invalidation
listener which uses lazy evaluation, so in your second example it is not
updated because it is not used in the
On Wed, 26 Aug 2020 15:46:46 GMT, Bhawesh Choudhary
wrote:
>> Added missing explicit no-arg constructors to classes in package
>> javafx.scene, javafx.css and javafx.stage.
>
> Bhawesh Choudhary has updated the pull request incrementally with one
> additional commit since the last revision:
>
301 - 400 of 830 matches
Mail list logo
