Thanks for the review.
Patch has been applied to the master branch.
commit 27229d174d4dec2cbfcf05865d49ef48442c2ff3
Author: Gert Doering
Date: Mon Sep 26 10:11:58 2022 +0200
t_client: add per-instance arguments to fping
Signed-off-by: Gert Doering
Acked-by: Frank Lichtenheld
Acked-by: Gert Doering
Same change as to master, just taking differences in config-msgc.h
into account.
Your patch has been applied to the release/2.5 branch.
commit 8cbfd57e4ad423c807ca8ec69f88fbc0e2da5aec (release/2.5)
Author: Lev Stipakov
Date: Mon Sep 26 10:08:43 2022 +0300
msvc
Acked-by: Gert Doering
This is a useful feature, and after some polishing, I think this is
about as good as it will get now :-) - thanks.
I have not tested this at all, as I have no MSVC build environment and
it will not manifest on MinGW builds. From my understanding it looks
reasonable
In addition to global FPING_EXTRA_ARGS now also evaluate
FPING_ARGGS_.
This can be used, for example, for a test instance for "will ToS-tagged
packets be sent properly?" by setting FPING_ARGS_2="-O 0x10".
Signed-off-by: Gert Doering
---
tests/t_client.sh.in | 5 +++-
Hi,
On Mon, Sep 26, 2022 at 08:46:50AM +0200, Antonio Quartulli wrote:
> On 26/09/2022 08:39, Gert Doering wrote:
> > It might seem elegant, to do this with a fall-through switch/case, but
> > it turns out to be not very elegant due to the restrictions on local
> > variable
or granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany
Acked-by: Gert Doering
I'm not sure how "dev" can ever be an empty string here, but if it
can be one, we shouldn't crash :-) - subjected to t_client tests on
OpenIndiana 2019 that excercise --dev tun/tap and --dev tun3/tap3
Trying around a bit, I came up with "openvp
o-win: support for --persist-tun
Signed-off-by: Lev Stipakov
Acked-by: Frank Lichtenheld
Message-Id: <20220830104958.91-1-lstipa...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25136.html
Signed-off-by: Gert Doering
--
kin
- do not print any per-test output at all, just overall summary
V=1 - print single header line for each successful test
print full output for failing tests
V=99 - print full output, always, as before
default is V=1 now
Signed-off-by: Gert Doering
v2:
fix erroneous test on "-n&quo
-Id: <20220914170134.2659433-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25210.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lis
- do not print any per-test output at all, just overall summary
V=1 - print single header line for each successful test
print full output for failing tests
V=99 - print full output, always, as before
default is V=1 now
Signed-off-by: Gert Doering
v2:
fix erroneous test on "-n&quo
Hi,
On Mon, Sep 19, 2022 at 08:36:21AM +0200, Gert Doering wrote:
> > we don't get here at all, if we have no event object that is timing out.
>
> process_coarse_timers() is run once per second, and does not need
> additional timers to be called.
>
>
Hi,
On Mon, Sep 19, 2022 at 12:29:20AM +0200, Antonio Quartulli wrote:
> On 18/09/2022 12:37, Gert Doering wrote:
> > On Sun, Sep 18, 2022 at 01:10:30AM +0200, Antonio Quartulli wrote:
> >> From: Dmitry Zelenkovsky
> >>
> >> Disconnect clients after session-t
a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Openv
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Acked-by: Gert Doering
Adding my ACK to Heiko's, because the push_option_fmt() thing is sufficiently
different from v3 so I had a very close look.
Testing this is not very easy with the current test framework, as it needs
this patch on both ends to become effective.
This said, I've
l I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Openvpn-devel mailing l
people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doerin
Acked-by: Gert Doering
Thanks for spotting this and sending a patch.
Not sure why this was fixed for add_route*() in commit a11bea18b1c93
(and then made more pretty in 903e2cf5c1), but forgotten in delete_route*()
Tested with a basic t_client test with ipv4 + ipv6 routes.
Your patch has been
rt
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein
I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Open
Acked-by: Gert Doering
"That was an easy one", after the plugin/script auth related stuff :-)
Your patch has been applied to the master branch.
commit 7de4be94e297ab1ea87ab17934f2026d7124239c
Author: Lev Stipakov
Date: Sat Sep 17 19:34:25 2022 +0300
doc: add ovpn-dco to usa
Arne Schwabe
Acked-by: Heiko Hund
Message-Id: <20220824140848.88013-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25099.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
__
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-
ot;If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert
t; " tap-windows6 (default)\n"
... in here, that is :-)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with
- do not print any per-test output at all, just overall summary
V=1 - print single header line for each successful test
print full output for failing tests
V=99 - print full output, always, as before
default is V=1 now
Signed-off-by: Gert Doering
---
tests/t_client.sh.in | 89
Acked-by: Frank Lichtenheld
Message-Id: <20220915104028.188-1-lstipa...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25221.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvp
htenheld
Acked-by: Arne Schwabe
Message-Id: <20220628080814.745-1-fr...@lichtenheld.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24575.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
_
Patch has been applied to the master branch.
One whitespace error fixed (tab before end-of-line comment) that uncrustify
complained about on merge.
commit 6e3fc642b74180f0e8e7ef63c0d6ca4e0c5537f4
Author: Gert Doering
Date: Mon Aug 8 17:23:44 2022 +0200
cleanup open_tun() for
onviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany
ed in the preceding
paragraph -> so, yes, that's what it says there :-)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of h
ms that are not Windows, MacOS or Linux, --dev-node
will usually not do what you want, so forget about it right away" - wrapped
in a slightly longer text :-)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures
Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
as conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moo
Hi,
On Mon, Sep 12, 2022 at 02:09:52PM +0200, Gert Doering wrote:
> So, observation suggests "it's happening inside the DCO module". I'll
> go instrument my kernel with printf()'s now... and will report if I find
> anything useful.
ok... so at the beginning
Hi,
On Mon, Sep 12, 2022 at 02:27:57PM +0200, Gert Doering wrote:
> trying to load my newly-instrumented if_ovpn.ko, I kldunload'ed the
> existing one - without shutting down *all* OpenVPN instances first.
>
> *Boom*...
>
> Console attached.
Ah, nice, dmesg has all the
inside the DCO module". I'll
go instrument my kernel with printf()'s now... and will report if I find
anything useful.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out.
Acked-by: Gert Doering
Thanks. Tested on FreeBSD with and without DCO (the latter is more
for good measure, as the changes only influence the FreeBSD-iroute part).
Your patch has been applied to the master branch.
commit b5b132c1ba36e6d2ca261d15a9d70648890021f7
Author: Kristof Provost
Date
into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Descri
tches up on the documentation.
Signed-off-by: Gert Doering
---
doc/man-sections/vpn-network-options.rst | 38 +++-
1 file changed, 31 insertions(+), 7 deletions(-)
diff --git a/doc/man-sections/vpn-network-options.rst
b/doc/man-sections/vpn-network-options.rst
index 5b2f8470..559b24
Acked-by: Gert Doering
Thanks.
I've taken the liberty to improve language a bit, as suggested by Richard
on IRC.
Your patch has been applied to the master branch.
commit 7b42a0ebc968d178faa1083dd42a0c170d4dfe74
Author: Arne Schwabe
Date: Sun Sep 11 16:48:34 2022 +0200
U
Acked-by: Gert Doering
Looks reasonable, and my github instance was able to successfully build
those mingw builds
Your patch has been applied to the master branch.
commit 4c1419266e177b423c18fa3dead78e2ac7c4b51c
Author: Arne Schwabe
Date: Fri Aug 26 17:30:26 2022 +0200
Add OpenSSL 3.0
I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_
@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21603.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforg
ge.net/msg25158.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Acked-by: Gert Doering
"This seems to make sense" :-) (aka, do what the commit message says)
Tested on the Ubuntu/DCO client/server test bench.
Your patch has been applied to the master branch.
commit a179d788c77d537b3a302320ebc476ca412c4e44
Author: Antonio Quartulli
Date: Thu Au
ent-crresponse script options and plugin interface
Signed-off-by: Arne Schwabe
Acked-by: Heiko Hund
Message-Id: <20220824110930.73009-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25089.html
Signe
Acked-by: Gert Doering
I have no idea what that stuff does, but it's not related to "openvpn code"
(obviously), and getting rid of files that are only there - and need to
maintained - for build functionality we do not use sounds like a good
idea.
I have not tested anything, ju
v Stipakov
Acked-by: Antonio Quartulli
Message-Id: <20220909064126.482-1-lstipa...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25153.html
Signed-off-by: Gert Doering
--
kind regard
mmand help to match man page and implementation
Acked-by: Frank Lichtenheld
Signed-off-by: Arne Schwabe
Acked-by: Gert Doering
Message-Id: <20220908161435.327109-1-fr...@lichtenheld.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25151.
Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Thanks for the review. strcmp() fixed (space) as instructed.
I'll send a manpage patch next to (try to...) document the expected behaviour
across platforms.
Your patch has been applied to the master branch.
commit a5cf4cfb77f74588759d96258e7435e54db12b2c
Author: Gert Doering
Date: Mon A
llowing the "other platform convention", where everything
not having a digit was iterated ("--dev tun-home" -> "tun-home0") -
which does not work for classic tun/tap devices on the BSDs anyway,
so is not the best model.
Adjust open_tun_dco_generic() to document expe
Acked-by: Gert Doering
Your patch has been applied to the master branch.
commit 26d619277284f346f1d45c15bf0bbbdbda4a99f9
Author: Antonio Quartulli
Date: Fri Aug 26 10:41:11 2022 +0200
dco-win: update GH Actions config file
Signed-off-by: Lev Stipakov
Signed-off-by: Antonio
Thanks for the reviewes. Dunno why I thought that "we must have no
spaces around operators" :-) - so, fixed that whitespace plus 3 tabs
that escaped.
Patch has been applied to the master branch.
commit 104e4ef1e3d49cccb3bc677bab9c24158f91b97b
Author: Gert Doering
Date: Sat Aug 2
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25102.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/
Hi,
On Thu, Aug 25, 2022 at 10:36:21PM +0200, Gert Doering wrote:
> On Wed, Aug 24, 2022 at 06:57:18PM +0200, Arne Schwabe wrote:
> > Error: test_provider.c(74): error C2099: initializer is not a constant
> >
> > Fix this issue by making the const char* to const char[]. Th
ever doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Hi,
On Fri, Jul 22, 2022 at 05:09:08PM +0200, Gert Doering wrote:
> Acked-by: Gert Doering
>
> "makes sense" - in a buildbot (or any other CI) environment, do not
> silently skip missing prereqs, but fail hard.
>
> Tested with "make check" ;-) - wi
2141806.39406-1-fr...@lichtenheld.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25058.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.
f till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Openvpn-deve
Acked-by: Gert Doering
Not very much to review here, anyway :-)
Your patch has been applied to the master branch.
commit a8b00c908b4b8567dcfd792b7ab1d9005bcc587b
Author: Antonio Quartulli
Date: Sat Aug 13 22:42:21 2022 +0200
dco-win: add documentation to README.dco.md
Signed-off
Acked-by: Gert Doering
Thanks for the test reports. I had stared-at-code in v102, and the
changes 102->105 are still fine with me.
I have subjected this to build tests on github (fine), and had my test
machinery chew on the linux and freebsd DCO and non-DCO builds very
thoroughly, as t
ing more complications.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. He
anted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany
Hi,
On Tue, Aug 02, 2022 at 02:02:39PM +0200, Gert Doering wrote:
> Your patch has been applied to the master branch.
>
> commit 4dfd592ff1ee18aa4859264c8a341dfa1a291988
... and after some reminding, to release/2.5 as well.
commit 468f53ae3bfcfca6563acbf648e7a0bc6f94b038 (HEAD ->
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Hars
Acked-by: Gert Doering
Same thing, "looks reasonable and all green on my github repo" :-)
Your patch has been applied to the master branch.
commit c0724527190d864b20fb3f5725ebdcadd8900697
Author: Arne Schwabe
Date: Mon Aug 22 20:41:47 2022 +0200
Include libressl and macOS 1
Acked-by: Gert Doering
Looks reasonable, and more test are always good. Tested by pushing to
my GH repo, and it builds all green today (no good starting with
"already broken" when nobody has much interest in working on it)
Your patch has been applied to the master branc
Fillinger
Acked-by: Arne Schwabe
Message-Id: <20220811120722.29168-2-maximilian.fillin...@foxcrypto.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24873.html
Signed-off-by: Gert Doering
--
kind regards,
Gert D
Signed-off-by: Max Fillinger
Acked-by: Arne Schwabe
Message-Id: <20220822154037.44320-1-maximilian.fillin...@foxcrypto.com>
URL:
https://www.mail-archive.com/search?l=mid&q=20220822154037.44320-1-maximilian.fillin...@foxcrypto.com
Signed-off-by: Gert Doering
Signed-off-by: Max Fillinger
Acked-by: Arne Schwabe
Message-Id: <20220822154037.44320-1-maximilian.fillin...@foxcrypto.com>
URL:
https://www.mail-archive.com/search?l=mid&q=20220822154037.44320-1-maximilian.fillin...@foxcrypto.com
Signed-off-by: Gert Doering
/* 3
> bytes */).
>
> Can you try this?
Looks good, might work :-).
Will give this a try as soon as time permits - next 2-3 weeks might not
work out.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest
HI,
On Sat, Aug 20, 2022 at 11:02:46PM +0200, Gert Doering wrote:
> I did lots of testing on FreeBSD today, and it turns out that the
> generic "undo" code is just a mess and clutters the log with garbage...
>
> 2022-08-20 22:58:02 /sbin/ifconfig tun4 0.0.0.0
> ifc
Hi,
On Fri, Aug 19, 2022 at 07:04:52PM +0200, Gert Doering wrote:
> The change is as we have discussed, and I still think it's a good and
> clean way forward. The "undo_ifconfig_ipv4() / _ipv6()" functions
> are as they have been before (except that they now get comp
took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, German
Acked-by: Gert Doering
As usually, I have no idea what this stuff does, but it's not changing
code and it seems to make Github happy :-)
Your patch has been applied to the master branch.
commit 734de8f9aa2df56bcb45ebab7cfa799a23f36403
Author: Lev Stipakov
Date: Sat Aug 20 14:27:55 2022
Hi,
so, as promised, more details on the route/iroute issues I saw... with
a new Subject: line, to keep the threads halfway orderly.
On Sat, Aug 20, 2022 at 04:01:02PM +0200, Gert Doering wrote:
> - route *deletion* does not work for IPv4 host routes, because of
>"other cod
the extra MR_WITH_NETBITS logic from dco.c, where it should
have never appeared.
Signed-off-by: Gert Doering
---
src/openvpn/dco.c | 16 ++--
src/openvpn/multi.c | 2 ++
src/openvpn/options.c | 6 --
3 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/sr
Acked-by: Gert Doering
Stared-at-code, tested on FreeBSD 14 with and without DCO as client,
and with DCO as server, with a number of interesting iroute problems
(--route /24, --iroute /32, --route /24 and --iroute same /24, no
--route at all, but --iroute /24). See below.
The "big p
Hi,
On Sat, Aug 20, 2022 at 11:29:55AM +0200, Gert Doering wrote:
> Acked-by: Gert Doering
>
> I have *not* tested this, but we've discussed the patch on IRC, and the
> code matches what we want to achieve. We've had GetProcAddress() dynamic
> resolution in the cod
Acked-by: Gert Doering
I have *not* tested this, but we've discussed the patch on IRC, and the
code matches what we want to achieve. We've had GetProcAddress() dynamic
resolution in the code before (some IPv6 vs XP/Vista stuff, IIRC) and
this all looks reasonable. GHA claims it com
18:59 fbsd14 tun-udp-p2mp[79256]: GLOBAL_STATS,dco_enabled,1
Aug 20 11:18:59 fbsd14 tun-udp-p2mp-topology-subnet[79278]:
GLOBAL_STATS,dco_enabled,1
Patch has been applied to the master branch.
commit efebdfe2de8dd5125fb42d646d03a958b7dc3eea
Author: Gert Doering
Date: Fri Aug 19 20:24:39 2022
gnalling), which happens
to be "-EPERM" on FreeBSD.
Change create_interface() to return -errno.
While at it, remove logging of errors from dco_freebsd.c::open_tun_dco()
(because all errors from create_interface() would be already logged there),
reducing open_tun_dco() to just a wrappe
Hi,
On Fri, Aug 19, 2022 at 07:04:42PM +0200, Gert Doering wrote:
> I had to apply a bit of pressure to get the patch to apply - it had
> one hunk trying to fix an #endif which never existed :-) - and the context
> of the last tun.c hunk needed adjustment (if (tun_dco_enabled(tt)))
honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany
Antonio Quartulli
Message-Id: <20220629170555.116087-1-maximilian.fillin...@foxcrypto.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24610.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
_
Acked-by: Gert Doering
I had to apply a bit of pressure to get the patch to apply - the
context in tun.c got changed ( || TARGET_FREEBSD) in the meantime...
fairly trivial, and no actual code change.
Pushed to the new and renovated buildbot army, to see if it would break
any platforms (very
-0400
Fix auth-token usage with management-def-auth
Signed-off-by: Selva Nair
Acked-by: Arne Schwabe
Message-Id: <20220704025840.2558-1-selva.n...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24627.html
Signed-off-b
Hi,
this looks good to me - will apply as soon as 3/7 goes in (to avoid
having documentation that says "it's in" while it isn't).
Acked-By: Gert Doering
On Sat, Aug 13, 2022 at 10:42:21PM +0200, Antonio Quartulli wrote:
> Signed-off-by: Arne Schwabe
> Signed-off-by:
CEDIR neccesary anymore, since ovpn_dco_win.h
is now part of our tree", right?
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a se
puter, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description:
_win(),
and then this would collaps to a much more compact
> +#if defined(_WIN32)
> +if (dco_enabled(&c->options))
> +{
> +create_socket_dco_win(c, sock, &sig_info->signal_received);
> +goto done;
> +}
> +el
Acked-by: Gert Doering
"This one is better" :-)
Test built via GHA for MSVC, tested on Linux non-DCO / DCO client and
DCO server. This time, neither "non DCO" nor "DCO build" exhibited
any surprises (as expected).
Not tested actual Windows build, but the checks
If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert
Signed-off-by: Arne Schwabe
Signed-off-by: Lev Stipakov
Signed-off-by: Antonio Quartulli
Acked-by: Lev Stipakov
Message-Id: <20220813204224.22576-...@unstable.cc>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24919.html
Signed-off-
to the end of check_option_conflict() function
Signed-off-by: Antonio Quartulli
Acked-by: Frank Lichtenheld
Message-Id: <20220802130312.18871-...@unstable.cc>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24783.html
Signed-off-by: Gert
901 - 1000 of 5743 matches
Mail list logo
