Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

2010-11-13 Thread Alon Bar-Lev
Hello, This again, raises the modulation of openvpn project. *NOBODY* wants/needs to modify the driver, most people lacks the skills and interest. Usually people wants to patch openvpn userspace components. The driver should come in its own .msi signed (msi + driver). OpenVPN installation

Re: [Openvpn-devel] OpenVPN 2.2-RC released

2011-03-04 Thread Alon Bar-Lev
Hello, Any reason why the windows cross compile fix we discussed [1] did not made it into mainline? Attached again. This is trivial patch, which resume the ability to build openvpn using cross compiler and autotools. Please apply so we don't need to maintain this out of tree. You can test

Re: [Openvpn-devel] OpenVPN 2.2-RC released

2011-03-04 Thread Alon Bar-Lev
GP SIGNED MESSAGE- > Hash: SHA1 > > On 04/03/11 22:14, Alon Bar-Lev wrote: >> Hello, >> >> Any reason why the windows cross compile fix we discussed [1] did not >> made it into mainline? >> >> This is trivial patch, which resume the ability to build openv

Re: [Openvpn-devel] OpenVPN 2.2-RC released

2011-03-05 Thread Alon Bar-Lev
On Sat, Mar 5, 2011 at 2:02 AM, Mr Dash Four wrote: > Speaking of which, I also proposed a (rather trivial) patch which enables > cross compilation of a number of OpenVPN plugins (that patch is attached > again) as in the 2.1.4 version that was not possible. I think

Re: [Openvpn-devel] [PATCH] Bind only to specified interface

2011-03-08 Thread Alon Bar-Lev
Hello, I don't understand why it is needed. You can always start openvpn and override configuration via command-line. So add --local "$(/sbin/ip addr show dev wlan0 | grep inet | sed 's#.*inet \(.*\)/.*#\1#')" parameter while starting it. A more generic approach can be adding $() support into

Re: [Openvpn-devel] OpenVPN 2.2-RC released

2011-03-09 Thread Alon Bar-Lev
Can you please send the patch again? On Wed, Mar 9, 2011 at 4:39 PM, Markus Koetter wrote: > > Hi, > > On 03/04/2011 08:26 PM, Samuli Seppänen wrote: > >      * Make the --x509-username-field feature an opt-in feature > > given the x509 username field is

Re: [Openvpn-devel] First OpenVPN 2.2-RC2 preview available

2011-03-18 Thread Alon Bar-Lev
Any reason why I cannot find git or svn repository for openvpn in the openvpn site? Maybe it is hidden or misplaced. 2011/3/18 Samuli Seppänen : > Hi all, > > First working _preview_ of 2.2-RC2 is now available. I've verified that > this installer works on Windows XP (32-bit)

Re: [Openvpn-devel] First OpenVPN 2.2-RC2 preview available

2011-03-19 Thread Alon Bar-Lev
Hello, GIT/SVN repository is expected to be published clearly in opened source projects, just like you have Download option in menu, there should be Source or similar. If your git is the one that is candidate for next release, publish it, better something than nothing. Also, please install

Re: [Openvpn-devel] [PATCH] Fixes to Makefile.am

2011-03-23 Thread Alon Bar-Lev
I think management/management-notes.txt should be in dist_doc_DATA so it actually get installed. 2011/3/23 Samuli Seppänen > > Removed reference to config-win32.h, which has been removed. Added > management-notes.txt to dist rules. > > Signed-off-by: Samuli Seppänen

Re: [Openvpn-devel] [PATCH] Change the default --tmp-dir path to a more suitable path

2011-04-07 Thread Alon Bar-Lev
On Wed, Apr 6, 2011 at 7:10 PM, David Sommerseth wrote: > In commit 4e1cc5f6dda22e9 the create_temp_filename() function was > reviewed and hardened, which in the end renamed this function to > create_temp_file() in commit 495e3cec5d156. > > With these changes it became more

Re: [Openvpn-devel] [PATCH 2/2] Use %SystemRoot% instead of hard-codedC:\WINDOWS for temp directory path

2011-04-08 Thread Alon Bar-Lev
On Fri, Apr 8, 2011 at 7:03 PM, Gisle Vanem wrote: > Why not a bit simpler; GetTempPath() (kernel32.dll) already does these tests. > Ref: http://msdn.microsoft.com/en-us/library/aa364992(v=vs.85).aspx : Good catch. Alon.

Re: [Openvpn-devel] I made a patch that prevents POSIX capabilities from disappearing during UID downgrade.

2011-04-11 Thread Alon Bar-Lev
Usually, using cap should be enabled/disabled via autoconf. On Mon, Apr 11, 2011 at 11:23 PM, crocket wrote: > > diff -Naur a/init.c b/init.c > --- a/init.c    2010-11-05 04:29:02.0 +0900 > +++ b/init.c    2011-04-12 05:11:43.540370471 +0900 > @@ -41,6 +41,10 @@

Re: [Openvpn-devel] I made a patch that prevents POSIX capabilities from disappearing during UID downgrade.

2011-04-11 Thread Alon Bar-Lev
quot; = "yes" && AC_DEFINE([ENABLE_CAPABILITIES], [1], [enable Linux capabilities]) --- Then in source you test for: #ifdef ENABLE_CAPABILITIES Alon. On Tue, Apr 12, 2011 at 12:03 AM, crocket <crockabisc...@gmail.com> wrote: > How do I enable it via autoconf? > > On Tue, Apr 12,

Re: [Openvpn-devel] route-up and iproute plugins

2011-04-16 Thread Alon Bar-Lev
I don't understand the "more secure" argument. But you can write less secured suid iproute2 ip utility replacement which can do whatever you like if the sudo is your problem. On Sat, Apr 16, 2011 at 1:57 AM, Mr Dash Four wrote: > > Is there a plugin allowing me to

Re: [Openvpn-devel] [PATCH] Make '--comp-lzo no' the default behaviour if LZO is enabled

2011-05-16 Thread Alon Bar-Lev
If you have a problem in what can or cannot be pushed to client, why not do this generic? Something like: --- push-allowed="comp-lzo ..." push-disallow="comp-lzo ..." --- On Mon, May 16, 2011 at 2:10 PM, David Sommerseth wrote: > > This makes 'comp-lzo' pushable without

Re: [Openvpn-devel] Builing OpenVPN for Windows

2011-07-02 Thread Alon Bar-Lev
Please ask these stuff on the list. 1. You should use i686-w64-mingw32 for 32bit. 2. NSI build is not supported for cross compile, there openvpn developers prefer to use their own build system in order to produce the installer. 3. As openvpn is not modular, you must compile your self the tap

Re: [Openvpn-devel] OpenVPN with PKCS11 support

2011-07-13 Thread Alon Bar-Lev
Just today we discussed this. Look at [1][2] [1] https://www.opensc-project.org/build [2] http://www.opensc-project.org/downloads/users/alonbl/build/ On Thu, Jul 14, 2011 at 12:27 AM, Thomas wrote: > Hi list, > > I'm looking for a newer version of OpenVPN (like 2.2.1) with

Re: [Openvpn-devel] [PATCH 2/2] don't use struct in6_addr s6_addr32 member anymore

2011-08-10 Thread Alon Bar-Lev
Hello, I think this should be done by autoconf. And hand added into win32 for MSVC. Alon. On Wed, Aug 10, 2011 at 3:55 PM, Heiko Hund wrote: > The s6_addr32 member of struct in6_addr is not available when building > for WIN32. To work around this, a local union is defined

[Openvpn-devel] pkcs11-helper-1.09 released

2011-08-16 Thread Alon Bar-Lev
Hello, pkcs11-helper-1.09 is available. Fixed issue introduced in 1.08 related to OpenSSL engine signature. ChangeLog 2011-08-16 - Version 1.09 * Do not retry if CKR_BUFFER_TOO_SMALL and none NULL target. * Fixup OpenSSL engine's rsa_priv_enc to use RSA size output buffer.

Re: [Openvpn-devel] [PATCH 1/3] add MinGW WinHTTP compatibility layer

2011-08-17 Thread Alon Bar-Lev
These macros are s ugly! why not do this simply like other examples in OpenVPN code, if I recall correctly in CryptoAPI module. On Wed, Aug 17, 2011 at 4:42 PM, Heiko Hund wrote: > MinGW is missing support for winhttp.dll which will be used for automatic > proxy

Re: [Openvpn-devel] [PATCH 0/3] better --auto-proxy support for Windows

2011-08-17 Thread Alon Bar-Lev
Won't it make it harder to configure openvpn as service? On Wed, Aug 17, 2011 at 4:42 PM, Heiko Hund wrote: > Hi, > > the auto-proxy support for Windows was rather sub-optimal. Since Internet > Explorer 5 proxy settings were configured with the network or VPN connection, >

Re: [Openvpn-devel] [PATCH 0/3] better --auto-proxy support for Windows

2011-08-17 Thread Alon Bar-Lev
, Aug 17, 2011 at 5:02 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Wednesday 17 August 2011 15:59:10 Alon Bar-Lev wrote: >> Won't it make it harder to configure openvpn as service? > > I don't see how. Please elaborate. > > Heiko > -- > Heiko Hund | Software E

Re: [Openvpn-devel] [PATCH] add --mark option to set SO_MARK sockopt

2011-08-31 Thread Alon Bar-Lev
Maybe should extend the usage of parameter "socket-flags"? On Wed, Aug 31, 2011 at 9:05 PM, Heiko Hund wrote: > Signed-off-by: Heiko Hund > --- >  init.c    |    1 + >  openvpn.8 |    6 ++ >  options.c |   14 ++ >  options.h |    3

Re: [Openvpn-devel] [PATCH] add --mark option to set SO_MARK sockopt

2011-08-31 Thread Alon Bar-Lev
-- > Hash: SHA1 > > On 31/08/11 20:27, Alon Bar-Lev wrote: >> Maybe should extend the usage of parameter "socket-flags"? > > I considered that too, but that would require a bigger rewrite of the > - --socket-flags parser.  Currently it only is doing "boolean fl

Re: [Openvpn-devel] [PATCH] UTF-8 X.509 distinguished names

2011-11-23 Thread Alon Bar-Lev
As this is inserted into environment, what happens if locale is not unicode enabled? I think this may break some configurations. On Wed, Nov 23, 2011 at 4:14 PM, Heiko Hund wrote: > The UTF-8 support that came with commit 2627335 does allow international > usernames and

Re: [Openvpn-devel] [PATCH] Windows UTF-8 input/output

2011-11-23 Thread Alon Bar-Lev
OpenVPN output is not always a console. I am not sure this patch is valid. On Wed, Nov 23, 2011 at 4:15 PM, Heiko Hund wrote: > This patch makes openvpn read unicode from the console and convert the input > to UTF-8. And then display UTF-8 output to the console correctly.

Re: [Openvpn-devel] [PATCH] Windows UTF-8 input/output

2011-11-23 Thread Alon Bar-Lev
On Wed, Nov 23, 2011 at 5:02 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Wednesday 23 November 2011 14:55:57 Alon Bar-Lev wrote: >> OpenVPN output is not always a console. > > What output are you concerned about? Log file is fine, as much as management > interf

Re: [Openvpn-devel] [PATCH] UTF-8 X.509 distinguished names

2011-11-23 Thread Alon Bar-Lev
On Wed, Nov 23, 2011 at 5:14 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Wednesday 23 November 2011 14:53:06 Alon Bar-Lev wrote: >> As this is inserted into environment, what happens if locale is not >> unicode enabled? > > Then the script will receive funn

Re: [Openvpn-devel] Topics for today's meeting

2011-11-24 Thread Alon Bar-Lev
Hello, I won't participate in sync meeting don't have the time. Anyway, for windows build. I already provide binaries for OpenVPN using mingw-w64 project, and it works fine! I use mingw-w64 for both win32 and win64 binaries, much better than old mingw project, as mingw-w64 is maintained! You

Re: [Openvpn-devel] Topics for today's meeting

2011-11-24 Thread Alon Bar-Lev
Correction! cygwin provides mingw-w64 now!!! Also recent autoconf/automake/libtool. So we can also cross compile using mingw. 2011/11/24 Alon Bar-Lev <alon.bar...@gmail.com>: > Hello, > > I won't participate in sync meeting don't have the time. > Anyway, for windows build. &

Re: [Openvpn-devel] Topics for today's meeting

2011-11-24 Thread Alon Bar-Lev
I hate CMake, it is way too complex, these guys re-invented the wheel with no decent reuse of any methodology / language that existed before. If we take SCons as another example, it took python and used it to do build... So if you are python developer most probably you know how to SCons. Also,

Re: [Openvpn-devel] Topics for today's meeting

2011-11-24 Thread Alon Bar-Lev
will build with dependencies now, it will take some time. 2011/11/24 Alon Bar-Lev <alon.bar...@gmail.com>: > Correction! > cygwin provides mingw-w64 now!!! > Also recent autoconf/automake/libtool. > So we can also cross compile using mingw. > > 2011/11/24 Alon Bar-Le

Re: [Openvpn-devel] [PATCH] UTF-8 X.509 distinguished names

2011-11-24 Thread Alon Bar-Lev
On Thu, Nov 24, 2011 at 1:42 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Wednesday 23 November 2011 17:48:54 Alon Bar-Lev wrote: >> Yes, there are many none unicode environments, and I am not sure what >> this patch will behave in windows environment as it is SCS-2 not

Re: [Openvpn-devel] Topics for today's meeting

2011-11-24 Thread Alon Bar-Lev
My build script is working as-is with cygwin, compiling native win32 binaries! 2011/11/24 Alon Bar-Lev <alon.bar...@gmail.com>: > I am *VERY* impressed from cygwin jump, I must admit I have not kept > track on this project for a long time! > But now it is up to date with fully ope

Re: [Openvpn-devel] [PATCH v2] Provide an access() wrapper for Windows

2011-12-02 Thread Alon Bar-Lev
Why not: #ifdef WIN32 #define access _access #endif On Fri, Dec 2, 2011 at 2:17 PM, David Sommerseth wrote: > Commit 0f2bc0dd92f43c91e33bba8a66b06b98f281efc1 adds extra file and > directory checks at startup. However, this patch makes use of some > features not directly

Re: [Openvpn-devel] [PATCH] Windows does not have dirname() - reimplement a portable version

2011-12-02 Thread Alon Bar-Lev
I think the whole code should be more autoconf depended. Autoconf can detect if POSIX version is available and if not, code can provide alternative. No need for the openvpn_ functions and wrappers. On Fri, Dec 2, 2011 at 1:02 PM, David Sommerseth wrote: > > Commit

Re: [Openvpn-devel] [PATCH] Windows does not have dirname() - reimplement a portable version

2011-12-02 Thread Alon Bar-Lev
On Fri, Dec 2, 2011 at 2:38 PM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/12/11 13:28, Alon Bar-Lev wrote: >> I think the whole code should be more autoconf depended. Autoconf can >> detect

Re: [Openvpn-devel] [PATCH v2] Provide an access() wrapper for Windows

2011-12-02 Thread Alon Bar-Lev
At every file: #ifdef HAVE_CONFIG_H #include #elif defined(_MSC_VER) #include #endif On Fri, Dec 2, 2011 at 2:54 PM, Gisle Vanem <gva...@broadpark.no> wrote: > > "Alon Bar-Lev" <alon.bar...@gmail.com> wrote: > > > Why not: > > #ifdef WIN32 > > #def

Re: [Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

2011-12-08 Thread Alon Bar-Lev
On Thu, Dec 8, 2011 at 1:46 AM, David Sommerseth wrote: > > This kicks out the openvpn_basename() function from misc.[ch] andputs > it into compat.[ch].  This is to provide the same functionality on > platforms not having a native basename() function available. > > In addition

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

2011-12-08 Thread Alon Bar-Lev
On Thu, Dec 8, 2011 at 2:13 AM, David Sommerseth wrote: > +/* The POSIX access() function is called via _access() on Windows, > + * defined in io.h > + */ > +#define HAVE_ACCESS 1 > +#define access _access > +#pragma warning(disable : 4996) /* Avoid Visual Studio to complain

Re: [Openvpn-devel] [PATCH] Add option to disable priority tagged packets (VID=0)

2011-12-08 Thread Alon Bar-Lev
Missing usage, man. On Thu, Dec 8, 2011 at 12:15 PM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Adding Fabian to Cc, he knows more about the VLAN code. > > With this feedback, I'm willing merge in the feat_vlan_tagging branch >

Re: [Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

2011-12-08 Thread Alon Bar-Lev
On Thu, Dec 8, 2011 at 12:27 PM, David Sommerseth wrote: > Hi Alon, > > I'm not sure I understand the critique too well now.  As this is the > approach I tried to do.  However, I put the basename() and dirname() > implementations in compat.h, calling the combined

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

2011-12-08 Thread Alon Bar-Lev
On Thu, Dec 8, 2011 at 12:44 PM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/12/11 08:44, Alon Bar-Lev wrote: >> On Thu, Dec 8, 2011 at 2:13 AM, David Sommerseth <dav...@redhat.com> >

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

2011-12-08 Thread Alon Bar-Lev
On Thu, Dec 8, 2011 at 12:51 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > On Thu, Dec 8, 2011 at 12:44 PM, David Sommerseth > <openvpn.l...@topphemmelig.net> wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 08/12/11 08:44, Alon Bar-

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

2011-12-08 Thread Alon Bar-Lev
On Thu, Dec 8, 2011 at 12:57 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > On Thu, Dec 8, 2011 at 12:51 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: >> On Thu, Dec 8, 2011 at 12:44 PM, David Sommerseth >> <openvpn.l...@topphemmelig.net> wrote: >>> -

Re: [Openvpn-devel] [PATCH] handle Windows unicode paths

2011-12-08 Thread Alon Bar-Lev
On Thu, Dec 8, 2011 at 1:06 PM, Heiko Hund wrote: > On Wednesday 07 December 2011 17:58:51 Heiko Hund wrote: >> This patch makes openvpn read the command line in UCS-2 and convert >> it to UTF-8 internally. Windows stores names in the filesystem in UCS-2. >> When using a

Re: [Openvpn-devel] [PATCH] Add option to disable priority tagged packets (VID=0)

2011-12-08 Thread Alon Bar-Lev
On Thu, Dec 8, 2011 at 7:02 PM, Fabian Knittel <fabian.knit...@avona.com> wrote: > Am 08.12.2011 11:27, schrieb Alon Bar-Lev: >> Missing usage, man. > > There are probably not *that* many users, agreed.  It's probably more of > a "large enterprise" feature, as onl

Re: [Openvpn-devel] [PATCH v3] Move away from openvpn_basename() over to platform provided basename()

2011-12-09 Thread Alon Bar-Lev
On Fri, Dec 9, 2011 at 5:26 PM, David Sommerseth wrote: >> These changes, just to take into account some system somewhere that >> has a basename() implementation that modifies the argument string, are >> ugly, and prone to memleak-errors.  Also, some other

Re: [Openvpn-devel] [PATCH] autotools ./configure don't like compat.h

2012-01-11 Thread Alon Bar-Lev
The syshead.h is totally invalid and should be revised long time ago. Most of the tests within the syshead.h should be done using autoconf and inject into config.h. This way, there is a single point of platform specific tests. On Wed, Jan 11, 2012 at 9:17 PM, David Sommerseth

Re: [Openvpn-devel] [PATCH] Signed-off-by: Jan Just Keijser <janj...@nikhef.nl>

2012-02-07 Thread Alon Bar-Lev
This is nice! Some questions: 1. Why not enable this automatically if openssl is sufficient version? There is no point in not using this if available. 2. I would have liked to see this in negotiation as well, so server will use EC if supported by the client and fallback if not... This way

Re: [Openvpn-devel] [PATCH 2/4] do not use mode_t on Windows

2012-02-16 Thread Alon Bar-Lev
I stopped following all OpenVPN changes. It seems like more changes are entered than should without proper review. Anyway, this is not the correct solution. Correct solution is to have config-msvc.h and have: --- #define mode_t int --- And in autoconf (if mingw does not have this as well):

Re: [Openvpn-devel] [PATCH 4/4] make MSVC link against shell32 as well

2012-02-16 Thread Alon Bar-Lev
On Thu, Feb 16, 2012 at 7:30 PM, Heiko Hund wrote: > Windows API CommandLineToArgvW(), introduced in Windows unicode path > commit 71bbbd76c62630c88441237d72fe5b61f0b45b2a, is defined therein. Usually this should be avoided and get command-line from wmain().

Re: [Openvpn-devel] [PATCH v2] use the underscore version of stat on Windows

2012-02-16 Thread Alon Bar-Lev
Again, All conditional statements should be within single config.h or config-msvc.h or sysheader.h or anything. Doing conditional inline makes code complex and unmaintainable. But as you adds lng patches without proper review I guess it is not that important. Alon. On Thu, Feb 16, 2012 at

Re: [Openvpn-devel] [PATCH 4/4] make MSVC link against shell32 as well

2012-02-17 Thread Alon Bar-Lev
On Fri, Feb 17, 2012 at 11:51 AM, Heiko Hund <heiko.h...@sophos.com> wrote: > Alon, > > On Thursday 16 February 2012 18:37:21 Alon Bar-Lev wrote: >> On Thu, Feb 16, 2012 at 7:30 PM, Heiko Hund <heiko.h...@sophos.com> wrote: >> > Windows API CommandLineToArgvW()

Re: [Openvpn-devel] [PATCH 2/4] do not use mode_t on Windows

2012-02-17 Thread Alon Bar-Lev
On Fri, Feb 17, 2012 at 11:39 AM, Heiko Hund <heiko.h...@sophos.com> wrote: > Alon, > > On Thursday 16 February 2012 18:34:34 Alon Bar-Lev wrote: >> Anyway, this is not the correct solution. >> Correct solution is to have config-msvc.h and have: >> --- >&g

Re: [Openvpn-devel] [PATCH] Makefile.am referenced a now non-existing config-win32.h

2012-02-17 Thread Alon Bar-Lev
When did this file gone? Anyway, this was required with compiling using MSVC... On Fri, Feb 17, 2012 at 1:13 PM, David Sommerseth wrote: > This file was moved to win/config.h.in and is the template used > by the Python build tools in win/.  This happened in > commit

[Openvpn-devel] [DEVELOPER REQUESTED] Repackage TAP-Win32

2012-02-18 Thread Alon Bar-Lev
Hello, We have a go to rewrite the OpenvPN build system. I started to work at core product [1]. As part of the re-write we split out the TAP-Win32 out of OpenVPN code base. To make things go faster we may try to parallelize the effort. Here are the tasks to perform: 1. Create a GIT repository

Re: [Openvpn-devel] [DEVELOPER REQUESTED] Repackage TAP-Win32

2012-02-20 Thread Alon Bar-Lev
2012/2/20 Samuli Seppänen > > Here are the tasks to perform: > > 1. Create a GIT repository of the master TAP-Win32 sources with all > > history, to ease our work, please use github. > Any thoughts of this anyone? Personally, I don't care where the source > code lives. It

[Openvpn-devel] [CRASH] on master /packet_id.c::packet_id_debug_print

2012-02-20 Thread Alon Bar-Lev
Hi, Master with verb 255 I get the following after a few packets... Can someone else try out to see if it reproduced? tls-client tls-cipher DHE-RSA-AES256-SHA cipher AES-256-CBC Server DH 4096bit Server certificate 2048bit Client certificate 2048bit Mon Feb 20 14:53:58 2012 us=139424

Re: [Openvpn-devel] [PATCH] define access mode flag X_OK as 0 on Windows

2012-02-20 Thread Alon Bar-Lev
Big NAK. This X_OK is standard define. It exists in mingw as 1. OpenVPN should not check execute if unsupported by OS, not changing standard constants. Heiko, Where exactly is the problem? When directories are checked or script? Correct patch would be to have a macro for execute ok in option.c

Re: [Openvpn-devel] [PATCH] define access mode flag X_OK as 0 on Windows

2012-02-20 Thread Alon Bar-Lev
On Mon, Feb 20, 2012 at 4:22 PM, Heiko Hund wrote: > Defining them makes code more readable, but without X_OK being 0 on Windows > openvpn crashes. See my commit message again and read the MSDN page about > _access at

[Openvpn-devel] [PATCH] windows: do not use X_OK as it is unsupported

2012-02-20 Thread Alon Bar-Lev
Reported by Heiko Hund. Reference [1]. Replaces 4ebc587eab73e03ef64d344a5707d84e7f8d875a [1] http://msdn.microsoft.com/en-us/library/1w06ktdy%28v=vs.100%29.aspx Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- options.c | 38 ++---

Re: [Openvpn-devel] [PATCH] windows: do not use X_OK as it is unsupported

2012-02-20 Thread Alon Bar-Lev
; Hash: SHA1 > > On 20/02/12 15:45, Alon Bar-Lev wrote: >> Reported by Heiko Hund. Reference [1]. >> >> Replaces 4ebc587eab73e03ef64d344a5707d84e7f8d875a >> >> [1] >> http://msdn.microsoft.com/en-us/library/1w06ktdy%28v=vs.100%29.aspx >> >>

Re: [Openvpn-devel] [PATCH] windows: do not use X_OK as it is unsupported

2012-02-20 Thread Alon Bar-Lev
Another option is to use X_OK and declare a macro PLATFORM_MASK_MODE(m)... whatever you think more readable. On Mon, Feb 20, 2012 at 9:35 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > David, > > Again, > This has nothing to do with POSIX. > mingw *DOES* define this

Re: [Openvpn-devel] [PATCH] windows: do not use X_OK as it is unsupported

2012-02-20 Thread Alon Bar-Lev
On Tue, Feb 21, 2012 at 12:39 AM, David Sommerseth wrote: > But remember that all your patches *will* go through review as for > everyone else in the community.  That means either *1)* patch reviews on > the mailing list, or *2)* reviewed through a sprint review in

Re: [Openvpn-devel] [PATCH] windows: do not use X_OK as it is unsupported

2012-02-20 Thread Alon Bar-Lev
be productive. Alon. On Tue, Feb 21, 2012 at 1:02 AM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 20/02/12 23:47, Alon Bar-Lev wrote: >> Please start go over my patches in github[1] and mark your comme

[Openvpn-devel] [PATCH 01/35] cleanup: options.c: remove redundant include

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- options.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/options.c b/options.c index a596ffe..3d8085c 100644 --- a/options.c +++ b/options.c @@ -50,7 +50,6 @@ #include "manage.h" #include "

[Openvpn-devel] [PATCH 00/35] build revolution

2012-02-21 Thread Alon Bar-Lev
. Alon. [1] https://github.com/alonbl/openvpn/ [2] https://github.com/alonbl/openvpn-build [3] https://github.com/alonbl/openvpn/downloads Alon Bar-Lev (35): cleanup: options.c: remove redundant include cleanup: crypto_openssl.c: remove support for pre-openssl-0.9.6 cleanup: tun.c: fix

[Openvpn-devel] [PATCH 02/35] cleanup: crypto_openssl.c: remove support for pre-openssl-0.9.6

2012-02-21 Thread Alon Bar-Lev
autoconf rejecting this anyway: --- AC_MSG_CHECKING([that OpenSSL Library is at least version 0.9.6]) AC_MSG_ERROR([OpenSSL crypto Library is too old.]) --- Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- crypto_openssl.c | 49 - 1

[Openvpn-devel] [PATCH 05/35] build: correct place to alter WINVER is at build system

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac|2 +- syshead.h |4 win/msvc.mak.in |2 +- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 1c4d66c..aa1d509 100644 --- a/configure.ac

[Openvpn-devel] [PATCH 03/35] cleanup: tun.c: fix incorrect option in message (ip-win32)

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- tun.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tun.c b/tun.c index c92c0d7..81b66fb 100644 --- a/tun.c +++ b/tun.c @@ -4492,7 +4492,7 @@ dhcp_masq_addr (const in_addr_t local, const in_addr_t netmask,

[Openvpn-devel] [PATCH 04/35] cleanup: memcmp.c: remove unused source

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac |3 --- memcmp.c | 43 --- 2 files changed, 0 insertions(+), 46 deletions(-) delete mode 100644 memcmp.c diff --git a/configure.ac b/configure.ac index 25dcc37..1c4d66c

[Openvpn-devel] [PATCH 07/35] build: tests do not work disable

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- Makefile.am |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 26b80f3..f96eb45 100644 --- a/Makefile.am +++ b/Makefile.am @@ -57,16 +57,17 @@ SUBDIRS = \ service

[Openvpn-devel] [PATCH 08/35] build: handle printf style format in mingw

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- buffer.h | 12 ++-- error.h |6 +- misc.h | 12 ++-- status.h |6 +- 4 files changed, 30 insertions(+), 6 deletions(-) diff --git a/buffer.h b/buffer.h index 6c79007..9bc33db 100644 --- a/bu

[Openvpn-devel] [PATCH 10/35] build: plugins: properly use CFLAGS and LDFLAGS

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- plugins/auth-pam/Makefile |9 + plugins/defer/build|6 +++--- plugins/down-root/Makefile |6 +++--- plugins/examples/build |6 +++--- 4 files changed, 14 insertions(+), 13 deletions(-) diff

[Openvpn-devel] [PATCH 09/35] build: rename plugin directory to plugins

2012-02-21 Thread Alon Bar-Lev
This to avoid conflit with plugin.c rules Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- Makefile.am |3 +- plugin/README | 47 --- plugin/auth-pam/.svnignore|1 - plugin/auth-pam/Makefile | 30 -- plugin/auth-pam/

[Openvpn-devel] [PATCH 11/35] Remove install-win32

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- Makefile.am|5 +- configure.ac |3 - images/.svnignore |2 - images/Makefile.am | 41 -- images/ic

[Openvpn-devel] [PATCH 12/35] Remove easy-rsa

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- Makefile.am|1 - easy-rsa/1.0/README| 161 easy-rsa/1.0/build-ca | 13 - easy-rsa/1.0/build-dh | 12 - easy-r

[Openvpn-devel] [PATCH 14/35] cleanup: rename tap-windows function from win32 to win

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac| 18 +++--- errlevel.h |2 +- error.c |6 +- forward.c |2 +- options.c |8 +- service-win32/service.h |2 +-

[Openvpn-devel] [PATCH 13/35] Remove tap-win32

2012-02-21 Thread Alon Bar-Lev
Introduce tap-win32.h which is modified tap-win32/common.h. Except of function rename, it is the same without the tap_id. This file should be provided as part of tap-win32 MSI. For now we hold a copy. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- Makefile.am

[Openvpn-devel] [PATCH 18/35] build: m4/ax_emptyarray.m4: cleanup

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- m4/ax_emptyarray.m4 | 49 +++-- 1 files changed, 31 insertions(+), 18 deletions(-) diff --git a/m4/ax_emptyarray.m4 b/m4/ax_emptyarray.m4 index 0a8755c..c6781c1 100644 --- a/m4/ax_emptyar

[Openvpn-devel] [PATCH 20/35] build: autotools: first pass of trivial autotools changes

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- Makefile.am | 12 +- configure.ac | 1227 +++--- lladdr.c |2 +- misc.c |2 +- misc.h |2 +- options.c| 12 +- route.c | 18 +- so

[Openvpn-devel] [PATCH 21/35] build: autoconf: remove OPENVPN_ADD_LIBS useless macro

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 26 ++ m4/ax_openvpn_lib.m4 |4 2 files changed, 10 insertions(+), 20 deletions(-) delete mode 100644 m4/ax_openvpn_lib.m4 diff --git a/configure.ac b/configure.ac index 3

[Openvpn-devel] [PATCH 19/35] build: m4/ax_socklen_t.m4: cleanup

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac |2 +- m4/ax_socklen_t.m4 | 95 +-- 2 files changed, 55 insertions(+), 42 deletions(-) diff --git a/configure.ac b/configure.ac index fbed6bf..69a3736

[Openvpn-devel] [PATCH 22/35] build: remove awk and non-standard autoconf output processing

2012-02-21 Thread Alon Bar-Lev
Replace with simpler environment solution. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- Makefile.am | 12 ++-- configure.ac |3 +++ configure_h.awk | 39 --- configure_log.awk

[Openvpn-devel] [PATCH 24/35] build: add libtool + windows resources for executables

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- .gitignore |6 Makefile.am |2 +- build/Makefile.am| 15 +++ build/ltrc.inc

[Openvpn-devel] [PATCH 25/35] build: autoconf: commands as environment

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 66 - 1 files changed, 28 insertions(+), 38 deletions(-) diff --git a/configure.ac b/configure.ac index 5afcacc..c34e8c4 100644 --- a/configure.ac +++ b/config

[Openvpn-devel] [PATCH 29/35] build: proper selinux detection and usage

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac| 35 +++ src/openvpn/Makefile.am |1 + src/openvpn/init.c |4 ++-- src/openvpn/options.c |6 +++--- src/openvpn/options.h |2 +- src/openvpn/sys

[Openvpn-devel] [PATCH 27/35] build: properly detect and use socket libs

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac| 27 +-- src/openvpn/Makefile.am |3 ++- 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index e893d8d..d18e2b0 100644 --- a/config

[Openvpn-devel] [PATCH 28/35] build: autoconf: minor cleanups

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 145 +- 1 files changed, 72 insertions(+), 73 deletions(-) diff --git a/configure.ac b/configure.ac index d18e2b0..8bc23cc 100644 --- a/configure.ac +++ b/config

[Openvpn-devel] [PATCH 32/35] build: proper lzo detection and usage

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 101 - doc/doxygen/doc_compression.h |2 +- src/openvpn/Makefile.am |2 + src/openvpn/forward.c |4 +- src/openvpn/init.c

[Openvpn-devel] [PATCH 31/35] build: properly process lzo-stub

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 12 +++- src/openvpn/lzo.c | 20 ++-- src/openvpn/lzo.h | 20 ++-- src/openvpn/ssl.c |2 +- src/openvpn/syshead.h | 12 5 files chang

[Openvpn-devel] [PATCH 33/35] build: proper crypto detection and usage

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 224 ++--- doc/doxygen/doc_data_crypto.h |2 +- include/openvpn-plugin.h | 31 -- src/openvpn/Makefile.am |2 + src/openvpn/cr

[Openvpn-devel] [PATCH 34/35] build: win-msvc: msbuild format

2012-02-21 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- .gitignore| 10 +- Makefile.am | 10 +- build/Makefile.am |2 + build/msvc/Makefile.am| 15 + buil

[Openvpn-devel] [PATCH 35/35] build: move out config.h include from syshead

2012-02-21 Thread Alon Bar-Lev
Yet another step in reducing the syshead.h content. Conditional compilation of sources needs to be based on a minimum program prefix (config.h only). Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/base64.c |6 ++ src/openvpn/buffer.c

[Openvpn-devel] [PATCH 23/35] build: standard directory layout

2012-02-21 Thread Alon Bar-Lev
Too big for mailing list... Suitable for mature project. root - administrative stuff doc- documents src- sources tests - tests distro - distro specific files sample - samples Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> On Tue, Feb 21, 2012 at 3:25 AM, <openvpn-d

Re: [Openvpn-devel] [PATCH 00/35] build revolution

2012-02-21 Thread Alon Bar-Lev
Hello Frank, Thank you for testing. Can you please try to download my tarball[1] and not autoreconf at your machine? I think your autotools are waaay to old. And... can you please send me: # autoconf --version # aclocal --version # automake --version # libtool --version Alon [1]

Re: [Openvpn-devel] [PATCH 00/35] build revolution

2012-02-21 Thread Alon Bar-Lev
Oh, and I forgot. Most optional dependencies are now disabled by default. You should explicitly enable lzo with --enable-lzo On Tue, Feb 21, 2012 at 11:01 AM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > Hi! > > Will there are no more --with-*-headers configure options, as

Re: [Openvpn-devel] [PATCH 00/35] build revolution

2012-02-21 Thread Alon Bar-Lev
Hello, On Tue, Feb 21, 2012 at 12:30 PM, Adriaan de Jong wrote: > Hi Alon, > > It's great to see a lot of work on the build system. Working with the old > system was often a pain, I hope the new system gives some more control and > especially flexibility to packagers. Still,

Re: [Openvpn-devel] [PATCH 00/35] build revolution

2012-02-21 Thread Alon Bar-Lev
On Tue, Feb 21, 2012 at 1:32 PM, Frank de Brabander wrote: > When I try to build like this, it seems to fail at linking to openssl > (OS X Lion). > > ./configure PKG_CONFIG=true > make > mekboek:openvpn-2.x-master brabander$ ls /usr/lib/libcrypto.* > /usr/lib/libssl.* >

  1   2   3   4   5   6   7   8   >