Re: [osg-users] pragma warnings disabled in headers

Hi Guys, I generally agree that suppressing these warnings is bad. Truth is if they were not disabled at the early days of OSG most of them would be not present today because authors would fix them in other way. And this poses a danger for the future. As along as we keep them disabled authors

Re: [osg-users] pragma warnings disabled in headers

Hi Wojtek, On Tue, Nov 25, 2008 at 11:39 AM, Wojciech Lewandowski <[EMAIL PROTECTED]> wrote: > But the other side is that proper fixing would probably require modifying > hundreds of OSG headers. I doubt that there is anyone brave enough to accept > this time consuming task and I doubt Robert will

Re: [osg-users] pragma warnings disabled in headers

Hi Paul, Wojtek's change only restores the OSG to how it's been compiling since the very early days w.r.t disabling the least usefu/most distractingl of the MSVC warnings. You can disable this via CMake, so that the OSG doesn't suppress any warnings. Fixing warnings is desirable, but has to be d

Re: [osg-users] pragma warnings disabled in headers

> I thought a push and pop pragma would work ( I use that in > my code) , but that would be in the headers which Robert > wants to avoid I'm usually opposed to push/pop too -- not because they're "in the headers", but because they disable displaying warnings for a block of code, and therefore

Re: [osg-users] pragma warnings disabled in headers

ssage- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Paul Martz Sent: Monday, November 24, 2008 4:38 PM To: 'OpenSceneGraph Users' Subject: Re: [osg-users] pragma warnings disabled in headers Hi all -- Sorry I'm coming into this a little late. What I'd really l

Re: [osg-users] pragma warnings disabled in headers

Hi all -- Sorry I'm coming into this a little late. What I'd really like is a clean compile so that if I introduce some suspicious code, I clearly see a new warning message displayed in the output, so that I can investigate it. What I don't want is to have all warnings disabled so that I never see

Re: [osg-users] pragma warnings disabled in headers

Hi Robert, I have restored MSVC disabled warnings in osg/Export. Difference is they are now disabled only when OSG_DISABLE_MSVC_WARNINGS macro is defined. This macro is set through CMake options and autogenerated in osg/Config. Simon suggested that it would be cool if we had more control over

Re: [osg-users] pragma warnings disabled in headers

g C4244: 'argument' : conversion from 'const osg::Matrixd::value_type' to 'osg::Vec4f::value_type', possible loss of data 24>C:\dev\OSG_SVN\OpenSceneGraph\include\osg/Matrixd(632) : warning C4244: 'argument' : conversion from 'const osg::Matr

Re: [osg-users] pragma warnings disabled in headers

#x27;argument' : conversion from 'const osg::Matrixd::value_type' to > 'osg::Vec4f::value_type', possible loss of data > > 24>C:\dev\OSG_SVN\OpenSceneGraph\include\osg/Matrixd(617) : warning C4244: > 'argument' : conversion from 'const osg::Mat

Re: [osg-users] pragma warnings disabled in headers

2008/11/21 Wojciech Lewandowski <[EMAIL PROTECTED]>: > Hi, Guys > Some middle step solution could be CMake define which would activate warning > disable in osg\Export. Would this be acceptable ? > > What do other OSG windows developers think ? > Sounds good to me. Though perhaps we should go whole

Re: [osg-users] pragma warnings disabled in headers

type' to 'osg::Vec4f::value_type', possible loss of data 24>C:\dev\OSG_SVN\OpenSceneGraph\include\osg/Matrixd(632) : warning C4244: 'argument' : conversion from 'const osg::Matrixd::value_type' to 'osg::Vec4f::value_type', possible loss of data 24>

Re: [osg-users] pragma warnings disabled in headers

2008/11/7 Robert Osfield <[EMAIL PROTECTED]> > On Fri, Nov 7, 2008 at 3:42 PM, Simon Hammett > <[EMAIL PROTECTED]> wrote: > > I agree with Peter, arbitrarily turning off peoples warnings isn't good > > practice. > > The OSG generally doesn't disable warnings, warning disabling is only > done on VS

Re: [osg-users] pragma warnings disabled in headers

On Fri, Nov 7, 2008 at 3:42 PM, Simon Hammett <[EMAIL PROTECTED]> wrote: > I agree with Peter, arbitrarily turning off peoples warnings isn't good > practice. The OSG generally doesn't disable warnings, warning disabling is only done on VS as it's had a history of producing lots of warnings on cor

Re: [osg-users] pragma warnings disabled in headers

2008/11/7 Robert Osfield <[EMAIL PROTECTED]> > Hi Peter, > > On Fri, Nov 7, 2008 at 12:11 PM, Peter Wraae Marino <[EMAIL PROTECTED]> > wrote: > > there is no push/pop for the warning in the header file which will make > > these warnings disabled in my own code too. I would like to catch this > > w

Re: [osg-users] pragma warnings disabled in headers

Hi Peter, On Fri, Nov 7, 2008 at 12:11 PM, Peter Wraae Marino <[EMAIL PROTECTED]> wrote: > there is no push/pop for the warning in the header file which will make > these warnings disabled in my own code too. I would like to catch this > warnings in my own code and I shouldn't be forced to enablin

[osg-users] pragma warnings disabled in headers

Hi Users (Robert), I noticed that the include file "export" has the following #if defined(_MSC_VER) #pragma warning( disable : 4244 ) #pragma warning( disable : 4251 ) #pragma warning( disable : 4267 ) #pragma warning( disable : 4275 ) #pragma warning( disable : 4290 ) #pr