[pgadmin-hackers] Speed up node animation in pgAdmin4

2016-03-19 Thread Thom Brown
Hi, I've attached a patch to speed up the expansion/collapsing of nodes. I've found it sluggish when testing, so I suggest we make it feel more responsive. I've also changed the speed of scrolling to an item. I don't know if we use this anywhere, but in case we do, I don't think we want it as sl

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-04-05 Thread Thom Brown
I'm getting weirdness with this node. See the attached picture, where it shows the servers node appearing under functions. Thom On 5 April 2016 at 16:21, Dave Page wrote: > Thanks - committed. > > On Mon, Mar 28, 2016 at 8:26 AM, Khushboo Vashi > wrote: >> Hi, >> >> Please find updated patch f

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-04-05 Thread Thom Brown
On 5 April 2016 at 17:20, Dave Page wrote: > On Tue, Apr 5, 2016 at 5:18 PM, Thom Brown wrote: >> I'm getting weirdness with this node. See the attached picture, where >> it shows the servers node appearing under functions. > > Make sure you've restarted the pytho

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-04-27 Thread Thom Brown
On 27 April 2016 at 10:22, Harshal Dhumal wrote: > > Hi, > > PFA attached patches for table node and all table child nodes. > > This patch includes below nodes, > > 1) Table node -- Initial patch by Murtuza, > constraints compatibility by Harshal. > 2) Column node

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-04-27 Thread Thom Brown
On 27 April 2016 at 13:43, Thom Brown wrote: > On 27 April 2016 at 10:22, Harshal Dhumal > wrote: >> >> Hi, >> >> PFA attached patches for table node and all table child nodes. >> >> This patch includes below nodes, >> >> 1) Table node

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-04-28 Thread Thom Brown
On 27 April 2016 at 14:34, Thom Brown wrote: > On 27 April 2016 at 13:43, Thom Brown wrote: >> On 27 April 2016 at 10:22, Harshal Dhumal >> wrote: >>> >>> Hi, >>> >>> PFA attached patches for table node and all table child nodes. >>>

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-24 Thread Thom Brown
On 24 May 2016 at 19:09, Ashesh Vashi wrote: > On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch, which will fixes below mentioned issues, >> > Committed. > In the Create Table dialog, on the Advanced tab, the "Of type" dro

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-24 Thread Thom Brown
On 25 May 2016 at 00:29, Thom Brown wrote: > On 24 May 2016 at 19:09, Ashesh Vashi wrote: >> >> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >> wrote: >>> >>> Hi, >>> >>> PFA patch, which will fixes below mentioned issues, >>

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-24 Thread Thom Brown
On 25 May 2016 at 02:00, Thom Brown wrote: > On 25 May 2016 at 00:29, Thom Brown wrote: >> On 24 May 2016 at 19:09, Ashesh Vashi wrote: >>> >>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >>> wrote: >>>> >>>> Hi,

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-25 Thread Thom Brown
cts/pgadmin4/"; for the > same. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshv

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-26 Thread Thom Brown
On 26 May 2016 at 11:20, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch for RM#1231 & RM#1237. > > Additionally I have shifted 'Advanced tab' after columns & constraint tab. > > > @Thom, > > Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to > p

Re: [pgadmin-hackers] pgAdmin III commit: Rename "Replication" to "Slony Replication"

2011-06-26 Thread Thom Brown
   |    2 +- > pgadmin/ui/dlgUserMapping.xrc             |    2 +- > pgadmin/ui/dlgView.xrc                    |    2 +- > pgadmin/ui/xrcDialogs.cpp                 |68529 ++--- > 41 files changed, 34304 insertions(+), 34306 deletions(-) Minor po

[pgadmin-hackers] Proportional font in messages tab on OSX

2011-06-30 Thread Thom Brown
t;, and on the preferences tab it shows as "Lucida Grande, 11". The query I've been using to force an error is just: SELECT DELETE; Thanks Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Ente

Re: [pgadmin-hackers] Proportional font in messages tab on OSX

2011-07-01 Thread Thom Brown
On 1 July 2011 12:06, Dave Page wrote: > On Fri, Jul 1, 2011 at 1:28 AM, Thom Brown wrote: >> Hi, >> >> I notice that on OSX using PgAdmin 1.14 beta 2 the messages tab are >> showing in a proportional font if an error occurs more than once.  The >> first time it

[pgadmin-hackers] [BUG] Meaningless dialogue when deleting foreign key

2011-07-02 Thread Thom Brown
to drop foreign key "fk_name"? - No / Yes" Is this a known bug? Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company <> -- Sent via pgadmin-hackers mailing

Re: [pgadmin-hackers] [BUG] Meaningless dialogue when deleting foreign key

2011-07-02 Thread Thom Brown
On 2 July 2011 13:08, Guillaume Lelarge wrote: > On Sat, 2011-07-02 at 12:12 +0100, Thom Brown wrote: >> Hi, >> >> I'm using PgAdmin III 1.14 beta 2 on OSX.  When attempting to delete a >> foreign key on a table, a dialogue comes up saying "Fo

[pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

2011-07-02 Thread Thom Brown
es, and some of the above statements require lots of horizontal scrolling on the SQL tab to see what the action will be. Could we harmonise these? Note that I didn't change the format for OIDs when I added the WITH OIDS variant. Thanks -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion

Re: [pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

2011-07-02 Thread Thom Brown
ng very long names, and some of the >> above statements require lots of horizontal scrolling on the SQL tab >> to see what the action will be.  Could we harmonise these? > > Yes, we should. Could you provide a patch? Sure, I'll take a look at it. -- Thom Brown Twitter: @d

Re: [pgadmin-hackers] pgAdmin III commit: Update CHANGELOG and make style.

2011-07-02 Thread Thom Brown
/dditems/utilities/ddTableNameDialog.h       |    2 +- > 5 files changed, 9 insertions(+), 6 deletions(-) You appear to have added an entry for the fill factor patch twice. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterp

Re: [pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

2011-07-03 Thread Thom Brown
On 2 July 2011 21:26, Thom Brown wrote: > On 2 July 2011 20:20, Guillaume Lelarge wrote: >> Great patch. It even helped me find a bug. Anyway, commited and pushed. >> Thank you. > > Thanks for committing it. :) > >>> I personally prefer the ones with new

[pgadmin-hackers] [BUG] Index operator class + collation = bad SQL

2011-07-03 Thread Thom Brown
ee (word text_pattern_ops DESC NULLS LAST COLLATE pg_catalog."zh_CN.utf8"); Attached a patch to fix. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/pgadmin/

[pgadmin-hackers] Updated sequence syntax

2011-07-03 Thread Thom Brown
ously this won't enable anything to work that didn't previously, but just thought it would be nice to use more suitable syntax. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [pgadmin-hackers] Updated sequence syntax

2011-07-03 Thread Thom Brown
On 3 July 2011 22:40, Guillaume Lelarge wrote: > On Sun, 2011-07-03 at 19:23 +0100, Thom Brown wrote: >> [...] >> I noticed that altering sequences still uses the old ALTER TABLE >> syntax.  While that's required for older versions, it's not anymore. >> At

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 20:47, Guillaume Lelarge wrote: > Hi Thom, > > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: >> [...] >> I noticed that objects which can be moved to different schemas can't >> be moved in PgAdmin, so I looked to see if there was any request

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
think I may have unleashed some sort of rampant patch > beast... :/ >> BTW, are you going to char(11)? > > Are you? Did we have that conversation already? :-) No, and no. :( -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
schema name with new one > 3. select the object in the new schema > ? I'm not at all familiar with PgAdmin's codebase, I'm just feeling in the dark so I don't know how easy it is to do that. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux us

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-05 Thread Thom Brown
On 5 July 2011 21:08, Guillaume Lelarge wrote: > On Tue, 2011-07-05 at 21:01 +0100, Thom Brown wrote: >> On 5 July 2011 20:47, Guillaume Lelarge wrote: >> > Hi Thom, >> > >> > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: >> >> [...] &g

Re: [pgadmin-hackers] Changing extension schema silently fails

2011-07-05 Thread Thom Brown
On 5 July 2011 21:23, Thom Brown wrote: > Hi, > > I'm using the latest head and I created the file_fdw extension, then > attempted to change its schema.  No error was returned, but it > remained in the same schema. > > I then dropped the extension and created it again s

[pgadmin-hackers] Changing extension schema silently fails

2011-07-05 Thread Thom Brown
Am I missing something, or does this fail silently? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.or

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-07 Thread Thom Brown
On 7 July 2011 23:20, Guillaume Lelarge wrote: > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: >> add_schemas_to_all_items_filtered.patch - same patch as before, but >> with the above patch contents removed or adjusted to assume the fixes >> have been applied. >>

[pgadmin-hackers] Prevent function rewrite when changing owner

2011-07-07 Thread Thom Brown
Hi all, Tiny patch attached to prevent a function being completely rewritten when just the owner changes. Not sure if you regard it as a bug fix or merely an efficiency feature. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http

Re: [pgadmin-hackers] Prevent function rewrite when changing owner

2011-07-07 Thread Thom Brown
On 8 July 2011 01:18, Dave Page wrote: > Thanks - patch applied. Cheers! Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Overhaul of type attributes modification

2011-07-08 Thread Thom Brown
ether or not you have a collation assigned because the collation condition was based on the precision being present for some reason. And if you actually assigned a collation for a valid data type, it wouldn't appear at all, so that's fixed too. -- Thom Brown Twitter: @darkixion IRC (freeno

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-08 Thread Thom Brown
On 8 July 2011 15:19, Thom Brown wrote: > Hi all, > > I noticed that if you add, delete, rename or change the type, > collation or precision of a composite type attribute, it deletes all > of them then adds them all back in.  Obviously attribute additions, > deletions and modi

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-08 Thread Thom Brown
On 8 July 2011 15:38, Thom Brown wrote: > On 8 July 2011 15:19, Thom Brown wrote: >> Hi all, >> >> I noticed that if you add, delete, rename or change the type, >> collation or precision of a composite type attribute, it deletes all >> of them then adds them

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 19:46, Guillaume Lelarge wrote: > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: >> On 7 July 2011 23:20, Guillaume Lelarge wrote: >> > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: >> >> add_schemas_to_all_items_filtered.patch - same p

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
ines of code to store a schema > name, Whilst I don't see the actual impact, I'll concede the point since I've only just started looking at code really so wouldn't have seen the issue first-hand. Extensions are a weird case for me since you can assign them to a schema, b

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 20:52, Guillaume Lelarge wrote: > On Fri, 2011-07-08 at 20:46 +0200, Guillaume Lelarge wrote: >> On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: >> > On 7 July 2011 23:20, Guillaume Lelarge wrote: >> > > On Wed, 2011-07-06 at

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
w if the name of a text search configuration is changed, it appears in the SQL output twice. My original patch moved a whole section of code, but now the removal of the original copy is missing. Everything else seems to work fine though. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 9 July 2011 00:12, Guillaume Lelarge wrote: > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: >> On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: >> > On 8 July 2011 19:46, Guillaume Lelarge wrote: >> > > On Thu, 2011-07-07 at 23:24 +0100, Thom

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Thom Brown
On 9 July 2011 09:28, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: >> On 9 July 2011 00:12, Guillaume Lelarge wrote: >> > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: >> >> On Fri, 2011-07-08 at 20:06 +0100, Thom

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
gAdmin now shows the > list this way: >    c1 integer, >    c2 integer, >    c4 integer >    c3 xml, > > Which is true. We drop the attribute and add another one, which will be > at the end of the list. I have a solution. It seems I overlooked the alter attribute c

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 13:25, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: >> > The major issue is why we use the "drop all, add all" method.  Let's say >> > I have a composite type declared like this: >> > >> >

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Thom Brown
On 9 July 2011 12:56, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 10:33 +0100, Thom Brown wrote: >> On 9 July 2011 09:28, Guillaume Lelarge wrote: >> > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: >> >> On 9 July 2011 00:12, Guillaume Lelarge wrote: &g

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 13:26, Thom Brown wrote: > On 9 July 2011 13:25, Guillaume Lelarge wrote: >> On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: >>> > The major issue is why we use the "drop all, add all" method.  Let's say >>> > I have a compo

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Thom Brown
On 9 July 2011 20:55, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 15:14 +0100, Thom Brown wrote: > BTW, just commited and pushed your patch. Thanks again. \o/ Thanks again Guillaume. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 Enterp

[pgadmin-hackers] Prevent duplicate attributes

2011-07-09 Thread Thom Brown
Hi (yes, me... again), Tiny patch attached to prevent adding attributes with a duplicate name to a type. It seems previous versions prevented this, but must have been allowed in a commit since the last release. Regards Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 21:07, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 17:54 +0100, Thom Brown wrote: >> On 9 July 2011 13:26, Thom Brown wrote: >> > On 9 July 2011 13:25, Guillaume Lelarge wrote: >> >> On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: >>

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 21:11, Thom Brown wrote: > On 9 July 2011 21:07, Guillaume Lelarge wrote: >> On Sat, 2011-07-09 at 17:54 +0100, Thom Brown wrote: >>> On 9 July 2011 13:26, Thom Brown wrote: >>> > On 9 July 2011 13:25, Guillaume Lelarge wrote: >>> >>

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 23:58, Thom Brown wrote: > I've found a corner-case bug btw, which requires a tiny amendment. > But I'm also rebasing the patch for current master and 1.14_patches > (or whatever it's called), so you'll get these shortly Okay, here are the two rebased

[pgadmin-hackers] New key shortcuts for query window

2011-07-10 Thread Thom Brown
ify one accelerator per menu item. You can add another menu item for the additional key binding, but that looks rubbish. Any idea if it's possible to show both key bindings on the same item? e.g. Execute F5/Ctrl+R Thanks Thom Brown Twitter: @darkixion IRC (freenode): dark_ixi

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-11 Thread Thom Brown
On 11 July 2011 15:21, Guillaume Lelarge wrote: > On Sun, 2011-07-10 at 01:05 +0100, Thom Brown wrote: >> On 9 July 2011 23:58, Thom Brown wrote: >> > I've found a corner-case bug btw, which requires a tiny amendment. >> > But I'm also rebasing the patc

Re: [pgadmin-hackers] Prevent duplicate attributes

2011-07-12 Thread Thom Brown
On 12 July 2011 10:53, Dave Page wrote: > On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown wrote: >> Hi (yes, me... again), >> >> Tiny patch attached to prevent adding attributes with a duplicate name >> to a type.  It seems previous versions prevented this, but must have

Re: [pgadmin-hackers] New key shortcuts for query window

2011-07-12 Thread Thom Brown
On 12 July 2011 10:59, Dave Page wrote: > On Sun, Jul 10, 2011 at 1:45 PM, Thom Brown wrote: >> Hi all, >> >> I think the SQL query window should have a File > Close menu item, >> which maps to Ctrl+W (or Apple+W in the case of a Mac).  This is easy >> to a

Re: [pgadmin-hackers] Prevent duplicate attributes

2011-07-12 Thread Thom Brown
On 12 July 2011 11:11, Guillaume Lelarge wrote: > On Tue, 2011-07-12 at 10:55 +0100, Thom Brown wrote: >> On 12 July 2011 10:53, Dave Page wrote: >> > On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown wrote: >> >> Hi (yes, me... again), >> >> >> >>

Re: [pgadmin-hackers] New key shortcuts for query window

2011-07-12 Thread Thom Brown
On 12 July 2011 11:11, Dave Page wrote: > On Tue, Jul 12, 2011 at 11:03 AM, Thom Brown wrote: >> On 12 July 2011 10:59, Dave Page wrote: >>> On Sun, Jul 10, 2011 at 1:45 PM, Thom Brown wrote: >>>> Hi all, >>>> >>>> I think the SQL query w

Re: [pgadmin-hackers] Prevent duplicate attributes

2011-07-14 Thread Thom Brown
On 14 July 2011 10:24, Guillaume Lelarge wrote: > On Tue, 2011-07-12 at 11:17 +0100, Thom Brown wrote: >> On 12 July 2011 11:11, Guillaume Lelarge wrote: >> > On Tue, 2011-07-12 at 10:55 +0100, Thom Brown wrote: >> >> On 12 July 2011 10:53, Dave Page wrote: >&

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-14 Thread Thom Brown
On 14 July 2011 10:28, Dave Page wrote: > On Thu, Jul 14, 2011 at 10:22 AM, Guillaume Lelarge > wrote: >> On Mon, 2011-07-11 at 15:29 +0100, Thom Brown wrote: >>> On 11 July 2011 15:21, Guillaume Lelarge wrote: >>> > On Sun, 2011-07-10 at 01:05 +0100, Thom Brow

Re: [pgadmin-hackers] Prevent duplicate attributes

2011-07-18 Thread Thom Brown
On 14 July 2011 10:31, Thom Brown wrote: > On 14 July 2011 10:24, Guillaume Lelarge wrote: >> So, you're working on fixing it, right? > > Possibly ;)  : http://code.pgadmin.org/trac/ticket/329 > > I haven't had time to look at fixing various bugs over the last cou

Re: [pgadmin-hackers] Prevent duplicate attributes

2011-07-18 Thread Thom Brown
On 18 July 2011 21:55, Guillaume Lelarge wrote: > On Mon, 2011-07-18 at 21:06 +0100, Thom Brown wrote: >> On 14 July 2011 10:31, Thom Brown wrote: >> > On 14 July 2011 10:24, Guillaume Lelarge wrote: >> >> So, you're working on fixing it, right? >> >

Re: [pgadmin-hackers] Prevent duplicate attributes

2011-07-18 Thread Thom Brown
On 18 July 2011 22:25, Guillaume Lelarge wrote: > On Mon, 2011-07-18 at 22:15 +0100, Thom Brown wrote: >> On 18 July 2011 21:55, Guillaume Lelarge wrote: >> > On Mon, 2011-07-18 at 21:06 +0100, Thom Brown wrote: >> >> On 14 July 2011 10:31, Thom Brown wrote:

[pgadmin-hackers] Altering column collation

2011-07-18 Thread Thom Brown
Hi, Attached is a patch which fixes #328. Currently if you change a column's collation, it actually drops the column. This changes it so that it issues an ALTER TYPE to adjust the collation instead. Regards -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Thom Brown
On 19 July 2011 08:32, Guillaume Lelarge wrote: > On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: >> [...] >> Attached is a patch which fixes #328.  Currently if you change a >> column's collation, it actually drops the column.  This changes it so >> that i

Re: [pgadmin-hackers] Altering column collation

2011-07-20 Thread Thom Brown
On 19 July 2011 21:04, Guillaume Lelarge wrote: > On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: >> On 19 July 2011 08:32, Guillaume Lelarge wrote: >> > On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: >> >> [...] >> >> Attached is a patch wh

Re: [pgadmin-hackers] Altering column collation

2011-07-21 Thread Thom Brown
On 21 July 2011 21:58, Guillaume Lelarge wrote: > On Thu, 2011-07-21 at 22:54 +0200, Guillaume Lelarge wrote: >> On Thu, 2011-07-21 at 21:44 +0200, Guillaume Lelarge wrote: >> > On Wed, 2011-07-20 at 10:56 +0100, Thom Brown wrote: >> > > On 19 July 2011 2

Re: [pgadmin-hackers] Patch to add support for not valid domain and check constraint

2011-07-22 Thread Thom Brown
errors. I'm using latest master. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To ma

Re: [pgadmin-hackers] New options dialog

2011-08-15 Thread Thom Brown
ru hints) > > > Logging > > >(Logfile, Log level) > > > > > > Comments? > > > > Seems OK. > > > > Here it is. Patch attached, and a few screenshots. > Nice work Guillaume. I didn't see the original discussion about this so I didn't have any expectations, but this looks really good. This also means the options dialogue is able to add as many options as are needed in future without cramming them all in one tab, or having dozens of tabs to scroll through. +1 So this is effectively the same way that LibreOffice/OpenOffice does it :) -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin III commit: Update serbian translation

2012-03-02 Thread Thom Brown
On 2 March 2012 15:38, Guillaume Lelarge wrote: > Update serbian translation Can someone confirm whether this is really correct? "Клијенстки фајл са кључом" Should this instead be: "Клијентског фајл са кључом" -- Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

Re: [pgadmin-hackers] pgAdmin III commit: Update serbian translation

2012-03-02 Thread Thom Brown
2012/3/2 Magnus Hagander : > 2012/3/2 Thom Brown : >> On 2 March 2012 15:38, Guillaume Lelarge wrote: >>> Update serbian translation >> >> Can someone confirm whether this is really correct? >> >> "Клијенстки фајл са кључом" >> &g

Re: [pgadmin-hackers] pgAdmin III commit: Update serbian translation

2012-03-02 Thread Thom Brown
On 2 March 2012 16:02, Guillaume Lelarge wrote: > On Fri, 2012-03-02 at 16:56 +0100, Magnus Hagander wrote: >> 2012/3/2 Thom Brown : >> > On 2 March 2012 15:38, Guillaume Lelarge wrote: >> >> Update serbian translation >> > >> > Ca

Re: [pgadmin-hackers] pgAdmin III commit: Update serbian translation

2012-03-02 Thread Thom Brown
On 3 March 2012 07:02, Guillaume Lelarge wrote: > On Fri, 2012-03-02 at 17:01 +0100, Guillaume Lelarge wrote: >> On Fri, 2012-03-02 at 15:53 +0000, Thom Brown wrote: >> > On 2 March 2012 15:38, Guillaume Lelarge wrote: >> > > Update serbian translation >> >

[pgadmin-hackers] Problem building pgadmin

2012-03-04 Thread Thom Brown
Hi all, I haven't tried building PgAdmin in quite a while now, so have started from scratch again. I seem to be getting the following problem: make install-data-hook make[3]: Entering directory `/home/thom/Development/pgadmin3' chmod 0666 //home/thom/Development/pgadmin/share/pgadmin3/docs/en_

Re: [pgadmin-hackers] Problem building pgadmin

2012-03-04 Thread Thom Brown
On 4 March 2012 16:03, Dave Page wrote: > On Sun, Mar 4, 2012 at 3:48 PM, Thom Brown wrote: >> Hi all, >> >> I haven't tried building PgAdmin in quite a while now, so have started >> from scratch again.  I seem to be getting the following problem: >>

[pgadmin-hackers] Incorrect domain logic for 9.1

2012-04-21 Thread Thom Brown
Hi, I noticed that if I create a domain based on an array data type, it doesn't get listed in the Domains node if the server is 9.1. This is because the query that gets the domains says that if the number of dimensions used is greater than 0 (which it will be if it's an array), then it must match

Re: [pgadmin-hackers] Incorrect domain logic for 9.1

2012-04-25 Thread Thom Brown
On 24 April 2012 16:53, Dave Page wrote: > Done - thanks Thom. Cheers Dave. -- Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Add support for range types (9.2+)

2012-04-29 Thread Thom Brown
On 29 April 2012 21:56, Guillaume Lelarge wrote: > Add support for range types (9.2+) Range types aren't added to the type drop-down and instead only show the array-equivalents. -- Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscript

Re: [pgadmin-hackers] pgAdmin III commit: Add support for range types (9.2+)

2012-04-30 Thread Thom Brown
On 30 April 2012 15:44, Guillaume Lelarge wrote: > On Sun, 2012-04-29 at 22:22 +0100, Thom Brown wrote: >> On 29 April 2012 21:56, Guillaume Lelarge wrote: >> > Add support for range types (9.2+) >> >> Range types aren't added to the type drop-down and instead

Re: [pgadmin-hackers] pgAdmin III commit: Add support for range types (9.2+)

2012-04-30 Thread Thom Brown
On 30 April 2012 15:57, Guillaume Lelarge wrote: > On Mon, 2012-04-30 at 15:47 +0100, Thom Brown wrote: >> On 30 April 2012 15:44, Guillaume Lelarge wrote: >> > On Sun, 2012-04-29 at 22:22 +0100, Thom Brown wrote: >> >> On 29 April 2012 21:56, Guillaume Lelarge

[pgadmin-hackers] Indexed constraint comments not working

2013-05-26 Thread Thom Brown
Hi all, Comments on indexed constraints (primary keys, exclusion constraints etc.) are failing due to referencing the wrong alias of the relevant pg_description join in the join clause. Test case: CREATE TABLE test (id int); ALTER TABLE test ADD CONSTRAINT cnt_x_test EXCLUDE USING btree (id WIT

Re: [pgadmin-hackers] Indexed constraint comments not working

2013-05-26 Thread Thom Brown
On 26 May 2013 18:20, Thom Brown wrote: > Hi all, > > Comments on indexed constraints (primary keys, exclusion constraints > etc.) are failing due to referencing the wrong alias of the relevant > pg_description join in the join clause. > > Test case: > > CREATE TAB

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-02 Thread Thom Brown
On 29 May 2013 10:40, Neel Patel wrote: > Hi Dave, > > Please find the updated patch after fixing some of the issues and comments > given by Ashesh. Just realised this reply has been in my draft folder for over a month... This comment appears to be incomplete: //While editing the view, if it i

[pgadmin-hackers] pgAdmin4 HTML5 corrections

2015-02-06 Thread Thom Brown
Hi, Attached are various HTML5 markup fixes for pgAdmin4. Regards Thom diff --git a/web/pgadmin/browser/templates/browser/body.html b/web/pgadmin/browser/templates/browser/body.html index 29ea474..211b7e1 100644 --- a/web/pgadmin/browser/templates/browser/body.html +++ b/web/pgadmin/browser/temp

Re: [pgadmin-hackers] pgAdmin3 icon

2009-12-08 Thread Thom Brown
2009/12/8 Dave Page > 2009/12/8 Jean-Michel Pouré : > > Dear Friends, > > > > I follow pgAdmin3 project with great pleasure, many thanks for your > > work. > > > > Please find attached an updated icon for pgAdmin3: > > http://www.poure.com/images/pgadmin3.xcf > > > > I took PostgreSQL stock icon

Re: [pgadmin-hackers] pgAdmin3 icon

2009-12-08 Thread Thom Brown
2009/12/8 Thom Brown > 2009/12/8 Dave Page > > 2009/12/8 Jean-Michel Pouré : >> > Dear Friends, >> > >> > I follow pgAdmin3 project with great pleasure, many thanks for your >> > work. >> > >> > Please find attached an updated i

Re: [pgadmin-hackers] pgAdmin3 icon

2009-12-08 Thread Thom Brown
2009/12/8 Jean-Michel Pouré > Dear Friends, > > I follow pgAdmin3 project with great pleasure, many thanks for your > work. > > Please find attached an updated icon for pgAdmin3: > http://www.poure.com/images/pgadmin3.xcf > > I took PostgreSQL stock icon and applied a shadow effect in Gimp. > > K

Re: [pgadmin-hackers] pgAdmin3 icon

2009-12-08 Thread Thom Brown
2009/12/8 Dave Page > 2009/12/8 Thom Brown : > > >> Does Windows support ico files up to 512x512? If so, this might work: > >> http://darkixion.com/pg.ico > >> > >> Thom > >> > > > > Actually I just tried that and it didn't wor

Re: [pgadmin-hackers] pgAdmin3 icon

2009-12-11 Thread Thom Brown
2009/12/11 Dave Page > 2009/12/11 Guillaume Lelarge : > > Le mardi 8 décembre 2009 à 22:47:31, Dave Page a écrit : > >> 2009/12/8 Dave Page : > >> > 2009/12/8 Dave Page : > >> >> I wonder if we need to start with a less complex version, like the > >> >> one-colour elephant. > >> > > >> > The atta

[pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-21 Thread Thom Brown
Hi, Not so much a feature request but a tweak to a default settings. The guys at work agree that copying the creation script for a database object into a new query window is a bit annoying and unnecessary as we always end up having to clear the window each time before typing anything. I imagine

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Thom Brown
2009/12/22 Dave Page > On Mon, Dec 21, 2009 at 5:37 PM, Guillaume Lelarge > wrote: > > Le 21/12/2009 15:41, Thom Brown a écrit : > >> [...] > >> Not so much a feature request but a tweak to a default settings. The > guys > >> at work agree that copying

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Thom Brown
2009/12/22 Guillaume Lelarge > Le 22/12/2009 11:02, Thom Brown a écrit : > > 2009/12/22 Dave Page > > > >> On Mon, Dec 21, 2009 at 5:37 PM, Guillaume Lelarge > >> wrote: > >>> Le 21/12/2009 15:41, Thom Brown a écrit : > >>>> [...] &

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Thom Brown
2009/12/22 Dave Page > On Tue, Dec 22, 2009 at 1:16 PM, Guillaume Lelarge > wrote: > > Done. I didn't backpatch it on the 1.10 branch. I don't think we should > > do this but I don't really have a hard feeling on this, so tell me if it > > needs to be done. > > It's not a bug fix so it doesn't g

[pgadmin-hackers] Feature request: limited deletions

2010-04-08 Thread Thom Brown
I couldn't find any discussion on this, but the request is quite straightforward. Implement a LIMIT on DELETE statements like SELECT statements. So you could write: DELETE FROM massive_table WHERE id < 4000 LIMIT 1; This would allow deletions in smaller batches rather than waiting poten

Re: [pgadmin-hackers] Feature request: limited deletions

2010-04-08 Thread Thom Brown
On 8 April 2010 11:55, Ian Barwick wrote: > 2010/4/8 Thom Brown : > > I couldn't find any discussion on this, but the request is quite > > straightforward. Implement a LIMIT on DELETE statements like SELECT > > statements. > > > > So you could write: >

[pgadmin-hackers] Feature request: threaded processes

2010-06-01 Thread Thom Brown
I notice that pgAdmin often locks up while it's doing something, like vacuuming or restoring a database. Would it be possible to have this run in a separate thread instead of locking the whole app up? And maybe be minimisable so that it appears somewhere as a running task, allowing the user to do

[pgadmin-hackers] VACUUM messages without newlines

2010-06-01 Thread Thom Brown
This is basically a plea to add newlines where appropriate when outputting VACUUM messages to the log window. I originally whined^H^H^H^H^Hrote about it here: http://archives.postgresql.org/pgsql-hackers/2010-06/msg00039.php That wasn't the right place as it was mentioned that it's a client-side

Re: [pgadmin-hackers] VACUUM messages without newlines

2010-06-01 Thread Thom Brown
On 1 June 2010 17:19, Dave Page wrote: > On Tue, Jun 1, 2010 at 4:57 PM, Thom Brown wrote: >> This is basically a plea to add newlines where appropriate when >> outputting VACUUM messages to the log window. >> >> I originally whined^H^H^H^H^Hrote about it here: >&g

Re: [pgadmin-hackers] Looking for table design interface advice for pgAdmin Database Designer

2010-07-14 Thread Thom Brown
On 14 July 2010 16:38, Luis Ochoa wrote: > Hi, I'm just working right now at Database Designer for pgAdmin with the > GSoC, and I want to create a table user interface that will be simple, easy > to use, and more keyboardless possible, right now my proposal is with two > designs that you can see a

Re: [pgadmin-hackers] Looking for table design interface advice for pgAdmin Database Designer

2010-07-15 Thread Thom Brown
On 15 July 2010 16:10, Luis Ochoa wrote: > On Wed, Jul 14, 2010 at 5:46 PM, Guillaume Lelarge > wrote: >> >> Le 14/07/2010 17:56, Thom Brown a écrit : >> > On 14 July 2010 16:38, Luis Ochoa wrote: >> ... >> >> Regards, Luis. >> >> >>

Re: [pgadmin-hackers] Ticket 118: Exclusion constraints

2010-07-20 Thread Thom Brown
20 July 2010 15:41, guillaume wrote: > On Tue, 20 Jul 2010 13:05:30 +0100, Dave Page wrote: >> On Tue, Jul 20, 2010 at 1:02 PM, guillaume > wrote: >> >>> So here is version 2 of this patch. Still lacks the icon. I would draw >>> one >>> if I had any idea on what to draw :) >> >> Constraint icon

[pgadmin-hackers] Feature request: drop rules

2010-07-21 Thread Thom Brown
I noticed you can't drop rules from the GUI. Could this be added? Thanks Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

  1   2   >