On 04.12.23 21:11, Andrew Dunstan wrote:
I just had a look at shifting bowerbird to use meson, and it got stymied
at the c99 test, which apparently doesn't compile with anything less
than VS2019.
If that is the case, then wouldn't that invalidate the documented claim
that you can build with V
On 05.12.23 05:26, Ashutosh Bapat wrote:
- When inheriting from multiple parents with different settings, an
explicit setting in the child is required.
When no explicit setting for child is specified, it will throw an
error as it does today. Right?
Yes, it would throw an error, but a different
-77f7-38fb-be921dff71af%40enterprisedb.com
From 174d51a66c80a3284ad97b347a286a7b65a2a440 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 5 Dec 2023 13:43:30 +0100
Subject: [PATCH v1] Make attstattarget nullable
This changes the pg_attribute field attstattarget into a nullable
field in the varia
We have backtrace support for server errors. You can activate that
either by setting backtrace_functions or by explicitly attaching
errbacktrace() to an ereport() call.
I would like an additional mode that essentially triggers a backtrace
anytime elog() (for internal errors) is called. This
On 01.12.23 23:10, Tristan Partin wrote:
On Wed Jul 12, 2023 at 9:35 AM CDT, Tristan Partin wrote:
On Wed Jul 12, 2023 at 9:31 AM CDT, Peter Eisentraut wrote:
> On 12.07.23 16:23, Tristan Partin wrote:
> > It has come to my attention that STDOUT_FILENO might not be
portable and
>
On 04.12.23 06:46, Michael Paquier wrote:
On Mon, Dec 04, 2023 at 06:59:13AM +0530, Bharath Rupireddy wrote:
The commit 44cac934 replaced "char buf[BLCKSZ]" with PGAlignedBlock to
avoid issues on alignment-picky hardware. While it replaced most of the
instances, there are still some more left. H
I found the way that MergeAttributes() handles column compression and
storage settings very weird.
For example, I don't understand the purpose of this error:
create table t1 (a int, b text compression pglz);
create table t1a (b text compression lz4) inherits (t1);
...
ERROR: 42804: column "b"
src/backend/nodes/print.c contains a number of functions that print node
types, mostly to stdout. Most of these are not actually used anywhere
in the code. Are they meant to be inserted into the code ad hoc for
debugging? Is anyone using these?
This file has clearly not been updated substan
On 01.12.23 11:51, shubham.kha...@fujitsu.com wrote:
Hi Peter,
I have reviewed the patches and also RUN the command, 'make check-world'. It is
working fine. All test cases are passed successfully.
committed
Thanks and Regards,
Shubham Khanna.
-Original Message-----
F
On 01.12.23 17:41, Tom Lane wrote:
Peter Eisentraut writes:
I noticed that some header files included system header files for no
apparent reason, so I did some digging and found out that in a few cases
the original reason has disappeared. So I propose the attached patches
to remove the
Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Fri, 1 Dec 2023 08:32:11 +0100
Subject: [PATCH 1/3] Remove unnecessary includes of
These were once needed for sig_atomic_t, but that no longer appears in
these headers, so the include is not needed.
---
src/include/replication/walsender.h
On 30.11.23 06:59, Michael Paquier wrote:
ereport(elevel,
(errcode(ERRCODE_UNDEFINED_OBJECT),
-errmsg("unrecognized configuration parameter \"%s\"
in file \"%s\" line %d",
-
dangling data lying around (for example, attacl could
contain references to users that are later also dropped).
I suggest the attached patch to set those fields to null when a column
is marked as dropped.From d587588df6d2bea8ea9b9e13b897e4206b1a0884 Mon Sep 17 00:00:00 2001
From: Peter
On 28.11.23 19:16, Andres Freund wrote:
On 2023-11-28 19:02:42 +0100, Peter Eisentraut wrote:
I noticed that under meson, the selection of the Python installation using
the 'PYTHON' option doesn't work completely. The 'PYTHON' option determined
the Python binary that
On 23.11.23 11:01, Peter Eisentraut wrote:
On 20.11.23 17:25, Tom Lane wrote:
Peter Eisentraut writes:
On 14.11.23 17:15, Tom Lane wrote:
I don't love the patch details though. It seems entirely wrong to
check
this before we check the opclass match.
Not sure why? The order doesn&#
On 23.11.23 09:41, Peter Eisentraut wrote:
On 20.11.23 02:25, Ian Lawrence Barwick wrote:
2023年7月3日(月) 18:22 Peter Eisentraut :
On 23.06.23 09:45, Ian Lawrence Barwick wrote:
if (!HeapTupleIsValid(tp))
+ {
+ ForeignServer *server = GetForeignServer(serverid
On 29.11.23 14:23, Andrew Dunstan wrote:
On 2023-11-28 Tu 13:02, Peter Eisentraut wrote:
I noticed that under meson, the selection of the Python installation
using the 'PYTHON' option doesn't work completely. The 'PYTHON'
option determined the Python binary that
c297c458766a0e1ee65408d3ced469f32cf5e7d8 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 28 Nov 2023 20:38:16 +0100
Subject: [PATCH v2 2/2] Catalog domain not-null constraints
This applies the explicit catalog representation of not-null
constraints introduced by b0e96f3119 for table
this through
Cirrus, seems to work.From d83c43c1bed2a096549fada42951b346b269c551 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 28 Nov 2023 18:56:18 +0100
Subject: [PATCH] Meson python detection
When we look for the Python installation using the meson python
module, we should make it use
tion. Added tests for the same.
This looks reasonable after a first reading. (I have found that using
git diff --patience makes the 0001 patch look more readable. Maybe
that's helpful.)From eac97b6f2a081f327d0649d35a346db0b4bb9d99 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue,
On 25.11.23 21:44, Tomas Vondra wrote:
while working on a patch I noticed we do this in the SGML docs (for
example in indexam.sgml and a bunch of other files):
... some text ...
some code
... description of the code.
That is, the program listing is in a paragraph tha
On 23.11.23 17:38, Alvaro Herrera wrote:
If you create a table with column of domain that has a NOT NULL
constraint, what happens? I mean, is the table column marked
attnotnull, and how does it behave?
No, the domain does not affect the catalog entry for the column. This
is the same way it b
On 20.11.23 17:25, Tom Lane wrote:
Peter Eisentraut writes:
On 14.11.23 17:15, Tom Lane wrote:
I don't love the patch details though. It seems entirely wrong to check
this before we check the opclass match.
Not sure why? The order doesn't seem to matter?
The case that was bo
On 20.11.23 08:58, Peter Eisentraut wrote:
On 17.11.23 19:39, Paul Jungwirth wrote:
But I feel the overall approach is wrong: originally I used hardcoded
"=" and "&&" operators, and you asked me to look them up by strategy
number instead. But that leads to tro
On 20.11.23 02:25, Ian Lawrence Barwick wrote:
2023年7月3日(月) 18:22 Peter Eisentraut :
On 23.06.23 09:45, Ian Lawrence Barwick wrote:
if (!HeapTupleIsValid(tp))
+ {
+ ForeignServer *server = GetForeignServer(serverid);
+
ereport(ERROR
+SELECT * FROM information_schema.check_constraints
+ WHERE (constraint_schema, constraint_name)
+IN (SELECT constraint_schema, constraint_name
+ FROM information_schema.domain_constraints
+WHERE domain_name IN ('con', 'dom', 'pos_int', 'things
On 21.11.23 14:35, Robert Haas wrote:
On Mon, Nov 20, 2023 at 11:37 PM Andres Freund wrote:
WRT Robert seeing those warnings and Tom not: There's something odd going
on. I couldn't immediately reproduce it. Then I realized it reproduces against
a homebrew install but not a macports one.
Robert
On 21.11.23 14:23, Peter Eisentraut wrote:
On 21.11.23 02:56, Andres Freund wrote:
One remaining question is whether we should adjust
install-doc-{html,man} to
be install-{html,man}, to match the docs targets.
Ah didn't notice that one; yes please.
I think this was done?
On 21.11.23 02:56, Andres Freund wrote:
One remaining question is whether we should adjust install-doc-{html,man} to
be install-{html,man}, to match the docs targets.
Ah didn't notice that one; yes please.
8861d5a6122d78f93379 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 21 Nov 2023 05:19:03 +0100
Subject: [PATCH 1/6] Put keywords in right order
---
src/backend/parser/gram.y | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/parser/gram.y b/src/backend/pa
On 14.11.23 17:15, Tom Lane wrote:
I don't love the patch details though. It seems entirely wrong to check
this before we check the opclass match.
Not sure why? The order doesn't seem to matter?
Also, in at least some cases
the code presses on looking for another match if the current opclas
On 17.11.23 19:39, Paul Jungwirth wrote:
But I feel the overall approach is wrong: originally I used hardcoded
"=" and "&&" operators, and you asked me to look them up by strategy
number instead. But that leads to trouble with core gist types vs
btree_gist types. The core gist opclasses use RT*
On 17.11.23 13:25, Amul Sul wrote:
To fix this we should be doing something like ALTER COLUMN TYPE and the pass
should be AT_PASS_ALTER_TYPE (rename it or invent a new one near to that) so
that in ATRewriteCatalogs(), we would execute ATPostAlterTypeCleanup().
I simply tried that by doing blind
On 17.11.23 19:53, Andres Freund wrote:
I pushed the first two commits (the selinux stuff) and worked a bit more on
the subsequent ones.
Patches 0001 through 0004 look good to me.
Some possible small tweaks in 0004:
+perl, '-ne', 'next if /^#/; print',
If you're going for super-brief mod
On 16.11.23 02:07, Andres Freund wrote:
It doesn't seem like your patch has it quite that way? I see
MinGW
...
Windows
Where "Windows" actually seems to solely describe visual studio? That seems
confusing.
I had suggested this arrangement as a way to reduce churn in this patch
On 15.11.23 21:29, Tom Lane wrote:
Daniel Gustafsson writes:
Since the 3DES/DES deprecations aren't limited to FIPS, do we want to do
anything for pgcrypto where we have DES/3DES encryption? Maybe a doc patch
which mentions the deprecation with a link to the SP could be in order?
A docs patc
On 15.11.23 13:26, Amul Sul wrote:
Question: Why are you using AT_PASS_ADD_OTHERCONSTR? I don't know if
it's right or wrong, but if you have a specific reason, it would be
good
to know.
I referred to ALTER COLUMN DEFAULT and used that.
Hmm, I'm not sure if that is a good compa
On 15.11.23 00:07, Tom Lane wrote:
I'm more concerned about the 3DES situation. Fedora might be a bit
ahead of the curve here, but according to the link above, everybody is
supposed to be in compliance by the end of 2023. So I'd be inclined
to guess that the 3DES-is-rejected case is going to be
On 14.11.23 11:40, Amul Sul wrote:
Please have a look at the attached version, updating the syntax to have "AS"
after EXPRESSION and other changes suggested previously.
The code structure looks good to me now.
Question: Why are you using AT_PASS_ADD_OTHERCONSTR? I don't know if
it's right or
On 15.11.23 05:49, Michael Paquier wrote:
Attached is a v4.
I'm happy with that.
(Note, however, that your rebase didn't pick up commits e7814b40d0 and
b41b1a7f49 that I did yesterday. Please check that again.)
Here is a patch that does it that way.
From d58e65a71d2fab40ab22f047999efe06d96d8688 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 15 Nov 2023 11:00:49 +0100
Subject: [PATCH v2] Explicitly skip TAP tests under Meson if disabled
If the tap_tests option is disabled under Meson, the
Some comments on your patches:
v2-0001-meson-Change-default-of-selinux-feature-option-to.patch
Ok
v2-0002-docs-Document-with-selinux-Dselinux-options-centr.patch
Ok, but "selinux" should be "SELinux" when referring to the product.
v2-0003-meson-docs-Add-doc-html-man-targets.patch
We have mak
On 14.11.23 02:58, Jeff Davis wrote:
If the user just wants PK/FK constraints, and equality lookups, then an
index with the "C" collation makes a lot of sense to serve those
purposes.
The problem is that the user has no way to declare whether they just
want this. The default assumption is tha
On 13.11.23 17:49, Jeff Davis wrote:
On Mon, 2023-11-13 at 13:43 +0100, Peter Eisentraut wrote:
On 11.11.23 01:03, Jeff Davis wrote:
But the database collation is always deterministic,
So far!
Yeah, if we did that, clearly the index collation would need to match
that of the database to be
On 13.11.23 21:04, Laurenz Albe wrote:
On Mon, 2023-11-13 at 10:24 +0100, Peter Eisentraut wrote:
* If this table is partitioned and we're creating a unique index, primary
* key, or exclusion constraint, make sure that the partition key is a
* subset of the index'
On 09.11.23 18:52, Andres Freund wrote:
Besides giving you a quick validity check of the XML, this also builds the
doc_generated, which draw from non-doc source files, so this would also
serve to check that those are sound and didn't mess up the docs.
Unfortunately presence of xmllint doesn't gu
On 05.10.23 22:55, Tom Lane wrote:
I found another bit of fun we'll need to deal with: on my F38
platform, pgcrypto/3des fails as attached. Some googling finds
this relevant info:
https://github.com/pyca/cryptography/issues/6875
That is, FIPS deprecation of 3DES is happening even as we speak.
Other than the documentation details and the business about
Gen_dummy_probes, which has been dealt with separately, this patch looks
solid to me.
On 12.10.23 07:23, Michael Paquier wrote:
On Thu, Oct 05, 2023 at 09:38:51AM +0200, Peter Eisentraut wrote:
- I think we can't just delete in
On 13.11.23 06:30, Michael Paquier wrote:
On Fri, Nov 10, 2023 at 08:38:21AM +0100, Peter Eisentraut wrote:
How about this patch as a comprehensive solution?
8 files changed, 26 insertions(+), 339 deletions(-)
Thanks for the patch. The numbers are here, and the patch looks
sensible.
The
On 13.11.23 14:07, Amul Sul wrote:
Also, it seems to me that the SET EXPRESSION variant should just do an
update of the catalog table instead of a drop and re-insert.
I am not sure if that is sufficient; we need to get rid of the
dependencies of
existing expressions on other columns and
On 11.11.23 01:03, Jeff Davis wrote:
But the database collation is always deterministic,
So far!
On 27.10.23 13:32, Ashutosh Bapat wrote:
I think we should fix these anomalies as follows
1. Allow identity columns to be added to the partitioned table
irrespective of whether they have partitions of not.
2. Propagate identity property to partitions.
3. Use the same underlying sequence for getti
On 17.10.23 09:25, Ashutosh Bapat wrote:
#create table tpart (a serial primary key, src varchar) partition by range(a);
CREATE TABLE
#create table t_p4 (a int primary key, src varchar);
CREATE TABLE
To appease the gods of surprises I need to add a NOT NULL constraint. See [1].
#alter table t_p4 a
ow the index i1 to be created.From 3acd59dcd7dffcfd22e61cce3ac1bb4c6982d16d Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Mon, 13 Nov 2023 10:15:23 +0100
Subject: [PATCH] Check collation when creating partitioned index
---
src/backend/commands/indexcmds.c | 12 +++-
1 file
On 09.11.23 13:00, Amul Sul wrote:
On Tue, Nov 7, 2023 at 8:21 PM Peter Eisentraut <mailto:pe...@eisentraut.org>> wrote:
On 25.10.23 08:12, Amul Sul wrote:
> Here is the rebase version for the latest master head(673a17e3120).
>
> I haven't done any o
On 08.10.23 07:15, Thomas Munro wrote:
About your patch:
I think you should have a "check" function called from
check_new_cluster(). That check function can then also handle the "not
supported" case, and you don't need to handle that in
parseCommandLine(). I suggest following the clone example
On 17.10.23 03:32, Krishnakumar R wrote:
The version comparison has been moved from initdb to bootstrap. This
created some compatibility problems with windows tests. For now I kept
the version check to not have \n added, which worked fine and serves
the purpose. However hoping to have something b
On 06.10.23 02:24, Krishnakumar R wrote:
elog(INFO, "Open bki file %s\n", bki_file);
+ boot_yyin = fopen(bki_file, "r");
Why is this needed? It already reads the bki file from stdin?
We no longer open the bki file in initdb and pass to postgres to parse
from stdin, instead we open the bki fi
thing like that for all platforms now.
Sounds like a good idea to me now that perl is a hard requirement.
+1.
How about this patch as a comprehensive solution?
From 47731e486d7356462ce610a6a76c21a0b3619823 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Fri, 10 Nov 2023 08:07:11 +0100
Su
On 08.11.23 00:12, Michael Paquier wrote:
- Should the subdirectory pg_basebackup be renamed into something more
generic at this point? All these things are frontend tools that deal
in some way with the replication protocol to do their work. Say
a replication_tools?
Seems like unnecessary chu
On 09.11.23 00:21, Andres Freund wrote:
Example output:
This is very nice!
$ ninja help
[0/1 1 0%] Running external command help (wrapped by meson to set env)
Code Targets:
all Build everything other than documentation
backend Build backen
On 09.11.23 01:59, Andres Freund wrote:
I think we could build doc/src/sgml/postgres-full.xml by default. That
takes less than 0.5 seconds here and it's an intermediate target for html
and man.
That does require the docbook dtd to be installed, afaict. I think we would
need a configure test for
onsider for example, it's
possible that a type does not have a btree equality operator. We don't
check that here either, but let the index code later check it.
Overall, with these fixes, I think this patch is structurally okay. We
just need to make sure we have all the weird corner
On 08.11.23 13:55, Christoph Berg wrote:
Re: Peter Eisentraut
If the problem is broken doc patches, then maybe a solution is to
include the `xmllint --noout --valid` target in whatever the check-world
equivalent is for meson. Looking at doc/src/sgml/meson.build, we don't
seem to do
On 07.11.23 17:40, Alvaro Herrera wrote:
If the problem is broken doc patches, then maybe a solution is to
include the `xmllint --noout --valid` target in whatever the check-world
equivalent is for meson. Looking at doc/src/sgml/meson.build, we don't
seem to do that anywhere. Doing the no-outpu
ttached patches (plus e9f075f9a1 already committed).
From 543e669f78b65c5ec8a07dcad34c60c6f32439e7 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 8 Nov 2023 12:00:02 +0100
Subject: [PATCH 1/2] meson: Fix doc installation path computation
This applies the logic from 8f6858064b also to the d
On 12.10.23 07:23, Michael Paquier wrote:
- Is src/backend/utils/README.Gen_dummy_probes still correct after this?
AFAICT, the Perl-based MSVC build system uses Gen_dummy_probes.pl, but the
meson build uses Gen_dummy_probes.sed even on Windows. Is that correct,
intended?
Interesting point. Thi
On 06.07.23 00:00, Daniel Gustafsson wrote:
On 16 May 2023, at 11:17, Daniel Gustafsson wrote:
Parked in the July CF for now.
Rebased to fix a trivial conflict highlighted by the CFBot.
I think the problem with this approach is that one would need to reapply
it to each regression test su
On 05.09.23 12:25, Nazir Bilal Yavuz wrote:
There are multiple 'always:' keywords under the CompilerWarnings task.
Instead of that, we can use one 'always:' and move the instructions
under this. So, I removed unnecessary ones and rearranged indents
according to that change.
I'm not sure this ch
On 08.11.23 08:16, Peter Eisentraut wrote:
On 19.09.23 20:05, Heikki Linnakangas wrote:
One thing caught my eye though: We currently have an "open" command
after every "create". Except for bootstrap relations; creating a
bootstrap relation opens it implicitly. Tha
On 19.09.23 20:05, Heikki Linnakangas wrote:
One thing caught my eye though: We currently have an "open" command
after every "create". Except for bootstrap relations; creating a
bootstrap relation opens it implicitly. That seems like a weird
inconsistency. If we make "create" to always open the
On 23.10.23 05:53, Euler Taveira wrote:
Let's continue with the bike shedding... I agree with Peter E that this name
does not express what this tool is. At the moment, it only have one action:
create. If I have to suggest other actions I would say that it could support
switchover option too (that
On 03.11.23 19:19, Christoph Berg wrote:
You can control this with the "docs" option for meson, as of recently.
I've been looking into switching the Debian PG 17 build to meson, but
I'm running into several problems.
* The docs are still not built by default, and -Ddocs=enabled doesn't
chang
On 03.11.23 22:16, Andres Freund wrote:
[selinux option]
Why isn't it "auto" like the others?
I don't really remember why I did that, but it's platform specific, maybe
that's why I did it that way?
Isn't that kind the point of autodetecting things? Aren't bonjour and
bsd_auth autodetected as we
On 25.10.23 08:12, Amul Sul wrote:
Here is the rebase version for the latest master head(673a17e3120).
I haven't done any other changes related to the ON UPDATE trigger since that
seems non-trivial; need a bit of work to add trigger support in
ATRewriteTable().
Also, I am not sure yet, if we we
On 04.11.23 01:51, Andres Freund wrote:
I'd just use a single test() invocation here, and add an argument to testwrap
indicating that it should print out the skipped message. That way we a) don't
need two test() invocations, b) could still see the test name etc in the test
invocation.
Is testwr
On 02.11.23 23:34, Andres Freund wrote:
On 2023-11-01 16:39:24 -0400, Peter Eisentraut wrote:
OTOH, it seems somewhat unlikely that maintainer-clean is utilized much in
extensions. I see it in things like postgis, but that has it's own configure
etc, even though it also invokes pgxs
header files, but this is getting old, and we have an easier
solution now.)From 7ca9e82d3c5e30ea21fe5d428b3fa0d6e5b3e942 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Mon, 6 Nov 2023 12:57:54 +0100
Subject: [PATCH] python: Hide warnings inside Python headers when using gcc
compatible compiler
It looks like this patch set needs a bit of surgery to adapt to the LLVM
changes in 9dce22033d. The cfbot is reporting compiler warnings about
this, and also some crashes, which might also be caused by this.
I do like the updated APIs. (Maybe the repeated ".DebugPrint = NULL,
/* default
On 01.11.23 12:12, Aleksander Alekseev wrote:
Hi,
Hmm. I think maybe we should fix the behavior of
GetDataDirectoryCreatePerm() to be more consistent between Windows and
non-Windows. This is usually the first function a program uses on the
proposed data directory, so it's also responsible for
On 30.10.23 10:12, Tom Lane wrote:
+1 for counting such tests as "skipped" in the summary. -1 for
emitting a message per skipped test. If I'm intentionally not
running those tests, that would be very annoying noise, and
potentially would obscure messages I actually need to see.
In my usage, t
ying to amend.
On 11.09.23 07:02, John Naylor wrote:
On Thu, Aug 31, 2023 at 6:23 PM Peter Eisentraut <mailto:pe...@eisentraut.org>> wrote:
> Attached is an updated patch set.
> There was some discussion about whether the catalog files are the right
> place to keep
On 09.10.23 17:14, Andres Freund wrote:
It kinda works, but I'm not sure how well. Because the aliasing happens in
Makefile.global, we won't know about the "original" maintainer-clean target
once recursing into a subdir.
That's perhaps OK, because extensions likely won't utilize subdirectories?
On 01.11.23 10:25, Tom Lane wrote:
And there's never been any
real clarity about whether to quote GUC names, though certainly we're
more likely to quote anything injected with %s. So that's why we have
a mishmash right now.
I'm leaning toward not quoting GUC names. The quoting is needed in
p
ed
data directory and report the error. See attached patch.From ff3a5ef09ea7f6f54262986e234ec919d53821ac Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 31 Oct 2023 07:42:17 -0400
Subject: [PATCH] More consistent behavior of GetDataDirectoryCreatePerm on
Windows
On Windows, GetDataDir
but
obviously other implementations, such as using python, would also be
possible.)From 19e78e4c5a16337c0ac4e661beb4729505736016 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Mon, 30 Oct 2023 05:32:45 -0400
Subject: [PATCH] Explicitly skip TAP tests under Meson if disabled
If the tap_
On 29.09.23 10:02, Peter Eisentraut wrote:
On 26.09.23 17:19, Aleksander Alekseev wrote:
Attached is an updated patch set where I have split the changes into
smaller pieces. The last two patches still have some open questions
about what certain constants mean etc. The other patches should be
On 25.10.23 20:32, Jeff Davis wrote:
But what should the result of UPPER('á' COLLATE UCS_BASIC) be? In
Postgres, the answer is 'á', but intuitively, one could reasonably
expect the answer to be 'Á'.
I think that's right. But what would you put into ctype to make that
happen?
That seems to
On 23.10.23 22:34, Nathan Bossart wrote:
On Mon, Oct 23, 2023 at 05:55:32PM +0800, Junwang Zhao wrote:
On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut wrote:
Since C99, there can be a trailing comma after the last value in an enum
C99 allows us to do this doesn't mean we must do this,
On 19.10.23 11:39, Michael Banck wrote:
Hi,
I believed that spread (not fast) checkpoints are the default in
pg_basebackup, but noticed that --help does not specify which is which -
contrary to the reference documentation.
So I propose the small attached patch to clarify that.
> printf(_("
On 24.10.23 14:40, Julien Rouhaud wrote:
On Tue, Oct 24, 2023 at 6:57 PM Peter Eisentraut wrote:
On 24.10.23 09:58, Andrei Zubkov wrote:
During last moving to the current commitfest this patch have lost its
reviewers list. With respect to reviewers contribution in this patch, I
think
On 04.10.23 22:08, Robert Haas wrote:
- I would like some feedback on the generation of WAL summary files.
Right now, I have it enabled by default, and summaries are kept for a
week. That means that, with no additional setup, you can take an
incremental backup as long as the reference backup was
On 24.10.23 09:58, Andrei Zubkov wrote:
During last moving to the current commitfest this patch have lost its
reviewers list. With respect to reviewers contribution in this patch, I
think reviewers list should be fixed.
I don't think it's the purpose of the commitfest app to track how *has*
re
On 23.10.23 16:26, Tom Lane wrote:
Also, since "PGAC_PATH_PROGS(OPENSSL, openssl)" prints the full path to
what it found, you can at least tell after the fact that you are being
misled, because you can cross-check that path against the -L switches
being used for libraries.
Yeah, that seems ok
On 23.10.23 02:26, Michael Paquier wrote:
5e4dacb9878c has reminded me that we don't show the version of OpenSSL
in the output of ./configure. This would be useful to know when
looking at issues within the buildfarm, and I've wanted that a few
times.
How about the attached to use the openssl co
On 16.10.23 15:46, Alvaro Herrera wrote:
On 2023-Aug-27, Peter Eisentraut wrote:
On 22.08.23 15:48, Vik Fearing wrote:
I think these might be the same person:
Zhihong Yu
Zihong Yu
I did not spot any others.
Fixed.
Hm, I noticed we also list Ted Yu, but that's the
On 18.10.23 06:40, David Rowley wrote:
I agree that it's not nice to add yet another way of breaking the
buildfarm and even more so when the committer did make check-world
before committing. We have --enable-tap-tests, we could have
--enable-indent-checks and have pgindent check the code is cor
On 16.10.23 17:15, David Steele wrote:
I also do wonder with recovery_control is really a better name. Maybe
I just have backup_label too firmly stuck in my head, but is what that
file does really best described as recovery control? I'm not so sure
about that.
The thing it does that describes i
On 10.10.23 10:03, Peter Eisentraut wrote:
On 09.10.23 11:20, Alvaro Herrera wrote:
I tried this out. I agree it's a good change. BTW, this made me
realize that "unlike" is not a good name: maybe it should be called
"except".
right
I would add quotes to the words
On 11.10.23 03:08, Jeff Davis wrote:
* unicode_is_valid(text): returns true if all codepoints are
assigned, false otherwise
We need to be careful about precise terminology. "Valid" has a defined
meaning for Unicode. A byte sequence can be valid or not as UTF-8. But
a string containing u
701 - 800 of 3024 matches
Mail list logo
