Re: [HACKERS] review: tab completion for set search_path TO

2014-06-23 Thread Pavel Stehule
Hello I am sorry, I expected so review shold to start with new thread. I was wrong, so next reviews I will use e existing threads Regards pavel Dne 23. 6. 2014 7:39 Michael Paquier michael.paqu...@gmail.com napsal(a): On Sun, Jun 22, 2014 at 2:22 AM, Pavel Stehule pavel.steh...@gmail.com

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-23 Thread Kyotaro HORIGUCHI
Hello, thank you for the comments. On Sun, Jun 22, 2014 at 8:54 PM, Simon Riggs si...@2ndquadrant.com wrote: On 13 June 2014 12:27, Fujii Masao masao.fu...@gmail.com wrote: I think that pg_resetxlog should reset backup locations by default since they are useless (rather harmful) after

Re: [HACKERS] How to change the pgsql source code and build it??

2014-06-23 Thread Kyotaro HORIGUCHI
Hello, I don't know you environment so I don't see how many additional changes are needed, but still I think the message should not be seen there. @Fabrizio de Royes Mello, Even upon making changes as per your suggestion, I could see that initdb is failing for the same reason:

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello third version with Erik's update Here are some my comments: The document of psql needs to be updated. At least the description of new option this patch adds needs to be added into the document. +

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 3:49 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Hello, thank you for the comments. On Sun, Jun 22, 2014 at 8:54 PM, Simon Riggs si...@2ndquadrant.com wrote: On 13 June 2014 12:27, Fujii Masao masao.fu...@gmail.com wrote: I think that pg_resetxlog

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Pavel Stehule
Hello 2014-06-23 10:02 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello third version with Erik's update Here are some my comments: The document of psql needs to be updated. At least the description of

Re: [HACKERS] Audit of logout

2014-06-23 Thread Fujii Masao
On Sat, Jun 21, 2014 at 12:59 PM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/13/2014 07:29 AM, Tom Lane wrote: Fujii Masao masao.fu...@gmail.com writes: On Thu, Jun 12, 2014 at 8:51 PM, Fujii Masao masao.fu...@gmail.com wrote: Some users enable

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello 2014-06-23 10:02 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello third version with Erik's update Here are some my

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Pavel Stehule
2014-06-23 10:57 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello 2014-06-23 10:02 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule pavel.steh...@gmail.com

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-23 Thread Kyotaro HORIGUCHI
Hi, At Mon, 23 Jun 2014 17:10:05 +0900, Fujii Masao masao.fu...@gmail.com wrote in cahgqgwfy_cdmfuriu6zoat2htqo_eijaj7vwewysol15oct...@mail.gmail.com I assume the primary usage of this patch to be, as described before, Dissolving a recovery freezing caused by wrongly placed backup label.

Re: [HACKERS] inherit support for foreign tables

2014-06-23 Thread Ashutosh Bapat
Hi, Selecting tableoid on parent causes an error, ERROR: cannot extract system attribute from virtual tuple. The foreign table has an OID which can be reported as tableoid for the rows coming from that foreign table. Do we want to do that? On Fri, Jun 20, 2014 at 1:34 PM, Kyotaro HORIGUCHI

Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-06-23 Thread Fujii Masao
On Sat, Apr 12, 2014 at 9:25 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, The last week I twice had the need to see how many backends had some buffers pinned. Once during development and once while analyzing a stuck vacuum (waiting for a cleanup lock). I'd like to add a column to

Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-06-23 Thread Andres Freund
On 2014-06-23 18:44:24 +0900, Fujii Masao wrote: On Sat, Apr 12, 2014 at 9:25 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, The last week I twice had the need to see how many backends had some buffers pinned. Once during development and once while analyzing a stuck vacuum (waiting

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 6:06 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2014-06-23 10:57 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello 2014-06-23 10:02 GMT+02:00 Fujii Masao

Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 6:51 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-23 18:44:24 +0900, Fujii Masao wrote: On Sat, Apr 12, 2014 at 9:25 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, The last week I twice had the need to see how many backends had some buffers

Re: [HACKERS] crash with assertions and WAL_DEBUG

2014-06-23 Thread Heikki Linnakangas
On 06/21/2014 01:58 PM, Heikki Linnakangas wrote: It's a bit difficult to attach the mark to the palloc calls, as neither the WAL_DEBUG or LWLOCK_STATS code is calling palloc directly, but marking specific MemoryContexts as sanctioned ought to work. I'll take a stab at that. I came up with the

Re: [HACKERS] crash with assertions and WAL_DEBUG

2014-06-23 Thread Andres Freund
On 2014-06-23 12:58:19 +0300, Heikki Linnakangas wrote: On 06/21/2014 01:58 PM, Heikki Linnakangas wrote: It's a bit difficult to attach the mark to the palloc calls, as neither the WAL_DEBUG or LWLOCK_STATS code is calling palloc directly, but marking specific MemoryContexts as sanctioned

[HACKERS] Use a signal to trigger a memory context dump?

2014-06-23 Thread Andres Freund
Hi, I wonder if it'd make sense to allow a signal to trigger a memory context dump? I and others more than once had the need to examine memory usage on production systems and using gdb isn't always realistic. I wonder if we could install a signal handler for some unused signal (e.g. SIGPWR) to

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-06-23 Thread Fujii Masao
On Fri, May 2, 2014 at 3:19 PM, Ian Barwick i...@2ndquadrant.com wrote: Hi Here is an initial version of an auditing extension for Postgres to generate log output suitable for compiling a comprehensive audit trail of database operations. You added this into CF, but its patch has not been

Re: [HACKERS] idle_in_transaction_timeout

2014-06-23 Thread Andres Freund
On 2014-06-22 19:03:32 -0700, Kevin Grittner wrote: Andres Freund and...@2ndquadrant.com wrote: I think we'll want a version of this that just fails the transaction once we have the infrastructure. So we should choose a name that allows for a complimentary GUC. If we stick with the

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-06-23 Thread Abhijit Menon-Sen
(I'm replying as co-author of pgaudit.) At 2014-06-23 19:15:39 +0900, masao.fu...@gmail.com wrote: You added this into CF, but its patch has not been posted yet. Are you planning to make a patch? It's a self-contained contrib module. I thought Ian had posted a tarball, but it looks like he

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Pavel Stehule
2014-06-23 11:53 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 6:06 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2014-06-23 10:57 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule pavel.steh...@gmail.com wrote:

Re: [HACKERS] tab completion for setting search_path

2014-06-23 Thread Andres Freund
On 2014-06-22 20:02:57 -0700, Tom Lane wrote: Ian Barwick i...@2ndquadrant.com writes: On 23/06/14 00:58, Andres Freund wrote: I thought about committing this but couldn't get over this bit. If you type SELECT * FROM pg_cattab it'll get autocompleted to pg_catalog.pg_ and pg_temptab will

Re: [HACKERS] idle_in_transaction_timeout

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 7:48 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-22 19:03:32 -0700, Kevin Grittner wrote: Andres Freund and...@2ndquadrant.com wrote: I think we'll want a version of this that just fails the transaction once we have the infrastructure. So we should

Re: [HACKERS] idle_in_transaction_timeout

2014-06-23 Thread Andres Freund
On 2014-06-23 20:29:17 +0900, Fujii Masao wrote: On Mon, Jun 23, 2014 at 7:48 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-22 19:03:32 -0700, Kevin Grittner wrote: Andres Freund and...@2ndquadrant.com wrote: I think we'll want a version of this that just fails the

Re: [HACKERS] idle_in_transaction_timeout

2014-06-23 Thread Vik Fearing
On 06/22/2014 07:47 PM, Andres Freund wrote: On 2014-06-22 09:27:24 -0700, Kevin Grittner wrote: Andres Freund and...@2ndquadrant.com wrote: The idea with the GUC name is that if we ever get support for cancelling transactions we can name that idle_in_transaction_transaction_timeout? That

Re: [HACKERS] idle_in_transaction_timeout

2014-06-23 Thread Andres Freund
On 2014-06-23 13:33:46 +0200, Vik Fearing wrote: On 06/22/2014 07:47 PM, Andres Freund wrote: On 2014-06-22 09:27:24 -0700, Kevin Grittner wrote: Andres Freund and...@2ndquadrant.com wrote: but I don't like that much. Not sure what'd be good, the best I currently can come up with is:

Re: [HACKERS] review: Non-recursive processing of AND/OR lists

2014-06-23 Thread Gurjeet Singh
Thanks! On Mon, Jun 16, 2014 at 3:58 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: Gurjeet Singh gurj...@singh.im writes: I tried to eliminate the 'pending' list, but I don't see a way around it. We need temporary storage somewhere to store the branches encountered on the right; in

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-06-23 Thread Gurjeet Singh
On Wed, Jun 18, 2014 at 8:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Gurjeet Singh gurj...@singh.im writes: Please find attached the patch. It includes the doc changes as well. Applied with some editorialization. Thanks! would it be possible to include this in 9.4 as well? Best regards, --

[HACKERS] Re: Request for Patch Feedback: Lag Lead Window Functions Can Ignore Nulls

2014-06-23 Thread Nicholas White
Hi Abhijit - What's the status of this patch? The latest version of the patch needs a review, and I'd like to get it committed in this CF if possible. Thanks - Nick -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Use a signal to trigger a memory context dump?

2014-06-23 Thread Stephen Frost
Andres, * Andres Freund (and...@2ndquadrant.com) wrote: I wonder if it'd make sense to allow a signal to trigger a memory context dump? I and others more than once had the need to examine memory usage on production systems and using gdb isn't always realistic. +100 I keep thinking we have

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 7:51 PM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: (I'm replying as co-author of pgaudit.) At 2014-06-23 19:15:39 +0900, masao.fu...@gmail.com wrote: You added this into CF, but its patch has not been posted yet. Are you planning to make a patch? It's a

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-06-23 Thread Stephen Frost
* Fujii Masao (masao.fu...@gmail.com) wrote: On Mon, Jun 23, 2014 at 7:51 PM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: At 2014-06-23 19:15:39 +0900, masao.fu...@gmail.com wrote: You added this into CF, but its patch has not been posted yet. Are you planning to make a patch? It's

[HACKERS] How to use the 'char() ' as data type and a function name in the same time.

2014-06-23 Thread rohtodeveloper
Dear Hackers When I use the pg_catalog.char(integer) function in the postgres, I can only use it like these:select pg_catalog.char(65); select char(65); But I want to use the function by the following way.select char(1);Of coures, There would be a gram error. I know the error is caused by

Re: [HACKERS] Use a signal to trigger a memory context dump?

2014-06-23 Thread Andres Freund
On 2014-06-23 08:36:02 -0400, Stephen Frost wrote: Andres, * Andres Freund (and...@2ndquadrant.com) wrote: I wonder if it'd make sense to allow a signal to trigger a memory context dump? I and others more than once had the need to examine memory usage on production systems and using gdb

Re: [HACKERS] test failure on latest source

2014-06-23 Thread Marco Atzeri
On 16/04/2014 18:55, Marco Atzeri wrote: On 16/04/2014 17:40, Tom Lane wrote: The bigger picture though is that this code isn't failing on the buildfarm. So what we need to ask is what's different about Marco's machine. good question. I checked again and I found that the fault is only on

Re: [HACKERS] tab completion for setting search_path

2014-06-23 Thread Kevin Grittner
Andres Freund and...@2ndquadrant.com wrote: On 2014-06-22 20:02:57 -0700, Tom Lane wrote: Ian Barwick i...@2ndquadrant.com writes: On 23/06/14 00:58, Andres Freund wrote: I thought about committing this but couldn't get over this bit. If you type SELECT * FROM pg_cattab it'll get

Re: [HACKERS] Use a signal to trigger a memory context dump?

2014-06-23 Thread Stephen Frost
Andres, * Andres Freund (and...@2ndquadrant.com) wrote: On 2014-06-23 08:36:02 -0400, Stephen Frost wrote: I'd tend to think this would be sufficient. You're suggesting a case where you need to debug prior to SQL access (not specifically sure what you mean by that) or processes which are

[HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2014-06-23 Thread Heikki Linnakangas
On 04/05/2014 07:56 AM, Tom Lane wrote: MauMau maumau...@gmail.com writes: Then, as a happy medium, how about disabling message localization only if the client encoding differs from the server one? That is, compare the client_encoding value in the startup packet with the result of

Re: [HACKERS] replication identifier format

2014-06-23 Thread Robert Haas
On Wed, Jun 18, 2014 at 12:46 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-18 12:36:13 -0400, Robert Haas wrote: I actually don't think any of the discussions I was involved in had the externally visible version of replication identifiers limited to 16bits? If you are

Re: [HACKERS] replication identifier format

2014-06-23 Thread Andres Freund
On 2014-06-23 10:09:49 -0400, Robert Haas wrote: On Wed, Jun 18, 2014 at 12:46 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-18 12:36:13 -0400, Robert Haas wrote: I actually don't think any of the discussions I was involved in had the externally visible version of

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.2

2014-06-23 Thread Amit Kapila
On Tue, Jun 17, 2014 at 8:56 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-17 20:47:51 +0530, Amit Kapila wrote: On Tue, Jun 17, 2014 at 6:35 PM, Andres Freund and...@2ndquadrant.com wrote: You have followed it pretty well as far as I can understand from your replies, as

Re: [HACKERS] Atomics hardware support table supported architectures

2014-06-23 Thread Robert Haas
On Thu, Jun 19, 2014 at 10:43 AM, Merlin Moncure mmonc...@gmail.com wrote: On Thu, Jun 19, 2014 at 7:07 AM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: Let's not pretend to support platforms we have no practical way of verifying. This is key. The buildfarm defines the set of platforms we

Re: [HACKERS] releaseOk and LWLockWaitForVar

2014-06-23 Thread Amit Kapila
On Tue, Jun 17, 2014 at 5:47 PM, Andres Freund and...@2ndquadrant.com wrote: Hi Heikki, All, Amit just pointed me to a case where the lwlock scalability patch apparently causes problems and I went on to review it and came across the following problem in 9.4/master: LWLockWaitForVar()

Re: [HACKERS] replication identifier format

2014-06-23 Thread Robert Haas
On Mon, Jun 23, 2014 at 10:11 AM, Andres Freund and...@2ndquadrant.com wrote: Why? Users and other systems only ever see the external ID. Everything leaving the system is converted to the external form. The short id basically is only used in shared memory and in wal records. For both using

Re: [HACKERS] WIP patch for multiple column assignment in UPDATE

2014-06-23 Thread Robert Haas
On Thu, Jun 19, 2014 at 9:37 AM, Tom Lane t...@sss.pgh.pa.us wrote: Pavel Stehule pavel.steh...@gmail.com writes: I did some tests and It looks so it allows only some form of nested loop. [ shrug... ] It's a subplan. One evaluation per outer row is what people are expecting. Is it

Re: [HACKERS] replication commands and log_statements

2014-06-23 Thread Robert Haas
On Fri, Jun 20, 2014 at 9:48 AM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: OK, I've just implemented the patch (attached) which does this, i.e., redefines log_statement as a list. Thanks to the patch, log_statement can be set to none, ddl, mod, dml, all,

Re: [HACKERS] How to use the 'char() ' as data type and a function name in the same time.

2014-06-23 Thread Kevin Grittner
rohtodeveloper rohtodevelo...@outlook.com wrote: When I use the  pg_catalog.char(integer) function  in the postgres, I can only use it like these: select pg_catalog.char(65);  select char(65); But I want to use the function by the following  way. select char(1); Try using the chr()

Re: [HACKERS] JSON and Postgres Variable Queries

2014-06-23 Thread Robert Haas
On Fri, Jun 20, 2014 at 11:26 AM, Joey Caughey jcaug...@parrotmarketing.com wrote: I’m having an issue with JSON requests in Postgres and was wondering if anyone had an answer. I have an orders table with a field called “json_data”. In the json data there is a plan’s array with an id value

Re: [HACKERS] replication commands and log_statements

2014-06-23 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: Similarly, building a logging facility that meets the needs of real users is going to require a configuration method more flexible than a total order with four choices. I happen to think a list of comma-separated tokens is a pretty good choice,

Re: [HACKERS] Atomics hardware support table supported architectures

2014-06-23 Thread Andres Freund
On 2014-06-23 10:29:54 -0400, Robert Haas wrote: On Thu, Jun 19, 2014 at 10:43 AM, Merlin Moncure mmonc...@gmail.com wrote: On Thu, Jun 19, 2014 at 7:07 AM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: Let's not pretend to support platforms we have no practical way of verifying.

Re: [HACKERS] replication commands and log_statements

2014-06-23 Thread Robert Haas
On Mon, Jun 23, 2014 at 11:15 AM, Stephen Frost sfr...@snowman.net wrote: * Robert Haas (robertmh...@gmail.com) wrote: Similarly, building a logging facility that meets the needs of real users is going to require a configuration method more flexible than a total order with four choices. I

Re: [HACKERS] please review source(SQLServer compatible)‏

2014-06-23 Thread Andrew Dunstan
On 06/23/2014 10:51 AM, rohtodeveloper wrote: Dear all, Our application will be switched from SQL Server to PostgreSQL. However, a few functions are not supported yet. So we decided to extend it. The functions are as following: 1.SQL statement support INSERT statement without INTO keyword

Re: [HACKERS] Minmax indexes

2014-06-23 Thread Heikki Linnakangas
Some comments, aside from the design wrt. bounding boxes etc. : On 06/15/2014 05:34 AM, Alvaro Herrera wrote: Robert Haas wrote: On Wed, Sep 25, 2013 at 4:34 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Here's an updated version of this patch, with fixes to all the bugs reported so far.

Re: [HACKERS] replication identifier format

2014-06-23 Thread Andres Freund
On 2014-06-23 10:45:51 -0400, Robert Haas wrote: On Mon, Jun 23, 2014 at 10:11 AM, Andres Freund and...@2ndquadrant.com wrote: Why? Users and other systems only ever see the external ID. Everything leaving the system is converted to the external form. The short id basically is only

Re: [HACKERS] JSON and Postgres Variable Queries

2014-06-23 Thread Andrew Dunstan
On 06/23/2014 11:06 AM, Robert Haas wrote: On Fri, Jun 20, 2014 at 11:26 AM, Joey Caughey jcaug...@parrotmarketing.com wrote: I’m having an issue with JSON requests in Postgres and was wondering if anyone had an answer. I have an orders table with a field called “json_data”. In the json data

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.2

2014-06-23 Thread Andres Freund
On 2014-06-23 19:59:10 +0530, Amit Kapila wrote: On Tue, Jun 17, 2014 at 8:56 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-17 20:47:51 +0530, Amit Kapila wrote: On Tue, Jun 17, 2014 at 6:35 PM, Andres Freund and...@2ndquadrant.com wrote: You have followed it pretty

Re: [HACKERS] [BUGS] BUG #10728: json_to_recordset with nested json objects NULLs columns

2014-06-23 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: Digging more into that, I have found the issue and a fix for it. It happens that populate_recordset_object_start, which is used to initialize the process for the population of the record, is taken *each* time a json object is found, re-creating

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-06-23 Thread Tom Lane
Gurjeet Singh gurj...@singh.im writes: would it be possible to include this in 9.4 as well? While this is clearly an improvement over what we had before, it's impossible to argue that it's a bug fix, and we are way past the 9.4 feature freeze deadline. In particular, packagers who've already

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-06-23 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: I'd expect a catalog table or perhaps changes to pg_class (maybe other things also..) to define what gets logged. How exactly will that work for log messages generated in contexts where we do not have working catalog access? (postmaster, crash recovery,

[HACKERS] Re: [HACKERS] please review source(SQLServer compatible)‏

2014-06-23 Thread Kevin Grittner
Andrew Dunstan and...@dunslane.net wrote: On 06/23/2014 10:51 AM, rohtodeveloper wrote: Our application will be switched from SQL Server to PostgreSQL. However, a few functions are not supported yet. So we decided to extend it. The functions are as following: 1.SQL statement support   

[HACKERS] Re: [HACKERS] Re: [HACKERS] please review source(SQLServer compatible)‏

2014-06-23 Thread Pavel Stehule
2014-06-23 18:00 GMT+02:00 Kevin Grittner kgri...@ymail.com: Andrew Dunstan and...@dunslane.net wrote: On 06/23/2014 10:51 AM, rohtodeveloper wrote: Our application will be switched from SQL Server to PostgreSQL. However, a few functions are not supported yet. So we decided to extend

Re: [HACKERS] Atomics hardware support table supported architectures

2014-06-23 Thread Robert Haas
On Mon, Jun 23, 2014 at 11:16 AM, Andres Freund and...@2ndquadrant.com wrote: This criterion has been proposed before, but I'm not sure I really agree with it. If having code around that targets obscure platforms is hindering the development of new features, then that's a reason to get rid of

Re: [HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2014-06-23 Thread Tom Lane
Heikki Linnakangas hlinnakan...@vmware.com writes: Earlier in this thread, MauMau pointed out that we can't do encoding conversions until we have connected to the database because you need to read pg_conversion for that. That's because we support creating custom conversions with CREATE

Re: [HACKERS] JSON and Postgres Variable Queries

2014-06-23 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: You might find a sub-SELECT helpful: SELECT * FROM (SELECT json_data-’plan'-’id' as plan_id FROM orders) x WHERE plan_id = 1 It might be a generally useful thing for WHERE-clause items to be able to reference items from the target list by alias,

Re: [HACKERS] How about a proper TEMPORARY TABLESPACE?

2014-06-23 Thread Robert Haas
On Wed, Jun 18, 2014 at 9:39 PM, Matheus de Oliveira matioli.math...@gmail.com wrote: Then, to summarize Matheus must do: * use an option instead of change the syntax and catalog to indicate that a tablespace is used to store temp objects Yes. I myself wasn't sure TEMPORARY syntax would be

Re: [HACKERS] Use a signal to trigger a memory context dump?

2014-06-23 Thread MauMau
From: Andres Freund and...@2ndquadrant.com I wonder if it'd make sense to allow a signal to trigger a memory context dump? I and others more than once had the need to examine memory usage on production systems and using gdb isn't always realistic. +1 It would be nice if there's a generic

[HACKERS] Re: [BUGS] BUG #10728: json_to_recordset with nested json objects NULLs columns

2014-06-23 Thread Merlin Moncure
On Mon, Jun 23, 2014 at 10:43 AM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: Digging more into that, I have found the issue and a fix for it. It happens that populate_recordset_object_start, which is used to initialize the process for the population of

Re: [HACKERS] please review source(SQLServer compatible)‏

2014-06-23 Thread Vik Fearing
On 06/23/2014 04:51 PM, rohtodeveloper wrote: 1.SQL statement support INSERT statement without INTO keyword DELETE statement without FROM keywork Why would we want this? -- Vik -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] replication identifier format

2014-06-23 Thread Robert Haas
On Mon, Jun 23, 2014 at 11:28 AM, Andres Freund and...@2ndquadrant.com wrote: Oh, great. Somehow I missed the fact that that had been addressed. I had assumed that we still needed global identifiers in which case I think they'd need to be 64+ bits (preferably more like 128). If they only

Re: [HACKERS] SQL access to database attributes

2014-06-23 Thread Robert Haas
On Sun, Jun 22, 2014 at 2:59 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I found only one problem - first patch introduce a new property CONNECTION_LIMIT and replace previously used CONNECTION LIMIT in documentation. But CONNECTION LIMIT is still supported, but it is not documented. So

Re: [HACKERS] Atomics hardware support table supported architectures

2014-06-23 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Jun 23, 2014 at 11:16 AM, Andres Freund and...@2ndquadrant.com wrote: Since fetch-and-add is trivially implemented using CAS, there's not much need to distinguish between CAS and CAS + fetch_and_add. From my POV the restriction to just

Re: [HACKERS] Atomics hardware support table supported architectures

2014-06-23 Thread Andres Freund
On 2014-06-23 12:08:08 -0400, Robert Haas wrote: That we still have !PG_USE_INLINE support although all buildfarm animals support it since 4c8aa8b (fixing acc) causes absurd constructs (STATIC_IF_INLINE) and fugly macro usage making it harder to read and modify code. I spend a good chunk

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-06-23 Thread Gurjeet Singh
On Mon, Jun 23, 2014 at 11:52 AM, Tom Lane t...@sss.pgh.pa.us wrote: Gurjeet Singh gurj...@singh.im writes: would it be possible to include this in 9.4 as well? While this is clearly an improvement over what we had before, it's impossible to argue that it's a bug fix, and we are way past the

Re: [HACKERS] API change advice: Passing plan invalidation info from the rewriter into the planner?

2014-06-23 Thread Robert Haas
On Wed, Jun 18, 2014 at 2:18 PM, Stephen Frost sfr...@snowman.net wrote: I'm also of the opinion that this isn't strictly necessary for the initial RLS offering in PG- there's a clear way we could migrate existing users to a multi-policy system from a single-policy system. Sure, to get the

Re: [HACKERS] releaseOk and LWLockWaitForVar

2014-06-23 Thread Heikki Linnakangas
On 06/17/2014 03:17 PM, Andres Freund wrote: LWLockWaitForVar() doesn't set releaseOk to true when waiting again. Isn't that a bug? LWLockWaitForVar() waits in LW_WAIT_UNTIL_FREE mode, because it's not interested in acquiring the lock, it just wants to be woken up when it's released (or the

Re: [HACKERS] Atomics hardware support table supported architectures

2014-06-23 Thread Andres Freund
On 2014-06-23 09:28:19 -0700, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jun 23, 2014 at 11:16 AM, Andres Freund and...@2ndquadrant.com wrote: Since fetch-and-add is trivially implemented using CAS, there's not much need to distinguish between CAS and CAS +

Re: [HACKERS] releaseOk and LWLockWaitForVar

2014-06-23 Thread Heikki Linnakangas
On 06/23/2014 05:38 PM, Amit Kapila wrote: While looking at function LWLockWaitForVar(), espacially below code: TRACE_POSTGRESQL_LWLOCK_ACQUIRE(T_NAME(l), T_ID(l), LW_EXCLUSIVE); I think in this function tracing is done considering the Exclusive lock is acquired, however it might have granted

Re: [HACKERS] SQL access to database attributes

2014-06-23 Thread Vik Fearing
On 06/23/2014 06:21 PM, Robert Haas wrote: On Sun, Jun 22, 2014 at 2:59 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I found only one problem - first patch introduce a new property CONNECTION_LIMIT and replace previously used CONNECTION LIMIT in documentation. But CONNECTION LIMIT is

Re: [HACKERS] SQL access to database attributes

2014-06-23 Thread Pavel Stehule
2014-06-23 18:39 GMT+02:00 Vik Fearing vik.fear...@dalibo.com: On 06/23/2014 06:21 PM, Robert Haas wrote: On Sun, Jun 22, 2014 at 2:59 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I found only one problem - first patch introduce a new property CONNECTION_LIMIT and replace previously

Re: [HACKERS] Atomics hardware support table supported architectures

2014-06-23 Thread Robert Haas
On Mon, Jun 23, 2014 at 12:29 PM, Andres Freund and...@2ndquadrant.com wrote: That we have support for platforms that we haven't even documented as working (e.g. SuperH) or platforms that don't work in the realword (m32r) means that that one has to think about and research so many more

Re: [HACKERS] SQL access to database attributes

2014-06-23 Thread Robert Haas
On Mon, Jun 23, 2014 at 12:39 PM, Vik Fearing vik.fear...@dalibo.com wrote: On 06/23/2014 06:21 PM, Robert Haas wrote: On Sun, Jun 22, 2014 at 2:59 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I found only one problem - first patch introduce a new property CONNECTION_LIMIT and replace

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-06-23 Thread Tom Lane
Gurjeet Singh gurj...@singh.im writes: On Mon, Jun 23, 2014 at 11:52 AM, Tom Lane t...@sss.pgh.pa.us wrote: While this is clearly an improvement over what we had before, it's impossible to argue that it's a bug fix, and we are way past the 9.4 feature freeze deadline. In particular, packagers

[HACKERS] checking for interrupts during heap insertion

2014-06-23 Thread Robert Haas
Hi, While talking to Amit Kapila this morning, he mentioned to me that there seem to be no CHECK_FOR_INTERRUPTS() calls anywhere in heap_multi_insert() or the functions it calls. Should there be? By way of contrast, heapgetpage() has this: /* * Be sure to check for interrupts at least

Re: [HACKERS] Use a signal to trigger a memory context dump?

2014-06-23 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: I wonder if it'd make sense to allow a signal to trigger a memory context dump? I and others more than once had the need to examine memory usage on production systems and using gdb isn't always realistic. I wonder if we could install a signal

Re: [HACKERS] Minmax indexes

2014-06-23 Thread Alvaro Herrera
Heikki Linnakangas wrote: Some comments, aside from the design wrt. bounding boxes etc. : Thanks. I haven't commented on that sub-thread because I think it's possible to come up with a reasonable design that solves the issue by adding a couple of amprocs. I need to do some more thinking to

Re: [HACKERS] Atomics hardware support table supported architectures

2014-06-23 Thread Andres Freund
On 2014-06-23 12:46:11 -0400, Robert Haas wrote: On Mon, Jun 23, 2014 at 12:29 PM, Andres Freund and...@2ndquadrant.com wrote: That we have support for platforms that we haven't even documented as working (e.g. SuperH) or platforms that don't work in the realword (m32r) means that that

Re: [HACKERS] tab completion for setting search_path

2014-06-23 Thread Robert Haas
On Mon, Jun 23, 2014 at 9:10 AM, Kevin Grittner kgri...@ymail.com wrote: Andres Freund and...@2ndquadrant.com wrote: On 2014-06-22 20:02:57 -0700, Tom Lane wrote: Ian Barwick i...@2ndquadrant.com writes: On 23/06/14 00:58, Andres Freund wrote: I thought about committing this but couldn't get

Re: [HACKERS] Use a signal to trigger a memory context dump?

2014-06-23 Thread Andres Freund
On 2014-06-23 10:07:36 -0700, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: I wonder if it'd make sense to allow a signal to trigger a memory context dump? I and others more than once had the need to examine memory usage on production systems and using gdb isn't always

[HACKERS] Re: [HACKERS] please review source(SQLServer compatible)‏

2014-06-23 Thread Kevin Grittner
Vik Fearing vik.fear...@dalibo.com wrote: On 06/23/2014 04:51 PM, rohtodeveloper wrote: 1.SQL statement support    INSERT statement without INTO keyword    DELETE statement without FROM keywork Why would we want this? I'm pretty sure that the only argument for it is to ease migration of

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-06-23 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost sfr...@snowman.net writes: I'd expect a catalog table or perhaps changes to pg_class (maybe other things also..) to define what gets logged. How exactly will that work for log messages generated in contexts where we do not have

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Pavel Stehule
Hello I am sending little bit modified patch by Fujii' comments - but I am not able to fix it more - it is task for someone with better English skill then I have Regards Pavel 2014-06-23 10:02 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule

[HACKERS] Re: [HACKERS] Re: [HACKERS] please review source(SQLServer compatible)‏

2014-06-23 Thread Pavel Stehule
2014-06-23 19:22 GMT+02:00 Kevin Grittner kgri...@ymail.com: Vik Fearing vik.fear...@dalibo.com wrote: On 06/23/2014 04:51 PM, rohtodeveloper wrote: 1.SQL statement support INSERT statement without INTO keyword DELETE statement without FROM keywork Why would we want this? I'm

Re: [HACKERS] idle_in_transaction_timeout

2014-06-23 Thread Josh Berkus
On 06/22/2014 09:02 PM, Abhijit Menon-Sen wrote: I (somewhat reluctantly) agree with Kevin that idle_in_transaction_session_timeout (for FATAL) and idle_transaction_timeout (for ERROR) would work. Given that an IIT timeout has been a TODO for at least 6 years before being addressed, I'm not

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-06-23 Thread Gurjeet Singh
On Mon, Jun 23, 2014 at 12:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: Gurjeet Singh gurj...@singh.im writes: While I'd love to reduce the number of future installations without this fix in place, I respect the decision to honor project policy. At the same time, this change does not break

Re: [HACKERS] API change advice: Passing plan invalidation info from the rewriter into the planner?

2014-06-23 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: On Wed, Jun 18, 2014 at 2:18 PM, Stephen Frost sfr...@snowman.net wrote: I'm also of the opinion that this isn't strictly necessary for the initial RLS offering in PG- there's a clear way we could migrate existing users to a multi-policy system

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-06-23 Thread Abhijit Menon-Sen
At 2014-06-23 08:50:33 -0400, sfr...@snowman.net wrote: I'm not a huge fan of adding this as a contrib module I added it to the CF because we're interested in auditing functionality for 9.5, and as far as I can tell, there's nothing better available. At the moment, the contrib module has the

Re: [HACKERS] Minmax indexes

2014-06-23 Thread Heikki Linnakangas
On 06/23/2014 08:07 PM, Alvaro Herrera wrote: Heikki Linnakangas wrote: With 8k block size, that's just enough to cover the full range of 2^32-1 blocks that you'll need if you set mm_pages_per_range=1. Each regular revmap page can store about 8192/6 = 1365 item pointers, each array revmap page

Re: [HACKERS] checking for interrupts during heap insertion

2014-06-23 Thread Heikki Linnakangas
On 06/23/2014 08:07 PM, Robert Haas wrote: While talking to Amit Kapila this morning, he mentioned to me that there seem to be no CHECK_FOR_INTERRUPTS() calls anywhere in heap_multi_insert() or the functions it calls. Should there be? Haven't heard any complaints, but I guess.. By way of

Re: [HACKERS] Minmax indexes

2014-06-23 Thread Robert Haas
On Thu, Jun 19, 2014 at 12:32 PM, Greg Stark st...@mit.edu wrote: On Wed, Jun 18, 2014 at 4:51 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Implementing something is a good way to demonstrate how it would look like. But no, I don't insist on implementing every possible design whenever

  1   2   >