Re: [HACKERS] [ADMIN] Replication slots and isolation levels

On 2015-11-02 15:37:57 -0500, Robert Haas wrote: > On Fri, Oct 30, 2015 at 9:49 AM, Vladimir Borodin wrote: > > I’ve tried two ways - bare SELECT in autocommit mode and BEGIN; SELECT; > > ROLLBACK. I first described the problem in thread on pgsql-admin@ [0], there > > is

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

On 3 November 2015 at 16:41, Craig Ringer wrote: > On 3 November 2015 at 02:58, Jim Nasby wrote: >> On 11/2/15 8:36 AM, Craig Ringer wrote: >>> >>> Here's the protocol documentation discussed in the README. It's >>> asciidoc at the moment, so it

Re: [HACKERS] NOTIFY in Background Worker

On 2015-11-03 09:52:34 +0100, Simon Riggs wrote: > On 3 November 2015 at 09:35, Andres Freund wrote: > > > > > With this commit - bde39eed0cafb82bc94c40e95d96b5cf47b6f719, it is not > > possible > > > to execute Notify commands inside a parallel worker. Can't we change > > >

Re: [HACKERS] NOTIFY in Background Worker

2015-11-03 9:54 GMT+01:00 Andres Freund : > On 2015-11-03 09:52:26 +0100, Pavel Stehule wrote: > > 2015-11-03 9:35 GMT+01:00 Andres Freund : > > > > > On 2015-11-03 17:19:43 +1100, Haribabu Kommi wrote: > > > > With this commit -

Re: [HACKERS] NOTIFY in Background Worker

On 2015-11-03 09:52:26 +0100, Pavel Stehule wrote: > 2015-11-03 9:35 GMT+01:00 Andres Freund : > > > On 2015-11-03 17:19:43 +1100, Haribabu Kommi wrote: > > > With this commit - bde39eed0cafb82bc94c40e95d96b5cf47b6f719, it is not > > possible > > > to execute Notify commands

Re: [HACKERS] NOTIFY in Background Worker

On 2015-11-03 17:19:43 +1100, Haribabu Kommi wrote: > On Sat, Aug 29, 2015 at 12:55 PM, Thomas Munro > wrote: > > On Sat, Aug 29, 2015 at 9:03 AM, Thomas Munro > > wrote: > > This made me wonder what happens if a background worker

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

On 3 November 2015 at 02:58, Jim Nasby wrote: > On 11/2/15 8:36 AM, Craig Ringer wrote: >> >> Here's the protocol documentation discussed in the README. It's >> asciidoc at the moment, so it can be formatted into something with >> readable tables. > > > Is this by chance

Re: [HACKERS] NOTIFY in Background Worker

2015-11-03 9:35 GMT+01:00 Andres Freund : > On 2015-11-03 17:19:43 +1100, Haribabu Kommi wrote: > > On Sat, Aug 29, 2015 at 12:55 PM, Thomas Munro > > wrote: > > > On Sat, Aug 29, 2015 at 9:03 AM, Thomas Munro > > >

Re: [HACKERS] NOTIFY in Background Worker

On 3 November 2015 at 09:35, Andres Freund wrote: > > With this commit - bde39eed0cafb82bc94c40e95d96b5cf47b6f719, it is not > possible > > to execute Notify commands inside a parallel worker. Can't we change > > it as disable both listen and notify commands inside a

[HACKERS] RFC/WIP: adding new configuration options to TOAST

Looking for feedback to see if anyone sees any issues or has any suggestions on what I'm doing. The attached patch alters 3 things with regard to TOAST behavior: 1) Add a GUC target_compression_ratio: When attempting to compress a datum in the TOAST code, only stored the compressed version

Re: [HACKERS] proposal: multiple psql option -c

2015-11-03 4:16 GMT+01:00 Robert Haas : > On Sat, Oct 31, 2015 at 2:50 PM, Pavel Stehule > wrote: > > fixed patch attached > > The documentation included in this patch doesn't really make it clear > why -g is different from or better than -c. > I

Re: [HACKERS] Parallel Seq Scan

On Fri, Oct 23, 2015 at 4:41 PM, Amit Kapila wrote: > > On Fri, Oct 23, 2015 at 10:33 AM, Robert Haas wrote: Please find the rebased partial seq scan patch attached with this mail. Robert suggested me off list that we should once try to see if we

Re: [HACKERS] September 2015 Commitfest

On Mon, Nov 2, 2015 at 9:35 PM, Michael Paquier wrote: > And now CF begins officially. The axe has fallen as promised 26 hours after. Seeing no volunteers around, I can take the CFM hat for November's CF. Any objections/complaints/remarks? -- Michael -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

> On Thu, Oct 29, 2015 at 6:05 AM, Kouhei Kaigai wrote: > > In this case, the EPQ slot to store the joined tuple is still > > a challenge to be solved. > > > > Is it possible to use one or any of EPQ slots that are setup for > > base relations but represented by

Re: [HACKERS] fortnight interval support

On Wed, Oct 28, 2015 at 4:17 AM, Gavin Flower wrote: > You trying to get PostgreSQL banned in France??? :-) > > When I was learning French many years ago, I was told that the French > consider their fortnight to be 15 days!!! Confirmed. I would translate fornight as 'quinzaine' to French.

Re: [HACKERS] WIP: Rework access method interface

On Tue, Nov 3, 2015 at 2:36 AM, Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >> I'm kind of inclined to just let the verifiers read the catalogs for > >> themselves. AFAICS, a loop around the results of SearchSysCacheList > >> is

Re: [HACKERS] Re: Why not to use 'pg_ctl start -D ../data' to register posgtresql windows service

On Tue, Nov 3, 2015 at 10:46 AM, YuanyuanLiu wrote: >I really learned a lot from you, and thank you! By the way, in the future you may want to ask general questions to pgsql-general, pgsql-hackers is where new features are being discussed and where technical discussions happen :) -- Michael

Re: [HACKERS] ALTER SYSTEM vs symlink

On Mon, Nov 2, 2015 at 10:40 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Nov 2, 2015 at 10:13 PM, Amit Kapila wrote: >>> I think that is the sensible way to deal with this and any other such >>> parameters. We already

Re: [HACKERS] OS X El Capitan and DYLD_LIBRARY_PATH

Hi, On 2015-10-14 11:24:27 -0400, Peter Eisentraut wrote: > The new OS X release 10.11 "El Capitan" has a "security" feature that > prevents passing DYLD_LIBRARY_PATH to child processes. Somehow, that > variable is stripped from the environment. Two colleagues of mine at Citus just hit that. >

Re: [HACKERS] proposal: PL/Pythonu - function ereport

2015-11-02 17:01 GMT+01:00 Catalin Iacob : > Hello, > > Here's a detailed review: > > 1. in PLy_spi_error__init__ you need to check kw for NULL before doing > PyDict_Size(kw) otherwise for plpy.SPIError() you get Bad internal > call because PyDict_Size expects a real

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

On 03/11/2015 04:06, Robert Haas wrote: > On Sat, Oct 31, 2015 at 2:25 PM, Julien Rouhaud > wrote: >> I just reviewed your patch, everything looks fine for me. Maybe some >> minor cosmetic changes could be made to avoid declaring too many vars, >> but I think a

Re: [HACKERS] Patent warning about the Greenplum source code

On 3 November 2015 at 08:12, Bruce Momjian wrote: > I am posting this at the request of Josh Berkus, who wanted > clarification on some issues. FYI, I have been speaking in this thread > as a community member, and not as a member of core, and made some > mistakes in my

Re: [HACKERS] [ADMIN] Replication slots and isolation levels

> 3 нояб. 2015 г., в 11:38, Andres Freund написал(а): > > On 2015-11-02 15:37:57 -0500, Robert Haas wrote: >> On Fri, Oct 30, 2015 at 9:49 AM, Vladimir Borodin wrote: >>> I’ve tried two ways - bare SELECT in autocommit mode and BEGIN; SELECT; >>> ROLLBACK.

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

On Mon, Nov 2, 2015 at 12:58 AM, Jeff Janes wrote: > If a transaction holding locks aborts on an otherwise idle server, perhaps it > will take a very long time for a log-shipping standby to realize this. But I > have hard time believing that anyone who cares about that

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

On 2015-11-03 10:23:35 -0500, Robert Haas wrote: > On Mon, Nov 2, 2015 at 12:58 AM, Jeff Janes wrote: > > If a transaction holding locks aborts on an otherwise idle server, perhaps > > it will take a very long time for a log-shipping standby to realize this. > > But I

Re: [HACKERS] Documentation fix for psql

Albe Laurenz writes: > The psql documentation calls the \pset options unicode_*_style > when in reality they are called unicode_*_linestyle. > This should be backpatched to 9.5. So I see. Looks like there are a few other grammatical issues in that patch too ... will

Re: [HACKERS] Patch: Implement failover on libpq connect level.

On Mon, Nov 2, 2015 at 12:15 PM, Peter Eisentraut wrote: > On 10/30/15 9:26 AM, Robert Haas wrote: >> That's true, but doesn't allowing every parameter to be multiply >> specified greatly increase the implementation complexity for a pretty >> marginal benefit? > > Well, the way I

Re: [HACKERS] Freeze avoidance of very large table.

On Mon, Nov 2, 2015 at 10:33 PM, Amit Kapila wrote: > On Tue, Nov 3, 2015 at 5:04 AM, Robert Haas wrote: >> >> On Sat, Oct 31, 2015 at 1:32 AM, Amit Kapila >> wrote: >> > >> > What is your main worry about changing the

Re: [HACKERS] Dangling Client Backend Process

On Fri, Oct 30, 2015 at 11:03 AM, Andres Freund wrote: > On 2015-10-30 10:57:45 -0400, Tom Lane wrote: >> Andres Freund writes: >> > adding a parseInput(conn) into the loop yields the expected >> > FATAL: 57P01: terminating connection due to unexpected

Re: [HACKERS] September 2015 Commitfest

On Tue, Nov 3, 2015 at 8:12 AM, Michael Paquier wrote: > On Mon, Nov 2, 2015 at 9:35 PM, Michael Paquier wrote: >> And now CF begins officially. The axe has fallen as promised 26 hours after. > > Seeing no volunteers around, I can take the CFM hat for November's CF. >

Re: [HACKERS] Minor clarifying changes to abbreviated key abort code comments

On Tue, Nov 3, 2015 at 5:47 AM, Robert Haas wrote: > This comment doesn't make sense to me: > > +* (TSS_BUILDRUNS state prevents control reaching here in any > +* case). > > Unless I'm missing something, that's not actually true. It is true.

[HACKERS] Bitmap index scans use of filters on available columns

create table f as select (random()*100)::int as x, md5(random()::text) as y from generate_series(1,100); create index on f (x, y); analyze verbose f; --dont vacuum explain select * from f where x=5 and y like '%abc%'; QUERY PLAN

Re: [HACKERS] [patch] to build docs on Mac OS X El Capitan with MacPorts

I should add that this was required for a postgres git build using MacPorts to supply dependencies and not a build of postgres using MacPorts. Neil > On Nov 3, 2015, at 8:11 AM, Robert Haas wrote: > > On Sun, Nov 1, 2015 at 8:41 AM, Neil Tiffin

Re: [HACKERS] fortnight interval support

On Tue, Nov 3, 2015 at 8:31 AM, Alvaro Herrera wrote: > (WRT the reference to Jane Austen and "Se'ennight" for "week", it occurs > to me that fortnight is a similar contraction for "forteen night".) Well, clearly we also need enquië for the elves of Arda and tenday for

Re: [HACKERS] Getting sorted data from foreign server

On Fri, Oct 30, 2015 at 6:19 AM, Ashutosh Bapat wrote: > If there is a collate clause in the ORDER BY, the server crashes with > assertion > +Assert(loc_cxt.state == FDW_COLLATE_NONE || > +loc_cxt.state == FDW_COLLATE_SAFE); > > > The assertion is

Re: [HACKERS] Minor clarifying changes to abbreviated key abort code comments

On Tue, Nov 3, 2015 at 11:15 AM, Robert Haas wrote: > OK, I see. Fixing comments in the back-branches is not always a > productive use of time, and in general I might like it if you pushed > for such things less frequently. But I've done it anyway in this > instance. I

Re: [HACKERS] Minor clarifying changes to abbreviated key abort code comments

On Tue, Nov 3, 2015 at 12:36 PM, Peter Geoghegan wrote: > On Tue, Nov 3, 2015 at 5:47 AM, Robert Haas wrote: >> This comment doesn't make sense to me: >> >> +* (TSS_BUILDRUNS state prevents control reaching here in any >> +*

Re: [HACKERS] Minor clarifying changes to abbreviated key abort code comments

On Tue, Nov 3, 2015 at 2:19 PM, Peter Geoghegan wrote: > On Tue, Nov 3, 2015 at 11:15 AM, Robert Haas wrote: >> OK, I see. Fixing comments in the back-branches is not always a >> productive use of time, and in general I might like it if you pushed >> for

Re: [HACKERS] Freeze avoidance of very large table.

On Tue, Nov 3, 2015 at 12:33 PM, Amit Kapila wrote: > On Tue, Nov 3, 2015 at 5:04 AM, Robert Haas wrote: >> >> On Sat, Oct 31, 2015 at 1:32 AM, Amit Kapila >> wrote: >> > >> > What is your main worry about changing the

Re: [HACKERS] [PATCH] postgres_fdw extension support

Paul Ramsey writes: > [ 20151006b_postgres_fdw_extensions.patch ] Starting to look through this now. I'm dubious of the decision to have ExtractExtensionList throw errors if there are un-installed extensions mentioned in the FDW options. Wouldn't it be a lot more

Re: [HACKERS] proposal: PL/Pythonu - function ereport

2015-11-03 17:13 GMT+01:00 Catalin Iacob : > On Tue, Nov 3, 2015 at 12:49 PM, Pavel Stehule > wrote: > >> 1. in PLy_spi_error__init__ you need to check kw for NULL before doing > >> PyDict_Size(kw) otherwise for plpy.SPIError() you get Bad

Re: [HACKERS] [PATCH] postgres_fdw extension support

On Tue, Nov 3, 2015 at 2:57 PM, Tom Lane wrote: > Paul Ramsey writes: >> [ 20151006b_postgres_fdw_extensions.patch ] > > Starting to look through this now. I'm dubious of the decision to have > ExtractExtensionList throw errors if there are

Re: [HACKERS] fortnight interval support

On Wed, Nov 4, 2015 at 2:31 AM, Robert Haas wrote: > On Tue, Nov 3, 2015 at 8:31 AM, Alvaro Herrera > wrote: >> (WRT the reference to Jane Austen and "Se'ennight" for "week", it occurs >> to me that fortnight is a similar contraction for "forteen

Re: [HACKERS] [PATCH] postgres_fdw extension support

Robert Haas writes: > On Tue, Nov 3, 2015 at 2:57 PM, Tom Lane wrote: >> Paul Ramsey writes: >>> [ 20151006b_postgres_fdw_extensions.patch ] >> There might be a case for raising a WARNING during >> postgres_fdw_validator(),

Re: [HACKERS] [PATCH] postgres_fdw extension support

Thanks everyone for the held and feedback on this patch! --  Paul Ramsey http://cleverelephant.ca http://postgis.net On November 3, 2015 at 3:47:37 PM, Tom Lane (t...@sss.pgh.pa.us) wrote: Robert Haas writes: > On Tue, Nov 3, 2015 at 2:57 PM, Tom Lane

Re: [HACKERS] pg_stat_statements query jumbling question

On Sat, Oct 31, 2015 at 10:03 AM, Julien Rouhaud wrote: >> At least, I would like to give some options to be chosen by the >> user. Is it possible and/or reasonable? >> > > I'm also rather sceptical about this change. Is anyone willing to argue for it, apart from

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

On November 4, 2015 12:37:02 AM GMT+01:00, Michael Paquier wrote: >On Wed, Nov 4, 2015 at 12:43 AM, Andres Freund >wrote: >> On 2015-11-03 10:23:35 -0500, Robert Haas wrote: >>> On Mon, Nov 2, 2015 at 12:58 AM, Jeff Janes

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

On 3 November 2015 at 23:04, Bill Moran wrote: > > Looking for feedback to see if anyone sees any issues or has any > suggestions on what I'm doing. The attached patch alters 3 things > with regard to TOAST behavior: COMPRESSION_TEST_SIZE (2) seems useful. The other

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

On Wed, Nov 4, 2015 at 12:43 AM, Andres Freund wrote: > On 2015-11-03 10:23:35 -0500, Robert Haas wrote: >> On Mon, Nov 2, 2015 at 12:58 AM, Jeff Janes wrote: >> > If a transaction holding locks aborts on an otherwise idle server, perhaps >> > it will

Re: [HACKERS] PoC: Partial sort

On Tue, Oct 20, 2015 at 4:17 AM, Alexander Korotkov wrote: > Planner regression is fixed in the attached version of patch. It appears > that get_cheapest_fractional_path_for_pathkeys() behaved wrong when no > ordering is required. I took a look at this. My remarks are not

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

On Tue, Nov 3, 2015 at 5:21 PM, Craig Ringer wrote: > On 3 November 2015 at 23:04, Bill Moran wrote: >> >> Looking for feedback to see if anyone sees any issues or has any >> suggestions on what I'm doing. The attached patch alters 3 things >>

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

On Tue, 3 Nov 2015 18:34:39 -0800 Jeff Janes wrote: > On Tue, Nov 3, 2015 at 5:21 PM, Craig Ringer wrote: > > On 3 November 2015 at 23:04, Bill Moran wrote: > >> > >> Looking for feedback to see if anyone sees any issues or

Re: [HACKERS] [PATCH] postgres_fdw extension support

I wrote: > I left out the proposed regression tests because they fail in "make > installcheck" mode, unless you've previously built and installed cube > and seg, which seems like an unacceptable requirement to me. I don't > think that leaving the code untested is a good final answer, of course. >

[HACKERS] Re: Why not to use 'pg_ctl start -D ../data' to register posgtresql windows service

Ok, Michael! Thanks for your kindly remind! Regards! Liu Yuanyuan -- View this message in context: http://postgresql.nabble.com/Why-not-to-use-pg-ctl-start-D-data-to-register-posgtresql-windows-service-tp5872282p5872631.html Sent from the PostgreSQL - hackers mailing list archive at

Re: [HACKERS] [PATCH] postgres_fdw extension support

On Wed, Nov 4, 2015 at 2:23 PM, Tom Lane wrote: > Michael Paquier writes: >> That's still strange to have a dummy object in >> postgres_fdw.so just for testing purposes. > > We could drop the extra functions at the end of the test, but I don't > see

Re: [HACKERS] Getting sorted data from foreign server

On Tue, Nov 3, 2015 at 11:35 PM, Robert Haas wrote: > On Fri, Oct 30, 2015 at 6:19 AM, Ashutosh Bapat > wrote: > > If there is a collate clause in the ORDER BY, the server crashes with > > assertion > > +Assert(loc_cxt.state ==

Re: [HACKERS] Trivial heap_finish_speculative() error message inaccuracy

Peter Geoghegan writes: > While auditing the access method code associated with ON CONFLICT DO > UPDATE's speculative insertion infrastructure, I noticed an > inaccuracy. > Attached patch fixes the trivial inaccuracy in a defensive elog() > call. Quite simply, this call site

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

On Tue, Nov 3, 2015 at 7:56 PM, Pavel Stehule wrote: > > > 2015-11-03 3:42 GMT+01:00 Amit Kapila : > >> On Mon, Nov 2, 2015 at 10:45 PM, Pavel Stehule >> wrote: >>> >>> >>> It is 100% true. But the users can do strange

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

On 4 November 2015 at 10:58, Bill Moran wrote: > On Tue, 3 Nov 2015 18:34:39 -0800 > Jeff Janes wrote: > >> On Tue, Nov 3, 2015 at 5:21 PM, Craig Ringer wrote: >> > On 3 November 2015 at 23:04, Bill Moran

Re: [HACKERS] [PATCH] postgres_fdw extension support

On Wed, Nov 4, 2015 at 12:38 PM, Tom Lane wrote: > I wrote: >> I left out the proposed regression tests because they fail in "make >> installcheck" mode, unless you've previously built and installed cube >> and seg, which seems like an unacceptable requirement to me. I don't >> think that leaving

[HACKERS] Trivial heap_finish_speculative() error message inaccuracy

While auditing the access method code associated with ON CONFLICT DO UPDATE's speculative insertion infrastructure, I noticed an inaccuracy. Attached patch fixes the trivial inaccuracy in a defensive elog() call. Quite simply, this call site didn't get the memo when we renamed that function

[HACKERS] Valgrind and shared_buffers (Was: Restore-reliability mode)

On Mon, Jul 27, 2015 at 7:12 AM, Alvaro Herrera wrote: > I only tried a few tests, for lack of time, and it didn't produce any. > (To verify that the whole thing was working properly, I reduced the > range of memory made available during PinBuffer and that resulted in a

Re: [HACKERS] COPY FREEZE and PD_ALL_VISIBLE

On Tue, Nov 3, 2015 at 8:07 PM, Simon Riggs wrote: > > On 3 November 2015 at 15:23, Amit Kapila wrote: >> >> On Fri, Oct 23, 2015 at 6:29 AM, Simon Riggs wrote: >>> >>> Easy enough to do it at the end of the COPY FREEZE in

Re: [HACKERS] Freeze avoidance of very large table.

On Wed, Nov 4, 2015 at 4:45 AM, Masahiko Sawada wrote: > > On Tue, Nov 3, 2015 at 12:33 PM, Amit Kapila wrote: > > On Tue, Nov 3, 2015 at 5:04 AM, Robert Haas wrote: > >> > >> On Sat, Oct 31, 2015 at 1:32 AM, Amit Kapila

Re: [HACKERS] [PATCH] postgres_fdw extension support

Michael Paquier writes: > On Wed, Nov 4, 2015 at 12:38 PM, Tom Lane wrote: >> I had a possibly better idea: instead of manufacturing an empty extension >> with a direct INSERT, hack on the one extension that we know for sure >> will be installed, namely postgres_fdw

Re: [HACKERS] proposal: PL/Pythonu - function ereport

Sorry, you're right, I didn't notice the x = plpy.SPIError() test. I did notice that you included the kw != NULL, I was explaining why it really is needed even though it *seems* the code also works without it. There's just the doc part left then. -- Sent via pgsql-hackers mailing list

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

On 11/3/15 8:34 PM, Jeff Janes wrote: I currently have a table with one column which has a median width of 500 bytes, a 90th percentile of 650 bytes, and makes up 75% of the table's size, and the column is rarely used, while the table itself is frequently seq scanned. I'd very much like to

Re: [HACKERS] Trivial heap_finish_speculative() error message inaccuracy

On Tue, Nov 3, 2015 at 7:10 PM, Tom Lane wrote: > This seems like a fine teaching moment in which to point out our > longstanding error message style guideline that says not to put > names of C functions into error messages in the first place. I don't ordinarily do that, of

Re: [HACKERS] ParallelContexts can get confused about which worker is which

On Tue, Nov 3, 2015 at 8:25 PM, Robert Haas wrote: > > On Mon, Nov 2, 2015 at 4:13 PM, Robert Haas wrote: > > On Sun, Nov 1, 2015 at 1:11 AM, Amit Kapila wrote: > >> If we are going to add a new parameter to BackgroundWorker

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

On Tue, Nov 3, 2015 at 7:53 PM, Merlin Moncure wrote: > > On Mon, Nov 2, 2015 at 8:42 PM, Amit Kapila wrote: > > > > What exactly do we want to define session_idle_timeout? Some > > possibilities: > > a. Reset the session related variables like

Re: [HACKERS] September 2015 Commitfest

On Wed, Nov 4, 2015 at 2:38 AM, Robert Haas wrote: > On Tue, Nov 3, 2015 at 8:12 AM, Michael Paquier > wrote: >> On Mon, Nov 2, 2015 at 9:35 PM, Michael Paquier wrote: >>> And now CF begins officially. The axe has fallen as promised 26 hours

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

On Wed, Nov 4, 2015 at 12:43 AM, Andres Freund wrote: > On 2015-11-03 10:23:35 -0500, Robert Haas wrote: >> On Mon, Nov 2, 2015 at 12:58 AM, Jeff Janes wrote: >> > If a transaction holding locks aborts on an otherwise idle server, perhaps >> > it will

Re: [HACKERS] extend pgbench expressions with functions

Hello, sorry for the silence. At Fri, 18 Sep 2015 20:35:48 +0200 (CEST), Fabien COELHO wrote in > > -1. double is an inexact type, whereas integer is an exact type. > > Sure. I already argue on that very line. Agreed. > > The

Re: [HACKERS] Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

On Wed, Nov 4, 2015 at 8:39 AM, Andres Freund wrote: > On November 4, 2015 12:37:02 AM GMT+01:00, Michael Paquier wrote: >>On a completely idle system, I don't think we should log any standby >>records. This is what ~9.3 does. > > Are you sure? I think it'll around

Re: [HACKERS] ATT_FOREIGN_TABLE and ATWrongRelkindError()

On 2015/10/28 20:10, Robert Haas wrote: On Fri, Oct 23, 2015 at 11:51 AM, Etsuro Fujita wrote: BTW, I found an incorrect error message in ATWrongRelkindError. Attached is a patch for fixing the message. Committed and back-patched to 9.3. Thanks! Best regards,

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

On 2015/10/28 6:04, Robert Haas wrote: On Tue, Oct 20, 2015 at 12:39 PM, Etsuro Fujita wrote: Sorry, my explanation was not correct. (Needed to take in caffeine.) What I'm concerned about is the following: SELECT * FROM localtab JOIN (ft1 LEFT JOIN ft2 ON ft1.x =

Re: [HACKERS] COPY FREEZE and PD_ALL_VISIBLE

On 3 November 2015 at 15:23, Amit Kapila wrote: > On Fri, Oct 23, 2015 at 6:29 AM, Simon Riggs > wrote: > >> On 21 October 2015 at 13:31, Jeff Janes wrote: >> >> Index-only scans will visit the heap for each tuple until the

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

On Mon, Nov 2, 2015 at 1:23 PM, Jim Nasby wrote: > On 11/2/15 11:15 AM, Pavel Stehule wrote: >> >> I have not strong idea about how to solve it well - maybe introduce >> transaction_idle_timeout and session_idle_timeout? > > > Yes, please. This is a very common problem.

Re: [HACKERS] ParallelContexts can get confused about which worker is which

On Mon, Nov 2, 2015 at 4:13 PM, Robert Haas wrote: > On Sun, Nov 1, 2015 at 1:11 AM, Amit Kapila wrote: >> If we are going to add a new parameter to BackgroundWorker structure, >> then the same needs to be updated in docs [1] as well. > > Right,

Re: [HACKERS] shm_mq fix for non-blocking mode

On Thu, Oct 22, 2015 at 10:00 PM, Robert Haas wrote: >> ...and so I've committed it and back-patched to 9.4. > > Sigh. This was buggy; I have no idea how it survived my earlier testing. > > I will go fix it. Sorry. Gah! That, too, turned out to be buggy, although in a

Re: [HACKERS] fortnight interval support

Michael Paquier wrote: > On Wed, Oct 28, 2015 at 4:17 AM, Gavin Flower wrote: > > You trying to get PostgreSQL banned in France??? :-) > > > > When I was learning French many years ago, I was told that the French > > consider their fortnight to be 15 days!!! > > Confirmed. I would translate

Re: [HACKERS] Minor clarifying changes to abbreviated key abort code comments

On Sat, Oct 31, 2015 at 3:42 PM, Peter Geoghegan wrote: > Attached are a couple of patches that only change code comments. The > first (abort abbreviation) patch is recommended for backpatch to 9.5. > The second is a tiny tweak. This comment doesn't make sense to me: +

Re: [HACKERS] eXtensible Transaction Manager API

On 2 November 2015 at 13:24, Konstantin Knizhnik wrote: > PostgreSQL assumes that top-level xid commit is atomic, along with all of > its subtransactions. So the API having access to only Get/Set at the xid > level would not work. We would need

Re: [HACKERS] proposal: PL/Pythonu - function ereport

On Tue, Nov 3, 2015 at 12:49 PM, Pavel Stehule wrote: >> 1. in PLy_spi_error__init__ you need to check kw for NULL before doing >> PyDict_Size(kw) otherwise for plpy.SPIError() you get Bad internal >> call because PyDict_Size expects a real dictionary not NULL > > >

Re: [HACKERS] COPY FREEZE and PD_ALL_VISIBLE

On Fri, Oct 23, 2015 at 6:29 AM, Simon Riggs wrote: > On 21 October 2015 at 13:31, Jeff Janes wrote: > > Index-only scans will visit the heap for each tuple until the first VACUUM >> is done. >> >> The first vacuum will read the entire table, but not

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

On Mon, Nov 2, 2015 at 8:42 PM, Amit Kapila wrote: > On Mon, Nov 2, 2015 at 10:45 PM, Pavel Stehule > wrote: >> >> >> It is 100% true. But the users can do strange things. If we solve idle >> transactions and not idle session, then they are able

Re: [HACKERS] COPY FREEZE and PD_ALL_VISIBLE

On Fri, Oct 23, 2015 at 2:46 AM, Robert Haas wrote: > > On Wed, Oct 21, 2015 at 1:31 PM, Jeff Janes wrote: > > It turns out it was pretty easy to set PD_ALL_VISIBLE on the new pages, > > since the code in hio that requests the relation to be extended

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

2015-11-03 3:42 GMT+01:00 Amit Kapila : > On Mon, Nov 2, 2015 at 10:45 PM, Pavel Stehule > wrote: >> >> >> It is 100% true. But the users can do strange things. If we solve idle >> transactions and not idle session, then they are able to increase

[HACKERS] Documentation fix for psql

The psql documentation calls the \pset options unicode_*_style when in reality they are called unicode_*_linestyle. This should be backpatched to 9.5. Yours, Laurenz Albe 0001-Fix-documentation-for-pset-unicode_-_linestyle.patch Description:

Re: [HACKERS] [patch] to build docs on Mac OS X El Capitan with MacPorts

On Sun, Nov 1, 2015 at 8:41 AM, Neil Tiffin wrote: > The attached patch was required to get the docs to build on Mac OS X 10.11.1 > (15B42) with MacPorts 2.3.4. After changing docbook.m4 ‘autoreconf’ has to > be run. This patch does not include the new version of