Re: [HACKERS] pg_basebackup --progress output for batch execution

2017-11-10 Thread Arthur Zakirov
f I'm not mistaken: > The _isatty function determines whether fd is associated with a character > device (a terminal, console, printer, or serial port). 1 - https://msdn.microsoft.com/en-us/library/f4s0ddew(v=vs.140).aspx -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com

Re: [HACKERS] pg_basebackup --progress output for batch execution

2017-11-09 Thread Arthur Zakirov
ing for background process to finish streaming ... pg_basebackup: base backup completed -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Generic type subscripting

2017-11-08 Thread Arthur Zakirov
d idea, but it is not critical, it is just complaint. After your fixing I think we should wait for opinion of senior community members and mark the patch as 'Ready for Commiter'. Maybe I will do more tests and try to implement subscripting to another type. -- Arthur Zakirov Postgres Professional:

Re: [HACKERS] [PATCH] Generic type subscripting

2017-10-31 Thread Arthur Zakirov
there necessity to use newNode() instead using makeNode(). The previous code was shorter. There is no changes in execnodes.h except removed line. So I think execnodes.h could be removed from the patch. > > I'm going to make few more improvements, but in the meantime I hope we c

Re: [HACKERS] [PATCH] Generic type subscripting

2017-09-20 Thread Arthur Zakirov
E requires a modification to add or drop subscripting from existing type (I am not sure that it should be done by this patch, maybe better to do it by a separate patch) -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing lis

Re: [HACKERS] [PATCH] Generic type subscripting

2017-09-20 Thread Arthur Zakirov
t insist on CREATE SUBSCRIPTING command. The patch brings important functionality and I don't want to be a person who blocked it from commiting. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@

Re: [HACKERS] [PATCH] Generic type subscripting

2017-09-19 Thread Arthur Zakirov
endency between pg_type and > pg_subscripting, dependency between pg_type and pg_proc. Here was a typo from me. Last entry is dependency between pg_subscripting and pg_proc. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsq

Re: [HACKERS] [PATCH] Generic type subscripting

2017-09-18 Thread Arthur Zakirov
( INITFUNC = subscripting_init_func FETCHFUNC = subscripting_fetch_func ASSIGNFUNC = subscripting_assign_func ) DROP SUBSCRIPTING FOR type_name -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@po

Re: [HACKERS] [PATCH] Generic type subscripting

2017-09-17 Thread Arthur Zakirov
init_func FETCHFUNC = subscripting_fetch_func ASSIGNFUNC = subscripting_assign_func DROP SUBSCRIPTING FOR type_name But I am not if the community will like such syntax. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hacker

Re: [HACKERS] [PATCH] Generic type subscripting

2017-09-16 Thread Arthur Zakirov
over user can implement subscripting to its own type without using 'DEPENDS ON' syntax. And he will face the bug mentioned above too. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] [PATCH] Generic type subscripting

2017-09-09 Thread Arthur Zakirov
ernal); 4 - and we get the error: =# select data[0] from test_subscripting; ERROR: function 0x55deb7911bfd returned NULL But of course it is only my opinion and I could be wrong. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-ha

Re: [HACKERS] [PROPOSAL] Text search configuration extension

2017-08-21 Thread Arthur Zakirov
tsquery('en_de_search', 'hause') q; ?column? | d |q --+--+-- t| 'begleiten':9 'hausen':8 'hund':2 'jedoch':5 | 'hausen' (1 row) This configuration is useful when a query la

Re: [HACKERS] Regressions failures with libxml2 on ArchLinux

2017-08-14 Thread Arthur Zakirov
b56f80e-1 on my Archlinux. All regression tests passed without any fails. I ran check and installcheck commands. Of course my environment is not completely match to your environment. It could be a reason why we have different results. -- Arthur Zakirov Postgres Professional: http://www.postgrespr

Re: [HACKERS] List of hostaddrs not supported

2017-07-10 Thread Arthur Zakirov
parison between pointer and zero character constant [-Wpointer-compare] > conn->connhost[i].host != NULL && conn->connhost[i].host != '\0') -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company

Re: [HACKERS] [PATCH] Generic type subscripting

2017-06-30 Thread Arthur Zakirov
info = eval_finfo; > + scratch->d.sbsref.nested_finfo = nested_finfo; > + Also I have noticed that assigning eval_finfo and nested_finfo after every time eval step is pushed is unnecessary in ExecInitSubscriptingRef() function. We need them only for EEOP_SBSREF_OLD, EEOP_SBSREF_ASSIG

Re: [HACKERS] Extracting GiST index structure stats?

2017-04-17 Thread Arthur Zakirov
://www.sai.msu.su/~megera/wiki/Gevel -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-04-07 Thread Arthur Zakirov
resGetForeignJoinPaths. See foreign_join_ok.) Oh, I see. I've missed that condition. Marked the patch as "Ready for Commiter". But the patch should be commited only after the patch [1]. 1. https://www.postgresql.org/message-id/424933d7-d6bb-4b8f-4e44-1fea212af083%40lab.ntt.co.jp -- Arth

Re: [HACKERS] [PATCH] Generic type subscripting

2017-04-06 Thread Arthur Zakirov
On 05.04.2017 16:06, Arthur Zakirov wrote: I'd like to focus on "refevalfunc" and "refnestedfunc" fields as I did earlier. I think using Oid type for them is a bad approach. "..._fetch" and "..._assign" functions in catalog is unnecessary movement to me.

Re: [HACKERS] [PATCH] Generic type subscripting

2017-04-05 Thread Arthur Zakirov
On 05.04.2017 16:06, Arthur Zakirov wrote: On 04.04.2017 15:41, Dmitry Dolgov wrote: Sorry for late reply. Here is a new version of the patch, I rebased it and fixed those issues you've mentioned (pretty nasty problems, thank you for noticing). Thank you! I've looked at the patch again

Re: [HACKERS] [PATCH] Generic type subscripting

2017-04-05 Thread Arthur Zakirov
f->refcontainertype)), parser_errposition(pstate, 0))); PG_RETURN_POINTER(node); } Also I was wondering do we need this code in array_subscript_parse()? I haven't understood the purpose of it. If it is ne

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-04-04 Thread Arthur Zakirov
_JOIN_REL() and IS_UPPER_REL() were added. And the patch is applied with errors. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Generic type subscripting

2017-04-01 Thread Arthur Zakirov
eans is there slices or not. I think it can improve readability of the code. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-03-31 Thread Arthur Zakirov
created on top of [1]. Are you planning to review this patch? Thanks, Yes, I wanted to review the patch. But there was a lack of time this week. I marked myself as reviewer in the commitfest app. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company

Re: [HACKERS] [PATCH] Generic type subscripting

2017-03-30 Thread Arthur Zakirov
2017-03-31 5:32 GMT+03:00 Dmitry Dolgov <9erthali...@gmail.com>: > On 30 March 2017 at 19:36, Arthur Zakirov <a.zaki...@postgrespro.ru> wrote: >> >> The last point is about the tutorial. As Tom pointed it is not useful when >> the tutorial doesn't execute. It hap

Re: [HACKERS] [PATCH] Generic type subscripting

2017-03-30 Thread Arthur Zakirov
On 29.03.2017 20:14, Arthur Zakirov wrote: I wanted to implement subscripting for ltree or hstore extensions. Subscripting for ltree looks more interesting. Especially with slicing. But I haven't done it yet. I hope that I will implement it tomorrow. ltree - I've implemented fetching

Re: [HACKERS] [PATCH] Generic type subscripting

2017-03-29 Thread Arthur Zakirov
lement it tomorrow. 1. https://www.postgresql.org/message-id/CAKNkYnz_WWkzzxyFx934N%3DEp47CAFju-Rk-sGeZo0ui8QdrGmw%40mail.gmail.com -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Generic type subscripting

2017-03-28 Thread Arthur Zakirov
oint (they're already separated at the time of evaluation, and besides the evaluation code fetch & assign are handled almost identically). Your patch reverts commits from 25-26 march. And therefore contains 15000 lines. I think the patch needs rebasing. -- Arthur Zakirov Postgres Prof

Re: [HACKERS] [PATCH] Generic type subscripting

2017-03-24 Thread Arthur Zakirov
e seen the previous versions of the patch from previous commitfest. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/ma

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

2017-03-20 Thread Arthur Zakirov
have a way to drop slots. -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-03-16 Thread Arthur Zakirov
Hello, 2017-02-27 12:40 GMT+03:00 Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>: > Hi, > > I'd like to propose to support parameterized foreign joins. Attached is a > patch for that, which has been created on top of [1]. > Can you rebase the patch? It is not applied now

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-03-15 Thread Arthur Zakirov
rver" to "foreign server" in case of user > mapping? The doc changes didn't compile with error > "osx:ref/create_user_mapping.sgml:52:15:E: document type does not > allow element "VARLISTENTRY" here; assuming missing "VARIABLELIST" Indeed! Mi