reproduce but you
>> can see pretty clearly a few lines above in auth.c that it can be
>> NULL. (I'm surprised Coverity didn't complain about that. Maybe it
>> can't see this code due to macros.)
committed and backpatched
--
Peter Eisentraut http:/
On 11/10/17 10:29, Fabien COELHO wrote:
> Or basically all is fine, I'm just nitpicking for nothing, shame on me.
>
> As I said, I rather like more precise declarations.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Suppo
st char * case, but
not the char ** -> const char ** case.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to you
LWLockTrancheArray = (const char **) // twice
These are not cases of "cheating". This is just the return value of a
memory allocation function being cast from void * to the appropriate
result type. That is an orthogonal style decision that I have
maintained in these cases.
--
On 11/8/17 11:11, Merlin Moncure wrote:
> On Wed, Nov 8, 2017 at 9:13 AM, Peter Eisentraut
> wrote:
>> I have already submitted a separate patch that addresses these questions.
>
> Maybe I'm obtuse, but I'm not seeing it? In very interested in the
> general approac
hashsearch.c uses FALSE in some comments.
> - In execExpr.c, ExecCheck mentions TRUE.
That one is an SQL TRUE, so I left it.
> - AggStateIsShared mentions TRUE and FALSE.
> - In arrayfuncs.c, ReadArrayStr, CopyArrayEls and ReadArrayBinary use TRUE.
Fixed the other ones.
--
Peter Eisentra
t;.
>> So I just added the end tag. Attached the update patch with the suggested
>> correction.
>
> Ah, I can see the warning as well. Using empty tags is forbidden since
> c29c5789, which is really recent. Sorry for missing it. Simon got
> trapped by that as well visibly.
g.
> Accordingly I propose the attached patch. If anyone's interested in
> experimenting on other platforms, we might be able to refine/complicate
> the FLUSH_DISTANCE selection further, but I think this is probably good
> enough for a first cut.
What is the status of this? Is
language
> function if you needed to. SQL has no flow control but I'm not too
> concerned about that.
I have already submitted a separate patch that addresses these questions.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote D
motivations for procedures is to do more complex and
expensive things including transaction control. So saving exception
overhead is not really on the priority list there.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & S
d.
I'll look for a place to add some documentation around this.
> Was surprised that pg_dump didn't use DROP ROUTINE, when appropriate.
It's not clear to me why that would be preferred.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
ly. That syntax is currently not available, but it should
not be hard to add.
I don't understand the point about wanting to return an int. How would
you pass that around, since there is no declared return type?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Dev
eating nonsensical reverse compilations
like CREATE FUNCTION RETURNS PROCEDURE. Catalog queries using
prorettype == 0 would behave sensibly by default. For example, an inner
or outer join against pg_type would automatically make sense.
--
Peter Eisentraut http://www.2ndQuadrant.com
On 10/29/17 08:50, Michael Paquier wrote:
> On Thu, Oct 26, 2017 at 9:25 AM, Peter Eisentraut
> wrote:
>> Here is an updated patch set. This is just a rebase of the previous
>> set, no substantial changes. Based on the discussion so far, I'm
>> proposing that 0001 t
variable, and some of them
> would end up having to cast away the const on their end.
OK, here is an updated patch with the controversial bits removed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote
l those results, so you'd need a
way to designate which ones, e.g.,
AS $$
SELECT set_config('something', 'value');
SELECT * FROM interesting_table; -- return only this one
SELECT set_config('something', 'oldvalue');
$$;
--
Peter Eisentraut
out statements, only about a command string that might
contain multiple commands. So I don't think anything would break.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mail
;s just that psql doesn't
print the non-last result sets.
We don't have any way to measure from psql how long each individual
result set took to compose. For that you will need deeper tools like
EXPLAIN ANALYZE and some way to process that data. That is way beyond
what \timing cu
On 11/2/17 19:52, Stephen Frost wrote:
> Uh, libpq doesn't actually have symbol versioning, at least not on the
> installed Ubuntu packages for PG10, as shown by objdump -T :
You're right, I was dreaming. But in any case, he would need symbol
versioning of libssl.
--
eSQL
> support downgrades?
no
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
cases where you have to
> cast away the const somewhere else. I realize that strtol has an ancient
> pedigree, but I do not think it's very good design.
Would you prefer leaving the input argument as char *, or change the
endptr argument to const as well?
--
Peter Eisentraut
e good if we could get it
> fixed in 10.1.
done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
hy it's not done that way is that this would not catch
errors of the command before the pipe.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq
e any way to avoid this deadlock?
I don't see a way to avoid it in general, unless we come up with a novel
way of creating replication slots.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via
s cooperation from various different parties, and the details
will likely be platform dependent. But it's generally a solved problem.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers m
a pretty complete patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/ma
?
> starting server anyway
> pg_ctl: could not read file "/tmp/pgsql/postmaster.opts"
>
> The attached patch changes the message to "trying to start server
> anyway" to highlight it is an attempt, not something that will happen.
committed
--
Peter Eisentraut
update the same.
I think those debug messages refer to the SQL name of the function, so
they look correct to me as is.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mai
On 9/15/17 00:20, Michael Paquier wrote:
> On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier
> wrote:
>> On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut wrote:
>>> passwordcheck: Add test suite
>>>
>>> Also improve one error message.
>>>
>&g
resource usage, it would probably be bad if a
wal_keep_segments setting papered over problems with replication slots
for example.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mail
g
patched around a bit recently. I have rewritten it a bit to make it
clearer.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make ch
ften use
>
> coalesce(current_setting(setting_name, true), default_value_here)
>
> as an implementation of current_setting() with a default value.
That appears to address this use case then. Do we need the new proposed
variant still?
--
Peter Eisentraut ht
On 10/3/17 12:31, Dang Minh Huong wrote:
> Sorry but please change "Huong Dangminh"(my name) to "Dang Minh Huong".
done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via
r in commit messages during
beta, which also makes some sense. So making the contributor list
fairly late and then not changing it much is more efficient.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent vi
Could someone clarify the status of this patch set? It has been in
"Waiting" mode since the previous CF and no new patch, just a few
questions from the author.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training
commit fest, so I'm closing the commit fest entry for now.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make change
On 11/1/17 10:29, Michael Paquier wrote:
> On Wed, Nov 1, 2017 at 2:24 PM, Peter Eisentraut
> wrote:
>> Committed to master. I suppose this should be backpatched?
>
> Thanks! Yes this should be back-patched.
OK, done for 10, 9.6, and 9.5.
The tablespace mapping feature star
explanation and warnings. But it's not
clear whether it's worth it given the existing alternatives.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (
t the right set of primitives might be to
address them.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
3669 +
+ innerTuples: 20 +
+ innerAllTheSame: 0+
+ leafPlaceholders: 569 +
+ innerPlaceholders: 0+
+ leafRedirects: 0+
+ innerRedirects:0+
+
This function should return a row with columns for each of these pieces
of informatio
uot; at the beginning.
Committed incorporating that suggestion.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
I suppose this should be backpatched?
(I changed the strcpy() to strlcpy() for better karma.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.
int result
but that would have a lot more overhead, potentially.
Thoughts?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 2e5d50cb39b926b29a6081f2387b95621357a4a0 Mon Sep 17 00:00:00 2001
From: Peter Eisen
cution context. I don't know if we have such a
thing yet or something that we could easily latch on to.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 1b3318154540d0fe71480ca58938433ecfccabbd Mon Sep
rhaps someone more familiar with postgres_fdw details can
check it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 097ecf61a9c2740b02a21be19a92aed92388346a Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
dling with this in the back branches. Maybe only the places where
the errors are not caught at all should be fixed there. Comments welcome.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training &
. In those cases, I added a cast or two.
Generally, I find these const decorations useful as easy function
documentation.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From a8163e84c83887e4a3b81642c13799593270
On 10/26/17 16:10, Tom Lane wrote:
> Peter Eisentraut writes:
>> On 10/16/17 03:19, Thomas Kellerer wrote:
>>> I don't know if this is intentional, but the Postgres 10 manual started to
>>> use lowercase IDs as anchors in the manual.
>
>> Here is a patc
On 10/27/17 04:06, Pavel Stehule wrote:
> Why buildin process has prefix bgworker?
Implementation detail. This has been changed in master already.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
S
can be applied to PG 10 to put the upper case
anchors back.
The question perhaps is whether we want to maintain this patch
indefinitely, or whether a clean break is better.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training &
quot;force_protocol_version" might be better. Other than that, no issues
with this concept.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postg
On 9/27/17 01:52, Michael Paquier wrote:
> I am marking the full set of patches as ready for committer.
All these patches have now been committed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
S
ease change the
whitespace to make it look best.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http:/
which exercises the
> non-NULL code path because slapd rejects TLS by default with a
> diagnostic message. I'm not sure if this is worth adding, since it
> doesn't actually verify that the code path is reached (though you can
> see that it is from the logs).
Committed.
--
Pet
attached patch accomplishes that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From f80e5aced1cedd2682fd50f6fa067bf455f66f4d Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 11 Oct 2017 18:35:19 -
on parsing.
I've been using
--with-extra-version=+git`date +%Y%m%d`"~"`git rev-parse --short HEAD`
for my local builds for some time, and I've not experienced any such
problems.
However, using the various numeric reporting options is clearly better
if you want to do ver
test lists. I
think we could just replace make installcheck with what make
installcheck-parallel MAX_CONNECTIONS=1 does. Thoughts?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers
g need to invent a new way to do that.
>
> Moving this to the next commitfest and bumping status to Ready for committer
> based on the discussion in this thread.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Train
this one probably will, too,
but at some point I feel we have to let it be for a while and take a
breather and get some feedback and field experience.
I'm available to discuss the changes you are envisioning, preferably one
at a time, in the near future as part of the PG11 development pro
On 9/30/17 03:01, Noah Misch wrote:
> On Mon, Sep 25, 2017 at 08:26:21AM +, Noah Misch wrote:
>> On Tue, Sep 19, 2017 at 07:01:47PM -0700, Peter Geoghegan wrote:
>>> On Tue, Sep 19, 2017 at 5:52 PM, Peter Eisentraut
>>> wrote:
>>>> On 9/18/17 18:46, Pe
;t do.
One reason for that is that the collation version also encodes things
like if the internal method for computing sort keys changes.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-h
ame behavior as before.
Arguably, you don't always want that. Maybe you selected a locale name
like 'en-NEWCOUNTRY', and in old ICU versions you want that to fall back
to default 'en' behavior and in newer you get the updated custom behavior.
--
Peter Eisentraut
On 9/29/17 19:38, Peter Geoghegan wrote:
> On Mon, Sep 25, 2017 at 11:40 AM, Peter Eisentraut
> wrote:
>> Reading over this code again, it is admittedly not quite clear why this
>> "canonicalization" is in there right now. I think it had something to
>> do with
ding? I have considered "Credits",
>> "Acknowledgements", "Thanks", but the first seemed better than the other
>> ones
> I prefer Acknowledgments.
Committed with those changes.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL
.." is less readable.
Yeah that is a bit ugly, but I have just moved existing code around.
I have now committed my patch with minor adjustments, so we have
something working for PG10.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
;> - KaiGai Kohei should be Kohei Kaigai.
>
> But his emails say Fujii Masao, not Masao Fujii.
>
> KaiGai's case is a bit trickier, as his email name has changed over time.
Yes, I used the form that the person used in their emails.
--
Peter Eisentraut http://ww
; - errmsg("terminating background worker \"%s\" due to administrator
> command",
> - MyBgworkerEntry->bgw_name)));
> + errmsg("terminating %s due to administrator command",
> + MyBgworkerEntry->bgw_ty
On 8/31/17 23:22, Michael Paquier wrote:
> On Fri, Sep 1, 2017 at 4:49 AM, Peter Eisentraut
> wrote:
>> On 5/30/17 23:10, Peter Eisentraut wrote:
>>> Here is a proposed solution that splits bgw_name into bgw_type and
>>> bgw_name_extra. bgw_type shows up in
On 9/22/17 15:31, Peter Eisentraut wrote:
> I suggest you create a patch that focuses on the --create part.
>
> You can create a separate follow-on patch for the --start part if you
> wish, but I think that that patch would be rejected.
I have moved this entry to the next commit fe
On 9/22/17 16:48, Peter Eisentraut wrote:
> On 9/19/17 19:00, Michael Paquier wrote:
>> On Wed, Sep 20, 2017 at 7:57 AM, Peter Eisentraut
>> wrote:
>>> To get things rolling, I have committed just the basic TAP tests, to
>>> give it a spin on the build farm.
ose.)
The list is sorted using COLLATE "en-x-icu".
Any thoughts?
[0]:
https://wiki.postgresql.org/wiki/PgCon_2017_Developer_Meeting#Release_notes_scope.2C_and_giving_credit
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Developm
tch. Feel free to send another patch if you want to
add more or different tests.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
on in pg_hba.conf and
> password_encryption are still here. "plain" is what has been removed.
More precisely, the ability to store passwords in plain text in
pg_authid has been removed. You can still use the authentication method
"password" that sends passwords in pla
-hashed passwords.
Pre-hashed passwords are the normal case. You can't break that without
making this module a net loss in security.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-h
fined anywhere. ICU converts the root collation to "und",
AFAIK, so it seems to agree with the current naming.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pg
tion is always going to have a
potential for problems. So I wouldn't spend a huge amount of effort
just to fix this specific case.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgs
rtunity to design a more useful sequence display that is
not merely hacked on to the general relation display.
This should be fixed for PG10, so if you have any feedback on the
design, please let me know soon.
Examples are in the attached patch.
--
Peter Eisentraut http://www.2ndQu
lopers.
But then background workers that are not updated for, say, PG11 will not
show anything useful in pg_stat_activity. We should have some amount of
backward compatibility here.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA,
o SHA-256,
for example. There is also the problem that the code as written will
turn any unrecognized hash method into SHA-256. If think the code
should single out MD5 and SHA-1 only and then use EVP_get_digestbynid()
for the rest. (I don't know anything about the details of OpenSSL APIs,
but tha
On 9/22/17 12:25, Peter Geoghegan wrote:
> On Fri, Sep 22, 2017 at 7:25 AM, Peter Eisentraut
> wrote:
>> I agree. The attached patch should do it.
>
> I see one small issue here: You'll now need to set ssup->comparator
> back to NULL before you return early in the W
ion and have enough information on how to put the new features
> into use.
>
>
>
> This looks good to me. Might suggest adding verifying the clients as a
> specific step:
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
Replacing mkdir() with
MakeDirectoryPerm() without any change in functionality doesn't really
improve clarity. Maybe we'll revisit that when your next patches arrive.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training
On 9/19/17 19:00, Michael Paquier wrote:
> On Wed, Sep 20, 2017 at 7:57 AM, Peter Eisentraut
> wrote:
>> To get things rolling, I have committed just the basic TAP tests, to
>> give it a spin on the build farm. I'll work through the rest in the
>> coming days.
I
t have SELECT FROM IF EXISTS, either.
I suggest you create a patch that focuses on the --create part.
You can create a separate follow-on patch for the --start part if you
wish, but I think that that patch would be rejected.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL De
and only.
So a per-command option might make more sense.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subsc
. If a worker is stopped and restarted in the
background as an implementation detail, then the user is not impacted.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql
wkward problems if
a future version of ICU establishes even more variants that will then be
preferred.
I think there is room for incremental refinement here. Features like
optionally checking or printing the canonical or preferred locale format
or making the locale description available via a functio
On 9/18/17 09:54, Peter Eisentraut wrote:
> On 9/16/17 08:10, David Steele wrote:
>>>> (5) drop contrib/chkpass altogether, on the grounds that it's too badly
>>>> designed, and too obsolete crypto-wise, to be useful or supportable.
>>> crypt() uses the 7
that this is normal.
Apparently, rmgr.c doesn't contain any instrumentable code. I don't see
this warning, but it might depend on tool versions and compiler options.
Note that rmgr.c doesn't show up here either:
https://coverage.postgresql.org/src/backend/access/transam/index.html
On 9/21/17 15:21, Peter Geoghegan wrote:
> On Thu, Sep 21, 2017 at 12:12 PM, Peter Eisentraut
> wrote:
>>> Attached patch shows what I'm getting at. This is untested, since I
>>> don't use Windows. Proceed with caution.
>>
>> Your analysis makes sens
On 9/21/17 17:38, Tom Lane wrote:
> Meanwhile, I see that Peter has posted a fix for the immediate problem.
> I propose that Peter should apply his fix in HEAD and v10, and then
done
> I'll rip out the !USE_WIDE_UPPER_LOWER code paths in HEAD only.
--
Peter Eisentraut
;m not sure that that's the case for all. So I'm a bit
> inclined to go with plan B, that is sync with their current HEAD now.
I suppose it might be good to do this after 10.0 final is wrapped?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Develop
> 'scram-sha-256' in postgresql.conf..."
I don't think there is a well-defined way of verifying whether all
client software supports it other than making the switch described and
then checking what breaks. So it's a bit of a circular process.
--
Peter Eisentraut
On 9/21/17 11:24, Dmitry Dolgov wrote:
> One last thing that I need to clarify. Initially there was an idea to
> minimize changes in `pg_type`
I see, but there is no value in that if it makes everything else more
complicated.
--
Peter Eisentraut http://www.2ndQuadra
our analysis makes sense, but the patch doesn't work, because "locale"
is never set before reading it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (p
--with-openssl ac_cv_func_towlower=no
>
> The result fails to compile:
Yeah, the placement of the ifdef blocks was pretty bogus. This patch
fixes it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Tra
anches in sync. I'm willing to do the code-sync work either way.
That makes sense. There is no urgency on the stdbool patch set, so
waiting for this to be resolved properly around November seems reasonable.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development
, this setting is
> common - what is not practical.
But you are proposing also to add a variable configuring the sort
direction. It would be weird that \dX+ observed the sort direction but
\dX did not.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x
ols ready to work with the new xlog/wal naming. If some
folks want to maintain such lists, that's great, but it's not a release
issue.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-
On 9/19/17 20:45, Peter Eisentraut wrote:
> On 9/19/17 17:55, Jeff Janes wrote:
>> I guess I'm late to the party, but I don't see why this is needed at
>> all. We encourage people to use any and all new features which are
>> appropriate to them--that is why we im
1 - 100 of 9053 matches
Mail list logo
